[00:22:38] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74525 [00:22:38] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73555 [00:38:15] New patchset: Jdlrobson; "Do not leave a gap on stub pages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74427 [00:38:51] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74427 [00:41:47] New patchset: Jdlrobson; "Story 920: Make upload tutorial screen have an upload and cancel button" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74526 [01:21:00] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74070 [01:27:58] Maryana: https://bugzilla.wikimedia.org/show_bug.cgi?id=51550 [01:34:42] New patchset: Jdlrobson; "Hide upload and edit for non JavaScript users" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74571 [01:40:50] New patchset: Jdlrobson; "Add event binding in initialize for PhotoUploaderPageActionButton" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74517 [01:40:58] New patchset: Jdlrobson; "Story 920: Make upload tutorial screen have an upload and cancel button" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74526 [01:41:12] New patchset: Jdlrobson; "Story 921: Adding editing tutorial" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74309 [01:50:53] New review: Jdlrobson; "Maryana says get rid of point" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/74309 [01:51:08] New review: Jdlrobson; "Cancel button incorrectly reads 'Got it'" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/74526 [02:59:45] [Commons-iOS] montehurd opened pull request #98: Dark splash images with fade to pic of day and logo animation. (master...splashUpdate) http://git.io/KClHyQ [11:24:51] prtksxna: https://bugzilla.wikimedia.org/show_bug.cgi?id=51676 [11:25:02] prtksxna: create a bugzilla account, and you can assign that to yourself [11:27:50] YuviPanda Does not let me edit it (I think) [11:28:00] prtksxna: you need to login. [11:28:12] Already did [11:28:19] prtksxna: what's your login email address? [11:28:33] The GMail one [11:28:47] I added myself to the CC List [11:29:45] prtksxna: I assigned. I think i'll need to grant you extra rights. let me poke people [11:29:51] andre__: can you grant prtksxna editbugs? [11:30:21] I get the edit fields now :D [11:31:08] prtksxna: :) [11:34:36] YuviPanda, yes yes yo! Done [11:34:41] andre__: ty :) [11:34:46] np [15:22:16] New patchset: MaxSem; "SkinMobile shouldn't call itself Minerva" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74630 [15:22:17] (PS1) MaxSem: SkinMobile shouldn't call itself Minerva [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74630 [15:23:19] lolrrit-wm, who the hell are you? [15:25:22] enough of this flood [15:25:25] MaxSem: ow, that's me [15:25:26] let me kill [15:25:44] MaxSem: that's going to replace gerrit-wm at some point. Chad asked me. [15:26:15] doesn't look very stable on your connection:) [15:26:25] MaxSem: no, I'm killing it and debugging as I go along [15:26:31] will run on toollabs [15:26:57] MaxSem: I do like its format better than gerrit-wm's current one tho :) [15:27:34] to me, it looks like a comment though [15:28:01] MaxSem: so comments have quotes, patchsets don't. It probably needs more tweaking though [15:28:13] that irritating (master) is now gone, at least (shows branches only if it is not master) [15:28:30] go on then:) [15:29:17] MaxSem: yeah, it's all done now. waiting for Chad to wake up so I can tweak some more. [15:29:27] timezones are irritating [15:47:46] New patchset: MaxSem; "Minor cleanup: unused vars, annotations" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74637 [16:11:30] good morning jdlrobson [16:11:36] mooorning MaxSem :) [17:17:44] Maryana: question - is showing the password to mobiletesttest in the user testing videos a good idea? [17:20:44] "I didn't know there were discussions about pages. I guess that's a beta feature too" [17:29:08] mhurd: design chat moved to Tuesday? [17:29:35] ya tomasz said to cancel for today, but tues doesn't work after all [17:29:43] brion and others are offsite [17:30:50] jdlrobson, yeah, heh, i guess i should change that pw. [17:31:05] mhurd: heh, okay. [17:35:33] New patchset: Jdlrobson; "Hygiene: Break the handshake" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74652 [17:38:39] YuviPanda: is 1pm our time too late for you for meeting on monday 29th? [17:40:08] tfinc: hey tomasz - couldn't find a slot next week where everyone was available - but monday 29th at 1pm was open if that works for yuvi [17:41:39] MaxSem: jdlrobson : is our deployment window still wed for next week ? [17:41:39] mhurd: no that works for me. [17:41:45] if so visual editor needs the slot [17:41:48] tfinc: yes [17:41:56] tfinc: Ryan Lane is on cache flush duty apparently [17:42:13] YuviPanda: awesome [17:44:22] jgonera - did you ever get to this bug? https://bugzilla.wikimedia.org/show_bug.cgi?id=44127 [17:44:27] i'm just going through & triaging [17:44:38] jdlrobson: there is a high chance that we'll have to move it as visual editor is getting priority. what other times work for us ? 11 looks open [17:44:56] tfinc: you'd have to check with MaxSem [17:45:03] earlier is better i'd guess [17:45:27] 11 AM PST? WFM [17:45:42] TLA TLA TLA [17:46:00] MaxSem: lets run with 11 then and see if ops is available for the cache flush [17:46:27] sure, poking Ryan now [17:46:31] New review: Jdlrobson; "SkinMobile should also be killed with fire and SkinMobileBeta renamed to SkinMinervaBeta etc.. :)" [mediawiki/extensions/MobileFrontend] (master) C: 2; - https://gerrit.wikimedia.org/r/74630 [17:46:48] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74630 [17:48:21] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74637 [17:49:15] jdlrobson, you working on this bug? https://mingle.corp.wikimedia.org/projects/mobile/cards/806 [17:49:31] Maryana: nope [17:49:35] why? [17:49:42] just triaging the bug backlog [17:49:50] is this a good candidate for code hygiene day? [17:49:58] if they're not assigned in bugzilla they're open [17:50:08] Maryana: yeh.. although a lot needs to be done beforehand i think [17:50:15] hmm, ok [17:50:26] i can just move it to a higher priority column in the backlog [17:50:31] tfinc, got a yes from Ryan [17:52:44] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74098 [17:53:07] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/73018 [17:53:17] Maryana: can you take a pass on https://docs.google.com/a/wikimedia.org/spreadsheet/ccc?key=0Aoizbfxc5g6KdEkza0xkQnJlM0o0TXlwQXhDOUFvYnc#gid=0 Roadmap [17:53:26] will do [17:59:14] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74571 [17:59:30] jdlrobson, can you rebase https://gerrit.wikimedia.org/r/#/c/71709/ ? [18:00:15] jgonera: sure not my biggest priority right now though since the Echo changes haven't happened yet [18:00:41] yes, but some other changes have happened already and as I told you, this CSS is dead anyway [18:00:42] jgonera - would this be worth fixing? https://bugzilla.wikimedia.org/show_bug.cgi?id=44264 [18:01:15] Maryana, at some point definitely ;) it's not urgent though [18:01:41] k - i was thinking that while everyone's at wikimania, we could have some bugs loaded up for you all to work on [18:01:45] rather than a full iteration [18:01:57] it's not going to make sense to try to do story work when everyone's traveling [18:02:22] jgonera: sure.. but i'm currently busy looking at our ResourceLoader module which i think is much more important :) [18:02:46] jdlrobson, ok, sure, it's not urgent, whenever you find a moment [18:02:59] New patchset: Jdlrobson; "Story 920: Make upload tutorial screen have an upload and cancel button" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74526 [18:03:45] New patchset: JGonera; "Add event binding in initialize for PhotoUploaderPageActionButton" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74517 [18:04:55] New patchset: JGonera; "Add event binding in initialize for PhotoUploaderPageActionButton" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74517 [18:06:45] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74517 [18:14:50] New patchset: JGonera; "Hygiene: Break the handshake" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74652 [18:16:18] jgonera, are you just focusing on android useragents in your current digging through the squid logs? [18:16:58] Maryana, no, I have a list of all Browsers + major version from a single day in June, I'll generate something from a week and publish it [18:17:48] sweet. we're just looking at a nokia bug and wondering how many symbian users we actually have.. [18:28:31] New review: JGonera; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/74526 [18:30:21] Maryana, the bug about invisible icons? [18:30:34] yep [18:31:09] Maryana: nada on offices for today [18:31:23] so should we just try for our standup space? [18:31:23] blah [18:31:27] yeah, that'll work [18:31:38] that will push us to do it quickly :) [18:31:45] hehe [18:31:46] yup incentive :D [18:49:41] New patchset: Jdlrobson; "Hygiene: Break the handshake" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74652 [18:50:31] Change merged: jenkins-bot; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74652 [18:54:23] [Commons-iOS] montehurd opened pull request #99: Fixed pic of day description parsing crash. (master...potdCrash) http://git.io/wP-Btw [19:01:16] New patchset: MaxSem; "Simplify opt-in cookies" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74667 [19:04:10] tfinc: patched the crashing bug i'd mentioned. heading to the local urgent care clinic, taking the laptop in case the wait extends beyond the lunch hour [19:04:21] mhurd: get better and rest up [19:04:42] tfinc: will do! so ready to be over this! [19:32:16] New review: Jdlrobson; "Anyway we could also just use the one cookie 'optin' ?" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74667 [19:32:43] tfinc: Maryana R34 and R35 are available… which one is the best one to pick? [19:33:01] do r34 [19:33:05] i have yet to test r35 [19:33:19] k done [19:35:00] New review: MaxSem; "That's what this patch does:P" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74667 [19:39:54] MaxSem: sorry MaxSem I stupidly missed your deprecation notice.. [19:40:18] another proof that b/c sucks! XD [19:41:24] MaxSem: add tests though… this is an important part of MobileFrontend [19:42:57] New review: Jdlrobson; "If i understand correctly the cookie value will be either beta or alpha?" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/74667 [19:44:29] just changing room for the kickoff meeting… brb [19:45:53] New review: MaxSem; "1) Yes, and no cckie if stable." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74667 [19:57:45] New review: Jdlrobson; "(1 comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/74526 [20:31:26] ergg the ResourceLoader module stuff is proving to be a pain in debug mode :( [20:33:55] ^ jgonera i'm now remembering why we have plumbing and combon [20:33:58] *common [20:36:14] hm [20:36:20] a pain why? [20:37:14] well in debug mode apparently getScriptFiles [20:37:15] is called [20:37:31] mw.loader.implement( "mobile.stable.common", [], {}, {} ) is constructed [20:37:36] where the array is a list of files [20:37:54] since there is no file for templates there is no way to get the template code to run... [20:38:40] only way i can see us doing it is disabling debug mode... [20:59:00] (PS1) Jdlrobson: Allow MFResourceLoaderModule to handle files [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74684 [20:59:02] ^ jgonera :-/ [20:59:21] (CR) jenkins-bot: [V: -1] Allow MFResourceLoaderModule to handle files [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74684 [21:00:12] jdlrobson: new gerrit-wm being deployed now, might be slightly wonly for a bit. but more readable format! :) [21:11:37] (PS1) Jdlrobson: Remove unnecessary closure [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74689 [21:11:38] (PS1) Jdlrobson: Hygiene: Remove M.prefix [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74690 [21:12:36] jgonera: i'm going to remove the mf prefix from all our javascript and css - will you merge if i do so? [21:17:19] jgonera: ? [21:19:15] mmm irc is quiet today [21:19:27] Maryana: any sign of ju ju? [21:45:03] jgonera: juuujuuu [21:46:59] tfinc: YuviPanda: back from dr. yay! [21:47:05] mhurd: feeling better? [21:47:06] mhurd: how are you feeling ? [21:49:06] tfinc: YuviPanda: was good to get some fresh air. picked up prescription so sinus infect should be handled soon :) [21:49:32] feeling 'bout the same otherwise [21:54:54] YuviPanda: seen brion here today? [21:55:00] mhurd: hmm, nope [21:55:03] mhurd: rest up :) [21:55:22] YuviPanda: will do :) he's prob dealing with moving stuff [21:56:47] jdlrobson: What is this "new asset" you refer to? [21:56:51] https://gerrit.wikimedia.org/r/#/c/74309/ [21:57:02] kaldari: the image on the tutorial is for uploads... [21:57:16] also kaldari any sign of jgonera been needing him for a good hour now.. [21:57:31] I was wondering where both of you were :) [21:58:04] jdlrobson: I'm still not sure what you mean by needing a new asset though [21:58:19] tfinc: what's kenan's irc name? i forgot to say hi and welcome at the standup! [21:58:29] The final mock-up for the editing tutorial doesn't have a tutorial graphic [21:58:33] mhurd: Maryana --^ [21:59:20] jdlrobson, I'm here [21:59:32] sweet need your help with a big refactor jgonera [21:59:41] kaldari: so.. [21:59:55] when the editor overlay shows it shows some copy text and a cancel button and a start editing button [21:59:59] above that is an image [22:00:05] that image describes photo uploading not editing.. [22:00:15] that is the asset i am referring to :) [22:00:59] ah, so you mean that needs to be changed to be separate from the regular background [22:01:15] yup [22:01:18] (PS1) Jdlrobson: Hygiene: Standardise file names [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74797 (owner: Jdlrobson) [22:01:21] got it [22:01:24] kaldari: should be specific to editing [22:01:33] jdlrobson, ok, what do you need me for in the big refactor? ;) [22:01:34] jgonera: ^ weirdness - this refactor surfaces a bug [22:01:43] it looks like the learn more overlay bug [22:01:47] renaming files surfaces a bug? [22:01:59] also certain tests don't seem to be running.. [22:02:20] "Remove unused references and random" ? [22:02:28] (CR) Jdlrobson: [C: -2] "QUnit is failing. any ideas why?" [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74797 (owner: Jdlrobson) [22:04:06] I don't see anything failing [22:04:12] but there's definitely too few tests [22:04:39] jgonera: agreed [22:04:43] not sure what is going on.. [22:05:01] (this is where the auto create test module is a pain :)) [22:05:34] (PS2) Jdlrobson: Hygiene: Standardise file names [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74797 (owner: Jdlrobson) [22:05:54] well, let's just debug the hook [22:05:57] give me a few minutes [22:08:00] the weird thing is if i look at the test modules running they are the same... [22:08:50] ahh got it [22:08:51] i think [22:09:10] ^ jgonera [22:09:29] i notice there are some lowercase / uppercase differences [22:11:19] the names must match [22:11:29] [name] -> test_[name] [22:12:07] yup [22:12:14] so i've got 291 tests now [22:12:19] (still one failing though which is weird) [22:12:25] Test failed: MobileFrontend: Overlay.js: Stacked overlays [22:12:25] Failed assertion: The second overlay is the active one, expected: true, but was: false [22:13:20] well jdlrobson, seems you renamed files in Resources.php but you haven't renamed the files... [22:13:26] hm [22:13:32] ? [22:13:34] can you push the new patchset? [22:13:39] which ones? [22:13:57] you renamed to Carousel.js in Resources.php, but the file is still called carousel.js [22:14:33] (PS3) Jdlrobson: Hygiene: Standardise file names [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74797 (owner: Jdlrobson) [22:14:41] jgonera: not for me… [22:14:59] * jdlrobson wonders if the case is being ignored [22:15:32] jgonera: it's definitely Carousel.js and test_Carousel.js here.. [22:15:34] I can see it at https://gerrit.wikimedia.org/r/#/c/74797 [22:15:54] ok, let me pull again [22:16:03] so exact same tests are running for me [22:16:09] only 1 fails with the refactor! [22:16:14] nope, jdlrobson, still lowercase [22:16:19] was lowercase and still is [22:16:22] jgonera: try renaming it yourself [22:16:28] and see if you're able to commit it [22:16:39] my command line is telling me there are no unstaged changes [22:16:55] weird [22:17:23] I checked out the latest patchset, no MobileFrontend tests run for me [22:19:05] wadddd? [22:19:10] wtf.. [22:19:26] jgonera: are you sure you are not caching? [22:19:45] pretty sure [22:21:30] soooo weird [22:21:39] ok i think i have the rename working [22:21:44] (PS4) Jdlrobson: Hygiene: Standardise file names [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74797 (owner: Jdlrobson) [22:21:47] had to change it to foo.js [22:21:50] and then change it again [22:22:02] weird, you must have some superold version of git or something [22:22:12] yup seems to have worked [22:22:23] can you try the tests in a browser instead? [22:23:01] (CR) Jdlrobson: [C: -1] "-1ing just to get your attention and an answer :)" [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74637 (owner: MaxSem) [22:23:13] the only test that runs for me is MobileFrontend: mobilediff.js [22:23:28] I tried both browser and phantomjs [22:23:32] i'm so confused. [22:23:43] jgonera: can you check your php log [22:23:47] maybe something odd is happening there [22:23:57] sounds like something is 404ing for you [22:24:00] maybe another rename issue [22:24:10] PHP log? I don't think so, it would show me the error in the browser [22:24:16] well then Chrome console would tell me [22:24:21] no.. ResourceLoader [22:24:36] it sometimes adds comments at the top of files saying it can't find things [22:24:56] I enabled debug mode, now I get lots of JS errors [22:25:35] jgonera: lots? [22:25:40] i'm still only getting one.. [22:25:50] errors in JS console [22:28:17] (PS1) Kaldari: Beginning some CSS clean-up [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74801 (owner: Kaldari) [22:28:41] (PS2) MaxSem: Minor cleanup: unused vars, annotations [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74637 (owner: MaxSem) [22:29:22] jdlrobson, for some reason, it's trying to request EventEmitter.js but the file is called eventemitter.js... [22:29:56] (CR) MaxSem: "Blergh, this special pagee is weird, execute() is not supposed to return anything yet it returns values for the sake of testing. Just back" [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74637 (owner: MaxSem) [22:30:11] jgonera: sigh [22:30:16] so must be something odd with my git [22:30:20] jdlrobson, same for page.js [22:30:25] jgonera: can you rename them on yours? [22:30:38] guess it's a mac/unix thing [22:30:38] and probably for everything where you tried to change the name to uppercase [22:30:42] I can [22:30:49] what version of git do you have? [22:30:52] jgonera: this is what's weird - all files have been renamed on mine but git is ignoring it [22:31:20] it's old [22:31:20] git version 1.7.7.5 (Apple Git-26) [22:31:21] jdlrobson, I could only understand such behavior on Windows [22:31:30] try updating [22:31:34] am doing so now [22:31:52] still.. the test is still failing for me which is weird [22:34:50] jgonera: still no luck with latest git.. :/ [22:35:21] http://stackoverflow.com/questions/5793663/letting-git-know-that-a-file-was-renamed-os-x-file-renamed-from-lowercase-to-u (PS5) JGonera: Hygiene: Standardise file names [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74797 (owner: Jdlrobson) [22:35:46] there we go.. [22:35:55] ^ still 12 tests missing an 1 failing [22:35:58] jgonera: problem fixed gitconfig was being told to ignore case [22:36:07] kenanwang: hey kenan! it's monte from the apps standup this morning. welcome! [22:37:00] (PS6) Jdlrobson: Hygiene: Standardise file names [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74797 (owner: Jdlrobson) [22:37:00] ^ jgonera only 1 failing for me here [22:37:06] yes, that's what I said [22:37:09] + 12 missing [22:37:14] comparing to what runs on master [22:37:23] 279 vs 291 [22:38:28] 291 are running for me jgonera [22:38:41] then I guess I haven't renamed everything [22:38:59] can you just discard what you have and pull my patchset from gerrit and see how many run for you? [22:39:04] something odd happening with overlays [22:39:46] and if that doesn't help us, I can just do the renaming from scratch because looking for what's missing is going to take more time [22:41:34] whenever i try and check yours out it's complaining that files are going to be overwritten [22:41:38] no idea wtf is going on here [22:42:02] well, I really can't help you with that, never had any issues like that [22:43:03] can you check the following files in your patchset [22:43:56] yeh jgonera i can't check yours out at all [22:44:07] some really weird lowercase/uppercase problems going on [22:45:12] following files? [22:46:23] ok finally checked yours out [22:46:37] yeh so now seeing less tests on your patchset [22:47:24] test_Carousel.js seems to have disappeared? [22:51:03] uh, you pushed two new patchsets now? what have you changed? [22:51:14] well jgonera my latest patch set runs all the tests for me. [22:51:23] my latest patch too [22:51:24] it just has a failure on test_Overlay.js [22:51:31] jgonera: yours doesn't for me.. [22:51:34] you just added test_Carousel? [22:51:40] I just pushed it [22:51:41] (PS7) JGonera: Hygiene: Standardise file names [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74797 (owner: Jdlrobson) [22:51:47] there you go... [22:52:17] jgonera: it doesn't for me [22:52:26] well.. it does in normal mode [22:52:28] not debug mode [22:52:42] patchset 7? [22:52:59] * jdlrobson now very very very confused [22:53:13] so yeh your patch set 7 Took 373ms to run 194 tests. 193 passed, 1 failed. [22:54:11] * exception 'MWException' with message 'ResourceLoaderFileModule::readScriptFiles: script file not found: "/Users/jrobson/Sites/w/extensions/MobileFrontend/javascripts/modules/search/pageImages.js"' in [22:54:38] page images went walkies it seems [22:55:01] no it didnt! [22:55:02] [22:55:02] javascripts/modules/search/pageImages.js [22:55:02] renamed from javascripts/modules/search-pageimages.js [22:55:07] that's what gerrit says [22:55:19] your git must be completely messed up... [22:56:06] it's not there for me.. [22:56:57] i'm going to reboot and see if this makes any differnce [23:00:32] jgonera: still same problem [23:00:36] so for you do all tests pass? [23:00:47] jdlrobson, this commit is messed up anyway [23:00:48] no [23:00:53] CSS got corrupted [23:00:56] e.g. https://gerrit.wikimedia.org/r/#/c/74797/7/less/common/common-js.less [23:01:06] changes that have nothing to do with that commit [23:01:12] wtf... [23:01:32] you want to have a go at it? [23:01:47] i'm really keen to get this done as it's so confusing in the current state [23:02:07] the thing that is weird is it says [23:02:10] "error: The following untracked working tree files would be overwritten by checkout: [23:02:11] javascripts/widgets/carousel.js [23:02:11] " [23:02:12] i don't have that file [23:02:20] I have rm javascripts/widgets/Carousel.js [23:02:26] in particular this break overlays I'd say: https://gerrit.wikimedia.org/r/#/c/74797/7/less/common/overlays.less [23:03:04] some bad rebase or something, although it's like that since patchset 1 [23:04:35] can we do it after deployment? I'm not willing to fight with this commit... [23:04:46] and definitely, let's split it into more commits [23:04:49] gradually [23:04:58] at least JS and LESS separately [23:05:22] okkki i just worry it will never get dsone [23:05:27] i've wasted 3 hrs with this today.. [23:05:32] also jgonera before doing so... https://gerrit.wikimedia.org/r/#/c/74690/ [23:05:38] https://gerrit.wikimedia.org/r/#/c/74689/ [23:05:53] (CR) Jdlrobson: [C: -2] "This completely breaks the navigation menu.. (try clicking the hamburger button on the left)" [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74801 (owner: Kaldari) [23:06:24] (CR) JGonera: [C: 2] Remove unnecessary closure [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74689 (owner: Jdlrobson) [23:06:44] (Merged) jenkins-bot: Remove unnecessary closure [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74689 (owner: Jdlrobson) [23:07:12] jdlrobson, I'd rather do it when we both + kaldari are in the office, we sit, spend half an hour on it without anyone doing anything else (to avoid conflicts) and be done with it [23:08:07] (CR) JGonera: [C: 2] Hygiene: Remove M.prefix [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74690 (owner: Jdlrobson) [23:08:40] (Merged) jenkins-bot: Hygiene: Remove M.prefix [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74690 (owner: Jdlrobson) [23:10:37] jdlrobson, on the bright side, that showed us that our tests are worth something ;) [23:10:55] makes me very very sad :( [23:11:07] i might just do a small commit to remove the mf- prefix [23:13:25] (CR) Kaldari: "Ah, I was only looking at it in Beta. I didn't realize there were significant layout differences between the two." [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74801 (owner: Kaldari) [23:14:04] lolrrit-wm? [23:14:11] lolwut? [23:14:19] * YuviPanda 's work, that :) [23:14:23] Maryana: no more gerrit-wm :) [23:14:50] tsk [23:15:53] Maryana: you don't like it? We're wondering if we should change it back to gerrit-wm :) [23:15:57] the code was rewritten, etc [23:16:10] it's just kind of a mouthful [23:16:23] Maryana: loling is a mouthful, yeah :) [23:16:54] Maryana: the nick gerrit-wm had troubles talking in the -operations channel due to some trouble with IRC nodes, so it is this for now [23:17:03] jgonera: the weird thing in on master: Took 458ms to run 291 tests. 291 passed, 0 failed. [23:17:23] this is less tests than on the other branch making me think some tests are not loading.. [23:17:49] yuvipanda, i think grrrit-wm would be better :) [23:17:55] hahaha :D [23:18:03] on what branch? I never had more than that [23:18:03] gerrit rarely makes me lol, but often makes me grr [23:18:19] no? mm [23:18:22] (PS1) Jdlrobson: Hygiene: Remove another unnecessary closure [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74809 (owner: Jdlrobson) [23:18:23] (PS1) Jdlrobson: Hygiene: Remove dead test [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74810 (owner: Jdlrobson) [23:18:24] (PS1) Jdlrobson: Hygiene: Remove dead css [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74811 (owner: Jdlrobson) [23:18:25] (PS1) Jdlrobson: Hygiene: Rename mf-view.js to View.js [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74812 (owner: Jdlrobson) [23:18:28] anyway.. jgonera more hygiene fixes ^ small ones [23:18:45] Maryana: i'll change it to that at some point :) [23:19:01] kaldari, can you have a look at those? [23:19:03] i will also accept screwit-wm [23:19:17] :D [23:19:18] (PS7) Jdlrobson: Story 920: Make upload tutorial screen have an upload and cancel button [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74526 (owner: Jdlrobson) [23:19:47]