[00:01:21] marktraceur: running low on energy - gonna have to pass on climb tonight. hopefully climb tomorrow! [00:01:35] mhurd: I meant tomorrow actually- [00:01:48] marktraceur: haha doh! [00:01:50] This is the problem with sign language between two people who don't know sign language [00:01:53] lol [00:01:59] mhurd: Eloquence and MissGayle are coming tomorrow [00:02:01] Mission Cliffs [00:02:20] marktraceur: i heard! [00:02:27] marktraceur: awesome [00:08:16] (PS1) Plavi: QA: Remove page-object gem deprecation warnings [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/75818 [00:16:48] I got the info from Hampton [00:16:55] weee [00:17:03] it's iOS 7 on iphone 5 using Chrome [00:17:22] the dang apple site is down and I need to upgrade my Xcode then I'll test itout [00:17:54] jdlrobson: ^^ [00:18:35] jcmish: i've seen it on my phone - chrome android [00:18:40] i don't think it is browser specific [00:18:43] oh cool [00:18:47] can you repro? [00:18:50] not all the time [00:18:51] or is it dodgy? [00:18:55] argh :( [00:19:09] I can't get it to happen on chrome on my 4s [00:20:36] I'll keep poking around jdlrobson to see if I can find a consistent scenario [00:45:48] YuviPanda: you there? [00:46:01] i want to install limn on mac but am failing miserably [00:47:21] [Commons-iOS] montehurd opened pull request #106: Made pic of day attribution handle license not retrieved. (master...licenseNotFound) http://git.io/JcDLyA [00:59:59] (CR) Mgrover: [C: 2] "pulled it down and tested as well as reviewed allis well" [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/72895 (owner: Mgrover) [01:00:13] [Commons-iOS] montehurd opened pull request #107: Made alpha of settings controls more consistent. (master...settingsStyle) http://git.io/QEZUTg [01:00:18] (Merged) jenkins-bot: QA: New Automation test Menu urls for bug 51078 [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/72895 (owner: Mgrover) [01:08:14] (CR) Mgrover: [C: 2] "Reviewed and pulled down to test. Looks good so +2'ing" [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/75818 (owner: Plavi) [01:08:32] (Merged) jenkins-bot: QA: Remove page-object gem deprecation warnings [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/75818 (owner: Plavi) [01:26:13] (PS1) Kaldari: Adding 'thank' link to MobileDiff view [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/75822 [01:26:33] (CR) jenkins-bot: [V: -1] Adding 'thank' link to MobileDiff view [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/75822 (owner: Kaldari) [01:29:01] (PS2) Kaldari: Adding 'thank' link to MobileDiff view [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/75822 [01:29:21] (CR) jenkins-bot: [V: -1] Adding 'thank' link to MobileDiff view [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/75822 (owner: Kaldari) [15:24:03] hi YuviPanda [15:24:41] why the files i committed yesterday not appear in the repo? [15:24:50] orsa: where? [15:24:56] https://git.wikimedia.org/tree/apps%2Fandroid%2Ftranslate.git [15:25:38] orsa: https://git.wikimedia.org/tree/apps%2Fandroid%2Ftranslate.git/a171f74020e0ec057e319448625e05aa9bf2216e/translatewiki%2Fsrc%2Fmain%2Fjava%2Fcom%2Ftranslatewiki%2Fapp [15:25:39] is there more? [15:25:44] orsa: did you use 'git add' to add the new files? [15:26:08] sure appear as "reviewd" here https://gerrit.wikimedia.org/r/#/c/75646/ [15:26:36] ahh ok no i see it [15:26:42] now i see it [15:27:32] orsa: :) [15:29:32] YuviPanda: why when i click on my link it does not show the updated tree? [15:29:50] orsa: gerrit doesn't let you see current code [15:29:54] only code as it was commited [15:29:59] use git.wikimedia.org to browse [15:33:31] ok if theres no other choice [15:37:31] @notify jcmish [15:37:31] I'll let you know when I see jcmish around here [16:12:00] (PS1) Cmcmahon: Forgot to tell the test to visit a page, Jenkins builds need this [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/75896 [16:12:17] (CR) Cmcmahon: [C: 2] Forgot to tell the test to visit a page, Jenkins builds need this [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/75896 (owner: Cmcmahon) [16:14:23] (Merged) jenkins-bot: Forgot to tell the test to visit a page, Jenkins builds need this [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/75896 (owner: Cmcmahon) [16:29:23] YuviPanda: git is wierd.. it says i "have more than one commit im about to submit" [16:29:54] even though i submitted the other one [16:36:40] aharoni: i guess you're familiar with thad kind of issues [16:37:16] orsa, just answer yes [16:38:49] thanks MaxSem, just want to make sure i wont get into troubles.. :) [16:42:26] orsa: you can do 'git fetch gerrit' before to see if that fixes :) [16:42:42] what YuviPanda said [16:43:57] thank YuviPanda [17:01:34] yurik, just got on the Google Hangout [17:01:44] yurik, you able to see us? [17:05:01] yurik, i'm going to sign out of my google id and then dfoy will try [17:10:15] yurik, you there? [17:11:43] (PS3) Kaldari: Adding 'thank' link to MobileDiff view [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/75822 [17:14:14] (PS1) MaxSem: Headers refactoring [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/75911 [17:14:39] (CR) jenkins-bot: [V: -1] Headers refactoring [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/75911 (owner: MaxSem) [17:26:58] hey mhurd [17:27:02] iOS release today? :D [17:27:06] YuviPanda: hey! [17:27:21] YuviPanda: aiming for tomorrow :) [17:27:45] YuviPanda: have a couple of last minute patches i'm trying to sneak in [17:27:52] nice [17:28:35] YuviPanda: looks like itunesconnect is online [17:28:40] whee [17:30:00] (CR) Kaldari: [C: -1] "(1 comment)" [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74667 (owner: MaxSem) [17:34:40] (CR) Kaldari: [C: -1] "Need to update ExtMobileFrontendTest::testSendHeaders in MobileFrontendTest.php per Jenkins." [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/75911 (owner: MaxSem) [18:02:11] (PS2) MaxSem: Headers refactoring [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/75911 [18:07:20] (CR) Jdlrobson: [C: -1] "(12 comments)" [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/75822 (owner: Kaldari) [18:07:47] (CR) Jdlrobson: "Also make it clear in commit message the Thank extension is needed as an optional dependency" [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/75822 (owner: Kaldari) [18:08:54] (CR) Jdlrobson: [C: -2] "Currently discussing on email best way forward." [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74922 (owner: Pcc) [18:09:57] (CR) Kaldari: [C: -1] "(2 comments)" [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74922 (owner: Pcc) [18:11:19] (CR) Kaldari: "Sorry, I meant user option, not user preference." [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74922 (owner: Pcc) [18:17:11] (CR) Kaldari: "Hmm, actually it looks like all the mobile settings are just cookies, so nevermind." [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74922 (owner: Pcc) [18:27:37] (CR) Kaldari: [C: 2] Headers refactoring [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/75911 (owner: MaxSem) [18:27:56] (Merged) jenkins-bot: Headers refactoring [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/75911 (owner: MaxSem) [18:31:18] MaxSem: edit tags are horribly broken - any idea why [18:31:31] horribly? [18:32:14] yup they are not reflecting what is going on in event logging.. [18:32:21] none of juliusz's edits are showing up for example [18:32:27] i found an edit tagged visual editor as well.. [18:32:42] (PS3) MaxSem: Simplify opt-in cookies [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74667 [18:56:08] Maryana, this looks outdated: http://en.wikipedia.org/wiki/Wikipedia:Editing_on_mobile_devices [18:58:05] jdlrobson, digging through this... [18:58:15] MaxSem: thanks :) [18:58:23] test edit on mw.o was properly tagged [18:58:42] however, on testwiki 2 of them weren't [18:59:15] and know what? these POSTs returned 503s even though the edits were saved [19:57:43] hey tfinc. anything from brion? [19:57:51] I don't see him on chat either [19:58:18] YuviNoPower: don't know. I got here at noon and went direct to the travel brown bag [19:58:21] i'll text him [19:58:26] tfinc: ok [19:59:32] YuviNoPower: text sent [19:59:35] tfinc: ty. [19:59:50] tfinc: I'll probably be out in 30 mins, will email him with CR requests [19:59:54] k [20:01:26] YuviNoPower, you still there? [20:01:30] jgonera: yup [20:19:08] YuviNoPower: https://twitter.com/whywhywhy50/status/360493489915576320 [20:19:27] not clicking that, jdlrobson. [20:19:36] :) [20:19:39] YuviNoPower: it's about the app [20:19:41] they want random [20:19:53] specifically asking about you [20:20:19] ah :) [20:20:39] jdlrobson: yeah, I no longer use twitter. please tell him we'll build an *actual* app in about 6 months or so :) [20:22:26] jdlrobson, seen my comments ^^^ ? [20:22:41] MaxSem: last i saw was and know what? these POSTs returned 503s even though the edits were saved [20:22:53] yup, that's it [20:23:25] mm [20:23:37] not sure what's causing that.. :/ [20:24:56] anything, including an OOM [20:35:12] (CR) Kaldari: "(5 comments)" [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/75822 (owner: Kaldari) [20:45:53] jdlrobson: added some comments to your comments, if you want to discuss in real time, lemme know :) [20:53:52] kaldari: will take a look in a bit [20:55:35] jdlrobson, dug through logs, found an unrelated problem, but no indication of what's wrong with testwiki editing:/ [21:39:45] kaldari or jdlrobson do you have the typography changes available in a form that we can try as personal CSS? [21:40:13] (The git diff Jon linked to obvs includes removed portions as well as added so it's work to cut/paste that in.) [21:52:11] StevenW: no way to have an exact duplicate :/ [21:52:40] i suppose you could take all the added bits and make all the rules !important but it wouldn't be exactly the same.. [22:02:39] jdlrobson: ok [22:02:48] can we set it up on one of our Labs instances? [22:03:05] piramido.wmflabs.org [22:03:07] ? [22:13:25] Also: other tagging errors are being reported (https://en.wikipedia.org/wiki/Wikipedia_talk:Tags#Incorrect_tagging) [22:13:37] Not sure if it's related to mobile's problem or not. [22:13:55] I checked GettingStarted + VE tagging yesterday and all seemed well, but not sure about all tags. [22:18:10] YuviPanda, we'll be roommates @ Wikimania:) [22:22:27] (PS1) MaxSem: Get rid of $wgExtMobileFrontend [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/76023 [22:23:48] party in maxsem and yuvipanda's room! [22:23:57] bring cognac :) [22:24:05] I hate cognac [22:24:08] aww [22:24:13] ok ok, bring vodka [22:24:17] (i hate vodka) [22:35:36] (PS1) Jdlrobson: Hygiene: Make it clearer where mobilediff code runs [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/76024 [22:35:37] (PS1) Jdlrobson: Story 986: Log watchlist interactions [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/76025 [22:37:45] kenanwang: http://stats.wikimedia.org/wikimedia/squids/SquidReportUserAgents.htm [22:39:13] (PS2) Jdlrobson: Story 986: Log watchlist interactions [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/76025 [22:44:18] [Commons-iOS] montehurd opened pull request #108: Reduced app binary size by optimizing bundled images. (master...optimizeImages) http://git.io/ZV-HlQ [23:05:10] jdlrobson: https://bugzilla.wikimedia.org/show_bug.cgi?id=48730 would that be something we would do or commons? [23:15:03] jcmish: we need to update our formatter [23:15:10] YuviPanda: limn is annoying. sort it out. [23:15:20] * limn generator script [23:15:42] k thanks jdlrobson [23:29:38] grr flickr is down [23:49:45] MaxSem: you still there? [23:49:59] yup [23:50:12] so we found out why edits are not being tagged.. [23:50:59] grep FIXME -r includes/MobileContext.php < MaxSem [23:53:41] nice [23:55:08] (PS1) Jdlrobson: Re-enable mobile edit tagging [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/76043 [23:55:20] So we're deploying MaxSem .. [23:55:28] (CR) jenkins-bot: [V: -1] Re-enable mobile edit tagging [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/76043 (owner: Jdlrobson) [23:56:18] too late for today or this week... [23:56:21] MaxSem: ori-l can deploy [23:56:36] (PS2) Jdlrobson: Re-enable mobile edit tagging [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/76043 [23:56:38] bsitu is currently scapping [23:56:56] MaxSem: ori-l says we can do it after [23:56:57] MaxSem: I got the OK from greg in person [23:57:03] ah [23:57:11] I can deploy myself then [23:57:17] thanks :) [23:57:30] (if I'll not fall asleep by then) [23:57:42] I would have asked him online so that the conversation is public but we literally had to chase him as he was trying to exit the building :D [23:58:08] jdlrobson, you need to fix tests [23:58:42] MaxSem: i have [23:58:44] ah, you already did [23:59:05] (CR) MaxSem: [C: 2] Re-enable mobile edit tagging [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/76043 (owner: Jdlrobson) [23:59:23] (Merged) jenkins-bot: Re-enable mobile edit tagging [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/76043 (owner: Jdlrobson)