[00:00:55] (PS1) MaxSem: Re-enable mobile edit tagging [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/76044 [00:01:01] (CR) MaxSem: [C: 2] Re-enable mobile edit tagging [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/76044 (owner: MaxSem) [00:01:22] (Merged) jenkins-bot: Re-enable mobile edit tagging [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/76044 (owner: MaxSem) [00:17:06] jdlrobson, deployed [00:17:14] thanks MaxSem ! [00:18:27] Seems to work Max :D [00:18:47] Well done MaxSem [00:18:54] wee [00:18:57] \o/ [00:21:04] mhurd_: i'm going to start winding down [00:22:10] tfinc: likewise [02:43:32] hello. I am trying to find the correct place to report an error in the mobile rendering. [02:43:51] https://en.m.wikipedia.org/wiki/List_of_chocolate_bar_brands [02:44:20] * T13 feels like a traffic controler at an airport sometimes... [02:44:44] the list of chocalate bars only displays one row of the table on the iphone (ios 6.whatever) and the same behavior on firefox and google chrome when I veiw the mobile page on my computer [02:45:10] I imagine andre__ feels the same sometimes. :p [02:46:35] dfc: if you gp tp that row, and tap once to focus on it, can you make it scroll through the rows? [02:47:06] * dfc pulls phone out [02:48:13] nothing happens [02:48:15] * T13 just checked and can do on Galaxy S3 [02:48:23] just the one row for the three musketeers [02:48:46] T13: what happens if you load the page on your computer with the en.m URL [02:48:56] Tap to grab the header row and drag it across. [02:49:34] Then, you should be able to grab and scroll up/down left/right [02:50:10] I don't have access to a computer right now. [02:50:35] okay. i tried it on the iphone and cant get the scroll bar [02:50:54] can i rest easier now knowing i reported this to the correct people? [02:51:15] Elsie, greg-g, jorm, Krinkle, marktraceur, ragesoss, RD, Reedy, thedj, thedj[work], YuviPanda: any of you here and awake? [02:51:26] ? [02:51:34] ? [02:51:36] T13: That's really unhelpful, don't do that. [02:52:07] ^^^^ dfc has a question for wmf staff/dev [02:52:28] you do know that half the people you pinged are not involved with mobile dev? [02:52:28] is this the correct place to report a rendering problem with the mobile gererated html? [02:52:34] https://en.m.wikipedia.org/wiki/List_of_chocolate_bar_brands [02:53:02] lists one row of chocalate bar brands on the iphone, firefox on the desktop, and google chrome [02:53:12] mobile devs generally discuss here, though the devs working from the sf office are likely home by now. [02:53:18] the non-mobile page lists hundreds of chocalate bar brands [02:53:36] I'd recommend filing on bugzilla under MediaWiki extensiosn > MobileFrontenf; unless someone here from the mobile team can help you [02:53:38] Xe is having hard time figuring how to manipulaye tables from iPhone. [02:53:53] http://wmbug.com/new?product=MediaWiki+extensions&component=MobileFrontend [02:53:56] is there a bugzilla I can create a ticket on? [02:54:18] krinkle nice [02:54:23] you'll need to create a simple bugzilla account there if you haven't already, should only take a minute. [02:54:51] many thanks [02:54:57] im good2go now krinkle [02:55:00] thanks for the help [02:55:04] yw [02:56:53] thanks T13|sleeps [02:57:02] :) [02:57:44] Bugzilla was going to be my next suggestion if no-one answered my ping. [02:58:27] T13|sleeps: Try not to ping people who aren't on the mobile team next time, as they'd do the same (point to bugzilla) [02:58:31] * Krinkle includes me [02:59:56] I tried to pick mobile team and people with lots of general knowledge (included you) [03:18:20] Actually, only Yuvi is on the mobile team out of those you pinged. [08:18:20] hi YuviPanda [08:18:27] hey orsa [08:18:28] 'sup [08:18:49] I undestand there is no equivalent keychain on android [08:19:05] how do you reccomend storing credentiasls? [08:19:41] orsa: well, there *is* [08:19:53] android has Accounts support [08:19:58] finding link, moment [08:20:20] orsa: https://developer.android.com/training/id-auth/custom_auth.html [08:20:34] this is implemented in the Commons app too, so you can lift it from there if you want [08:20:50] oh nice.. :) [08:20:55] :) [08:46:18] hey mhurd [08:46:32] hey yuvi! [08:46:50] up pretty late :) [08:47:07] ya should probably sleep haha [08:47:50] :) [08:52:29] YuviPanda: ok gonna try that sleep thing again :) [08:59:53] YuviPanda: now i see that Custom Account does NOT encrypt the data. how do you solve that in Commons app? [09:00:06] orsa: only your app can access that data [09:00:12] other apps cannot [09:00:14] so it is fine. [09:00:32] orsa: and we cannot encrypt it safely anyway, since mediawiki does not support anything other than basic auth [09:00:47] yes but is case of stealing the devise, one can root it and see it clearly [09:01:06] ok, i see [09:01:09] in that case there is no help even if you 'encrypt' it in some form [09:01:15] since the keys are going to be on the device too [09:01:23] and this is rather 'standard' for android [09:01:37] and also if you want, you can encrypt your *entire* phone, so for people who are sensitie they can do that [09:01:40] (you can't do that with iOS) [09:02:33] YuviPanda: then whats the point of using Custom Account instead of simply "Shared Preferences" [09:02:41] ? [09:03:00] it would be much easier [09:03:00] orsa: it will show up in user's 'settings', other apps can request permission to use it, and it can be 'backed up' later. [09:05:57] YuviPanda: got it, thanks :) [09:06:00] :) [09:06:17] orsa: it's also rather re-usable. You should be able to use the code fromc ommons app [09:06:19] *commons [09:06:28] orsa: also are you using a library for accessing the mediawiki api? [09:07:01] orsa: there's already java-mwapi, which handles all the login / cookie saving stuff properly. Use it? [09:08:13] YuviPanda: i created my own [09:08:22] orsa: please don't do that [09:08:28] orsa: duplicating work is bad. [09:08:32] orsa: use java-mwapi? [09:09:59] orsa: and then everyone will have to maintain two separate java mediawiki api libraries [09:11:18] but does is support translatewiki API methods? [09:11:32] such as translation aid [09:11:45] orsa: all of mediawiki's api is generic, so it should support them all [09:11:56] orsa: if you are using it under api.php, then it is supported [09:14:07] orsa: api.action("translationaid").param("title", title).param("group", group).get() [09:14:08] should work [09:14:18] orsa: mediawiki's api is built in such a way that clients can support them easily [09:14:28] orsa: so please, do *not* write your own client [09:51:57] YuviPanda: is that the most updated repo for java-mwapi? https://github.com/orsa/java-mwapi [09:52:05] looking [09:52:27] orsa: fork from https://github.com/wikimedia/java-mwapi [09:53:27] orsa: it has tests, you can look at them to see how to use the functionality [09:53:45] YuviPanda: ill look [09:54:38] YuviPanda: does is produce asynchronous requests? [09:54:52] orsa: in android you always have to use AsyncTask yourself to produce asynchronous requests [11:51:16] orsa: did i miss anything while disconnected? [11:51:39] YuviPanda: no, no worries.. :) [15:49:18] * YuviPanda pokes brion [15:49:31] hey YuviPanda [15:49:43] house situation getting under control? [15:50:04] nothing to do on the house today but hope the flooring guys finish up, so i'm back online [15:50:32] ok…. icon email shortly, any code review or anything else you need? [15:50:32] :) [15:50:33] brion: there's a bunch of patchsets for you [15:50:38] awesome \o/ [15:50:41] brion: I'm doing the campaigns stuff as a branch, as a patch series - so no github for that one. straight up gerrit [15:50:51] scary! [15:50:59] brion: you should find them all in your gerrit dashboard [15:51:03] excellent [15:51:20] brion: I'm refactoring things a little bit too, to not copy paste code or someshit [15:51:35] nice [15:51:40] yeah, icon email [15:51:49] brion: we should also email about holo light switch, but that can come later, I guess [15:52:03] prtksxna_gone: added icons for the holo light variant, still needs some tweaking [15:52:04] tho [15:52:53] ok looks like i've got some pull reqs from monte as well... [15:53:01] yeah [15:53:03] but email first :P [16:05:47] YuviPanda: where is "in.yuvi.http.fluent.Http.HttpRequestBuilder" [16:33:39] brb food [16:53:52] (CR) Kaldari: "(5 comments)" [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/75822 (owner: Kaldari) [16:58:29] (CR) Kaldari: "(1 comment)" [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/75822 (owner: Kaldari) [17:00:42] taking screenshots for icon email :) [17:11:34] sent [17:14:33] brb [17:17:46] http://about.travis-ci.org/docs/user/getting-started/ [17:17:49] wrong chan [17:32:45] Maryana: i'm going to have fun translating this https://ja.wikipedia.org/wiki/Wikipedia:井戸端#.E3.83.A2.E3.83.90.E3.82.A4.E3.83.AB.E7.B7.A8.E9.9B.86 [17:33:53] Maryana: were seeing some blocking issues on JA. i'm trying to understand them [17:33:54] eek - google translate not helping [17:35:03] Maryana: this is causing some of the issue https://ja.m.wikipedia.org/wiki/Template:Blocked_mobilephone [17:35:27] jcmish, is that editing blocked bug reproduceable on beta? [17:35:30] 7 year old ban on mobile editing ? [17:35:52] the swedish one? [17:35:54] that's crazy... [17:35:55] MaxSem: ? [17:36:02] yep [17:36:40] beta is sparse when it comes to some of the langauges [17:36:40] let me see [17:37:32] tfinc, might have something to do with ancient phones not supporting Unicode [17:37:49] MaxSem: no Sv on beta labs [17:38:59] could be [17:39:18] Maryana: who do we know in the JA community who could give us more insight into why this ban exisits ? [17:39:21] exists* [17:40:19] i don't know anybody on jawiki, but maybe ask haitham to figure out if it's a software ban or just a community policy - it *looks* like it's the latter, and now the users are discussing whether to lift it? [17:40:29] * YuviPanda looks around [17:40:33] brion: hey! [17:40:42] heyy [17:41:26] brion: thanks for the email :) [17:41:33] did you get time to look at the patches? [17:42:23] getting there [17:42:24] [Commons-iOS] brion closed pull request #106: Made pic of day attribution handle license not retrieved. (master...licenseNotFound) http://git.io/JcDLyA [17:43:15] [Commons-iOS] brion pushed 2 new commits to master: http://git.io/QoNmHg [17:43:15] Commons-iOS/master e22faee Monte Hurd: Made alpha of settings controls more consistent. [17:43:15] Commons-iOS/master da8da90 Brion Vibber: Merge pull request #107 from montehurd/settingsStyle... [17:43:51] YuviPanda: brion: i like the icon [17:43:56] :D [17:43:57] \o/ [17:44:03] mhurd: prtksxna_gone did it [17:44:05] (he's away now) [17:44:20] YuviPanda: it fits well [17:44:27] with the rest of them,yeah [17:44:51] https://github.com/montehurd/Commons-iOS/commit/b2203c52ebfe6d04d27e7de57d1666beca62b6a8 <- nice now we can see the potd images in source control :DD [17:44:55] mhurd: google specifically made a blog post recently on this subject too http://android-developers.blogspot.in/2013/07/making-beautiful-android-app-icons.html [17:45:35] ok merged… lemme double check everything is good combined :) [17:45:43] [Commons-iOS] brion closed pull request #108: Reduced app binary size by optimizing bundled images. (master...optimizeImages) http://git.io/ZV-HlQ [17:45:56] then i'll get to your YuviPanda :) [17:46:13] hehe :) [17:46:26] brion: yay! [17:46:30] Maryana: my read so far was that their was a community decision in 2006 to block them. i'm unsure how they implemented it [17:47:07] YuviPanda: i added that link to the calendar invite for the design chat monday [17:47:12] whoa why is this license in estonian…. oh it's the estonian version. ok that makes sense :D [17:47:14] mhurd: sweet [17:48:11] mhurd: oh while we're making changes... [17:48:21] …let's kill the "upload" button on the 'my uploads' page. it confuses people [17:48:32] and isn't really necessary since there's one on the detail page when you actually input data [17:49:01] brion: k [17:49:35] mhurd: oh, what other fixes/changes are you making this morning? [17:50:18] brion: on iPad on details page the "categories" heading isn't aligned quite right. also on the settings page the mock page animation at the top is too small. [17:50:34] (too small on iPad) [17:50:35] spiff [17:52:58] any idea when iOS release is going to push out? [17:53:59] YuviPanda: we'll push it to iTunes connect this afternoon assuming it works… as for review time, who knows... [17:54:07] we can hope it's ready sometime next week, but no guarantees [17:54:13] Maryana: found the policy https://ja.wikipedia.org/wiki/Wikipedia:投稿ブロックの方針/改定案#.E6.90.BA.E5.B8.AF.E9.9B.BB.E8.A9.B1.E3.83.96.E3.83.A9.E3.82.A6.E3.82.B6 [17:54:54] brion: :) [17:55:47] ok checking gerrit... [17:56:21] tfinc: it seems like they did this because they were getting lots of IP vandalism, and it was hard to trace b/c of slipperiness of mobile IPs [17:56:32] or at least that's my reading via google translate [17:56:41] YuviPanda: ok i see two change sets, on 'campaigns' branch. is that everything or should i go searching for more :) [17:56:50] brion: there should be three [17:56:57] hmm [17:57:06] YuviPanda: also the holo light? or another one [17:57:09] tfinc, looks like neither of these reasons are applicable to our implementation [17:57:11] not holo light [17:57:22] Maryana: the blocks seem to be coming from https://ja.wikipedia.org/wiki/特別:ブロック一覧 [17:57:26] brion: https://gerrit.wikimedia.org/r/#/q/project:apps/android/commons+status:open,n,z [17:57:27] first 3 [17:57:41] we target only reasonably modern browsers and allow only logged-in editing [17:57:46] for instance at one point they blocked all of DOCOMO which is huge [17:57:46] whee [17:58:15] Maryana: what we need here is someone to lead the JA discussion about removing these blocks. My Japanese is nowhere near enough to do it [17:58:58] the only person i know who'd be able to is haitham [17:59:33] i can get in touch w/him and ask [18:00:33] Maryana: Erik says to check in w/ Philippe. he should have someone [18:01:04] that would be great [18:01:23] Maryana: can you reach out to him ? [18:01:39] will do [18:03:10] tfinc, and here's the swedish problem: https://sv.wikipedia.org/wiki/Special:Bidrag/2620:0:862:1:26B6:FDFF:FEF5:ABB4 [18:05:54] Maryana: Haitham points out that some people are getting through just fine http://ja.m.wikipedia.org/w/index.php?title=%E7%89%B9%E5%88%A5:%E6%9C%80%E8%BF%91%E3%81%AE%E6%9B%B4%E6%96%B0&days=30&from=&limit=500&tagfilter=mobile+edit [18:06:06] so it may be selective ip blocks due to vandelism like you said [18:06:49] YuviPanda: hmm, not sure i understand the separate 'campaigns' launcher icon [18:06:56] jcmish, what do you see at https://sv.m.wikipedia.org/w/api.php?action=query&meta=userinfo&uiprop=blockinfo&format=json ? [18:06:59] brion: so that's a very, very temp thing [18:07:05] brion: we'll add drawers soon [18:07:18] YuviPanda: also, if the app is already open it seems to only open the my uploads view [18:07:27] Maryana: where can i see the current editing stats? [18:07:33] brion: yeah, that's a bug. you need to tap back to close it and open it again [18:07:41] blugh [18:07:44] brion: it's a temp thing for testing only, which is one of the reasons this is on a separate branch [18:07:54] YuviPanda: maybe stick it in the options menu instead? [18:08:05] can be another commit, just want to know it's coming ;) [18:08:13] hmm nada MaxSem [18:08:22] just query on the left and nothing else [18:08:24] brion: that feels hackier :P [18:08:25] or not [18:08:30] hehe [18:08:34] brion: I can either make it open up either way fine [18:08:38] or stick it in options windo [18:08:39] w [18:08:44] jcmish, can you paste it? [18:08:48] I prefer former, but can stick it in menu if you like that more [18:08:51] https://sv.m.wikipedia.org/w/api.php?action=query&meta=userinfo&uiprop=blockinfo&format=json#query/userinfo/name [18:09:04] i like the menu more, the launcher confuses me :) [18:09:05] gave me: 0 name 143.112.144.129 anon [18:09:10] i'll merge this one for now tho [18:09:56] YuviPanda: brion: mhurd : any last minute changes to the trello board before i copy it ? [18:10:07] i'm good [18:10:09] tfinc: no [18:10:32] oh i should probably double-check the source as well as testing before i merge :) [18:10:37] jcmish, so you see no block but still can't edit on sv:? [18:11:00] ok good, no surprises in the code :) [18:11:00] tfinc: let me move the things in 'code review' to done since brion just finished them [18:11:01] tfinc: odne [18:11:01] *done [18:11:52] hehe [18:12:16] thanks [18:12:44] I don't see a block but if I go to https://sv.m.wikipedia.org/wiki/Caeneressa_tienmushana#editor-0 and hit edit it comes up do you want me to try to save the eidt [18:12:54] *edit and see what's happening? [18:13:47] MaxSem: wheee, we're roommates :) [18:13:52] hopefully we won't both sleep off :) [18:14:55] YuviPanda, I already told you yesterday:) [18:15:17] jcmish, sure - try to edit [18:15:18] do either of you snore? YuviPanda and MaxSem ? :D [18:15:29] MaxSem: yeah, I wasn't around. I forgot to nick away before leaving, leading jgonera to believe I never sleep :) [18:15:38] I wouldn't know if I did, would I? :) [18:15:51] jcmish, with proper hanging out you never feel anything when you sleep [18:15:57] I'm a *heavy* sleeper, so am a bit afraid of rooming alone and waking up the *next* day [18:16:03] and missing a full day of the conference [18:16:14] I think I've had 2 full dreams / nightmares of that happening :P [18:16:39] hahahaha [18:17:10] so true MaxSem so true! and hmm YuviPanda sure what if you woke yourself up snoring? My grandfather used to do that all the time :D [18:17:22] haha, will probably happen in the future though [18:17:24] MaxSem: I was able to edit and save with no problem [18:17:31] jcmish, aha [18:17:43] so the problem is indeed ppl being blocked [18:18:11] MaxSem: ahhh [18:18:19] so yeah it's not "everyone" then [18:18:47] hmm, the user who blocked my IPv6 is a checkuser [18:19:33] YuviPanda, can you quickly merge: https://gerrit.wikimedia.org/r/#/c/76037/ ? I thought I could merge myself but it seems I was wrong... who do I ask to give me merge permissions there? [18:19:45] YuviPanda: go forth and cherry-pick [18:19:49] brion: \o/ [18:19:49] so, my conclusion is that we need URGENTLY to display the full information about why did the edit fail [18:19:54] jgonera: Chad, I'd think? [18:19:55] Maryana, ^^^ [18:20:13] what's his IRC nickname? [18:20:40] ^demon [18:20:49] jgonera: are you sure you can't merge? [18:20:49] jgonera: try setting v+2 as well? [18:20:49] brion: thoughts on the 'controller' pattern? [18:20:49] brion: I'm going to use it in more places. Currently going to write an 'Upload' Controller [18:20:49] jgonera: ^demon [18:21:02] jgonera: try V+2 and 'publish and submit'? [18:21:02] you can C+2, so you *should* be able to merge [18:21:16] YuviPanda: me like. keeps things separate from the UI code [18:21:26] YuviPanda, you're right [18:21:33] brion: yeah, our activities were getting too big for my liking [18:21:33] YuviPanda, I forgot there's no Jenkins there [18:21:36] thanks [18:21:37] jgonera: :) [18:22:29] brion: grr, doesn't let me cherry pick, apparently 'change is closed' [18:22:31] dumb gerrit [18:22:34] hurr durr [18:22:54] YuviPanda: you'll have to do it the hard way [18:23:01] git cherry-pick [18:23:27] or are you doing that and gerrit won't accept it? [18:23:36] try removing/re-adding the Change-Id line maybe [18:24:31] brion: yeah, will do the cherry-pick manually [18:24:38] need to change change-id but that'll be fine. [18:24:43] spiff [18:24:44] (PS4) Kaldari: Adding 'thank' link to MobileDiff view [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/75822 [18:24:45] brion: actually, I'm not going to do that [18:31:14] brion: if we cherry-pick, it'll be problematic when merging [18:31:14] since it is in both campaigns and master [18:31:14] i'll leave it as is [18:31:28] ok [18:32:36] brion: thoughts on having an UploadController vs putting it in the Contribution controller? [18:33:18] YuviPanda: separate sounds good… [18:33:24] hmmm, right [18:33:24] ok [18:33:29] let me go do that [18:36:01] YuviPanda: brion: heads up that hangout link for 12 is in the description. the automatic one was not working. jsut gave me a your not allowed to join [18:36:14] that's the one in 30 mins, right? [18:36:22] 24 mins [18:36:33] tfinc: ^ [18:36:38] yes [18:36:54] tfinc: ok [18:37:20] ok [18:39:16] gonna grab some eats before the noon mtg, brb [18:52:42] hey folks physically in the US, if you log out do you see a v6 IP on https://sv.m.wikipedia.org/wiki/Special:MyContributions ? and at https://sv.wikipedia.org/wiki/Special:MyContributions ? [18:54:44] MaxSem, in the input field? no, I see v4 [18:54:45] i don't have ipv6 at home :( [18:55:03] do we have v6 at the office? [18:55:20] i see v4 in both here... [18:55:32] jgonera: i don't think so… it's something ops has been asking for :P [18:55:40] the trick is that I see v6 on mobile but v4 on desktop [18:55:52] o_O [18:55:52] and guess what? the v6 belongs to WMF [18:55:56] [Commons-iOS] montehurd opened pull request #109: Fixed details page "Category" heading layout issue on iPad. (master...categoryLayout) http://git.io/vTuolA [18:56:43] so I'm trying to figure out if it's fucked specifically for ppl hitting Amsterdam or just for all mobile users [18:57:37] v4 in both of them for me [18:57:53] okay, so it's a Euro thing... [18:59:26] brb [19:01:35] Maryana, thank you for the bag, wherever you are ;) [19:02:11] in r31 [19:02:15] lemme know if that works [19:02:23] the red bag is in the green one [19:02:29] whichever you want to use [19:05:00] hi YuviPanda: I'm struggling with defining the MWApi dependencies properly. any clue for the easiest way to know what are the needed files and how to import them without a mess? [19:05:34] orsa: hmm, I am pretty sure we can just get you a Jar for that. [19:05:34] orsa: I'm in a meeting though :( can you give me a bit? [19:05:42] ~30 mins [19:05:46] YuviPanda: sure [19:05:55] thanks [19:28:59] MaxSem: why is the mobile formatter running on special pages? o_O [19:30:31] jdlrobson, because it always was this way:P furthermore, we're actually using this to beautify Special:Search [19:30:35] it wasn't MaxSem [19:30:47] we never had content_0 on special pages.. [19:30:58] i suspect it changed when we enabled section toggling by default [19:31:15] because previously they had too few sections to be collapsed? [19:31:20] yeh [19:31:32] where do i fix that? i'm hitting issues because of it [19:32:30] MobileFormatter.php $formatter->enableExpandableSections( !$isMainPage ); ? [19:32:37] jdlrobson, hide #search and .mw-search-createlink and we can disable it [19:32:47] *with CSS [19:32:52] that would be good [19:32:55] i'll do a patch for that in a sec [19:33:11] I thought you're OOO today:) [19:33:24] i board in 20 minutes [19:33:24] i'll be working from a plane [19:33:25] doubt there will be wifi though ;-) [19:33:58] just found the best i18n string: "Provides features for mobile providers that provide free access" [19:34:40] a bit of recursion, so what?:P [19:57:55] (PS5) Jdlrobson: Adding 'thank' link to MobileDiff view [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/75822 (owner: Kaldari) [19:58:12] tfinc: do you still want to have the 1:1 today? I'm fine if you want to skip it this week since I'm not in the office. [19:58:53] (CR) Jdlrobson: [ C: 1] "Ryan - made a few changes (basically the thank link is now created in JavaScript and css )." [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/75822 (owner: Kaldari) [19:59:05] (CR) Jdlrobson: "+2 if it is acceptable to you :)" [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/75822 (owner: Kaldari) [20:00:11] brb charging [20:00:19] YuviPanda: is meeting done? [20:00:24] tfinc: pm? [20:00:44] orsa: yup! I'll look into that in about 15 mins? [20:00:44] YuviPanda: sure. i'll be distracted as i have a 1:1 [20:00:49] tfinc: should be fine. [20:00:54] YuviPanda: 10x [20:03:12] Jon's edit graphs deployed to our dashboard: http://mobile-reportcard.wmflabs.org/ [20:04:28] kaldari: i'm on hangout. we'll make it quick [20:05:27] tfinc_: poke when you're done with 1:1, my pm convo should also be quick :) [20:06:42] kaldari: ready when you are [20:07:04] tfinc_: Did you see my message earlier? [20:07:23] oh, you must be flyingclimber :) [20:21:12] [Commons-iOS] montehurd synchronize pull request #109: Fixed details page "Category" heading layout issue on iPad. (master...categoryLayout) http://git.io/vTuolA [20:35:05] hey orsa [20:35:11] hey [20:35:28] orsa: so you see a pom.xml file in that repo, right? [20:35:33] you can use that to produce jars, or include them [20:35:35] in your repo [20:36:13] i see that. do i neet to produce jar out of java-mwapi? [20:36:24] orsa: you can do that if that'll be easier for you, yeah. [20:36:50] but i see that java-mwapi itself depend on others [20:37:45] orsa: yeah, maven (that is where the pom.xml is from), will automatically pull those in [20:37:51] orsa: are you using IntelliJ? [20:38:36] orsa: https://www.jetbrains.com/idea/webhelp/maven.html has docs on how to automatically includ ethose [20:38:41] so your IDE will take care of all that [20:38:45] no, android studio. intellij seemed even more useless for me. [20:39:11] orsa: android studio = intelliJ + some changes [20:39:16] orsa: why is IntelliJ more useless? [20:39:46] when i tried to import my project it produced many errors [20:40:40] I see [20:41:29] orsa: like? [20:42:01] ill stick with studio for now [20:42:20] okay, but it's still crashy. I thought it'll be as stable as IntelliJ [20:42:48] orsa: let me figure out how to get you a simple jar file. should be doable. [20:43:28] YuviPanda: 10x [21:13:28] [Commons-iOS] brion pushed 4 new commits to master: http://git.io/oncfPg [21:13:28] Commons-iOS/master 56848f9 Monte Hurd: Fixed details page category heading alignment on ipad. [21:13:28] Commons-iOS/master 99db90e Monte Hurd: Reduced height of category entries. [21:13:28] Commons-iOS/master 46fb8e3 Monte Hurd: Title & descrip text box width same as categories box.... [21:13:28] <77CAANN93> [Commons-iOS] brion closed pull request #109: Fixed details page "Category" heading layout issue on iPad. (master...categoryLayout) http://git.io/vTuolA [21:13:42] brion: yay! [21:14:10] mhurd: anything else to poke before trying out for a release? [21:14:33] brion: one quick one… hopefully 45 minutes? [21:15:03] brion: aim for 3pm and if i'm not finished do with what we've got [21:15:04] ? [21:15:11] works for me :D [21:15:14] brion: yay! [21:19:55] brion: good catch: re: welcome screen [21:19:56] let me fix [21:20:01] yay [21:20:08] * tfinc_ watches his phone upgrade to 4.3 [21:20:13] sigh [21:20:22] where's the problem here: [21:20:22] ^http://(?:www\.(?=mediawiki)|)?((?:commons|species|meta|incubator|outreach|strategy|wikimania2012|wikimania2013)(?:\.|(?=wikimediafoundation))(?=wikimedia)|\w+\.(?!wikimedia|mediawiki)|(?=mediawiki))(wikimedia|wikipedia|wiktionary|wikinews|wikisource|wikiquote|wikibooks|wikiversity|wikivoyage|mediawiki|wikimediafoundation)\.org[:\d]*/wiki/(.*) [21:20:28] * brion starts obsessively checking for software updates [21:20:33] has anyone upgraded yet ? [21:20:40] neither do I know:) [21:21:09] tfinc_: looks like it pre downloaded on my phone, installing it now :D [21:21:13] orsa: ping [21:21:15] orsa: so when you have cloned the java-mwapi library [21:21:18] http://www.zdnet.com/top-5-features-in-android-4-3-jelly-bean-7000018522/ [21:21:19] brion: just execute 'mvn compile' [21:21:23] auto download over wifi == win [21:21:24] brion: you'll find all the .jar files in lib/ [21:21:29] you can then copy them to your app [21:21:34] YuviPanda: eh? [21:21:39] err [21:21:41] I meant orsa [21:21:42] nto brion [21:21:43] :D [21:21:43] sorry [21:21:44] restricted profiles are nice. especially when i need to pass on my phone to someone [21:22:10] i'm also curious about the additions to notification [21:22:11] s [21:22:26] YuviPanda: did you added the jar now [21:22:32] orsa: no i just remembered ;) [21:22:35] orsa: it's been there forever [21:25:18] YuviPanda: lets see :) [21:25:26] orsa: i just tried it out, it gives me the jars [21:29:18] jgonera: where can i see the most up to date stats on mobile edits ? [21:31:38] YuviPanda: i got .class files, but no jar [21:31:46] orsa: did you do mvn compile? [21:31:52] yes [21:32:04] let me double check [21:33:47] i see only the jars which mwapi itself depend on [21:34:38] ok booted up in 4.3… looking to see if that restricted profiles feature is there on phones or is tablets only... [21:35:20] orsa: try 'mvn assembly:assembly -DdescriptorId=jar-with-dependencies' [21:35:32] crap 'Tablet owners can create restricted profiles' [21:35:34] oh wells [21:35:48] orsa: you should find them in the 'target' folder [21:35:53] orsa: one with and one without dependencies [21:39:08] brion: ping [21:39:16] pong [21:39:19] brion: can you check if the 'login' screen also has an action bar? [21:39:21] in GB? [21:39:33] YuviPanda: in current or in the patch? [21:39:48] brion: both? [21:39:48] lemme test current master real quick :) [21:39:48] ok [21:39:48] brion: in current [21:39:48] yeah [21:39:48] current first [21:39:52] [Commons-iOS] montehurd opened pull request #110: Details can scroll more on iPad. (master...detailsTweaks) http://git.io/OE_ekw [21:40:21] whee reboot the 2.3 phone, its battery emptied again \o/ [21:40:31] YuviPanda: the build fails [21:40:33] hehe :) [21:40:41] orsa: can you pastebin the error message? [21:41:17] I still strongly suggest using IntelliJ, since all this is very simple there. [21:41:23] * YuviPanda regrets suggesting Android Studio first up [21:41:41] brion: another pull req. one more quickie hopefully in next 15 minutes [21:41:56] spiff, moment [21:42:02] YuviPanda: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.7.2:test (default-test) on project api: There are test failures. [21:42:18] kenanwang: the hangout situation for the invite was all sorts of bizarre [21:42:24] mvn assembly:assembly -DdescriptorId=jar-with-dependencies -DskipTests [21:42:32] orsa: did you include the '-DskipTests' part? [21:42:37] YuviPanda: ok the login page on 2.3 on master does not have an action bar [21:42:50] brion: hmm, this is confusing. Since they both have the same styles [21:42:52] let me poke [21:43:07] YuviPanda: yed, i did [21:43:19] tfinc_: weird. No worries. I'll try to make the next one. [21:43:25] YuviPanda: ok how do i omport using intelliJ? [21:44:09] orsa: https://www.jetbrains.com/idea/webhelp/maven.html [21:45:02] orsa: you can just add it as a dependency, from file -> project structure [21:45:24] kenanwang: what's your trello account? i want to add you to the next sprint board ? [21:45:40] [Commons-iOS] brion closed pull request #110: Details can scroll more on iPad. (master...detailsTweaks) http://git.io/OE_ekw [21:46:49] tfinc_: I actually don't have one yet. [21:47:53] kenanwang: invite sent [21:48:18] kenanwang: let me know when you've added your account [21:50:28] tfinc_: done [21:51:12] it'd be simpler if it used the email as account identifier, then we could just add people [21:51:20] but i suppose people hate exposing their email addresses [21:53:57] (PS1) Yurik: Removed X-CS dependency in HTML content rewriting [extensions/ZeroRatedMobileAccess] - https://gerrit.wikimedia.org/r/76201 [21:54:06] dr0ptp4kt, ^ [21:54:10] tfinc_, here: http://mobile-reportcard.wmflabs.org/ [21:54:20] MaxSem, here? [21:54:27] yup [21:54:28] didn't see those before. did we just rev it ? [21:54:47] tfinc_, yes, we deployed this today [21:55:17] MaxSem, do you have a second to take a look at a few "fixme" or "howdoidothisthing" in the https://gerrit.wikimedia.org/r/#/c/76201/ [21:55:22] nothing thorough yet [21:55:27] just a quick look [21:55:28] sure [21:55:34] thx! [21:56:30] jgonera: successful edits is total . not just unique right ? [21:56:56] tfinc_, yes, unique is at the bottom, but only unique per day, we'll need to add unique per month [21:57:52] brion: I assigned cards to me / brion as appropriate, and I count 25 points + a 4 hour spike for me. Sounds appropriate [21:58:06] moved a couple of cards that weren't that urgent back to backlog [21:58:13] jgonera: do we have a rollup of unique contributors across our contributions pipelines ? [21:58:40] tfinc_, you mean edits + uploads? not at the moment [21:59:09] [Commons-iOS] montehurd opened pull request #111: Made mock page at top of settings look better on ipad. (master...settingsMockPage) http://git.io/3nv0SA [21:59:13] brion: ^ [21:59:17] yurik, i see it. will review on monday, okay? [21:59:20] lookin [21:59:27] dr0ptp4kt, sure thing [21:59:31] here goes our Swedish editing fix: https://gerrit.wikimedia.org/r/76205 [21:59:44] man i'm SO glad obj-c has blocks these days [21:59:53] brion: haha yes!!!! [21:59:56] java can make do with anonymous inner classes but i'd go insane in 'old' objc [21:59:56] yurik, thx, brain is in phantomjs and bash shell mode at the moment. looking forward to testing it out! [21:59:58] dr0ptp4kt, besides, that patch still misses a "full screen warning" - I need some HTML thoughts on that [22:00:06] (your code, looking forward to testing it) [22:00:12] thx [22:00:14] yurik, word [22:01:05] (PS1) JGonera: Revert "Fix: Tag mobile edits" [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/76206 [22:01:29] mhurd: looks good, merging [22:01:31] tfinc_: thanks got it [22:01:36] brion: yay! [22:01:48] [Commons-iOS] brion pushed 2 new commits to master: http://git.io/uExnUQ [22:01:48] Commons-iOS/master 5911a0b Monte Hurd: Made mock page at top of settings look better on ipad. [22:01:48] Commons-iOS/master 027271e Brion Vibber: Merge pull request #111 from montehurd/settingsMockPage... [22:01:54] mhurd: anything else? :) [22:02:03] or shall i increment the version number and build :D [22:02:21] brion: hmmm… probably forgetting something but oh well. let's do this! [22:02:22] :) [22:02:41] wooo [22:03:40] ok incrementing to 1.0.6 [22:04:33] [Commons-iOS] brion pushed 1 new commit to master: http://git.io/jvcVBw [22:04:33] Commons-iOS/master 7812e17 Brion Vibber: bump version to 1.0.6 for release! [22:04:48] ok… set to non-debug build, 'archive'... [22:04:50] brion: mhurd \o/. Yay on releases :) [22:05:01] and… build for arm not simulator :) [22:05:03] yyyyeeeaaaahhh! [22:05:07] :) [22:05:10] I'm off now [22:05:25] orsa: I'm heading to sleep. Email me if you run into issues? [22:05:38] orsa: I understand it can be frustrating to get setup on Android dev, but after that it is usually smoother [22:05:44] good night! [22:05:46] brion: oh, kick the tires on the settings page w the build release - make sure the debug setting is gone [22:05:48] ok save for ad-hoc for testflight... [22:05:54] YuviPanda: good night, thanks [22:05:57] ah yeah :D [22:06:03] YuviPanda: g'night! [22:06:18] mhurd: crap I don't have my iOS devices here, can you try installing from test flight once i've updated it there? [22:06:24] brion: ya! [22:06:30] spiff [22:06:51] ok sign with… CommonsBeta... [22:07:51] ok… don't' think i need a new profile, which is good cause that's still down i think [22:07:56] kaldari, can you merge https://gerrit.wikimedia.org/r/#/c/76206/ ? I'll be working on this part of code and want to avoid conflicts [22:08:16] brion: oh yeah hope we don't need any profiley things [22:08:35] mhurd: yeah worst case we just push out the beta and wait until all of ADC is back online :) [22:08:49] brion: true [22:09:04] oh man now i need to come up with brief release notes [22:09:09] "bug fixes and improvements" ;0 [22:09:17] brion: lol [22:09:36] lemme skim git log real quick :) [22:11:57] mhurd: ok you should have an email from test flight confirming i've enabled the new build for you [22:12:03] confirm it installs on device? [22:12:11] brion: checking now [22:12:39] YuviPanda: thanks for closing board 13 [22:12:44] brion: installing... [22:12:55] whee [22:13:44] (CR) JGonera: [ C: -1] "(1 comment)" [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74667 (owner: MaxSem) [22:14:54] oh shit [22:14:58] " The iOS Developer Program License Agreement has been updated. To create new apps and upload binaries to the App Store, the user with the Team Agent role must review and accept this agreement in Member Center. " [22:15:18] weeeeeelll so much for uploading to the store [22:15:31] since member center is down i can't get in there :( [22:16:21] brion: oh god [22:17:18] brion: well, at least we got a test flight build out :) [22:17:28] brion: which looks good by the way [22:17:57] brion: the debug setting is hidden properly too [22:17:58] exellent [22:18:00] oh good :D [22:18:09] i'll release the build on TF and send a mail on mobile tech & mobile-l [22:18:11] ... [22:18:19] brion: sounds good! [22:18:19] jgonera: yes both. that way we have one global place to see our 6,000 target [22:18:47] tfinc_, not sure if I'll manage to add all of this today [22:18:52] k [22:20:03] brion: crap i forgot to hide upload button. [22:20:12] heh [22:20:23] very interesting take on phone profiles http://www.reddit.com/r/Android/comments/1j0lo5/official_android_43_questions_and_answers_thread/cb9z8tr [22:20:24] let's just get it in the next one :) [22:20:33] we might push out another beta before ADC is b ack on lie anyway :P [22:20:46] brion: haha yeah [22:23:38] mhurd: oh, throw a card in for it before we forget though [22:23:48] brion: ya? [22:23:55] oh for the button [22:24:07] will do [22:24:19] tx [22:26:06] brion: done [22:26:55] brion, I'm trying to reset my password on WIkipedia, I get the reset password email, I login with temporary password and then set a new password and it doesn't work... (keeps saying incorrect password) [22:27:03] do you know why this might be the case? [22:27:13] hmm that doesn't sound good :) [22:27:40] I tried 2 times already [22:27:49] can this be related to our login system changes [22:28:00] jgonera: might be a bug in the centralauth updates? check with csteipp or #wikimedia-tech maybe [22:28:04] I'm talking about desktop obviously because we don't have password reset on mobile [22:28:07] right [22:28:20] jgonera: or... [22:28:23] he's not there, not in the office either [22:28:28] jgonera: are you trying it on test.wikipedia.org or en.wikipedia.org? [22:28:29] bah [22:28:36] en.wikipedia.org [22:28:39] there might just be a memcache session issue with test [22:28:44] hmmmm well that ought work then :D [22:29:57] ragesoss: do let us know if the update handles your large account better :) [22:30:47] ui is extremely unresponsive while loading photos. [22:31:14] but settings eventually came up [22:31:15] brion, is the new login system still called CentralAuth extension? or is it in core now or in a different extension? [22:31:18] I'll report a bug [22:31:26] ragesoss: ok, still needs work… but that's a good sign :) [22:31:39] jgonera: i… think it's still CentralAuth. but honestly i don't know [22:31:57] I'll report it in the core, will get more attention [22:32:40] heh :) [22:32:44] hey, it finally loaded all my photos (starting from where it had left off from last time I tested) [22:33:27] \o/ [22:33:30] ok that's good :D [22:33:39] (CR) MaxSem: "(2 comments)" [extensions/ZeroRatedMobileAccess] - https://gerrit.wikimedia.org/r/76201 (owner: Yurik) [22:34:04] why can I move single view images horizontally, but not swipe to the next one? [22:34:13] so it actually fetches them all (good) but the ui's not responsive enough during initial update (bad) [22:34:29] ragesoss: ah yes, we've got that on android but it hasn't quite made it in on iOS yet [22:34:39] whereas on android we have the swipe but not the zoom :) [22:34:50] well, no, it still stops at every screen timeout. [22:34:55] hmmm [22:36:07] I was trying to double tap to zoom. [22:37:04] pinch zoom, but resolution is still thumbnail size. [22:37:18] ragesoss: you're talking about iOS right? [22:37:32] mhurd: do we have a card for dynamically-fetch-larger-imgae-on-zoom? [22:37:41] i know we talked about it as a todo [22:38:16] Yuvi: iOS. [22:38:40] alright [22:38:43] (CR) Kaldari: [ C: -1] "link remains active after thank action has been completed." [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/75822 (owner: Kaldari) [22:38:51] ragesoss: are you still seeing OOM errors? [22:39:30] last I tried, yes. [22:39:39] grr, okay [22:39:44] let me head to sleep now though [22:39:46] brb [22:40:05] my money's on the in-memory cache overloading the per-app memory limit on some devices [22:40:26] brion: not yet. prob need to discuss particulars too [22:40:30] I haven't tried nightlies since the last Play update. [22:40:52] Yuvi^ [22:40:52] ok [22:41:37] ragesoss: brion's on it, I think [22:42:19] it's on my list for next week yeah [22:42:44] since i can actually repro it sometimes on my nexus1 :) [22:43:37] :) [22:43:39] yeah [22:43:44] my Ace can't repro it [22:43:48] (2.3) [22:43:51] okay I should really go sleep [22:44:48] gnight :) [22:53:35] (CR) JGonera: [ C: 2] Revert "Fix: Tag mobile edits" [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/76206 (owner: JGonera) [22:54:01] (Merged) jenkins-bot: Revert "Fix: Tag mobile edits" [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/76206 (owner: JGonera) [22:54:46] (CR) Yurik: "(2 comments)" [extensions/ZeroRatedMobileAccess] - https://gerrit.wikimedia.org/r/76201 (owner: Yurik) [23:18:35] (PS1) JGonera: Show error message on CAPTCHAs and extension errors [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/76215 [23:21:12] [Commons-iOS] montehurd opened pull request #112: Better details scroll margin calculation. (master...detailsScrollMargin) http://git.io/nTPFbw [23:22:45] brion: ^ on iPad the details slider would only scroll a portion of the way up the screen. improved the calculation to allow the content, whatever its size, to scroll all the way up [23:28:20] spiff [23:29:17] [Commons-iOS] brion closed pull request #112: Better details scroll margin calculation. (master...detailsScrollMargin) http://git.io/nTPFbw [23:29:32] brion: yay thanks! [23:29:49] :D [23:31:10] brion: were there any other things you'd like to add to the etherpad for the monday design chat? (http://etherpad.wmflabs.org/pad/p/wm-mobile-design-jul) [23:32:03] (PS6) Kaldari: Adding 'thank' link to MobileDiff view [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/75822 [23:32:09] nothing off the top of my head, but i'll keep the link open in case anything comes to mind :) [23:32:22] brion: cool [23:34:31] (CR) Kaldari: "@Jdlrobson: Since the way you refactored it didn't really make sense for a link, I went ahead and changed it to a button. Hope you're happ" [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/75822 (owner: Kaldari) [23:37:37] (PS4) MaxSem: Simplify opt-in cookies [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/74667 [23:41:27] (PS2) JGonera: Show error message on CAPTCHAs and extension errors [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/76215 [23:48:23] brion: thinking about heading out at 5... [23:49:08] mhurd: feel free :)