[00:16:14] (03PS4) 10Dr0ptp4kt: Continuation of PhantomJS automation tests for Wikipedia Zero. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/76226 [00:16:39] (03CR) 10Dr0ptp4kt: "Intermediate save" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/76226 (owner: 10Dr0ptp4kt) [02:23:42] (03PS5) 10Dr0ptp4kt: Continuation of PhantomJS automation tests for Wikipedia Zero. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/76226 [02:23:59] (03CR) 10Dr0ptp4kt: "Intermediate save." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/76226 (owner: 10Dr0ptp4kt) [03:15:32] (03CR) 10Yurik: "(2 comments)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/75289 (owner: 10Yurik) [03:16:45] (03PS2) 10Yurik: Handle MobileFrontendBeforeDOM hook instead of double parsing [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/75289 [03:17:08] (03CR) 10Yurik: "PS2 is a rebase" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/75289 (owner: 10Yurik) [03:17:32] (03PS2) 10Yurik: Removed X-CS dependency in HTML content rewriting [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/76201 [03:46:00] (03PS1) 10Mgrover: change content_0 element to content to fix tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/77997 [03:47:04] moooobile [03:47:38] (03CR) 10Mgrover: [C: 032] "minor tweak to fix broken automation tests" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/77997 (owner: 10Mgrover) [03:47:58] (03Merged) 10jenkins-bot: change content_0 element to content to fix tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/77997 (owner: 10Mgrover) [04:04:33] mhurd: yuvipanda you guys online? i'll wander back your way shortly :) [04:04:42] brion: ya! [04:04:46] \o/ [04:04:49] how's intellij going? [04:05:12] if you see sumana send her up to get her stuff so i can go back to you guys ;) [04:05:36] brion: will do [04:06:24] brion: about to begin intellij install - i think yuvi has installer [04:07:36] \o/ [04:08:52] hah so we put in a support req with comcast about the xbox Xfinity app not working [04:09:00] it's been escalated three times and they're sending a tech out tomorrow :P [04:09:07] everything else works, just not their damn xbox tv app [04:47:28] (03CR) 10Brion VIBBER: "Are we closer to pushing this or should we abandon for now?" [apps/android/commons] - 10https://gerrit.wikimedia.org/r/73981 (owner: 10SuchABot) [04:47:52] (03CR) 10Brion VIBBER: "Didn't bring my 2.3 device with me to HK but I've got emulators galore -- I'll do some testing." [apps/android/commons] - 10https://gerrit.wikimedia.org/r/76346 (owner: 10SuchABot) [04:48:53] (03PS3) 10Yurik: Removed X-CS dependency in HTML content rewriting [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/76201 [04:49:40] (03CR) 10Yurik: "(6 comments)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/76201 (owner: 10Yurik) [05:14:33] (03PS1) 10Pypt: Render the list of categories as a normal subheading for logged in mobile users. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/77999 [05:16:20] (03PS2) 10Yuvipanda: Add proofread app support [apps/android/translate] - 10https://gerrit.wikimedia.org/r/77558 (owner: 10Orsagi) [06:19:28] MaxSem, ping [06:19:38] pong [06:20:04] hi! do you know by any chance how to output raw text from inside the special page? [06:20:11] so that its not wrapped in proper html? [06:21:50] i looked at the action=raw [06:25:55] yurik, getCategoryLinks [06:26:00] erg [06:26:02] https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/esisupport/includes/specials/SpecialEsi.php [06:26:25] wa? what's that? [06:26:41] we already have ESI support built in? [06:31:34] no [06:31:35] it [06:31:40] s [06:31:47] an abandoned branch [06:40:25] bleh, i had such high hopes :) [06:41:48] MaxSem, has it ever even been tested? according to varnish doc, should be a self-closing tag, not sure if it will even handle [06:42:20] I thought everyone agrred that ESI is evil [06:42:37] i was told that ESI is ok if used sparingly [06:43:01] like 1 banner per page :) [06:46:38] btw have you seen https://bugzilla.wikimedia.org/show_bug.cgi?id=52536 [06:47:05] thx, no [06:47:07] weird [06:48:01] i reeeally don't like bugzilla :( [06:48:52] bugzilla loves you [08:38:12] [13Commons-iOS] 15pypt opened pull request #117: Replace "toolbar-view" ("Open in Safari") with UIActivity (06master...06master) 02http://git.io/WLpPEQ [08:44:43] pypt: thanks again! [08:45:15] no problem :) give me more work while the DevCamp is on! [08:45:21] pypt: yes!!! [10:06:49] if I'm trying to make a skin of my own, how do I specify the css and js files? [15:42:33] (03CR) 10Orsagi: [C: 032 V: 032] Add proofread app support [apps/android/translate] - 10https://gerrit.wikimedia.org/r/77558 (owner: 10Orsagi) [15:55:37] is git.wikimedia.org down? [15:56:00] anyone? [17:36:18] yurik, running core master and MobileFrontend master in the Vagrant instance, change 76201 patchset 3 is resulting in a stack trace. any hints on getting it working? [17:36:36] dr0ptp4kt, checking... [17:38:09] dr0ptp4kt, what request are you making [17:39:01] works for me [17:39:12] can you paste stacktrace in pastebin [17:40:19] http://localhost:8080/wiki/Main_Page and http://localhost:8080/wiki/Main_Page?useformat=mobile [17:40:27] ^yurik, one moment [17:40:44] yurik, *only* enabling MobileFrontend works, though. ok, to the pastebin [17:41:29] nope, nothing on my side. dr0ptp4kt, make sure everything is up to date (mobile, core) [17:42:27] yeah, i git pulled core and MobileFrontend, which are both on master. i used the gerrit commands from the web ui [17:43:28] yurik, http://pastebin.com/eg7w0YK9 [17:45:24] dr0ptp4kt, i suspect this is related to the ori's patch recently. Double check everything else is up to date [17:46:33] yurik, that would probably make sense. have you tried a git pull on core and MobileFrontend today? plus issued a git fetch https://dr0ptp4kt@gerrit.wikimedia.org/r/mediawiki/extensions/ZeroRatedMobileAccess refs/changes/01/76201/3 && git checkout FETCH_HEAD to get ZeroRatedMobileAccess updated to the latest patchset? [17:46:42] ohh, forgot [17:46:45] something else [17:46:49] one sec [17:46:53] yurik, cool, thx [17:49:16] dr0ptp4kt, add $wgGroupPermissions['zeroadmin']['zero-edit'] = true; to your config [17:49:26] not sure if that would fix it though [17:50:16] dr0ptp4kt, but in any case, i strongly suspect that you will get this error if you check out master [17:52:26] yurik, yeah, same error. what commit hashes are you at on core and mf? [17:52:38] yurik, i was thinking i will just get checkout to sync with what you have [17:52:46] s/get checkout/git checkout/ [17:53:03] do a git pull on core & mobile [17:53:08] what's the command to see hash? [17:53:42] core - 866ff31d8a1a4650f8730c35985932c501284f54 [17:55:48] dr0ptp4kt, mobile -- 64e9133b276d6cb34d861fb808b718ab784efee1 [17:56:33] dr0ptp4kt, i will try to use your settings, see if that changes anything [17:57:08] cool, and i'll try yours :) what do you have for core? [17:57:29] yurik, that is to say, the mediawiki folder embodiment of core in the vagrant instance [17:58:45] dr0ptp4kt, http://pastebin.com/SQRBh8ag [17:59:41] dr0ptp4kt, found it [17:59:45] $wgZeroRatedMobileAccessEnableZeroConfigPages = true; [17:59:53] investigating [18:01:23] yurik, cool, thx. i commented that out. i don't have the json config editor or other extensions installed, just mf and zrma. not that those subdependencies should technically matter, just saying. [18:07:52] (03PS1) 10Yurik: Fix for CanonicalNamespace hook [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/78086 [18:08:22] dr0ptp4kt, ^^ +2 asap please [18:13:26] dr0ptp4kt, was restarting, if you said anything [18:22:29] (03CR) 10Dr0ptp4kt: [C: 04-1] "Added comments to Patchset 1 that can be considered for Patchset 4." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/76201 (owner: 10Yurik) [18:25:07] (03CR) 10Dr0ptp4kt: [V: 04-1] "(1 comment)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/76201 (owner: 10Yurik) [18:26:57] (03CR) 10Dr0ptp4kt: [C: 032] Fix for CanonicalNamespace hook [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/78086 (owner: 10Yurik) [18:27:00] (03Merged) 10jenkins-bot: Fix for CanonicalNamespace hook [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/78086 (owner: 10Yurik) [18:28:53] yurik, sorry for delay. i just +2'd that 1 line reduction. [18:36:08] (03CR) 10Yurik: "(1 comment)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/76201 (owner: 10Yurik) [18:36:24] dr0ptp4kt, not sure why you blocked the verify [18:36:26] a bit confused [18:37:56] (03PS4) 10Yurik: Removed X-CS dependency in HTML content rewriting [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/76201 [18:38:09] yurik, isn't Verified for functional test outcomes? [18:38:25] no, verified is for automated testing [18:38:36] we should never touch it - only review [18:38:40] yurik: [18:38:51] LOL [18:39:36] yurik, okay, sorry, i thought the block on +1 and +2 Verified, but retain of 0 and -1 was to allow for functionality testing. i'm cool with just using the code review feature :) [18:39:58] np :) [18:40:42] so are the 0 and -1 on Verified supposed to be modified only by people's automation test scripts as part of something like their own jenkins jobs? i understand that in practice some jenkins jobs automatically -1 stuff (e.g., js linting), but that can be overridden with a +2 in the code review spot. [18:43:33] (03PS1) 10Yurik: ESI handling of the banner [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/78091 [18:56:59] dr0ptp4kt, not sure exactly why it is even there, possibly for override purposes, but i don't think we should ever do it in the regular course of action [18:57:38] do what? sorry, not sure of the context of that statement :) [19:04:58] dr0ptp4kt, the "verify" +1/-1 thing [19:05:19] yurik, oh, yeah. ha. got it. [19:23:28] (03CR) 10Dr0ptp4kt: [C: 04-1] "(1 comment)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/78091 (owner: 10Yurik) [19:47:50] yurik, walked around the block after disconnecting wifi, so wouldn't have seen recent messages last 10-15 mins... [19:54:37] (03PS6) 10Dr0ptp4kt: Continuation of PhantomJS automation tests for Wikipedia Zero. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/76226 [19:55:00] (03CR) 10Dr0ptp4kt: "Just rebasing." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/76226 (owner: 10Dr0ptp4kt) [20:08:54] are there any developers for phone apps in the channel? I have a question someone might be interested in helping with [20:21:37] Ktr101, i believe most of the people are at Wikimania, probably sleeping (it's in Hong Kong). you may want to try emailing the mobile-l@lists.wikimedia.org list (be sure to sign up and confirm your account first) [20:21:49] ah [20:21:51] fudge [20:22:07] https://play.google.com/store/apps/details?id=com.mim1999.unvisited&hl=en i'm looking for anyone who can translate this to ios [20:22:23] simple app, has received praise from the wlm mailing list [20:25:39] Ktr101, that looks pretty neat! you should definitely email the list or put in a feature request at bugzilla.wikimedia.org for wikimedia commons app, or both! [20:26:10] i've gone ahead and created a page on commons, although it is so simple i'd rather not advertise it :D [20:26:43] Ktr101, not sure what any eventual mapping features will rely upon (Google Maps v OSM v other alternatives v some combination). hey, don't be afraid to share, that's what ideation and iteration and other i-words are about! [20:26:53] lol [20:27:10] i'm for isolation, ignorance, and other i-words that i can't think of [20:28:07] Ktr101, ha :) [20:32:06] sent [20:32:14] god, yet another list i'm on [20:35:35] Ktr101, thx, i see it. mailing lists are great! until your inbox has hundreds of messages every morning even when all lists are in digest mode! [20:36:23] one thing i started doing was signing up for both digest and non-digest mode. then i send the non-digested messages to a folder that i can go to in case i need to reply to an individual thread. [20:37:08] i guess there are some mail clients and services that will resolve message IDs for replying to specific messages from a digest, but i like to keep stuff within my webmail when possible. [20:45:29] join acc [20:45:43] it's horrible on some days [22:29:09] (03PS7) 10Dr0ptp4kt: Continuation of PhantomJS automation tests for Wikipedia Zero. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/76226 [22:29:37] (03CR) 10Dr0ptp4kt: "Intermediate save." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/76226 (owner: 10Dr0ptp4kt) [22:35:49] (03PS8) 10Dr0ptp4kt: Continuation of PhantomJS automation tests for Wikipedia Zero. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/76226 [22:36:43] (03CR) 10Dr0ptp4kt: "Intermediate save." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/76226 (owner: 10Dr0ptp4kt)