[17:27:52] <brion>	 wtf amazon tracking
[17:28:04] <brion>	 so my dual-sim phone is listed as 'out for delivery' yesterday morning
[17:28:12] <brion>	 and not delivered
[17:28:27] <brion>	 how long a run is this driver making?? :)
[17:34:38] <brion>	 ok, time to find the compressed air and clear out all the dust. :P
[18:04:01] <grrrit-wm>	 (03PS2) 10Jdlrobson: Alpha: UserProfile special page (first pass) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76271 
[18:04:02] <grrrit-wm>	 (03PS1) 10Jdlrobson: Bug 52856: Fix the thank button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79079 
[18:04:07] <grrrit-wm>	 (03PS1) 10Jdlrobson: Allow showing of other users uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79080 
[18:04:08] <grrrit-wm>	 (03PS1) 10Jdlrobson: Improving styling of button on following pages: [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79081 
[18:30:35] <grrrit-wm>	 (03CR) 10Jdlrobson: "Waiting on Max, Kaldari Arthur to check the PHP code..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/77999 (owner: 10Pypt)
[18:31:05] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Change settings page heading [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/78638 (owner: 10JGonera)
[18:31:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Change settings page heading [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/78638 (owner: 10JGonera)
[19:10:56] <grrrit-wm>	 (03PS3) 10Jdlrobson: Story 986: Log watchlist interactions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76025 
[19:55:46] <grrrit-wm>	 (03CR) 10Jdlrobson: "(4 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76025 (owner: 10Jdlrobson)
[20:09:14] <grrrit-wm>	 (03PS6) 10Dr0ptp4kt: Removed X-CS dependency in HTML content rewriting [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/76201 (owner: 10Yurik)
[20:10:34] <dr0ptp4kt>	 ^yurik, i made a small change for the partner banner to have the rewrite logic as well. it will work for now with non-esi, but would need to know a safe Title in the esi case, i guess.
[20:11:11] <yurik>	 dr0ptp4kt, oki, will take a look
[20:11:16] <dr0ptp4kt>	 yurik, anyhow, was hoping you could take a look and incorporate into the next patchset. my <a> onclck code is going to look at both the css class and the rough format of the hyperlink href
[20:11:32] <dr0ptp4kt>	 yurik, thanks
[20:23:19] <pragunbhutani>	 jdlrobson: Hello there!
[21:03:30] <jdlrobson>	 pragunbhutani: still there?
[21:12:24] <pragunbhutani>	 jdlrobson: right here
[21:12:31] <jdlrobson>	 pragunbhutani: great
[21:12:34] <pragunbhutani>	 just stepped away to grab a snack
[21:12:37] <pragunbhutani>	 how was your trip?
[21:13:44] <jdlrobson>	 great :) bit jet lagged though!
[21:14:21] <pragunbhutani>	 jdlrobson: okay what I'm trying to do as of now is get the skin mocked up and uploaded on my labs instance
[21:14:46] <pragunbhutani>	 that way, whenever Katie gets time again, we'll be able to look over how we want to deal with the parser output
[21:14:55] <pragunbhutani>	 now, referring to the gist you'd shared with me
[21:15:51] <pragunbhutani>	 should I copy the contents of gistfile1.txt into Resources.php, verbatim?
[21:32:16] <pragunbhutani>	  jdlrobson : ping when back please
[21:32:26] <jdlrobson>	 back
[21:32:31] <jdlrobson>	 (was waiting for you to ping me :))
[21:33:07] <jdlrobson>	 pragunbhutani: do you have your own extension or are you making a fork of MobileFrontend
[21:34:25] <pragunbhutani>	 jdlrobson: I'm not entirely sure, but I think it'll be a fork of MobileFrontend
[21:34:44] <pragunbhutani>	 or rather, extending MobileFrontend using that method that you'd described earlier
[21:36:52] <pragunbhutani>	 jdlrobson: that was the idea anyway, to have Parser Output provide Wikibase html to MobileFrontend and then extend Mobile Frontend to be able to display Wikibase content
[21:38:24] <jdlrobson>	 pragunbhutani: it would be better to have your own extension
[21:39:07] <pragunbhutani>	 jdlrobson: can you elaborate on that please?
[21:39:31] <jdlrobson>	 pragunbhutani: sure.
[21:39:39] <jdlrobson>	 pragunbhutani: so you have 2 options
[21:39:55] <jdlrobson>	 1) you git clone MobileFrontend and make tweaks in the codebase to add WikiData skin.
[21:40:32] <jdlrobson>	 or 2) You create a new extension or use a Wikidata extension which includes the skin
[21:40:39] <jdlrobson>	 i am suggesting you go with the latter
[21:40:49] <jdlrobson>	 that way you will benefit from MobileFrontend upstream changes
[21:41:37] <pragunbhutani>	 jdlrobson: hmm, okay so assuming that we decide to go with the second option
[21:41:44] <pragunbhutani>	 what kind of work would that require?
[21:41:47] <jdlrobson>	 So say your extension is called WikiDataSkin you'll have a WikiDataSkin.php file which sets the skin and adds the resource loader modules
[21:42:24] <jdlrobson>	 http://www.mediawiki.org/wiki/Manual:Developing_extensions < pragunbhutani 
[21:42:46] <jdlrobson>	 in LocalSettings.php you just make sure it is included AFTER MobileFrontend
[21:43:03] <jdlrobson>	 so require_once require_once "$IP/extensions/MobileFrontend/MobileFrontend.php"; "$IP/extensions/MyExtension/MyExtension.php"; 
[21:44:28] <pragunbhutani>	 jdlrobson: can the extension be programmed to set the skin only in the case when a mobile device is being used to access Wikidata?
[21:44:49] <jdlrobson>	 pragunbhutani: the extension would only be installed on Wikidata
[21:45:08] <jdlrobson>	 (unless i misunderstand)
[21:45:34] <pragunbhutani>	 jdlrobson: what I meant was, we needn't make any changes to the skin if it's being viewed through a computer
[21:47:51] <jdlrobson>	 you mean desktop?
[21:48:05] <jdlrobson>	 MobileFrontend already supports desktop and mobile mode
[21:48:21] <jdlrobson>	 your extension just needs to tweak the mobile skin that MobileFrontend provides.
[21:49:38] <pragunbhutani>	 jdlrobson: ah okay I understand a little better now
[21:49:40] <grrrit-wm>	 (03PS1) 10Jdlrobson: Story 920: Force upload CTA on beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79160 
[21:50:00] <pragunbhutani>	 and this tweaking of the skin will be done in the same way as you had described earlier?
[21:50:27] <pragunbhutani>	 class SkinMobileWikidata extends SkinMinerva 
[21:50:40] <jdlrobson>	 pragunbhutani: yup. So all your extension would need to do is define the skin
[21:51:08] <jdlrobson>	 in your LocalSettings.php you just set $wgMFDefaultSkinClass to your skins name
[21:51:09] <pragunbhutani>	 jdlrobson: okay, so far so good!
[21:51:51] <jdlrobson>	 pragunbhutani: i'd suggest as step one you paste $wgMFDefaultSkinClass = 'SkinWikiDataMobile';
[21:51:55] <jdlrobson>	 into your LocalSettings.php
[21:51:58] <jdlrobson>	 this will break the mobile view
[21:52:03] <jdlrobson>	 your goal is then to make that work :)
[21:55:18] <grrrit-wm>	 (03PS1) 10Jdlrobson: Bug 52207: Support reCaptcha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79162 
[21:57:36] <pragunbhutani>	 jdlrobson: okay, I just did that
[21:57:50] <pragunbhutani>	 jdlrobson: and I also applied the changes you'd shared with me on that github gist
[21:58:07] <pragunbhutani>	 I've got 'hello world' instead of the body text now
[21:58:12] <jdlrobson>	 sweet
[21:58:21] <jdlrobson>	 so you can see where hello world is set yes?
[21:58:36] <pragunbhutani>	 yes
[21:58:51] <jdlrobson>	 ok great.
[21:58:56] <pragunbhutani>	 $tpl->set( 'foo', 'hello world' )
[21:58:57] <jdlrobson>	 are you able to add your own css as well?
[21:59:09] <pragunbhutani>	 I presume I can replace that with a string containing the html?
[21:59:46] <pragunbhutani>	 jdlrobson: and as for the css, I wanted to confirm
[21:59:55] <pragunbhutani>	 can I copy the text from https://gist.github.com/jdlrobson/6208287#file-gistfile1-txt verbatim?
[22:00:09] <jdlrobson>	 pragunbhutani: so $wgResourceModules is simply an array of modules
[22:00:14] <jdlrobson>	 the key is the module name and the value is the module itself
[22:00:26] <jdlrobson>	 in the skin you add the module by referencing it's module name
[22:00:38] <jdlrobson>	 so in your WikiData.php file you simply need to register the module
[22:00:50] <jdlrobson>	 e.g. $wgResourceModules['foo'] = array( 'styles' => ...
[22:01:00] <jdlrobson>	 and then in your skin add it
[22:01:28] <jdlrobson>	 make sure you understand what that gist is doing :)
[22:01:59] <pragunbhutani>	 jdlrobson: I was able to follow everything except that last part, concerning the resource loading
[22:02:23] <jdlrobson>	 http://www.mediawiki.org/wiki/Manual:$wgResourceModules < pragunbhutani 
[22:04:00] <pragunbhutani>	 jdlrobson: okay, so what I understand is, that I need to register this resource module from within WIkidata (and not the mobile extension) and afterwards, I can supply the css files with the skin
[22:05:22] <jdlrobson>	 exactly
[22:05:32] <jdlrobson>	 you shouldn't need to touch MobileFrontend extension at all
[22:05:45] <jdlrobson>	 if you are changing any code there then you are probably doing it wrong - and should show me :)
[22:06:13] <pragunbhutani>	 jdlrobson: at the moment, I have made some changes to mobile frontend actually
[22:06:28] <pragunbhutani>	 but that's just because I've placed my skin inside MF/includes/skins
[22:06:45] <pragunbhutani>	 and then had to set the corresponding values in MobileFrontend.php
[22:06:47] <jdlrobson>	 you can do that in your own extension - should be just a case of moving them over
[22:07:22] <pragunbhutani>	 yeah, that's for sure
[22:07:51] <grrrit-wm>	 (03PS7) 10Dr0ptp4kt: Removed X-CS dependency in HTML content rewriting [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/76201 (owner: 10Yurik)
[22:08:19] <pragunbhutani>	 jdlrobson: I'll be able to load those classes from within my extension as well?
[22:08:30] <jdlrobson>	 yup
[22:08:33] <pragunbhutani>	 I should definitely go and read the manual on developing extensions
[22:08:49] <pragunbhutani>	 ah, so that's why you said that it should be included after MF in localSettings
[22:09:01] <pragunbhutani>	 because I'll be extending classes from MF
[22:10:02] <pragunbhutani>	 jdlrobson: okay, awesome!
[22:10:09] <pragunbhutani>	 things are so much clearer now than yesterday
[22:10:30] <pragunbhutani>	 jdlrobson: I'm going to be hacking around today as well so I'm sure there will be more doubts tomorrow
[22:10:35] <pragunbhutani>	 but at least I'm not stuck now :)
[22:10:42] <jdlrobson>	 ok good
[22:13:53] <pragunbhutani>	 jdlrobson: I noticed on your twitter feed that you've been to India?
[22:15:12] <dr0ptp4kt>	 ^yurik, JavaScript-based interstitial included. i also made it so that CSS & JS addmodule stuff happens only if the config is not null, so as to avoid unnecessary stuff in regular mdot browsing; i think i may need to tweak the logic, though for 'not supported' people.
[22:15:20] <jdlrobson>	 pragunbhutani: back in november yes!
[22:16:45] <pragunbhutani>	 jdlrobson: awesome! what part did you visit?
[22:17:28] <jdlrobson>	 pragunbhutani: i flew in to bangalore and went to hampi, goa, aurangabad and delhi with yuvipanda 
[22:18:35] <pragunbhutani>	 Nice. I hope I get a chance to run into YuviPanda sometime as well. Maybe the next time there's a hackathon in India.
[22:25:50] <grrrit-wm>	 (03PS8) 10Dr0ptp4kt: Removed X-CS dependency in HTML content rewriting [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/76201 (owner: 10Yurik)
[22:26:17] <dr0ptp4kt>	 ^yurik, there, that should fix it for the case where the user is on zerodot and the config is null. enjoy!
[22:26:50] <pragunbhutani>	 jdlrobson: okay I've just noticed something strange
[22:27:18] <jdlrobson>	 pragunbhutani: what's that?
[22:27:28] <pragunbhutani>	 if I change the text in $tpl->set( 'foo', 'hello world') to anything else
[22:27:42] <pragunbhutani>	 I still see hello world in the skin!
[22:31:36] <pragunbhutani>	 jdlrobson: now I don't understand where this 'hello world' is coming from!
[22:31:48] <pragunbhutani>	 it's certainly not getting that from SkinMobileWikidata
[22:32:24] <grrrit-wm>	 (03CR) 10Jdlrobson: "I really dislike the pattern of mw.config.get( 'wgMFMode' ) === 'alpha' ? 'tap' : 'click'" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/78632 (owner: 10JGonera)
[22:32:57] <jdlrobson>	 did you change this in your extension or in the MobileFrontend extension?
[22:33:05] <jdlrobson>	 it could be caching or you're changing the wrong file..
[22:33:51] <pragunbhutani>	 in MobileFrontend
[22:33:58] <pragunbhutani>	 I'm yet to make my own extension
[22:34:41] <pragunbhutani>	 jdlrobson: ah sorry, seems like it was caching
[22:34:47] <pragunbhutani>	 incognito solved it
[22:35:51] <grrrit-wm>	 (03PS4) 10Jdlrobson: Fixes a bug with the display of the fixed userinfo panel when the left-nav is open. It now behaves the same as the article content - squishing at large screen sizes and clipping on small screens. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76659 (owner: 10Kaldari)
[22:39:19] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76659 (owner: 10Kaldari)
[22:58:04] <grrrit-wm>	 (03PS1) 10Jdlrobson: Bug 51977: Hide the talk icon when refreshing talk pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79167 
[23:28:35] <grrrit-wm>	 (03PS2) 10Dr0ptp4kt: META Wikipedia Zero automation probe banner outcomes. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/78265 
[23:30:59] <dr0ptp4kt>	 ^yurik, there, iframes instead of images for the META config pages
[23:33:47] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: [C: 031] "It's working." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/78265 (owner: 10Dr0ptp4kt)