[15:35:40] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] "I'm currently rewriting the whole dynamic loading and Page view thing because the current implementation makes it impossible to reliably e" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79167 (owner: 10Jdlrobson)
[15:42:30] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/78336 (owner: 10Jdlrobson)
[15:49:36] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79080 (owner: 10Jdlrobson)
[16:19:57] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Bug 52207: Support reCaptcha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79162 (owner: 10Jdlrobson)
[16:20:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: Bug 52207: Support reCaptcha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79162 (owner: 10Jdlrobson)
[16:55:19] <grrrit-wm>	 (03CR) 10Jdlrobson: "Will it be done and merged by next deployment? If not I'd suggest just merging this and then rewriting it.." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79167 (owner: 10Jdlrobson)
[17:14:51] <grrrit-wm>	 (03PS2) 10Jdlrobson: Allow showing of other users uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79080 
[17:24:43] <grrrit-wm>	 (03PS2) 10Jdlrobson: Bug 52511: Make editor load correct page for ajax loaded pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/78336 
[17:27:16] <jdlrobson>	 jgonera: https://gerrit.wikimedia.org/r/#/c/74813/ < waiting for a response on this - should i stop working on this or is it worth more work?
[17:28:52] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "-1ing purely to get your attention." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/78632 (owner: 10JGonera)
[17:29:38] <jgonera>	 jdlrobson, if we rename it to assertMode() I guess it's ok as a double precaution
[17:29:44] <jdlrobson>	 ok cool. i'll do that now then
[17:30:01] <jdlrobson>	 also not sure what to do about https://gerrit.wikimedia.org/r/74684
[17:30:12] <jdlrobson>	 can't find a way to get it working in debug mode :(
[17:32:13] <grrrit-wm>	 (03CR) 10JGonera: "I was thinking about it too, but didn't do it since such an abstraction would be unnecessary if we pushed that to stable at some point." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/78632 (owner: 10JGonera)
[17:34:10] <jgonera>	 I haven't had a look at it. I'd suggest splitting that into two patches: one making MFResourceLoaderModule support files and another cleaning up Resources.php (this can be done later)
[17:34:25] <jgonera>	 this way we can take more time playing with MFResourceLoaderModule without the risk of scary rebasing
[17:39:21] <jdlrobson>	 btw jgonera Took 436ms to run 278 tests. 278 passed, 0 failed. < in debug mode and Took 449ms to run 297 tests. 297 passed, 0 failed. < in normal mode for qunit tests
[17:39:32] <jdlrobson>	 any idea what's going on?
[17:39:36] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Start enforcing modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/74813 
[17:39:53] <jdlrobson>	 jgonera: sure.. but I have to change one Resource to make sure it works :)
[17:42:53] <jdlrobson>	 jgonera: are you sure about your -webkit-tap-highlight-color rule? that only applies to the body element
[17:45:05] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] "It still seems very icky." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/78632 (owner: 10JGonera)
[17:45:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make tapping more responsive [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/78632 (owner: 10JGonera)
[18:39:34] <grrrit-wm>	 (03PS2) 10Jdlrobson: Bug 49647: Take away History.js dependency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/70953 
[18:40:48] <multichill>	 jdlrobson: What code is used again to extract the relevant image of an article? Looking for it 
[18:41:29] <jdlrobson>	 multichill: what do you mean?
[18:41:35] <jdlrobson>	 the page image shown on nearby?
[18:41:42] <multichill>	 exactly
[18:41:49] <jdlrobson>	 PageImages extension provides that
[18:42:14] <multichill>	 Is that on the fly or stored in db?
[18:42:49] <jdlrobson>	 it computes them when the article is saved - i think it's stored as a property
[18:42:50] <jdlrobson>	 https://en.m.wikipedia.org/w/api.php?format=json&action=query&prop=pageimages&titles=San+Francisco%7CSaint+Petersburg%7CSan+Diego%7CSaudi+Arabia%7CSaskatchewan%7CS%C3%A3o+Paulo%7CSalt+Lake+City%7CSan+Antonio%7CSaxophone%7CSanskrit%7CSacramento%2C+California%7CSandstone%7CSan+Francisco+Chronicle%7CSantiago%7CSan+Francisco+Giants&pithumbsize=80&pilimit=50
[18:42:56] <jdlrobson>	 ^ example api query
[18:43:01] <jgonera>	 jdlrobson, heading out for today, do you need anything?
[18:43:09] <jdlrobson>	 jgonera: all the patches...
[18:43:27] <jdlrobson>	 just need them all merged by end of the week - the list is getting pretty ridiculous
[18:43:42] <jdlrobson>	 i'm not sure when our next deployment is but we should have them all merged by then at bare minimum
[18:43:45] <grrrit-wm>	 (03CR) 10JGonera: [C: 032] Allow showing of other users uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79080 (owner: 10Jdlrobson)
[18:44:04] <jdlrobson>	 (but nothing urgent since we don't have a deployment)
[18:44:29] <multichill>	 jdlrobson: Ok, found it, thank you
[18:44:37] <jdlrobson>	 multichill: great
[18:44:45] <jgonera>	 ok, let me do it tomorrow then
[18:45:39] <multichill>	 jdlrobson: Great source for wikidata to start with. Take qnumber + pageimage and insert that
[18:45:53] <jdlrobson>	 jgonera: thanks
[18:46:39] <grrrit-wm>	 (03PS12) 10Jdlrobson: Story 921: Adding editing tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/74309 (owner: 10Kaldari)
[18:46:43] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Story 921: Adding editing tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/74309 (owner: 10Kaldari)
[18:49:28] <grrrit-wm>	 (03CR) 10Jdlrobson: "er... i didn't mean to +2 this... doh. I'll do a follow up." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/78632 (owner: 10JGonera)
[18:50:45] <grrrit-wm>	 (03PS13) 10Jdlrobson: Story 921: Adding editing tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/74309 (owner: 10Kaldari)
[18:51:03] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Story 921: Adding editing tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/74309 (owner: 10Kaldari)
[18:51:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Story 921: Adding editing tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/74309 (owner: 10Kaldari)
[18:54:41] <multichill>	 jdlrobson: We have a lot of articles like https://nl.wikipedia.org/wiki/Spaarndam
[18:54:50] <multichill>	 Now https://commons.wikimedia.org/wiki/File:2010-NL-P07-Noord-Holland-positiekaart-gemnamen.jpg shows up as the image
[18:55:10] <multichill>	 Any idea how to tweak that? Getting the same map 20+ times is not very useful....
[18:56:18] <grrrit-wm>	 (03PS3) 10Jdlrobson: Allow showing of other users uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79080 
[18:57:48] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] "cherry picked exact same commit" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79080 (owner: 10Jdlrobson)
[18:58:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: Allow showing of other users uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79080 (owner: 10Jdlrobson)
[18:58:37] <jdlrobson>	 mmm multichill you'd have to ask MaxSem but it will just pick the first suitable image in the article
[18:58:46] <jdlrobson>	 it would be interesting to allow explicit picking of page images
[18:59:02] <multichill>	 *kuch* wikidata *kuch* 
[18:59:52] <MaxSem>	 mmm, I think we should just make the maps dynamic
[19:00:19] * jdlrobson  enters a fantasy world where all wiki maps were no longer images…

[19:00:25] <MaxSem>	 this way they will not appear in PI listings
[19:00:40] <MaxSem>	 ...in addition to a billion of other niceties
[19:00:40] <grrrit-wm>	 (03PS3) 10Jdlrobson: Alpha: UserProfile special page (first pass) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76271 
[19:01:20] <grrrit-wm>	 (03PS2) 10Jdlrobson: Improving styling of button on following pages: [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79081 
[19:05:13] <grrrit-wm>	 (03PS2) 10Jdlrobson: Story 920: Force upload CTA on beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79160 
[19:06:55] <multichill>	 MaxSem: Is http://pastebin.ca/2432362 correct? nearby looks kind of freaky on nlwp
[19:07:12] <multichill>	 Source includes an image, but I don't see any
[19:07:41] <multichill>	 https://nl.wikipedia.org/wiki/Speciaal:InDeBuurt#item_10
[19:09:01] <MaxSem>	 unfortunately, I can't see your nearby:
[19:09:03] <MaxSem>	 )
[19:12:16] <jdlrobson>	 MaxSem: https://bugzilla.wikimedia.org/show_bug.cgi?id=51924 < any ideas of a more generic way to do this?
[19:12:44] <jdlrobson>	 also multichill if you can tell MaxSem your long/lat it's possible to force the browser to use a mock location
[19:12:52] <MaxSem>	 I see no problem with MP special-casing
[19:14:32] <multichill>	 Oh right, hold on
[19:15:10] <multichill>	 https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=ext.centralNotice.bannerController%7Cext.uls.displaysettings%2Ci18n%2Cime%2Cinit%2Cinputsettings%2Cinterface%2Clanguagenames%2Clanguagesettings%2Cpreferences%2Cwebfonts%7Cext.uls.webfonts.repository%7Cext.vector.footerCleanup%7Cext.wikimediaShopLink.core%7Cjquery.client%2Ccookie%2CdelayedBind%2Ci18n%2Cime%2CjStorage%2
[19:15:11] <jdlrobson>	 MaxSem: but surely this problem effects pages other than the Main page?
[19:15:12] <multichill>	 crap
[19:16:03] <multichill>	 "lat":"52.093800","lon":"5.119100"
[19:16:10] <multichill>	 MaxSem: ^
[19:16:12] <MaxSem>	 jdlrobson, I wonder if ppl who developed LastModified (E2?) encountered something like this
[19:16:22] <jdlrobson>	 MaxSem: it's a good question...
[19:25:36] <grrrit-wm>	 (03PS1) 10Jdlrobson: Bug 52857: Allow editing of sections containing h1s. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79230 
[19:27:07] <grrrit-wm>	 (03PS2) 10Jdlrobson: Bug 52857: Allow editing of sections containing h1s. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79230 
[19:27:26] <thedj>	 MaxSem: remember that transcluding actual content is rather rare (and actually advised against on wikipedia)
[19:27:49] <MaxSem>	 thedj, yes - but there are portals...
[19:28:10] <thedj>	 Main page truly is an exception in that, because it's a composition of 6 'trenches' of content summaries
[19:29:14] <thedj>	 yeah, but portals well... they are not maintained a lot in terms of content, so probably there it doesn't matter too much either.
[19:29:35] <thedj>	 very old is close to very very old.
[19:30:02] <thedj>	 but fresh is a long way from very old.
[19:47:26] <grrrit-wm>	 (03CR) 10MaxSem: [C: 04-1] "(8 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76271 (owner: 10Jdlrobson)
[19:51:03] <MaxSem>	 hmm, calendar just told me that code hygiene day starts in 10 minutes:P
[20:21:35] <jdlrobson>	 MaxSem: :)
[20:21:45] <jdlrobson>	 MaxSem: gonna try and fix up the user profile stuff before you go to sleep - when will that be?
[20:22:03] <MaxSem>	 not sure after all these travels:P
[20:22:17] <jdlrobson>	 tell me about it MaxSem !
[20:22:21] <jdlrobson>	 my body is so confused
[20:22:31] <jdlrobson>	 i woke up at 3am last night dripping with sweat and confused where i was
[20:27:34] <jdlrobson>	 MaxSem: so on user profiles i do check for Echo being installed but not there… should i check it twice?
[20:27:55] <jdlrobson>	 i could make the function private instead
[20:28:20] <MaxSem>	 you should check on every execution path where it might lead to fatals/bugs
[20:28:24] <jdlrobson>	 ok
[20:28:56] <jdlrobson>	 if ( $wgEchoBackend ) { < MaxSem would that be a suitable test?
[20:29:31] <jdlrobson>	 also MaxSem apologies for my terrible sql i haven't written sql in php for a long time :)
[20:31:17] <Reedy>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=52895 Other text on page disappears after mobile edit
[20:53:07] <jdlrobson>	 Reedy: I haven't got filter rights so this bug doesn't make any sense to me.. what exactly is the problem?
[20:57:58] <Reedy>	 The filter hits for 2 of them suggest the complete contents of the article disappear, bar the section being edited
[20:58:57] <Reedy>	 But when you view the new revision it's fine
[20:59:04] <Reedy>	 So it might just be an AbuseFilter bug...
[21:11:20] <jdlrobson>	 mmm that's really weird Reedy
[21:25:40] <grrrit-wm>	 (03PS4) 10Jdlrobson: Alpha: UserProfile special page (first pass) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76271 
[21:25:53] <grrrit-wm>	 (03PS1) 10Jdlrobson: Bug 51924: Special case main page history link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79276 
[21:29:44] <Maryana>	 jdlrobson, you have mail
[21:30:11] <grrrit-wm>	 (03PS1) 10Jdlrobson: Bug 50952: Show a link on talk page back to subject page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79277 
[21:31:03] <jdlrobson>	 Maryana: nope
[21:31:09] <jdlrobson>	 oh there it is
[21:31:36] <jdlrobson>	 i didn't realize ryan had worked on it.. that sucks
[21:31:45] <jdlrobson>	 it's still in ready for dev.. he should have claimed it
[21:32:24] <Maryana>	 yeah, i'm not actually sure that he did anything...
[21:32:29] <Maryana>	 no clue
[21:32:29] <jdlrobson>	 why does the echo notification icon look like the talk page icon whilst logged out?
[21:32:58] <jdlrobson>	 also are we bringing back the W ?!
[21:32:59] <Maryana>	 yeaaahh… i mean, it's different-ish
[21:33:31] * jdlrobson  remembers how we only officially launched the random feature when we introduced the hamburger icon

[21:33:54] <jdlrobson>	 Maryana: So this helps with the notification overlay (somewhat)
[21:34:19] <jdlrobson>	 although the cross in the top left is departing from the back arrow we currently have.. which i assume is intentional but i was not in any of the overlay discussions so I don't know
[21:34:52] <Maryana>	 you still haven't looked at the whiteboards? :)
[21:35:04] <Maryana>	 now you're just being stubborn 
[21:35:14] <jdlrobson>	 Maryana: the whiteboards no longer exist
[21:35:19] <Maryana>	 still there
[21:35:27] <Maryana>	 want me to show you?
[21:35:34] <jdlrobson>	 this is why digital works best…. :/
[21:35:58] <Maryana>	 please direct all future process improvement suggestions to kenan ;)
[21:36:00] <jdlrobson>	 Maryana: even so i take the designs vibha and may do with a pinch of salt as they tend to do a lot of experimentation with ideas and it's never clear what they've settled on or not
[21:36:09] <jdlrobson>	 Maryana: i will do
[21:36:21] <jdlrobson>	 sorry if i'm coming across as more irritable then usual - my jet lag is kicking in
[21:36:30] <Maryana>	 nah, it's fine
[21:36:37] <jdlrobson>	 but i am very confused by the whole thing
[21:36:55] <Maryana>	 let's just wait for the designers to be back in the office before we pick up this discussion again
[21:37:14] <jdlrobson>	 anyway i'm going to head back and work from home and yeh i'll wait for them to get back - just a bit frustrating as it would have been nice to wrap this up.
[21:37:32] <Maryana>	 well, this is still the cougar bug-fixing iteration
[21:37:42] <Maryana>	 since we knew there'd be some chaos with people traveling and whatnot
[21:37:50] <jdlrobson>	 are you sure Maryana i'm still in beaver.. :)
[21:38:06] <Maryana>	 ha - ok, that's cos somebody forgot to update mingle
[21:38:22] <jdlrobson>	 anyway i have work to keep me busy so it's not the end of the world ;-)
[21:38:41] <jdlrobson>	 anyway leaving office now talk laters
[21:38:48] <Maryana>	 get some rest