[16:39:11] hey multichill [16:39:23] Hi yuvipanda, still in HK or are you back home? [16:39:30] multichill: still in HK [16:40:28] multichill: leaving in 12 hours [16:40:49] Did you find some place to stay? [16:40:53] multichill: oh yeah [16:41:35] multichill: i am just using the self| template [16:41:39] let me look at it [16:41:40] moment [16:41:56] self template? What are you talking about? [16:43:58] yuvipanda ? [16:50:20] multichill: moment, finding link [16:50:34] } else if(license.equals(Prefs.Licenses.CC_BY_SA)) { [16:50:34] return "{{self|cc-by-sa}}"; [16:50:35] multichill: ^ [16:50:40] aaaargh [16:50:41] so it just adds {{self|cc-by-sa}} [16:50:45] should it do something else? [16:50:45] That's wrong [16:51:00] isn't that what UploadWizard does? [16:51:06] or am I using the wrong templates? [16:51:16] https://commons.wikimedia.org/wiki/Template:Cc-by-sa -> https://commons.wikimedia.org/wiki/Template:Cc-by-sa-1.0 :-( [16:51:31] {{self|Cc-by-sa-3.0}} [16:51:55] multichill: gah, can you change that? [16:51:57] that sounds baaad [16:52:04] multichill: I'm going to submit a patch for that now [16:52:07] multichill: but still [16:54:00] What was the bug id again? [16:55:32] foudn it [16:56:39] if(license.equals(Prefs.Licenses.CC_BY)) { [16:56:39] return "{{self|cc-by-3.0}}"; [16:56:39] } else if(license.equals(Prefs.Licenses.CC_BY_SA)) { [16:56:40] return "{{self|cc-by-sa-3.0}}"; [16:56:42] } else if(license.equals(Prefs.Licenses.CC0)) { [16:56:44] return "{{self|cc0-3.0}}"; [16:56:46] } [16:56:48] multichill: ^ [16:56:50] ? [16:56:54] no [16:56:59] which was wrong? [16:57:06] f(license.equals(Prefs.Licenses.CC0) [16:57:32] {{self|Cc-zero}} [16:58:11] } else if(license.equals(Prefs.Licenses.CC0)) { [16:58:11] return "{{self|cc-zero}}"; [16:58:12] } [16:58:13] works? [16:58:22] multichill: bug link? [16:58:31] https://bugzilla.wikimedia.org/show_bug.cgi?id=52967 [16:58:40] Yup, that should work [17:00:42] (03PS1) 10Yuvipanda: Use CC 3.0 licenses explictly [apps/android/commons] - 10https://gerrit.wikimedia.org/r/79585 [17:00:45] multichill: ^ [17:01:33] multichill: looks good? I can self +2 [17:02:07] (03CR) 10Multichill: [C: 031] "Looks good to me" [apps/android/commons] - 10https://gerrit.wikimedia.org/r/79585 (owner: 10Yuvipanda) [17:02:28] (03CR) 10Yuvipanda: [C: 032 V: 032] Use CC 3.0 licenses explictly [apps/android/commons] - 10https://gerrit.wikimedia.org/r/79585 (owner: 10Yuvipanda) [17:02:30] multichill: done [17:02:38] multichill: thank you :) [17:06:17] multichill: feel free to close the bug [17:06:18] whenever [17:06:25] yuvipanda: Any idea when the next build will be out? [17:06:37] multichill: I can do that whenever, but I don't want to do it and then get on a plane [17:06:41] multichill: tuesday, perhaps? [17:07:08] Sounds good, maybe you post a message in the bug about that and close it after it was deployed? [17:07:34] multichill: ok