[16:37:30] jgonera: any idea about https://bugzilla.wikimedia.org/show_bug.cgi?id=52361 ? [16:38:51] jdlrobson, not yet, I'm fixing the tapping behavior on desktop now [16:38:59] btw I noticed more new bugs [16:39:08] login page has a "Categories" heading below the form [16:39:15] jgonera: there is something weird going on in that bug - i suspect it's a bug in View or Class [16:39:25] jgonera: eek. I can fix that now [16:39:46] jgonera: alpha only though right? [16:39:53] and I got some "calling undefined on object (assertMode)" or sth like that, but can't reproduce now [16:40:12] jdlrobson, don't know, I saw it on alpha because that's where I'm fixing tapping [16:40:22] jgonera: yeh categories are only in alpha.. i'll fix up [16:40:33] jgonera: assertMode problems sound like caching problems [16:41:16] jdlrobson, weird, I have cache disabled when the inspector is opened [16:41:25] I'll see if it happens again [16:41:32] jgonera: yep alpha only for categories.. fixing now [16:43:00] (03PS1) 10JGonera: Fix tap event fallback [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79814 [16:45:12] (03PS1) 10Jdlrobson: Don't render categories on special pages or if none [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79815 [16:45:34] jgonera: window.addEventListener … is that a good idea? [16:46:03] why not use on? [16:46:11] jdlrobson, it's explained in the comment [16:46:19] (in the first use) [16:47:11] https://developer.mozilla.org/en-US/docs/Web/API/EventTarget.addEventListener seems like all the browsers where we run JS should handle it [16:48:15] jgonera: no i understand you need to use useCapture i'm just surprised jQuery provides no abstraction for this [16:48:38] jdlrobson, I was surprised too [16:48:54] if you find that's not the case, I'll happily change it [16:51:08] it just seems icky and confusing using addEventListener in one single place. [16:52:04] jdlrobson, totally agree, we should submit a patch to jQuery when we find a moment, and then wait for core to update the jQuery it uses [16:52:15] where are we using the click fallback? [16:52:25] *callback [16:52:45] jdlrobson, I'm not sure I understand? where or why? [16:52:50] where and why [16:54:00] (03CR) 10MaxSem: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79815 (owner: 10Jdlrobson) [16:54:26] MaxSem: I was maybe being paranoid [16:54:31] line 15, to avoid weird ghostclicks (when tapped element moves, the element that now occupies its old position gets clicked, see test in https://github.com/jgonera/micro.tap) and to be able to do preventDefault() not to follow links directly in tap event handler, without the need to register a separate click callback [16:54:35] jdlrobson, ^ [16:54:36] I wasn't sure if getCategoryLinks( ever returned anything other than '' [16:55:12] MaxSem i wouldn't be surprised if in some special case a special page has categories ;-) if you don't think this is true i'll drop the second condition :) [16:55:53] jdlrobson, at least core skins just check for categories:) [16:56:02] MaxSem: that's good enough for me.. [16:56:04] (03PS2) 10Jdlrobson: Don't render categories on special pages or if none [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79815 [16:56:13] eh, no standups today either? [16:56:34] I'm tired of siiittinggggggg:P [16:56:42] no standup? [16:56:53] not in my calendar [16:57:00] * MaxSem bites awjr [16:57:37] MaxSem, true, not in mine either [17:00:00] hmm today's standup seems to have been canceled [17:00:06] at least in the calendar [17:00:28] MaxSem: do you already have a hangout open? [17:00:35] no [17:00:36] k [17:01:38] https://plus.google.com/hangouts/_/9023ceae25a879d4d8d1a09ae0889b059e6b2e25?authuser=1&hl=en [17:01:52] MaxSem, jgonera, Maryana ^ [17:02:48] awjr: sweet [17:04:27] jdlrobson: do you see Maryana and/or kenan around? [17:35:52] jgonera: https://gerrit.wikimedia.org/r/79425 https://gerrit.wikimedia.org/r/79431 < can you merge these quickly to avoid merge conflicts? [17:35:59] (03PS4) 10Jdlrobson: Hygiene: Use our own custom reset file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79431 [17:36:03] morning all [17:36:06] jdlrobson, in a few moments [17:36:14] (03PS2) 10Jdlrobson: Hygiene: Drop mf- prefix from less files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79425 [17:36:37] MaxSem: can you double check https://gerrit.wikimedia.org/r/76271 ? [17:36:42] it should be ready to merge now [17:36:48] it will also make vibha happy ;-) [17:37:06] (likewise to you jgonera i know you like making vibha happy ;-)) [17:37:15] (but hygiene ones first!) [17:37:19] (03CR) 10MaxSem: [C: 032] Don't render categories on special pages or if none [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79815 (owner: 10Jdlrobson) [17:38:28] (03Merged) 10jenkins-bot: Don't render categories on special pages or if none [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79815 (owner: 10Jdlrobson) [17:43:22] jgonera: i'm gonna merge your micro.tap fix but I'm going to amend the comment to have a FIXME - are you okay with that? [17:43:35] jdlrobson, sure [17:43:50] also jgonera not sure if it should be in externals directory as jshint will not run on it.. [17:43:56] what do you think? [17:44:23] not a big deal but just had be wondering what we should do with libraries we maintain [17:44:26] well, it's a separate thing that I pushed to my github too, so I'd keep it under externals [17:44:30] hm [17:44:31] ok np [17:44:34] not sure [17:44:45] also should changes be made in that repository? [17:44:46] it's small, let's not think about it now ;) [17:45:00] maybe we should have a make remotes command that pulls the latest version? [17:45:00] possibly, but I can sync it later [17:45:13] yeah, we could [17:45:29] yeh we already have make remotes so we could just add in there in future [17:47:09] (03PS2) 10Jdlrobson: Fix tap event fallback [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79814 (owner: 10JGonera) [17:47:10] ^ jgonera are you okay with that? [17:47:53] jdlrobson, yep [17:48:13] (03CR) 10Jdlrobson: [C: 032] Fix tap event fallback [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79814 (owner: 10JGonera) [17:48:33] jgonera: please please please merge the hygiene patches before they explode - they took me a lot of time friday :( [17:48:56] jdlrobson, my head is going to explode rewriting dynamic loading first [17:49:23] that's a rabbit hole.. don't go to far down there. i was talking to Krinkle|detached about this at wikimania. i think he'd be keen to get involved [17:49:35] (03Merged) 10jenkins-bot: Fix tap event fallback [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79814 (owner: 10JGonera) [17:53:43] errgg gerrit server unavailable?! [17:53:51] ah it's back now [17:55:23] jdlrobson, why is it a rabbit hole? we just need some consistency, whether the page is loaded dynamically or not, things such as section data should be accessible in the same way [17:55:51] else we'll end up writing two codebases for every feature, one for normal loading, and another for dynamic [17:56:58] and I want to add some experimental features that I head in my mind for quite some time, but for this, I need to either disable dynamic loading in alpha or rewrite it [17:57:04] had* [18:05:56] jdlrobson, can you elaborate on what you talked about with Krinkle|detached and how he wants to get involved? [18:06:18] jgonera: sorry was looking into this opera mobile editing bug [18:06:27] basically Krinkle is interested in doing it for desktop [18:06:35] he was keen for using mobile as a test case [18:06:44] (by it i mean ajax page loading) [18:06:58] ok, so does he want to rewrite it on mobile? [18:07:12] he suggested on standardizing on a certain event for when the page has finished loading - i think he said such an event exists already but i forget) [18:07:21] well whatever we write should work on both mobile and desktop [18:08:16] awjr: can you see me? [18:08:16] i just wanted you to be aware that the code will always be very volatile until we do this. I think maybe organizing some kind of hackathon around this would be a good idea [18:08:25] it's different API isn't it? and desktop doesn't have View, or even mustache templates [18:08:28] jcmish: omg yeah, i was looking for mgrover :p [18:08:31] :D [18:09:12] jgonera: i'm sure if written well enough that won't be a problem [18:09:30] jdlrobson, I don't think it's such a complex problem, but let me finish this patch because I already spent some time on it [18:09:38] essentially it's a url, a render function and a transform function [18:10:13] jgonera: sure.. i'm not saying it doesn't need to be done, i'm just concerned since there are still lots of open bugs that have patches that haven't been merged yet [18:10:22] essentially it's fetching something with AJAX and putting it in the DOM [18:10:47] updating my iOS 7 beta instances, wheeee [18:11:02] jdlrobson, I can't be just the patch-merger, I want to do stuff myself too... [18:11:58] jgonera: i don't think that's a fair comment... [18:13:48] jdlrobson, sorry if you feel bad about my comment. let's talk about this when I'm back, I don't think IRC is good for such discussions [18:16:26] sure.. i know. fixing bugs/code hygiene is not the most fun thing either… and i hate code review just as much as everyone else. just without kaldari you're the only one who can do review of js/css in this team :) [18:16:55] this opera mobile bug is so weird btw.. it's as if the binding to this.$el becomes outdated [18:17:23] it runs Webkit, right? some old version? [18:18:05] MaxSem: do you know if the regexes in varnish are case-sensitive? [18:18:29] the new opera mobile is webkit, somewhat behind chromium/chrome [18:19:10] jgonera, jdlrobson, MaxSem can you guys please try logging into the projects on mobile? [18:19:12] i think we have a problem [18:19:21] they're not by default - use (?i) [18:19:34] ok, MaxSem i think tim s's change of cookie names broke login for mobile [18:19:44] req.http.Cookie ~ "session" [18:19:45] awjr: ? [18:19:53] now needs to be req.http.Cookie ~ "Session" [18:20:03] jdlrobson: are you able to log in on mobile? [18:20:04] i am not. [18:20:05] awjr, I logged in on enwiki [18:20:16] There was an unexpected error logging in. Please try again. If the problem persists, it may be because you have cookies disabled, and you should check that they are enabled in your browser settings. < awjr eek [18:20:22] yeah that's what im seeing. [18:20:24] awjr, [Ss]ession [18:20:30] is this the rename that tim did? [18:20:35] yup [18:20:42] oh dearz [18:20:46] emergency fix? [18:20:49] the cause was really hilarious [18:20:50] logged in again... [18:20:57] MaxSem: what cause? [18:21:04] for that change [18:21:14] can you disclose? [18:21:22] not sure if I should describe it in a public channel though:) [18:21:33] MaxSem: https://gerrit.wikimedia.org/r/#/c/79837/ [18:21:43] jdlrobson: it is a security issue that has not been publicly disclosed yet [18:23:13] awjr, are you on security@? [18:24:10] i dont think so MaxSem [18:24:32] awjr, so you don't know what happened? [18:24:37] no MaxSem [18:24:40] just that something happened [18:25:04] heh, I deduced everything from public information [18:27:47] (03PS1) 10Jdlrobson: Bug 53059: Clarify editing message when unavailable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79840 [18:31:17] ok mark's merged my change to the varnish conf [18:34:03] (03PS1) 10Jdlrobson: Bug 52361: Fix reference weirdness in Opera Mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79841 [18:35:59] ^ jgonera weirdest fix ever [18:37:08] awjr: do you guys track response times on the mobile site? [18:37:34] mwalker: we track rendering time [18:37:51] via NavigationTiming api [18:37:58] do you mean time to load on the client, or time it takes from server to client, or server response -> rendered? [18:38:09] time to load on client mostly [18:38:21] yah [18:38:29] I'm mostly curious about client latency; and then client render time [18:38:30] jdlrobson, strange [18:38:32] mwalker: go to mobile-reportcard.wmflabs.org and click 'performance' - you can see the magic graph [18:38:35] http://mobile-reportcard.wmflabs.org/ [18:38:57] talking of which jgonera who can deploy the latest version of limn? YuviPanda ? [18:40:00] brion: i guess it makes sense to do the auto layout time box w Xcode 5... [18:40:43] awjr: these two plots are averages? with 'Rendering' being the instantaneous value for that day; and 'Rendering (over last 30 days)' being a sliding window? [18:40:51] jdlrobson, not sure if any of us can, deploy scripts are broken, I can pull the newest version of graphs on limn0 but I'm not sure if that's enough [18:41:08] you can ask milimetric on #wikimedia-analytics [18:41:28] (03CR) 10JGonera: [C: 032] Bug 52361: Fix reference weirdness in Opera Mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79841 (owner: 10Jdlrobson) [18:41:34] mwalker: correct (jgonera, jdlrobson probably know more than me about this) [18:41:49] (03Merged) 10jenkins-bot: Bug 52361: Fix reference weirdness in Opera Mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79841 (owner: 10Jdlrobson) [18:42:09] kk thanks :) ; jgonera, jdlrobson; do y'all have percentile data? [18:42:26] *percentile breakdowns for the page render data [18:42:26] the raw data is available on stat1 mwalker [18:42:48] awesome; I'll find my credentials [18:42:52] there's a link to the raw stats csv under the graph on mobile-reportcard [18:43:08] MaxSem: what was the date of our last deployment? [18:43:41] btw mobile login seems to be working OK now [18:43:49] jdlrobson, Jul 30 [18:43:55] thanks Max! [18:43:58] awjr: awesome [18:44:27] awjr, the raw stats for the graph, but not the raw stats from which those raw stats are generated ;) [18:44:33] oo [18:44:37] jdlrobson: do you know where on stat1 the raw data is? [18:44:38] details, details [18:45:11] mwalker, mysql -h s1-analytics-slave.eqiad.wmnet -u research -pXXX log [18:45:59] mwalker, table NavigationTiming_5336845 [18:46:11] shoot; I don't have the mysql password [18:46:31] heads up jgonera awjr MaxSem Maryana ken an i'm drafting a mail for mobile-l about editing errors [18:46:32] off to the analytics channel for I [18:46:47] ruh roh [18:46:50] so long, mwalker [18:46:53] jdlrobson: scary?. [18:46:58] anything serious, jdlrobson? [18:47:00] awjr: yup.. very scary [18:47:03] the error rate is high [18:47:08] 48% [18:47:13] awjr, jdlrobson; thanks for your help :) [18:47:14] what's the most common one? [18:47:15] jdlrobson: today or over the last x days/weeks? [18:47:20] since last deployment [18:47:22] AbuseFilter [18:47:23] kk [18:47:23] hmm.. abusefilter? [18:47:25] ah [18:47:27] all will be revealed soon [18:47:29] kk [18:47:38] ok [18:48:06] * jgonera goes to eat dinner/supper, will be back later [18:59:35] (03CR) 10MaxSem: [C: 04-1] "(12 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76271 (owner: 10Jdlrobson) [19:08:45] Maryana: mail sent to wikitech and mobile-l [19:09:05] thanks - also useful for closing the anon editing bug [19:09:11] MaxSem: thanks for picking up those i18n issues!! [19:09:14] since abusefilter is 10 times as sensitive toward anons [19:20:35] i'm not seeing the email, jdlrobson [19:20:46] did you get stuck in moderation limbo? [19:21:01] or in the abusefilter limbo? :-P [19:21:48] Maryana: it went out to mobile-l and wikitech-l [19:22:11] hmm.. weird [19:22:22] i'm not subscribed to wikitech, but i'm pretty sure i am to mobile-l.. [19:22:31] mmm….. [19:22:36] lunch [19:51:12] MaxSem: can you note your concerns about the patch on https://bugzilla.wikimedia.org/show_bug.cgi?id=52632 ? [19:52:17] sure [19:57:53] MaxSem: what's the status of https://mingle.corp.wikimedia.org/projects/mobile/cards/830 ? it looks to me like everything is in place for it to be working, but, it's not working [19:59:31] jdlrobson: what is the current status of https://mingle.corp.wikimedia.org/projects/mobile/cards/899 ? last comment says there's a patch coming, but i dont see a link for one nor do i see an obvious corresponding patchset in gerrit [19:59:56] awjr, it requires a frontend squid restart [20:00:17] MaxSem: but even if you hit m.wikimediafoundation.org directly mobile site doesn't load [20:00:34] MP is whitelisted [20:00:41] MP? [20:00:45] main page [20:00:47] o [20:00:53] sorry, I've got a meeting [20:01:05] kk thanks MaxSem, seems to work on non-mp [20:04:01] (03CR) 10JGonera: [C: 04-1] "I'd merge but it breaks borders in login and sign up forms." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79431 (owner: 10Jdlrobson) [20:05:52] (03CR) 10JGonera: [C: 04-1] "Could you explain the changes in editor.less and common-js.less?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79425 (owner: 10Jdlrobson) [20:07:53] (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79840 (owner: 10Jdlrobson) [20:09:41] (03CR) 10JGonera: [C: 032] Improving styling of button on following pages: [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79081 (owner: 10Jdlrobson) [20:10:04] (03Merged) 10jenkins-bot: Improving styling of button on following pages: [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79081 (owner: 10Jdlrobson) [20:11:23] Maryana: when you're around can we chat for a few? [20:11:44] (03CR) 10JGonera: [C: 04-1] "Notice: Undefined index: subject-page in /home/jgonera/www/extensions/MobileFrontend/includes/skins/MinervaTemplate.php on line 113" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79277 (owner: 10Jdlrobson) [20:13:31] (03CR) 10JGonera: [C: 031] Bug 51924: Special case main page history link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79276 (owner: 10Jdlrobson) [20:18:08] (03CR) 10JGonera: [C: 04-1] "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/78336 (owner: 10Jdlrobson) [20:47:29] (03PS2) 10Jdlrobson: Bug 50952: Show a link on talk page back to subject page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79277 [20:51:40] (03PS3) 10Jdlrobson: Bug 52511: Make editor load correct page for ajax loaded pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/78336 [20:51:42] (03CR) 10Jdlrobson: "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/78336 (owner: 10Jdlrobson) [20:53:18] Maryana you're a grammar nazi: what is more grammatically correct: 'Mobile editing is not currently available on your browser.' or 'Mobile editing is currently not available on your browser.' [20:53:30] i guess the latter but i'm not sure why and more curious about a grammar lesson [20:53:52] depends on if you're trying to negate the current or the available part [20:54:07] (03CR) 10JGonera: [C: 04-1] "Although this allows me to edit in the test case mentioned in the bug, the preview is messed up (the order of headings is changed). Is thi" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79230 (owner: 10Jdlrobson) [20:54:10] not currently has stronger implications that it may be available soon [20:54:18] (03CR) 10Jdlrobson: "Looks like the rebase screwed up '_' sigh" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79425 (owner: 10Jdlrobson) [20:54:33] currently not means it's not available and may never be available [20:54:50] 'Mobile editing is not currently available on your browser.' is what we want then [20:55:04] yep :) [20:55:08] for example we don't support Windows Phones but we do want to [20:55:22] (03CR) 10Jdlrobson: "jdlrobson: Maryana you're a grammar nazi: what is more grammatically correct: 'Mobile editing is not currently available on your browser.'" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79840 (owner: 10Jdlrobson) [20:55:47] ^ jgonera [20:56:16] sure, I was only wondering if that word order was intentional [20:56:30] (03CR) 10JGonera: [C: 032] Bug 53059: Clarify editing message when unavailable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79840 (owner: 10Jdlrobson) [20:56:52] (03Merged) 10jenkins-bot: Bug 53059: Clarify editing message when unavailable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79840 (owner: 10Jdlrobson) [20:59:37] (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/70953 (owner: 10Jdlrobson) [21:00:14] (03PS3) 10Jdlrobson: Hygiene: Drop mf- prefix from less files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79425 [21:01:39] jcmish: have you tried messing with your audio settings in the hangout itself? [21:04:07] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79425 (owner: 10Jdlrobson) [21:08:33] hey jdlrobson [21:08:40] i saw a ping on this channel but lost backscroll. 'sup? [21:09:37] YuviPanda: i forget [21:09:58] hehe, ok [21:30:40] jdlrobson: question on the timing data; this appears to be massively sampled; e.g. I have only 8040 events from 2013-07-28 to 2013-08-02 -- can you tell me anything about how those samples are selected? [21:31:02] mwalker: browsers need to support the NavigationTiming API [21:31:15] it's provided by NavigationTiming extension - ori-l would be a good person to chat to about sampling [21:31:45] And then my connection ded [21:32:12] jdlrobson: gotcha [21:32:13] thanks [21:37:26] jdlrobson: hi [21:37:29] about https://bugzilla.wikimedia.org/show_bug.cgi?id=51639 [21:37:37] where does "a-z" appear exactly? [21:38:52] aharoni: https://en.m.wikipedia.org/wiki/Special:Watchlist we were considering it for a label in place of 'All' on this page [21:41:48] (03CR) 10JGonera: [C: 032] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79425 (owner: 10Jdlrobson) [21:42:10] (03Merged) 10jenkins-bot: Hygiene: Drop mf- prefix from less files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79425 (owner: 10Jdlrobson) [21:46:45] well, it obviously doesn't work for all languages. [21:46:58] if you really want something like "a-z", it can be an optional message [21:49:07] jdlrobson: ^ [21:49:19] maybe it can be "all articles" in the articles view. [21:51:05] aharoni: it needs to be short as well :-/ i just wondered if there are equivalents to a-z in other languages which express the same idea [21:51:20] in most alphabets - yes. [21:51:45] "а-я" for Russian, "א-ת" for Hebrew. [21:51:51] not sure about Chinese, though :) [21:52:14] but in Chinese you can probably express that idea in two or three chars ;) [21:54:22] jdlrobson, didn't hear, when are you going to Burning Man? [21:54:34] jgonera: all next week leaving either monday or tuesday [21:54:43] ok [21:56:32] (03CR) 10JGonera: [C: 032] Bug 50952: Show a link on talk page back to subject page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79277 (owner: 10Jdlrobson) [21:56:49] (03CR) 10JGonera: [C: 032] Bug 52511: Make editor load correct page for ajax loaded pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/78336 (owner: 10Jdlrobson) [21:57:13] (03Merged) 10jenkins-bot: Bug 52511: Make editor load correct page for ajax loaded pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/78336 (owner: 10Jdlrobson) [21:57:51] (03CR) 10JGonera: [C: 032] Bug 51697: Support all types of talk [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/78338 (owner: 10Jdlrobson) [21:58:11] (03Merged) 10jenkins-bot: Bug 51697: Support all types of talk [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/78338 (owner: 10Jdlrobson) [21:59:47] (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79167 (owner: 10Jdlrobson) [22:03:54] (03PS2) 10Jdlrobson: Bug 51977: Hide the talk icon when refreshing talk pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79167 [22:05:01] (03PS3) 10Jdlrobson: Bug 50952: Show a link on talk page back to subject page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79277 [22:05:37] (03CR) 10JGonera: [C: 032] Bug 50952: Show a link on talk page back to subject page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79277 (owner: 10Jdlrobson) [22:05:39] (03CR) 10Jdlrobson: [C: 032] "rebased due to filename change" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79277 (owner: 10Jdlrobson) [22:06:03] (03CR) 10JGonera: [C: 032] Bug 51977: Hide the talk icon when refreshing talk pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79167 (owner: 10Jdlrobson) [22:06:08] (03Merged) 10jenkins-bot: Bug 50952: Show a link on talk page back to subject page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79277 (owner: 10Jdlrobson) [22:06:14] sweet thanks jgonera get some sleep! :) [22:06:25] (03Merged) 10jenkins-bot: Bug 51977: Hide the talk icon when refreshing talk pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79167 (owner: 10Jdlrobson) [22:06:37] see you all tomorrow! [22:09:03] Maryana: any objections to https://gerrit.wikimedia.org/r/#/c/79276/ ? [22:09:28] on main page we say "View edit history of this page.'" rather than "Last modified 3 months ago." [22:09:30] depends - what does it do? [22:09:44] this will prevent wiki admins from hiding the history link [22:09:52] ah, k - yeah [22:10:05] looks good [22:10:09] no hiding! [22:11:36] (03CR) 10Jdlrobson: [C: 032] "Checked wording with Maryana." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79276 (owner: 10Jdlrobson) [22:12:04] (03Merged) 10jenkins-bot: Bug 51924: Special case main page history link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79276 (owner: 10Jdlrobson) [22:12:27] awjr: any thoughts on https://bugzilla.wikimedia.org/show_bug.cgi?id=51277 ? [22:13:13] will look in a min jdlrobson, responding to https://bugzilla.wikimedia.org/show_bug.cgi?id=51465 right now [22:23:28] jdlrobson: replied to 51465 and 51277 [22:47:53] thanks awjr_away [23:56:49] hey, I used to see the mobile version of my local wiki with mf_mobileFOrmat cookie set true. I just updated MobileFrontend extension and it stopped working, and &mobileaction=beta doesn't work either [23:59:21] Ah, ?useformat=mobile&mobileaction=beta works Is the cookie no longer used?