[15:05:33] (03CR) 10MaxSem: "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76271 (owner: 10Jdlrobson) [15:07:42] (03CR) 10MaxSem: [C: 04-2] "Overall, I would like to have a confirmation from our DB gurus, Asher and Sean, that retrieving potentially up to 1000 rows just to displa" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76271 (owner: 10Jdlrobson) [15:21:03] (03PS1) 10MaxSem: Log Accept headers in conjunction with User-agent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80026 [15:48:50] > Can you please advise if you can provide us with appx file for the application "wikipedia" available on windows 8 store. [15:48:54] that's brion ? [15:49:27] they want to sideload on a whole fleet of devices [15:49:38] i guess then they don't get updates? [15:50:46] jeremyb: yeah, that's brion. *I* want to kill it, since nobody's touched that code in... a long time [15:50:51] and I don't know if anyone would, even [15:52:39] howdy [15:52:54] jeremyb: they could just compile it themselves you know ;) [15:53:02] brion: can't sign :P [15:53:06] (assuming there is signing) [15:53:14] brion: also in office? android i'm pushing out an update today [15:53:17] they can re-sign on their own account ;) [15:53:19] brion: i think we might need a fix for iOS too [15:53:31] YuviPanda: will be in office in an hour or so-ish [15:53:35] brion: ok [15:53:35] YuviPanda: on the wikipedia app? or [15:53:44] or commons [15:53:50] brion: no, on commons. we've been apparently using the cc 1.0 licenses [15:53:54] brion: i doubt they know [15:54:18] brion: since that is apparently the default template if you odn't specify 3.0 [15:54:20] stupid commons! [15:54:22] :P [15:54:47] brion: oh, hah! this req is from MS qatar [15:58:18] YuviPanda: hah! oh i remember reading a bug report going past… yeah i'll check that later [15:58:33] jeremyb: from MS? you'd think they'd have access to the store. ;) [15:58:39] brion: yeah!! [15:58:41] jeremyb: forward their email to me and i'll figure out what to do [15:58:58] brion: k [15:59:27] brion: or do you want it assigned to you in otrs? :) [15:59:45] oh, no, i forgot, your account was closed [15:59:56] hah [16:00:01] that explains why i can't log in [16:00:04] well that and i forgot the password [16:02:16] brion was closed march 5th in between jesse wild and mark bergsma [16:03:55] brion: did you get it? [16:04:06] it's 2013082010007087 fyi [16:04:59] jeremyb: got it [16:05:18] danke [16:05:27] oh hey [16:05:32] i think i have the .appx online already actually [16:05:42] http://dumps.wikimedia.org/win8/release7/ <- in here [16:05:52] so i'll see if that works for em :) [16:07:26] jeremyb: if i do a reply-to-all will it include the followup in ptrs? or will it explode somehow :) [16:08:14] mmm, ptrs [16:08:35] damn you autocorrect [16:08:46] one sec [16:08:48] no, no that's just my crappy fingers typing badly [16:11:09] brion: prepend on your subject: '''[Ticket#2013082010007087] ''' [16:11:19] (after the Re: or whatever) [16:11:53] ok [16:12:38] jeremyb: ok sent [16:15:55] brion: danke! [16:28:16] The status for the following app has changed to In Review. [16:28:16] App Name: Wikimedia Commons [16:28:18] heyyyyy [16:28:23] let's see what we get :) [16:28:52] brion: woohoo! [16:29:47] hey mhurd [16:29:50] stil jetlagged? [16:33:37] YuviPanda: yeah! woke up around midnight. doh! [16:33:47] mhurd: hehe :P I slipped right back into my normal sleep cycle [16:33:51] mhurd: have a massive massive cold tho [16:34:27] YuviPanda: :( hope you feel better! [16:34:34] mhurd: me too! [16:35:04] (03CR) 10Dr0ptp4kt: "MaxSem, noted. Holding off on any merges of code until both yurik and I can review (yurik OoO this week)." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/68581 (owner: 10MaxSem) [17:10:02] awjr, can you review https://gerrit.wikimedia.org/r/80026 for today's deployment please? [17:10:09] sure MaxSem [17:10:12] in a bit [17:16:25] hey Maryana are we doing the QA review in 15 mins? or do you have something else going on? [17:16:52] hmm, well, none of the designers are back from vacation yet [17:17:13] so i can just poke around beta labs, i guess [17:18:07] slackers :D [17:18:16] hopefully they are somewhere awesome [17:20:23] does anyone in here wear contact lenses? [17:20:36] that doesn't sound auspicious [17:21:03] I *think* jon does [17:21:33] hehehe since i have a habit of breaking/losing my glasses, particularly while traveling (like at Wikimania…) i've decided to try contacts out. they seem to work great except for when im looking at a computer screen (which is like 75% of my day…) [17:21:56] heh, I wore them for a day and then threw them away. Too fussy for my tastes [17:21:56] and i wonder if that's typical [17:22:01] [13Commons-iOS] 15brion closed pull request #118: Fix for potential issue with debug mode in release builds. (06master...06debugMode) 02http://git.io/G-bQxg [17:22:10] brion: back at the office? [17:22:17] YuviPanda: yep [17:23:35] YuviPanda: Status Pending Developer Release :DDDDD [17:24:33] awjr: since I don't have my 10:30 do you want to chat then? [17:24:38] sure jcmish [17:24:53] kayo I'll ping ya in a few [17:25:03] I used to wear contacts but that was a long time ago [17:25:13] when you still had to do a lot to maintain them [17:25:32] my sister wears then and says they are MUCH easier to handle especially the ones you can sleep in [17:26:05] yeah - i tried them about 20 years ago when i was a kid and i totally hated them; these are way easier to cope with. but i dont think i can use them since i cant really see my computer screen very clearly with them :( [17:27:00] MaxSem: per https://gerrit.wikimedia.org/r/#/c/80026/1/includes/MobileFrontend.body.php aren't we already logging User-Agent and Accept headers? [17:27:09] the analytics team can probably get you that dat [17:27:10] a [17:27:30] or jgonera [17:27:31] (that would be logged at the varnish log level rather than debug log) [17:27:44] Diederik said they're not logging accept [17:27:51] oh ok [17:28:14] and since we need it only temporarily, I thought there's no point in poking them [17:28:36] huh? I'm not sure if it's about contact lenses or user agents [17:29:42] it's about contact agents [17:30:02] I don't know anything about that ;) [17:30:36] jcmish: ready when you are :) [17:31:25] sorry, fuckin shitty connection [17:31:28] brion: help test a release? only two commits (new icon + license template) [17:31:43] sure link me up [17:32:12] brion: sweet, let me prep a build [17:32:34] * brion boots up 4.3 and 2.3 phones... [17:35:07] MaxSem: also, you wanted to log 1/10000 not 1/1000 right? [17:35:45] 1/1000 is too spammy, methinks [17:36:01] think you'll get enough WAP usage info with 1/10000 tho? [17:36:14] mmm [17:36:32] 3G mobile views/month [17:36:40] 75M WAP views [17:36:54] are the analytics guys logginge very req or a sampled set? [17:37:15] 1/1000 [17:37:51] MaxSem: i think it might make more sense to add this to the X-Analytics header. you'll have a better sample size and can use existing analytics tools to pull the data out [17:38:30] I don't want to mess with varnish when all I need is a small collection of headers [17:38:42] you won't need to mess with varnish, that's the whole point of the X-Analytics header [17:39:07] it's for storing arbitrary analytics data that won't require making changes to the logging infra or to varnish [17:39:20] ah [17:39:29] ok, I'll look at it tomorrow [17:39:38] MaxSem: ok - i sent diederik a message asking about it [17:40:01] thanks dude! [17:40:06] no problem [17:40:31] YuviPanda: ok commons-ios seems to be ok on the license front, it uploads marked as cc-by-sa 3.0 unported specifically [17:40:40] heh, nice :) [17:47:58] (03PS1) 10Yuvipanda: Updated CHANGELOG and bumped version number [apps/android/commons] - 10https://gerrit.wikimedia.org/r/80065 [17:48:02] brion: email'd! [17:49:41] brion: can you test? [17:50:13] working on it [17:53:56] (03PS1) 10MaxSem: Don't redirect everything with oldid to MobileDiff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80067 [17:54:19] (03CR) 10MaxSem: "Prolly needs a bit of styling." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80067 (owner: 10MaxSem) [17:55:32] YuviPanda: ok looks good on 4.3; .apk upgrades cleanly and new upload is marked as CC-BY-3.0 unported [17:55:38] (03CR) 10jenkins-bot: [V: 04-1] Don't redirect everything with oldid to MobileDiff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80067 (owner: 10MaxSem) [17:55:45] brion: mmm! [17:56:15] oddly the launcher icon didn't update immediately on my home screen, but i see it updated in the app and in the apps list [17:56:24] i assume it's just cached and will fix itself later [17:56:31] brion: hmm, probably [18:00:30] (03PS2) 10MaxSem: Don't redirect everything with oldid to MobileDiff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80067 [18:03:21] brion: 2.3? [18:03:31] looks good on my 4.1 so far [18:03:38] YuviPanda: looks good on 2.3 as well [18:03:54] brion: hmm, check about screen on 2.3? do you see actionbar on top? [18:03:57] just took me longer to set up, i had to add my work gmail account so i could download the attachment :) [18:04:00] ooh lemme doublecheck [18:04:09] yes [18:04:21] and on settings too [18:05:23] (03CR) 10Jdlrobson: [C: 04-2] "Definitely needs some styling. Let me take a look.." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80067 (owner: 10MaxSem) [18:05:25] hmmm still got a crash on 2.3 lemme check the stack trace [18:05:36] OOM again [18:05:42] YuviPanda: did we merge that OOM workaround yet? [18:05:46] brion: nope [18:05:48] no worry if not we can do it for the next update :) [18:05:49] ok [18:05:53] so that's good, not a regression :DDD [18:06:01] ok i think we're good to go for now [18:06:06] brion: it was causing slowness on newer devices, we decided to add acheck :P [18:06:12] yeah [18:06:14] i left comments on both those pull requests, I think [18:06:21] lemme check if i finished that [18:07:00] YuviPanda: https://github.com/brion/apps-android-commons/commit/e6108da973dfc7e2ff477925e5c3721373c08337 [18:07:10] look ok? [18:08:10] brion: looks okay, but commit says >50m, code says 48 :P [18:08:18] brion: but we can merge that right after release. [18:08:30] heh woops [18:08:32] lemme fix that ;) [18:08:35] :) [18:08:38] ok [18:08:48] brion: I'm going to put out a release now anyway [18:08:51] awjr, I'm confused: what iteration are we at? [18:08:54] brion: sounds good? [18:09:38] MaxSem: what is getSubtitle used for other than diff next/prev buttons? [18:09:40] YuviPanda: sounds good yes :D [18:12:12] jdlrobson, for various stuff - navigation between edits, "Redirected from foo", etc [18:12:33] mmm i'm concerned about showing it for all these things [18:12:40] i suggest we just show it on the diff view for the time being [18:12:58] d'oh? all of them look quite appropriate [18:13:17] redirected from is one thing I missed a lot [18:13:30] well i think this needs design input, but my personal belief is when viewing an old revision it should actually display like a banner at the top of the page [18:13:38] redirected should however be under title [18:13:54] i just think we should think of these things separately [18:14:13] I think that navigation makes sense under the title too [18:14:27] because it's a nav for _this title_ [18:15:10] but it's not prominent enough [18:15:44] when i'm viewing an old revision i want that to be as obvious as possible [18:16:05] style the message and it will be very obvious;) [18:16:13] eg https://en.wikipedia.org/w/index.php?title=Dershowitz%E2%80%93Finkelstein_affair&oldid=556895655 [18:16:15] MaxSem: dragonfly [18:16:20] very hard to miss [18:16:30] MaxSem: story wall on mingle should be up to date [18:16:44] MaxSem: Regardless this should be in beta first - it needs design treatment [18:17:06] jdlrobson, feel free to. though it's really a bug fix [18:17:12] MaxSem: the (diff) ← Previous revision | Latest revision (diff) | Newer revision → (diff) buttons are extremely badly placed though [18:17:29] awjr, but why I see old cards in story wall? [18:17:52] MaxSem: the only 'old' cards you should see are cards that weren't completed - so stuff in development, code review, and testing [18:17:58] aha [18:18:00] MaxSem: how come that says "This is an old revision of this page, as edited by Capscap (talk | contribs) at 17:54, 26 May 2013. It may differ significantly from the current revision." and mine says "Revision as of 00:53, 25 July 2013 by Empty (Talk | contribs)" [18:18:10] there was a lot that wasn't completed last iteration; so there's a lot that got carried over [18:18:14] is this a wiki customisation? [18:18:26] yes [18:19:38] brion: the apk i gave you pushed things to commons, right? Not testwiki? :) [18:19:55] YuviPanda: yes :) [18:20:00] ok :) [18:20:12] brion: merge https://gerrit.wikimedia.org/r/80065? [18:20:14] (trivial) [18:20:18] changelogs and stuff [18:20:22] * YuviPanda uploads APK [18:21:05] looking [18:21:20] brion: also can you put the apk on dumps? [18:21:25] ok [18:21:30] same apk? [18:22:24] brion: yeah [18:22:41] (03CR) 10Brion VIBBER: [C: 032 V: 032] Updated CHANGELOG and bumped version number [apps/android/commons] - 10https://gerrit.wikimedia.org/r/80065 (owner: 10Yuvipanda) [18:24:03] YuviPanda: md5 61ceef01cb470777105ee9751d322b44 wikimedia-commons-1.0beta11.apk [18:24:09] checking md5 [18:24:20] yup [18:24:21] that's the one [18:26:28] \o/ [18:31:03] jcmish: did you still want me to look at your python scripts? [18:31:15] oh yeah [18:31:17] in a bit [18:31:21] jcmish: ok - where are they? [18:31:27] i'm putzing with it right now [18:31:31] okidoke [18:31:35] i'll ping you when I'm done [18:31:42] cool [18:32:58] MaxSem: diederik says we should do the logging your way since they're going to be making changes to the analytics cluster and things will be offline/chaotic [18:33:03] MaxSem: why on earth is this guy installing WURFL?! http://www.mediawiki.org/w/index.php?title=Extension_talk:MobileFrontend&offset=20130820174315&lqt_mustshow=32248#Installation_problems_32248 [18:35:04] because he can't read? [18:35:13] tehe [18:35:21] (03CR) 10awjrichards: [C: 032] Log Accept headers in conjunction with User-agent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80026 (owner: 10MaxSem) [18:35:30] anyway, 1.5 hours to deployment [18:35:47] anyone has any config changes to deploy? [18:36:00] jdlrobson jgonera ^^ [18:36:02] anyone seen kaldari? [18:36:12] dr0ptp4kt, anything zero-related I should deploy? [18:36:16] I don't have any config changes [18:36:22] (03Merged) 10jenkins-bot: Log Accept headers in conjunction with User-agent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80026 (owner: 10MaxSem) [18:36:42] MaxSem, no. thanks for checking! [18:36:44] MaxSem: gawd.. who knows i forget [18:37:16] jcmish: just a thought is there any way in the deployment logs to pull out dependencies? [18:37:22] that would be useful for this purpose.. [18:37:35] we usually write Dependency: changesetid or Dependencies: changesetid [18:37:44] awjr: kaldari is here yes [18:37:56] hmm [18:37:58] i've told him to get on irc [18:38:00] jdlrobson: can you tell him to get on irc? [18:38:02] not sure what you mean jdlrobson [18:38:25] jcmish: example.. https://gerrit.wikimedia.org/r/#/c/58550/ [18:38:34] Commons uploader app for iOS is updated in the App Store -- many small fixes and big improvements to the UI. [18:38:39] hi kaldari! feeling better? [18:38:48] the commit message says there is a dependency for this commit. It would be good if we could list these in the deployment log so the deployer knows what needs to be deployed from elsewhere [18:39:10] awjr: mostly. got about 3 hours of sleep last night [18:39:17] :( [18:39:23] and still sniffly, but better [18:39:46] MaxSem: i don't think there are any config changes this time but i may be wrong [18:39:50] jcmish: does that make sense? [18:39:51] ok [18:39:57] awjr: how's your jet lag? [18:39:57] glad you're on the mend - the jetlag has been killer for me, though i finally got a nice long 9 hours of sleep last night [18:40:04] nice [18:40:13] jcmish: is your script in any form to put in MobileFrontend repository - maybe i could hack it in? [18:40:27] i woke up at 2am after going to bed at midnight on monday though and couldn't fall back asleep :p [18:40:30] yup makes sense [18:40:32] I don't think I've slept long er than 3 hours since I got back yet [18:40:33] and it can be done [18:41:04] kaldari: yeah, i think finally the sleeplessness caught up with me and i couldn't help but sleep for a long time [18:41:13] kaldari: do you have any config changes to go out with today's deployment? [18:41:20] the night before I slept from 1am to 4am and then couldn't go back to sleep [18:41:35] awjr: no config changes [18:41:39] kk [18:41:46] kaldari: how was the philippines? [18:42:06] awjr: awesome, except for the torrential rain and sickness [18:42:14] did you get stuck in manila? [18:42:22] awjr: I heard you had some sickness in Japan [18:42:37] kaldari: yeah, i came down with tonsilitis - 104F fever! [18:42:41] awjr: no, I made it out to Palawan and the weather there was beautiful [18:42:51] nice [18:43:09] holy crap; palawan looks incredible [18:43:13] awjr: Yeah, I had an awful fever and had to spend a whole day in bed at the hostel in Manila [18:43:23] the day before I flew out [18:43:32] blech [18:43:45] had a fever on the plane ride too [18:43:50] oh that's awful [18:43:59] yeah, especially for a 12 hour flight! [18:44:11] yeah, brutal - i was over the fever by the time i left [18:44:30] but otherwise I had fun :) [18:44:35] \o/ [18:47:12] running up to HR... [18:49:34] jdlrobson, awjr do Overlay JS tests fail for you on master? [18:49:44] * jdlrobson looks [18:50:36] Took 443ms to run 297 tests. 297 passed, 0 failed. < jgonera [18:50:40] hm... [18:50:43] although on debug mode they do.. [18:50:47] Took 462ms to run 278 tests. 275 passed, 3 failed. < debug mode [18:50:51] less tests too... [18:50:56] \o/ debug mode [18:51:05] Arthurs-MacBook-Pro:MobileFrontend awjrichards$ make qunit [18:51:05] Running QUnit tests... [18:51:05] Using http://virtualbot.com/testing/core as a development environment host. [18:51:05] To specify a different host set MEDIAWIKI_URL environment variable [18:51:06] (e.g. by running "export MEDIAWIKI_URL=http://localhost:8080/w") [18:51:07] Took 392ms to run 297 tests. 297 passed, 0 failed. [18:51:21] jgonera: ^ [18:51:40] jdlrobson, didn't we force non-debug in make qunit? [18:51:45] jgonera: no [18:51:57] we should be running tests in non debug mode as its what production uses and debug mode is borked [18:52:11] YuviPanda: oh -- we should probably also change the strings in apps-android-commons to be labeled as CC-BY-SA 3.0 specifically [18:52:22] the template's right, but the labels in the UI are ambiguous :) [18:52:23] make qunitdebug runs debug mode [18:52:51] brion: hehe :P the templates are what we wrote them to be, not what we wanted them to be :) [18:52:59] yeah, looking at the Makefile adn qunit.sh it looks like it should run in non-debug [18:53:00] :) [18:53:03] brion: hmm, yes, adding the labels makes sense. should I do it? [18:53:06] go for it [18:53:08] brion: ok [18:53:18] brion: I think I'll head to sleep soon. Horrible cold [18:53:33] awww. travel bug? [18:53:33] jdlrobson, so both make qunit and make qunitdebug run in debug? I don't get it [18:53:48] jgonera: no, just make qunitdebug [18:54:12] qunitdebug: [18:54:12] @scripts/qunit.sh 'MobileFrontend&debug=true' [18:54:18] qunit: [18:54:18] @scripts/qunit.sh [18:54:20] from the Makefile ^ [18:54:38] ok, so they do in my case since I have debug on by default in LocalSettings [18:54:58] anyway, I don't like breaking tests in debug mode, and something from today/yesterday broke them [18:55:01] brion: yeah, probably from the rain + the warm outside + cold AC [18:55:29] if debug mode is so broken (although it hardly ever causes me problems), then shouldn't it be deprecated? [18:55:47] probably; or fixed [18:56:10] yeah, but what exactly is broken there? [18:57:16] * awjr shrugs [18:57:18] jdlrobson: ^? [18:58:20] jgonera: well debug mode from what i understand was an afterthought in resource loader to bring convenience in debugging. It is very peculiar though. Probably worth raising a bug saying that it is unreliable. [18:58:30] there are completely different code paths for it for example [18:58:41] code paths? [18:58:45] from what i remember flipping in css doesn't occur [18:59:00] jgonera: if you look at the ResourceLoader code you'll see that completely different functions get called for debug/non-debug mode [18:59:13] :| [18:59:23] we can't and shouldn't rely on it [19:00:07] I'm afraid we need stronger arguments than that if we want to raise a bug [19:00:10] jgonera: probably worth opening a conversation with Krinkle|detached Roan and Trevor at some point [19:00:15] hm [19:00:25] jgonera: just open a tracking bug saying we are running into various issues with qunit failing in debug mode [19:00:35] but not in non-debug mode [19:00:36] http://what-if.xkcd.com/59/ [19:00:42] or maybe a wikitech thread to collect the issues [19:00:45] well, yes, then they will ask "what issues" [19:01:20] jgonera: well you have one here - the tests are running differently for unknown reasons [19:01:23] ok, maybe I'll try to track down which change made them fail later [19:01:46] jgonera: the fact debug mode runs less tests is also alarming [19:02:06] i'm sure if you asked why this might happen you'll find reasons from people who know the code inside out [19:02:18] isn't it because they fail? I haven't noticed that before [19:02:19] There are lots of things that don't work right or the same in debug mode [19:02:27] it's a common issue [19:02:55] jgonera: in this case the error seems to be something to do with using document.body rather than 'body' as the appendTo value in overlays [19:03:02] Failed assertion: Still in DOM, expected: [object HTMLBodyElement], but was: null [19:03:07] hm [19:03:20] i'm not sure why that would only happen in debug mode though [19:08:54] * jgonera food, will be back before deployment [19:12:08] YuviPanda: should we make separate posts about updated iOS & android apps or shall i make one combined? (on wikitech-l, mobile-l, and commons-l) [19:12:27] brion: combined is good enough, since the android one is a minor upgrade [19:13:17] spiff i'll write it up shortly [19:13:25] YuviPanda: Who is technical_13@yahoo.com? [19:13:53] multichill: Technical_13 [19:13:56] I'd think [19:13:58] heh [19:14:10] multichill: why? [19:14:27] multichill: I also just pushed it out, btw. going to hit the bed now to try recover from cold an dcold meds [19:14:40] YuviPanda: Good job, get well soon [19:14:51] He was screwing around with bug prio [19:15:58] multichill: yeah, he does those kinda things sometimes :) [19:16:40] multichill: I'm adding '3.0' monikers to the license strings (so it is CC Attribution 3.0 instead of just CC Attribution) [19:16:45] multichill: does CC0 also have a number? [19:16:46] * YuviPanda looks [19:17:02] Version? No, only 1.0 [19:17:25] {{cc-zero}} == .10 [19:17:28] *1.0 [19:17:41] hmm [19:17:59] so CC Attribution 3.0, CC Attribution-ShareAlike 3.0, and CC0 [19:18:01] is that correct? [19:25:15] I was paged? [19:35:01] (03PS1) 10Yuvipanda: Explicitly mention version of CC licenses [apps/android/commons] - 10https://gerrit.wikimedia.org/r/80105 [19:35:17] brion: ^ [19:35:26] \o/ whee [19:36:03] brion: okay, now I'll *actually* go to sleep [19:36:15] gnight :D [19:38:30] (03CR) 10Brion VIBBER: "Should the qq messages be updated as well?" [apps/android/commons] - 10https://gerrit.wikimedia.org/r/80105 (owner: 10Yuvipanda) [19:38:48] brion: not sure if that's needed, I guess? [19:39:14] meh it's clear enough i guess :D [19:39:15] merrrrrrge time [19:46:07] YuviPanda: multichill ??? [19:47:37] Technical_13: Please don't play around with bugs like you did at https://bugzilla.wikimedia.org/show_bug.cgi?id=52967 [19:47:41] (03CR) 10Brion VIBBER: [C: 032 V: 032] Explicitly mention version of CC licenses [apps/android/commons] - 10https://gerrit.wikimedia.org/r/80105 (owner: 10Yuvipanda) [19:49:19] I elevated the importance of it, was no intent to "play with". [19:59:49] jdlrobson, have you checked those JS tests with debug off in a real browser, not PhantomJS? [20:04:32] heads up - the ppl before us are still deploying [20:05:06] kk thanks for the head's up MaxSem [20:08:15] jdlrobson, what is needed to get previews in Nearby? alpha or sth more? don't seem to work for me [20:10:17] sorry jgonera just finishing up lunch [20:10:28] sure, no rush [20:11:31] :( [20:11:42] * werdna waves [20:11:46] well i'm still here MaxSem yell when we're ready [20:11:52] jdlrobson: who did you say would know more about mobile editing code? [20:12:20] werdna: jgonera would be your man [20:12:24] gotcha [20:12:41] still waiting on e2 to wrap up deployment? [20:13:17] * Maryana goes and gets some tea [20:14:37] so jgonera 1) 6/300 tests fail in browser on qunit, 3/297 fail in qunit debug mode 2) for some reason preventDefault is not running on nearby and previews thus not working [20:15:23] ok, that confirms what I found (if those tests in the browser fail without debug mode) [20:15:31] 1) is kind of alarming though [20:15:47] have you checked the editor on various browsers after this opera fix? [20:17:57] MaxSem: do you have a rough idea when we'll be deploying today? [20:18:51] nope [20:19:31] is it the notifications deployment that's still going, maxsem? [20:19:34] i can ask in the ee channel [20:19:48] it's Chad, not EE [20:19:54] ah, i see [20:20:14] I'm in #-ops, don't worry;) [20:20:45] kk :) [20:30:19] jgonera: why would using document.body make any difference?! [20:30:33] jdlrobson, I don't know, why do tests fail? [20:30:43] why is the sky blue? [20:30:44] i don't know this is all very strange.. i'm exploring [20:31:19] jgonera: i think the tap code might be interfering.. [20:31:37] that would be odd, but not impossible ;) [20:31:41] try disabling it [20:31:53] all right awjr, jcmish, jdlrobson, jgonera, kaldari, Maryana - we're live on testwiki, please test:) [20:32:13] jgonera: Uncaught TypeError: Cannot call method 'isDefaultPrevented' of undefined [20:32:28] thanks MaxSem [20:32:30] kayo MaxSem [20:32:30] jgonera: you must remember tests run in alpha mode [20:32:47] well, yes, I don't get anything like that [20:32:49] that would explain clicking a heading toggles it [20:32:55] (why it is failing) [20:33:06] i suspect when an error is thrown weird stuff happens in qunit [20:33:19] heading, what heading? are we talking about failing OVerlay tests? [20:33:23] hm [20:33:58] anyway i'll try a few phones now and see if i hit any problems [20:34:02] k [20:34:03] (03PS1) 10JGonera: Make page heading markup uniform [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80131 [20:34:03] thanks [20:34:04] (03PS1) 10JGonera: Hygiene: get rid of M.getApiUrl() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80132 [20:34:05] (03PS1) 10JGonera: Introduce PageApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80133 [20:35:13] Bug (beta): Preview broken on nearby (as juliusz pointed out) [20:37:37] sweet, getting watchlist data [20:37:57] Maryana: :D [20:38:33] hm, toasts are not centered in Android browser [20:38:37] BUG: Toast not centerd [20:38:41] in beta, when i add a talk topic, then go back to the article, then go back to view talk topics, i do not see the topic i added :( [20:38:44] jgonera: ahh snap :) [20:38:45] everywhere? [20:38:50] or Android too? [20:38:54] on this android browser at least.. [20:39:03] yeah, should I try to fix it now? [20:39:25] android 4.1.1 [20:39:33] 4.2.2 too [20:39:33] will try older android as well [20:39:57] jgonera: guess it should be easy to fix - due to refactor of toasts? [20:39:57] just thanked someone for reverting my edit - thank trolling! [20:40:22] jdlrobson, probably [20:40:23] hahaha [20:40:42] jdlrobson: talk does not appear to be working; at least not adding talk topics [20:41:21] awjr: works for me.. [20:41:22] i have now added three talk topics to https://test.m.wikipedia.org/wiki/Skanwiki but none of them actually appear [20:41:24] awjr: alpha or beta? [20:41:26] beta [20:41:48] i've tried both in desktop chrome as well as chrome for android [20:41:49] ooh awjr seems to hit empty talk pages [20:41:52] bizarrely the error is "{"servedby":"mw1017","error":{"code":"editconflict","info":"Edit conflict detected"}}" [20:41:58] wtf [20:42:03] :-| [20:42:55] kenanwang: Maryana fyi i just noticed on a short page the footer text "Text is available under CC BY-SA 3.0; additional terms may apply." is very prominent and I clicked on it by accident.. i wonder if this explains why lots of people star it - maybe they think starring it makes the content available [20:43:15] maybe it should be smaller or a different color from the article? [20:43:35] BUG: Cannot add new topics to empty talk pages instead get edit conflict o_O "{"servedby":"mw1017","error":{"code":"editconflict","info":"Edit conflict detected"}}" [20:43:39] if it's any smaller, it's hard to read or tap on, though [20:44:30] awwww when are we gonna get a mobile history view! [20:44:34] i want i want i want [20:44:48] awjr: i made progress on that during wikimania [20:44:52] oo! [20:44:53] i'll share it after deployment in case you want to pick it up [20:44:57] it abstracts the watch list feed view [20:45:03] very cool [20:45:04] as we should reuse that and creates Special:History [20:45:32] sorry was heads down awjr you don't see the talk topic show up [20:45:36] when you add them? [20:45:44] BUG: awjr Razr editing not working... [20:45:45] or the count isn't showing on the icon? [20:45:55] correct jcmish though jdlrobson says it only affects empty talk pages [20:46:14] jdlrobson: im working on that, but it's a pain because there are different sdks for the different color models [20:46:37] ah okay mine did show up but they were added on to an existing [20:46:48] jcmish: try on https://test.m.wikipedia.org/wiki/Skanwiki [20:47:17] awjr: maybe we should open a bug for it? [20:47:29] the sdk issue? [20:47:36] yup [20:47:37] awjr: got it [20:47:39] yeah good idea [20:47:48] it's important awjr i fear we are not giving it the right amount of attention [20:48:00] think of the poor razr users who can't edit [20:48:35] (03PS1) 10JGonera: Make toasts centered on Android browser [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80138 [20:48:39] jdlrobson, MaxSem ^ [20:48:40] something funky's going on w/the blue upload tutorial [20:49:07] when i log in w/a fresh account from the upload button, it doesn't show when i get back on the page. but it does show if i refresh the page [20:49:09] is there a way to force the tutorial without creating a virgin account? [20:49:20] Maryana: o_O [20:49:22] as long as you have 0 uploads, it should work [20:49:28] Maryana: come show me [20:49:32] kk [20:49:42] you don't need a new account awjr oh wait what Maryana said [20:49:47] :) [20:50:37] * tfinc looks about  [20:50:43] * tfinc opens his email  [20:50:59] * tfinc ponders deleting all of it that's marked as new [20:50:59] * jdlrobson waves at tfinc  [20:51:03] inbox zero [20:51:12] jdlrobson: is our phone cabinet still there ? [20:51:15] you forgot 'averts eyes' [20:51:28] hi tfinc; still alive? [20:51:45] tfinc you should try making this while you're recovering from travel: http://bacon.wikia.com/wiki/Bacone [20:51:50] awjr: still awake. lets see if i'm drooling on this keyboard by mid afternoon [20:52:09] awjr: i think i just heard my arteries scream [20:52:14] BUG: Upload tutorial overlay clipped on iPhone meaning you can't see the upload button [20:52:29] awjr: especially since i mostly ate fish while in Japan [20:52:43] hehehe tfinc then yo are ready for the bacone! [20:52:58] i just got a captcha that said 'taped lads' [20:54:06] jdlrobson / jgonera: if I were to hook an AbuseFilter event so that I could add a 'mobile' variable to the variables that AbuseFilter operates, where might I put such a hook? [20:54:26] jdlrobson: is our phone cabinet still in the office? [20:54:37] tfinc: yes [20:54:48] surprisingly it doesn't seem like any got stolen by the laptop thief [20:54:54] tfinc: are you in the office today? I guess not? [20:55:00] BUG: iPhone 6.1.3 clicking upload button after redirect doesn't show upload tutorial or change the icon [20:55:05] werdna, I'm not familiar with AbuseFilter's internals, what are you trying to achieve, can you give an example? [20:55:05] werdna: i'm in SF but haven't decided to head in [20:55:13] tfinc: I can understand that ;-) [20:55:31] jgonera: I'm not asking about AbuseFilter, I'm asking about which extension to hook into it from :) [20:55:48] so, for example, which extension are you adding mobile edit tags from? [20:55:50] i'll be working but i'm trying to delay using sub standard public transit after being in hong kong and japan [20:55:51] ;) [20:56:14] tfinc: ;-) I've been used to Dutch/German public transport. It's not an easy transition. [20:56:18] tfinc: welcome to the land of not-flying :) [20:56:25] not-flying-currently, at least [20:56:41] werdna, MobileFrontend, I don't think we're doing anything in any other extension, jdlrobson correct me if I'm wrong [20:57:06] werdna: can we chat about this after deployment not the best time for me :( [20:57:30] jdlrobson: didn't realise you were deploying, go ahead [20:57:35] thanks werdna :) [20:58:05] BUG: Fat fingers keep pressing edit rather than upload (effected Maryana and me now) [20:58:29] i actually blame my nails [20:58:57] Maryana: how do you want to handle these 5 bugs [20:59:02] jdlrobson: BUG: iPhone 6.1.3 clicking upload button after redirect doesn't show upload tutorial or change the icon. Doesn't effect edit button. [20:59:09] ha [20:59:13] HAHHA [20:59:19] you have a new phone jdlrobson? [20:59:30] or out of practice ;) [20:59:55] jcmish: no i was trying an iphone [21:00:06] :D ah not used to it [21:00:09] we should check if this is happening on other phones/OSs [21:00:29] all the general upload tutorial weirdness [21:01:01] Maryana: ken an i'd suggest we add a story to log taps on edit and upload from browsers that don't support it to get an idea of demand for it [21:02:10] jgonera: not found any issues in editor so far [21:02:24] me neither [21:02:29] https://gerrit.wikimedia.org/r/#/c/80138/ can you merge? [21:03:12] don't we already log when someone attempts an edit + UA? [21:03:16] MaxSem: i think I'm done testing [21:03:17] jdlrobson ^ [21:03:21] Maryana: no [21:03:41] only when the editor loads.. not if they clck the button when they don't support it [21:03:48] ahhh, i see [21:03:54] jdlrobson, does ^^ need deploying? [21:04:02] I think everything else looks good [21:04:48] MaxSem: up to Maryana [21:04:54] kenan and jcmish [21:04:57] where is ken an on irc? [21:05:11] MaxSem: Maryana jdlrobson I'm fine with it [21:05:16] I took a look at the commit [21:05:27] I just don't want to commit too many things but that one is cool [21:05:31] (03CR) 10Jdlrobson: [C: 031] Make toasts centered on Android browser [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80138 (owner: 10JGonera) [21:05:37] ok cool i'll +2 [21:05:38] fine with what - deploying a fix or living with it for a week?:) [21:05:41] (03CR) 10Jdlrobson: [C: 032] Make toasts centered on Android browser [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80138 (owner: 10JGonera) [21:05:42] all looks good to me [21:05:59] jdlrobson: where all three of the nexus4's on my desk ? [21:05:59] sorry MaxSem deploying this fix [21:05:59] :D [21:06:03] (03Merged) 10jenkins-bot: Make toasts centered on Android browser [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80138 (owner: 10JGonera) [21:06:13] tfinc: yup surprisingly! i've taken one already ;-) [21:06:21] worst burglar ever.. [21:06:24] wait [21:06:33] tfinc: and jdlrobson are you saying someone left those [21:06:39] but stole old machines? [21:07:00] jcmish: yes [21:07:04] ok [21:07:09] jdlrobson: wow [21:07:20] do we need to test with that change or should I just scap? [21:07:43] I say scap unless jdlrobson and jgonera disagree [21:07:47] jdlrobson: good i'm glad those weren't stolen some of the items that were stolen [21:07:48] it's not scary major [21:08:18] it's only CSS [21:08:29] what could possibly go wrong [21:08:34] ;) [21:08:40] hahahah shush awjr before you jinx us [21:08:46] :p [21:08:53] awjr, body { display: none } ? [21:08:57] hahaha [21:09:00] oops [21:09:50] someone added body display none? [21:10:27] i'm not sure if you guys are joking or not about burglary, but if you're missing any machines, check the server room [21:10:41] that's where the folks who were renovating the office moved odds and ends they didn't know what to do with [21:11:08] there's boxes and boxes of random crap in there, including a bunch of laptops, keyboards, etc. [21:11:26] Maryana, so nothing was stolen? [21:11:40] not to my knowledge! [21:12:31] Maryana: i wasn't as i received a note from lynette a week ago about three possibly stolen laptops. i've heard no updates on it. [21:13:16] oh, huh. i hadn't heard anything about that. [21:13:22] shrug [21:13:25] I saw the note too [21:13:29] I thought they were actually gone [21:13:44] Maryana: 3 laptops were stolen - gabrielle's and aarons [21:13:45] jdlrobson: reads like a joke to me [21:13:48] i forget the 3rd [21:14:06] weird... [21:14:11] all right, scapping [21:14:39] jdlrobson / jgonera: Googling through the entire MediaWiki extension tree for mobile-edit and mobileedit, and changetags (case-insensitive) doesn't find what I'm looking for [21:14:45] hence why i wanted to make sure our high priced items were still there [21:14:58] werdna, because it's 'mobile edit';) [21:15:19] still no results [21:15:24] extension tree is up to date [21:15:41] MobileFrontend.hooks.php [21:16:00] googling gives me this [21:16:01] https://git.wikimedia.org/commitdiff/mediawiki%2Fextensions%2FMobileFrontend.git/38668600ae376cedd0e3c97d7684f6574e8719f7 [21:16:22] yup [21:16:27] werdna, onRecentChange_save [21:16:46] I'd try grepping instead of Googling ;) [21:16:51] localhost:extensions andrew$ find . -name 'MobileFrontend.hooks.php' [21:16:52] localhost:extensions andrew$ [21:17:17] Maryana: any way to know how much pages get favorited on desktop? [21:17:19] Switched to branch 'master' [21:17:19] Your branch is behind 'origin/master' by 2517 commits, and can be fast-forwarded. [21:17:22] why the hell… [21:17:37] :O [21:18:04] kenanwang - yes, if you go to the article's history page and click "number of watchers" [21:18:14] takes you to a page like this: https://en.wikipedia.org/w/index.php?title=Beraprost&action=info#mw-pageinfo-watchers [21:18:28] "number of page watchers - 8" [21:18:32] Maryana: oooh i've never seen that before. nice! [21:18:47] yeah, all kinds of treasures can be found in page history.. :) [21:19:08] check out barack obama: https://en.wikipedia.org/w/index.php?title=Barack_Obama&action=info#mw-pageinfo-watchers [21:19:19] actually, that's not as huge a number as i would've thought [21:19:22] it doesn't differentiate between mobile and desktop watchers though [21:19:30] no, it doesn't.. [21:21:36] Kenan: for the cc by sa page.. [21:21:36] 10714 anonCTA [21:21:37] 14 unwatchlist [21:21:38] 93 watchlist [21:21:55] the high ANON cta click rate seems to suggest babies playing with iPhones [21:22:30] Maryana: https://en.wikipedia.org/w/index.php?title=Barack_Obama&oldid=2814496 [21:22:34] assuming the unwatchers are people that made mistakes 93-14/193 = 40% of all watchers come from mobile [21:22:39] that suggests accidents kenanwang [21:25:43] jdlrobson: yeah or that it's more prominent on mobile but it something is definitely happening with that page and with mobile [21:26:34] so jgonera i can confirm that micro tap is causing some of the qunit errors [21:26:40] but not all of them [21:26:46] hm [21:27:09] steps to reproduce or how did you figure it out? [21:27:35] i just removed it and less tests failed :) [21:27:42] Cannot read property 'isDefaultPrevented' of undefined [21:28:05] window click handler seems to be occurring before tapEvent is defined [21:28:31] if (tapEv && tapEv.isDefaultPrevented()) { makes 3 tests pass for me [21:28:41] instead of if (tapEv.isDefaultPrevented()) { [21:29:15] looking at overlays now.. [21:31:54] hm, I thought the fix I wrote changed this [21:32:00] I'll have a second look [21:33:06] overlay code makes no sense [21:33:19] (why the test for overlay fails) [21:36:00] ahhhh [21:36:02] i see why [21:36:07] tap changes again [21:36:39] jgonera: fixed all tests [21:37:00] patch? [21:37:38] ok i gotta get lunch and then assemble furniture at the house… i'll check in on irc in ~an hour if folks need me for anything [21:38:23] jgonera: on it's way.. i'm just checking it a bit closer.. [21:39:32] running down to get the kidlet a snack [21:39:35] back in a bit [21:39:53] still failing in debug mode.. i suspect this is because of the dependency tree [21:50:43] awjr, jcmish, jdlrobson, jgonera, kaldari, kenanwang and Maryana - scapped:) [21:50:48] w00t [21:51:09] \o/ categories [21:51:32] (if only they were formatted correctly on mobile!) [21:52:30] :D [21:52:45] categories make me excited [21:52:55] will they be formatted for mobile? jdlrobson? [21:53:13] uh [21:53:14] correctly that is :D [21:53:22] should we pull it in the next sprint? [21:53:29] i just tried to log in on enwiki and when i tapped 'login' i got sent to https://login.wikimedia.org/wiki/Special:CentralLogin/start?token=e9178bb60e4a6f0574f352228ddd7293 [21:53:31] or is that something that's more work? [21:53:45] alpha only jcmish - this was a volunteer patch - it just lists them in a section above languages [21:53:54] i imagine we will give them the same treatment as the languages button [21:54:04] ahh volunteer patch k that's what I was missing [21:54:06] i'm opening a bug now actually [21:54:13] weird; can't replicate tho [21:54:20] hmm awjr I'm not having it happen [21:54:27] but I'm gonna run the automation tests again [21:54:28] yeah jsut happened to me that once [21:54:41] sometimes they can get that to happen when I can't [21:58:49] whoa [21:59:08] it turns out if you add an image to a user namespace page [21:59:25] the image adder will actually add the image to the main namespace page [21:59:33] ohhh [21:59:35] oh no [21:59:35] now that's new [21:59:43] beta? stable? [21:59:48] that's cos we drop the stuff before the semi-colon, right jdlrobson? [21:59:49] eg i added a mobile upload to User:Awjrichards, but instead it created Awjricards and added the image there: http://en.wikipedia.org/wiki/Awjrichards [21:59:56] haha [22:00:06] this was in stable, jcmish [22:00:07] there are better ways of getting an article about yourself on wikipedia, awjr [22:00:10] owch [22:00:12] lol [22:00:14] ahahhahaha [22:00:16] it's a picture of my dog no less [22:00:22] well really it's treating Emma as the princess she is [22:00:23] i thought we didn't enable photo uploads in other namespaces? [22:00:38] nice - already speedied [22:01:10] awww :( [22:01:36] poor puppy [22:01:42] ahh we only apply it to main and user namespaces [22:01:49] mm so wonder why the namespace isn't working [22:02:03] we should, um, fix that.. somehow [22:02:08] eek we are using mw.config.get( 'wgTitle' ) [22:02:10] either disable it in user namespace for now [22:02:21] or make it work properly [22:02:27] it's an easy fix [22:02:28] i can definitely see lots of users trying it out [22:02:36] and then having their pages/photos deleted :( [22:02:50] good catch, awjr [22:02:55] you can thank emma :) [22:03:10] she was internet famous for a few minutes! [22:03:22] (03PS1) 10Jdlrobson: Ensure uploads from user namespace go to correct page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80145 [22:03:23] ^ Maryana awjr [22:03:30] hehehe not the first time! im afraid commons and enwiki admins probably hate her :( [22:05:28] hm, I messed up section editing in alpha, the buttons don't work, only the main one [22:10:31] gotta run an errand, should be back in about 20 mins [22:10:58] (03PS1) 10JGonera: Regression: make section edit buttons work in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80146 [22:13:10] (03CR) 10JGonera: [C: 032] Ensure uploads from user namespace go to correct page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80145 (owner: 10Jdlrobson) [22:13:34] (03Merged) 10jenkins-bot: Ensure uploads from user namespace go to correct page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80145 (owner: 10Jdlrobson) [22:21:17] (03PS1) 10Jdlrobson: Fix various Qunit tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80148 [22:21:18] jgonera: best i can do so far ^ [22:21:32] ok, just a moment [22:22:02] lots of weirdness [22:26:53] (03CR) 10JGonera: [C: 04-1] "(3 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80148 (owner: 10Jdlrobson) [22:28:37] jgonera Not when you fire a click event programmatically in a test... [22:28:47] then a mouseup/mousedown will never fire [22:29:49] (03CR) 10Jdlrobson: "(3 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80148 (owner: 10Jdlrobson) [22:29:51] jdlrobson, oh, I see... can you add a comment there explaining that (check for tapEv in case click triggered programmatically)? [22:30:00] jgonera: i've just commented to your messages [22:30:27] need to go and pick a package up from upstairs [22:31:23] (03CR) 10JGonera: "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80148 (owner: 10Jdlrobson) [22:33:03] (03PS2) 10Jdlrobson: Fix various Qunit tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80148 [22:38:53] (03PS1) 10Werdna: Add user_mobile AbuseFilter variable, to allow debugging mobile edits. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80152 [22:38:58] jdlrobson: ^^ [22:40:14] The idea would be to deploy that, wait a week or so, then use the retrospective batch testing interface to check which items in the abuse log are from the mobile interface [22:44:34] (03CR) 10MaxSem: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80152 (owner: 10Werdna) [22:44:48] werdna, ^^ [22:46:19] fixed [22:46:21] (03PS2) 10Werdna: Add user_mobile AbuseFilter variable, to allow debugging mobile edits. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80152 [22:46:28] * jgonera going to bed really soon. anybody needs anything? [22:49:50] (03CR) 10MaxSem: [C: 032] Add user_mobile AbuseFilter variable, to allow debugging mobile edits. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80152 (owner: 10Werdna) [22:51:07] (03Merged) 10jenkins-bot: Add user_mobile AbuseFilter variable, to allow debugging mobile edits. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80152 (owner: 10Werdna) [22:51:20] \o/ [23:00:24] (03CR) 10Jdlrobson: [C: 031] "Code looks fine - just need to test some more." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80132 (owner: 10JGonera) [23:00:49] (03CR) 10Jdlrobson: [C: 032] Regression: make section edit buttons work in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80146 (owner: 10JGonera) [23:01:12] (03Merged) 10jenkins-bot: Regression: make section edit buttons work in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80146 (owner: 10JGonera) [23:04:50] tfinc are you planning to come in tomorrow? [23:08:01] time to sleep, see you all tomorrow! [23:10:33] awjr: yes [23:10:52] tfinc - cool can i schedule some time for us to chat about next week's workshops? [23:11:00] yes [23:15:48] looks like you got a busy day tomorrow tfinc, had to schedule late in the aftenroon - i hope you'll still be awake :) [23:16:43] today is the first day since i've been back where i've felt even vaguely human in the afternoon [23:23:58] awjr: http://m.mediawiki.org/w/index.php?title=Special:Watchlist&watchlistview=feed&filter=all < do you see a message at the top of the page saying There are new messages for you. ?! [23:24:36] no jdlrobson, should i? [23:26:28] lets hope so :D [23:55:34] awjr: I'm still not feeling human today [23:55:41] but that's not jetlag, that's just regular tired and frustrated [23:55:54] werdna oh i thought it was because you were superhuman [23:55:57] heh [23:55:59] not quite :)