[00:08:45] <jdlrobson>	 awjr: nope that's good. i think some other extension is kicking in and showing it :(
[00:10:07] <awjr>	 :-|
[00:10:12] <awjr>	 jdlrobson: was it a CN banner?
[00:10:36] <jdlrobson>	 awjr: takes me to http://m.mediawiki.org/wiki/Special:NewMessages
[00:10:44] <jdlrobson>	 not sure why it is showing up on Watchlist view
[00:10:54] <jdlrobson>	 LiquidThreads i guess
[00:10:55] <awjr>	 o_O
[00:11:00] <jdlrobson>	 awjr: opening bug
[00:11:02] <awjr>	 maybe kaldari knows something about it? ^
[00:11:34] <Krenair>	 there's a special LQT link on the watchlist if you have new LQT messages
[00:11:56] <awjr>	 ahha, we are probably not stripping out that page element
[00:12:07] <awjr>	 or at least displaying it sanely
[00:13:56] <kaldari>	 yeah, probably just need to strip anything from LQT
[00:17:21] <awjr>	 kaldari: does lqt use a special css class?
[00:20:09] <werdna>	 lqt_watchlist_messages_notice
[00:20:12] <werdna>	 awjr: ^^
[00:20:56] <awjr>	 jdlrobson: we could just add that to the list of classes to strip for now; or come up with something smarter.
[00:20:57] <awjr>	 thanks werdna
[00:21:30] <jdlrobson>	 werdna awjr https://bugzilla.wikimedia.org/show_bug.cgi?id=53138
[00:21:45] <jdlrobson>	 ^ and kaldari 
[00:23:10] <awjr>	 werdna kaldari does that notice just show up on watchlist, or other pages too? also any other places LQT elements may show up?
[07:21:32] <grrrit-wm>	 (03PS1) 10MaxSem: Blacklist WAP phones from HTTPS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80178 
[07:28:52] <grrrit-wm>	 (03PS1) 10MaxSem: Fix doxygen [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80179 
[07:29:08] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Fix doxygen [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80179 (owner: 10MaxSem)
[07:29:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix doxygen [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80179 (owner: 10MaxSem)
[10:10:07] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80148 (owner: 10Jdlrobson)
[10:12:32] <grrrit-wm>	 (03CR) 10JGonera: "I'm OK with M.tapEventName = mw.config.get( 'wgMFMode' ) === 'alpha' ? 'tap' : 'click' with a FIXME saying that if micro.tap gets to stabl" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/78632 (owner: 10JGonera)
[11:09:18] <MaxSem>	 hey jgonera
[16:56:48] <jdlrobson>	 awjr: is there anyway OutputPage can access query string parameters?
[16:57:02] <awjr>	 jdlrobson: you should do so from the request object
[16:57:09] <jdlrobson>	 but that's private no?
[16:57:27] <awjr>	 no you should be able to get that publicly - there's a method...
[16:57:32] <awjr>	 i forget off the top of my head
[16:58:11] <awjr>	 jdlrobson: ill dbl check after standup
[16:58:17] <jdlrobson>	 i think i got it awjr 
[16:58:27] <MaxSem>	 $out->getRequest()->getText()
[16:58:40] <jdlrobson>	 yup what MaxSem said :)
[16:58:44] <awjr>	 there it is :)
[16:58:51] <MaxSem>	 mtg?
[16:59:44] <grrrit-wm>	 (03PS3) 10Jdlrobson: Don't redirect everything with oldid to MobileDiff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80067 (owner: 10MaxSem)
[17:00:46] <awjr>	 jdlrobson, jgonera standup!
[17:00:55] <jdlrobson>	 awjr: trying to get link :)
[17:01:01] <awjr>	 https://plus.google.com/hangouts/_/18e3805b6dcd5f41b8671b101360728b58bdc88c?authuser=1
[17:01:17] <jgonera>	 connecting earphones
[17:01:40] <awjr>	 jcmish: standup?
[17:15:33] * brion  waves

[17:16:13] <jdlrobson>	 Maryana: right clicking middle clicking etc works for me..
[17:16:19] <jdlrobson>	 MaxSem: does it work for you?
[17:16:19] <jgonera>	 jdlrobson, why would that be a troll bug? you wanted Nearby to work on desktop and not being able to open something in a new tab with a middle click is bad
[17:16:23] <jcmish>	 hate comcast
[17:16:32] <jgonera>	 jdlrobson, oh, so it works?
[17:16:35] <jcmish>	 sorry folks it bounced me 
[17:16:52] <jdlrobson>	 jgonera: https://gerrit.wikimedia.org/r/#/c/78348/
[17:17:22] <MaxSem>	 mmm, "Try an open area with a better signal." sounds stupid on desktop
[17:17:39] <jdlrobson>	 MaxSem: lol desktops are dead!
[17:17:42] <jdlrobson>	 long live the portable!
[17:18:03] <jgonera>	 jdlrobson, so it's deployed already or not?
[17:18:05] <jdlrobson>	 anyway it works for me.. if it doesn't he must have a really weird setup
[17:18:07] * MaxSem  puts jdlrobson into a briefcase

[17:18:23] <jdlrobson>	 jgonera: yes so i'm assuming this got raised before deployment
[17:18:26] <jgonera>	 right click and middle click give me kind of an unexpected behavior on enwiki
[17:18:33] <jdlrobson>	 jgonera: how so?
[17:18:54] <jgonera>	 well, just try it yourself, when I middle click, the article opens both in a new tab and current tab
[17:19:09] <jgonera>	 when I right click, instead of seeing the menu, the article loads
[17:19:11] <jdlrobson>	 i have no middle click to my knowledge on my mac
[17:19:14] <jdlrobson>	 right click works fine for me
[17:19:25] <jgonera>	 ctrl+left I guess, or buy a mouse
[17:19:31] <jdlrobson>	 jgonera: that was the old behaviour
[17:19:34] <jdlrobson>	 are you on desktop site or mobile site?
[17:19:38] <jgonera>	 mobile
[17:19:42] <jgonera>	 enwiki
[17:19:44] <jdlrobson>	 that's a beta thing then
[17:19:52] <jdlrobson>	 this guy was complaining about desktop
[17:19:55] <jgonera>	 I'm in stable
[17:20:16] <jdlrobson>	 jgonera: old js?
[17:20:21] <jdlrobson>	 works fine for me..
[17:20:35] <jdlrobson>	 god desktop version looks so nasty
[17:20:40] <jdlrobson>	 needs page iamges
[17:20:45] <jgonera>	 same with debug=1
[17:21:09] <jdlrobson>	 css isn't loading for desktop
[17:21:12] <jdlrobson>	 :(
[17:22:13] <jdlrobson>	 not sure how to resolve that without applying all our styles on desktop
[17:35:41] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] "Although the design treatment of this is not perfect it does make it obvious that you are looking at an old revision." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80067 (owner: 10MaxSem)
[17:40:41] <jdlrobson>	 anyone need anything before i head into office?
[17:49:05] <YuviPanda|away>	 brion: i'm back but that's mostly because neither of the clinics nearby were open, and I'm going to try ride it out.
[17:49:15] <YuviPanda|away>	 with some painkillers and attempted sleep. 
[17:49:31] <YuviPanda|away>	 don't think I'll get much done today
[17:55:27] <brion>	 :(
[17:55:49] <brion>	 Yuvi take care of yourself dude 
[18:12:51] <jgonera>	 awjr, MaxSem, what code is responsible for making the returntoquery parameter work? is it something in the core?
[18:13:10] * MaxSem  blinks

[18:13:25] <MaxSem>	 parameter to what?
[18:13:31] <MaxSem>	 it's used in many places
[18:13:36] <jgonera>	 query parameter, in login/create acc links
[18:14:01] <awjr>	 the returnto param?
[18:14:15] <awjr>	 i think that's typically handled in the skin but i think there are many different components that may make use of it
[18:14:19] <MaxSem>	 the special pages in question are handling it
[18:14:26] <jgonera>	 I need it to replace %23 with # before doing the actual redirect...
[18:14:42] <jgonera>	 yes, but where's the code taking this and redirecting the browser to the given URL
[18:15:03] <jgonera>	 I know I can peek at it in various places, but I need to modify its behavior
[18:15:08] <awjr>	 for login i think that actually happens in the UserLogin class
[18:15:16] <awjr>	 although it may get hijacked by CentralAuth extension
[18:15:27] <awjr>	 but i'd have to look to be sure
[18:15:35] <jgonera>	 we don't use CentralAuth anymore, do we?
[18:15:38] <MaxSem>	 hmm, does Location: support hashes?
[18:15:45] <MaxSem>	 jgonera, we do
[18:16:35] <jgonera>	 MaxSem, why wouldn't it
[18:16:44] <jgonera>	 tel
[18:18:53] <MaxSem>	 jgonera, you need to fix LoginForm::executeReturnTo(), apparently
[18:19:07] <MaxSem>	 need my help?
[18:19:42] <jgonera>	 that's in core?
[18:19:55] <MaxSem>	 yup
[18:24:53] <jgonera>	 MaxSem, doing 			$redirectUrl = str_replace( '%23', '#', $returnToTitle->getFullURL( $returnToQuery, false, $proto ) ); in line1023 seems lame, any suggestions?
[18:28:36] <MaxSem>	 jgonera, are you adding the anchor via returntoquery? returnto shoyuld work better
[18:28:56] <jgonera>	 oh, I didn't know it existed...
[18:29:17] <MaxSem>	 aaand no change needed:)
[18:31:48] <jgonera>	 thanks, MaxSem, seems to work
[18:32:06] * flyingclimber  yawns from jetlag

[18:32:10] <flyingclimber>	 flyingclimber == tfinc 
[18:32:24] <flyingclimber>	 guess i left myself logged in at home 
[18:34:24] <jgonera>	 MaxSem, one more. I was thinking, since we want to show edit buttons always now (even when logged out), we could just transform the desktop edit links into the mobile ones in the formatter, couldn't we?
[18:34:55] * MaxSem  facepalms and crawls under a carpet

[18:35:41] <jgonera>	 why? I mean, I can either change the formatter or add more cruft to JS
[18:36:59] <MaxSem>	 we need to run this past Jon
[18:37:13] <jgonera>	 ok
[18:38:02] <jgonera>	 I'm just scared that the JS for setting up editor buttons (buttons only) is almost 100 lines long
[18:41:04] <MaxSem>	 o_0
[18:43:04] <MaxSem>	 jgonera, I think there is a simple way to pervert the core parser to output the links in the formeat we need
[18:44:42] <jgonera>	 MaxSem, we don't want to prevent it, we need those links to parse the section IDs out of them. but instead of doing this, I'd prefer those links to be what we use on mobile, so instead of "?title=Banksia_violacea&action=edit&section=1", "#editor-1"
[18:49:36] <MaxSem>	 jgonera, not prevent but pervert:P
[18:51:37] <MaxSem>	 hmm, no need to pke Jon, actually
[18:54:02] <grrrit-wm>	 (03PS2) 10awjrichards: Blacklist WAP phones from HTTPS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80178 (owner: 10MaxSem)
[18:54:21] <MaxSem>	 jgonera, just override Skin::doEditSectionLink()
[18:54:28] <grrrit-wm>	 (03CR) 10awjrichards: [C: 032] Blacklist WAP phones from HTTPS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80178 (owner: 10MaxSem)
[18:54:48] <jgonera>	 MaxSem, thanks, will look into it in a moment
[18:54:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Blacklist WAP phones from HTTPS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80178 (owner: 10MaxSem)
[19:18:00] <awjr>	 MaxSem: im looking at https://gerrit.wikimedia.org/r/#/c/72612/1 - why don't we just use $wgServer?
[19:18:53] <MaxSem>	 awjr, then we should ditch getDesktopUrl() completely...
[19:19:27] <awjr>	 lemme see..
[19:19:39] <awjr>	 wow havent looked at this stuff in a long time
[19:20:01] <MaxSem>	 :)
[19:20:10] <awjr>	 MaxSem: updateDesktopUrlQuery seems to still be useful
[19:20:20] <awjr>	 so maybe we should jsut get rid of getDesktopUrlHost()
[19:20:41] <awjr>	 and just always use $wgServer
[19:21:24] <awjr>	 or just replace the logic in updateDesktopUrlHost() to return wgServer to keep things separate
[19:21:56] <awjr>	 which i think is what i would prefer to do but don't really care that muc
[19:21:57] <awjr>	 h
[19:23:34] <grrrit-wm>	 (03CR) 10Kaldari: "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76659 (owner: 10Kaldari)
[19:32:45] <grrrit-wm>	 (03PS2) 10awjrichards: An incomplete attempt to fix MobileContext::getDesktopUrl() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/72612 (owner: 10MaxSem)
[19:32:50] <awjr>	 what do you think MaxSem ^?
[19:34:24] <grrrit-wm>	 (03CR) 10MaxSem: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/72612 (owner: 10MaxSem)
[19:34:36] <MaxSem>	 awjr, just w/s:)
[19:34:44] <awjr>	 doh
[19:35:03] <awjr>	 i dont know why we didnt just use $wgServer before...
[19:35:10] <awjr>	 im hoping im not forgetting some weird usecase
[19:36:36] <grrrit-wm>	 (03PS3) 10awjrichards: Fix MobileContext::getDesktopUrl() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/72612 (owner: 10MaxSem)
[19:37:09] <jgonera>	 jdlrobson, any reason why we're not overriding Skin::doEditSectionLink() to generate our editor links?
[19:37:40] <jdlrobson>	 btw in case people were not aware… v
[19:37:41] <jdlrobson>	 http://en.m.wikipedia.org/wiki/Special:Uploads/Kaldari
[19:38:01] <jgonera>	 also, why do we use number-based anchors for sections instead of heading-based anchors (which are burried in spans inside h2s)?
[19:39:08] <awjr>	 MaxSem: fixed WS and updated commit message https://gerrit.wikimedia.org/r/#/c/72612/
[19:39:22] <jdlrobson>	 jgonera: because we are scared of changing HTML markup for caching reasons
[19:39:53] <MaxSem>	 jdlrobson, this particular one is cache-safe:)
[19:40:01] <jgonera>	 MaxSem, why?
[19:40:08] <jgonera>	 it generates links for anons too
[19:40:20] <awjr>	 i wish we had infinite scroll on the photo uploads page
[19:40:23] <jdlrobson>	 MaxSem: negative. not cache space
[19:40:25] <jgonera>	 but anyway, we can override it and start using it in one month
[19:40:25] <jdlrobson>	 awjr: we do
[19:40:29] <jgonera>	 awjr, we do in beta
[19:40:29] <awjr>	 ?
[19:40:30] <awjr>	 oh
[19:40:31] <awjr>	 beta
[19:40:31] <MaxSem>	 because it's done in ParserOurtput, after caching layer
[19:40:31] <awjr>	 yes.
[19:40:36] <awjr>	 sweet :)
[19:40:44] <jdlrobson>	 Maryana: where's the story for pushing infinite scroll to stable?
[19:40:46] <MaxSem>	 so no waiting is needed;)
[19:40:54] <jgonera>	 jdlrobson, ^
[19:40:57] <jdlrobson>	 same question to kenan but he's not here :)
[19:41:11] <Maryana>	 hmm… somewhere in the bowels of mingle
[19:41:27] <awjr>	 i think it would be nice if there was a beta/alpha indicator on the special pages as well
[19:41:30] <jdlrobson>	 MaxSem: i'm confused… the output HTML is different and not tied to the page content though
[19:41:38] <MaxSem>	 yup
[19:41:44] <jdlrobson>	 awjr: yeh we need better branding altogether
[19:41:48] <awjr>	 yah
[19:42:01] <jgonera>	 ok, food, be back soon
[19:42:23] <jgonera>	 in the meanwhile, could you explain the reasons behind the anchors, jdlrobson ?
[19:42:50] <jdlrobson>	 MaxSem: i'm still confused. we are talking about changing <h2 class="section_heading" id="section_1"><span id="foo">Foo</span></h2> to <h2 class="section_heading" id="Foo">Foo</h2>
[19:42:57] <MaxSem>	 yes
[19:43:09] <jdlrobson>	 jgonera: i'm totally confused with what you are asking and what MaxSem is saying
[19:43:16] <jgonera>	 jdlrobson, no, two different things
[19:43:16] <MaxSem>	 it's done after the caching layer, just when you request the HTML
[19:43:35] <jdlrobson>	 jgonera: write an email explaining it i'm not going to follow it in irc
[19:43:48] <MaxSem>	 <editsectionlink> is what gets cached
[19:43:49] <jgonera>	 we are talking about changing "?title=Banksia_violacea&action=edit&section=1" to "#editor-1" in edit links generated on the server side
[19:44:12] <MaxSem>	 then it gets substituted with user- and skin-specific HTML
[19:44:24] <jgonera>	 1) generating edit links, 2) anchors in section headings
[19:44:55] <jgonera>	 or lets talk after the meeting on the hangout
[19:55:42] <RodrigoPadula>	 Hello guys
[19:55:52] <RodrigoPadula>	 who is responsible by the Wikipedia Zero project?
[19:56:17] <RodrigoPadula>	 I tried to contact Kul to introduce to the manager responsible by nem projects here inside Telefonica Vivo - Brasil
[19:56:28] <RodrigoPadula>	 but I did received any reply from Kul yet...
[19:57:12] <RodrigoPadula>	 people from the local phone company is asking me about how to start the conversation to apply Wikipedia Zero here
[19:57:36] <awjr>	 RodrigoPadula: kul is probably your best bet for what you're talking about
[19:57:49] <awjr>	 he's been traveling and is likely behind on responding to emails
[19:58:03] <awjr>	 dr0ptp4kt may have some additional insight ^^
[19:58:19] <RodrigoPadula>	 hummm ok...
[19:58:26] <RodrigoPadula>	 I sent the emails some weeks ago
[20:00:38] <MaxSem>	 weeks?
[20:01:49] <awjr>	 jdlrobson, jcmish prioritization!
[20:02:43] <Maryana>	 + kaldari
[20:02:47] <Maryana>	 ^
[20:03:01] <kenanwang>	 jdlrobson: Hey you there?
[20:03:31] <kenanwang>	 jdlrobson: We're doing story prioritization
[20:05:14] <RodrigoPadula>	 MaxSem, yep...
[20:05:34] <MaxSem>	 flyingclimber, can you help^^^?
[20:06:07] <flyingclimber>	 RodrigoPadula: happy to help to get you to the right person
[20:06:10] <flyingclimber>	 let me pm you
[20:37:44] <awjr>	 www.wikipedia.org template: http://meta.wikimedia.org/wiki/Www.wikipedia.org_template
[20:50:28] <dr0ptp4kt>	 RodrigoPadula, I'll reach out to the business team regarding the Wikipedia Zero inquiry. Thanks!
[20:51:11] <dr0ptp4kt>	 RodrigoPadula, please accept our apologies for the delay. It's been a bit hectic around here, and there is a bit of a backlog.
[20:51:33] <RodrigoPadula>	 dr0ptp4kt, thanks!! I was talking to flyingclimber about that some minutes ago...
[20:52:08] <RodrigoPadula>	 so, I would like to help to find new partners fro Wikipedia Zero here in Brasil...
[20:52:22] <RodrigoPadula>	 I will keep in touch during the next weeks
[21:12:01] <jdlrobson>	 jgonera: thanks for that email it really helped
[21:12:30] <jgonera>	 jdlrobson, no problem
[21:12:42] <jdlrobson>	 hope my answer was helpful :)
[21:12:51] <jdlrobson>	 i completely misunderstood what you were trying to do
[21:17:31] <flyingclimber>	 Maryana: i'm glad to see a good a normal curve to http://mobile-reportcard.wmflabs.org/ uploads monthly 
[21:17:45] <flyingclimber>	 now that we have half a years data 
[21:17:58] <flyingclimber>	 roughly 1.5k right now
[21:18:50] <flyingclimber>	 Maryana: when are we getting a edits monthly tab ?
[21:20:10] <Maryana>	 oh yeah, we need one
[21:20:19] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Hygiene: get rid of M.getApiUrl() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80132 (owner: 10JGonera)
[21:20:27] <Maryana>	 i'll see what i can do about tat
[21:20:28] <Maryana>	 *that
[21:20:28] <flyingclimber>	 Maryana: need me a to add a story for it ?
[21:20:36] <flyingclimber>	 i want to make sure we get to it
[21:20:41] <Maryana>	 yeah, go for it!
[21:21:46] <grrrit-wm>	 (03Abandoned) 10Jdlrobson: Bug 52857: Allow editing of sections containing h1s. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79230 (owner: 10Jdlrobson)
[21:21:47] <grrrit-wm>	 (03PS1) 10JGonera: Story 1092: Show section-level edit login/signup CTA [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80298 
[21:23:58] <Maryana>	 maxsem - so wikimediafoundation.org appears to be broken on mobile
[21:24:04] <MaxSem>	 ?
[21:24:14] <Maryana>	 try visiting foundation wiki on a phone
[21:24:58] <flyingclimber>	 Maryana: done https://mingle.corp.wikimedia.org/projects/mobile/cards/1116
[21:25:09] <Maryana>	 fr-tech is running a mobile test banner and their feedback link goes to wmf.org - so they're wondering if they should stop the test
[21:26:37] <MaxSem>	 haaaaa
[21:27:02] <Maryana>	 any idea what's going on?
[21:27:12] <MaxSem>	 DNS
[21:27:44] <awjr>	 shit
[21:27:50] <awjr>	 that is not good, it was working the other day :(
[21:27:57] <awjr>	 could it be related to paravoid's dns changes?
[21:28:18] <awjr>	 m.mediawiki.org is also gone
[21:29:04] <Maryana>	 ruh roh
[21:31:40] <Maryana>	 so i'm guessing this is not an easy fix?
[21:32:30] <Maryana>	 i'll update the fundies
[21:32:38] <awjr>	 it may take a while
[21:33:00] <awjr>	 we're pinging the ops but DNS changes can take a while to take effect
[21:33:34] <awjr>	 asker os ;pplomg omtp ot
[21:33:35] <awjr>	 er
[21:33:38] <awjr>	 asher is looking into it
[21:34:35] <spagewmf>	 awjr or tfinc: https://mingle.corp.wikimedia.org/projects/flow/ only has Defect and Story card types, is there a way to import some from a richer project like mobile?
[21:34:40] <Maryana>	 awjr, cool
[21:35:14] <awjr>	 spagewmf: yes; i was actually thinking we should just start a new project for you guys in mingle and use one of the pre-set mingle templates
[21:35:34] <awjr>	 if you're amenable to it, i can get something set up for you guys before the workshops next week
[21:35:54] <spagewmf>	 awjr Mingle help shows a screenshot with [Import template] button, but I can't get to it.
[21:36:02] <jdlrobson>	 awjr: updating cards now
[21:36:05] <awjr>	 spagewmf: it will be a lot easier to start from scratch
[21:36:07] <jdlrobson>	 wanted to check i summarized correctly
[21:36:18] <awjr>	 jdlrobson: will look shortly
[21:36:20] <awjr>	 thanks :)
[21:36:23] <spagewmf>	 awjr That would be great thanks, I assume there's a way to import current cards
[21:36:24] <Maryana>	 thanks, jdlrobson - i was gonna but the fundies caught me
[21:36:32] <jdlrobson>	 eek the fundies!
[21:36:32] <jdlrobson>	 !
[21:36:43] <Maryana>	 i know. scary bunch :)
[21:36:45] <awjr>	 spagewmf: i *think* so; we may have to do some manual migration
[21:37:08] <awjr>	 spagewmf: but last i looked you guys didnt have too many cards so it shouldn't be a big deal i dont think
[21:37:25] <awjr>	 spagewmf: we'll generate a *lot* of cards during the workshops :)
[21:38:14] <awjr>	 spagewmf: i will likely tackle setting up the project tomorrow
[21:39:17] <spagewmf>	 awjr that would be great!  I'd like to Hangout and watch you
[21:39:30] <awjr>	 ok spagewmf, i'll ping you some time tomorrow :)
[21:40:44] <jdlrobson>	 gawd gerrit so slow today
[21:44:53] <flyingclimber>	 jdlrobson: you have chad in the office. let him know. 
[21:45:17] <jdlrobson>	 we moaned on the way to lunch about it flyingclimber 
[21:45:27] <jdlrobson>	 was effecting kaldari too
[21:45:46] <jdlrobson>	 i'm just moaning ;-)
[21:45:59] <kaldari>	 I was getting 30K/sec to gerrit
[22:00:38] <jgonera>	 anyone needs anything before I take off? jdlrobson?
[22:00:55] <jdlrobson>	 jgonera: somewhat fixed qunit tests would be handy
[22:01:33] <jdlrobson>	 jgonera: apart from that nothing i can think of
[22:01:59] <jgonera>	 jdlrobson, that line I commented in my last review is so stupid that I must punish you by not fixing it myself :P
[22:02:19] <jgonera>	 it's basically if ( true ) a = true else a = false;
[22:03:27] <jdlrobson>	 jgonera: there is a reason
[22:03:27] <jdlrobson>	 i was using another test beforehand which didn't return a boolean
[22:03:48] <jdlrobson>	 i refactored and forgot to change it
[22:04:20] <jgonera>	 ok, ok, just change it and merge yourself, you have my comment as a backup if someone screams at you for self-merging
[22:07:36] <spagewmf>	 awjr Holy mobile mingle transitions, Batman :)  Three still set mpinchuk as owner.
[22:07:57] <awjr>	 yeah the transitions are kind of a pita - though they are quite powerful
[22:10:35] <spagewmf>	 transitions cry out for sound effects. Ka-chunk, Wheeeee, Fworrmm
[22:10:41] <awjr>	 hehehe
[22:19:04] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Kill FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80306 
[22:19:05] <grrrit-wm>	 (03PS1) 10Jdlrobson: Story 964: Move Echo to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80307 
[22:28:24] <grrrit-wm>	 (03PS3) 10Jdlrobson: Fix various Qunit tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80148 
[22:30:31] <grrrit-wm>	 (03PS4) 10Jdlrobson: Fix various Qunit tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80148 
[22:30:46] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] "small thing fixed" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80148 (owner: 10Jdlrobson)
[22:31:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix various Qunit tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80148 (owner: 10Jdlrobson)
[22:31:27] <awjr>	 Maryana, MaxSem the DNS issue appears to have been resolved
[22:31:35] <Maryana>	 sweet
[22:31:40] <Maryana>	 i'll let the fundies know
[22:31:44] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Make page heading markup uniform [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80131 (owner: 10JGonera)
[22:31:48] <awjr>	 seems to be working for me, although in some places it may of course take some time for changes to propagate
[22:32:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: get rid of M.getApiUrl() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80132 (owner: 10JGonera)
[22:32:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make page heading markup uniform [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80131 (owner: 10JGonera)
[22:59:06] <kaldari>	 jdlrobson: Where'd you go?
[23:00:52] <Maryana>	 he came to tell me about a very dedicated vandal :)
[23:31:07] <grrrit-wm>	 (03PS1) 10Jdlrobson: Beta: Fix user info box on diff view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80312 
[23:41:00] <jdlrobson>	 MaxSem: https://gerrit.wikimedia.org/r/80067 < are you ok with this?
[23:41:56] <MaxSem>	 I'm not
[23:42:17] <MaxSem>	 subtitles are subtitles and shouldn't be mixed with banners
[23:43:03] <MaxSem>	 I think that diff navigation is more than noticeable as it can take a lot of space on mobile phoe screens
[23:46:39] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Wouldn't it be better to run drawer.render with appropriate arguments? Using updateUrl seems unnecessary.." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80298 (owner: 10JGonera)
[23:47:37] <grrrit-wm>	 (03CR) 10Jdlrobson: "Kaldari showed me the issue. I had another stab at it: https://gerrit.wikimedia.org/r/#/c/80312/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76659 (owner: 10Kaldari)
[23:47:56] <jdlrobson>	 MaxSem: well that's going to need some design input then.
[23:48:05] <jdlrobson>	 so we should abandon work on this until designers get back
[23:48:25] <kaldari>	 you beat me to it
[23:48:35] <jdlrobson>	 kaldari: to what?
[23:48:57] <kaldari>	 fixing the user info box
[23:49:01] <jdlrobson>	 MaxSem: FYI i did add a FIXME I don't expect it to always be a banner - it was just the easiest thing to do with existing css
[23:49:42] <grrrit-wm>	 (03CR) 10MaxSem: [C: 04-2] "I personally disagree with breaking UX by moving diff navigation to chrome, it's inconsistent with other skins. Waiting for design input." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80067 (owner: 10MaxSem)
[23:51:27] <jdlrobson>	 MaxSem: it's just a shame - viewing old revisions as far as i know are not a priority and i /miss/ not being able to view revisions :(
[23:51:49] <MaxSem>	 jdlrobson, why do you want this in banners so badly?
[23:52:12] <jdlrobson>	 MaxSem: i told you.. we have css that describes an element above the chrome that we can just reuse
[23:52:29] <jdlrobson>	 putting it below the title requires design input around how that looks next to the nav
[23:52:36] <jdlrobson>	 hence the FIXME
[23:52:40] <jdlrobson>	 this is just the easiest thing to do right now without any design input
[23:52:46] <jdlrobson>	 it is no reflection of me wanting it always to be this way
[23:53:11] <MaxSem>	 why always ask design?
[23:53:18] <jdlrobson>	 (hence https://gerrit.wikimedia.org/r/#/c/80067/3/includes/skins/SkinMinerva.php L109)
[23:53:29] <jdlrobson>	 MaxSem: because on mobile design is so important
[23:53:35] <jdlrobson>	 as space is so tight
[23:53:37] <kaldari>	 jdlrobson: the -20% right causes weird behavior in Firefox
[23:53:46] <jdlrobson>	 kaldari: really? :(
[23:53:53] <MaxSem>	 I'm a very big fan of keeping consistency with desktop skins if possible
[23:56:07] <jdlrobson>	 MaxSem: i don't think this is inconsistent - it's at the top of the page
[23:56:22] <MaxSem>	 compare with https://en.wikipedia.org/w/index.php?title=Fabian_Delph&oldid=569647820
[23:56:29] * Technical_13  still thinks there should be a left handed skin option available.

[23:56:50] <jdlrobson>	 anyway MaxSem all i
[23:56:53] <MaxSem>	 you can't expect people to remember all these little differences when switching between mobile and desktop
[23:57:19] <jdlrobson>	 anyway MaxSem all i'm saying is i think surfacing revisions is more important here than getting the design right. I agree the design needs love but I'm saying we should ask an expert about that
[23:57:22] <MaxSem>	 as a consequence, it will make this navigation _less_ noticeable
[23:57:36] <jdlrobson>	 i think this is just a minor design change that it's not worthy of my energy
[23:57:59] <jdlrobson>	 i'm just disappointed we cannot surface old revisions
[23:58:05] <MaxSem>	 so let's do it the most bizzarre way for now?