[00:04:04] <grrrit-wm>	 (03CR) 10Jdlrobson: "Maryana/Kenan looks like we are going to need some design input on how to show an old revision (see conversation belong). Without this old" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80067 (owner: 10MaxSem)
[00:07:09] <grrrit-wm>	 (03PS1) 10Jdlrobson: Bug 51639: Rephrase from 'All' to 'List' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80319 
[00:13:17] <grrrit-wm>	 (03PS1) 10Jdlrobson: Bug 53078: Underscore characters in watchlist confirmation toast message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80320 
[00:19:00] <dr0ptp4kt>	 jdlrobson, I added you to change 76201. the js-related stuff you can see by diffing patchset 6 and 8.
[00:19:21] <dr0ptp4kt>	 jdlrobson, upon yurik's return, he'll be making other php changes to this code. hoping you can look at the js, though.
[00:19:38] <kaldari>	 jdlrobson: Actually, right 0 doesn't help since that basically just restores the original behavior, where the thank button sticks to the right even if there isn't any room for it. It looks like there are 2 possible solutions: have a fixed-position container div that lets us match the behavior of the rest of the content or hide the user info drawer when we open the sidebar drawer.
[00:19:54] <dr0ptp4kt>	 jdlrobson, i zPrefixed variables, even though i know the IIFE will protect them
[00:20:30] <jdlrobson>	 kaldari: :(
[00:20:30] <dr0ptp4kt>	 jdlrobson, on that point, should i try to monkeypatch the modal to make it have the red background with white text? or would it make more sense to support that at instantiation?
[00:20:39] <jdlrobson>	 dr0ptp4kt: i'll take a look at this tomorrow
[00:20:42] <jdlrobson>	 poke me in the mornign
[00:20:48] <dr0ptp4kt>	 jdlrobson, thx, will do
[00:26:15] <grrrit-wm>	 (03CR) 10Kaldari: [C: 04-1] "Doesn't work right in Firefox. Clips the user info panel in full width view." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80312 (owner: 10Jdlrobson)
[00:30:21] <grrrit-wm>	 (03PS1) 10Jdlrobson: Bug 53104: Avoid showing last modified timestamp on non-existant pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80323 
[00:33:43] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Bug 53104: Avoid showing last modified timestamp on non-existant pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80323 (owner: 10Jdlrobson)
[00:34:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Bug 53104: Avoid showing last modified timestamp on non-existant pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80323 (owner: 10Jdlrobson)
[00:34:48] <kaldari>	 jdlrobson: The reason I had to create a separate container div is that I needed to assign it a width of "100%" to get it to match the behavior of the rest of the page, but it couldn't have both width:100% and padding:1em; so I had to split it into 2 divs.
[00:37:06] <kaldari>	 the width switches to 80% in the smaller view (as you were suggesting)
[00:39:16] <grrrit-wm>	 (03PS5) 10Kaldari: Fixes a bug with the display of the fixed userinfo panel when the left-nav is open. It now behaves the same as the article content - squishing at large screen sizes and clipping on small screens. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76659 
[00:43:42] <grrrit-wm>	 (03CR) 10Kaldari: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76659 (owner: 10Kaldari)
[00:44:32] <grrrit-wm>	 (03PS6) 10Kaldari: Fixes a bug with the display of the fixed userinfo panel when the left-nav is open. It now behaves the same as the article content - squishing at large screen sizes and clipping on small screens. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76659 
[00:44:47] <grrrit-wm>	 (03CR) 10MaxSem: [C: 04-2] "Freezing until WMF enables $wgSecureLogin." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80324 (owner: 10MaxSem)
[01:34:01] <grrrit-wm>	 (03PS7) 10Kaldari: Fixes a bug with the display of the fixed userinfo panel when the left-nav is open. It now behaves the same as the article content - squishing at large screen sizes and clipping on small screens. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76659 
[01:36:54] <grrrit-wm>	 (03PS8) 10Kaldari: Fixes a bug with the display of the fixed userinfo panel when the left-nav is open. It now behaves the same as the article content - squishing at large screen sizes and clipping on small screens. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76659 
[01:41:31] <grrrit-wm>	 (03PS9) 10Kaldari: Fixes a bug with the display of the fixed userinfo panel when the left-nav is open. It now behaves the same as the article content - squishing at large screen sizes and clipping on small screens. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76659 
[09:22:45] <grrrit-wm>	 (03CR) 10JGonera: "See comment for updateLinks() in CtaDrawer.js" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80298 (owner: 10JGonera)
[09:23:54] <grrrit-wm>	 (03CR) 10JGonera: "Alternatively, I could try running render() and then show() in setTimeout(), but I'm not sure if that's better." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80298 (owner: 10JGonera)
[14:46:34] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80320 (owner: 10Jdlrobson)
[14:46:53] <grrrit-wm>	 (03CR) 10JGonera: [C: 031] Bug 51639: Rephrase from 'All' to 'List' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80319 (owner: 10Jdlrobson)
[14:47:24] <grrrit-wm>	 (03CR) 10JGonera: [C: 032] Hygiene: Kill FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80306 (owner: 10Jdlrobson)
[14:47:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Kill FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80306 (owner: 10Jdlrobson)
[14:51:49] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] "(3 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76659 (owner: 10Kaldari)
[14:54:41] <grrrit-wm>	 (03CR) 10Orsagi: [C: 032 V: 032] translation module implementation [apps/android/translate] - 10https://gerrit.wikimedia.org/r/78318 (owner: 10Orsagi)
[14:55:48] <grrrit-wm>	 (03CR) 10Orsagi: [C: 032 V: 032] Full translation and edit abillity [apps/android/translate] - 10https://gerrit.wikimedia.org/r/79460 (owner: 10Orsagi)
[14:58:31] <grrrit-wm>	 (03CR) 10JGonera: [C: 031] "+1 so that others can still check it. If everything is fine, merge." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80307 (owner: 10Jdlrobson)
[15:04:54] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Fix MobileContext::getDesktopUrl() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/72612 (owner: 10MaxSem)
[15:05:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix MobileContext::getDesktopUrl() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/72612 (owner: 10MaxSem)
[15:11:20] <grrrit-wm>	 (03PS1) 10MaxSem: Uncomment token check in Special:MobileOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80389 
[15:16:44] <grrrit-wm>	 (03PS1) 10MaxSem: Rm header logging, several days worth of data should be enough [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80390 
[16:15:46] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Bug 51639: Rephrase from 'All' to 'List' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80319 (owner: 10Jdlrobson)
[16:16:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Bug 51639: Rephrase from 'All' to 'List' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80319 (owner: 10Jdlrobson)
[16:18:37] <grrrit-wm>	 (03CR) 10Jdlrobson: "Doing it that way would become even messier. Since wgTitle doesn't include the namespace we'd have to construct the namespace and prepend " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80320 (owner: 10Jdlrobson)
[16:23:33] * flyingclimber  yawns

[16:23:43] <tfinc>	 i've been up since 2am due to jetlag
[16:23:51] <tfinc>	 this will be a brutal day
[16:31:35] <jgonera>	 flyingclimber, I find that resisting sleep no matter what the first day (until 10pm or midnight) makes it much easier the following days (although the first one is a struggle)
[16:31:55] <flyingclimber>	 jgonera: i didn't go to bed till midnight on my first night 
[16:32:03] <flyingclimber>	 and slept till 8am 
[16:32:22] <tfinc>	 still was destroyed the second day
[16:32:28] <tfinc>	 even did all meals at regular times
[16:32:56] <jgonera>	 I guess it doesn't always work then ;)
[16:33:13] <tfinc>	 YuviPanda: feeling better? still alive ?
[16:33:19] <tfinc>	 jgonera: its about consistency
[16:33:34] <tfinc>	 i shouldn't have let myself doze off at 11pm last night 
[16:33:36] <tfinc>	 oh well
[16:34:09] <jgonera>	 yep, that probably didn't help
[16:34:37] <jgonera>	 yeah, YuviPanda, how's your ear?
[16:36:21] <tfinc>	 mhurd: YuviPanda: brion: how up to date is this https://trello.com/b/DzbU1dzm/mobile-app-sprint-14 ?
[16:36:38] <tfinc>	 it hasn't seen any movement in over two days
[16:36:48] <tfinc>	 leading me to think its out of sync
[16:39:08] <mhurd>	 tfinc: just moved "release to market" card to done column. otherwise seems up to date for iOS 
[16:49:21] <mhurd>	 tfinc: now that i have a better feel for how long complete autolayout-ification will take, do you think i should keep at it, or should I table it for now?
[16:50:04] <tfinc>	 add a story for it. we have a prioritization meeting scheduled for 11 today for our sprint kicking off next week
[16:50:27] <tfinc>	 *but* i have a strong feeling that we won't have enough people for it and that we'll have to delay out next sprint 
[16:50:36] <tfinc>	 this is because i have yet to hear from brion or yuvi today
[16:50:53] <mhurd>	 tfinc: ah. sounds good. hope yuvi's feeling better
[17:01:42] <grrrit-wm>	 (03CR) 10JGonera: [C: 032] Bug 53078: Underscore characters in watchlist confirmation toast message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80320 (owner: 10Jdlrobson)
[17:02:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Bug 53078: Underscore characters in watchlist confirmation toast message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80320 (owner: 10Jdlrobson)
[17:07:33] <jgonera>	 jdlrobson, do you know anything about the Campaigns extension?
[17:07:41] <jdlrobson>	 jgonera: i'm just replying now
[17:07:45] <jgonera>	 ok
[17:08:05] <kaldari>	 awjr: where was that parking garage that you used to use near the office?
[17:08:16] <awjr>	 kaldari: harrison and...
[17:08:20] <awjr>	 mnm
[17:08:25] <awjr>	 lemme look at a map
[17:08:44] <jdlrobson>	 jgonera: replied
[17:09:02] <awjr>	 kaldari: i want to say harrison between 3rd and 4th st
[17:09:07] <awjr>	 but not 100% sure
[17:09:35] <awjr>	 it was the cheapest day parking lot i could find close-ish to the office
[17:09:48] <kaldari>	 awjr: thanks
[17:16:27] <jdlrobson>	 awjr MaxSem we really need to find a way to get messages showing on test wiki/beta labs - seems like a message is showing up blank for some reason
[17:16:38] <awjr>	 what?
[17:16:42] <MaxSem>	 which one?
[17:16:51] <awjr>	 you mean i18n messages jdlrobson?
[17:17:25] <jdlrobson>	 awjr: yup
[17:17:44] <jdlrobson>	 so for some reason the fix i did to show a different toast for the edit button when there is no browser support is not showing
[17:17:51] <jdlrobson>	 quim just showed me and is going to reopen the bug
[17:18:32] <awjr>	 unfortunately testwiki is not a reasonable place to test messaging; betalabs should work though
[17:19:36] <jdlrobson>	 the fix is really dumb as well.. :/
[17:20:17] <awjr>	 im not really clear what the problem is
[17:20:25] <awjr>	 but if the message isn't present you should at least see the message key
[17:20:36] <awjr>	 on testwiki i mean
[17:20:58] <awjr>	 so if you're seeing something functionally broken, it's likely unrelated to the i18n messages not appearing
[17:21:44] <MaxSem>	 jdlrobson, I ran an update on beta - can you check?
[17:22:11] <jdlrobson>	 MaxSem: awjr no i'm just saying we would have trapped this in testing if we weren't trained to see broken messages...
[17:22:15] <jdlrobson>	 fix on the way
[17:22:18] <grrrit-wm>	 (03PS1) 10Jdlrobson: Bug 53059: Attach the message to the page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80407 
[17:22:20] <jdlrobson>	 ^ see
[17:22:33] <MaxSem>	 ah
[17:22:52] <awjr>	 oh
[17:22:55] <awjr>	 betalabs!
[17:23:24] <awjr>	 also, i think it would be swell if there were a vagrant instance that mimicked production that we could all use for local testing, etc
[17:23:49] <awjr>	 that way you could reliably test *before* committing and we wouldn't have to fully rely on betalabs (or test)
[17:24:08] <MaxSem>	 if you want to mimick prod, you'll need a bloody cluster of VMs
[17:24:15] <awjr>	 that is correct MaxSem
[17:24:21] <awjr>	 vagrant can do that for you
[17:25:10] <jgonera>	 awjr, in some cases you won't see the message key because it's wrapped in <> and the browser thinks it's a tag
[17:25:43] <awjr>	 !
[17:25:47] <awjr>	 i thought message output escapes html chars
[17:25:51] <awjr>	 unless you're using raw
[17:26:13] <jgonera>	 I'm not sure how that happens but I saw it in some cases
[17:26:18] <awjr>	 that is not good
[17:26:55] <awjr>	 that sounds like messages are not being properly escaped in those cases
[17:27:21] <jgonera>	 possibly, but maybe intentionally, there are some messages that include HTML
[17:27:30] <jgonera>	 I don't remember where I saw that...
[17:28:20] <jdlrobson>	 jgonera: the toast uses html
[17:28:35] <jdlrobson>	 the messages don't need to be the same - it would just be good to see some sort of message
[17:28:36] <awjr>	 oh yeah html messages :(
[17:28:54] <jdlrobson>	 is there a way to replace <message-key> with '{{message-key}}'
[17:29:05] <jdlrobson>	 at least that way it won't be rendered as html
[17:29:31] <jdlrobson>	 we could also add some javascript that pulls messages from the git repository when absent
[17:30:07] <awjr>	 we should really just have a reliable testing environment.
[17:30:14] <tfinc>	 Maryana: do we have limn graphs for edit failures ?
[17:30:31] <jgonera>	 tfinc, we will soon
[17:30:43] <tfinc>	 jgonera: this sprint ?
[17:30:46] <Maryana>	 yeah, it's in development this iteration
[17:30:48] <Maryana>	 :)
[17:30:48] <jgonera>	 yes, daily errors
[17:30:50] <jdlrobson>	 tfinc: yeh this sprint
[17:31:04] <jdlrobson>	 Maryana: jgonera the limn graphs are still out of date btw
[17:31:10] <jdlrobson>	 who do we poke to get them updatd?
[17:31:14] <jdlrobson>	 (deployed)
[17:31:20] <jgonera>	 milimetric
[17:31:45] <Maryana>	 hmm… out of date how?
[17:31:49] <jdlrobson>	 which room can i find milimetric in ?
[17:31:54] <jdlrobson>	 Maryana: it's not showing the newbie graph
[17:31:58] <jgonera>	 #wikimedia-analytics
[17:32:04] <Maryana>	 hrm :-/
[17:32:31] <jgonera>	 ok, gotta go, anybody needs anything?
[17:32:52] <awjr>	 MaxSem: wikimediafoundaiton.org is now getting auto-redirected :D https://rt.wikimedia.org/Ticket/Display.html?id=5624
[17:33:23] <dr0ptp4kt>	 jdlrobson, as requested, ping! would you please take a look at the js-oriented stuff in change https://gerrit.wikimedia.org/r/#/c/76201/6..8//COMMIT_MSG ? this is yuri's thing to which i added click interception. he'll be resuming work on the php-side stuff upon return, but your mad js feedback would be nice!
[17:33:26] <awjr>	 why does the main page stay on desktop though?
[17:34:30] <MaxSem>	 per product:D
[17:34:34] <grrrit-wm>	 (03CR) 10Kaldari: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76659 (owner: 10Kaldari)
[17:34:39] <jgonera>	 see you all tomorrow then!
[17:34:48] <awjr>	 see ya jgonera
[17:36:00] <Maryana>	 awjr, fundraising & communications requested that a bunch of pages stay desktop-only
[17:36:39] <awjr>	 oh, yeah - it is too bad main page is one of them :( i think it's confusing
[17:36:51] <jdlrobson>	 Maryana: http://mobile-reportcard-dev.wmflabs.org/ Successful first edits on mobile :D
[17:37:02] <Maryana>	 sweeeeet!
[17:37:08] <Maryana>	 that's awesome
[17:37:10] <jdlrobson>	 looks like we are adding about 200 a day
[17:37:21] <awjr>	 jdlrobson: can you summarize the issue with https://gerrit.wikimedia.org/r/#/c/80067/ ? i dont really understand after reading the comments
[17:37:39] <jdlrobson>	 awjr: sure.
[17:37:54] <Maryana>	 awjr, yeah… i think the formatting on that page just looks atrocious on mobile. not made for it at all, unfortunately :-/ but communications is looking for a designer to do a big overhaul of all the stuff on that wiki
[17:38:04] <Maryana>	 so maybe someday soon it'll be ready for mobile
[17:38:12] <awjr>	 makes sense; i hope so!
[17:38:15] <jdlrobson>	 awjr: there are 2 problems here 1) when oldid present it doesn't show the revision 2) when it does show the revision it is not clear you are viewing a revision rather than an up to date version of the page (queue trolling people to believe silly things)
[17:38:28] <jdlrobson>	 awjr: MaxSem and I are clashing over 2
[17:38:47] <jdlrobson>	 Desktop shows a bar saying viewing revision X with controls to go back a revision and forward a revision
[17:38:53] <jdlrobson>	 it shows this bar under the title of the page
[17:39:21] <jdlrobson>	 MaxSem wants it to be consistent with desktop and be under the title of the page but due to the fact we have a navigation bar there on mobile it looks very cluttered and i'm not sure how to handle the styling for it
[17:39:44] <jdlrobson>	 as a short term fix i suggested rendering it as a banner as we already have styling for that (and then review with designers later) but MaxSem vetoed
[17:39:58] <jdlrobson>	 so we are currently blocked
[17:40:07] <jdlrobson>	 awjr: is that clearer now?
[17:40:14] <awjr>	 i think so thanks jdlrobson
[17:40:34] <MaxSem>	 I'd not call this vetoed, you mentioned we need design yourself, I marked it with -2 waiting for it
[17:40:54] <awjr>	 jdlrobson, MaxSem have you guys discussed with Maryana yet?
[17:41:07] <MaxSem>	 Jon added her to that rev
[17:41:23] <Maryana>	 i've been seeing the bugs & gerrit comments, but i don't really understand the context
[17:41:41] <awjr>	 yeah, jdlrobson perhaps you can walk Maryana through it in a browser?
[17:41:42] <Maryana>	 two minutes with a demo on a local instance might help :)
[17:42:06] <Maryana>	 yeah, that would be really helpful - whenever you have a sec, jdlrobson
[17:42:39] <jdlrobson>	 Maryana: sure
[17:43:13] <jdlrobson>	 MaxSem: i also said we are unlikely to get design attention anytime soon. I said this was simply an intermediate measure until we get that
[17:43:53] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "(3 comments)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/76201 (owner: 10Yurik)
[17:44:15] <awjr>	 yeah with nearly all designers out that's probably true but maryana can at least point you guys in a good direction for now so we can move forward with that bug
[17:47:53] <grrrit-wm>	 (03PS1) 10MaxSem: Add an extra paranoid check to blacklisting of WAP devices from HTTPS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80410 
[17:56:29] <grrrit-wm>	 (03CR) 10Kaldari: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76659 (owner: 10Kaldari)
[18:06:28] <grrrit-wm>	 (03CR) 10Qgil: [C: 031] Bug 53059: Attach the message to the page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80407 (owner: 10Jdlrobson)
[18:12:23] <brion>	 welcome back tfinc 
[18:12:28] <tfinc>	 sup brion
[18:12:28] <brion>	 how's the jeglat?
[18:12:36] <tfinc>	 brion, crappy i've been up since 2am
[18:12:40] <brion>	 heh
[18:13:00] <brion>	 mhurd keeps trying to power through it, he might finally be adjusted now :)
[18:13:16] <tfinc>	 thus i'm chucking caffeinated tea and making sure mhurd kicks me if i fall asleep
[18:13:22] <tfinc>	 brion: will we see you in the office today ?
[18:13:52] <brion>	 tfinc, i can be in for the afternoon if you like, or i can keep hacking here. either works for me :)
[18:14:10] <brion>	 no more deliveries today
[18:14:29] <tfinc>	 brion: if your productive at home right now then stick with it and we'll see you in the office tomorrow
[18:14:47] <brion>	 spiff.
[18:14:48] <tfinc>	 we need to get our schedules back to normal/predictable now that everyone is back
[18:15:06] <brion>	 yes :)
[18:16:25] <tfinc>	 thus i expect you all in from now 
[18:16:42] <brion>	 +2
[18:18:17] <tfinc>	 brion: since i hadn't heard back from you and yuvi i cancelled the prioritization meeting for today and will likely delay the kick off 
[18:18:48] <brion>	 ok
[18:18:55] <brion>	 yeah yuvi seems to be out today still
[18:19:09] <brion>	 do the prio tomorrow or next week?
[18:23:01] <tfinc>	 yeah, i'm thinking monday'ish and kick off mid week 
[18:23:40] <tfinc>	 how has the rollout been of the new iOS release ?
[18:24:24] <brion>	 so far just seen happiness... :)
[18:25:09] <grrrit-wm>	 (03CR) 10Kaldari: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76659 (owner: 10Kaldari)
[18:26:40] <grrrit-wm>	 (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80298 (owner: 10JGonera)
[18:35:16] <jdlrobson>	 Maryana: i lost you
[18:35:17] <jdlrobson>	 come find me
[18:35:54] <Maryana>	 sorry, was in mtg, jdlrobson - omw now
[18:36:29] <jdlrobson>	 \o/ i'm by the hammock
[18:43:05] <YuviPanda>	 hey tfinc
[18:43:17] <tfinc>	 hey YuviPanda, how are you feeling ?
[18:43:48] <YuviPanda>	 tfinc: was okay all day, but then my ears started hurting again in the evening. On painkillers now, but wasn't able to sleep, so trying to get some distraction on the computer
[18:44:22] <jdlrobson>	 Maryana: eta?
[18:44:32] <tfinc>	 YuviPanda: i've canceled the prioritization meeting as i didn't hear back from you guys. is https://trello.com/b/DzbU1dzm/mobile-app-sprint-14 up to date for android
[18:44:40] <tfinc>	 brion: same question to you about the trello board
[18:45:04] <tfinc>	 i'm going to take the afternoon to catch up our backlog and test what you guys have put together
[18:45:07] <YuviPanda>	 tfinc: a lot of brion's stuff should be in 'working' or 'waiting for review'
[18:45:16] <tfinc>	 brion: can you move those over?
[18:45:21] <brion_>	 sure
[18:45:55] <YuviPanda>	 tfinc: my stuff is accurate.
[18:47:05] <YuviPanda>	 tfinc: I'll be going off in another 10 mins, I'd think - to try to sleep again before the painkillers wear off. Anything you want from me before that?
[18:47:16] <jdlrobson>	 Maryana: ?
[18:47:18] <brion_>	 ok, the cats on the overlay display got kicked back from review for a little more poking, so i'm keeping that in 'doing' column
[18:47:43] <Maryana>	 jdlrobson, where are you?
[18:47:43] <brion_>	 but it's in the same patch set as the description display :)
[18:47:48] <Maryana>	 i'm sitting in your chair :)
[18:47:50] <jdlrobson>	 kaldari: can you take a look at https://gerrit.wikimedia.org/r/80407 and https://gerrit.wikimedia.org/r/80307
[18:47:53] <jdlrobson>	 Maryana: hammock
[18:47:57] <jdlrobson>	 jdlrobson: \o/ i'm by the hammock
[18:48:02] <kaldari>	 jdlrobson: sure
[18:48:11] <YuviPanda>	 brion_: let me see if I can merge the OOM stuff
[18:48:17] <brion_>	 ok
[18:48:21] <brion_>	 i believe that one's ready yeah
[18:52:53] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Bug 53059: Attach the message to the page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80407 (owner: 10Jdlrobson)
[18:53:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Bug 53059: Attach the message to the page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80407 (owner: 10Jdlrobson)
[18:57:50] <jdlrobson>	 MaxSem: Maryana and I found a compromise for the old revisions
[18:57:53] <tfinc>	 brion_: so the list is up to date now ?
[18:57:58] <MaxSem>	 wee?
[18:58:07] <brion_>	 tfinc: looks correct yes
[18:58:11] <tfinc>	 thanks
[18:58:29] <grrrit-wm>	 (03PS4) 10Jdlrobson: Don't redirect everything with oldid to MobileDiff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80067 (owner: 10MaxSem)
[18:59:06] <jdlrobson>	 ^ MaxSem 
[18:59:11] <jdlrobson>	 so now it's below the heading
[18:59:22] <jdlrobson>	 Maryana pointed out the toolbar makes no sense on revisions as you can't edit
[19:00:20] <MaxSem>	 between title and page actions?
[19:00:49] <jdlrobson>	 MaxSem: it replaces page actions
[19:00:53] <jdlrobson>	 just for revisions
[19:00:57] <MaxSem>	 ah
[19:01:00] <MaxSem>	 makes sense
[19:01:06] <jdlrobson>	 making the page noticeably different
[19:01:09] <jdlrobson>	 yep i'm happy with it if you are
[19:01:12] <grrrit-wm>	 (03CR) 10MaxSem: [C: 031] Don't redirect everything with oldid to MobileDiff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80067 (owner: 10MaxSem)
[19:02:16] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Don't redirect everything with oldid to MobileDiff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80067 (owner: 10MaxSem)
[19:02:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't redirect everything with oldid to MobileDiff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80067 (owner: 10MaxSem)
[19:02:57] <MaxSem>	 :)
[19:03:00] <MaxSem>	 thanks
[19:12:33] <grrrit-wm>	 (03CR) 10Kaldari: [C: 04-1] "Return-to link loses the namespace prefix." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80307 (owner: 10Jdlrobson)
[19:12:59] <jdlrobson>	 kaldari: return to link?
[19:13:05] <jdlrobson>	 which one?
[19:13:15] <kaldari>	 The one on the Notificaitons page
[19:13:16] <jdlrobson>	 oohh i see what you mean
[19:13:20] <jdlrobson>	 let me fix that now
[19:15:47] <jdlrobson>	 kaldari: coming up!
[19:16:26] <grrrit-wm>	 (03PS2) 10Jdlrobson: Story 964: Move Echo to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80307 
[19:20:07] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Story 964: Move Echo to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80307 (owner: 10Jdlrobson)
[19:20:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Story 964: Move Echo to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80307 (owner: 10Jdlrobson)
[19:23:46] <jdlrobson>	 MaxSem: any ideas why the multiple issues template does not show up on http://en.m.wikipedia.org/wiki/Shyness ?
[19:23:54] <jdlrobson>	 but does on desktop: http://en.wikipedia.org/wiki/Shyness
[19:24:27] <MaxSem>	 haaaaa
[19:24:36] <MaxSem>	 metadata class
[19:24:41] <MaxSem>	 we strip it
[19:24:41] <jdlrobson>	 MaxSem: ?
[19:24:59] <jdlrobson>	 MaxSem: since when?
[19:25:02] <jdlrobson>	 did the template get updated?
[19:25:09] <MaxSem>	 since forever
[19:25:27] <MaxSem>	 but fixed it to actually work in all circumstances just this summer
[19:25:27] <jdlrobson>	 where is the code for that MaxSem ?
[19:26:14] <MaxSem>	 this partucular class is in mediawiki-config
[19:26:59] <jdlrobson>	 erg
[19:27:06] <jdlrobson>	 do we want to remove that?
[19:27:18] <jdlrobson>	 none of the article issues are currently showing uo
[19:27:41] <jdlrobson>	 can't we hide them in css instead?
[19:28:25] <MaxSem>	 the problem is that metadata is used for a bunch of other stuff
[19:28:30] <MaxSem>	 like topicons
[19:28:32] <MaxSem>	 hmm
[19:28:47] <MaxSem>	 I guess we can split this config...
[19:29:54] <MaxSem>	 jdlrobson, yet another reason to use ArticleEmblems and minimize the number of metadata HTML in pages;)
[19:30:16] <jdlrobson>	 shall i open a bug?
[19:32:20] <MaxSem>	 for AE? we'll discuss this in SF. for .metadata - not needed, I'll fix it right away
[20:02:04] <tfinc>	 jcmish: moving to a room now
[20:03:55] <jcmish>	 no worries
[20:19:05] <MaxSem>	 okay team, we have edit links in WAP view:P
[20:19:27] <MaxSem>	 why the hell do I care? XD
[20:23:45] <brion>	 hah
[20:23:47] <brion>	 oh WAP
[20:29:35] <awjr_lunch>	 oops
[20:29:37] <awjr_lunch>	 how did that happen?
[20:37:37] <MaxSem>	 rewrites and refactorings, how else?
[20:37:53] <MaxSem>	 oh, and we don't test WAP;)
[20:43:01] <jdlrobson>	 we used to strip out edit links on wap
[20:43:04] <jdlrobson>	 and mobile
[20:43:12] <jdlrobson>	 now we don't because we needed to know the section id
[20:43:17] <jdlrobson>	 *cough* formatter changes
[20:43:25] <jdlrobson>	 that's what you get when you hack
[20:45:16] <jdlrobson>	 Maryana: sandwich is fricking awesome
[20:46:58] <Maryana>	 yesssss
[20:47:02] <Maryana>	 nom nom
[20:56:40] <grrrit-wm>	 (03PS1) 10Yuvipanda: bug 50733: Fix OOM error on low-memory devices [apps/android/commons] - 10https://gerrit.wikimedia.org/r/80491 
[20:56:51] <brion>	 curious… https://bugzilla.mozilla.org/show_bug.cgi?id=880107
[20:57:18] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 032 V: 032] "Is from https://github.com/wikimedia/apps-android-commons/pull/42 :)" [apps/android/commons] - 10https://gerrit.wikimedia.org/r/80491 (owner: 10Yuvipanda)
[20:57:38] <YuviPanda>	 brion: merged OOO
[20:57:40] <YuviPanda>	 err
[20:57:40] <YuviPanda>	 OOM
[20:57:58] <brion>	 \o/
[20:58:04] <brion>	 thanks muchly sir
[20:58:13] <brion>	 ear feeling better?
[20:58:38] <ragesoss>	 does this only affect low-memory devices?
[20:58:45] <brion>	 ragesoss: yes
[20:58:49] <brion>	 < 48m of VM memory
[20:58:52] <YuviPanda>	 brion: no, planning on going to try sleeping again now.
[20:58:59] <brion>	 :( sleep well dude
[20:59:07] <YuviPanda>	 i'll try! hopefully will be all good tomorrow
[20:59:25] <YuviPanda>	 brion: slightly unrelated, but do read http://varnull.adityamukerjee.net/post/59021412512/dont-fly-during-ramadan
[20:59:34] <brion>	 YuviPanda: i did… scary shit man
[20:59:45] <brion>	 flying while brown is an issue sometimes in US :(
[21:00:06] <brion>	 but hey, racism is dead right?!
[21:00:12] <YuviPanda>	 sigh, yeah.
[21:00:36] <YuviPanda>	 brion: my flight to SF this time has 2 stopovers. hopefully won't be too horrible
[21:00:48] <brion>	 good luck……
[21:00:49] <brion>	 where at?
[21:01:16] <YuviPanda>	 brion: Chennai, Delhi, Newark, SF
[21:01:36] <brion>	 not too awful
[21:01:48] <brion>	 stopping in newark seems typical, they don't seem to fly straight to west coast much
[21:02:02] <flyingclimber>	 awjr: heads up that i wont last long this afternoon
[21:05:59] <brion>	 jet lag giveth and jet lag taketh away
[21:06:07] <brion>	 on the one hand, see some sunrises!
[21:06:50] <grrrit-wm>	 (03PS1) 10MaxSem: Refactor removals configuration [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80493 
[21:07:16] <MaxSem>	 jdlrobson, ^^^
[21:10:42] <jdlrobson>	 MaxSem: did you update the config too?
[21:10:52] <MaxSem>	 in process;)
[21:10:56] <jdlrobson>	 cool
[21:11:06] <jdlrobson>	 i'm happy to merge this
[21:11:16] <jdlrobson>	 MaxSem: in case you didn't see.. https://bugzilla.wikimedia.org/show_bug.cgi?id=53237
[21:12:51] <grrrit-wm>	 (03CR) 10MaxSem: "Corresponding config change: https://gerrit.wikimedia.org/r/80494" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80493 (owner: 10MaxSem)
[21:15:58] <jdlrobson>	 funniest diff ever http://en.m.wikipedia.org/wiki/Special:MobileDiff/565391494
[21:16:16] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Refactor removals configuration [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80493 (owner: 10MaxSem)
[21:16:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Refactor removals configuration [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80493 (owner: 10MaxSem)
[21:30:22] <jdlrobson>	 MaxSem: awjr heads up first volunteer mobile skin - https://github.com/pragunbhutani/WikibaseMobile
[21:30:32] <jdlrobson>	 although this one is also a desktop skin :D
[21:32:29] <MaxSem>	 mmm, and that's the whole result of his GSoC?
[21:36:35] <awjr>	 no problem tfinc, i figured
[21:37:06] <awjr>	 tfinc i havent dont much yet - i've been working 1:1 with s on mingle and trying to uncover some of things that will be good to focus on during the workshops
[21:38:21] <awjr>	 tfinc i just shared a new slide with you
[21:38:26] <tfinc>	 k
[21:42:07] <awjr>	 tfinc also i was thinking it might be useful to move the 'meetings' portion to sometime on Thursday and start doing personas on weds; that will increase the amount of hands-on stuff we do on Weds
[21:44:28] <tfinc>	 hmm
[21:44:39] <tfinc>	 that works for me
[21:44:52] <tfinc>	 what did Maryana think when you ran it by her?
[21:45:30] <awjr>	 i didnt run that specific idea by her yet; but she seemed on boardw ith the agenda generally; she wanted to make sure that we don't repeat anything from the appetizer workshop
[21:46:50] <tfinc>	 i meant in general
[21:49:25] <tfinc>	 awjr: i'm going to send myself home soon as i need a change of scenery to recharge my batteries 
[21:49:32] <awjr>	 no problem tfinc :)
[21:49:42] <tfinc>	 did you see my forwards about attendance ?
[21:49:48] <awjr>	 i did, thanks for sending those
[22:31:47] <grrrit-wm>	 (03PS1) 10Jdlrobson: Story 1073: Enable campaigns on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80503 
[22:36:29] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: "(3 comments)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/76201 (owner: 10Yurik)
[22:37:12] <grrrit-wm>	 (03PS9) 10Dr0ptp4kt: Removed X-CS dependency in HTML content rewriting [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/76201 (owner: 10Yurik)