[16:37:13] (03PS1) 10JGonera: Don't use document.body [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81012 [16:45:38] (03CR) 10JGonera: [C: 031] Fixes a bug with the display of the fixed userinfo panel when the left-nav is open. It now behaves the same as the article content - squishi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76659 (owner: 10Kaldari) [16:46:45] (03CR) 10JGonera: [C: 032] Bug 53102: Simple fix for text indent in older browsers on cancel button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80653 (owner: 10Jdlrobson) [16:47:09] (03Merged) 10jenkins-bot: Bug 53102: Simple fix for text indent in older browsers on cancel button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80653 (owner: 10Jdlrobson) [16:48:19] (03CR) 10JGonera: [C: 032] Bug 53103: Apply RTL styling for upload button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80656 (owner: 10Jdlrobson) [16:48:39] (03Merged) 10jenkins-bot: Bug 53103: Apply RTL styling for upload button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80656 (owner: 10Jdlrobson) [16:49:33] (03CR) 10JGonera: [C: 04-1] "Not sure yet if this is the right fix, see discussion on Bugzilla." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80665 (owner: 10Jdlrobson) [17:00:45] Maryana, jgonera - standup! [17:02:48] hey brion [17:02:57] yo YuviPanda [17:03:26] brion: how's the weekend? [17:03:50] relaxing. played a lot of saints row iv and had some chinese food :) [17:04:02] brion: heh, lots of people seem to be doing that [17:04:42] generally settling into the house…. i took a couple of my tablets home for the living room :) [17:05:14] brion: heh, nice! [17:05:22] brion: I finally managed to write the API :D care to review? [17:05:40] \o/ link me up and i'll look it over on the bus [17:05:45] (running a little late today, laundry) [17:14:50] mhurd: no, you sound like a robot [17:15:04] hmmm [17:15:06] mhurd: is that bad internet on your end? [17:15:07] or mine? [17:15:15] mhurd: plus you are moving like claymotion :P [17:15:18] jcmish, I'll have to run soon [17:15:23] mhurd: and I hear random cymbals [17:15:27] YuviPanda: hmm lol [17:16:28] Hi, are there any plans for enabling login and editing on the official wikipedia android app? [17:18:16] the only relevant thing i could find so far is https://bugzilla.wikimedia.org/show_bug.cgi?id=52772 [17:18:40] hey jgonera so i looked at https://gerrit.wikimedia.org/r/#/c/81012/1,publish - i'm a bit concerned that might impact styling though (specifically scrolling overlays) [17:18:53] could we not just wrap the overlay creation in a document.ready ? [17:19:02] jdlrobson, I checked on Android browser and Chrome [17:19:07] and Opera Mobile Classic [17:19:34] creation? you mean defining the Class? [17:19:35] specifically i was wondering if initialize should run in document.ready [17:19:46] I guess we'd have to wrap everything using an overlay in document.ready too [17:20:02] so this.initialize.apply( this, arguments ); > $( function(){self.initialize.apply( self, arguments );} ); [17:20:02] initialize? as in a single class method? [17:20:18] god, no, that's spaghetti ;) [17:20:36] well we shouldn't make any assumptions about where the code is running [17:20:38] Sid-G, there are plans, but no timeline afaik. YuviPanda might know more:) [17:20:59] * Sid-G pokes YuviPanda [17:21:06] we're not making any, we're just setting appendTo as a string which is later dynamically evaluated using $() [17:21:19] it's some weird Opera Mobile Classic bug we're trying to work around [17:21:28] jgonera: i don't think so [17:21:35] what do you mean? [17:21:37] i think Opera Mobile Classic is running the code before it should [17:21:44] wait [17:21:57] and that's what is causing $( 'body' ) to fail? [17:22:15] anyway, if it is, wrapping everything in document.ready is definitely not the solution [17:22:21] well if you look at editor.js we just run init(); [17:22:30] maybe we should run $( init ) and see if that solves the problem for opera mobile [17:22:31] hey, Sid-G. [17:22:33] (and use 'body' [17:22:37] i want to test that now [17:22:43] we can try that too, I'm fine with that [17:22:57] hi YuviPanda :) [17:22:59] Sid-G: the current wikipedia app is fairly 'abandoned'. We're planning on a reboot within the next 6 months or so, and that will definitely have login [17:23:04] Sid-G: in the meantime, use the mobile web version :) [17:23:14] (03PS5) 10MaxSem: Alpha: UserProfile special page (first pass) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76271 (owner: 10Jdlrobson) [17:23:18] (03CR) 10jenkins-bot: [V: 04-1] Alpha: UserProfile special page (first pass) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76271 (owner: 10Jdlrobson) [17:23:30] also i wondered about the name appendTo jgonera - we already have an appendTO function [17:23:40] we should probably rename it [17:23:45] yeah, we can change that [17:23:58] YuviPanda, mail me a link to the changeset to review and i'll look over it on the way to the office [17:23:59] YuviPanda: alrighty :) [17:23:59] we could name it "container" [17:24:05] brion_: doing [17:24:27] * Sid-G goes to rply to newbie who asked the question originally [17:24:27] brion_: done [17:25:17] tx [17:25:34] (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80673 (owner: 10Jdlrobson) [17:26:21] so jgonera tried it but sadly opera mobile still playing up. :( [17:27:15] jdlrobson: aren't you supposed to be at burning man? [17:27:39] jdlrobson, we could a) ignore opera classic for now b) go with the #mw-mf-viewport as a container [17:29:13] (03PS6) 10MaxSem: Alpha: UserProfile special page (first pass) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76271 (owner: 10Jdlrobson) [17:29:16] (03CR) 10jenkins-bot: [V: 04-1] Alpha: UserProfile special page (first pass) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76271 (owner: 10Jdlrobson) [17:30:44] YuviPanda: wednesday [17:30:49] ah, okay :) [17:30:51] ahhahrhg need to be there now though [17:30:57] can't sleep [17:31:16] jgonera: i'm fine with using mw-mf-viewport as long as we don't see any regressions occurring.. [17:31:29] jdlrobson, sure [17:31:38] k let's go with that [17:31:44] jdlrobson, if you could just find a moment and test on some iOS device, that would be great [17:32:31] (03CR) 10Jdlrobson: [C: 032] Fixes a bug with the display of the fixed userinfo panel when the left-nav is open. It now behaves the same as the article content - squishi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76659 (owner: 10Kaldari) [17:32:47] (03CR) 10Jdlrobson: [C: 032] Don't use document.body [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81012 (owner: 10JGonera) [17:32:50] BOOM [17:32:55] (03Merged) 10jenkins-bot: Fixes a bug with the display of the fixed userinfo panel when the left-nav is open. It now behaves the same as the article content - squishing at large screen sizes and clipping on small screens. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76659 (owner: 10Kaldari) [17:33:12] (03Merged) 10jenkins-bot: Don't use document.body [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81012 (owner: 10JGonera) [17:33:27] (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80661 (owner: 10Jdlrobson) [17:34:04] (03CR) 10MaxSem: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76271 (owner: 10Jdlrobson) [17:35:32] ahh didn't realize you hadn't tested on iOS jgonera eek i'll look at that now [17:35:56] jdlrobson, I'd be surprised if it broke there, but who knows [17:36:57] jgonera: seeing weirdness on master on ios4 but not introduced by your patch - position fixed seems to be broken [17:37:07] hm [17:37:45] (03CR) 10JGonera: [C: 04-1] "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80684 (owner: 10Jdlrobson) [17:37:49] jgonera: actually it happens on en wiki so it might be an emulator issue [17:37:50] (waiting for iPhone to charge) [17:38:09] I'm not sure if we have any iPhone with iOS 4.x [17:38:28] https://gerrit.wikimedia.org/r/#/c/80684/1/javascripts/specials/overlays/PagePreviewOverlay.js < jgonera in terms of why - this was because document.body was returning null [17:38:31] i'm hoping this patch fixes it [17:38:39] jdlrobson, will have to go in a few minutes, do you think you'd have time to look at https://gerrit.wikimedia.org/r/#/c/80133/ ? [17:38:41] I see [17:38:42] nearby does run at top of page though [17:38:47] hm [17:39:16] shouldn't matter as long as Overlay.show() is not run before the document loads [17:39:18] jgonera: i had a poke at it last week but i'm not sure if i'll finish that today - will try but want to make sure i fix a few other more pressing things first [17:39:25] (e.g. edit in another language) [17:39:28] jdlrobson, ok [17:39:35] edit in another language? [17:40:27] the edit button showing up in the "read in another language" button [17:41:13] https://gerrit.wikimedia.org/r/#/c/76659/ < kaldari does that mean https://gerrit.wikimedia.org/r/80312 can now be abandoned? [17:41:23] brion: ping? [17:41:34] Maryana: did you say the question about the app was on wikimedia-l? [17:41:37] or was it mobile-l? [17:41:38] jdlrobson: yes [17:42:01] yuvipanda: wikimedia-l [17:42:04] jgonera: https://gerrit.wikimedia.org/r/#/c/80673/1/includes/skins/SkinMinerva.php < so dependencies don't work when you use addModuleStyles [17:42:04] hmm, okay [17:42:12] the list where fun goes to die [17:42:26] jgonera: so on that basis can we merge as desktop nearby looks super ugly without it :) [17:43:12] Maryana: 'die' is too light a word :) [17:43:17] jgonera: alternatively I could leave it as it was and just add it to the nearby page on desktop [17:43:22] * YuviPanda looks [17:43:45] actually no that would be more duplication - this is the best way i can think of right now [17:44:08] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80673 (owner: 10Jdlrobson) [17:46:32] jdlrobson, oh well [17:46:37] jgonera: i have no idea why but removing these stops previews from working - something super odd going on !! - https://gerrit.wikimedia.org/r/#/c/80684/1/javascripts/specials/overlays/PagePreviewOverlay.js [17:46:48] (even when rebased) [17:46:48] (03CR) 10JGonera: [C: 032] Desktop: Load pagelist styles on nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80673 (owner: 10Jdlrobson) [17:47:08] jdlrobson, have you rebased [17:47:09] ? [17:47:10] (03Merged) 10jenkins-bot: Desktop: Load pagelist styles on nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80673 (owner: 10Jdlrobson) [17:47:12] yup [17:47:13] hm [17:47:23] so what's happening? [17:47:28] nothing shows up? any errors? [17:47:51] tfinc, mhurd: this is crazy: http://www.rockandice.com/video-gallery/adam-ondra-sending-move-5-15b [17:48:21] alert( this.appendTo ); alerts null [17:48:25] is this the one in Scandinavia ? [17:48:31] i swear there is something weird going on with extend [17:48:41] it only seems to effect things which extend something that has been extended [17:49:07] can you push the rebased change? [17:49:20] sure [17:49:40] awjr: he's insane! [17:49:53] tfinc: yeah, it's in norway [17:49:57] mhurd: right?! [17:50:01] (03PS2) 10Jdlrobson: Nearby bug fixes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80684 [17:50:04] ^ jgonera [17:50:09] do you think I can have a second look at it tomorrow? I'm supposed to meet a friend in 10 minutes, will be a few minutes late already I'm afraid... [17:50:19] argg 1s [17:50:23] jgonera: sure [17:50:59] weird it works now anyway [17:51:03] :O [17:51:05] cache? [17:51:13] (03PS3) 10Jdlrobson: Nearby bug fixes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80684 [17:51:17] cache i suspect yeh [17:51:17] ok, if it doesn't work, I'll check it tomorrow [17:51:28] i'll poke kaldari to test and merge [17:51:31] ok [17:51:36] see you tomorrow [17:53:46] brion: ping! can you show off the android stuff at the showcase? [17:53:56] brion: just the regular stuff, plus perhaps the holo light patch? [17:56:08] YuviPanda: yeah [17:56:12] ooh i'll try and test that one too [17:56:18] ok off to the bus [17:56:50] (03PS2) 10Jdlrobson: Log thank events from diff view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80661 [18:11:10] jcmish: 1092 doesn't work - i'm working on a fix as we speak [18:11:18] k thanks! [18:11:21] you might want to shift it back to in development [18:11:29] yup doing that now [18:19:42] jcmish: ok got the fix [18:19:44] (03PS1) 10Jdlrobson: Regression: Stop edit cta showing for things that are not editable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81023 [18:19:50] ^ need kaldari to review this [18:20:03] looking [18:20:53] MaxSem: thanks for the help with the profile stuff btw :) [18:21:02] :) [18:21:11] cool [18:22:11] (03Abandoned) 10Jdlrobson: Beta: Fix user info box on diff view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80312 (owner: 10Jdlrobson) [18:27:12] brb gonna grab a bite [18:27:44] (03CR) 10Kaldari: [C: 032] "Looks good" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81023 (owner: 10Jdlrobson) [18:28:09] (03Merged) 10jenkins-bot: Regression: Stop edit cta showing for things that are not editable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81023 (owner: 10Jdlrobson) [18:35:14] can someone review https://gerrit.wikimedia.org/r/#/c/80389/ plz? [18:35:54] MaxSem: if you get Maryana's blessing on the language, i can merge [18:36:13] (03CR) 10Kaldari: [C: 032] Log thank events from diff view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80661 (owner: 10Jdlrobson) [18:36:35] mhurd: is this the latest market release https://github.com/wikimedia/Commons-iOS/releases/tag/REL_1_0_8 ? [18:36:44] * Maryana looks [18:37:08] (03Merged) 10jenkins-bot: Log thank events from diff view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80661 (owner: 10Jdlrobson) [18:37:37] * YuviPanda pounces on brion [18:37:42] flyingclimber: yes, i believe so [18:37:53] i got logged out of gerrit somehow :-/ but lgtm, maxsem, awjr [18:37:54] brion: is https://github.com/wikimedia/Commons-iOS/releases/tag/REL_1_0_8 the latest release ? [18:38:08] tfinc: yes [18:38:12] thanks Maryana :) [18:38:20] now to figure out how to log back in [18:38:24] * Maryana shakes fist at gerrit [18:38:33] Maryana: there should be a login link in upper right corner [18:38:43] yeah, i just don't remember my creds [18:38:47] oh [18:38:51] heh that's more complicated [18:38:55] * tfinc builds the latest code tree to see where things are at [18:40:06] Maryana: thanking will now log [18:40:19] sweet! [18:40:38] YuviPanda: is https://github.com/wikimedia/apps-android-commons/releases/tag/v1.0beta11 latest market release ? [18:40:41] tfinc: are we ordering in lunch today for the show and tell or should i go grab some? [18:40:46] yup, tfinc [18:40:52] grab lunch [18:41:07] tfinc: there's a branch' campaigns' there that has teh campaign work tho [18:41:11] it's not in master yet [18:41:18] mhurd: want to fill up https://etherpad.wikimedia.org/p/MobileShowcase [18:41:18] ? [18:41:26] YuviPanda: ya [18:43:21] (03PS4) 10Jdlrobson: Story 1073: Enable campaigns on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80503 [18:43:38] (03CR) 10awjrichards: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80389 (owner: 10MaxSem) [18:44:03] brion: think you can look at the API patch before the showcase? [18:44:04] or after? [18:44:30] YuviPanda: i left a comment on the patch set, it looks ok offhand but i'll test it to be sure after the showcase [18:44:37] brion: okay! :) [18:45:30] meanwhile let me load on my details page branch [18:45:48] (03PS3) 10MaxSem: Uncomment token check in Special:MobileOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80389 [18:45:55] awjr, ^^ [18:47:38] (03CR) 10awjrichards: [C: 032] Uncomment token check in Special:MobileOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80389 (owner: 10MaxSem) [18:47:56] (03Merged) 10jenkins-bot: Uncomment token check in Special:MobileOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80389 (owner: 10MaxSem) [18:49:01] thanks awjr & Maryana [18:49:05] :D [18:58:36] mhurd: yurik MaxSem: heads up showcase in 2 min [18:58:40] and others .. [18:58:47] tfinc: ya [18:58:49] yup [18:58:52] tfinc: I can't hear you [18:58:53] cool [18:59:15] tfinc: can hear you now [18:59:19] awjr: --^ [19:00:16] awjr: joining us ? [19:00:27] brion: got the desc patch? [19:00:33] also the light theme? :) [19:01:13] YuviPanda: desc patch yes, light theme not yet [19:02:15] yeah tfinc [19:02:20] was making a sandwich [19:04:34] brion: okay. [19:09:48] hi YuviPanda, what are we going to do with the whole component thing in bugzilla? [19:10:03] I prefer a mobile component under WLM [19:10:06] than bring up a product [19:11:53] brion: wait for mobile web to show off, and then display holo light? [19:13:09] YuviPanda: is holo theme on your fork? [19:13:16] brion: holo-light [19:13:26] brion: hmm, let me see. [19:13:28] i gotta add you to my repo [19:14:09] YuviPanda: ok found it :D [19:14:18] jesus fucking christ, this laptop feels like it is from 1999! [19:14:48] * YuviPanda stabs it [19:17:39] YuviPanda: Me too [19:18:04] Can you comment on the bug? [19:18:48] And we should probably go though https://bugzilla.wikimedia.org/buglist.cgi?list_id=228912&resolution=WONTFIX&query_format=advanced&bug_status=RESOLVED&component=Browse&component=General&component=Login&component=Maps&component=Upload&product=WikiLoves%20Monuments%20Mobile [19:19:47] multichill: current resolution seems appropriate to me :P [19:20:25] Most of the bugs don't really look like they should be opened again [19:21:03] indeed [19:21:19] plus I don't think I want to touch the code at all, if possible [19:21:19] YuviPanda: got the build installed but now the video capture stopped working. :P [19:21:21] can't win eh [19:21:29] brion: android screen monitor? :P [19:22:29] ssllooww but it'll do :) [19:23:07] brion: heh, mobile web also seems to get much more engagement than apps. oh well. [19:23:20] :) [19:27:35] multichill: which bug do you want me to comment on? [19:27:59] YuviPanda: https://bugzilla.wikimedia.org/show_bug.cgi?id=53333 [19:28:33] multichill: also, thoughts on setting up a 'Wiki Loves Monuments' organization, with its own signing key, that can release the app? [19:28:55] sure [19:29:22] multichill: a key needs to be kept securely, and the account itself, of course. [19:29:28] who would be able to set that up? [19:29:44] Maybe you can just do that? [19:29:57] I can do that, yeah [19:30:07] tomorrow. hopefully. [19:34:44] (03CR) 10MaxSem: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76271 (owner: 10Jdlrobson) [19:38:30] ty YuviPanda [19:50:47] hey brion [19:51:11] heyy [19:51:20] brion: patch? :) [19:51:34] shortly :) [19:51:55] tfinc: have you had time to think more of the wikipedia app? [19:52:12] i'm focused on wrapping up the sprint for commons right now [19:52:17] tfinc: ok [19:57:37] welcome back, yurik. would you please remove the -2 from 69420 and also +2 80574? [19:57:52] dr0ptp4kt, hey! [19:57:55] checking... [19:57:55] yurik, how was the vacation? [19:58:04] good to be back :) [19:58:09] wb, yurik [19:58:13] thx :) [19:58:21] I implemented an API and now I understand why you want to get rid of all formats :) [19:58:24] (other than JSON) [19:58:27] s/API/API Module/ [19:58:32] yep yep [19:58:53] now we need to convince brad to approve my change and we can move forward on that [19:58:57] they all seem so.... stateful [19:59:44] dr0ptp4kt, removed 69420 [20:00:11] YuviPanda: https://bugzilla.wikimedia.org/show_bug.cgi?id=53333 <- please cmt [20:00:12] YuviPanda: brion: mhurd: are any of you *not* chrome browser users ? [20:00:24] tfinc: i'm mostly a firefox user [20:00:28] i use chrome just for hangouts :) [20:00:35] tfinc: i use chrome and safari [20:00:42] as i was debating about trying this https://chrome.google.com/webstore/detail/scrum-for-trello/jdbcdblgjdpmfninkoogcfpnkjmndgje [20:00:43] tfinc: I use both Chrome and FF [20:00:44] * yurik is using lynx [20:00:56] tfinc: we could, yeah. [20:01:09] multichill: ah, ok [20:01:46] tfinc: pooh. nice! [20:02:04] "oooh" != "pooh" damn autocorrect [20:02:28] dr0ptp4kt, why do you need those lines? also, could you please make the ID shorter? I really don't like half a page id there :) [20:02:34] "In the card titles you can add the storypoints between parentheses. The assigned points will be picked up by Scrum for Trello and displayed in the upper right corner of the card." <-- exactly what we already do [20:02:53] YuviPanda: brion: mhurd: --^ [20:03:09] this chrome users get some extra ui niceness while others see the same points we've had before [20:03:19] o_O [20:03:23] no other changes are necessary :D [20:04:12] :D sounds good, tfinc [20:04:14] let's try it! [20:04:37] i like that someone was doing the exact same kind of point tracking as us [20:05:53] its coming from an article that Maryana shared with me http://www.civicactions.com/team/kevin_walsh [20:05:59] err [20:06:20] yurik, the HTML template for rendering the overlay view doesn't support interpolations of $1, $2, … jdlrobson recommended against the JS-based supported interpolation inside of the JavaScript interstitial.js and recommended to get a translation in the hopper instead. [20:06:47] this one http://www.civicactions.com/blog/2012/oct/10/five_tips_for_using_trello_for_scrum [20:06:56] dr0ptp4kt, not sure what you mean [20:08:51] tfinc, jdlrobson do either of you have a photo of the mobile web team - or at least most of it? [20:09:04] errrrr [20:09:15] not all together awjr i usually just piece together photos [20:09:22] yeah [20:09:29] ok [20:09:30] thanks! [20:09:32] actually [20:09:37] look at the tip of defrag-cache2. there's a new HTMLish template that takes as named parameters the values that get visibly rendered during presentation of the (js-based) interstitial. it supports {{someVal}}. those named parameters are defined inside interstitial.js. we end up having to do somewhat complex escaping and munging if we do stuff in js with those $1, $2 vars instead of just having separate variables. [20:09:44] nm [20:09:45] ^yurik [20:10:23] dr0ptp4kt, are you saying we can't use the regular MW-style i18n? [20:10:25] in javascript [20:10:48] i thought we had a js lib that has the same capabilities as php one? [20:11:00] including parameter expansion [20:13:00] yurik, not exactly. the javascript *does* support subvariable interpolation / expansion. i believe jon's code review was dealing with separating the Model (JS) from the View (template) as much as possible. [20:13:16] jdlrobson, did i understand correctly? ^ [20:15:19] Doing it this way will just ensure you benefit from better consistency and less breakage [20:15:24] it's also easier to read [20:15:48] i'm not sure what you are referring to about MW-style i18n [20:16:06] mw.msg( 'key', 'foo', 'bar' ) should apply parameters to key [20:16:48] jdlrobson, if i understand correctly, dr0ptp4kt is talking about dynamically creating a message for the user in JS based on the i18n messages + some additional values that need to be inserted into those messages [20:17:09] usually the substrings are inserted with $1 $2 ... [20:17:17] (03Abandoned) 10Jdlrobson: Bug 53282: Don't rely on extend / fix the uploads page button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80665 (owner: 10Jdlrobson) [20:17:21] awjr: no team photo that i know of. something to think about for all staff [20:17:23] that's all the info i have :) [20:17:54] yurik: ? so if you have a message "$1 said $2" that will still work in JS [20:18:12] what do you mean by dynamically creating a message? [20:18:40] wfMessage("id").parameter(1,2,3).render() [20:18:42] (03PS4) 10Jdlrobson: Introduce PageApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80133 (owner: 10JGonera) [20:18:57] yurik, jdlrobson - this is the before-after https://gerrit.wikimedia.org/r/#/c/76201/9..14/modules/interstitial.js [20:19:01] jdlrobson, ^ that should be creatable in js, not just phph [20:19:05] yurik: so that in js would be mw.msg( 'id', 1,2,3) [20:19:32] only thing you can't do in JS easily is parse (although if needed there is a way) [20:19:46] yurik, like jdlrobson says, mw.msg can do the trick. 2 and 3 need to be fully crafted html elements though. [20:20:32] YuviPanda: is this still an issue https://bugzilla.wikimedia.org/show_bug.cgi?id=45407 ? [20:20:41] (my original code was more cluttered than necessary, but same principle at play) [20:20:42] jdlrobson, are you still working on UserProfile or can I hack it now? [20:20:48] MaxSem: feel free to hack it [20:20:57] MaxSem: i'm done with what i need to do - i just want to get it out there now :) [20:21:06] then i have a few things to iterate on [20:21:25] tfinc: commented there [20:22:20] dr0ptp4kt, i must be missing context of some sort :) My initial comment was about how long the ID is in 80574 [20:22:23] yurik, see also https://gerrit.wikimedia.org/r/#/c/76201/9..14/templates/interstitial.html <-- jdlrobson [20:23:06] YuviPanda: https://bugzilla.wikimedia.org/show_bug.cgi?id=48436 I think this bug is too broad for our app is instead needs to be a sitewide decision [20:23:09] yurik, oh yeah…okay, so the extra i18n is to queue up the messages so they're ready when we go live [20:23:27] the patch name for the i18n i can rename easy [20:23:42] tfinc: not really. It has nothing to do with ops as such, and is implemented in the app itself. [20:23:52] YuviPanda: how so ? [20:24:01] (03CR) 10Jdlrobson: [C: 032] Introduce PageApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80133 (owner: 10JGonera) [20:24:04] cool, lets do that, will approve. Lets only keep the first 4 words intact (even though i would LOVE to change them all to a shorter abrev) [20:24:19] dr0ptp4kt ^ [20:24:19] tfinc: you ship the app with the fingerprint of your certs, and the app verifies those when connecting. [20:24:20] (03Merged) 10jenkins-bot: Introduce PageApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80133 (owner: 10JGonera) [20:25:01] yurik, oh wait you're talking about the key names in the i18n file, not the branch name, right? [20:25:11] right [20:25:12] tfinc: so if someone MITMs the user and uses a different certificate, then it will be rejected - even if the certificate is otherwise valid for the platform [20:25:15] yurik, ok, one minute [20:25:23] i don't care about the branch name that much :) [20:25:32] YuviPanda: ahh. that makes more sense. but given that uploads are directly attributed to users i din't see a point to this [20:25:45] tfinc: it's mostly to protect against password theft [20:26:08] tfinc: and cookie stealing. you MITM the user, and we send the auth cookies over the line, and boom - attacker has cookies! [20:26:20] tfinc: or cookies are invalidated, we send username / pass - and boom, attacker has username and pass [20:26:44] tfinc: we arleady use SSL to make that scenario safe - certificate pinning makes it even more safer [20:26:54] tfinc: not a high priority, though. [20:27:47] YuviPanda: is this still valid https://bugzilla.wikimedia.org/show_bug.cgi?id=47611? [20:28:03] (03PS1) 10Jdlrobson: Bug 49033: Style pre and code tags properly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81114 [20:28:19] tfinc: they're... intermittent? more intermittent than they were - I've not seen it in the last month. But because they're intermittent, hard to say? [20:28:51] (03PS3) 10Dr0ptp4kt: Adding two messages to prepare for re-arch of WZ link rewriting. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/80574 [20:29:03] (03CR) 10Jdlrobson: "Krinkle feel free to +2 before Monday 5pm PST if you want it to go into next deployment :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81114 (owner: 10Jdlrobson) [20:29:46] ^yurik 80574. will submit another ps for the interstitial reflecting the new names, too [20:30:17] * YuviPanda pokes brion with API Code Review [20:30:24] YuviPanda: i'm going to resolve then. re-open if it becomes an issue [20:30:28] tfinc: ok [20:30:56] (03CR) 10Yurik: [C: 032] Adding two messages to prepare for re-arch of WZ link rewriting. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/80574 (owner: 10Dr0ptp4kt) [20:30:58] (03Merged) 10jenkins-bot: Adding two messages to prepare for re-arch of WZ link rewriting. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/80574 (owner: 10Dr0ptp4kt) [20:31:19] tfinc: gonna grab foods :) [20:32:02] brion: is this still an issue https://bugzilla.wikimedia.org/show_bug.cgi?id=46952 ? [20:33:01] MaxSem: where best to scrub .lqt_watchlist_messages_notice - in config? [20:33:27] jdlrobson, in CSS:) [20:33:32] erg ok [20:33:59] mhurd: brion: YuviPanda: i'm moving through https://trello.com/b/2cUtayOd/mobile-app-backlog Android / iOS columns to clean them up and remove cruft. come help out if your not busy [20:34:24] tfinc: hopping on [20:34:32] * YuviPanda pokes brion for code review some more :P [20:34:34] brion: is this still an issue https://bugzilla.wikimedia.org/show_bug.cgi?id=46952 ? [20:35:18] moment [20:35:46] (03PS1) 10Jdlrobson: Bug 53138: Remove Liquid threads notification message from watchlist view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81119 [20:36:38] brion: YuviPanda is this still an issue https://bugzilla.wikimedia.org/show_bug.cgi?id=46318 ? [20:37:00] tfinc: looks like that (46952) should still be an active issue, resolvable by moving store text to the localization files and pulling from there when updating the store [20:37:14] tfinc: 46318 is still an issue, since that needs a fair bit of backend work [20:37:26]