[00:08:24] (03PS7) 10Jdlrobson: Story 834: Adding new notifications overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81133 (owner: 10Kaldari) [00:09:15] (03PS8) 10Jdlrobson: Story 834: Adding new notifications overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81133 (owner: 10Kaldari) [00:12:46] (03PS9) 10Jdlrobson: Story 834: Adding new notifications overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81133 (owner: 10Kaldari) [00:14:10] (03CR) 10Kaldari: [C: 032] Story 834: Adding new notifications overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81133 (owner: 10Kaldari) [00:15:24] (03Merged) 10jenkins-bot: Story 834: Adding new notifications overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81133 (owner: 10Kaldari) [00:19:00] :D [00:19:04] go for it jdlrobson [00:19:10] jcmish: already did [00:19:11] I'm cooking dinner so you're safe [00:19:14] we're good to go we think [00:19:25] k wanna take one more pass before I pull the logs? [00:45:01] tfinc: going to sleep for real now. hard to give up an hour of actual productivity in the morning :) night! [00:45:35] * tfinc is just going to assume that was YuviPanda_zz was talking in his sleep  [06:21:11] (03PS1) 10Mgrover: Stable Automation Tests for logged in/logged out QA:#1136 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81179 [14:08:27] * awjr waves [14:08:40] MaxSem: forgot to mention yesterday - there's a good chance i won't be around during some or all of deployment today [14:09:03] hey [14:09:12] I think it's not a problem [14:20:03] cool MaxSem [14:20:05] thanks [14:22:31] MaxSem: can you make sure to dbl check the results of https://bugzilla.wikimedia.org/show_bug.cgi?id=50967 on testwiki before pushing? [14:22:45] i am always paranoid about changes like that. [14:24:50] sure [16:42:01] (03PS5) 10Jdlrobson: Story 1073: Enable campaigns on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80503 [17:01:30] MaxSem: what happened to metadata on files on commons? https://commons.m.wikimedia.org/wiki/File:Kaselaug_-_Rabivere_maastikukaitseala.jpg [17:02:03] ? [17:02:15] it being not collapsed is a known bug [17:02:21] MaxSem: it's not showing.. [17:02:30] it's being scrubbed [17:02:49] mw_metadata class ? [17:02:58] mw-imagepage-section-metadata ? [17:03:18] Hello all, I was wondering how I can filter out certain templates from being output on Mobile Frontend [17:03:46] hmm, it should scrub only .metadata [17:04:29] anyway, today's deployment should fix it [17:05:18] MaxSem: hope so :D [17:05:29] Ulfr: add the class nomobile to the containing element [17:05:33] that should hide it on mobile mode [17:05:52] jdlrobson: Any way I can alias that to something I already applied? e.g. noprint? [17:06:23] Ulfr: this is your own mediawiki ? [17:06:33] jdlrobson: Correct [17:06:37] Ulfr: take a look at $wgMFRemovableClasses [17:06:46] you can add selectors to that for scrubbing [17:07:04] Yessss [17:07:08] $wgMFRemovableClasses['base'][] = '.noprint' would remove .noprint from the rendered output [17:07:10] still, doing this with CSS is recommended [17:07:24] Ulfr: yeh so the other way is to use MediaWiki:Mobile.css [17:07:30] and apply .noprint { display: none; } [17:07:38] the latter is preferable if you can [17:07:50] Yeah, that sounds way better. stupid load balanced frontends [17:08:04] Just wasnt' looking forward to having to let pywikibot handle it, it gets a tummy ache in the middle [17:08:44] MF and PWB are two dinosaurs, Earth is too small for them two [17:09:05] While I'm here is there any way to have an alternate mainpage for mobile? I'm going to pull my hair out of i have to magick a way to make some images mobile friendly [17:10:57]
Desktop Main page
[17:11:00] *snort* PWB is still my savior when my users change their minds every other day [17:11:17] MaxSem: Oh, sick. [17:11:36] hmm, does display: block !important override inline display:none? [17:12:00] that's a very deep question [17:12:05] Ulfr, most people ask us to stop special-casing the main page at all [17:12:26] Well most people can DIAF, my boss is particular as hell [17:14:27] e.g. I got reamed because I called our custom vector skin vector2, so I had to modify the actual vector skin so he'd calm down [17:17:43] why work for the brain-damaged?:P [17:19:26] Ulfr: the main trick to not having to special case a homepage is to use div's and classes rather than tables and inline styles [17:19:31] hey mobile team. I noticed a few bugs today. [17:19:37] ragesoss: gul[ [17:19:39] *gulp [17:19:50] impossible, we're flawless! [17:19:54] duh! [17:19:59] geocode globe shows up even if there are no coords. [17:20:17] fix: add coords [17:20:18] jdlrobson: http://www.wikidoc.org [17:20:34] I click and end up at the article [[undefined]] [17:21:20] if there are coordinates, I geta certificate warning. [17:21:43] Ulfr: looks like you have it under control :) [17:21:50] ragesoss: example url? [17:21:50] and the geohack page is totally not mobile friendly. [17:21:58] ragesoss: well that figures ;-) [17:22:18] jdlrobson: I wish :( It's all shrunk. Marching orders are for something that's readable and fat finger friendly [17:22:22] we should really replace geohack with a special page [17:22:32] https://en.m.wikipedia.org/wiki/Glenshaw%2C_Pennsylvania [17:22:41] Ulfr: mobile design is tricky.. you're familiar with media queries right? [17:22:49] coordinates on that one. [17:22:56] jdlrobson: Probably, but not necessary the name [17:22:58] https://developer.mozilla.org/en-US/docs/Web/Guide/CSS/Media_queries < Ulfr [17:23:25] mm that [17:23:32] no coordinates here: https://en.m.wikipedia.org/wiki/Chelsea_Manning [17:23:32] ragesoss: that's new - guess some template changed [17:23:56] ragesoss: if there are coordinates, I geta certificate warning. < can you elaborate? [17:24:13] also, on the latter I get no warning that page is protected. [17:24:46] ragesoss: oh that's known - MaxSem was pointing that out during wikimania [17:25:05] we need to incorporate those into the design [17:25:14] if I tap globe on that first link, invalid cert [17:25:33] somebody forgot to feed the cert monster. [17:25:35] ArticleEmblemsArticleEmblemsArticleEmblemsArticleEmblemsArticleEmblemsArticleEmblemsArticleEmblemsArticleEmblems [17:25:38] he gets stingy when he's hungry [17:25:41] geohack has an invalid certificate? [17:25:49] ragesoss: anyway easiest thing to do is hide it in Mobile.css i'll do that now [17:25:51] it shouldn't be showing [17:25:53] at lwast, happened the first time. [17:25:59] jdlrobson, toolserver is just... invalid [17:27:23] Those mediaqueries seem like something I'd use if I didn't have to make changes to what seems like 800k pages for it :( [17:27:38] I should get a small banner to indicate that I'm editing a protected page, if I'm an admin. [17:27:42] getting my users to use CSS instead of HTML style attributes was a nightmare [17:27:48] Ulfr, templates, no? [17:28:07] MaxSem: Every chapter has it's own template :( [17:28:42] Most of the content was created without someone handy to make stuff streamlined like that [17:28:47] ragesoss: geohack disabled on mobile should kick in in 5 minutes [17:28:49] every person is a harbinger of their own doom [17:28:50] so people figured out how to make something look right and copypasta [17:28:54] concur. [17:28:57] concur so hard [17:29:07] otherwise I might edit, say, Chelsea Manning without realizing it was locked and all changes require consensus. then I would get blocked by Risker. :) [17:29:14] unfortunately I'm just the tech monkey [17:33:16] jdlrobson: geohack gone now. thanks! [17:35:10] Guh. I hate mobile browsers. How do I purge on the android browser? :< [17:35:19] * Ulfr has fat fingers [17:36:17] I've been UA [17:36:52] err... using new Nexus 7 for the last few weeks. love it. [17:37:27] once my keyboard case comes, I'll never use a desktop again. [17:38:11] More power to you. I need a mouse to have anything resembling precision [17:39:13] Or really big buttons. Like 1/4th the screen big [17:39:54] that was mostly a joke. I do enjoy the nexus 7 though, and the mobile view of our sites looks better and better. [17:40:20] Don't rub it in :( [17:40:21] Jerk. [17:40:28] I need a one-tap path to talk pages, though. [17:41:06] jdlrobson^ [17:42:23] even if it just takes me to the desktop view. it's a critical thing if I'm logged in and editing. [17:42:44] * Ulfr is glad his phone came with the shockproof case. [17:43:09] * Ulfr decided to see if flinging the phone at a wall would purge the cached css [17:43:11] ragesoss: use beta :D [17:43:19] it's commiinggggg [17:43:20] v [17:43:22] very close :) [17:43:24] orly? [17:43:27] sweet [17:43:30] ragesoss: has been in there for ages [17:43:37] it's just a bit rusty and needs some more work [17:43:52] beta seems to turn off randomly for me. [17:43:56] ragesoss: looks like the geohack bug is fixed [17:44:01] (03PS1) 10MaxSem: Giving people deserved credits [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81266 [17:44:14] (03CR) 10MaxSem: [C: 032] Giving people deserved credits [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81266 (owner: 10MaxSem) [17:44:14] maybe I just cleared the cookie or something. [17:44:29] yeah, geohack is fixed. [17:45:04] (03Merged) 10jenkins-bot: Giving people deserved credits [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81266 (owner: 10MaxSem) [17:45:17] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81266 (owner: 10MaxSem) [17:45:54] jdlrobson: from a QA standpoint, should I use beta or experimental? [17:46:00] Uhh, silly question but you don't have to have the mobile domain set up to get the extension to work, right? >> [17:46:07] ragesoss: beta is more reliable [17:46:13] Ulfr, right [17:46:25] experimental usually as a ton more features but tends to be unstable sadly (mostly due to the ajax loading experiments) [17:46:32] Ulfr, do you have a frontend cache? [17:46:38] something we are working on... [17:46:48] MaxSem: You're wicked smart [17:47:03] seems like the latter sometimes has features that aren't going anywhere. I don't mind instability. [17:47:24] what was wrong with the geohack link ? [17:47:27] worked for me... [17:47:32] that's how I like my applications and my women, unstable as heck [17:47:58] MaxSem: got it in one. You're the man [17:48:11] ? [17:48:26] Squid wasn't letting me see new versions of pages [17:48:29] thedj: I got a cert warning on first tap. and it showed up on noncoded articles too, and took me to [[undefined]] on tap. [17:48:34] bypassed squid and everything's hunky dory. [17:48:44] ragesoss: link ? [17:49:04] cert errors i can't fix. [17:49:06] thedj: it's now disabled. [17:49:31] ragesoss: no, the css hides it. it's still there. so simple to test with inspector [17:49:43] https://en.m.wikipedia.org/wiki/Chelsea_Manning [17:49:46] thx [17:50:06] wait, that has a title geo ? [17:50:41] yeah, and it takes me to [[undefined]] [17:51:00] globe showed on every article. [17:51:48] oh, i removed the length check in one of the revisions. [17:54:20] Mother of pearl. For the sake of my phone is there any way to get firefox to pretend it's a mobile browser? [17:54:45] Ulfr, ModifyHeaders [17:54:53] or a bunch of similar extensions [17:55:41] MaxSem: Thanks man. [17:55:42] brb [18:00:25] jdlrobson: comments icon spins but does nothing. [18:00:53] ragesoss: you're in alpha? [18:01:24] on experimental, it shows a number before tap. that number shows through spinner, which is ug [18:01:31] ly. [18:01:41] ragesoss: told you to avoid experimental lol [18:01:51] but alpha and beta both just spin [18:01:53] * jdlrobson preferred the name here be dragons mode - was much clearer [18:02:04] beta spins when you try to read or you try to contribute? [18:02:20] when I tap the talk icon [18:02:30] ragesoss: sounds like you are caching an old page [18:02:36] try adding debug=true to the url [18:02:41] what page are you trying this on? [18:03:03] the Manning article [18:03:14] so, huge active ta [18:03:21] lk page [18:05:22] MaxSem: I actually read the documentation and useformat=mobile did the trick, but what I see on that format isn't what I see on my phone. Is that a caching thing or did I goof my config. (sorry to be a pest) [18:06:41] what's the difference? [18:07:25] MaxSem: What I currently get on my phone is the desktop view with text that isn't shrinkwrapped in stupid being readable. What mobileview gets me is something I could actually use to browse or edit even with fingers as fat as mine [18:07:55] e.g. http://www.wikidoc.org/index.php?title=Pericarditis&useformat=mobile vs http://www.wikidoc.org/index.php?title=Pericarditi [18:08:03] add an S at the end of second url [18:08:15] have you read https://www.mediawiki.org/wiki/Extension:MobileFrontend/Configuring_browser_auto-detection ? [18:08:41] (03PS2) 10Cmcmahon: Stable Automation Tests for logged in/logged out QA:#1136 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81179 (owner: 10Mgrover) [18:11:11] I read that and disregarded it because I always feel like I'm battling a kraken when trying to get squid to behave :( Guess I do need a mobile domain [18:11:24] awjr: i made small tweaks yesterday. back on it today in the afternoon. [18:11:33] groovy tfinc [18:11:36] im working on it now [18:12:08] you had a number of blanks slides that i wasn't sure about [18:13:47] tfinc ah yeah; i had left those in there to keep the sections clearly delineated [18:13:56] they don't need to stay in, but it's been helpful [18:14:11] there are so many slides it's easy to get lost [18:17:25] awjr: Take this, it will help you. [18:17:31] * Ulfr couldn't resist the reference [18:17:51] Ulfr: i think that went over my head :p [18:18:14] awjr: Old videogame reference [18:18:25] Ulfr: :( [18:18:27] er [18:18:30] that was supposed to be a :) [18:18:32] xD [18:18:43] heh [18:18:46] somebody's going into a dungeon or somesuch and they mention it being easy to get lost [18:18:51] Ulfr, you mean "It's dangerous to go alone, take this"? [18:18:59] MaxSem: That's the one! [18:19:17] * Ulfr needs to get his references straight. [18:20:32] MaxSem: Zelda, right? [18:21:14] http://img8.joyreactor.cc/pics/post/legent-of-zelda-котик-песочница-362248.jpeg [18:22:05] I would take him anywhere. Doubt he'd be terribly useful though [18:38:37] about to land at SFO - see you office folks hopefully around 1! [18:39:15] Guh. There's no handy guide written about configuing apache to bypass squid if a mobile browser is detected is there? [18:50:35] hey brion. have you looked at templating stuff like twig before? http://twig.sensiolabs.org/ [18:50:43] not much no [18:50:56] hmm, I'm going to see if I can use that with UploadWizad [18:51:09] brion: http://i3.minus.com/jbv2Hnm25PiRcV.png for the Campaign: pages. any thoughts? [18:51:52] YuviPanda: looking awesome :D [18:52:04] brion: ignore the colors, etc :) [18:52:23] one might consider showing both 'most recent' and 'top rated' photos from the campaign [18:52:31] but that's additional work cause you need a rating system ;) [18:52:44] brion: the idea is the 'top strip' is the equivalent of 'top rated' - 'featured pictures' that are mostly hand-picked [18:52:52] and below is most recent [18:53:12] excellent,t hat works [18:53:33] brion: I am guessing they should all be static for now - no carousels, no swishyness [18:53:35] or sanything [18:54:08] yeah simplest [18:54:13] we can make it awesomer later [18:54:14] :DD [18:54:18] brion: yeah :D [18:54:30] brion: can you merge the 3 patches? :D They sortof start the work on this. [18:54:33] moment [19:00:23] Oh, god. Does AMF actually require memcached? [19:00:49] * Ulfr whimpers [19:01:45] ok where was i [19:02:12] filed a support request with netgear to see if there's some way to set the hdmi output resolution on this dang miracast receiver [19:02:22] it works great on a tv but it outputs 1080p60 by default which i can't record [19:02:35] * brion stabs netgear [19:03:01] ok lemme update my local mw install and test those changesets [19:03:26] brion: use vagrant! it is what all the cool kids use now :) [19:03:45] eh i'll have to try that out sometime [19:03:59] as we add things like parsoid it'll be easier to do a VM configuration than a 'set it up on your generic host' anyway :D [19:07:57] hm [19:08:03] YuviPanda: ok so ?action=query&list=allcampaigns&format=json should show parsed or unparsed? [19:08:10] brion: parsed [19:08:19] i see lots of 'wikitext:' '{{subst:blah}}'' [19:08:25] brion: ah, so those aren't parsed [19:08:32] what is? [19:08:34] brion: since they are actually wikitext that needs to be appended [19:08:37] brion: to the uploaded file [19:08:38] ok [19:08:44] brion: anything under display: [19:08:48] brion: also the 'label' field for fields [19:08:55] brion: and after one of the other patches, description and title fields [19:10:06] YuviPanda: but… not the 'headerLabelPage' etc legacy entries that i have right? [19:10:13] so i'd have to add something to test the parsing [19:10:38] brion: everything under display: is parsed, but headerLabelPage would be parsed wrong, but that's okay since it isn't really supported. [19:10:47] heh [19:10:48] brion: just type some random wikitext into headerLabel ;) [19:10:55] YuviPanda: yeah i can confirm that works \o/ [19:11:01] happy joy [19:11:02] \o/ [19:19:10] * Ulfr grumbles. Install an extension they said. Not much configuration they said. [19:22:07] awjr_away: we may want to defer the liasion discussion till later as we'd want howie and oliver there [19:22:55] Ulfr: do you have a question about setting up MobileFrontend ? [19:23:33] tfinc: Not particularly. I just chose to ignore the bits where it said I'd need to subdomain for mobile because I use the kraken for front end caching [19:24:04] The extension works great. Modding my apache installs isn't very fun. [19:25:57] (03PS1) 10Kaldari: Some tweaks to the notifications overlay 1. Instead of resorting, just reversing notifications array 2. Smaller font for notification footer, per Vibha 3. Making sure loading spinner is actually visible when active 4. Hiding primary link - this isn't supp [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81363 [19:28:06] (03CR) 10Jdlrobson: [C: 031] "I'd +2 but I guess I can't so close to deployment ;-)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81363 (owner: 10Kaldari) [19:32:06] tfinc: You wouldn't happen to know if a mobile subdomain needs it's own vhost would you? [19:32:24] ah crap i gotta catch up with tim on architecture RFC review soon…. and now he's busy with the baby :) [19:32:33] brion: you got time! :) [19:32:38] maybe that'll push his sleep schedule off to coincide more with mine ;) [19:32:38] brion: there are a few fun ones, I thought [19:32:57] brion: hehe, yeah - look at ori-l, for instance. his sleep cycle is almost in sync with what mine should be [19:33:02] heh [19:42:55] btw, high quality extension, this is going to look awesome once I've got a few other content issues squared away :) [19:48:00] brion: I emailed that mockup to the design list, lemme see if something pops back :) [19:48:50] will do :D [19:59:12] (03PS1) 10Jdlrobson: Bug 53182: Don't show new pages editor for newly created pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81371 [20:03:11] ah what the fuck [20:03:25] looks like my recording problem may not be the resolution, but HDCP scrambling being enabled [20:03:30] on the video out from the devices [20:03:33] ARRRRRRRRRGGGHHHH [20:07:32] all right awjr_away, jdlrobson, kaldari, Maryana - we're live on testwiki, please test:) [20:07:45] scary [20:08:18] brion: I know that feel [20:08:55] on it [20:09:37] you'd think my hdmi recording widget could like show some kind of error message instead of a blank screen [20:13:14] Maryana, is Kenan in the office? [20:14:10] He's off this week MaxSem [20:14:13] ah [20:16:32] hey awjr, tested getDesktopDomain() - looks good [20:17:33] w00t! thanks MaxSem [20:17:40] thank troll success! http://imgur.com/pc53WmS [20:19:51] automation tests passed moving on to poking around [20:20:10] aha finally figured out how to use 'adb backup'… turns out it wants your *encryption password* if your phone is encrypted [20:27:44] MaxSem: Maryana jdlrobson awjr looks good to me [20:28:00] i've hit a few issues on android 2 but they seem to be on production too [20:28:16] i can't get wifi to work on the old iphone [20:28:21] yeah that's just android 2 being shitty :) [20:28:27] oh bummer [20:28:30] is it the phone? [20:28:44] i have a fix for android 2 though.. if we want to merge it. [20:29:02] sorry, i was checking in w/awjr and haven't had a chance to look at anything except echo [20:29:02] jdlrobson: that's disabling the position:fixed and letting the bottom toolbar scroll, or? [20:29:06] which looks good :) [20:29:08] for wifi not working? [20:29:09] or am i crossing bugs again :D [20:29:25] Maryana: awh is a bad influence :D [20:29:31] awjr: [20:29:32] :D [20:29:42] brion: yeh locking the viewport [20:29:52] yeah that should help a lot on old android [20:30:38] heyo [20:30:47] i'm not seeing the section-level edit button when logged out [20:31:01] I was just saying you're a bad influence on Maryana awjr [20:31:11] :D [20:31:17] oh wait, i'm looking at live wp. derp. [20:31:29] awjr has made me totally confused. i blame him! [20:31:36] oh whew Maryana I was gonna say umm I got it to work [20:31:40] haha yes blame him :D [20:32:07] if it makes you feel any better i feel totally confused too [20:32:17] (03PS1) 10Jdlrobson: Bug 53421: Lock viewport on Android 2.* [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81382 [20:32:21] ^ jcmish brion kaldari anyone care to merge? [20:32:30] * brion looking [20:33:11] jdlrobson: that test for Android 2 is lazy, it'll match someday on Android 20 ;) [20:33:28] but that's already there so won't block ;)) [20:33:39] (03CR) 10Brion VIBBER: [C: 032] Bug 53421: Lock viewport on Android 2.* [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81382 (owner: 10Jdlrobson) [20:34:53] (03Merged) 10jenkins-bot: Bug 53421: Lock viewport on Android 2.* [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81382 (owner: 10Jdlrobson) [20:35:07] * jdlrobson reminded of https://www.youtube.com/watch?v=X5rZSsHmhT4 [20:36:09] oh I'm so sad [20:36:27] I could have gone my how life not seeing that thanks jdlrobson [20:36:33] no it'll be stuck in my mind [20:36:38] *now [20:36:52] :) [20:36:59] * jdlrobson gives up on the old iphone [20:38:57] MaxSem: Notifications seem to be working [20:39:04] woo [20:41:38] everything looks great to me! [20:42:12] jdlrobson, deployed that change [20:42:54] MaxSem: sweet [20:43:02] there is actually one slight improvement we can make as well.. [20:44:44] (03PS1) 10Jdlrobson: Support real position fixed on Android 2. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81386 [20:45:03] ^ brion jcmish can we merge this too? [20:45:47] it's much much smoother and according to juliusz android 2 users are a big chunk of our audience.. [20:46:08] If brion is cool I am since I don't know what you're actually doing :D [20:46:11] (03CR) 10Brion VIBBER: [C: 032] "Note that this _might_ fail on really old Android 2.0 devices? But there should be very few out there still, it's mostly 2.3 and a smidge " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81386 (owner: 10Jdlrobson) [20:46:24] sweet [20:46:27] jcmish: it fixes a fix for android 2.x browser :) [20:46:31] (03Merged) 10jenkins-bot: Support real position fixed on Android 2. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81386 (owner: 10Jdlrobson) [20:46:37] i think everything else looks good [20:46:52] no I know that brion just don't understand whether it is right :D [20:47:13] cool MaxSem I say we move on to scapping? [20:47:21] thanks are being logged [20:47:25] \o/ [20:47:26] do we want to test ^^^ [20:47:28] ? [20:47:56] yes I meant after testing the Android fix sorry :D [20:48:22] jdlrobson: can you validate since you have the device? [20:48:38] scap [20:49:15] jcmish: validated! [20:50:15] danke [20:50:22] make it so MaxSem :D [20:52:11] MaxSem: jdlrobson Maryana I need to run and pick up my son from school back in a bit [20:52:22] kk [20:52:38] deployed [20:53:35] Thar be broken links in yer documentation! [20:53:38] http://www.mediawiki.org/wiki/Extension:MobileFrontend/Configuring_browser_auto-detection [20:53:51] The varnish link and includes link are both busted, and I don't know what an x-device header is! [20:53:52] kaldari: https://mingle.corp.wikimedia.org/projects/mobile/cards/1140 [20:54:00] rabblerabblerabble [20:54:31] MaxSem: deployed to en.wiki? [20:54:38] nooooo [20:54:46] ahh ok :) [20:54:47] did I ever declare a scap?:P [20:54:48] was going to say.. :) [20:54:55] MaxSem: well scatman hasn't played so no [20:54:56] did it ever end in 2 minutes?;) [20:55:33] fooood [20:56:40] I'm not actually mad :( [21:00:52] Ulfr: good to have you around - i always like seeing a new face in the mobile channel. :-) [21:01:12] jdlrobson: Yeah, this project is legit! [21:01:19] scapping... [21:01:22] I just hate futzing with my apache configs [21:01:40] hrm, X-Device... [21:01:52] if you're running trunk, you need X-WAP [21:02:02] Ulfr: so is wikidoc the only mediawiki instance you are working on at the moment? [21:02:32] jdlrobson: Uh, install? yes. Domain? I wish. [21:03:22] I've got several languages set up with subdomain based configs [21:06:55] Apache directs to directories based on subdomain, and I've got english and m pointed at the same directory, and it directs my browser correctly when I try to go, but when I access it from my phone the same thing happens [21:08:01] Although I may need to change the mobile domain to inactive until I figure out why my frontends are getting lit up like a christmas tree [21:09:55] brion: mhurd: YuviPanda: how are you guys doing on your current backlog? i'm hoping to have the next one ready to kick off next week. will you guys have enough work to wait till then ? [21:10:22] there's enough for me there, yeah. [21:10:34] tfinc: checking trello... [21:11:25] tfinc: oh yeah we'll be full up :) [21:11:42] brion: any progress on the license detection stuff? [21:11:42] tfinc: yes between auto layout and swipe-to-delete on categories i'll be plenty busy 'till then [21:11:46] man this backup is taking forevar [21:12:10] YuviPanda: detection not in yet, just the selection on upload [21:13:04] brion: can you move the stuff you're going to work on to the 'doing' column and assign to yourself? [21:13:08] brion: in https://trello.com/b/XkdTvW0Z/mobile-app-sprint-15 [21:13:12] yeah [21:13:24] tfinc: wait, are we still in sprint 14? or is it 15 yet? [21:13:29] 14 [21:13:42] brion: https://trello.com/b/DzbU1dzm/mobile-app-sprint-14 then [21:13:43] not 15 [21:13:58] YuviPanda: i haven't finished 15 yet [21:14:02] tfinc: ok [21:14:13] brion: sorry, not 15, 14 [21:15:15] wops [21:15:42] agh - i just moved a couple cards to 15 too... [21:16:57] oh shit.... DOMXPath::query() [domxpath.query]: Invalid expression in /usr/local/apache/common-local/php-1.22wmf13/extensions/MobileFrontend/includes/formatters/HtmlFormatter.php on line 216 [21:17:17] jdlrobson: Why did you ask? [21:17:29] awjr_away, kaldari ^^^ [21:17:39] this is serious... [21:17:48] Ulfr: i was just curious if you'd be sticking around - it's always nice to have fresh blood in the project :) [21:18:11] jdlrobson: I'd be happy to stupid-test the extension once my users can get at it ;P [21:18:46] MaxSem: you always worry me when you say oh shit :) [21:18:46] I just haven't the foggiest what sort of headers the extension needs or how to make it use the mobile url template [21:18:51] is this related to the config change MaxSem ? [21:19:04] Ulfr: we can help you with that :) [21:19:07] investigating [21:19:56] MaxSem: how'd u get that? [21:20:10] look at prod error log [21:20:34] jdlrobson: Well for now I'd settle for knowing if I'm getting DDoS'd exceptionally hard or if having rewrites based on browser headers would spike CPU usage [21:23:43] Oh god. [21:32:12] scap complete, still investigating the formatter issue [21:34:02] okay, it's [21:34:02] foreach( array_keys( $wgMFRemovableClasses ) as $class ) { [21:34:02] $wgMFRemovableClasses[$class] = array_merge( [21:34:02] $wgMFRemovableClasses[$class], [21:34:02] $wmgMFRemovableClasses[$class] [21:34:02] ); [21:34:02] } [21:38:12] Fuck [21:38:42] My internet just died [21:38:58] uhoh [21:39:54] kaldari, thebproblem is likely in mobile.php [21:42:08] awjr shit hit fan [21:42:16] MaxSem|android: what happened? [21:42:30] do you need me to do anything? [21:42:43] Error log is full with our bugs and my connection is dead [21:43:18] Likely tue problem is in mobile.php [21:43:18] kaldari: did we get the blog post up about mobile echo ? [21:43:54] No, spent all of yesterday scrambling to get the overlay version ready [21:44:35] tfinc: plus the overlay version has some rough edges so might want to wait 1 more deployment cycle before blogging about it, IMO [21:45:08] kaldari: will the blog post change due to the overlap work ? [21:45:13] MaxSem|android: where can i see the logs [21:45:23] fatalmonitor isn't working :-| [21:45:31] or… do i need to look on fenari rather than tin? [21:45:34] it's been a while.. [21:45:39] fatalmonitor on fenari [21:46:20] kk [21:46:21] ah yeah [21:46:29] tfinc: no, I guess we could go ahead and blog about the current version as is [21:46:35] great [21:47:06] hopefully we'll have the overlay version up as the default very soon though [21:47:20] it doesn't like $wmgMFRemovableClasses [21:47:45] Wmg or wg? [21:48:13] error says arg 2 which would be wmg [21:48:42] InitialiseSettings.php is loaded before mobile.php, correct? [21:49:20] Yep [21:49:45] And other vars are used around that place [21:50:32] Dammit, there was no that error when we tested on testwiki [21:56:24] MaxSem|android: I'm going to touch and resync the config-file real quick [21:56:53] MaxSem|android: kaldari's theory which i think is a sound one is that config files and/or code are out of sync somewhere on the cluster [21:57:04] that seems plausible to me given the errors im seeing in the fatalmonitor [21:57:06] Grrrd [21:59:21] :-/ [22:05:26] MaxSem|android: eek $this->remove( $wgMFRemovableClasses ); [22:05:31] MaxSem|android: are you able to look at code? [22:05:42] what jon said :p [22:05:43] going to try syncing the code for MobileFrontend in wmf13 [22:05:55] line 30, ExtractFormatter [22:06:18] Fuck [22:06:45] MaxSem|android: should that be commented out? [22:06:53] or … [22:06:54] ? [22:07:41] (probably unrelated) but something is very effed up w/login and/or centralauth right now [22:07:49] on desktop [22:07:52] ['extracts'] [22:08:36] that is already present on line 26, MaxSem|android [22:08:38] Wait [22:08:48] MaxSem|android: want a pastebin? [22:12:39] MaxSem|android: http://pastebin.com/Sd3u7W0K [22:12:44] that's what's currently deployed/in master [22:12:58] so $this->remove( $wgMFRemovableClasses ); will pass an array of arrays rather than an array of strings to the remove function [22:15:13] parseSelector then ends up getting passed an array instead of a string as a selector [22:15:21] strpos will then get run on it [22:15:24] BOOM [22:17:09] http://www.youtube.com/watch?v=O_HyZ5aW76c&t=67 [22:17:12] ^ Maryana [22:17:27] ruh roh [22:17:32] what are we doing live? [22:19:51] I'm back [22:23:28] Maryana: trying a fix [22:23:54] MaxSem|android: kaldari commented out line 30 from ExtratsFormatter.php (http://pastebin.com/Sd3u7W0K) in prod and errors appear to be dropping [22:24:18] Maryana: im not sure anyone's investigated the login issue yet [22:24:21] * Maryana crosses fingers [22:24:21] Weeee [22:24:31] awjr: superm401 raised a bug [22:24:35] hopefully somebody's on it [22:24:40] Maryana: linky? [22:24:49] https://bugzilla.wikimedia.org/show_bug.cgi?id=53424 [22:24:54] Login issues? [22:25:08] ahttp://en.wikipedia.org/w/api.php?format=xml&action=query&pageids=4422&prop=extracts&exsentences=1 [22:25:51] yeah, centralauth is refusing to let go of login session cookies, titanic-style, maxsem [22:26:18] MaxSem|android: can you confirm about ExtractFormatter.php? [22:27:01] http://geekologie.com/2013/06/28/titanic-head-explosion.gif [22:27:51] Jons link looks okay [22:29:36] (03PS1) 10awjrichards: Remove errant remove call that appears to be causing PHP warnings in prod [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81416 [22:29:49] MaxSem|android: can you look at that patchset real quick and confirm that that looks sane? ^ [22:31:14] awjr lgtm [22:32:03] (03CR) 10Kaldari: [C: 032] Remove errant remove call that appears to be causing PHP warnings in prod [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81416 (owner: 10awjrichards) [22:32:23] (03Merged) 10jenkins-bot: Remove errant remove call that appears to be causing PHP warnings in prod [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81416 (owner: 10awjrichards) [22:33:33] thanks MaxSem|android [22:33:54] ok we're almost done; kaldari is going to get the patch in the deployment branches and pushed out everywhere [22:34:01] Maryana, jcmish ^ [22:34:13] thanks, everybody! [22:34:16] <3 [22:34:17] yup [22:34:19] saw it [22:34:40] :D [22:35:50] those were some ninja like skills! [22:36:55] Maryana and chrismcmahon why wouldn't we see the central auth issue on betalabs? [22:37:02] jcmish: hellz yeah, all kaldari and jdlrobson :) [22:37:15] :D [22:37:30] jcmish, i'm not sure.. [22:39:39] Maryana: jcmish beta has had a number of auth experiments in recent times. I'm not sure what the current status is, but the lack of a valid cert for any labs domain is an ongoing headache. solution might be ~2 weeks out we hope [22:40:36] ah cool chrismcmahon bunmer though since so many of us are affected by it [22:42:52] Maryana: https://twitter.com/galambalazs/status/371353263440158720 < infobox fuel [22:43:28] "Sorry, that page doesn’t exist!" [22:43:43] you're not sorry, twitter.. [23:11:18] awjr, greg-g, MaxSem|android: all done with bugfix deployment :) [23:11:27] heyo! thanks kaldari :D [23:11:27] didn't take as long as I thought [23:11:46] Cheers kaldari [23:12:12] kaldari, MaxSem|android those final errors appear to be disappearing [23:12:28] Woohoo [23:13:24] kaldari: rock [23:13:54] thanks to jdlrobson for figuring out the fix [23:14:25] np [23:14:51] Maryana: so basically that tweet was moaning about how there were loads of links on this article before the definition: https://en.m.wikipedia.org/wiki/Dunning-Kruger_effect [23:15:20] we should just scrub that template it's not useful on mobile [23:15:25] or collapse it [23:15:27] oh god, the psychology template [23:15:28] yeah [23:16:12] jdlrobson, Maryana: that template should probably just be assigned the navbox class [23:16:31] I'll make sure it's set up correctly [23:16:34] * jdlrobson tempted to add no mobile class [23:17:49] Dont [23:18:25] jdlrobson, do you have any favorite articles edited via mobile, off the top of your head? [23:18:28] not joke ones [23:18:41] MaxSem|android: whyyyyyy [23:19:08] Maryana, jdlrobson: hmm, looks like we allow navboxes in mobile [23:19:17] We need a more systematic solution [23:19:19] Maryana: not that i can think of [23:19:26] MaxSem|android: this is an intermediate solution [23:19:38] it's an action that encourages template designers to think about mobile [23:26:51] This particular case is not design but placement [23:28:04] Maryana: http://imgur.com/9WgCkga [23:28:16] OuKB|android: they are all badly designed though [23:28:30] we probably need to do something like the cleanup template strategt [23:31:58] jdlrobson: https://bugzilla.wikimedia.org/show_bug.cgi?id=53437 [23:47:56] thedj: i'm seeing #li-coordinates show up on mobile again :( [23:48:07] thedj: e.g. https://en.m.wikipedia.org/wiki/Saskatchewan [23:48:20] thedj: any idea what's going on? [23:48:26] you seemed to have fixed it earlier :( [23:48:56] ^ Maryana [23:51:50] thedj: for when you get back temporary fix >https://en.m.wikipedia.org/wiki/Special:MobileDiff/570464813...570466166