[00:00:01] <kaldari>	 Yeah, it works fine without the raw=true
[00:20:25] <grrrit-wm>	 (03PS4) 10Jdlrobson: Hygiene: Complete merging of special nearby code with nearby pages code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80687 
[00:21:26] <grrrit-wm>	 (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80687 (owner: 10Jdlrobson)
[02:25:36] <grrrit-wm>	 (03PS13) 10Kaldari: Various improvements to mobile notifications... [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 
[02:27:12] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Various improvements to mobile notifications... [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 (owner: 10Kaldari)
[02:32:06] <grrrit-wm>	 (03PS14) 10Kaldari: Various improvements to mobile notifications... [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 
[02:32:31] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Various improvements to mobile notifications... [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 (owner: 10Kaldari)
[02:33:59] <grrrit-wm>	 (03PS15) 10Kaldari: Various improvements to mobile notifications... [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 
[09:05:39] <grrrit-wm>	 (03PS1) 10MaxSem: No need for raw resources now [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82810 
[09:32:51] <pragunbhutani>	 MaxSem: there?
[09:33:00] <MaxSem>	 yup
[09:33:23] <pragunbhutani>	 Hi, I'm working on a Mobile Skin for Wikidata
[09:33:55] <pragunbhutani>	 I need a little help with making the skin responsive and Jon told me I should ask you for help while he's away
[09:34:03] <pragunbhutani>	 let me know when you have a few minutes please?
[09:34:08] <MaxSem>	 now
[09:34:15] <MaxSem>	 but I'm a PHP-only guy
[09:34:32] <pragunbhutani>	 MaxSem: ah okay, this involves css
[09:56:40] <Silke_WMDE>	 Hi all, I tried the Wikimedia Commons Apps from fdroid. While the Google Play Store one works, I can't authenticate with that one. I was wondering how to help debug this as a non-coder. Any hints? 
[10:28:56] <MaxSem>	 Silke_WMDE, f-droid is a garbage pit that hosts random outdated apckages, don't use it
[10:31:26] <MaxSem>	 also, they build the apps themselves we can have no idea what they might've screwed
[13:16:33] <pragunbhutani>	 MaxSem: In the skin that I've made, if I click on the 'Mobile View' toggle at the bottom, it does switch to mobile view
[13:16:44] <pragunbhutani>	 but the toggle does not change to show 'Desktop View'
[13:16:50] <pragunbhutani>	 any idea why that may be happening?
[13:17:08] <MaxSem>	 skin problem?
[13:18:27] <pragunbhutani>	 yes but as far as I can tell, I've not even touched the footer
[13:18:52] <pragunbhutani>	 I'm using the same footer that MobileFrontend provides
[13:19:38] <MaxSem>	 where's your code once again?
[13:23:35] <pragunbhutani>	 https://github.com/pragunbhutani/WikibaseMobile
[13:23:51] <pragunbhutani>	 if you'd like to see the problem in action, check this out http://wikidata-mobile-tester.instance-proxy.wmflabs.org/w/index.php?title=Main_Page&mobileaction=toggle_view_desktop
[13:25:18] <MaxSem>	 because you're inheriting from minerva, which is a desktop skin;)
[13:25:53] <pragunbhutani>	 ah okay, so I should change that to SkinMobile?
[13:26:23] <MaxSem>	 depends on what you need, really
[13:26:53] <pragunbhutani>	 I need a mobile skin that extends the mobile skin in MF actually
[13:26:57] <pragunbhutani>	 for Wikidata
[13:27:07] <MaxSem>	 I asked it during your application phase: why a new skin needed when the problem is with wikibase's output, not chrome?
[13:30:01] <pragunbhutani>	 Because I think we'll need a new skin to accommodate the different kind of data elements that Wikibase has
[13:30:40] <pragunbhutani>	 as far as I understand, the way Wikibase handles its output is not very good as of now and changing that is not going to be very easy
[13:30:51] <MaxSem>	 so change wikibase
[13:31:17] <pragunbhutani>	 I have made some changes to it in the sense that I've factored the class that prints claim html out of wikibase
[13:33:31] <pragunbhutani>	 I'm not sure if changing Wikibase is a practical option as of now
[13:38:14] <grrrit-wm>	 (03PS1) 10Orsagi: settings initial implementation [apps/android/translate] - 10https://gerrit.wikimedia.org/r/82824 
[17:05:56] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Fix spaces after references [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81507 (owner: 10MaxSem)
[17:06:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix spaces after references [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81507 (owner: 10MaxSem)
[17:06:59] <awjr>	 jdlrobson: you are alive!
[17:17:27] <jdlrobson_>	 awjr: yup yup :D
[17:17:33] <awjr>	 \o/
[17:17:55] <awjr>	 jdlrobson_: im sure you had a terrible time?
[17:21:14] <jdlrobson>	 awjr: absolutely terrible. worst burn EVER
[17:22:10] <awjr>	 jdlrobson: yeah, that's how i felt afterwards too. oh well, only one week wasted
[17:22:41] <jdlrobson>	 yeh luckily i only went for 5 days ;-)
[17:22:45] <awjr>	 hahaha
[17:22:53] <jdlrobson>	 i'm going to be staying up for 10 nights to get my time back
[17:23:00] <awjr>	 lol
[17:23:02] <awjr>	 how did you like sierra hot springs after?
[17:23:12] <awjr>	 that place is AWESOME but i imagine it was packed
[17:42:45] <jdlrobson>	 awjr: it was pretty damn cool yeh
[17:42:51] <jdlrobson>	 not too packed at 5 in the morning.. :)
[17:42:55] <awjr>	 :D
[17:43:20] <jdlrobson>	 awjr: any idea if we scrub portal-column-left-wide classes on mediawiki.org ?
[17:43:27] <awjr>	 nope
[17:43:28] <jdlrobson>	 i just applied one and it disappeared
[17:43:30] <awjr>	 i mean, no idea
[17:59:46] <grrrit-wm>	 (03CR) 10MaxSem: "AAAAAAAAA!!!" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/68581 (owner: 10MaxSem)
[18:19:35] <jdlrobson>	 haha toro went down
[18:24:35] <tfinc>	 jdlrobson: works for me 
[18:25:25] <tfinc>	 Maryana: heads up https://bugzilla.wikimedia.org/show_bug.cgi?id=53818 for flow
[18:25:39] <tfinc>	 let me know if you guys need any more context
[18:25:51] <Maryana>	 woo! and that's why we demo :)
[18:26:58] <tfinc>	 yup. having a demo makes it feel real and gives everyone something tangible to interact with
[18:27:15] <tfinc>	 i'm glad this is one of the things that came out of the agile training 
[18:28:39] <jdlrobson>	 MaxSem: you aware of this issue - https://bugzilla.wikimedia.org/show_bug.cgi?id=35215
[18:28:54] <MaxSem>	 yup
[18:28:56] <jdlrobson>	 CentralNotice is causing insecure warnings on quite a few browsers on the mobile site because of it :(
[18:29:09] <MaxSem>	 it'll be possible to fix ince we move off squid
[18:49:15] <Maryana>	 jdlrobson: the privacy policy looks really bad on mobile :(
[18:49:22] <Maryana>	 you should raise that in the q&a
[18:49:29] <jdlrobson>	 Maryana: yeh michelle has already emailed me about it
[18:49:33] <jdlrobson>	 we are sorting it out today
[18:49:39] <jdlrobson>	 i should point it out
[18:49:40] <Maryana>	 oh, good!
[18:49:41] <Maryana>	 yay!
[18:49:42] <tfinc>	 YuviPanda: how is you sleep schedule today? i'm looking at the app story prioritization and thinking that lunch will run right into it
[18:49:58] <jdlrobson>	 actually i'll let someone else point it out ;-)
[18:50:02] <jdlrobson>	 it will be fixed soon
[18:50:05] <jdlrobson>	 no one will notice
[18:50:24] <YuviPanda>	 tfinc: I woke up at 9pm, but want to go to sleep at something like 3am or so, so I can wake up early tomorrow (at least 1pm!) and get some dollars / prep for travel.
[18:50:45] * tfinc  does the time zone math in his head 

[18:51:06] <Maryana>	 jdlrobson: aw, somebody pointed that out on the talk page :)
[18:51:08] <Maryana>	 mobile first!
[18:52:12] <tfinc>	 ok, so you would still be up if i moved it to 1. lets see when metrics finishes 
[18:52:28] <YuviPanda>	 haha!
[18:52:29] <YuviPanda>	 ok
[19:05:29] <grrrit-wm>	 (03PS2) 10Jdlrobson: No need for raw resources now [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82810 (owner: 10MaxSem)
[19:05:35] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] No need for raw resources now [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82810 (owner: 10MaxSem)
[19:06:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: No need for raw resources now [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82810 (owner: 10MaxSem)
[19:10:32] <jdlrobson>	 MaxSem: care to comment? https://bugzilla.wikimedia.org/show_bug.cgi?id=51586
[19:11:00] <MaxSem>	 jdlrobson, https://gerrit.wikimedia.org/r/81580
[19:11:02] <tfinc>	 brion: mhurd: how much time do you guys need for lunch post metrics? its 12:10 and we have a our story prioritization session @ 12:30 
[19:11:21] <jdlrobson>	 MaxSem: hehe i'll reference the bug in the summary then
[19:11:39] <grrrit-wm>	 (03PS2) 10Jdlrobson: Provide information about LQT status of a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81580 (owner: 10MaxSem)
[19:11:44] <MaxSem>	 jdlrobson, but it's only a half of it, JS should handle this data
[19:11:57] <jdlrobson>	 True but it's still related :)
[19:12:09] <MaxSem>	 tfinc, 12:30? it's at 1 in my calendar
[19:14:29] <grrrit-wm>	 (03PS4) 10Jdlrobson: optipng -o7 "$png" && advpng -z -4 "$png" && advdef -z -4 "$png" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82105 (owner: 10MaxSem)
[19:17:50] <tfinc>	 i'm going to move it to 1
[19:17:57] <tfinc>	 MaxSem: thats the mobile web . i was talking about apps
[19:17:58] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] Provide information about LQT status of a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81580 (owner: 10MaxSem)
[19:18:09] <MaxSem>	 ahhh
[19:21:06] <YuviPanda>	 tfinc: you can push that back another 30 mins too if that will make your lunch less hurried
[19:28:22] <tfinc>	 1 is fine
[19:28:38] <brion>	 1 works for me :)
[19:30:56] <YuviPanda>	 swell then
[19:31:10] <YuviPanda>	 brion: btw, deployed :) https://test.wikipedia.org/wiki/Campaign:wlm-pl
[19:31:17] <brion>	 \o/
[19:31:20] <YuviPanda>	 brion: and Romaine was happy with the masscamps tool
[19:31:20] <brion>	 awesome
[19:31:39] <YuviPanda>	 brion: and I'm going to notify Village Pump on Commons now
[19:31:50] <brion>	 hm it looks like some styles are missing
[19:31:59] <brion>	 'create an account and upload' looks like plain text, not a button
[19:32:06] <YuviPanda>	 brion: it *just* got deployed, and that happened to me the first time
[19:32:07] * brion  blames testwiki

[19:32:08] <YuviPanda>	 do a hard refresh?
[19:32:32] <brion>	 hard refresh doesn't help, nor does logging in
[19:32:46] <brion>	 nor does switching browsers
[19:32:55] <brion>	 same problem on login page, so it's not just campaign
[19:32:56] <YuviPanda>	 brion: do a purge?
[19:32:58] <YuviPanda>	 ah
[19:33:00] <brion>	 purge what?
[19:33:09] <YuviPanda>	 nevermind, if it is there on login too
[19:33:15] <brion>	 yeah
[19:33:22] <YuviPanda>	 brion: that's an mwui regression?
[19:33:44] <brion>	 sounds like
[19:43:06] <tfinc>	 sonuva. the only room with av open 1-2 is R33 and its wired connections dont work
[19:59:10] <tfinc>	 hangout link for app story prioritization https://plus.google.com/hangouts/_/7eecbde8f51de1c6bbb580660c6d48c525ab5ba1?hl=en .. the one in the calendar invite doesn't work
[19:59:16] <YuviPanda>	 brrr
[20:01:36] <tfinc>	 brion: where are you at ?
[20:01:48] <brion>	 hey just filing a bug
[20:01:51] <brion>	 lemme join the hangout
[20:02:23] <tfinc>	 thanks brion
[20:02:33] <awjr>	 Maryana, jdlrobson, jgonera etc - story time!
[20:02:49] <jgonera>	 awjr, coming
[20:03:28] <jdlrobson>	 awjr: yeh we're still trying to work out how to setup this room
[20:03:38] <awjr>	 !
[20:03:48] <awjr>	 i thought r37 was supposed to be all ready to go :(
[20:05:03] <jdlrobson>	 arthur we need you to mime
[20:15:27] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] "<3" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82487 (owner: 10JGonera)
[20:15:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add M.tapEvent (temporarily) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82487 (owner: 10JGonera)
[20:40:46] <awjr>	 jdlrobson: http://etherpad.wikimedia.org/p/mobilesprintname
[20:41:32] <awjr>	 kenanwang: http://etherpad.wikimedia.org/p/mobilesprintname
[20:46:14] <jcmish_lunch>	 picking up the munchkin back in a bit
[21:03:16] <pragunbhutani>	 hello jdlrobson 
[21:03:58] <jdlrobson>	 hey pragunbhutani what's up?
[21:07:36] <pragunbhutani>	 jdlrobson: hey!
[21:07:43] <pragunbhutani>	 sorry, I was out late
[21:07:51] <pragunbhutani>	 so far, I've managed to do this
[21:07:52] <pragunbhutani>	 http://wikidata-mobile-tester.instance-proxy.wmflabs.org/wiki/Main_Page
[21:08:39] <jdlrobson>	 cool so what do you need help with pragunbhutani 
[21:09:43] <pragunbhutani>	 jdlrobson: first of all, there's the mobile view/desktop view toggle at the bottom
[21:10:16] <pragunbhutani>	 it stays stuck at 'mobile view'
[21:10:19] <jdlrobson>	 so this is because you are extending a desktop skin
[21:10:29] <jdlrobson>	 you could try extend SkinMobile instead of extend SkinMinerva
[21:10:52] <jdlrobson>	 alternatively you could submit a patch to MobileFrontend to account for that
[21:11:53] <pragunbhutani>	 jdlrobson: okay if I extend SkinMobile instead of SkinMinerva, do I also need to change the template I'm extending?
[21:14:31] <YuviPanda>	 mhurd: btw, http://blue-dragon.wmflabs.org/wiki/Campaign:show-off-campaigns is the desktop campaign stuff I've been doing
[21:14:36] <YuviPanda>	 if you haven't had a chance to look yet
[21:15:37] <mhurd>	 YuviPanda: yes! good stuff!
[21:17:02] <jdlrobson>	 pragunbhutani: you shouldn't need to no
[21:17:08] <jdlrobson>	 pragunbhutani: try it and see :)
[21:17:40] <pragunbhutani>	 jdlrobson: giving it a spin :)
[21:19:42] <jdlrobson>	 pragunbhutani: how long are you sticking around for? i was just about to go get some fresh air
[21:19:58] <pragunbhutani>	 jdlrobson: about an hour
[21:20:05] <pragunbhutani>	 or a little more if you'll be around after that?
[21:20:10] <jdlrobson>	 pragunbhutani: is there any other problems you're running into?
[21:20:13] <jdlrobson>	 anything urgent?
[21:20:32] <pragunbhutani>	 Not problems really, but some things that I wanted to get your opinion on
[21:20:48] <pragunbhutani>	 and help with including scripts, yes
[21:23:43] <jdlrobson>	 what's the problem with including scripts?
[21:23:58] <pragunbhutani>	 jdlrobson: how do I do it? :p
[21:23:58] <jdlrobson>	 pragunbhutani: have you defined modules as suggested?
[21:24:06] <jdlrobson>	 (in the gist i gave you)
[21:26:01] <pragunbhutani>	 jdlrobson: yeah I did those for the stylesheet
[21:26:06] <pragunbhutani>	 *stylesheets
[21:26:06] <jdlrobson>	 so are the styles adding?
[21:26:13] <pragunbhutani>	 yes they are
[21:26:19] <jdlrobson>	 so what's the problem with the scripts
[21:26:23] <pragunbhutani>	 although, right now when I just switched to SkinMobile
[21:26:29] <pragunbhutani>	 the css isn't there
[21:26:53] <jdlrobson>	 pragunbhutani: where are you attaching the css module?
[21:26:54] <jdlrobson>	 in initPage
[21:27:24] <pragunbhutani>	 public function setupSkinUserCss( OutputPage $out ) {
[21:27:30] <pragunbhutani>	 oh should that be in initPage?
[21:29:51] <pragunbhutani>	 nope, didn't help
[21:37:13] <jdlrobson>	 use initPage
[21:37:33] <jdlrobson>	 did you set 'targets' => 'mobile' on the module pragunbhutani ?
[21:37:40] <jdlrobson>	 pragunbhutani: any code i can look at?
[21:37:56] <pragunbhutani>	 jdlrobson: ah no I did not do that!
[21:38:01] <pragunbhutani>	 yes, one second
[21:38:11] <pragunbhutani>	 https://github.com/pragunbhutani/WikibaseMobile
[21:38:52] <jdlrobson>	 $wgResourceModules['skins.WikibaseMobile'] = array( you need to set 'targets'=>'mobile'
[21:38:54] <jdlrobson>	 that's why
[21:39:14] <pragunbhutani>	 jdlrobson: for each of the stylesheets?
[21:40:05] <pragunbhutani>	 or instead of 'media'=>'screen'
[21:42:33] <pragunbhutani>	 jdlrobson: ah, got it now :D
[21:42:37] <jdlrobson>	 if any module is not marked as being mobile enabled it will not load on mobile
[21:43:54] <pragunbhutani>	 jdlrobson: okay now, how about the scripts?
[21:44:15] <jdlrobson>	 the same
[21:44:21] <jdlrobson>	 just instead of styles
[21:44:31] <jdlrobson>	 use scripts
[21:44:40] <jdlrobson>	 and instead of doing addModuleStyles use addModules
[21:45:29] <pragunbhutani>	 okay, awesome
[21:45:37] <pragunbhutani>	 jdlrobson: so then I can play around with this for now
[21:45:46] <jdlrobson>	 pragunbhutani: great. anything else you need?
[21:46:02] <pragunbhutani>	 other than this, I just wanted to discuss how you think the layout should be for different widths
[21:46:09] <pragunbhutani>	 and how the different views should work together
[21:46:26] <pragunbhutani>	 but that can wait for a day
[21:46:35] <pragunbhutani>	 now that I can add the scripts, I can play around with those tonight
[21:49:59] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Don't add styles in two places [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83018 
[21:50:18] <jdlrobson>	 pragunbhutani: ok
[21:50:55] <jdlrobson>	 pragunbhutani: if i was you i'd just worry about tablets 768px and 320px - use % widths everywhere
[21:51:02] <jdlrobson>	 brb i need to pop out
[21:51:19] <pragunbhutani>	 jdlrobson: okay, I'll rework with those in mind
[21:58:22] <MaxSem>	 awjr & kaldari, can you please take a look at https://www.mediawiki.org/wiki/Requests_for_comment/DataStore and tell me what do you think about it?
[21:59:24] <kaldari>	 sure
[22:01:50] <kaldari>	 MaxSem: isn't it possible to configure Redis to be persistant?
[22:02:43] <MaxSem>	 it is. hoewever we currently support it for specialized cases like BagOStuff and JobQueue
[22:03:18] <MaxSem>	 kaldari, ^
[22:03:35] <kaldari>	 Might want to at least mention that in the RfC
[22:04:39] <kaldari>	 and I gues currently mediaWiki only supports using redis for caching-type applications
[22:06:33] <kaldari>	 you could just list it as a possible back-end
[22:09:17] <kaldari>	 MaxSem: Looks good to me. Seems like a useful proposal.
[22:09:44] <grrrit-wm>	 (03PS7) 10JGonera: Add media viewer [alpha] [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81879 
[22:10:05] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add media viewer [alpha] [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81879 (owner: 10JGonera)
[22:10:32] <grrrit-wm>	 (03CR) 10JGonera: "I think I addressed all the remaining issues. Also, check how it behaves when the overlay is open and you rotate the phone." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81879 (owner: 10JGonera)
[22:11:04] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81879 (owner: 10JGonera)
[22:13:10] <grrrit-wm>	 (03PS8) 10JGonera: Add media viewer [alpha] [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81879 
[22:14:51] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81879 (owner: 10JGonera)
[22:15:33] <grrrit-wm>	 (03PS1) 10JGonera: Add "es3" option to our jshint config [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83024 
[22:16:39] <grrrit-wm>	 (03CR) 10JGonera: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82764 (owner: 10JGonera)
[22:17:57] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add "es3" option to our jshint config [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83024 (owner: 10JGonera)
[22:18:12] <jgonera>	 jdlrobson, can I ask you for a quick sanity check in https://gerrit.wikimedia.org/r/#/c/82759/ ?
[22:18:41] <jgonera>	 jdlrobson, kaldari, can you review https://gerrit.wikimedia.org/r/#/c/82556/ ? this changes some things you worked on before
[22:22:40] <grrrit-wm>	 (03CR) 10JGonera: [C: 031] Update pre-commit hook to use optipng not pngcrush [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82105 (owner: 10MaxSem)
[22:24:30] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83018 (owner: 10Jdlrobson)
[22:27:32] <grrrit-wm>	 (03PS2) 10JGonera: Do a PST during preview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82529 (owner: 10MaxSem)
[22:27:33] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Do a PST during preview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82529 (owner: 10MaxSem)
[22:27:56] <grrrit-wm>	 (03PS3) 10JGonera: Do a PST during preview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82529 (owner: 10MaxSem)
[22:28:19] <grrrit-wm>	 (03CR) 10JGonera: [C: 032] Do a PST during preview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82529 (owner: 10MaxSem)
[22:28:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Do a PST during preview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82529 (owner: 10MaxSem)
[22:44:54] <awjr>	 MaxSem: it generally looks good to me! the RFC i mean
[22:45:17] <awjr>	 MaxSem: when you say 'Keys shouldn't be mangled' do you mean keys should be immutable?
[22:45:36] <awjr>	 or that they should follow some consistent pattern?
[22:46:02] <MaxSem>	 awjr, I mean that for example memcached uses key hashes
[22:47:24] <awjr>	 ah but you'd prefer them to be readable, sortable, etc/
[22:47:26] <awjr>	 ?
[22:48:10] <awjr>	 indexable
[22:51:41] <grrrit-wm>	 (03PS2) 10Jdlrobson: Don't show newbie tutorials after logging out [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82764 (owner: 10JGonera)
[22:52:00] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] "I made a minor tweak. Juliusz if you are happy with this feel free to +2" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82764 (owner: 10JGonera)
[22:53:47] <jdlrobson>	 MaxSem: https://gerrit.wikimedia.org/r/#/c/81580/2/includes/api/ApiMobileView.php should this not be isset ?
[22:54:13] <jdlrobson>	 for if ( $data['liquidthreads'] ) {
[22:54:20] <MaxSem>	 awjr, yes - see how it searches by prefix
[22:54:33] <awjr>	 aye makes sense MaxSem
[22:55:10] <MaxSem>	 jdlrobson, my bad
[22:55:22] <jdlrobson>	 MaxSem: apart from that looks fine to me
[22:55:32] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81580 (owner: 10MaxSem)
[22:55:37] <MaxSem>	 jdlrobson, actualy no
[22:55:56] <MaxSem>	 I increment the cache version, so all data is guaranteed to have this set
[22:59:11] <jdlrobson>	 MaxSem: but it seems a bit risky if the function it calls is ever refactored no?
[22:59:35] <MaxSem>	 it relies on data being valid in many places
[23:03:10] <awjr>	 tfinc: ready when you are
[23:05:44] <grrrit-wm>	 (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82556 (owner: 10JGonera)
[23:06:14] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Hide NagOverlay after checkboxes are checked [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82747 (owner: 10JGonera)
[23:06:14] <tfinc>	 awjr: i have nothing on my calendar
[23:06:23] <tfinc>	 and i need to talk to doreen about a flight
[23:06:39] <tfinc>	 did you invite me to this meeting ?
[23:06:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hide NagOverlay after checkboxes are checked [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82747 (owner: 10JGonera)
[23:06:47] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] Story 1096: Beta section editing tutorial a/b test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82556 (owner: 10JGonera)
[23:06:49] <tfinc>	 if so i'll be back in a couple 
[23:06:53] <awjr>	 tfinc: >_< crap, i added some guy named tom morris
[23:06:58] <tfinc>	 lulz
[23:07:12] <awjr>	 wow
[23:07:18] <awjr>	 tfinc: have time after chatting with doreen?
[23:08:25] <awjr>	 tfinc: anyway, invite fixed, holler when you're around
[23:10:13] <MaxSem>	 jdlrobson, seen my reply^?
[23:10:48] <jdlrobson>	 MaxSem: sorry no i missed it
[23:11:12] <jdlrobson>	 MaxSem: at the very least should add a test to ensure that it is always present
[23:11:16] <jdlrobson>	 just gives us a bit more safety
[23:14:52] <MaxSem>	 jdlrobson, see the code around. no other array index is checked - why this one is special?
[23:15:25] <jdlrobson>	 MaxSem: yeh but that's broken windows theory - we should set standards
[23:15:39] <jdlrobson>	 surely you don't disagree that a test would give us better more future proofed code?
[23:16:00] <jdlrobson>	 if we continue the bad pattern of not adding tests we continue the bad pattern
[23:16:16] <MaxSem>	 why not test умукн class ашудвб ерут, шеэы зкусшыудн еру ыфьу ыегаа
[23:16:20] <MaxSem>	 bleh
[23:16:41] <MaxSem>	 why not test every class field then? it's precisely the same thing
[23:20:42] <jdlrobson>	 MaxSem: you can never have enough tests from my perspective
[23:20:54] <jdlrobson>	 test every class field :) it's good for newcomers to see the expected behaviour
[23:21:04] <MaxSem>	 that's because you don't feel confident about php
[23:26:45] <awjr>	 jcmish probably has some wise words ^^
[23:27:01] <jcmish>	 :D
[23:27:27] <jcmish>	 catching up
[23:28:12] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 031] "Works well in my testing in iOS simulator -- I'll +2 after testing on some more devices. :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81879 (owner: 10JGonera)
[23:29:50] <jdlrobson>	 Maryana: you may want to come into wikimedia-dev - talking about the wlm banner
[23:30:03] <jdlrobson>	 it needs to go from mobile
[23:31:18] <tfinc>	 awjr: and i'm back. you booked against another meeting. i'm free now
[23:31:38] <awjr>	 fml
[23:35:04] <Maryana>	 jdlrobson: did i miss the wlm banner discussion?
[23:35:14] <jdlrobson>	 Maryana: not really it stalled
[23:37:57] <jdlrobson>	 mail to wikitech?
[23:39:03] <jcmish>	 sorry I had to read up MaxSem and jdlrobson I think that you can have too many tests if they're not testing something static
[23:39:44] <jcmish>	 but that being said. I think you should always have at least one positive path and negative path test 
[23:39:46] <MaxSem>	 jcmish, a different tests are discussed
[23:40:31] <jcmish>	 not sure what you mean MaxSem? You guys are talking about unit tests ? Or no?
[23:40:38] <MaxSem>	 no
[23:41:43] <jdlrobson>	 wlm banner discussion happening in #wikimedia-tech if anyone interested
[23:41:57] <jdlrobson>	 #wikimedia-dev sorry
[23:47:07] <jgonera>	 jdlrobson, I see that you reached a consensus
[23:47:24] <grrrit-wm>	 (03PS1) 10MaxSem: Remove unused ID whitelists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83042