[00:02:09] (03CR) 10Jdlrobson: [C: 032] "awesome :D" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81879 (owner: 10JGonera) [00:02:29] (03Merged) 10jenkins-bot: Add media viewer [alpha] [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81879 (owner: 10JGonera) [00:12:23] (03PS5) 10Jdlrobson: Update pre-commit hook to use optipng not pngcrush [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82105 (owner: 10MaxSem) [00:12:25] (03CR) 10jenkins-bot: [V: 04-1] Update pre-commit hook to use optipng+advdef not pngcrush [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82105 (owner: 10MaxSem) [00:12:28] (03CR) 10Jdlrobson: [C: 032] Update pre-commit hook to use optipng+advdef not pngcrush [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82105 (owner: 10MaxSem) [00:12:31] (03CR) 10jenkins-bot: [V: 04-1] Update pre-commit hook to use optipng+advdef not pngcrush [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82105 (owner: 10MaxSem) [00:13:30] (03PS5) 10Jdlrobson: Hygiene: Complete merging of special nearby code with nearby pages code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80687 [00:13:32] rebasing... [00:17:36] (03PS6) 10MaxSem: Update pre-commit hook to use optipng+advdef not pngcrush [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82105 [00:17:52] (03CR) 10MaxSem: [C: 032] Update pre-commit hook to use optipng+advdef not pngcrush [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82105 (owner: 10MaxSem) [00:18:11] (03Merged) 10jenkins-bot: Update pre-commit hook to use optipng+advdef not pngcrush [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82105 (owner: 10MaxSem) [00:25:06] (03PS1) 10Yuvipanda: (WIP) Add Campaigns ContentProvider & SyncService [apps/android/commons] (campaigns) - 10https://gerrit.wikimedia.org/r/83045 [00:29:41] Is Jon gone? [00:29:58] kaldari, yes [00:30:23] awjr, why have we changed the current iteration to ferret already? [00:33:41] @_@ [00:33:46] we shouldn't have jgonera [00:33:48] jgonera: I still see emu when I click the story wall tab [00:34:02] yeah, same [00:34:29] jgonera: maybe hard refresh? [00:34:51] ah for some reason the story wall had been set to show 'next iteration' as opposed to 'current iteration', which i fixed earlier today [00:34:57] awjr, hm, weird, I'm still seeing fireferret [00:35:04] oh [00:35:20] jgonera: do you see a little refresh icon on the story wall tab? [00:35:37] awjr, thanks, that helped [00:35:40] :D [00:37:26] i wonder what a fireferret would look like [00:39:36] monty: hey question coming from legal [00:41:20] monty: oops I'm actually looking for mhurd [00:46:46] (03CR) 10JGonera: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82556 (owner: 10JGonera) [00:46:57] (03PS2) 10JGonera: Story 1096: Beta section editing tutorial a/b test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82556 [00:49:00] any mobile apps peeps out there? [00:49:09] kenanwang: I'm actually here [00:49:16] excellent [00:49:20] 'sup? [00:49:24] (going to sleep in 10m) [00:49:33] do you know if we use unique identifiers for analytics purposes/ [00:49:34] ? [00:49:43] kenanwang: android does, iOS had some trouble. [00:49:44] unique devise identifiers [00:49:51] kenanwang: we set unique user agents [00:50:08] kenanwang: wait, are you talking about the Wikipedia app? [00:50:13] or the COmmons apps? [00:50:16] any of our apps really [00:50:29] this is a questions from legal about our policies [00:50:50] With commons we record user name + device name [00:51:02] let me dig that page up, moment [00:51:37] kenanwang: https://meta.wikimedia.org/w/index.php?title=Schema:MobileAppUploadAttempts&oldid=5346150 [00:51:51] perfect [00:52:05] kenanwang: we collect, for anyone who has uploaded (And who has not opted out), username + device + platform + appversion [00:52:22] you can opt out/ [00:52:22] ? [00:52:33] kenanwang: yeah, go to settings, and opt out [00:52:40] kenanwang: we also collect the fact that people opted out, however. [00:52:51] so everyone has at least 1 record - even if they opt out, there's a record of them opting out [00:52:56] mhhm [00:53:01] but that's just a username right/ [00:53:02] ? [00:53:12] is that true of the wikipedia app? [00:53:13] no, that has device + platform + appversion too, IIRC [00:53:18] ahhh [00:53:18] ok [00:53:19] kenanwang: the wikipedia app collects nothing. [00:53:30] k [00:53:47] kenanwang: it has a unique useragent, but it doesn't add anything that your browser doesn't already have, in terms of device uniqueness [00:53:58] we might want to use a unique device identifier tho so we probably shouldn't paint ourselves into a corner [00:54:34] sure, sure. [00:54:48] when we did the old app EventLogging didn't exist, so we couldn't really do much even if we wanted [00:54:59] (old WIkipedia app, I mean) [00:55:03] ok I think that's enough info for me to work with legal [00:55:04] thanks! [00:55:09] yw :) [00:55:29] now I head off to sleep for real [00:55:36] sweet dreasms [00:55:55] see you in a few days :) [00:56:04] yup! [01:00:08] (03PS2) 10Yuvipanda: (WIP) Add Campaigns ContentProvider & SyncService [apps/android/commons] (campaigns) - 10https://gerrit.wikimedia.org/r/83045 [07:31:24] [13Commons-iOS] 15Grunny opened pull request #119: Better formatting for Information template (06master...06information-format) 02http://git.io/k2MSpQ [10:23:56] (03PS3) 10Yuvipanda: (WIP) Add Campaigns ContentProvider & SyncService [apps/android/commons] (campaigns) - 10https://gerrit.wikimedia.org/r/83045 [14:47:40] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82050 (owner: 10MaxSem) [15:02:46] (03PS1) 10MaxSem: Better section regex for mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83099 [15:58:11] (03PS1) 10MaxSem: Always output license footer in content language [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83104 [17:19:58] brion: there's a WIP patch for campaigns [17:20:16] * jgonera going to the office now [17:20:25] jdlrobson, do you have any meetings today? [17:20:25] brion: https://gerrit.wikimedia.org/r/#/c/83045/ [17:20:45] jgonera: err i hope not :) [17:20:46] \o/ [17:20:53] apparently yes [17:20:54] dammit! [17:20:59] jdlrobson, what time? [17:21:09] 1.30-4pm probably [17:21:11] brion: will finish it up today, so it can go out of 'wip' [17:21:13] you coming into the office jgonera [17:21:16] awesome [17:21:22] adding myself as reviewer so it's in my gerrit queue :D [17:22:11] 1.30-4pm? [17:22:14] woah [17:22:17] can someone else load http://mobile-reportcard.wmflabs.org/ and verify that all time points are being reported as 11PM ? [17:22:37] jgonera: --^ [17:22:42] tfinc, points? on the bar charts? [17:22:46] yes [17:22:52] i'm seeing every day listed as 11pm [17:23:06] tfinc: i don't see that in firefox [17:23:18] where are you seeing that? [17:23:32] chrome [17:23:36] i'll take a screenshot [17:23:36] I mean, on the graph or in CSV? [17:23:40] graph [17:24:12] try hard refresh and if this doesn't help, make a screenshot, I can't see any 11PM in there [17:24:39] jdlrobson, yes, coming now, let's work on the history stuff as soon as I get there [17:25:46] jgonera: k [17:25:58] screenshot sent to mobile-tech [17:26:00] just feels like there's so much cut-n-paste in the content providers… i wonder if we can consolidate those better in a refactor. no rush though :D [17:26:40] brion: yeah, I want to do that. However, not sure how exactly to do that - since there's a lot of constants being referenced [17:26:52] had to hard refresh it twice [17:26:52] now it looks fine [17:26:52] incredibly bizarre [17:26:52] tfinc that is whack [17:26:52] awjr: you saw the screenshot ? [17:26:59] yeah tfinc; though it looks fine to me in my browser [17:27:12] looks fine now so we'll deal with it if it happens again [17:27:27] ok [17:28:50] (03CR) 10Brion VIBBER: "I notice this pulls the full list of campaigns every time; this could get big." [apps/android/commons] (campaigns) - 10https://gerrit.wikimedia.org/r/83045 (owner: 10Yuvipanda) [17:28:51] (03Abandoned) 10Jdlrobson: Create a thin base class for all our skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/69336 (owner: 10MaxSem) [17:29:10] (03Abandoned) 10Jdlrobson: WIP: decouple heading formatting from MobileFormatter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/70558 (owner: 10MaxSem) [17:29:25] * MaxSem bites jdlrobson [17:29:31] I wanted to do it myself! [17:29:47] brion: it shouldn't refresh too often - but in general we don't control how often it refreshes. [17:30:19] i just hate an auto-refresh that runs on people's data plans that doesn't try to minimize its data transfer [17:31:05] MaxSem: meh. I think we should make a rule now that any patches over 2 months old with no activity in 2 weeks get abandoned. what do you think? [17:31:10] keeps the queue clean [17:31:54] brion: hmm, thoughts on how else to do it? [17:32:39] YuviPanda: well you could perhaps do some time-based fetch. but that might need to add more stuff [17:32:43] jdlrobson, meh [17:33:01] MaxSem: meh yeh? [17:33:12] or meh dont careh [17:33:15] meh meh:P [17:33:20] ahh meh meh meh [17:33:21] brion: what i'd ideally want is 'list of all campaigns that have changed since time X' [17:33:22] (03PS3) 10Jdlrobson: Bug 49647: Take away History.js dependency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/70953 [17:33:28] brion: or something similar. [17:33:35] brion: not sure if that'll be easy to make the API provide [17:33:59] (03PS4) 10Jdlrobson: Bug 49647: Take away History.js dependency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/70953 [17:34:07] well it'd be trivial if you add a table that tracks updates to campaign namespace by time :) [17:34:34] brion: hehe :P [17:34:56] ok gotta finish up here and head into the office [17:35:30] MaxSem: are we deploying next week ? [17:35:59] tfinc, I don't think so - it'll be during the tech days, too chaotic [17:36:03] tfinc: turns out my flight, all told, is going to be 32 hours long. yay! [17:36:05] (03PS5) 10Jdlrobson: Bug 49647: Take away History.js dependency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/70953 [17:36:16] haven't seen anything from greg-g on this... [17:36:22] YuviPanda: how is that even possible ? [17:36:40] tfinc: Chennai -> Delhi -> Newark -> SFO [17:36:49] with about 3 hour layovers in between [17:37:53] tfinc, MaxSem just sent greg-g an email [17:38:08] k, greg was asking me about it [17:38:17] o [17:39:40] i guess regardless of whether or not other deployments are happening regularly next week we should probably hold off as folks will be scattered during tech days on tuesday afternoon [17:39:58] MaxSem what do you think? ^ [17:40:17] concur [17:43:25] Maryana: can you get kenan to update https://docs.google.com/a/wikimedia.org/spreadsheet/ccc?key=0Aoizbfxc5g6KdEkza0xkQnJlM0o0TXlwQXhDOUFvYnc#gid=0 ? [17:43:52] will do [17:49:31] thanks [17:52:02] :) [17:56:00] jdlrobson, MaxSem it would be awesome if you can jump in and provide your reasons for wanting to kill the htmlformatter stuff on the 'mobile web needs your brains' thread [17:56:12] awjr: yeh i've started writing the email up but i need some more time [17:56:16] it's on my to do list for today [17:56:44] no problem jdlrobson just wanted to poke; im happy to do it but figured a diversity of voices and opinion is a Good Thing and will help build more momentum/discussion around it [18:00:51] (03PS3) 10Jdlrobson: Story 1096: Beta section editing tutorial a/b test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82556 (owner: 10JGonera) [18:01:27] (03CR) 10Jdlrobson: [C: 032] Story 1096: Beta section editing tutorial a/b test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82556 (owner: 10JGonera) [18:02:34] (03Merged) 10jenkins-bot: Story 1096: Beta section editing tutorial a/b test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82556 (owner: 10JGonera) [18:07:47] (03PS6) 10Jdlrobson: Hygiene: Complete merging of special nearby code with nearby pages code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80687 [18:08:15] (03CR) 10Jdlrobson: [C: 04-1] "Please please please add a test with this. This kind of change is scary to a core piece of code." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83099 (owner: 10MaxSem) [18:08:57] (03CR) 10Jdlrobson: [C: 032] Always output license footer in content language [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83104 (owner: 10MaxSem) [18:09:23] (03Merged) 10jenkins-bot: Always output license footer in content language [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83104 (owner: 10MaxSem) [18:10:38] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83018 (owner: 10Jdlrobson) [18:16:20] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81371 (owner: 10Jdlrobson) [18:16:34] (03PS2) 10Jdlrobson: Bug 53182: Don't show new pages editor for newly created pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81371 [18:16:40] (03PS3) 10Jdlrobson: Bug 53182: Don't show new pages editor for newly created pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81371 [18:18:23] (03PS1) 10Jdlrobson: Hygiene: Add comma.. been bugging me for some time [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83115 [18:18:43] ^ MaxSem can you merge that simply fix? :) [18:19:20] yer itchy jdlrobson?:) [18:19:26] (03CR) 10MaxSem: [C: 032] Hygiene: Add comma.. been bugging me for some time [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83115 (owner: 10Jdlrobson) [18:19:49] (03Merged) 10jenkins-bot: Hygiene: Add comma.. been bugging me for some time [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83115 (owner: 10Jdlrobson) [18:21:53] (03CR) 10Jdlrobson: [C: 04-1] "(6 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 (owner: 10Kaldari) [18:22:11] MaxSem: sooo many things to do ;-) [18:36:57] (03CR) 10JGonera: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 (owner: 10Kaldari) [18:38:56] tfinc: is r36 the kindergarten room? [18:39:00] (03PS5) 10Jdlrobson: Hygiene: Use our own custom reset file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79431 [18:39:06] awjr: yes [18:41:26] (03CR) 10Jdlrobson: [C: 032] Remove unused ID whitelists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83042 (owner: 10MaxSem) [18:41:47] (03Merged) 10jenkins-bot: Remove unused ID whitelists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83042 (owner: 10MaxSem) [18:45:33] (03PS1) 10Yurik: Minor fix in vcl varnish script [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83118 [18:49:29] awjr: heads up that i saw your mail about the dev camp. just haven't had a chance to think about it yet [18:50:07] cool thanks tfinc [18:57:15] (03CR) 10JGonera: "Is this about readability? Because technically that tweak does nothing, apart from adding 4 extra characters ("else")." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82764 (owner: 10JGonera) [19:02:45] mhurd: YuviPanda brion : heads up that i'm turning on card aging for the app backlog [19:02:55] 'card aging'? [19:03:15] Cards will visibly “age” as time passes without any activity. Regular mode will cause old cards to become progressively more transparent. Pirate mode will cause old cards to crack and tear like an old treasure map. Once cards have new activity on them, their age counter is reset and they appear new again. Age threshholds are 1, 2, and 4 weeks. [19:03:36] we're on pirate mode, right? [19:03:43] :D [19:03:50] hehe, i'm trying the regular first [19:03:55] booorrringgg! [19:04:43] brion: ping? [19:04:51] YuviPanda: pong [19:05:18] brion: thoughts on the sync provider? I could add a 'only if modified since' functionality to the API if you want... [19:05:56] now i'm trying pirate mode [19:06:06] YES! [19:06:16] YuviPanda: let's leave it as is for now and consider fancying it up later [19:06:19] brion: okay [19:06:22] once we have a better idea of if it causes any impact [19:06:24] keep it simple :D [19:06:28] brion: other than that that code looks okay now? [19:06:37] nothing stood out, lemme take another test pass [19:06:46] brion: i still need to surface that list in the UI [19:06:48] let me get to that [19:06:49] hmm .. pros/cons of both [19:06:59] ok [19:08:02] (03CR) 10JGonera: [C: 032] Don't show newbie tutorials after logging out [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82764 (owner: 10JGonera) [19:08:03] awjr_haircut: is there a wiki page for writing up about our formatter woes? [19:08:05] (03CR) 10jenkins-bot: [V: 04-1] Don't show newbie tutorials after logging out [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82764 (owner: 10JGonera) [19:10:22] (03PS3) 10Jdlrobson: Don't show newbie tutorials after logging out [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82764 (owner: 10JGonera) [19:11:09] (03CR) 10Brion VIBBER: "(2 comments)" [apps/android/commons] (campaigns) - 10https://gerrit.wikimedia.org/r/83045 (owner: 10Yuvipanda) [19:11:10] (03PS4) 10Jdlrobson: Don't show newbie tutorials after logging out [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82764 (owner: 10JGonera) [19:13:05] brion: deletion happens in the contentprovider! [19:13:17] brion: the contentprovider is self-regulating - doesn't allow duplicate campaign names [19:13:36] what if a campaign is deleted? [19:13:49] or renamed? [19:14:16] (03CR) 10Jdlrobson: [C: 032] Don't show newbie tutorials after logging out [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82764 (owner: 10JGonera) [19:14:40] (03Merged) 10jenkins-bot: Don't show newbie tutorials after logging out [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82764 (owner: 10JGonera) [19:14:48] (03CR) 10Kaldari: "(5 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 (owner: 10Kaldari) [19:15:02] brion: hmm, doesn't handle either. [19:15:10] :) [19:16:00] brion: I don't know how it can actually handle deletes and such [19:16:09] brion: perhaps I need to rethink this, and not use a contentprovider at all [19:16:19] hmm [19:28:50] (03PS1) 10JGonera: Remove obsolete code from mf-toggle-dynamic.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83124 [19:37:39] kenanwang, jcmish, you guys still wanna check in? [19:48:37] good: i got my HDMI EDID emulator which i can use to force resolution to 720p. bad: i forgot my keys and can't get into the locked drawer where i put the video capture widget. i guess i'll test it monday…. [19:49:13] brion: so thinking about it - I am considering killing the ContentProvider, and just ask the API everytime we show them the screen [19:49:24] brion: pros: no excess baggage. Cons - slow! [19:49:27] heh [19:49:35] brion: also, we have a lot of campaigns, and no idea which ones the user will be interested in [19:49:36] YuviPanda: content provider or not, i would recommend caching them [19:49:40] so they can be used when offline [19:49:44] once loaded once [19:49:45] brion: oh yes, definite.y [19:49:51] brion: all that becomes so much easier with a sync adapter :D [19:49:56] hehe [19:50:12] brion: well, if we cache them there's still the renamed/deleted difficulty [19:50:30] yeah… at least until we clear and update the cache :) [19:50:52] true [19:53:05] (03CR) 10MaxSem: [C: 032] "OK, I'll just merge it myself." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/68581 (owner: 10MaxSem) [19:53:07] (03Merged) 10jenkins-bot: Move Vary: headers setup from MF [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/68581 (owner: 10MaxSem) [19:57:08] brion: I think I'm going to let this rot until I land in SF. [19:57:45] ok. it'll be on my dashboard so i'll get pinged when you update it :) [19:58:05] brion: okay :) [20:00:59] hey Maryana sorry was on with kenanwang and didn't see this :D [20:01:04] we went on without ya :D [20:04:38] jdlrobson: ping [20:06:56] jorm: ping [20:16:54] preilly: pong [20:32:21] (03PS6) 10JGonera: Bug 49647: Take away History.js dependency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/70953 (owner: 10Jdlrobson) [20:32:31] (03PS7) 10JGonera: Bug 49647: Take away History.js dependency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/70953 (owner: 10Jdlrobson) [20:39:55] gah power went off for a minute - i hope it stays on today... [20:40:46] (03PS8) 10Jdlrobson: Bug 49647: Take away History.js dependency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/70953 [20:43:44] jdlrobson: I remember the other reason I'm not reusing the Echo JS for mobile notifications. Desktop Echo uses jQuery.ui and we don't load jQuery.ui on mobile. [20:43:56] echo uses query ui [20:44:00] o_O [20:44:02] jQuery.ui [20:44:08] for the love of god please stop it from doing so [20:44:14] :) [20:44:16] I could [20:44:32] but that would involve a bit more work [20:44:33] * YuviPanda adds jquery mobile to MF... [20:46:04] (03PS6) 10JGonera: Hygiene: Use our own custom reset file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79431 (owner: 10Jdlrobson) [20:46:37] (03CR) 10JGonera: [C: 032] Hygiene: Use our own custom reset file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79431 (owner: 10Jdlrobson) [20:46:42] jdlrobson: Do you know if we load mediawiki.ui instead? I'm guessing not. [20:46:53] since we seem to use our own styles for things [20:47:07] (03Merged) 10jenkins-bot: Hygiene: Use our own custom reset file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/79431 (owner: 10Jdlrobson) [20:47:10] YuviPanda: when do you get to SF? [20:47:22] jdlrobson: sunday afternoon [20:47:26] jdlrobson: after a 35hour flight [20:48:28] this is the problem with mobile having it's own interface components. it makes integrating features from desktop a bit tricky. [20:49:35] YuviPanda: Where is your flight taking you? [20:49:47] Reedy: Madras -> Delhi -> Newark -> SF [20:50:00] So it's not 35 hours flying, that includes layovers? [20:50:03] with 3-4 hour layovers [20:50:04] yeah [20:50:05] kaldari: ui libraries are horrible and mediawiki has 2 of those :( [20:50:08] i'd die from 35 hour flying [20:50:19] hmm, I think I also messed up timezone math. it is probably 32 hours, not 35 [20:50:34] I was thinking can fly from SF to HK in less time than that (going the wrong way around via london) in about 23-25 [20:50:35] why are ui libraries horrible? They keep people from having to reinvent the wheel. [20:50:40] (03PS9) 10Jdlrobson: Bug 49647: Take away History.js dependency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/70953 [20:50:51] well let me rephrase - ones of the shelf are horrible - to me it's lazy programming [20:51:01] kaldari: Cause they're written by developers? [20:51:02] jdlrobson: actually we have 3 ui libraries [20:51:02] mediawiki should have its own ui library [20:51:12] VE has it's own ui library [20:51:16] Reedy: heh, true. includes layovers. [20:51:36] jdlrobson: that's what mediawiki.ui is supposed to be, but it isn't well developed and no one uses it :P [20:52:07] (03CR) 10JGonera: [C: 032] Bug 49647: Take away History.js dependency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/70953 (owner: 10Jdlrobson) [20:52:11] mw.ui has buttons and some textfield styling, and that's it, no? [20:52:32] (03Merged) 10jenkins-bot: Bug 49647: Take away History.js dependency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/70953 (owner: 10Jdlrobson) [20:52:38] yeah, not much yet, but it's actually probably enough for echo [20:52:44] and mobile notifications [20:53:00] I could migrate both of them to mediawiki.ui [20:53:42] while merging them [20:54:07] although I'd prefer to leave it all how it is :) [20:57:45] (03PS2) 10MaxSem: Better section regex for mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83099 [20:58:17] (03CR) 10jenkins-bot: [V: 04-1] Better section regex for mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83099 (owner: 10MaxSem) [20:58:19] (03CR) 10MaxSem: [C: 04-2] "Teh suxxx, the fix appears insufficient:(" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83099 (owner: 10MaxSem) [21:00:44] (03PS1) 10Dr0ptp4kt: Better prevent chargeable resources from being inadvertently accessed. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 [21:03:51] (03CR) 10Dr0ptp4kt: [C: 04-2] "WIP. This first cut seems functional enough for production to mitigate menu-based "bad" (chargeable) clicks. But cookie setting and cookie" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 (owner: 10Dr0ptp4kt) [21:06:53] brion: ready when you are in r32 [21:07:03] moment [21:20:30] brion, jdlrobson, jgonera, YuviPanda: bikeshed time… it looks like sometimes we use 700px as a responsive css threshold (presumably for tablets/desktop) and sometimes we use 768px. It looks like the most common screen width resolution for tablets is actually 800px. Any suggestions for what value we should converge on for our tablet/desktop media queries? [21:21:06] or at least which value I should use at the moment? [21:21:56] randomly picking a number, I'll say 720 [21:22:19] it looks like 768 is specifically for iPad [21:22:26] 768px is the magic number [21:22:31] that's what i'd use [21:22:41] screw 700 - that sounds like old code [21:23:39] 768 it is [21:25:31] jdlrobson: awjr is there a wiki page for writing up about our formatter woes? [21:25:53] i think it would be good to have a wiki page outlining goals etc - for responding to tim and in preparation for the chat [21:26:01] jdlrobson: i was trying to look for it earlier but couldn't find one so im not sure if one ever existed [21:26:13] MaxSem: do you know? ^^ [21:26:16] but yeah jdlrobson i agree [21:26:27] sounds like a good idea [21:26:35] errggy well i need to help legal with mobilifying the terms and conditions - can someone start that so i can help contribute to it when i get back? [21:27:28] awjr, not that I know of [21:27:46] i have a vague recollection of there being notes somewhere, maybe on an etherpad? [21:28:08] my ep is http://etherpad.wikimedia.org/p/mf [21:28:49] (03PS1) 10Kaldari: Hide nav boxes on small displays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83135 [21:28:53] i know we talked about it for sure a bit during annual planning [21:29:54] meh, there isn't much here: https://www.mediawiki.org/wiki/Wikimedia_Mobile_engineering/imported/Mobile_team/Mobile_web/Etherpad/Internal_goals_2013-2014#Remove_existing_HTMLFormatter_code_from_MobileFrontend_extension [21:30:41] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83135 (owner: 10Kaldari) [21:36:08] (03CR) 10Kaldari: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83135 (owner: 10Kaldari) [22:22:08] jdlrobson: Want to go to a Giants game tomorrow night? [22:29:19] kenanwang, do you have a WMF account on enwiki, or are you just using user:kenanwang for everyting? [22:29:27] *everything [22:56:27] brion: I think the app/hybrid should be using the webview more as a 'dumb html container', and not do too many things in it. We'll probably be able to discuss mroe on Monday :) [22:56:44] YuviPanda: agreed; minimal interference in the inside is good [22:57:06] brion: yeah, but I also think the webview should show dumb html with minimal javascript, not all of mobilefrontend :) [22:57:30] well, then we lose all those web features :) [22:57:53] the sticking point, I think, is wether the UI should be native or CSS/DOM [22:57:56] i for one don't want to reimplement visual editor ;) [22:58:08] we won't need to. I was at the VE talk, and it is amazingly modularly written [22:58:21] well some of the ui is gonna be css/dom cause that'll be anything we don't override :) [22:58:32] it'd be good to do things like toolbar and search and menu in native though [22:58:45] yeah, and I think that'll break things badly. Or put an undue burden on MF devs. [22:58:48] anyway, let's have this on Monday. [22:58:54] i need to sleep early today so I can catch my flight. [22:58:56] yeah we'll talk :D [22:58:59] excellent [22:59:05] when do you arrive? [22:59:10] brion: sunday afternoon [22:59:14] spiff [22:59:21] but looong flight [22:59:52] hehe [23:02:55] (03PS1) 10Jdlrobson: Alpha: Remove inline style scrubbing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83195 [23:02:58] (03CR) 10jenkins-bot: [V: 04-1] Alpha: Remove inline style scrubbing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83195 (owner: 10Jdlrobson) [23:03:45] (03PS2) 10Jdlrobson: Alpha: Remove inline style scrubbing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83195 [23:05:10] (03CR) 10JGonera: [C: 032] Alpha: Remove inline style scrubbing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83195 (owner: 10Jdlrobson) [23:05:32] (03Merged) 10jenkins-bot: Alpha: Remove inline style scrubbing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83195 (owner: 10Jdlrobson) [23:08:40] (03PS1) 10JGonera: Remove unused code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83196 [23:09:10] Maryana: this is now my favorite of the meme tweets https://twitter.com/10yearoldmac/status/376047531392000000 [23:09:36] jdlrobson, https://gerrit.wikimedia.org/r/#/c/83196/1 [23:10:57] (03PS2) 10Jdlrobson: Remove unused code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83196 (owner: 10JGonera) [23:11:03] (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove unused code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83196 (owner: 10JGonera) [23:11:29] (03CR) 10Jdlrobson: [C: 032] Hide nav boxes on small displays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83135 (owner: 10Kaldari) [23:11:44] (03Merged) 10jenkins-bot: Hygiene: Remove unused code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83196 (owner: 10JGonera) [23:12:13] https://bugzilla.wikimedia.org/show_bug.cgi?id=53048 < jgonera [23:12:14] (03Merged) 10jenkins-bot: Hide nav boxes on small displays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83135 (owner: 10Kaldari) [23:21:06] awjr: did that wiki page get set up for formatter stuff? [23:21:15] jdlrobson: i thought you were doing it! [23:21:21] so, probably not :p [23:21:32] awjr: i've been tackling the t&c on mobile [23:21:42] oak guess i should get something off the ground [23:21:58] no worries jdlrobson, i've also had my head in another hole [23:23:23] actually, holes would be more accurate [23:32:12] jgonera MaxSem: awjr https://www.mediawiki.org/wiki/Remove_existing_HTMLFormatter_code_from_MobileFrontend_extension?venotify=created [23:32:16] care to help me flesh this out? [23:34:14] jdlrobson: ready in R33 when you are [23:37:27] jdlrobson, I thik you're misplacing the emphasis: e should strive to get rid of the formatter, not move it into core for the sake of mobile [23:37:56] a stripped-down version of it can actually be useful for text extraction from HTML [23:39:50] jdlrobson: https://www.mediawiki.org/wiki/Wikimedia_Engineering/WMF_Tech_Days_2013 [23:46:12] (03PS2) 10Kaldari: Hygiene: Don't add styles in two places [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83018 (owner: 10Jdlrobson) [23:46:39] (03CR) 10Kaldari: [C: 032] Hygiene: Don't add styles in two places [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83018 (owner: 10Jdlrobson) [23:47:00] (03Merged) 10jenkins-bot: Hygiene: Don't add styles in two places [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83018 (owner: 10Jdlrobson) [23:55:07] MaxSem: Hey Max, can you comment at https://bugzilla.wikimedia.org/show_bug.cgi?id=53595? Thanks! [23:57:55] btw if you guys see weird things happening in mingle RE bugs showing up in 'in analysis' - ignore it for now, im doing some testing of bingle updates