[00:07:36] (03PS1) 10MaxSem: Move red link removal to MobileFormatter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83592 [00:24:43] jdlrobson, should I override doEditSectionLink in SkinMinerva or SkinMobile? [00:24:55] Always choose SkinMinerva if you can jgonera [00:24:57] SkinMobile I guess since there's not editor in Minerva? [00:24:58] SkinMobile should die [00:25:02] well... [00:25:15] then we get useless edit links in Minerva no? [00:25:31] jdlrobson, ^ [00:25:45] jgonera: well hopefully in next 2 days we can get the same section markup on SkinMinerva [00:26:01] i guess SkinMobile will do for time being until that though :) [00:26:01] ok, so I put it in SkinMinerva then? [00:26:06] ok ;) [00:26:12] jgonera: well.. see what it looks like in desktop mode :) [00:26:25] if it works/looks ok do it - otherwise do it in SkinMobile [00:26:34] we don't load editor JS in desktop mode so I assume broken [00:34:47] (03PS1) 10JGonera: Override Skin::doEditSectionLink [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83597 [00:35:11] (03CR) 10jenkins-bot: [V: 04-1] Override Skin::doEditSectionLink [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83597 (owner: 10JGonera) [00:41:00] MaxSem, can you have a look at https://gerrit.wikimedia.org/r/#/c/83597/ and tell me if the tests fail because I broke something or I just need to update them? [17:14:06] YuviPanda: where are you ? [17:14:22] YuviPanda: you know were not in the office right ? were @ spur [17:17:18] iOS 7 coming september 18 [17:18:50] mhurd: --^ [17:18:59] i'm catching up on it here http://www.engadget.com/2013/09/10/apple-iphone-liveblog-2013/ [17:19:17] tfinc: oh yeah that's today [17:19:17] i'm watching the are technica one :) http://live.arstechnica.com/apple-september-10-event/ [17:20:16] brion: auto layout just in time for iOS 7 :) [17:20:22] \o/ [17:20:44] i wonder if they're gonna do a final version seed to test on [17:21:26] ooh, iWork apps are free now [17:22:46] here comes the new iphone... [17:23:05] please no new screen resolution [17:23:12] though with auto layout we'd be ready soon ;) [17:26:40] * tfinc waits for the 5C price [17:26:49] retina and A6 [17:27:06] i want my retina iPad mini... [17:27:10] and a retina macbook air [17:28:37] '$99 with contract'… what's the real price :P [17:28:39] 99/199 [17:31:04] "iPhone 5C is beautifully, unapologetically plastic." [17:31:22] plastics…. it's the future [17:31:41] brion: do you see yuvi about / [17:31:42] ? [17:31:55] tfinc: don't see him [17:32:00] grrr [17:32:20] eh just arrived :D [17:32:26] *he [17:32:44] bad Yuvi [17:33:58] brion: mhurd: YuviPanda: i'll chair the app team intro. think of one thing your really proud of to share with the engineering dept. [17:34:24] * tfinc debates about one thing you shouldn't have done as well :) [17:34:30] four-click sharing to Commons on android :D [17:34:39] well plus typing [17:35:16] gold iPhone is real! [17:35:30] bling bling [17:35:31] all hail our new gold iphone overlords [17:36:36] 64bit wtf [17:36:37] A7 fancy [17:36:40] whoooooooooooa [17:36:46] mhurd: --^ [17:36:48] another arch to build for? :P [17:37:21] brion: huh! [17:37:36] there BETTER be another Xcode seed with this [17:37:47] i hate when they spring shit like this at the last minute [17:39:21] god damnit there is going to be another xcode just for this [17:39:38] time to upgrade mhurd [17:39:44] yyyyyyup [17:39:48] download another few gigs [17:40:13] tfinc: gah! haha [17:50:20] dfoy: you about @ tech days ? [17:52:11] tfinc: not this morning but will attend when it's back at WMF [17:52:14] wonder if they have a new iPod touch coming too [17:52:26] otherwise we'll have to get a full iPhone 5S to test the 64-bit :P [17:52:49] guess i'll have to do the wp:zero introduction then. you were listed under it but i can take it [17:53:58] tfinc: I didn't hear about the introduction or off-site until I got into the office this morning [17:54:09] no worries [17:54:20] tfinc: ok thx [18:00:24] Has it got more than 4GB of memory then? [18:00:33] Or is this just prep work.. [18:04:03] might just be prep work [18:04:08] otherwise it seems confusing yeah [18:04:24] though maybe the 64-bit ARM ISA is awesome than the 32-bit one, i haven't researched that [18:04:45] that's one of the reasons for going 64-bit on x86_64… it's just a better ISA than the 32-bit one [18:05:04] hey brion [18:05:13] yo [18:05:58] iPhone 5s available…. september 20 [18:06:06] that was quick [18:10:29] hmm no mac os x 10.9 announcements? [18:10:54] i really want to upgrade my MBP, the multi-monitor improvements are great [18:10:59] but i need a working version of Xcode first :P [18:15:22] brion: it was iPad mini retina or bust for me [18:15:38] bust it is then :( [18:15:47] * tfinc explodes [18:16:08] :( [18:21:58] brion: hey [18:22:13] brion: https://gerrit.wikimedia.org/r/#/c/83082/ and https://gerrit.wikimedia.org/r/#/c/83568/ [18:22:15] :D [18:41:45] sonofa [18:41:57] YuviPanda: ok you might actually have to …. de-parse that if it's wiki parsed :) [18:42:04] brion: hmm? [18:42:10] double-check what happens if you put formatting or é or something in the title there [18:42:39] brion: hmm, I put a < in there, it came out as < on the [18:42:47] <brion> yeah :( [18:42:55] <brion> lemme find the handy text-from-html function [18:43:00] <YuviPanda> brion: why? [18:43:15] <YuviPanda> brion: <title> can't contain HTML [18:43:16] <brion> YuviPanda: wait, it's < in the HTML? or it's < in the display in the browser? [18:43:23] <YuviPanda> brion: < in the html [18:43:26] <YuviPanda> brion: displays as < [18:43:29] <YuviPanda> brion: and I think that's okay. [18:43:42] <brion> hmmmmm ok let's leave it as-is for now then [18:43:45] <YuviPanda> brion: this is the title, and the reason it is wikitext is because people can do i18n easily. [18:43:48] * brion is just always suspicious :DD [18:43:51] <brion> yeah [18:43:55] <brion> the i18n makes sense! [18:44:06] <YuviPanda> :D [18:44:08] <YuviPanda> it is good [18:45:01] <YuviPanda> brion: so I'm not sure of the comment either, since setHTMLTitle does escaping itself. [18:45:17] <brion> yeah… the method name is deceptive [18:45:21] <brion> let's just merge it as-is :D [18:46:34] <YuviPanda> brion: hehe, internal method names that make no sense? NO WAY! :P [18:46:48] <brion> what is this, some kind of decade-old project? [18:46:50] <brion> at least it's not java [18:47:13] <YuviPanda> hehe [18:47:14] <YuviPanda> true that [18:47:21] <mhurd> brion: OpenGL ES 3.0 support! yay! [18:48:14] * brion checks https://en.wikipedia.org/wiki/OpenGL_ES#OpenGL.C2.A0ES.C2.A03.0 [18:48:39] <brion> ugh they used non-breaking spaces in a section name? [18:48:43] <brion> that's…. insane [18:48:49] <YuviPanda> hahaha [18:54:42] <brion> c'mon apple, where the damn final iOS 7 and Xcode 5 seeds!? [18:54:47] * brion grumbles [19:50:50] <brion> "Developing for iOS 7 GM seed" [20:35:20] <jdlrobson> jgonera: it's just the other side [20:35:42] <jgonera> jdlrobson, be there in a few minutes [20:36:24] <grrrit-wm> (03PS2) 10JGonera: Override Skin::doEditSectionLink [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83597 [20:39:40] <brion> "The iPod “iPod touch” cannot be used because it requires iTunes version 11.1 or later." [20:39:42] <brion> *rolleyes* [20:39:48] <brion> one more download! [20:45:23] <jdlrobson> brion https://etherpad.wikimedia.org/p/WikimediaEngineering2013-FrontEndRfc [20:45:48] <brion> \o/ [20:45:57] <jdlrobson> brion: correction.. https://etherpad.wikimedia.org/p/WikimediaEngineering2013-FrontEndRfC [20:46:01] <jdlrobson> the c should be uppercase [20:46:06] <jdlrobson> haha [20:54:41] <brion> for some reason i can't install the Xcode 5 command-line tools [20:54:48] <brion> apple download server is rejecting my permissions. nice. [20:55:15] <mhurd> brion: gah! my iOS 7 gm install may have failed :( oh apple [20:55:32] <brion> :( [20:55:51] <brion> damn… the fading bug is still there [20:56:15] <mhurd> brion: doh! [20:59:45] <mhurd> brion: so apparently it didn't back up like it usually does when i started the update… unsure if photos etc are lost… nooooo! [20:59:58] <brion> awesome. :( [21:10:34] <brion> mhurd: http://etherpad.wikimedia.org/p/iOS-7-issues <- some notes from a quick run of auto layout branch on iOS 7 GM [21:10:53] <grrrit-wm> (03CR) 10JGonera: [C: 032] Hygiene: Complete merging of special nearby code with nearby pages code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80687 (owner: 10Jdlrobson) [21:11:36] <mhurd> brion: ah! good stuff! will tweak [21:11:57] <brion> whee [21:12:12] <brion> navbar stuff is probably from our customized drawing [21:12:18] <brion> can just switch that off on 7+ probably [21:13:31] <grrrit-wm> (03Merged) 10jenkins-bot: Hygiene: Complete merging of special nearby code with nearby pages code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80687 (owner: 10Jdlrobson) [21:14:00] <mhurd> brion: iOS 7 may be sizing view controller default view frames a bit differently - i think the auto layout constraints can be tweaked to make nav bars happy [21:14:25] <brion> spiff [21:20:27] <brion> yay command-line tools install now [21:27:54] <grrrit-wm> (03PS4) 10JGonera: Bug 53182: Don't show new pages editor for newly created pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81371 (owner: 10Jdlrobson) [21:28:07] <grrrit-wm> (03CR) 10JGonera: [C: 032] Bug 53182: Don't show new pages editor for newly created pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81371 (owner: 10Jdlrobson) [21:28:48] <grrrit-wm> (03Merged) 10jenkins-bot: Bug 53182: Don't show new pages editor for newly created pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81371 (owner: 10Jdlrobson) [21:35:17] <grrrit-wm> (03PS1) 10MaxSem: Move fancy image removal from HtmlFormatter to MobileFormatter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83760 [22:34:51] <grrrit-wm> (03PS1) 10JGonera: Regression: Fix PageApi for non-existent pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83767 [22:52:21] <grrrit-wm> (03CR) 10Jdlrobson: "Will this require a cache flush?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83597 (owner: 10JGonera) [22:52:56] <grrrit-wm> (03CR) 10Jdlrobson: "ignore.. read the code ;-)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83597 (owner: 10JGonera) [22:55:04] <grrrit-wm> (03PS1) 10JGonera: Hygiene: Change image viewer route [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83769 [22:56:45] <grrrit-wm> (03CR) 10Jdlrobson: [C: 031] "code looks fine - just need to test some more." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83561 (owner: 10JGonera) [22:57:09] <grrrit-wm> (03CR) 10Jdlrobson: [C: 04-1] "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83024 (owner: 10JGonera) [23:00:39] <grrrit-wm> (03CR) 10Jdlrobson: [C: 04-1] "I'd really like us to simply enable red links again. Let's talk to Kenan about doing this and see if we can remove this code altogether." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83592 (owner: 10MaxSem) [23:01:16] <grrrit-wm> (03CR) 10Jdlrobson: [C: 032] Regression: Fix PageApi for non-existent pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83767 (owner: 10JGonera) [23:01:42] <grrrit-wm> (03Merged) 10jenkins-bot: Regression: Fix PageApi for non-existent pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83767 (owner: 10JGonera) [23:04:10] <grrrit-wm> (03CR) 10MaxSem: "This can take a couple of weeks, while I want to move forward with core integration during tech days. Does it matter from which class the" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83592 (owner: 10MaxSem) [23:04:38] <OuKB> jdlrobson, ^^ [23:05:21] * jdlrobson waves at OuKB. It takes 5 minutes to remove. Let me have a chat with Kenan later today :) [23:05:45] <jdlrobson> but it doesn't matter - i'm happy to merge I'd just like to have that conversation first :) [23:06:16] <OuKB> jdlrobson, you can't remove it w/o supporting action=edit and page creation. could you please stop -1'ing over tangential concerns? [23:06:30] <jdlrobson> OuKB: we support page creation :) [23:06:57] <jdlrobson> ok removed -1 but it won't get me reviewing it any faster :) [23:07:22] <grrrit-wm> (03PS1) 10JGonera: Regression: make image viewer full screen again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83770 [23:07:57] <jgonera> jdlrobson, can you check if that brings back the weird bug that Michelle reported and we fixed ^ [23:08:34] <grrrit-wm> (03CR) 10Jdlrobson: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83770 (owner: 10JGonera) [23:08:51] <jdlrobson> jgonera: if i get time i'll do that later but just one comment ^ [23:09:22] <jgonera> ok, checking how similar they are [23:09:37] <grrrit-wm> (03CR) 10Kaldari: [C: 031] "Agree with Jon, but I don't think it should necessarily block this change." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83592 (owner: 10MaxSem) [23:09:52] <jgonera> jdlrobson, quick answer: not in this patch, one is a class of body and the other class of html... [23:10:21] <jdlrobson> could use the same rule applied to 2 places though no? also probably needs a FIXME? [23:10:52] <jgonera> how? a less mixin for body { height: 100%; } ? seems like too little for a mixin... [23:11:27] <jdlrobson> i mean .navigation-enabled, .overlay-enabled body { height: 100%; } [23:13:36] <jgonera> well yes, what about it? [23:13:56] <jgonera> how do you want to merge .navigation-enabled and .overlay-enabled? they're too different [23:14:15] <jgonera> another class just for body { height: 100%; } ? too much overhead for such a small thing [23:16:08] <grrrit-wm> (03CR) 10JGonera: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83770 (owner: 10JGonera) [23:17:02] <grrrit-wm> (03CR) 10JGonera: "It's not going to work until jshint is updated on whatever Jenkins runs on. I'll ask around again." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83024 (owner: 10JGonera) [23:37:49] <grrrit-wm> (03CR) 10Jdlrobson: [C: 032] "FYI just talked with Kenan. He's happy for us to enable red links in alpha/beta. I'm going to write a follow up patch." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83592 (owner: 10MaxSem) [23:38:11] <grrrit-wm> (03Merged) 10jenkins-bot: Move red link removal to MobileFormatter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83592 (owner: 10MaxSem) [23:51:35] <brion> new iOS design guidelines, whee https://developer.apple.com/library/prerelease/ios/documentation/UserExperience/Conceptual/MobileHIG/index.html