[17:01:32] brb [17:02:02] Maryana: standup! [17:04:51] Google Bump [17:08:07] (03PS1) 10Addshore: split MobileTemplateWML into its own class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84345 [17:27:02] (03CR) 10JGonera: [C: 04-2] "Let's merge after the 9/17 deployment to have more time to test locally." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83943 (owner: 10JGonera) [17:27:15] (03CR) 10JGonera: [C: 04-2] "Let's merge after the 9/17 deployment to have more time to test locally." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83958 (owner: 10JGonera) [17:27:26] (03CR) 10JGonera: [C: 04-2] "Let's merge after the 9/17 deployment to have more time to test locally." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84032 (owner: 10JGonera) [17:30:22] Maryana: i updated the invite to be for 330 :) [17:36:04] (03PS4) 10Jdlrobson: Override Skin::doEditSectionLink [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83597 (owner: 10JGonera) [17:38:55] kaldari: https://wikitech.wikimedia.org/wiki/MobileFrontend/Deployment [17:39:01] (03CR) 10Jdlrobson: [C: 032] Override Skin::doEditSectionLink [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83597 (owner: 10JGonera) [17:39:36] (03Merged) 10jenkins-bot: Override Skin::doEditSectionLink [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83597 (owner: 10JGonera) [17:40:22] MaxSem: If you want to update any of the deployment documentation, it's at https://wikitech.wikimedia.org/wiki/MobileFrontend/Deployment [17:41:08] kenanwang: https://gerrit.wikimedia.org/r/#/c/79948/ [17:41:27] (03PS2) 10Jdlrobson: Migrating all use of M.pageApi.getPageUrl to mw.util.wikiGetlink [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83967 (owner: 10Kaldari) [17:42:42] jdlrobson, this one is important: https://gerrit.wikimedia.org/r/#/c/83770/ overlays are slightly broken now! [17:42:48] jgonera: i know.. don't worry [17:42:57] ok ;) [17:42:59] jgonera: i'm just getting through the ones that don't require me to get out every phone under the sun [17:43:47] (03CR) 10Jdlrobson: [C: 032] Migrating all use of M.pageApi.getPageUrl to mw.util.wikiGetlink [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83967 (owner: 10Kaldari) [17:44:29] (03Merged) 10jenkins-bot: Migrating all use of M.pageApi.getPageUrl to mw.util.wikiGetlink [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83967 (owner: 10Kaldari) [17:44:31] MaxSem: https://gerrit.wikimedia.org/r/#/c/84345/ o_O [17:44:42] strange patch.. [17:45:44] (03CR) 10MaxSem: [C: 04-1] "You forgot the new file;) Also, "The autoloader expects this", really?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84345 (owner: 10Addshore) [17:46:27] jdlrobson: crap, I probably should have -2ed https://gerrit.wikimedia.org/r/#/c/83934/ until after the deployment [17:46:42] kaldari: it got merged into core [17:46:52] we just cherry pick the commit [17:47:04] true, and since I'm deploying tomorrow I can make sure it's pushed out [17:47:09] so nevermind [17:48:13] brion: planning on coming to the office today? [17:54:25] (03PS11) 10Jdlrobson: Hygiene: Simplify formatter HTML [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83837 [17:56:16] jdlrobson, do you want to get https://gerrit.wikimedia.org/r/#/c/83837/ merged today? it's kind of scary just before the deployment... [18:00:18] kaldari: are you working on fixing up https://gerrit.wikimedia.org/r/#/c/82073/ ? [18:01:15] (03CR) 10MaxSem: [C: 04-2] "Preventing deployment tomorrow cause we need to commnicate a cache flush beforehand." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83837 (owner: 10Jdlrobson) [18:01:27] jdlrobson: yes, some of that is dependant on https://gerrit.wikimedia.org/r/#/c/83575/ which hasn't been reviewed yet. [18:01:51] kaldari: is it blocked by that? [18:02:02] should it be a dependency? [18:02:03] Not sure I you heard me discuss it at the standup or if that was before you arrived [18:02:08] before i arrived :( [18:02:32] yeah, I'll list it as a dependency [18:02:41] want to -2 it as well? [18:02:45] yse [18:02:48] i'll take a look at the echo code a bit later today [18:03:10] thanks MaxSem - aside from the cache flush does that code look ok from your perspective? [18:03:24] neeed to look more closely [18:03:32] MaxSem: ok. just wondering if we need to schedule a cache flush [18:03:36] fucking keyyboard [18:03:37] (03CR) 10Kaldari: [C: 04-2] "Not ready" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 (owner: 10Kaldari) [18:03:42] neeeeeedddd [18:04:15] (03PS3) 10Jdlrobson: Regression: make image viewer full screen again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83770 (owner: 10JGonera) [18:04:22] jdlrobson, can we make our JS handle both cases to avoid the flush? [18:04:47] MaxSem: it's possible it already works. i've not tested it on the old version [18:04:59] i was just assuming it would need a cache flush but in theory it might be fine a few inconsistencies aside [18:05:21] please do - I can help you with testing if needed [18:38:28] (03CR) 10Jdlrobson: "+50, -3320. Epic." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER) [18:44:18] jdlrobson: you like that less patch? :D [18:44:22] :) [18:45:58] jgonera: so.. editing seems to be completely broken on master on opera mobile and iPhone 4.3.2. your patch seems to fix it for iPhone (although there is a rendering bug) but not opera mobile. slightly concerning.. [18:46:34] jdlrobson, which patch? [18:46:39] the height: 100% one [18:50:16] (03PS1) 10MaxSem: Revert "Rm header logging, several days worth of data should be enough" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84360 [18:56:00] (03PS2) 10MaxSem: Restore logging, now on steroids [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84360 [19:02:56] (03PS3) 10MaxSem: Restore logging, now on steroids [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84360 [19:03:02] lunch, anyone? [19:03:03] (03PS1) 10Jdlrobson: Regression: Fix edit button in page actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84364 [19:05:27] jdlrobson: I'm testing https://mingle.corp.wikimedia.org/projects/mobile/cards/1118 and it's still not working like it says in ticket. I put the details in the mingle ticket [19:06:41] (03CR) 10JGonera: [C: 032] Regression: Fix edit button in page actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84364 (owner: 10Jdlrobson) [19:07:21] (03Merged) 10jenkins-bot: Regression: Fix edit button in page actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84364 (owner: 10Jdlrobson) [20:04:44] (03CR) 10Jdlrobson: [C: 032] Regression: make image viewer full screen again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83770 (owner: 10JGonera) [20:05:23] (03Merged) 10jenkins-bot: Regression: make image viewer full screen again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83770 (owner: 10JGonera) [20:06:21] (03PS1) 10JGonera: Update README [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84416 [20:10:58] (03CR) 10Jdlrobson: [C: 032] Provide information about LQT status of a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81580 (owner: 10MaxSem) [20:11:48] (03Merged) 10jenkins-bot: Provide information about LQT status of a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/81580 (owner: 10MaxSem) [20:11:59] (03CR) 10Jdlrobson: [C: 032] Update README [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84416 (owner: 10JGonera) [20:14:08] (03Merged) 10jenkins-bot: Update README [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84416 (owner: 10JGonera) [20:28:32] awjr_away, jdlrobson I'm cleaning up our code guidelines. currently we have http://www.mediawiki.org/wiki/Wikimedia_Mobile_engineering/imported/Mobile_team/Mobile_web/Engineering_conventions/PHP_naming_conventions which is a super long URL. how about merging https://gist.github.com/jgonera/5238638 in and creating a page at http://www.mediawiki.org/wiki/MobileFrontend/Code_Guidelines ? is this a good URL? [20:33:28] MaxSem, ^ [20:39:07] (03PS1) 10Jdlrobson: Stop refreshing page on a hash change [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84420 [20:39:16] jgonera: fine with me [20:40:38] (03PS1) 10JGonera: Wrap README at 72 characters [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84421 [20:40:55] jgonera: that sounds good to me [20:44:30] (03PS1) 10JGonera: Change tabs to spaces in README [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84422 [20:46:31] (03PS1) 10Jdlrobson: Hygiene: Consolidate all the height: 100% rules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84423 [20:46:33] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Consolidate all the height: 100% rules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84423 (owner: 10Jdlrobson) [20:47:22] (03PS2) 10Jdlrobson: Hygiene: Consolidate all the height: 100% rules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84423 [21:00:25] (03CR) 10JGonera: [C: 04-1] "I'm all for cleaning up unused CSS, but I think a single CSS rule doesn't merit a separate CSS class." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84423 (owner: 10Jdlrobson) [21:04:28] (03CR) 10Yurik: [C: 032] Minor fix in vcl varnish script [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83118 (owner: 10Yurik) [21:04:42] (03Merged) 10jenkins-bot: Minor fix in vcl varnish script [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83118 (owner: 10Yurik) [21:05:19] (03CR) 10Yurik: [C: 032] Added py script to check for overlapping IP ranges on META [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83979 (owner: 10Yurik) [21:05:37] (03Merged) 10jenkins-bot: Added py script to check for overlapping IP ranges on META [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83979 (owner: 10Yurik) [21:07:40] (03PS7) 10Yurik: Handle MobileFrontendBeforeDOM hook instead of double parsing [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/75289 [21:18:36] (03PS8) 10Yurik: Handle MobileFrontendBeforeDOM hook instead of double parsing [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/75289 [21:30:56] (03PS9) 10Yurik: Handle MobileFrontendBeforeDOM hook instead of double parsing [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/75289 [21:38:40] (03PS3) 10Dr0ptp4kt: Better prevent chargeable resources from being inadvertently accessed. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 [21:46:36] (03CR) 10Dr0ptp4kt: [C: 032] Handle MobileFrontendBeforeDOM hook instead of double parsing [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/75289 (owner: 10Yurik) [21:46:38] (03Merged) 10jenkins-bot: Handle MobileFrontendBeforeDOM hook instead of double parsing [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/75289 (owner: 10Yurik) [22:03:09] (03CR) 10Jdlrobson: [C: 04-1] "invalid mediawiki wiki markup.." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84421 (owner: 10JGonera) [22:03:44] jdlrobson, was it valid before my changes? [22:03:49] jgonera: yup [22:03:55] paste it into a wiki page [22:06:11] awjr, Maryana, is there an option to list all the cards created by me in Mingle? [22:07:35] (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84420 (owner: 10Jdlrobson) [22:08:21] jgonera: because that's what it's called in the object returned by getState - we discussed this before [22:08:50] (03PS1) 10MaxSem: Use MobileContext for mobile view detection [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/84443 [22:09:04] jdlrobson, epoch.js, L54: H.replaceState = function( data, title, url ) { [22:09:08] jgonera: yeah [22:09:14] lemme come over [22:09:55] jgonera: id: url || window.location.pathname [22:10:26] (03PS1) 10Jdlrobson: Regression: Make sure all edit buttons are styled as edit buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84444 [22:10:52] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84420 (owner: 10Jdlrobson) [22:13:45] (03PS1) 10Yuvipanda: Display contributions even when they overwrite an existing file [apps/android/commons] - 10https://gerrit.wikimedia.org/r/84447 [22:13:50] brion: https://gerrit.wikimedia.org/r/84447 [22:14:44] im updating the mingle story wall so it may look weird for a few minutes [22:14:59] awjr, how do I delete cards? https://mingle.corp.wikimedia.org/projects/mobile/cards/1116 this one is a dupe, we already implemented this as a part of a different story [22:15:18] jgonera: if you open up the card you should see a 'delete' button [22:15:58] awjr, I only see Edit, I guess I don't have the right permissions [22:16:05] jgonera: what's the card? [22:16:15] https://mingle.corp.wikimedia.org/projects/mobile/cards/1116 [22:16:36] jgonera: deleted [22:16:47] thanks [22:17:47] jgonera: can you take a look at https://gerrit.wikimedia.org/r/84444 - nasty regression on pages with h1s that i'd hate to see go into stable tomorrow [22:21:25] (03PS2) 10MaxSem: Use MobileContext for mobile view detection [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/84443 [22:27:34] (03CR) 10JGonera: [C: 032] Regression: Make sure all edit buttons are styled as edit buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84444 (owner: 10Jdlrobson) [22:28:00] (03Merged) 10jenkins-bot: Regression: Make sure all edit buttons are styled as edit buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84444 (owner: 10Jdlrobson) [22:28:27] anybody remember what we decided to call the next iteration (starts with a 'g')? i neglected to write it down :( [22:28:47] Maryana, jcmish, jgonera, jdlrobson, MaxSem ^ [22:28:52] grasshopper [22:28:58] then honeybadger [22:29:08] ^ awjr [22:29:09] tehe [22:29:11] thanks jdlrobson [22:29:11] awjr, GOBLIN [22:29:16] :p [22:30:17] (03CR) 10Yurik: [C: 032] Use MobileContext for mobile view detection [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/84443 (owner: 10MaxSem) [22:30:19] (03Merged) 10jenkins-bot: Use MobileContext for mobile view detection [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/84443 (owner: 10MaxSem) [22:30:55] (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84420 (owner: 10Jdlrobson) [22:34:01] kaldari, can you review https://gerrit.wikimedia.org/r/84360 today please? [22:34:55] (03PS2) 10JGonera: Wrap README at 72 characters [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84421 [22:35:13] (03Abandoned) 10JGonera: Change tabs to spaces in README [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84422 (owner: 10JGonera) [22:36:04] (03CR) 10JGonera: "Good catch, automatic wrapping in Vim tricked me." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84421 (owner: 10JGonera) [22:37:41] (03CR) 10Kaldari: [C: 032] Restore logging, now on steroids [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84360 (owner: 10MaxSem) [22:38:03] (03Merged) 10jenkins-bot: Restore logging, now on steroids [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84360 (owner: 10MaxSem) [22:41:40] (03PS1) 10Jdlrobson: Fix blockquote styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84450 [22:48:23] (03CR) 10Kaldari: [C: 032] Fix blockquote styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84450 (owner: 10Jdlrobson) [22:49:13] (03PS1) 10JGonera: Ensure sections in stubs really look like open sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84454 [22:51:35] (03Merged) 10jenkins-bot: Fix blockquote styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84450 (owner: 10Jdlrobson) [22:57:09] (03PS1) 10Jdlrobson: Regression: Show human readable nearby error message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84458 [22:57:15] (03PS1) 10Jdlrobson: Improve nearby error handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84459 [23:22:49] (03PS4) 10Dr0ptp4kt: Better prevent chargeable resources from being inadvertently accessed. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 [23:23:58] (03CR) 10JGonera: [C: 032] Regression: Show human readable nearby error message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84458 (owner: 10Jdlrobson) [23:24:24] (03Merged) 10jenkins-bot: Regression: Show human readable nearby error message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84458 (owner: 10Jdlrobson) [23:49:42] (03PS1) 10Kaldari: Un-hardcode footer license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84465 [23:51:44] (03PS1) 10Jdlrobson: Redirect to talk page when liquid threads enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84466 [23:52:51] (03PS2) 10Kaldari: Un-hardcode footer license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84465 [23:55:21] (03CR) 10Jdlrobson: [C: 032] Un-hardcode footer license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84465 (owner: 10Kaldari) [23:55:44] (03Merged) 10jenkins-bot: Un-hardcode footer license message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84465 (owner: 10Kaldari) [23:57:41] kaldari: you still seeing https://bugzilla.wikimedia.org/show_bug.cgi?id=53382 ? [23:57:58] lemme check [23:58:09] kaldari: can't seem to replicate now