[00:00:13] jdlrobson: yeah, I still get the error. [00:00:31] kaldari: can you add firefox version? [00:01:42] added [00:01:45] v23 [00:01:54] thx [00:02:25] who wants to go to the pirate bar tonight then noisebridge? [00:02:36] also what time shall we leave? [00:02:42] ^ YuviPanda awjr jgonera MaxSem tfinc [00:02:49] pirate bar?? [00:02:56] * awjr raises hand [00:03:03] er [00:03:04] all the rum in the world [00:03:06] * awjr raises hook [00:03:10] yargh! [00:03:13] and pirate shanty songs on the toilet walls ohhh ah [00:03:18] also jcmish Maryana ^ [00:03:58] is this explained in an email I didn't read? :) [00:04:01] (03CR) 10Jdlrobson: [C: 032] "we could probably refactor those rules - relying on specificity here seems a bit hacky but works as advertised" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84454 (owner: 10JGonera) [00:04:24] (03Merged) 10jenkins-bot: Ensure sections in stubs really look like open sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84454 (owner: 10JGonera) [00:04:48] kaldari: no this is very adhoc [00:04:50] ooohh argghh [00:05:04] can you elaborate on what is entailed? [00:05:09] jdlrobson, I need to pick up my car from the mechanic before 6pm [00:05:27] is this a walking thing? [00:05:39] or do I need transportation? [00:05:46] http://25.media.tumblr.com/a6953439dadb303acb7d9f016b916617/tumblr_msgrjpMncw1sobyjzo1_500.gif < MaxSem at end of night [00:05:57] kaldari: probably a bus or taxi thing [00:06:15] (03PS1) 10JGonera: Fix: Make section edit A/B test work [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84467 [00:06:19] http://www.yelp.com/biz/smugglers-cove-san-francisco < kaldari [00:06:27] jdlrobson, important, we should merge before deployment ^ [00:07:09] ME, ME, ME! [00:07:14] * kaldari raises hand [00:07:42] jgonera: technically it's after 5pm so we need michelle's permission [00:07:56] but i'm looking through it now [00:07:57] ^ jcmish [00:07:57] jdlrobson: she already gave it :) [00:08:05] jdlrobson, jcmish just reported that to me 15 minutes ago so I think she'll be OK with it [00:08:07] ah ok didn't get that memo [00:08:07] jdlrobson: via email a bit ago [00:08:38] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84459 (owner: 10Jdlrobson) [00:09:58] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84459 (owner: 10Jdlrobson) [00:10:30] ah that's why - i only tend to check my mail twice a day when possible ;-) [00:10:45] i'm testing now [00:11:18] seems broken jgonera [00:11:25] i get redirected to main page [00:11:27] jdlrobson, in what way? [00:11:31] update the core [00:11:33] (03PS5) 10Dr0ptp4kt: Better prevent chargeable resources from being inadvertently accessed. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 [00:11:37] there's Kaldari's change [00:12:03] cta has a link to just the login page with no returnto [00:12:38] yes, update the core [00:12:48] it's the getPageUrl -> getWikiLink thing [00:12:49] good spot - i was in vector 2 mode [00:12:52] it's not related [00:14:21] (03CR) 10Jdlrobson: [C: 032] Fix: Make section edit A/B test work [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84467 (owner: 10JGonera) [00:14:38] yeh i was working on vector stuff and hadn't rebased [00:14:44] (03Merged) 10jenkins-bot: Fix: Make section edit A/B test work [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84467 (owner: 10JGonera) [00:15:09] ok so ship departing for pirate bar in 15 minutes or 30 minutes me heartys? < awjr kaldari MaxSem [00:15:24] jgonera: you want to meet us there after you have sorted your car? [00:15:33] jcmish: https://www.mediawiki.org/wiki/Wikimedia_Mobile_engineering/imported/Mobile_team/Mobile_web/Etherpad/Internal_goals_2013-2014 [00:15:35] sure [00:15:39] I'll see, I'll call/text you [00:15:52] jdlrobson: sounds good! [00:15:56] 15 is fine w me [00:16:03] 5:30? [00:17:12] yup [00:20:50] (03CR) 10Siebrand: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84459 (owner: 10Jdlrobson) [00:36:57] (03PS1) 10Kaldari: Un-hardcoding About and Disclaimer links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84472 [06:10:12] (03CR) 10Nikerabbit: [C: 04-1] "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84472 (owner: 10Kaldari) [06:25:55] who's home? [06:26:59] https://en.m.wikipedia.org/wiki/MP3Gain -> external links -> any of the links. seems to not do anything useful [06:27:07] currently sends me to https://en.m.wikipedia.org/wiki/MP3Gain?renderZeroRatedRedirect=true&returnto=http%3A%2F%2Fmp3gain.sourceforge.net%2F [07:09:53] btw, the search function for gitblit seems totally broken now :( [07:10:10] i.e. no results returned ever. just 302 back to the repo summary [07:10:31] jeremyb: use github :P [07:11:26] ewwwww. maybe i will [07:11:31] YuviPanda: see my question above? [07:11:52] jeremyb: yeah, a bug that jon robson and arthur noted earlier today [07:12:06] jeremyb: don't expect anything to change today, but. they're all sleeping [07:13:08] jeremyb: emailed internally [07:13:17] jeremyb: do file a bug tooo [07:13:27] jeremyb: and thanks for reporting it. we found that happening for images [07:15:26] ugh, why don't people file bugs for these things instead of sending internal emails? [07:15:43] or you're saying image thing was known but the links were not known until now? [07:18:51] jeremyb: well, we were at a bar drinking when we found the bug, and we sent an email than try to use bugzilla on the phone [07:19:04] jeremyb: there'll be a bug filed when we wake up, mostly [07:19:53] haha. bar drinking :-P [07:20:23] were you answering a question at the bar? [07:20:41] how much wood could a woodchuck chuck if a woodchuck could chuck wood? [07:23:24] hrmmmm, why no wikibugs here? [07:23:25] 17 07:21:20 < wikibugs> (NEW) MobileFrontend wraps external links in a broken redirect (renderZeroRatedRedirect=true&returnto=${target}) - https://bugzilla.wikimedia.org/54212 normal; MediaWiki extensions: MobileFrontend; () [07:26:27] jeremyb: hehe :P [07:26:30] jeremyb: i'm in bed [07:26:33] supposed to be not on IRC [07:27:06] YuviPanda: well, were you answering a question at the bar? editing? [07:27:19] jeremyb: we just were looking random stuff u [07:27:20] p [07:27:24] and ran into a bug [07:27:29] *the [07:27:35] was there a bet? [07:27:46] no comment [07:27:46] :P [07:27:55] boring! [07:28:02] * jeremyb sleeps and YuviPanda should sleep too!! [07:28:05] bye [07:28:17] jeremyb: nite [07:36:40] awjr: errrrr, that formatting in mingle sucks. (no line breaks??) [07:36:53] good thing i don't have to use mingle! :P [07:40:38] jeremyb: fwiw, arthur filed a bug too as soon as he got back: https://bugzilla.wikimedia.org/show_bug.cgi?id=54209 [07:48:03] jeremyb: you mean the bugzilla bugs that get imported to mingle? [07:49:10] the formatting is indeed nasty; i wonder if mingle disregards \n characters [07:51:25] jeremyb: ps i'm pretty sure that bug is related to the zero extension rather than mobilefrontend [08:13:32] (03PS1) 10Yurik: bug 54212 - Zero URLs are leaking in non-zero mobile sites [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/84497 [08:18:16] YuviPanda, around? [08:18:23] surprisingly! :D [08:18:26] hmm [08:18:37] sticking to the original TZ :) [08:18:43] hehe :P [08:18:55] want merging? :P [08:18:57] i fixed the bug i think, but can't find any ops [08:18:59] sure [08:19:20] I can't do deploy [08:19:39] i wouldn't want to do a depl when everyone is asleep - better half-working site than me messing up something and no ops to hold my hand [08:19:54] i can deploy, that's not an issue [08:20:06] but if sync [08:20:10] hehe [08:20:15] looking at code now [08:20:18] fails midway, and there needs to be some magic root access [08:20:43] yuri_k: I see a bunch of getConfig calls without a null check [08:20:47] onMinervaPreRender [08:20:52] onGetMobileNotice [08:21:03] oh [08:21:04] nevermind [08:21:06] i can't read [08:21:07] grr [08:21:32] YuviPanda, such is life... there ain't no stinking checks [08:21:35] yuri_k: I can merge if you want me to :) [08:21:38] sure [08:21:41] thx [08:21:54] (03CR) 10Yuvipanda: [C: 032] "Look sane!" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/84497 (owner: 10Yurik) [08:21:55] done [08:21:56] (03Merged) 10jenkins-bot: bug 54212 - Zero URLs are leaking in non-zero mobile sites [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/84497 (owner: 10Yurik) [08:22:06] yuri_k: heading to sleep now [08:22:17] YuviPanda, thx [08:22:19] gnight [08:56:36] jeremyb: fixed ;) [09:32:56] (03PS2) 10Addshore: split MobileTemplateWML into its own class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84345 [17:06:40] YuviPanda: where do Commons test build uploads go? I don't see them on commons nor test. [17:09:11] they should go to test... [17:10:48] MaxSem: which patches are you working on related to formatter? [17:10:53] can you link me to them? [17:12:01] (03CR) 10Alex Monk: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84466 (owner: 10Jdlrobson) [17:13:48] jdlrobson, https://gerrit.wikimedia.org/r/80578 [17:16:45] thanks MaxSem [17:29:10] (03PS1) 10Jdlrobson: Leave width of image rendering of infoboxes up to the template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84544 [17:31:33] YuviPanda: you about ? [17:37:53] (03CR) 10Brion VIBBER: [C: 031] "Sounds like this should do the job (havent' tested yet)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84544 (owner: 10Jdlrobson) [17:39:29] (03PS1) 10Yurik: Minor zero cleanup [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/84548 [17:41:05] brion: you about ? [17:41:36] mhurd: thanks for moving your stories over in https://trello.com/b/XkdTvW0Z/mobile-app-sprint-15 [17:41:46] tfinc: at home office atm, catching up before heading in [17:42:55] brion: can you move over which storys your working on in https://trello.com/b/XkdTvW0Z/mobile-app-sprint-15 ? [17:43:11] sure can [17:45:11] ok i'm packing up and heading in before any more bug mail can distract me :) [17:45:14] see ya in ~45min [17:47:02] awjr_away: can you approve my mail to teampractices ? [18:04:38] (03CR) 10MaxSem: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83837 (owner: 10Jdlrobson) [18:22:35] tfinc: looking now [18:22:36] tfinc: are you subscribed? [18:22:51] tfinc: msg approved [18:23:16] tfinc: i dont see you in the membership for the list [18:23:42] ah nm there you are - i wonder why your email got trapped [18:27:51] (03PS1) 10Kaldari: Using our own copyright i18n message for mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84558 [18:44:22] awjr: thanks [18:45:25] (03PS4) 10Yuvipanda: Use a SyncProvider to sync all Campaigns [apps/android/commons] (campaigns) - 10https://gerrit.wikimedia.org/r/83045 [18:45:30] brion: ^ is complete-ish [18:45:35] \o/ [18:45:38] brion: we can't really handle deletes and renames properly yet [18:45:43] but i think that's a tradeoff we can make for now [18:45:45] ok [18:45:54] brion: the UI also sucks majorly :P [18:46:00] hehe [18:47:12] brion: i'm going to fix shareactivity now, so you can actually contribute [18:47:19] awesomesauce [18:50:02] [13Commons-iOS] 15brion closed pull request #119: Better formatting for Information template (06master...06information-format) 02http://git.io/k2MSpQ [18:50:04] (03CR) 10Dr0ptp4kt: [C: 032] "It doesn't break anything locally." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/84548 (owner: 10Yurik) [18:50:09] (03Merged) 10jenkins-bot: Minor zero cleanup [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/84548 (owner: 10Yurik) [18:52:24] jcmish, the negative test string for hyperlinks is renderZeroRatedRedirect . the positive test would be to see that links with class 'external' do not point to the same domain - be sure to check for protocol relative (//) and http:// and https:// … just extract the domain name component. [18:54:39] jcmish, for images, the negative test case is to look for a span like the following: Click to view image of, "hair.jpg"... the title attribute should END with case-insensitive png|gif|jpg|jpeg|svg. the positive test case would be to look for an tag, and when the with a corresponding is found, follow that thing, and see if it results in an image on [18:54:39] upload.wikimedia.org [18:55:12] jcmish, here are the other telltale negative tests for identifying whether ZeroRatedMobileAccess is running in the wrong context: [18:55:48] ^jcmish look for spans of this form: [18:57:24] mhurd: can you mail out and mention that we added the auto layout storys yesterday ? [18:58:05] ^jcmish or this form: div id="zero-landing-page"> [18:58:15] ^jcmish, sorry if unbalanced DIV tags [18:59:35] tfinc: ya! [19:03:22] tfinc: done! [19:05:52] (03PS2) 10Jdlrobson: Leave width of image rendering of infoboxes up to the template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84544 [19:32:21] brion, why do we have both https://www.mediawiki.org/wiki/MobileFrontend and https://www.mediawiki.org/wiki/Extension:MobileFrontend ? [19:32:24] awjr_away, ^ [19:40:37] jgonera: probably we should merge them :D [19:41:20] brion, I want to create a separate page for coding guidelines, should I go for /MobileFrontend/Coding_Guidelines or /Estension:MobileFrontend/Coding_Guidelines? [19:41:30] s->x [19:41:44] everything to Extension:MobileFrontend says i [19:42:49] I see [19:49:19] brion: this may be useful: http://stackoverflow.com/questions/6395132/cabasicanimation-with-5-images [19:52:49] FUCKING MOTHERFUCKER APPLE FUCK YOU APPLE FUCK YOU IN THE EAR [19:56:36] ??? Brion? [19:57:08] code signing [19:58:36] there, got it working somehow [19:58:42] not really sure how [20:02:55] jgonera: i think one was intended to be more WMF-centric (MobileFrontend) and the other more generic, extension-focussed (Extension:MobileFrontend) - but those pages existed beforei i joined the team so im not totally sure [20:03:40] awjr, brion, kaldari says that one is a project page and the other extension page and that we could possibly rename the project one to MobileWeb [20:03:55] mmmmm could do [20:04:44] jdlrobson: or jgonera when we are live on en.m can you test https://mingle.corp.wikimedia.org/projects/mobile/cards/1073. I "think" we were relaying on a deploy from platform to go along with it? [20:04:46] jgonera: i like that idea, we already have https://www.mediawiki.org/wiki/Mobile_web/Team but nothing on the root (Mobile_web) page; perhaps this is something we can discuss more during our team quarterly planning stuff on thursday [20:05:23] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84466 (owner: 10Jdlrobson) [20:06:33] (03PS2) 10Jdlrobson: Redirect to talk page when liquid threads enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84466 [20:11:06] awjr: got another mail blocked in the review queue of team practices [20:11:11] * awjr grumbles [20:11:17] can you set all wikimedia.org mails to auto pass ? [20:11:36] is it possible to do that in mailman? [20:12:19] (03PS2) 10Jdlrobson: Stop refreshing page on a hash change [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84420 [20:13:01] (03CR) 10Jdlrobson: [C: 04-1] "Talking to Juliusz we should change getState to set a url rather than an id to avoid this confusion (it would also be confusing to do getS" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84420 (owner: 10Jdlrobson) [20:16:41] updates should be on https://test.m.wikipedia.org/ now [20:17:03] jdlrobson, jgonera, jcmish, awjr: ^ [20:17:15] w000t [20:18:52] on it [20:19:22] heyo! [20:24:01] testing complete. looks good to me kaldari [20:24:26] yay [20:25:20] article creation seems to work in alpha [20:27:27] (03CR) 10Jdlrobson: "I still need to review it too ;-).." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83943 (owner: 10JGonera) [20:29:30] automation tests are good [20:32:13] jgonera: what was that change? [20:32:33] kaldari, https://gerrit.wikimedia.org/r/#/c/84467/ [20:32:50] but it's possible that simply desktop chrome behaves slightly differently than android [20:34:41] do we only show article namespace pages in the watchlist? [20:34:47] jgonera, jdlrobson, kaldari ^ [20:35:04] awjr: in a-z view? [20:35:13] yeah [20:35:17] kaldari, no, something's wrong, mw.mobileFrontend.isTestA = true has different result for the A/B test on my local instance and on testwiki [20:35:21] (i know you can find them in 'modified' view) [20:35:35] when it's true it shows the tutorial on my local instance but it goes directly to the editor on testwiki [20:35:39] awjr: yes that's always been the case [20:35:42] k [20:35:44] we've talked about copying over the tabs [20:36:50] jgonera: The new code was successfully deployed to tin [20:36:54] for that change [20:37:01] tin? [20:37:04] I'll touch the files and re-sync to testwiki [20:37:08] oh, that's the server [20:37:16] ok, let's try that [20:38:25] jgonera: touched and re-sycned to test.wiki [20:39:48] jgonera: https://test.wikipedia.org/w/static-1.22wmf17/extensions/MobileFrontend/javascripts/modules/editor/editor.js [20:40:07] looks up to date [20:43:02] im getting 503 errors trying to edit on testwiki (although it seemed to work fine for me a few minutes ago) [20:43:30] anybody else seeing that? [20:43:40] haven't seen that [20:43:43] what article? [20:43:48] awjr: was it a big article just like last time? [20:43:53] might just be testwiki being flakey [20:44:00] we've identified this problem before with large articles [20:44:00] it's san francisco article [20:44:09] awjr: yeh you reported that last deployment ;-) [20:44:10] i expect the 503 error is not related to our code [20:44:10] yes, we've run into this like 3 times already ;) [20:44:11] oh [20:44:12] lol [20:44:15] it's only testwiki [20:44:19] im glad you have a better memory than me. [20:44:51] yeah, editing smaller articles is fine for me [20:45:13] fine for me too [20:45:14] i'll uh… be sure to remember for next time :p [20:46:06] jcmish: Clear for further deployment to the rest of the wikis? [20:46:10] k I say we're good [20:46:12] yup [20:47:47] (03PS12) 10Jdlrobson: Hygiene: Simplify formatter HTML [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83837 [20:47:51] kaldari: if you're discovering anything undocumented as you're deploying that hsould be documented, please add to https://wikitech.wikimedia.org/wiki/MobileFrontend/Deployment :) [20:48:04] or anything that's out of date, for that matter [20:48:35] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Simplify formatter HTML [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83837 (owner: 10Jdlrobson) [20:55:08] ready for scap? [20:56:37] scap away! [21:06:21] jgonera: when desktop enables a new echo wiki do we pick it up for free ? [21:06:43] tfinc, that should be the case, yes [21:07:00] thanks [21:07:12] ok i've found a workaround for that cross-fade bug on iOS 7 [21:07:13] yayy [21:07:33] monte should be able to take care of the rest of the minor iOS 7 issues soon [21:07:34] brion: can I haz merge? [21:07:41] brion: to be more accurate, can I haz code review? :D [21:07:43] YuviPanda: momentarily :D [21:08:06] brion: alright :) [21:08:10] YuviPanda: https://gerrit.wikimedia.org/r/#/c/83045/ right? [21:08:24] indeed brion [21:08:28] spiff. looking now [21:08:53] (03PS13) 10Jdlrobson: Hygiene: Simplify formatter HTML [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83837 [21:21:24] (03CR) 10Kaldari: [C: 04-2] "Waiting for feedback from legal." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84558 (owner: 10Kaldari) [21:36:34] scap's finished [21:36:37] please test on en.wiki [21:36:41] kayo [21:37:01] awjr, jdlrobson, jgonera: ^ [21:37:11] w00t [21:37:52] (03CR) 10Brion VIBBER: "Hmm... I've opened up the Campaigns view and I see..... an empty list." [apps/android/commons] (campaigns) - 10https://gerrit.wikimedia.org/r/83045 (owner: 10Yuvipanda) [21:38:26] (03CR) 10Yuvipanda: "Need to turn the campaign provider on by default. I'll do that in a followup patch. you can turn it on manually for this, perhaps?" [apps/android/commons] (campaigns) - 10https://gerrit.wikimedia.org/r/83045 (owner: 10Yuvipanda) [21:40:08] (03PS5) 10Jdlrobson: Collapse on h1s when present [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83931 [21:42:02] (03CR) 10Brion VIBBER: "Ugh. Ok testing..." [apps/android/commons] (campaigns) - 10https://gerrit.wikimedia.org/r/83045 (owner: 10Yuvipanda) [21:42:14] brion: even clicking on things does... nothing [21:42:16] yet [21:42:20] there's nothing to hook them to [21:42:26] hehe [21:42:30] ok let's fix those up later then :D [21:42:33] yeah [21:42:55] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok we'll fix those things up in later commits. Whee!" [apps/android/commons] (campaigns) - 10https://gerrit.wikimedia.org/r/83045 (owner: 10Yuvipanda) [21:42:58] kaldari: is this the correct license text for enwiki? https://creativecommons.org/licenses/by-sa/3.0/ [21:43:20] im getting JS errors on enwiki in stable [21:43:38] on the main page, im getting 2 errors: [21:43:39] . Uncaught TypeError: Object #