[11:23:06] (03PS1) 10Yuvipanda: Turn on Campaigns Sync by default [apps/android/commons] (campaigns) - 10https://gerrit.wikimedia.org/r/85654 [13:51:39] (03CR) 10Siebrand: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76271 (owner: 10Jdlrobson) [16:20:47] microsoft announcing updated surface tablets: http://arstechnica.com/gadgets/2013/09/microsofts-hardware-round-2-surface-2-and-surface-pro-2/ [16:21:06] honestly the only thing i want out of Windows 8.1 RT is "allow running unsigned desktop applications on ARM" [16:21:13] wish they'd announce that [16:21:35] at least they bumped up the screen resolution on the ARM version [16:23:36] YuviPanda: back on high-latency internet? :) [17:00:23] (03PS1) 10Orsagi: release candidate [apps/android/translate] - 10https://gerrit.wikimedia.org/r/85684 [17:01:43] (03CR) 10Orsagi: [C: 032 V: 032] release candidate [apps/android/translate] - 10https://gerrit.wikimedia.org/r/85684 (owner: 10Orsagi) [17:02:12] jdlrobson: standup! [17:02:43] jcmish: ^ [17:02:49] arghgh [17:02:53] sorry sumanah distracted me [17:02:55] anyone in the office see juliusz and/or kaldari? [17:03:12] brion: ^ [17:03:12] I'm coming having video issues [17:03:24] ok if you're audio only it's ok jcmish [17:03:27] i'm still at the home office [17:09:11] (03PS3) 10Jdlrobson: Hygiene: Refactor page.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85141 [17:09:44] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Refactor page.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85141 (owner: 10Jdlrobson) [17:11:25] (03PS1) 10Brion VIBBER: Fixes for moving HtmlFormatter class to core [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85685 [17:11:49] (03CR) 10jenkins-bot: [V: 04-1] Fixes for moving HtmlFormatter class to core [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85685 (owner: 10Brion VIBBER) [17:12:32] bah have to update tests [17:16:09] jcmish: https://gerrit.wikimedia.org/r/85347 and less important but https://gerrit.wikimedia.org/r/85138 [17:16:31] awjr: i suspect the bugs in awaiting final code review are not in priority order [17:16:47] k thanks jdlrobson [17:16:53] i'd say https://gerrit.wikimedia.org/r/85347 is top priority but it's right at the bottom [17:16:54] I'll take a look at the today [17:17:14] jdlrobson: they should be in the same priority order in which they were added to 'ready for dev' but that doesn't necessarily mean they are in actual priority order relative to one another now [17:17:21] jdlrobson: get kenan to take a look [17:17:38] i'll wait for him to come in on irc [17:17:45] you may be waiting for a bit :) [17:17:51] awjr: well the problem is bugs don't seem to be getting prioritized at all [17:17:58] they just come in and go straight into ready for development [17:18:01] YuviPanda: hey you joining? [17:18:07] lemme see if i can get him on [17:18:11] kenanwang: yet just talking about you - ping me when you're ready [17:18:16] ah there he is [17:18:21] (i assume you have a meeting now with YuviPanda ;-)) [17:18:30] apps standup [17:19:22] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85141 (owner: 10Jdlrobson) [17:22:55] jgonera: can you quickly recheck i didn't screw up the rebase and +2 ? https://gerrit.wikimedia.org/r/#/c/85141/3 [17:23:11] (03CR) 10Brion VIBBER: [C: 04-2] "Max prefers to do this in a way that'll be compatible with both pre- and post-merge versions of core, so he should have another patch comi" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85685 (owner: 10Brion VIBBER) [17:23:51] (03CR) 10Jdlrobson: [C: 04-1] "needs rebasing now..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85270 (owner: 10JGonera) [17:24:14] brion: the super annoying thing is over the weekend i came up with like 3 variations on that custom button object, and they worked great… just not in ios7 [17:24:22] d'oh [17:24:29] (03CR) 10Jdlrobson: [C: 032] "seems a friendlier way to say rebase ;-)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85270 (owner: 10JGonera) [17:24:31] (03CR) 10jenkins-bot: [V: 04-1] Update templates to contain new mobile edit links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85270 (owner: 10JGonera) [17:25:25] brion: it was def one of those cases i wished i had full source access :( [17:25:41] brion: too much mystery [17:26:05] :( [17:26:11] (03CR) 10Jdlrobson: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85301 (owner: 10JGonera) [17:26:22] you can always decompile the framework libraries! debugger to the rescueeeee [17:27:08] jdlrobson: wanna talk to me? [17:27:19] (03CR) 10JGonera: [C: 032] Hygiene: Refactor page.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85141 (owner: 10Jdlrobson) [17:27:20] hey kenanwang yeh [17:27:30] i just noticed that bugs in mingle don't seem to get prioritised [17:27:43] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Refactor page.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85141 (owner: 10Jdlrobson) [17:27:57] specifically according to our story board #1247 is the lowest priority [17:28:04] but i'd argue it is the highest priority kenanwang [17:28:11] since it's broken behavior in stable that used to work [17:28:41] (although maybe mobile captcha support is of higher important) [17:28:48] but either way prioritization doesn't seem to be accurate [17:28:59] also was hoping to do a quick bug triage kenanwang for those 3 bugs [17:29:49] (03PS2) 10Kaldari: Un-hardcoding About and Disclaimer links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84472 [17:30:12] (03CR) 10jenkins-bot: [V: 04-1] Un-hardcoding About and Disclaimer links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84472 (owner: 10Kaldari) [17:30:13] kenanwang: ping me when you are back ;-) [17:30:23] wtf is going on with jenkins MaxSem [17:30:25] jdlrobson: looking at the bug. [17:30:36] https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-testextensions-master/2378/console : FAILURE in 3s [17:30:36] jdlrobson, upgrade? [17:30:49] PHP Fatal error: Call to undefined method MobileFormatterHTML::removeImages() in /srv/ssd/jenkins-slave/workspace/mwext-MobileFrontend-testextensions-master/extensions/MobileFrontend/includes/api/ApiParseExtender.php on line 80 [17:31:02] * jdlrobson waves at kaldari  [17:31:08] jenkins seems to be misbehaving kaldari [17:31:54] (03PS3) 10Kaldari: Un-hardcoding About and Disclaimer links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84472 [17:32:17] (03CR) 10jenkins-bot: [V: 04-1] Un-hardcoding About and Disclaimer links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84472 (owner: 10Kaldari) [17:32:24] jdlrobson, ah. result of core migration, already working on that one:) [17:32:35] MaxSem: cool :) [17:32:41] jdlrobson: I'm going to prioritize the stories in awaiting code review. Let's talk about how this works more generally and yes we should do a quick triage. [17:32:56] cool so you want to do quick triage now kenanwang - shouldn't take long [17:33:05] jdlrobson, MaxSem: Should I just remove jenkins from that patch review for now? [17:33:07] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85141 (owner: 10Jdlrobson) [17:33:15] kaldari: do a recheck [17:33:19] seems to work [17:33:40] a recheck? [17:33:46] jdlrobson: sure how do you wanna do? [17:33:59] ok so first bug is https://bugzilla.wikimedia.org/show_bug.cgi?id=53667 [17:34:08] kaldari: if you reply recheck jenkins tries again [17:34:21] awjr: how do I reorder cards in mingle? [17:34:27] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84472 (owner: 10Kaldari) [17:34:32] kenanwang: you should be able to drag them - if not ask arthur [17:34:34] awjr: ^ [17:34:44] yeehaw! [17:34:51] kenanwang: i'll let you read bug first - let me know if you have any questions you need answers to before prioritising [17:34:53] jdlrobson: that was magical [17:35:21] (03CR) 10Jdlrobson: [C: 032] "merge attempt #3 ! bad jenkins!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85141 (owner: 10Jdlrobson) [17:35:34] kaldari: hehe [17:35:45] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Refactor page.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85141 (owner: 10Jdlrobson) [17:36:03] grrrr jenkins stop sucking [17:36:11] ^ MaxSem how do we deal with this since we can't force merge? [17:36:25] 1 sec [17:36:53] why can't you force merge? [17:37:16] you can just remove jenkins as a reviewer [17:38:26] jcmish: thanks for the links [17:38:53] jdlrobson: just click the (x) next to 'jenkins-bot' [17:39:12] have we been able to reproduce that last bug/ [17:39:13] ? [17:39:18] kaldari: but we don't have verified [17:39:33] kenanwang: i've seen certain cases where i've hit desktop instead of mobile [17:39:33] oh yeah, shit :) [17:39:37] whether related or not i don't know [17:39:45] Krinkle disabled it kaldari [17:40:03] jdlrobson: i mean 1249 the language selector issue [17:40:08] (we did ok that ;-) - just never ran into this issue) [17:40:19] Bad Jenkins! Bad! [17:40:25] kenanwang: oh you want to look at that bug hey? what's the decision on the other one? [17:40:37] 17:35:37 PHP Fatal error: Call to undefined method MobileFormatterHTML::removeImages() in /srv/ssd/jenkins-slave/workspace/mwext-MobileFrontend-testextensions-master/extensions/MobileFrontend/includes/api/ApiParseExtender.php on line 80 [17:40:42] the other bug is easily reproducible yes [17:40:55] Krinkle: yeh but that is being thrown by something not touching php [17:41:04] tough [17:41:08] and it didn't complain when we +2ed the previous change that [17:41:22] I don't know the tests [17:41:31] but that exception doesn't lie [17:41:52] presumably another change got merged first (either in meidawiki core or in mobilefrontend) [17:42:01] and now mf is failing when this change is applied. [17:42:20] does it work locally on latest master of mf and core? [17:42:23] probably not [17:43:14] Krinkle: i think MaxSem's core change broke it but this is not the point here - whilst Max fixes that we have no way of merging our other code which is slightly irritating [17:43:23] tfinc: you bet… sorry I was digging around to find the one Chris created [17:43:26] so it took a bit [17:43:43] bleh, still looking for the best solution [17:43:55] 1151 fix with higher priority, 1195 won't fix (question here is this a title that usually has a prefix on desktop and we strip it? I ask because I'd agree with jared that we should default to stripping out the prefix when it's not confusing), 1249 fix with low priority, [17:43:55] jcmish: yup. i figured we has something like that but i coudln't find it [17:44:01] jdlrobson: ^ [17:44:06] ha me neither :D [17:44:08] It's not new that broken tests should be fixed before other changes can be merged, we've had that for about a year now. The only difference is that this is cross-repository, so the core change unit tests didn't fail pre-merge. [17:44:20] ken an can you respond on the bug for 1195 and close it? [17:44:32] This is broken because the method got renamed in core, and mf is still using the old method name [17:44:38] MaxSem: ^ [17:44:44] kenanwang: do you want to move the others across to ready for development and rejig the priority order? [17:44:51] Krinkle: yes we know all this. [17:45:03] Krinkle: the issue is we are twiddling our thumbs on code review now because we can't merge anything else [17:45:27] ah, 1.18 is already branched [17:45:35] Krinkle: is there any way core changes can also trigger MobileFrontend tests in certain cases or do we have to live with that? [17:45:36] wmf18 [17:45:45] then I'll go the easiest way [17:45:52] and use brion's patch [17:45:58] jdlrobson: Are you blocking on a deployment though? Unless that is the case, just merge it later. the +2 is recorded, just move on and pretend it is merged in your mind. [17:46:16] whee [17:46:17] mf master is broken and can't be deployed now anyway, so I don't think anything is being blocked. [17:47:13] jdlrobson: still unsure how to reorder cards. I'm asking arthur but I'm moved them over and they're in roughly correct order... [17:47:29] Krinkle: yes but lots of patches are going to cause merge conflicts with each other - so i can't pretend they are merged in my mind [17:47:33] kenanwang: great [17:48:19] jdlrobson: I don't see how there would be more or less merge conflicts with or without this being merged. [17:48:20] MaxSem: any quick fixes for time being? [17:48:29] Whether you rebase it on commit X in master or commit X in gerrit, same thing? [17:48:46] is the problem that the formatter changes were merged to core? [17:48:51] MaxSem: could revert the core change...? [17:49:38] afaik there's at least one other patchset dependent on the core change [17:49:42] from another extension [17:49:55] ah but that other change hasn't been merged yet (https://gerrit.wikimedia.org/r/#/c/85135/) [17:50:01] jdlrobson, can we merge https://gerrit.wikimedia.org/r/#/c/84913/ ? [17:50:02] (03CR) 10Jdlrobson: [C: 032] "Ok.. I'll raise the bug then." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84913 (owner: 10JGonera) [17:50:13] oh ;) [17:50:23] that was fast [17:50:23] do we not have a patchset in MF that makes MF compatible with the core change? [17:50:25] (03CR) 10jenkins-bot: [V: 04-1] Redirect &action=edit§ion=X to mobile editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84913 (owner: 10JGonera) [17:50:32] MaxSem: awjr: htmlformatter::removeimages got renamed during code review, just fix the call in mf? [17:50:41] jgonera: my review is blocked until core change is fixed [17:50:45] i can't test anything [17:50:51] ? [17:51:07] fucking gerrit [17:51:28] jgonera: read upwards [17:52:02] (03PS2) 10MaxSem: Fixes for moving HtmlFormatter class to core [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85685 (owner: 10Brion VIBBER) [17:52:10] here we go [17:52:26] whee [17:52:57] (03CR) 10MaxSem: [C: 032] Fixes for moving HtmlFormatter class to core [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85685 (owner: 10Brion VIBBER) [17:53:00] MaxSem, brion is that patchset intended to fix things for now with a followup for b/c? [17:53:14] it's a permafix [17:53:42] jgonera: https://bugzilla.wikimedia.org/show_bug.cgi?id=54475 [17:54:12] :D yeah that looks good [17:54:33] thx [17:54:37] MaxSem: ok so this version *does* require the updated core. is that as intended? [17:54:54] yup [17:55:08] ok [17:55:11] well that simplifies things :D [17:55:23] decided that 2 cherrypicks is easier than all that cruft [17:55:51] (03CR) 10Brion VIBBER: [C: 032] "Ok, this version *does* require the updated core, but it's easier to update the core than to maintain the back/forward-compat. :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85685 (owner: 10Brion VIBBER) [17:56:54] (03Merged) 10jenkins-bot: Fixes for moving HtmlFormatter class to core [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85685 (owner: 10Brion VIBBER) [17:57:03] \o/ [17:59:19] (03CR) 10Jdlrobson: "https://bugzilla.wikimedia.org/show_bug.cgi?id=54475 explains the bug that this creates." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84913 (owner: 10JGonera) [17:59:41] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84913 (owner: 10JGonera) [18:00:09] (03CR) 10Jdlrobson: "attempt #4" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85141 (owner: 10Jdlrobson) [18:00:39] (03CR) 10Jdlrobson: "try again jenkins" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84913 (owner: 10JGonera) [18:01:33] jcmish: jgonera could you both review https://gerrit.wikimedia.org/r/85347 as soon as you can - i'd like us to restore the uploads tutorial for new users before tomorrow [18:05:12] jdlrobson: you updated the title of https://mingle.corp.wikimedia.org/projects/mobile/cards/1140 but there's no detail about what the block is - can you elaboratE? [18:06:00] awjr: i was waiting for kaldari to come along [18:06:11] kaldari: can you explain why the above story is blocked on the card? i remember you saying it was last wek [18:07:04] jdlrobson: I'm already pulling it down to check the test on betalabs [18:07:15] thanks jcmish :) [18:07:40] (03CR) 10Awjrichards: [C: 032] Redirect &action=edit§ion=X to mobile editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84913 (owner: 10JGonera) [18:08:17] (03Merged) 10jenkins-bot: Redirect &action=edit§ion=X to mobile editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84913 (owner: 10JGonera) [18:08:47] you betcha [18:08:56] jdlrobson: Still waiting on +2 for https://gerrit.wikimedia.org/r/#/c/83575/ [18:10:05] kaldari: do i understand correctly that there's no b/c for 1140? if so we'll have to be careful about deploying the feature and possibly cherry-pick echo changes [18:10:42] "b/c"? [18:11:10] (03CR) 10JGonera: [C: 031] Regression:Restore the First time user uploads tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85347 (owner: 10Jdlrobson) [18:11:17] kaldari: sorry, backwards compatability [18:11:24] (03CR) 10Jdlrobson: "attempt #5" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85141 (owner: 10Jdlrobson) [18:11:37] (03CR) 10JGonera: "LGTM, but letting Michelle have a look too." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85347 (owner: 10Jdlrobson) [18:11:47] jdlrobson: can you update https://bugzilla.wikimedia.org/show_bug.cgi?id=53802 since your change was merged? i think it didn't auto-update since the message is missing the bug: # at the end [18:12:10] awjr: don't worry i will - i tend to these in big goes - in meantime i'm trying to sort out jenkins [18:12:19] awjr: Ideally we would want to deploy the Echo changes a week before the MobileFrontend changes to minize the risk. [18:12:46] awjr: The MobileFrontend changes are -2ed in the meantime: https://gerrit.wikimedia.org/r/#/c/82073/ [18:12:57] kaldari: ok perfect kaldari [18:13:56] kaldari: also look like benny updated https://gerrit.wikimedia.org/r/#/c/83575/ and gave you the goahead to merge, if you like :) [18:14:17] ah cool [18:15:36] (03PS16) 10Awjrichards: Various improvements to mobile notifications... [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 (owner: 10Kaldari) [18:15:40] (03CR) 10jenkins-bot: [V: 04-1] Various improvements to mobile notifications... [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 (owner: 10Kaldari) [18:19:12] jdlrobson, not sure which patch did that but I think we have a rather serious regression - main edit icon always opens editor for section 1 for me even if there is a lead section. can you confirm? [18:20:12] (03PS4) 10Awjrichards: Hygiene: Refactor page.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85141 (owner: 10Jdlrobson) [18:21:09] (03PS2) 10JGonera: Update templates to contain new mobile edit links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85270 [18:22:00] (03CR) 10Awjrichards: [C: 032] "Needed rebase, tests pass and did a quick local test - lgtm" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85141 (owner: 10Jdlrobson) [18:22:21] jdlrobson, the formatter, there's no content_0 now right? [18:22:27] (03Merged) 10jenkins-bot: Hygiene: Refactor page.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85141 (owner: 10Jdlrobson) [18:22:40] jgonera: correct there is M.getLeadSection instead [18:22:55] (will look at the regression you reported in a minute [18:23:00] no, but I need to know if lead section is section 0 or not, see editor.js [18:23:14] ok, it's editor.js L75 [18:25:49] jdlrobson, also, I noticed a weird bug where editor preview shows an "Edit" word at the end of each heading [18:26:07] jgonera: there's a bug open for that [18:26:08] (03PS3) 10Jdlrobson: Stop refreshing page on a hash change [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84420 [18:26:12] (03CR) 10jenkins-bot: [V: 04-1] Stop refreshing page on a hash change [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84420 (owner: 10Jdlrobson) [18:26:20] jgonera: https://bugzilla.wikimedia.org/show_bug.cgi?id=54243 [18:27:01] jdlrobson, doesn't seem to be related [18:27:11] why not? [18:27:16] is it editor javascript kicking in? [18:28:18] so jgonera yeh i see the same edit issue [18:28:21] should be an easy fix [18:28:24] looking at it now [18:28:26] no, doesn't seem so [18:28:27] ok [18:29:33] got a fix jgonera [18:30:41] (03PS1) 10Jdlrobson: Regression: Ensure clicking main edit button opens lead section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85695 [18:30:45] ^ jgonera [18:32:18] jgonera: so can replicate the word edit bug - doesn't seem to be in preview so guess something is going on in our javascript [18:32:45] doesn't seem to be in preview? [18:33:44] found the problem jgonera [18:34:22] (03PS2) 10JGonera: Hide toasts and drawers when tapping in overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85301 [18:35:34] (03CR) 10MaxSem: [C: 032] Un-hardcoding About and Disclaimer links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84472 (owner: 10Kaldari) [18:35:57] (03Merged) 10jenkins-bot: Un-hardcoding About and Disclaimer links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84472 (owner: 10Kaldari) [18:36:58] (03PS1) 10Jdlrobson: Regression: Fix extraction of section heading in preview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85697 [18:36:59] (03CR) 10JGonera: [C: 032] Regression: Ensure clicking main edit button opens lead section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85695 (owner: 10Jdlrobson) [18:37:31] jdlrobson, for some reason, when I save an edit, the page doesn't get refreshed, I get an infinite spinner, do you also get that? [18:37:45] (03CR) 10Jdlrobson: [C: 032] "That works too :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85301 (owner: 10JGonera) [18:37:48] jdlrobson, tis https://gerrit.wikimedia.org/r/#/c/76271/ ready from your FE POV? [18:38:03] umm… alpha or beta jgonera ? [18:38:04] (03Merged) 10jenkins-bot: Regression: Ensure clicking main edit button opens lead section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85695 (owner: 10Jdlrobson) [18:38:39] (03Merged) 10jenkins-bot: Hide toasts and drawers when tapping in overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85301 (owner: 10JGonera) [18:38:47] MaxSem: it will need some minor follow ups but yes it's good to go :) [18:39:44] although Max it does need a rebase [18:39:51] a big one :( [18:40:17] (03CR) 10JGonera: [C: 032] Regression: Fix extraction of section heading in preview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85697 (owner: 10Jdlrobson) [18:40:27] pfft. I've seen worse [18:40:47] (03Merged) 10jenkins-bot: Regression: Fix extraction of section heading in preview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85697 (owner: 10Jdlrobson) [18:40:51] in RUSSIA REBASES rebase you! [18:41:00] ;-) [18:41:13] MaxSem: i'll look into that now [18:41:59] MaxSem: What does 'PHP LGTM' mean? [18:42:02] MaxSem, the preview api is borken [18:42:05] broken [18:42:39] kaldari, PHP Hypertext Processor [changes] Look Good To Me [18:42:51] ah :) [18:44:35] MaxSem, that's what I get every time after saving an edit: Fatal error: Call to undefined method MobileFormatterHTML::removeImages() in /home/jgonera/www/extensions/MobileFrontend/includes/api/ApiMobileView.php on line 219 [18:44:42] jdlrobson: we're going to need to create a different user for this test [18:44:57] (sorry, not preview API, just the mobile view API) [18:44:58] ugh, I thought I nailed them all... [18:45:04] Selenium_user has done uploads on betalabs and en.m.wiki [18:45:10] so we can't use it for this tests it'll fail [18:46:15] MaxSem, will you prepare a patch for this? [18:46:21] sure, sorry [18:46:23] ok [18:47:39] yay unit tests :) [18:48:18] (03PS2) 10JGonera: Prevent overlay header from covering button bars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85349 [18:49:31] (03PS1) 10MaxSem: More HtmlFormatter removal fixes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85699 [18:49:44] jgonera, ^^ [18:50:12] MaxSem: it broke in rebase so i'm fixing up now [18:50:20] jcmish: that's fine - are you able to take care of that? [18:50:34] jgonera: did you update core and mobilefrontend? [18:50:40] awjr, jdlrobson do we have the showcase today? [18:50:46] jdlrobson, yes, why are you asking? [18:50:59] jgonera: just ruling out the obvious for your fatal error :) [18:51:14] awjr: jgonera i hope showcase isn't today.. after last weeks craziness i feel that would be overkill [18:51:30] jcmish, awjr, MaxSem: Do we want to wait on having a unit test for this or is it OK to merge? https://gerrit.wikimedia.org/r/#/c/84466 [18:51:59] jdlrobson: afaik, tomasz didn't cancel it though i have no idea if he's planning to attend [18:52:14] kaldari, the UT depends on LQT so I say we shouldn't bother [18:52:30] jdlrobson, jgonera, brion, mhurd, YuviPanda, MaxSem, kaldari: do you have stuff to show off for the showcase? [18:52:41] nothing from me :( [18:52:47] * MaxSem scratches his head [18:53:03] not much to see no :) [18:53:04] awjr: my updates look mostly the same, just using auto layout under the hood [18:53:25] jgonera, YuviPanda anything you're particularly excited to show off? [18:53:37] if not, let's go ahead and cancel today's showcase [18:53:42] MaxSem, is the setRemoveMedia() still needed? just quickly checking [18:53:50] awjr: k [18:53:55] where? [18:54:00] awjr, not that much, possibly image viewer in alpha but it's small and can wait for the next one [18:54:36] ok jcmish, jgonera, MaxSem, jdlrobson, YuviPanda, mhurd, brion, kaldari let's cancel today's showcase [18:54:39] MaxSem, all over the place ;) grep -nr "setRemoveMedia" [18:54:45] i'll see if i can update the calendar event (i may not be able to) [18:54:51] ok [18:55:03] so why do you want to remove it?:) [18:55:25] (03CR) 10Kaldari: [C: 032] Redirect to talk page when liquid threads enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84466 (owner: 10Jdlrobson) [18:55:28] (03CR) 10jenkins-bot: [V: 04-1] Redirect to talk page when liquid threads enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84466 (owner: 10Jdlrobson) [18:55:29] MaxSem, just asking if it's also related to image removal [18:55:40] that's the new func [18:55:47] MaxSem, ok, I see [18:56:49] kaldari: it sound like a unit test won't actually work for this [18:56:51] so I'm good [18:56:52] (03CR) 10JGonera: [C: 032] More HtmlFormatter removal fixes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85699 (owner: 10MaxSem) [18:57:04] jcmish: cool [18:57:25] (03Merged) 10jenkins-bot: More HtmlFormatter removal fixes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85699 (owner: 10MaxSem) [18:57:35] MaxSem, it confused me because in MobileFormatterTest it's called in a function assigned to $removeImages [18:58:12] well, a unit test would work for that change but the patchset would need to be rewritten [18:58:19] jcmish, kaldari, MaxSem ^ [18:58:30] as much as i'd like to see it though, i'm fine merging the change for now [18:58:47] yeah the code doesn't look like it lends itself to unit tests [18:58:52] can we make a note to refactor it [18:58:54] and coping with it later after jcmish gets the coverage tools running and we can look at where best to put our unittesting efforts [18:58:58] on a code clean up day? [18:59:03] jcmish: as it is now, it doesn't - it would need to be rewritten [18:59:25] kaldari: can you add a FIXME comment? [18:59:26] k I'll keep track of it awjr [18:59:45] that reminds me awjr do I need to run code coverage on the PHP code as well? [18:59:53] we should jcmish [19:00:09] k do you know of any php code coverage tools offhand? [19:00:21] or should I check with the core folks and do some research? [19:00:41] phpunit has built in tools: http://phpunit.de/manual/3.7/en/code-coverage-analysis.html [19:01:15] and i remember oging to a talk once by sebastian where he was showing off some other tool he wrote for more advanced analysis [19:01:19] but i forget what it's called [19:01:21] jcmish: but i suggest checking with core folks before settling on something [19:01:33] k cool [19:01:37] I'll reach out to them thanks [19:01:43] thank YOU! [19:03:42] (03PS4) 10Kaldari: Redirect to talk page when liquid threads enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84466 (owner: 10Jdlrobson) [19:03:47] (03CR) 10jenkins-bot: [V: 04-1] Redirect to talk page when liquid threads enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84466 (owner: 10Jdlrobson) [19:03:50] (03PS9) 10Jdlrobson: Story 475: UserProfile special page (first pass) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76271 [19:04:40] (03PS5) 10Kaldari: Redirect to talk page when liquid threads enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84466 (owner: 10Jdlrobson) [19:04:43] awjr: FIXME added [19:04:44] (03CR) 10jenkins-bot: [V: 04-1] Redirect to talk page when liquid threads enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84466 (owner: 10Jdlrobson) [19:04:49] ty kaldari [19:05:10] (03CR) 10Kaldari: [C: 032] Redirect to talk page when liquid threads enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84466 (owner: 10Jdlrobson) [19:05:13] (03CR) 10jenkins-bot: [V: 04-1] Redirect to talk page when liquid threads enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84466 (owner: 10Jdlrobson) [19:05:45] (03CR) 10Jdlrobson: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85270 (owner: 10JGonera) [19:06:46] jgonera: i'm hitting the editor issue now as well. MaxSem are you looking into that- a few patches rely on the editor working :) [19:07:17] mmm "git pull origin hamster" that's one of my best typos [19:07:29] (03PS10) 10Jdlrobson: Collapse on h1s when present [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83931 [19:07:46] jdlrobson, pull the newest master [19:07:58] just did jgonera hadn't seen that [19:08:31] (03PS3) 10Jdlrobson: Prevent overlay header from covering button bars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85349 (owner: 10JGonera) [19:10:36] (03PS3) 10JGonera: Update templates to contain new mobile edit links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85270 [19:10:37] jdlrobson: did you see my note? [19:10:55] jcmish: in irc? [19:10:59] yessir [19:11:03] (03CR) 10JGonera: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85270 (owner: 10JGonera) [19:11:08] your tests will fail on prod and betalabs [19:11:15] errrrr about the user account one? [19:11:17] we need to create a user who's never done uploads [19:11:19] yeah [19:11:39] jdlrobson: jcmish: that's fine - are you able to take care of that? [19:11:41] so I can +2 BUT I'll need to make some code changes in the env file to usie this [19:11:59] yeah just wanted you to know it's going to fail and take me a bit to getting it working [19:12:31] jcmish: do you think you will be able to do it by 5? [19:12:44] or is it a several day job? [19:13:03] no not by 5pm [19:13:06] it's your call at the end of the day :-) - i just want to make sure it gets merged before code cut off [19:13:10] I need to finish stuff for the deploy [19:13:13] i can separate qa tests if you prefer [19:13:21] so yeah can you pull the qa tests [19:13:27] into a different commit [19:13:37] and then I'll pull it down and get the rest of the stuff done [19:13:53] sure will do that now jcmish [19:14:06] thanks [19:14:37] (03CR) 10JGonera: [C: 04-1] "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83931 (owner: 10Jdlrobson) [19:16:21] (03CR) 10Jdlrobson: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83931 (owner: 10Jdlrobson) [19:16:55] (03PS2) 10JGonera: Show proper button bar in editor on errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85320 [19:17:11] (03PS4) 10JGonera: Story 1163: Mobile Captcha support for editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85150 [19:17:34] (03PS4) 10JGonera: Clean up login/create account form and captcha CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85151 [19:19:21] jdlrobson: https://gerrit.wikimedia.org/r/#/c/84466/5 has a merge conflict that im afraid to resolve myself - can you take a look when you have a chance? [19:19:30] (03CR) 10Jdlrobson: [C: 032] Prevent overlay header from covering button bars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85349 (owner: 10JGonera) [19:19:39] awjr: i'm already on it.. [19:19:42] cool [19:20:10] (03PS6) 10Jdlrobson: Redirect to talk page when liquid threads enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84466 [19:22:30] ^ jcmish [19:22:37] (03PS3) 10Jdlrobson: Regression:Restore the First time user uploads tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85347 [19:22:37] whoops too early ;-) [19:22:38] (03PS1) 10Jdlrobson: QA: Add QA tests for I3f49cd50ed0c1778f8914b45cbc492fcc1775ca6 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85712 [19:22:43] ^ jcmish - there we go :) [19:22:50] danke [19:23:29] https://gerrit.wikimedia.org/r/#/c/84466/ < awjr or kaldari if you can take one quick pass over it [19:23:44] (03CR) 10Jdlrobson: [C: 031] "Rebased - hoping kaldari can just double check it one last time" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84466 (owner: 10Jdlrobson) [19:24:09] (03Merged) 10jenkins-bot: Prevent overlay header from covering button bars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85349 (owner: 10JGonera) [19:24:20] (03PS3) 10Jdlrobson: Improve nearby error handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84459 [19:24:43] lgtm but i can't easily test it as i dont have lqt setup/configured [19:24:45] (03CR) 10jenkins-bot: [V: 04-1] Redirect to talk page when liquid threads enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84466 (owner: 10Jdlrobson) [19:25:04] (03CR) 10Jdlrobson: [C: 032] Update templates to contain new mobile edit links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85270 (owner: 10JGonera) [19:25:21] awjr: i'll let kaldari take a look after lunch [19:25:22] jenkins doesnt like it, jdlrobson [19:25:25] yah [19:25:31] grr jenkins moans about everything [19:25:36] jdlrobson: jslint problem [19:25:44] ok this is legit ;-) [19:25:47] :p [19:27:19] (03PS7) 10Jdlrobson: Redirect to talk page when liquid threads enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84466 [19:27:29] awjr_lunch: well it works for me so happy for you/me to +2 but i'll give kaldari time to test it first [19:27:59] yah if kaldari can test against LQT that would be best [19:28:23] MaxSem: the profile stuff should be good to go now so up to you and jgonera to +2 [19:28:41] i'm then going to do a follow up which wires it up and a few design tweaks the designers want - but would be happy to get it out in the wild tomorrow [19:28:51] grrr, I'd better look at queries again [19:29:05] jdlrobson, is this alpha only for now? [19:29:11] awjr_lunch: who would I talk to about code coverage on the platform side? [19:29:58] jdlrobson, if you don't find the time to merge the captcha, it would be good to at least merge this: https://gerrit.wikimedia.org/r/#/c/85320/ it allows people to go back to their modified wikitext after saving failed [19:31:13] jgonera: i was just about to say this.. :) [19:31:27] heading to lunch now, after lunch my next priority for review is the captcha stuff (cc jgonera ) [19:31:35] ok, thanks [19:31:42] first i really need to eat :) [19:31:46] sure ;) [19:38:44] ok now.. food for realzz [20:07:36] awjr_lunch: jdlrobson-brb : did you guys end up doing a showcase today ? [20:09:25] brion: how is https://trello.com/c/lbBitujU/51-2-android-parse-out-license-data-from-wikitext going ? [20:10:09] tfinc: no, we cancelled it - i sent an email about it a bit ago [20:12:11] still behind where i want to be [20:13:27] awjr_lunch: k [20:14:46] brion: can YuviPanda help you with it ? [20:15:21] haven't seen YuviPanda online today, i think he's jet lagged. (he was online last night our time) [20:15:34] i'll ping him when i see him if i still need a push [20:30:53] (03CR) 10Kaldari: [C: 032] Redirect to talk page when liquid threads enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84466 (owner: 10Jdlrobson) [20:31:24] (03Merged) 10jenkins-bot: Redirect to talk page when liquid threads enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84466 (owner: 10Jdlrobson) [20:35:46] jdlrobson-brb, I disagree with https://gerrit.wikimedia.org/r/#/c/76271/9/includes/MobileFrontend.hooks.php - enabling the special page just for some users is fragile (e.g. users passing links to it to others). better just not link to it when not alpha [20:42:18] MaxSem: i've always found it extremely dangerous having special pages show up in stable [20:42:48] dangerous how? [20:42:49] i remember the nearby link got tweeted/went viral and there were some broken bits in it that made it look like it was broken even though complete [20:43:05] whether that is a good thing or not remains to be seen [20:43:18] jdlrobson: i'd say the thing to do is to have the special page check the mode and disable itself with a message explaining it's a beta or alpha feature [20:43:31] that way if someone does share the link, it's clear wtf is going on :D [20:43:39] brion: yeh that would be another suitable solution yes [20:43:42] MaxSem: what do you think? [20:43:51] agree with brion [20:43:57] ok i'll do that now then [20:44:12] \o/ [20:44:49] alternatively, we can just warn on non-stable pages that we don't guarantee anything [20:51:46] dr0ptp4kt, any thoughts on the patch? [20:51:59] yurik, reviewing [20:52:21] yurik, will be testing throughout afternoon [20:52:44] (03CR) 10Kaldari: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84459 (owner: 10Jdlrobson) [20:52:44] oki, i would like to get it out asap as i am traveling next week [20:52:52] (03PS10) 10Jdlrobson: Story 475: UserProfile special page (first pass) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76271 [20:53:37] jdlrobson: Do you prefer '-1' for agnostic questions/comments in gerrit or leaving the patches at '0'? [20:54:09] kaldari: -1 is more likely to get my attention [20:54:14] on the subject of the ' vs " [20:54:20] in our i18n file we seem to do /' [20:54:20] cool, same for me [20:54:28] but i'll change message [20:54:41] i think yours is better [20:54:58] that's fine [20:55:12] wow! yay on the less RFC brion, jdlrobson \o/ [20:55:13] we can revisit the '/'s in the i18n later [20:55:14] (03PS4) 10Jdlrobson: Improve nearby error handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84459 [20:55:54] (03CR) 10Kaldari: [C: 032] Improve nearby error handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84459 (owner: 10Jdlrobson) [20:56:18] jgonera: are you satisfied with the responses RE abusefilter or do you want to hear some more voices? [20:56:31] (03Merged) 10jenkins-bot: Improve nearby error handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84459 (owner: 10Jdlrobson) [20:56:56] jdlrobson: all the i18n people are asleep right now, but Reedy confirms that avoiding the '/' is preferred. [20:57:11] er '\' [20:57:15] kaldari: ok - can you add that to our docs so we don't do it in future? [20:57:27] https://www.mediawiki.org/wiki/MobileFrontend/Coding_conventions [20:57:33] will do [21:02:21] and if anyone has time, I also have a change to ZeroRatedMobileAccess that needs review: https://gerrit.wikimedia.org/r/#/c/85391/ [21:03:52] awjr, let me see again [21:05:26] awjr, that's probably enough. I still need to go over a patchset that Andrew Garret linked to in his private reply [21:05:38] ok cool thanks jgonera :) [21:07:29] (03CR) 10Siebrand: [C: 031] "L10n/i18n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76271 (owner: 10Jdlrobson) [21:07:37] awjr: what's more important - the captcha stuff or the zero stuff? [21:07:48] what's the zero stuff jdlrobson? [21:07:55] https://gerrit.wikimedia.org/r/#/c/85391/ [21:08:06] just curious as we never prioritize zero stuff and i wonder if we should [21:08:31] actually that link wasn't the one i was thinking of [21:08:35] but is another good example [21:09:44] basically https://gerrit.wikimedia.org/r/#/c/76201/ and https://gerrit.wikimedia.org/r/#/c/83133/ [21:09:53] kenan is the best one to answer that question; but in general we rarely do zero-specific stuff unless it's cleaning something up that we've done in MF. i would say unless it's an emergency we should be focussing on MF-specific stuff and let the zero folks manage priorities of zero-related code [21:10:24] ok and i guess any important work yuri_k and dr0ptp4kt should communicate to kenan they need our resources? [21:10:45] it's just on my list of things to review and i keep deprioritising it and feeling bad [21:10:53] jdlrobson: if they need dedicated resources they should probably communicate with tomasz and kenan [21:11:05] jdlrobson: I don't understand why you don't want to remove the height definition here as well: https://gerrit.wikimedia.org/r/#/c/84544/2/less/common/hacks.less [21:11:15] awjr: jdlrobson if zero needs more attention then dan needs to prioritize it [21:11:26] kaldari: well the max width is 100%... [21:11:31] he's the product owner and has to set when/what happens [21:11:42] if the zero team can't tackle it then he can talk to kenan [21:11:52] so say an image is registered as having size 600px by 400px but the container is only 300px width, the image will be scaled to 300px by 400px [21:11:54] jdlrobson: if you're particularly concerned about code review, that's up to you to figure out on your onw [21:11:55] *own [21:12:20] awjr: ok :) [21:12:28] but if its getting de-prioritized many of times and it hasn't become an issue then i'd question its importance over all [21:12:31] jdlrobson: ah, so the comment was just worded wrong. it should say "if the suggested width is more than 100%", not "less than 100%" [21:12:31] dr0ptp4kt: make sure you keep poking me with anything that i'm taking too long to review :) [21:13:08] ah yes good catch [21:13:27] (03CR) 10Kaldari: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84544 (owner: 10Jdlrobson) [21:13:30] feel free to fix up - i'm currently looking at juliusz's captcha patches - otherwise i can fix it up after [21:13:30] jdlrobson, my goal is to restructure zero at this point to start using ESI -- https://gerrit.wikimedia.org/r/#/c/85641/ (hopefully to go into production this week) [21:13:41] jdlrobson: sure, I'll fix [21:14:21] (03CR) 10JGonera: [C: 032] Regression:Restore the First time user uploads tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85347 (owner: 10Jdlrobson) [21:14:51] (03Merged) 10jenkins-bot: Regression:Restore the First time user uploads tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85347 (owner: 10Jdlrobson) [21:15:10] thanks kaldari [21:15:30] (03PS3) 10Kaldari: Leave width of image rendering of infoboxes up to the template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84544 (owner: 10Jdlrobson) [21:15:32] jgonera: https://gerrit.wikimedia.org/r/#/c/85270/ needs rebasing btw :( [21:16:02] I have just noticed, will do that in a moment [21:16:22] (03CR) 10Kaldari: [C: 032] Leave width of image rendering of infoboxes up to the template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84544 (owner: 10Jdlrobson) [21:16:33] ^ MaxSem profile code is sorted btw [21:16:48] (03Merged) 10jenkins-bot: Leave width of image rendering of infoboxes up to the template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84544 (owner: 10Jdlrobson) [21:17:44] btw kaldari jgonera at some point we should get some docs auto generated for our JavaScript - I think that would be useful [21:18:01] true [21:18:21] jdlrobson, I guess we should ask Krinkle or someone if they're using some tool for that already [21:19:55] visual editor team use jsduck if i remember correctly? [21:20:16] indeed [21:20:29] https://doc.wikimedia.org [21:20:43] https://doc.wikimedia.org/VisualEditor/master/#!/api/ve.init.sa.Target [21:24:39] thanks for that Krinkle [21:25:32] jdlrobson, I'll eat lunhc now and rebase that later, can you have a look at https://gerrit.wikimedia.org/r/#/c/85320/ ? It's a one line change [21:25:47] jgonera: after the captcha stuff ;-) [21:26:21] jdlrobson, ok, sure. do you want to test it? have you had any problems configuring FancyCaptcha? [21:29:18] jgonera: i've had captcha support for a while [21:29:22] i have all the different ones [21:29:32] this is how i knew recaptcha is still broken :) [21:34:38] jgonera: mm… account creation form is broken for me.. does http://localhost.beta/w/index.php?title=Special:UserLogin&type=signup work for you? [21:34:56] oh wait.. Ran out of captcha images. [21:34:59] looks like i need to do something [21:35:47] huh, I generated only 2 and never run out of them ;) [21:36:12] (03PS4) 10Yurik: Removed X-CS dependency in HTML content rewriting [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85641 [21:37:08] (03PS5) 10Yurik: Removed X-CS dependency in HTML content rewriting [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85641 [21:42:28] jgonera: mm something odd happening [21:42:34] it doesn't happen to you? [21:43:18] odd things happen to me from time to time but I'm not sure which you're referring to [21:43:20] )ahh updated ConfirmEdit and all okay now ;-) [21:48:16] jgonera: the captcha is not showing for me [21:48:18] i still get an error [21:48:20] {"edit":{"captcha":{"type":"image","mime":"image/png","id":"523489135","url":"/w/index.php?title=Special:Captcha/image&wpCaptchaId=523489135"},"result":"Failure"}} [21:49:00] what shows up then? the regular error toast? [21:49:06] yup [21:49:39] (03CR) 10MaxSem: [C: 032] "DB queries can benefit from sending less unneeded information to PHP but that can be done while this page is being tested with minimum tra" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76271 (owner: 10Jdlrobson) [21:49:40] are you sure you refreshed the site in the browser after checking out the patchset? [21:49:41] and i can't get back to source which is anoying [21:50:01] 100% sure jgonera [21:50:03] yes, I told you, the 1 line patch I linked to twice fixes it, but that's a separate thing [21:50:03] (03Merged) 10jenkins-bot: Story 475: UserProfile special page (first pass) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/76271 (owner: 10Jdlrobson) [21:50:06] uh [21:50:07] i've killed memcache and everything [21:50:25] ok, bb in 15 minutes, food's ready [21:54:00] (03CR) 10Jdlrobson: [C: 032] Show proper button bar in editor on errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85320 (owner: 10JGonera) [21:54:25] (03Merged) 10jenkins-bot: Show proper button bar in editor on errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85320 (owner: 10JGonera) [21:56:28] jdlrobson, awjr: 76271 is i believe being superceded by yuri_k's 85641; i'm currently reviewing this 85641, which changes link rewriting in anticipation of esi banners. kaldari's 853691 addresses a mobilefrontend interface message removal impacting zeroratedmobileaccess footers, taking some additional cases into account. my 85133 javascript-based patchset: yuri_k asked that someone immersed regularly in javascript from [21:56:28] the general mobile web team review that instead of him - that's the one that i emailed mobile-tech and zero about, and i'll open a separate thread with kenanwang, tfinc, and dfoy. tfinc, i agree with your judgment that if the requests for core mobile web code reviewers aren't asked for, it implies that it's something yuri_k and i are handling on a separate timeline. [21:56:53] (03CR) 10Jdlrobson: [C: 032] "(5 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85150 (owner: 10JGonera) [21:56:59] (03CR) 10jenkins-bot: [V: 04-1] Story 1163: Mobile Captcha support for editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85150 (owner: 10JGonera) [21:57:12] jgonera: so i merged but please read my comment - there are some issues i would like addressed [21:57:35] (03CR) 10Jdlrobson: "OK I guess you can edit them/address the concerns in the rebase :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85150 (owner: 10JGonera) [21:59:19] MaxSem: i wonder if there is a way to get up to date messages on beta labs [22:00:08] jdlrobson, is should happen once in a while - up to 40 minutes if memory serves me right [22:00:18] s/is/if/ [22:14:54] ping brion [22:15:12] YuviPanda: yo [22:15:23] brion: i'm fucked for the entire week, I guess. 3AM and I'm wide awake [22:15:30] :( [22:15:33] brion: did you see https://bugzilla.wikimedia.org/show_bug.cgi?id=54465 [22:16:08] hmm, parsing could be an issue yeah… lots of little bits there [22:16:12] YuviPanda, wow - you ever went to bed before 3AM?:P [22:16:18] that would explain the timeout i saw in the app :D [22:17:14] MaxSem: don't remember [22:17:20] MaxSem: today I went to sleep at 9:30PM! [22:17:36] glorious [22:19:12] MaxSem: inorite [22:19:22] MaxSem: now I need to be awake during normal people hours and interact with normal people [22:20:56] brion: i'm profiling to find the actual bottleneck. I'm 99% sure it is the parser... [22:21:17] * brion hmms [22:21:41] can't really pre-render on save, since we don't know which languages will get pulled, and templates etc can change and that gets complicated [22:22:26] could also try making the per-page limit really small so the worst-case time isn't too bad on any single request :PP [22:22:36] (per-api call limit rather) [22:22:44] brion: sure, but this is a general problem that needs fixing [22:25:13] jdlrobson, I assume it worked? answering your comments now [22:25:43] brion: i suppose the 'proper' way to do it is to use the pagecache [22:25:59] hmm [22:26:42] brion: and use the regular job queue mechanism to invalidate on page edit [22:27:01] could try that. i'm just not sure that'll catch all the translation stuff [22:27:08] brb house stuff [22:27:18] (03CR) 10JGonera: "(5 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85150 (owner: 10JGonera) [22:29:00] part of our fence fell down a few days ago, we gotta get the handyman to fix it when he returns :P [22:29:12] sigh, why can't these old guys get cell phones and be contactable :D [22:29:28] heh [22:33:34] (03CR) 10jenkins-bot: [V: 04-1] Clean up login/create account form and captcha CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85151 (owner: 10JGonera) [22:34:07] uhh rebasing rebasing [22:34:51] MaxSem: can you merge and deploy this config change during the deployment tomorrow: https://gerrit.wikimedia.org/r/#/c/85259/ [22:35:29] (03PS4) 10JGonera: Update templates to contain new mobile edit links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85270 [22:35:38] kaldari, sure thing, added to my list [22:35:44] thnaks [22:40:28] (03CR) 10MaxSem: [C: 032] Update templates to contain new mobile edit links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85270 (owner: 10JGonera) [22:40:52] (03Merged) 10jenkins-bot: Update templates to contain new mobile edit links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85270 (owner: 10JGonera) [22:41:14] (03CR) 10MaxSem: "Is this issue dead in the water?" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/55813 (owner: 10Awjrichards) [22:43:32] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85151 (owner: 10JGonera) [22:44:15] (03CR) 10Jdlrobson: "(3 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85150 (owner: 10JGonera) [22:50:20] (03PS11) 10Jdlrobson: Collapse on h1s when present [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83931 [22:52:32] kaldari: is https://bugzilla.wikimedia.org/show_bug.cgi?id=53595 fixed now? [22:52:46] yuri_k, is ZeroRatedMobileAccess:master working for you with MobileFrontend:master? [22:52:52] Change-Id: I0440ecd33e253fdaf77179b855db6cdd4f355935 ? [22:52:54] ^jcmish, cc [22:53:08] dr0ptp4kt, there was some bug in mobile, but after updating - yes [22:53:28] dr0ptp4kt, i meant - my last zero patch, not master, will check master in a sec [22:53:37] yuri_k, thx [22:53:45] jdlrobson: Yes, I'll close it [22:53:50] thanks kaldari [22:55:25] (03PS1) 10Yurik: ESI handling of the banner [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85779 [22:56:30] (03PS2) 10Yurik: ESI handling of the banner [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85779 [22:57:52] (03Abandoned) 10Yurik: ESI handling of the banner [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/78091 (owner: 10Yurik) [22:59:57] (03CR) 10MaxSem: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83931 (owner: 10Jdlrobson) [23:00:56] MaxSem: what should be .*? [23:00:58] dr0ptp4kt, take a look at the esi above [23:01:08] the regex [23:01:16] it is... [23:01:21] dr0ptp4kt, i think all of that code (both patches) can go into production [23:01:32] it computes to or [23:01:38] unless i'm being stupid? [23:01:40] .$tagRegEx = '<' . $tagName . '.*'; [23:02:08] I'm being not very clear:P [23:02:17] nope.. please clarify : [23:02:18] :) [23:02:24] ".*?" instead of ".*" [23:03:14] dr0ptp4kt, and master of core+mobile+zero seems to work for me [23:03:30] (latest) [23:06:22] yuri_k, updated master for core and that seemed to do the trick [23:07:34] dr0ptp4kt, oki, could you test the esi patch too? I want to deploy both of them as the 2nd one is minor and doesn't affect anything unless enabled [23:08:31] MaxSem: what would that catch that the other wouldn't? if anything it should probably be .+ no? [23:08:35] since you have to close the h2 / h1 [23:08:42] yuri_k, do you want me to stop reviewing the link rewriting patch and switch to the esi patch? or look at the esi patch after the link rewriting patch? i'll have at least a couple of comments on the link rewriting patch. [23:09:09] jdlrobson, greedy quantifier can catch other s [23:09:22] doesn't %sU take care of that? [23:09:38] if it doesn't by accident, that doesn't mean that this won't break with future changes [23:09:40] MaxSem: i defer to you though since you are the PHP expert - i just don't seem to be identifying anything new here [23:09:41] dr0ptp4kt, esi patch adds a few more changes to the link rewriting - i could even merge them into one. Finish link rewrite first, will keep things simple :) [23:09:52] (i'm using the same regular expression as before) [23:10:02] so if what you are saying is true then surely the current code is flawed? [23:10:16] MaxSem: can you write a unit test that catches this problem? [23:10:36] yuri_k, okay, back tot he link rewriting patchset [23:10:38] i mean there shouldn't ever be an h2 inside an h1 for example [23:10:44] I will, but then this patch wouldn't make it until code cutoff [23:11:15] MaxSem: you will write a unit test? or you will ? [23:11:28] the former [23:11:55] ok.. i'm still clueless on how this would explode in the current state so would be very keen to see that unit test [23:12:01] yuri_k, you'll want to make sure the ops guys know it's coming. i recommend getting on the #wikimedia-operations channel and letting them know you'll be letting them know when the first cut goes in. the link rewriting will add some level of extra items to the cache, although it shouldn't cause problems. and obviously a ?specialflag=1 type thing for the esi banners shouldn't impact anything for perf [23:12:22] but in the interest of making our users happy if that is blocking this get merged i'll fix that up now [23:12:36] yuri_k, i'm sure the guys are sleeping right now, so maybe chat with them when up tomorrow morn? [23:12:50] dr0ptp4kt, sounds good [23:12:58] (03PS5) 10JGonera: Story 1163: Mobile Captcha support for editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85150 [23:13:10] yuri_k, thx [23:13:25] MaxSem: if I put a ? it breaks [23:13:34] $tagRegEx = '<' . $tagName . '.*?'; does not do what it should do [23:13:40] i just tried it [23:13:46] (03PS5) 10JGonera: Clean up login/create account form and captcha CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85151 [23:13:50] meh, nevermind then [23:14:04] (03CR) 10MaxSem: [C: 032] Collapse on h1s when present [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83931 (owner: 10Jdlrobson) [23:14:18] MaxSem: some more unit tests would probably help here though :) [23:15:26] (03Merged) 10jenkins-bot: Collapse on h1s when present [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83931 (owner: 10Jdlrobson) [23:16:10] jdlrobson, kaldari, I rebase the captcha patchsets [23:16:19] jgonera: i'm alread on it [23:16:21] jdlrobson, if you rebase https://gerrit.wikimedia.org/r/#/c/84420/ I'll gladly merge it ;) [23:16:57] jdlrobson, I added a method for showing a button bar and docs for the save function [23:17:04] jgonera: yup i already saw [23:17:17] still not 100% sure about this input-box thing but we can discuss that later [23:18:25] why not? that's basically a refactoring of .wpInputs from create account form [23:18:42] (03PS1) 10Kaldari: Use shorter text for some common licensing strings in the footer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85789 [23:19:27] (03CR) 10Jdlrobson: [C: 032] Story 1163: Mobile Captcha support for editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85150 (owner: 10JGonera) [23:19:53] jdlrobson: Actually, I'd like to get one more tweak in for the footer changes before the deployment: https://gerrit.wikimedia.org/r/#/c/85789/ [23:19:56] jgonera: well as i said wpInputs is a core class and i'm wondering if we should be moving away from it [23:20:09] is there anything else that needs review currently? [23:20:13] jgonera: anyway let's talk about that after deployment i merged the key patch [23:20:19] (03Merged) 10jenkins-bot: Story 1163: Mobile Captcha support for editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85150 (owner: 10JGonera) [23:20:23] jdlrobson, oh, it is? ok, let's revisit it later then [23:20:30] jgonera: rebasing that patch with the hash change now [23:20:47] kaldari, I rebased the captcha css cleanup that you +2d [23:20:48] ok [23:20:52] jgonera: i said so in my comment on gerrit - i guess you missed it ;-) [23:20:55] ah [23:21:03] jgonera, sorry, I might have [23:21:09] (03CR) 10Kaldari: [C: 032] Clean up login/create account form and captcha CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85151 (owner: 10JGonera) [23:21:33] (03Merged) 10jenkins-bot: Clean up login/create account form and captcha CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85151 (owner: 10JGonera) [23:22:00] (03CR) 10Jdlrobson: "Open question (not a real -1) - wpInputs is used in core - should we really be departing from this class in favour of our own - what's the" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85151 (owner: 10JGonera) [23:22:18] eek kaldari ^ [23:22:32] we should still have that discussion [23:22:54] (03PS2) 10Yurik: Update README to reflect new X-Analytics header [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/55813 (owner: 10Awjrichards) [23:22:59] oops [23:23:08] not cataclysmic but just goes to support the fact that the gerrit ui is bad huh jgonera since my comment on patch set 4 got ignored? [23:23:21] (03CR) 10Yurik: [C: 032] Update README to reflect new X-Analytics header [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/55813 (owner: 10Awjrichards) [23:23:22] (03CR) 10JGonera: [C: 031] "I guess this is the only way to do it, but I'll let someone else have a look too." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85789 (owner: 10Kaldari) [23:23:23] (03Merged) 10jenkins-bot: Update README to reflect new X-Analytics header [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/55813 (owner: 10Awjrichards) [23:24:19] what's wpInputs? [23:24:26] jdlrobson, I'm looking at the comments again and can't see it [23:24:59] ah, I see [23:25:11] oh, in that patchset [23:25:49] to be fair i should have -1ed i guess [23:25:54] (03CR) 10Jdlrobson: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85789 (owner: 10Kaldari) [23:26:24] jdlrobson, yes, that would help, I saw a checkmark and assumed it only needed rebasing [23:26:46] jdlrobson: I don't see wpInputs defined as CSS anywhere in core [23:27:07] kaldari: oh really? mm.. why did we use that then - maybe core got changed since in a login form refactor? [23:27:22] kaldari: is it used at all in core - i know it used to be [23:27:24] I imagine it was deprecated in favor of mediawiki.ui [23:27:25] if not great :) [23:30:18] (03PS4) 10Jdlrobson: Stop refreshing page on a hash change [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84420 [23:30:19] (03PS1) 10Jdlrobson: Alpha: Update title of page on a lazy load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85792 [23:30:22] kaldari: well that's super then - one less thing to worry about [23:30:22] :) [23:30:28] ^ jgonera rebased [23:32:22] (03CR) 10JGonera: [C: 032] Stop refreshing page on a hash change [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84420 (owner: 10Jdlrobson) [23:32:48] (03Merged) 10jenkins-bot: Stop refreshing page on a hash change [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84420 (owner: 10Jdlrobson) [23:33:06] (03CR) 10JGonera: [C: 032] Alpha: Update title of page on a lazy load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85792 (owner: 10Jdlrobson) [23:33:45] dr0ptp4kt, any comments i can already address? [23:33:56] (03Merged) 10jenkins-bot: Alpha: Update title of page on a lazy load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85792 (owner: 10Jdlrobson) [23:34:01] yuri_k, 20 minutes [23:34:07] kk [23:34:52] kaldari, https://gerrit.wikimedia.org/r/#/c/81710 [23:35:47] (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85789 (owner: 10Kaldari) [23:37:20] (03CR) 10JGonera: Use shorter text for some common licensing strings in the footer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85789 (owner: 10Kaldari) [23:47:47] (03PS1) 10MaxSem: Debug logging for latest PoolCounter weirdness [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85795 [23:47:58] quick review plz^^ [23:49:26] MaxSem: want +2? [23:49:38] yup:) [23:51:24] (03CR) 10Yuvipanda: [C: 032] "LGTM" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85795 (owner: 10MaxSem) [23:51:33] thank you:) [23:51:46] (03Merged) 10jenkins-bot: Debug logging for latest PoolCounter weirdness [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85795 (owner: 10MaxSem) [23:54:57] (03CR) 10Dr0ptp4kt: [C: 04-1] "(6 comments)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85641 (owner: 10Yurik)