[00:01:54] (03PS2) 10Kaldari: Use shorter text for some common licensing strings in the footer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85789 [00:04:33] I know I'm 3 minutes after the cutoff, but anyone want to sneak in https://gerrit.wikimedia.org/r/85789? [00:06:26] kaldari, what if it's localised? [00:07:14] there's not much we can do without refactoring the installer [00:07:27] really it should store a key rather than a string [00:08:49] MaxSem: This is basically just a hack in the meantime [00:09:26] (03CR) 10MaxSem: [C: 032] Use shorter text for some common licensing strings in the footer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85789 (owner: 10Kaldari) [00:09:34] meh [00:09:39] agreed, meh [00:10:09] (03Merged) 10jenkins-bot: Use shorter text for some common licensing strings in the footer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85789 (owner: 10Kaldari) [00:10:15] I'll file a bug on the installer enhancement [00:13:39] (03CR) 10Dr0ptp4kt: [C: 04-1 V: 04-1] "(1 comment)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85779 (owner: 10Yurik) [00:26:25] dr0ptp4kt, around? [00:26:37] yurik, yup. what's up with the username changes? [00:27:15] (03CR) 10Dr0ptp4kt: "Once 85641 shakes out, will review and amend" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85391 (owner: 10Kaldari) [00:27:26] lots of clones dr0ptp4kt [00:27:38] yurik, tell your botz to behave [00:27:59] dr0ptp4kt, how do you want to address the redirect vulnarability [00:28:41] hmm, why apps CR is in #-dev? [00:28:51] redirect them to the homepage seems like the safest thing to do. [00:28:55] ^yurik [00:29:12] MaxSem: they mostly turn up here, I guess the config isn't generic enough [00:29:38] dr0ptp4kt, how do you mean? [00:30:01] dr0ptp4kt, https://gerrit.wikimedia.org/r/#/c/85641/5/includes/ZeroSpecialPage.php [00:32:36] yurik, i was thinking that if the configuration is null then the 'redirect' key should just be set to the webroot of the current wiki. maybe that should be done in getRedirectInfo on PageRenderingHooks.php:647 or thereabouts [00:33:29] kaldari: "message": "Bad value JDLR:General disclaimer for attribute href on element a: Whitespace in path component. Use %20 in place of spaces.", [00:33:37] yurik, the alternative is to echo the url safely so the end user can see where s/he's going [00:33:38] htmlvalidation is complaining in latest master [00:33:53] yurik, in either case, there will be some sort of cached objects, it's just a question of size and duration [00:34:17] ah [00:34:20] (03PS1) 10Jdlrobson: Beta: Link diff page to user profile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85802 [00:34:21] (03PS1) 10Jdlrobson: Story 475: Link user profile from left menu in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85803 [00:34:25] yurik, cached object proliferation can be bad anywhere, that is to say it isn't unique to this code, so i wonder if having the url echoed would be nice. [00:34:43] dr0ptp4kt, if we are trying to prevent redirect for non-zero issues, i don't see much point - considering that we are trying to get all mobiles to this program :) [00:35:07] dr0ptp4kt, sec, fixing the esi bug (good catch, thx) [00:36:38] (03PS2) 10Jdlrobson: Story 475: Link user profile from left menu in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85803 [00:36:47] (03PS3) 10Yurik: ESI handling of the banner [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85779 [00:36:52] yurik, if the user is on a legitimate carrier, the user isn't automatically redirected; the user consents by clicking through. contrast this with the desktop user who happened to land on a mobile subdomain and got automatically bounced to some third party site [00:37:30] jdlrobson: any idea which links it's complainaing about? [00:37:44] kaldari: i suspect in the latest footer changes [00:37:51] the general disclaimer link [00:38:33] (03CR) 10Yurik: "(1 comment)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85779 (owner: 10Yurik) [00:39:03] (03PS1) 10Jdlrobson: Profiles: Stop the heading from being a link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85804 [00:40:06] jdlrobson: found it, easy fix... [00:40:47] dr0ptp4kt, ok, looking at pagerenderinghooks line 647 [00:41:59] in case there is no x-cs and there is a redirect, what do you think the action should be? [00:43:13] (03PS1) 10Kaldari: Use underscore version of titles for link hrefs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85805 [00:43:23] jdlrobson: ^ [00:45:48] dr0ptp4kt, ^ [00:45:50] yurik, i think simplest is to redirect the user to the main page of that same wiki. another acceptable alternative would be to send the user to the 'from' parameter's corresponding article [00:45:51] I'll see about adding a check to the code that actually buidls the links as well [00:47:51] dr0ptp4kt, this is not very good because if, for some reason, user clicks on a link after switching to wifi or their carrier forgets to whitelist their ip, they would loose their location in that article, and the behavior would be unexpected [00:48:35] whereas if we silently accept and redirect them, it would be the easiest and least disruptive behavior. [00:49:00] yurik, thus, i think the best thing to do is to print a clickable URL to the screen, with both the text of the link safely escaped, and as always, the href safely encoded. [00:49:18] ok, we can do that [00:49:39] except that now we need to do all the localization and message building. Ugh :) [00:49:40] yurik, in the non-abuse case, it's no more work than the user would do. in the abuse case, at least we didn't help someone get a virus. [00:49:41] (03PS1) 10Ori.livneh: Use LESS files directly in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85806 [00:49:45] (03CR) 10jenkins-bot: [V: 04-1] Use LESS files directly in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85806 (owner: 10Ori.livneh) [00:49:49] yurik, that's *fun*, remember? [00:49:56] right [00:50:28] and no, i don't think this has anything to do with getting a virus [00:50:53] because we are allowing this behavior for anyone in the carrier's network [00:51:04] and soon we might have most of the ppl in the world in it [00:51:11] (03Abandoned) 10Ori.livneh: Use LESS files directly in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85806 (owner: 10Ori.livneh) [00:51:36] dr0ptp4kt, ^ [00:56:00] (03PS2) 10Kaldari: Generate links for about and disclaimer correctly. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85805 [00:58:25] (03PS3) 10Kaldari: Generate links for about and disclaimer correctly. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85805 [01:02:13] (03CR) 10Kaldari: [C: 032] "Quick bug fix before tomorrow's deployment" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85805 (owner: 10Kaldari) [01:02:37] (03Merged) 10jenkins-bot: Generate links for about and disclaimer correctly. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85805 (owner: 10Kaldari) [01:05:00] yurik, where can I look up what an X-CS stands for? [01:05:19] MaxSem, no idea :) [01:05:30] X-CS was something that was always used [01:05:33] varnish? [01:05:54] MaxSem, are you looking for the meaning behind the "CS" letters? [01:06:16] or the code that sets it? [01:06:20] no, meaning behind 416-03 [01:06:25] and so on [01:07:00] https://www.mediawiki.org/wiki/Requests_for_comment/Zero_Architecture#Partner_Configuration [01:07:16] ^MaxSem cc yurik [01:07:17] MaxSem, http://meta.wikimedia.org/wiki/Zero:416-03 [01:07:29] thx [01:07:58] MaxSem, the first line (comment) in the zero: page specifies the carrier [01:08:47] User-agent: 'Nokia3330/1.0 (03.05)', Accept: 'vnd.wap.wml' [01:08:57] dafuq [01:10:15] because accept is not prefixed with "text/", they get nice HTML instead of WAP [01:11:06] on a 2002 phone [01:12:50] real programers don't compare strings, they do substring search... for "wml" [01:13:16] (03PS12) 10Dr0ptp4kt: Better prevent chargeable resources from being inadvertently accessed. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 [01:13:52] the log looks weird though. as if someone tested the heck out of our zero sites with one phone... or "phone" [01:14:26] MaxSem, are you referring to the User-Agent field? [01:14:36] accept [01:14:57] An "Accept" header of "phone"? seriously? [01:15:05] * YuviPanda gives them free phones [01:15:14] :) [01:17:25] brilliant, jetlag! [01:17:39] didn't notice what time is it [01:17:42] hehe [01:17:56] * MaxSem takes a miagic pill to go to bed in 1/2h [01:18:59] let me look at these IPioj48930209823uyn04fd8n2y308 [01:19:34] sbgwesdEH$%dfbndn? [01:27:04] (03PS6) 10Yurik: Removed X-CS dependency in HTML content rewriting [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85641 [01:27:49] dr0ptp4kt, i fixed it a little bit - since this is a very unusual case, i will just show the link without any text [01:27:59] i would rather not get too involved with it [01:28:32] yurik, yeah, that's okay, i think [01:29:27] ok, +2 it then :) [01:31:55] (03PS4) 10Yurik: ESI handling of the banner [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85779 [01:33:08] dr0ptp4kt, i rebased the other patch, and need to step away, pls +2 both patches so that i can deploy tomorrow [01:38:49] (03PS13) 10Dr0ptp4kt: Better prevent chargeable resources from being inadvertently accessed. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 [01:44:49] (03CR) 10Dr0ptp4kt: [C: 032] "The Desktop link, which is currently broken anyway, needs to have its hyperlink formatted. But this should be put into production to start" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85641 (owner: 10Yurik) [01:44:51] (03Merged) 10jenkins-bot: Removed X-CS dependency in HTML content rewriting [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85641 (owner: 10Yurik) [01:45:17] (03CR) 10Dr0ptp4kt: [C: 032] ESI handling of the banner [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85779 (owner: 10Yurik) [01:45:19] (03Merged) 10jenkins-bot: ESI handling of the banner [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85779 (owner: 10Yurik) [01:45:23] let me look at these IPioj48930209823uyn04fd8n2y308 [01:45:43] MaxSem, HA! go to bed! [01:47:23] yurik, +2'd 'em. the Desktop footer hyperlink format should be updated to reflect the interstitial. but that's currently buggy anyway, so the +2 lets us start reaping the benefits. [01:59:37] (03PS14) 10Dr0ptp4kt: Better prevent chargeable resources from being inadvertently accessed. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 [05:53:22] (03Abandoned) 10Yurik: Removed X-CS dependency in HTML content rewriting [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/76201 (owner: 10Yurik) [12:01:53] (03CR) 10Zfilipin: "I will take a look, but probably not this week. I am jet lagged and I have a conference on Friday, so I have to prepare for it." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85138 (owner: 10Jdlrobson) [14:42:26] bah [14:42:48] so microsoft guys want me to add more languages to the store profile on our windows 8 app…. but apparently if you do that, the store demands that you translate your app description [14:42:53] i'll fiddle with it later [14:49:29] (03PS1) 10Yurik: Big refactoring of PageRenderingHooks to avoid globals [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85854 [14:49:50] brion, they killed nokia! no negotiations with satan! [14:50:49] :D [14:51:44] hi brion [14:51:50] hey [14:51:53] how's your sleep schedule :D [14:52:05] brion: i woke up at 3AM [14:52:11] brion: and then haven't been able to sleep [14:52:24] brion: so decided that the best course of action is to go to the nearest train station and work out of there :P [14:52:33] brion: I'll probably hit the bed in an hour or so [14:52:54] brion: there's an android patch from yesterday, and I still am not sure how to add caching to the parses [14:52:57] heh [14:53:01] ok [14:53:20] brion: have you done stuff with the parser cache before? [14:54:00] zero ext is about to be deployed, watch out! :) [14:54:10] zero extensions are going to be deployed? [14:54:15] * YuviPanda|course rolls all extensions into core :P [14:54:54] heh [14:55:12] YuviPanda|course: mm some time ago… not sure how to make things fit together for this but we can try to hash it out :D [14:55:21] brion: think we can use the parser cache for this... somehow? with the proper invalidation when templates get edited? [14:55:42] brion: essentially, I need to find out how exactly jobs are queued when a template is edited, and then make it refresh this too [14:56:50] YuviPanda|course: maybe check over the LinksUpdate and template edit invalidation stuff, see if you can find something uyou can hook in [14:57:04] brion: probably. sounds like a big chunk of work tho :( [14:57:05] maybe replace the 'parse the page for links' with a 'let's parse all the bits and save them for later' [14:57:09] brion: if only the parser wasn't that slow :( [14:57:33] brion: on average each campaign seems to do 2 instances of parsing. that isn't even much! [15:02:46] :( [15:03:28] brion: also profiling section on mw docs seems... fairly outdated [15:03:34] i should probably pick up xhprof or something similar [15:03:39] and do it today / tomorrow [15:04:06] wfProfileIn()! we should kill that shit man [15:04:16] but i'm not sure we have sampling profiling in the PHP engine available in production :) [15:04:34] brion: sure, but my local install sortof repros this anyway ;) [15:04:47] yay [15:05:00] that's easier than 'can only repro on production site' :DD [15:05:05] brion: ~5s for ~15 campaigns [15:05:09] so that's bad [15:05:13] more like 3s-5s [15:05:18] ouchies [15:05:26] indeed [15:05:47] brion: I've also started doing the Functional Programming with Scala course on Coursera :D [15:06:05] heh nice [15:06:16] now to sneak something written in Scala on to production.... [15:06:17] :P [15:14:50] brion, for local testing wfProfileIn() sucks indeed, however when you have a whole fucking cluster and graphite...:) [15:15:05] \o/ [15:15:23] data whee [15:24:31] YuviPanda, where does UW parse campaign names? [15:26:01] I'm seeding seeds of love^W profiling [15:28:47] mmm, nice dependency on EL [15:29:36] mmm, include() on every campaign read, really? [15:34:05] (03PS1) 10Yurik: Prevented zero API 'ips' from working when running on a non-META site. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85859 [15:37:33] YuviPanda, https://gerrit.wikimedia.org/r/85860 [15:40:43] MaxSem, could you add any instance of IContextSource to the GetMobileUrl hook? [15:40:50] any object would do :) [15:41:15] * MaxSem looks [15:43:05] (03PS1) 10MaxSem: Add context to GetMobileUrl hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85865 [15:43:29] yurik, next time it'll be an exercise for you:) ^^ [16:18:07] MaxSem: ty for the patch [16:18:09] MaxSem: and what do you mean by include() on every campaign read? [16:19:03] $schema = include( $wgUpwizDir . '/includes/CampaignSchema.php' ); [16:19:30] that's there on every read? supposed to be on every edit [16:19:32] * YuviPanda checks [16:21:01] MaxSem: it's called from isValid(), I don't see how that is called on every read [16:21:10] right [16:21:15] more like every save [16:21:42] if you review it, I'll deploy it today [16:21:58] wooo [16:21:59] doing now [16:22:05] profile good! [16:22:42] MaxSem: are multiple wfProfileIn calls with same value for __METHOD__ okay? [16:23:38] dunno if it's okay, but definitely not what was intended... fixing [16:23:50] :) [16:24:12] MaxSem: looks good otherwise [16:24:13] done [16:24:14] ah, new PS [16:24:15] looking [16:26:06] MaxSem: merged [16:26:20] wee [16:29:14] MaxSem: jet lag is going to set in in some time, and I expect to crash soooon [16:29:28] sleep well [16:30:08] MaxSem: ty for merging / deploying [16:35:07] (03PS6) 10Brion VIBBER: work in progress patch: use .less files directly in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 [16:47:43] (03CR) 10Brion VIBBER: [C: 04-1 V: 04-1] "Something's wrong... I don't have main menu icons, and the page action area buttons are vertically laid out instead of horizontally." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER) [16:53:40] (03CR) 10Brion VIBBER: "LESS error: expecting number: failed at `font-size: round( 1em / @fontScalingFactor, 2 ); // Fixed font on purpose to avoid zooming on iOS" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER) [16:54:07] brion: there's a app patch waiting on gerrit. can you try it out with testwiki to confirm that the patch works for you? [16:54:14] still need to fix the perf issue [16:54:16] moment [16:54:23] brion: no rush [17:08:35] brion: MaxSem heading to sleep now. Jetlag, etc [17:08:45] gnite [17:09:02] nite [17:17:47] heads up awjr: I'm going to carry out today's deployment, but my jetlag might decide otherwise [17:18:01] MaxSem: im sure we can talk kaldari into it if you prefer :) [17:18:12] I don't see him yet [17:18:29] i bet he'll be on soon [17:22:03] http://www.businessinsider.com/fake-ios-7-ad-promising-a-waterproof-device-destroys-phones-2013-9 [17:44:25] (03PS7) 10Brion VIBBER: work in progress patch: use .less files directly in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 [17:45:24] (03CR) 10Brion VIBBER: "Patch 7 indicates requirement of implementation of round() function, and @imports the mixin required for .background-image." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER) [18:56:22] (03PS1) 10Mgrover: QA-id changed for Notification to secondary-button from user-button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85902 [18:59:25] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85902 (owner: 10Mgrover) [18:59:57] (03Merged) 10jenkins-bot: QA-id changed for Notification to secondary-button from user-button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85902 (owner: 10Mgrover) [19:09:22] has anyone seen dr0? [19:13:11] yurik, ^^ [19:31:07] jgonera, is Kaldari in office? [19:31:20] yes, he's eating lunch [19:31:36] he's not on irc again [19:35:40] jgonera, could you look at styling of https://m.wikimediafoundation.org/wiki/Thank_You_All and its subpages? [19:35:47] FR are unhappy [19:36:05] FR? [19:36:17] dr0ptp4kt, ping [19:36:49] MaxSem, that gives me a desktop view no matter what I do, is that OK? [19:38:18] yep, although I've actually seen mobile view there, not sure how [19:38:57] the subpages are mobile, there are some small rendering problems there [19:39:04] (03PS8) 10Brion VIBBER: work in progress patch: use .less files directly in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 [19:39:08] dr0ptp4kt, around? have you had a chance to run your tests? [19:39:15] anyway, those headings are really long, not sure if that's what a heading is supposed to be [19:39:23] need food before deployment, be back [19:39:33] dr0ptp4kt, could really use some peace of mind :) [19:39:41] (03CR) 10Brion VIBBER: "Required core parts have been merged; seems to work. Someone please confirm and merge. :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER) [19:45:06] (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER) [19:46:46] (03CR) 10Brion VIBBER: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER) [20:00:09] deployment time MaxSem ? [20:00:11] or is kaldari doing it this time round? [20:00:17] me [20:00:34] lemme know if I can be of any assistance [20:00:47] but awjr and kaldari should be prepared to take the flag from my hands if jetlag kicks in [20:01:02] :) [20:01:25] yurik, back from the meeting, and settled in. will be reviewing [20:01:51] dr0ptp4kt, meeting? [20:01:57] did i miss something? :) [20:02:02] yurik, the one carolynne and i were at [20:02:07] oh [20:02:09] cool [20:02:24] let me know how the test runs, and could you check if our zero system works? [20:02:33] i have been seeing images in it [20:02:41] suspect something weird is going on [20:02:46] try it from the office [20:07:54] dr0ptp4kt, ^ [20:08:07] all right awjr, jcmish, jdlrobson, jgonera, kaldari - we're live on testwiki, please test:) [20:08:28] danke Max [20:08:29] w00t! [20:08:34] starting to test [20:08:42] testin [20:08:54] yurik, setting ua and xff *only* (not forging X-CS or X-Subdomain), to correspond with the entry for 510-11, the interstitial is required on zerodot. note that the 510-11 carrier is zerodot-only. setting the ua and xff *only* to correspond with the carrier 250-99, the image is not present, and there's no interstitial, which is the desired behavior. [20:08:57] \o/ [20:09:48] dr0ptp4kt, so it doesn't show images for you, right? [20:09:54] yurik, MF is doing its deployment, so i can run the "short" version of the test. it's going to have some errors due to regexes needing to be updated to reflect the new &from=&to= stuff, but it should be an okay estimation until the full run executes later today. [20:09:58] under zero.* [20:10:11] thx [20:10:14] yurik, correct, it is NOT showing the images for zerodot when using xff. i'll check when forging x-cs in a minute [20:11:52] jdlrobson, jgonera: looks like our nearby and user icons overlap if you're logged in: https://test.m.wikipedia.org/wiki/Special:Nearby [20:11:54] nearby overlay is showing the nearby icon smooshed over the user icon in the upper right hand corner [20:11:58] hahaha jinx kaldari [20:12:06] i am logged out though [20:12:14] yurik, forging of X-CS is also yielding the expected behavior: for a zero-only carrier with X-CS: 510-11 the 'click to view' [20:12:26] …yurik, hit ENTER unexpectedly, continuing transmission... [20:12:31] and in fact, the user icon shows up in the search bar for me on desktop chrome (as logged out user) [20:12:42] weird, i get images... will double check [20:12:45] jgonera, jdlrobson, jcmish, kenanwang ^ [20:12:48] bahh [20:12:55] regressiiionnnn [20:13:02] i can fix the nearby issue [20:13:08] i know what's going on [20:13:20] yurik, for X-CS: 510-11 the 'click to view' text shows up and upon click the interstitial shows, which is correct because the carrier is zero-only. for X-CS: 250-99, the 'click to view' text shows up and the interstitial does not show (as the carrier supports images). [20:13:36] Also note the footer copyright message will be broken until the scap happens [20:13:52] Cool thanks jdlrobson [20:16:26] interesting, the user icon in the right corner looks fine (it's not in the search box) when im logged in [20:16:48] on stable [20:17:37] the user icon should NOT show up if you're not logged in, correct? [20:17:56] yurik, from what i see esi must be working when using X-FORCE-ESI: 1 as well [20:18:14] jgonera in case you missed it: [20:18:15] interesting, the user icon in the right corner looks fine (it's not in the search box) when im logged in [20:18:15] 1:18 [20:18:15] on stable [20:18:19] the user icon should NOT show up if you're not logged in, correct? [20:18:36] yurik, direct hits to Special:ZeroRatedMobileAccess?renderesibanner=1 render the appropriate banner [20:18:45] (03PS1) 10Jdlrobson: Regression: Remove Echo button from Nearby page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85909 [20:19:02] I guess it shouldn't [20:19:22] errg breakage [20:19:25] let me fix that as well in same patch [20:19:30] dr0ptp4kt, it shouldn't work until varnish config is updated [20:19:44] (03CR) 10Jdlrobson: [C: 04-1] "Going to fix so doesn't show when logged out either." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85909 (owner: 10Jdlrobson) [20:19:51] jdlrobson, what caused it? [20:20:00] the renderesibanner=1 will work because it doesn't require esi to be enabled [20:20:26] the user profile change [20:20:35] i made it more generic and somehow chaos broke loose [20:21:04] yurik, are you suggesting that the onerror="continue" clause is thus executing? in any case, no harm done there it seems [20:21:38] (03PS2) 10Jdlrobson: Regression: Remove Echo button from Nearby page / anon page views [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85909 [20:21:46] ^ k this should fix all that echo nonsense [20:21:48] dr0ptp4kt, are you saying that there is no tag when you add the header? [20:22:03] should have caught that one :/ [20:22:04] so guys i'm getting some automation tests failures but they weren't happening on labs [20:22:17] oh wait I should have looked up I see that about the license [20:23:16] yurik, seems my browser cache was the problem despite a command+shift+r. loading the page fresh shows the tag, and thus no banner. good, as expected. [20:24:18] yurik, i had to add an extra parameter onto the en.m in order to make it work, but ru.m did it automatically on the Main_Page [20:24:34] yurik, en.m was Main_Page, ru.m was its Russian equivalent [20:24:46] jcmish: are the test failures only relating to the footer thing? [20:24:47] so the read button is missingon test [20:24:56] yeah the footer was one so i ignored that [20:24:59] YuviPanda_zz: https://bugzilla.wikimedia.org/show_bug.cgi?id=39349 <- nice one :P [20:25:10] (03CR) 10Jdlrobson: [C: 04-1] "Need to add event logging to link clicks" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85803 (owner: 10Jdlrobson) [20:25:11] but there's also no "Read in another language" button showing on test [20:25:19] but it's there and working on betalabs [20:25:45] ok, jdlrobson, not sure if this is the way to go, but let's merge that, seems to work [20:25:59] kaldari: echo overlay isn't loading for me - is that just me? [20:26:06] (03CR) 10JGonera: [C: 032] Regression: Remove Echo button from Nearby page / anon page views [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85909 (owner: 10Jdlrobson) [20:26:07] did i break that as well? [20:26:23] echo overly is working for me jdlrobson, ins table [20:26:26] not loading for me either (beta) [20:26:30] (03Merged) 10jenkins-bot: Regression: Remove Echo button from Nearby page / anon page views [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85909 (owner: 10Jdlrobson) [20:26:32] yup i broke it [20:26:33] fix on the way :) [20:26:57] it's that profile patch again.. sorry :-) [20:27:24] I guess someone rushed too much when merging it ;) [20:27:42] jdlrobson: yeah, looks like the overlay isn't working in beta [20:27:56] but at least it falls back to the archive page, so not a critical breakage [20:28:10] (03PS1) 10Jdlrobson: Regression: Fix echo overlay for Echo in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85912 [20:28:14] i'm really hoping in this deployment we don't hit cache issues [20:28:32] so many things that potentially could cause them (even though i think we've been thorough i'm still nervous) [20:28:35] ^ Read in another language button is htat missing? [20:28:37] ^ fixes echo overlay [20:29:15] jcmish: what page should have languages? [20:29:20] (03CR) 10JGonera: [C: 032] Regression: Fix echo overlay for Echo in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85912 (owner: 10Jdlrobson) [20:29:37] main page always has language [20:29:41] typically [20:29:45] (03Merged) 10jenkins-bot: Regression: Fix echo overlay for Echo in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85912 (owner: 10Jdlrobson) [20:29:45] jcmish: i see it on San Francisco article.. [20:29:47] and it's missing but it's on main on betalabs [20:30:28] are you sure main on testwiki has languages? [20:30:29] https://test.wikipedia.org/wiki/Main_Page < jcmish according to desktop doesn't have any languages [20:30:37] so that would be expected [20:30:45] yup and weird because it used to be on main [20:30:54] okay I won't worry about it :D [20:30:56] i just stumbled upon this on testwiki, thought YuviPanda_zz might get a kick: https://test.m.wikipedia.org/wiki/Tto_page_7 [20:31:38] jgonera: the image overlay doesn't seem to work on that in experimental.. [20:32:00] will check [20:32:02] when i add a talk topic to an article with no existing talk topics, i do not see my talk topic in the list on the talk page until i hard refresh - is that known/expected jdlrobson? [20:32:13] main page looks completely different on beta and experimental for me [20:32:41] yeah section toggling is busted in alpha at least on the main page [20:33:10] jdlrobson, image overlay works for me [20:33:10] huh, amongst other things apparently [20:33:26] only testwiki is super slow and it takes time for the image to show up [20:33:50] BUG:'mobile-frontend-editor-cancel' label on talk save form [20:33:55] (fixing now) [20:34:21] ? [20:34:41] awjr: patch will explain [20:34:43] dr0ptp4kt, is there a meeting today? [20:34:49] kk [20:35:01] yurik, dunno. i'll hop on google talk [20:35:19] awjr, is the content the same for you on beta and alpha? [20:35:53] no jgonera [20:36:00] awjr, for me the content of the main page is different depending on the mode I use (beta/experimental)! [20:36:08] testwiki weirdness? [20:36:08] yeah same jgonera [20:36:12] * awjr shrugs [20:36:20] i dunno - how does it look on betalabs? [20:37:56] (03CR) 10JGonera: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER) [20:38:38] awjr, also a completely different page on beta/experimental [20:38:43] jdlrobson, any ideas? ^ [20:39:00] @_@ [20:39:03] jgonera: elaborate.. main page has some special casing [20:39:13] (in alpha) [20:39:28] elaborate: content of main page in beta != content of main page in alpha [20:39:34] as in 100% different [20:39:34] correct [20:39:40] special casing is DISABLED for main pages in alpha [20:39:52] ok, that explains ;) [20:40:34] that was the part of kill the special casing the main page initative [20:41:00] although we may want to remove that in favour of making it possible to have style tags in templates and fixing all the broken main pages [20:42:09] anyway, section toggling on main page doesn't work in alpha [20:42:32] who is deploying anyway? [20:42:50] (03PS1) 10Jdlrobson: Regression: Ensure cancel button label loads for talk overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85913 [20:42:51] (03PS1) 10Jdlrobson: Regression: Exit talk after a successful save of a new topic [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85914 [20:42:52] jgonera: max [20:43:51] jgonera: ahh.. i think i know why main page does that on alpha [20:44:12] jdlrobson, should we merge those 2 as well? ^ [20:44:25] jgonera: please - talk is a bit broken without them [20:45:09] (03CR) 10JGonera: [C: 032] Regression: Ensure cancel button label loads for talk overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85913 (owner: 10Jdlrobson) [20:45:17]