[00:00:40] (03CR) 10Kaldari: "Is this for test.wiki or en.wiki (or neither/both)?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85941 (owner: 10Cmcmahon) [00:01:09] (03CR) 10MaxSem: [C: 032] Profile: Get correct file for profile page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85935 (owner: 10Jdlrobson) [00:01:33] (03Merged) 10jenkins-bot: Profile: Get correct file for profile page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85935 (owner: 10Jdlrobson) [00:03:15] chrismcmahon: You're back! :) [00:03:47] kaldari: you're back! that was a humongous netsplit [00:04:11] so is that patch for testing test.wiki or en.wiki or both/neither? [00:05:40] (03CR) 10Cmcmahon: "beta labs and production as of right now https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/ an" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85941 (owner: 10Cmcmahon) [00:06:17] kaldari: right now it is beta and enwiki, which should share a config except where that config is overridden for beta [00:07:54] chrismcmahon: hmm, there is a chance that that URL will get changed by the en.wiki community to point to a local page like "Wikipedia:Text of Creative Commons Attribution-ShareAlike 3.0 Unported License" [00:08:19] kaldari: that's cool, the test will fail and we'll then check that the link is correct [00:08:38] OK, sounds like a plan [00:10:14] I like tests that fail because something actually changed, not because some string has an indeterminate value. [00:17:09] !logs [00:34:30] maxsem, jgonera, jdlrobson, awjr: The "Terms of Use" link is a bit more problematic than the others. MediaWiki doesn't have any concept of a "Terms of Use" link. It isn't a standard footer link, unlike the others. So on non-Wikimedia wikis, should we even have a "Terms of Use" link in the mobile view? There is no equivalent in the desktop view. [00:34:51] This is in reference to https://mingle.corp.wikimedia.org/projects/mobile/cards/1187 [00:35:43] kaldari: personally i'd say this is not a high enough priority and we should stick it in the backlog [00:36:36] fair enough. it will definitely be a tricky one to figure out how to implement correctly. [00:37:07] I'll move it to the backlog for now [00:37:44] good questions for kenan - and probably legal :) [00:37:52] im heading out - have a good night everyone [00:47:39] (03PS9) 10JGonera: Use .less files directly in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER) [00:54:04] (03PS10) 10JGonera: WIP: Use .less files directly in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER) [00:54:48] (03CR) 10Kaldari: [C: 032] link text is not consistent, check for target instead, see comment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85941 (owner: 10Cmcmahon) [00:55:11] (03Merged) 10jenkins-bot: link text is not consistent, check for target instead, see comment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85941 (owner: 10Cmcmahon) [05:18:50] (03PS1) 10Mgrover: QA#1251 Create a first time user to make sure that the tutorial displays for uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85955 [06:38:41] (03CR) 10Mgrover: "I started looking at it but I have a few questions so Jon I'll try to chat with you for a bit tomorrow to see exactly what you're trying t" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85138 (owner: 10Jdlrobson) [08:16:44] (03CR) 10Zfilipin: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85955 (owner: 10Mgrover) [08:18:50] (03CR) 10Zfilipin: "The only time today (Wednesday) that would be good for all of us is probably 9am SF time. Sounds good?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85138 (owner: 10Jdlrobson) [08:20:43] (03CR) 10Zfilipin: "It would be better for me if we worked on that tomorrow (Thursday) at the same time (9am SF time)." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85138 (owner: 10Jdlrobson) [11:54:05] MaxSem: did you deploy the profiling changes y'day? [11:54:15] yup [11:54:20] sweeet [11:57:55] https://graphite.wikimedia.org/dashboard/temporary-30 should give an idea [11:58:16] I see no Api stats however - is it called so rarely? [11:58:36] MaxSem: indeed. the only client is the app i'm still writing :P [11:58:50] MaxSem: the API itself is like a month old [11:59:06] so you need to call it a few times [11:59:10] yeah, I can do that ;) [11:59:27] will do once I get off the train [12:59:06] MaxSem: hitting the API endpoint in a loop. [12:59:12] but first one itself hasn't returned yet [13:00:08] MaxSem: lol, still hasn't returned [13:00:09] ugh [13:01:13] MaxSem: ugh, timeouts! [13:01:18] MaxSem: but they're timeouts from nginx [13:01:22] MaxSem: not sure if that means the apache timed out [13:01:23] or not [13:01:50] MaxSem: [13:04:40] now [14:14:32] YuviPanda|train, I'm back [14:14:38] woo! [14:14:53] MaxSem: I sent requests, and I see small little lines there [14:16:23] small lines where? I still don't see ApiQueryAllCampaigns in graphite [14:19:44] MaxSem: hmm, weird. I now realize they aren't from the API [14:19:46] let me hit it more [14:20:11] 1/50 of requests have profiling [14:20:17] ooo [14:20:18] h [14:20:21] that explains it [14:20:25] i ran like 25 [14:20:26] bleh [14:20:34] let me hit run it in a big loop [14:23:24] MaxSem: running httperf now [14:23:31] MaxSem: but since on average this seems to take ~20s... [14:23:42] uuuuuuuuuuuuuuuuuuuuuuuuughhhh [14:24:21] I know, I know [14:24:27] at least we know it isn't a db issue [14:27:06] * MaxSem looks #-ops for pages [14:27:33] in case the latest slowdowns were caused by YuviPanda|train :P [14:27:55] MaxSem: this has been around for a while :P [14:28:16] (03PS1) 10MaxSem: Check latest revision in mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85980 [14:37:01] YuviPanda, it's there! [14:37:08] woo! [14:37:16] dammit, it is lost among my tabs [14:37:40] MaxSem: i've no idea how to read any of it [14:38:12] https://graphite.wikimedia.org/dashboard/ -> everything -> type class name [14:40:48] but the source of slowness is clear: UploadWizardCampaign::getParsedConfig() is 100-200ms, multiply this by the number of campaigns requested [14:41:21] MaxSem: yeah, as I expected. all the parses. [14:41:32] caching is yer friend [14:41:43] MaxSem: there's no easy way to invaliate [14:42:01] so forbit wikitext in descriptions [14:42:04] MaxSem: since the JSON contains wikitext, with templates. [14:42:06] *forbid [14:42:12] MaxSem: pfft. It is a feature, not a bug... [14:42:23] wikitext is in about 4-5 fields, not just description [14:42:47] "cluster meltdown is a feature!":P [14:43:24] heh :P [14:43:28] then you need to track dependencies [14:43:46] I need to plug into whatever jobs based invalidation thing that we use for normal pages [14:44:05] MaxSem: it won't actually melt down, since we do cache in squid. [14:44:12] you already have parser output, use transclusions from it [14:44:14] small period, but we still do. [14:44:49] MaxSem: true. [14:45:10] MaxSem: so where do I look for 'when X changes, I want to revalidate Y'? [14:45:19] * YuviPanda trawls the database structure [14:46:29] I stopped hitting the api endpoint [14:47:16] parse text -> save versions of all transcluded pages -> when needed, get versions from cache -> check revids -> if match, get chached parse results, otherwise parse again [14:47:53] of course, dependency checks have to be batched [14:48:32] MaxSem: it is raw wikitext, not a link to a page. [14:48:54] yup [14:49:08] want me to do that for you? [14:49:14] that'll be aweomse :P [14:49:18] wouldn't it also be recursive? [14:50:00] no [14:52:28] MaxSem: what if I'm parsing {{a}}, and Template:a has {{b}} and then I change Template:b? [14:52:31] shouldn't that invalidate the cache? [14:52:59] it should and it will, if you design dependency tracking properly [14:53:09] right. [14:53:26] it'll be awesome if I can convince you to do that, MaxSem :D [14:54:20] that's a significant chunk of work, I wonder if I need to ask a permission to work on this [14:56:10] MaxSem: I still don't understand what *exactly* you mean when you say 'Dependency tracking', in this context [14:56:17] and I could probably go from there. [14:57:13] 1) get list of pages transcluded in a value [14:57:22] 2) repeat for all values [14:57:38] 3) get revids for them all and cache it [14:57:43] does the parser give me (1) recursively? [14:57:49] yes [14:57:51] aaaha! [14:57:54] then it makes sense :) [14:58:15] shall I continue? [14:58:30] yes. [14:59:37] when you need a parsed config: [14:59:54] 4) get cached dependencies, check revids [15:00:09] 5) if revids match, get cached config [15:00:27] 6) otherwise, parse again [15:00:46] yeah, I understand [15:01:35] this still entails checking current revid for all dependencies, but I guess that'll be still a lot faster than whetever I'm doing [15:02:13] yup [15:02:33] especially if you check them all at once for all requested campaigns [15:03:20] hmm, that code'll get ugly-ish fast, but that'll be incredibly fast since a lot of campaigns will share similar dependencies [15:05:58] MaxSem: the other approach I was considering is to populate templatelinks table with data for the Campaign: page on edit [15:06:18] MaxSem: and then do cache invalidation during LinksUpdate (or similar) [15:06:24] sounds scary [15:06:34] MaxSem: why? it is sortof technically accurate.... [15:06:43] MaxSem: and should make reads a lot faster [15:06:44] will probably work but would be fragile [15:06:58] MaxSem: it is how normal page parser cache invalidation works, no? :P [15:07:05] MaxSem: plus, this won't have to be recursive! [15:07:14] because templates are already re-rendered [15:07:16] hmm [15:07:19] maybe it has to be recursive [15:07:35] MaxSem: but yeah, it is very similar to the method you proposed, except heavy on write time code than read time code [15:08:33] then you could cache page_rouched [15:08:39] *touched [15:09:18] sure, than revid. but rather similar, no? [15:11:49] MaxSem: if I do it on LinksUpdate, it'll be exactly the same technique as used for normal pages [15:11:55] except using memcached instead of parsercache [15:12:03] i'm reading through LinksUpdate now [15:14:27] MaxSem: although that means it'll depend on the job queue to update the cache, and god knows how long those can take [15:15:56] brb [16:44:18] (03PS1) 10MaxSem: Use mobile-friendly HTML for previews [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86001 [16:56:15] (03CR) 10Jdlrobson: [C: 032] Use mobile-friendly HTML for previews [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86001 (owner: 10MaxSem) [16:57:43] (03Merged) 10jenkins-bot: Use mobile-friendly HTML for previews [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86001 (owner: 10MaxSem) [17:03:14] brion: ! [17:03:38] brion: I've had this wonderful idea - how about we do standup over IRC today? [17:03:38] brion: has the advantage of being publicly archived, plus I'm on a train right now :P [17:03:57] \o/ [17:03:58] :D [17:04:21] i'm at home office, we'll see if mhurd gets on irc or hangout first :D [17:04:59] brion: heh [17:05:08] brion: i've tried hangout from a train before. nobody could hear anything [17:05:12] buses were better tho [17:05:40] hehe yeah video chat is sub ideal on noisy crowded transport [17:06:08] brion: yeah, true. [17:07:53] hey mhurd_ [17:08:03] YuviPanda|train: hey! [17:08:15] mhurd_: did you hear about the wonderful idea of doing standup on IRC today? [17:08:24] mhurd_: both to see how it will go, and also because I'm on a train? :D [17:08:28] YuviPanda|train: no but that works for me! [17:08:41] YuviPanda|train: whoa really? [17:08:48] mhurd_: yeah, really. [17:08:55] he's got |train in his username, i think that's pretty legit [17:08:56] mhurd_: i've tried doing standup from trains before. that never worked well [17:09:03] auto rickshaws, buses are slightly better [17:09:06] side of the road works too, mostly [17:09:18] brion: totally :) [17:09:47] mhurd_: brion want to start now? [17:10:28] is kenanwang here as well? [17:10:58] brion: he may be joining the web standup right now [17:11:25] mhurd_: brion if you guys want to do the hangout, you can go ahead and do it - I'll just mail in my standup notes. [17:11:34] mhurd_: you in office or out? [17:11:38] brion: i'll go see if he's there [17:11:43] ok :D thx [17:12:22] brion: he's on the hangout for web's standup [17:12:43] ok let's check in real quick [17:12:46] brion: YuviPanda|train they're almost done [17:12:53] ooh chrome updated [17:12:54] hey I'm at home right now but available [17:13:04] ah great were' all here then :D [17:13:07] :D [17:13:16] yay! [17:13:22] mhurd_: you want to start? [17:13:26] ya [17:14:07] so i tracked down the long delay after the settings icon is tapped. was combination of auto layout issues and slow (on old devices) image filter [17:14:18] yay [17:14:26] today 'm gonna fix the iOS slider inconsistancies [17:14:43] awesome… i believe i've got a stack of little tweaks from you to review already [17:14:47] i'll give you feedback on those later today [17:14:52] sounds good! [17:15:01] that's the quick summary for me [17:15:18] brion next? [17:15:39] ive never seen my computer clock be off! [17:15:41] it's two minutes fast [17:15:52] ok i finally got that little license display on android detail page done -- YuviPanda|train that's awaiting your double-check review :) [17:15:59] nice! [17:16:03] and i've done a whole lot of misc code review & rfc catchup [17:16:05] yay! [17:16:21] yeah, I followed the RFC process. Solid, except for some hijacking now and then :P [17:16:21] also i have a minor update queued to go out for the windows 8 app, which i'll get off my plate as quick as i can :) [17:16:38] tim kept us time boxed on that rfc meeting, it was good :D [17:16:42] out in an hour :D [17:16:45] indeed. [17:16:58] MaxSem: the api is horrible [17:17:00] am I next? [17:17:14] YuviPanda|train: you are next. [17:17:18] so that change you made returns the response in the form { parse: { text: 'html here' } } [17:17:22] no it's not [17:17:35] brion: mhurd_ so MaxSem helped me add profiling for the slow calls in the Campaigns stuff - turned out to be the parse calls (as expected). [17:17:39] without that argument it returns it in the form { parse: { text: { '*': 'html here' } } } [17:17:39] wtf [17:17:50] yay parser [17:17:56] brion: mhurd_ we discussed caching mechanisms that have the least read problems, and are easiest to implement. [17:18:03] jdlrobson, then it's a bug [17:18:04] although i prefer the former consistency is more important [17:18:09] lemme fix it [17:18:11] have a couple of approaches that I'll be exploring [17:18:31] brion: mhurd_ other than that, worked on making it possible for people to upload to campaigns they're looking at. [17:18:37] great [17:18:51] nice! [17:18:53] YuviPanda|train: anything i should review currently open? [17:18:55] brion: mhurd_ I'm going to try to fix the perf issue first, since that blocks other work [17:19:00] or shall i await your next ping [17:19:05] brion: nothing as of now [17:19:07] ok [17:19:19] from me :) [17:19:20] kenanwang: any questions or things we should make sure we discuss? [17:19:28] nothing from mem [17:19:29] me [17:19:34] ok then we are done :D [17:19:36] brion: oh i forgot i have some pretty cool stuff to demo next time you're in the office - the new UIButtonDynamicHeight object i whipped together does some crazy stuff when used with auto layout [17:19:39] standup… complete! [17:19:42] awesome [17:19:48] yay! [17:19:55] achievement unlocked [17:19:58] :D [17:20:06] haha [17:20:09] kenanwang: mhurd_: brion how did you like IRC standup? [17:20:20] we used to do this when I first joined the team for a month or so. [17:20:28] i like em. :) it can be easy to get distracted though ;) [17:20:32] yeah [17:20:36] YuviPanda|train: seems fine [17:20:47] agreed [17:21:04] works fine with this size of group i think [17:21:05] part of the point of a standup is to make it just *slightly* inconvenient so you don't want to spend too long at it ;) [17:21:10] e3 has a bot that orders people around, and perhaps we can steal that too, to prevent 'who is next' issues? [17:21:20] heh ncie [17:21:22] *nice [17:21:27] kenanwang: indeed. this is like, 3.5 people? [17:21:30] heheh [17:21:37] :D [17:21:44] i have no prob doing irc standup if someone's on a slow connection [17:22:31] word [17:23:09] brion: the caching stuff, I'm going to try to use templatelinks to track dependent templates, and then update them. [17:23:30] excellent [17:23:46] *update them in LinkUpdate [17:23:46] or similar. [17:23:46] so that reads are always cached, and they are invalidated on write [17:23:46] brion: MaxSem considers it brittle, and I guess that is true [17:23:55] brion: but that's entire mediawiki's parser caching technique, so... :P [17:24:01] yep :D [17:24:29] (03PS1) 10Jdlrobson: Regression: Fix previews [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86004 [17:24:35] ^ jgonera important patch - previews broken without it :) [17:24:51] jdlrobson, basically: OH SHIT [17:25:18] are they broken in production jdlrobson ? [17:25:22] there are other users of this API, so I can't make it consistent right away [17:25:26] on master yes [17:25:33] jgonera, in prod no [17:25:38] nono, I mean, enwiki, eswiki, plwiki, everywhere [17:25:40] ok [17:25:44] jgonera: no Max's change just introduced it [17:25:59] see patch for narrative [17:26:08] I'm looking at it [17:26:23] getting off train, brb [17:26:24] jdlrobson, you don't need such tricky detection, mobileformat=html is now always there [17:28:06] kenanwang: in terms of user profiles what kind of information would be useful to log for you [17:28:29] is it simply how many times a link is clicked on or is it number of times clicked on by unique users [17:28:48] what do you want to measure? [17:28:59] MaxSem: I'm future proofing that code [17:29:08] ok, makes sense [17:29:27] the existence of the FIXME says it should die at some point [17:29:28] I'd love to know generally: how much its used, how people get there, who engages with the page, [17:29:41] kenanwang: are you interested in the type of user? [17:29:43] e.g. edit count [17:29:54] yes [17:29:55] are you in the office today kenanwang ? we could make a schema to describe this [17:30:39] yeah [17:30:40] i will be [17:30:44] in about 20-30 [17:30:59] ok [17:32:06] (03CR) 10JGonera: [C: 032] Regression: Fix previews [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86004 (owner: 10Jdlrobson) [17:32:31] (03Merged) 10jenkins-bot: Regression: Fix previews [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86004 (owner: 10Jdlrobson) [17:32:42] * jgonera heading to the office [17:33:34] (03CR) 10Dr0ptp4kt: [C: 032] Refactor some of the warning code for footer links. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85391 (owner: 10Kaldari) [17:33:36] (03Merged) 10jenkins-bot: Refactor some of the warning code for footer links. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85391 (owner: 10Kaldari) [18:09:04] jdlrobson: i wrote down the wrong bug number to follow up with kenan (that he is supposed to WONTFIX) - was it https://mingle.corp.wikimedia.org/projects/mobile/cards/1250? [18:11:16] awjr: nope [18:11:24] https://mingle.corp.wikimedia.org/projects/mobile/cards/1195 [18:12:06] that's a wontfix? i thought we were looking into that one [18:12:22] no we agreed 2 stand ups ago it was a wontfix [18:12:32] woops ok [18:12:39] thanks [18:32:19] (03CR) 10JGonera: [C: 032] Profiles: Stop the heading from being a link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85804 (owner: 10Jdlrobson) [18:32:45] (03Merged) 10jenkins-bot: Profiles: Stop the heading from being a link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85804 (owner: 10Jdlrobson) [18:33:53] (03CR) 10JGonera: [C: 032] Beta: Link diff page to user profile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85802 (owner: 10Jdlrobson) [18:34:17] (03Merged) 10jenkins-bot: Beta: Link diff page to user profile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85802 (owner: 10Jdlrobson) [18:36:31] when are we planning on allowing redlinks in mobile? Just asking since I'm converting them in ajax loaded notifications as well so I need to keep that synced. [18:36:50] jdlrobson, jgonera, MaxSem: ^ [18:37:37] so far in alpha, guess it'll need more polishing [18:40:48] multichill: yeah, best way to fix bugs - rip out the feature... :P [18:41:30] YuviPanda: No, the best way is to label a bug as a (unintended) feature :P [18:41:48] that's general best way, while this is best non-trolly way [18:41:49] :P [18:47:04] (03PS17) 10Kaldari: Various improvements to mobile notifications... [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 [18:47:25] (03CR) 10Kaldari: Various improvements to mobile notifications... [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 (owner: 10Kaldari) [18:47:30] (03CR) 10jenkins-bot: [V: 04-1] Various improvements to mobile notifications... [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 (owner: 10Kaldari) [18:47:42] (03PS1) 10Jdlrobson: EventLogging: Add generic form of click tracking to mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86010 [18:50:06] (03Abandoned) 10Jdlrobson: Alpha: Enable section toggling on main page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85915 (owner: 10Jdlrobson) [18:51:23] (03PS18) 10Kaldari: Various improvements to mobile notifications... [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 [18:53:21] (03PS1) 10MaxSem: Don't display file name with underscores [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86012 [18:56:04] (03PS2) 10Jdlrobson: EventLogging: Add generic form of click tracking to mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86010 [18:56:31] (03PS19) 10Kaldari: Various improvements to mobile notifications... [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 [18:59:20] (03PS20) 10Kaldari: Various improvements to mobile notifications... [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 [19:01:08] hmm jdlrobson, do we need to collapse sections on category pages? they're never long [19:01:14] (03CR) 10Kaldari: [C: 04-2] "Don't merge until change I9fa8c450 is merged." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 (owner: 10Kaldari) [19:02:03] i'm not sure we should be using -2 to mean 'pending on dependency'… i kinda feel like it means 'kill this with fire and never come back with it' [19:02:08] marktraceur: i'm still a little confused about the best approach for registering a core beta feature - https://gerrit.wikimedia.org/r/#/c/79948/ [19:03:02] jdlrobson: What seems to be the trouble? [19:03:10] jdlrobson, shouldn't that CSS should just go to Betafeatures? [19:03:19] Nooooo. [19:04:10] marktraceur: https://gerrit.wikimedia.org/r/#/c/79948/ = Nooooo. OR MaxSem: jdlrobson, shouldn't that CSS should just go to Betafeatures? = Nooooo. ? [19:04:20] The latter [19:04:36] i prefer that answer ;-) [19:04:51] jdlrobson: You should be able to "just" register the hook after all of the extensions have been loaded [19:04:53] i'd rather we had a standard way to have beta features that result in core changes [19:05:07] jdlrobson: Honestly I never considered that use case [19:05:10] marktraceur: where would be the neatest place to do this? I notice core doesn't register any hooks [19:05:21] Let me see. [19:05:26] marktraceur: this is why i'm involving you so we can work out the best way to do it :) [19:05:44] i want to core to have a nice beta environment like mobile where people can make drastic changes to skins etc [19:05:59] awjr, can you take a look at https://mingle.corp.wikimedia.org/projects/mobile/cards/1151 ? [19:06:00] not too much of a rush as I still need to get https://gerrit.wikimedia.org/r/#/c/85920/2 merged [19:06:11] aye [19:06:41] MaxSem: i wont be able to dig into it until later this afternoon [19:06:43] that ok? [19:06:50] jdlrobson: We could probably talk about moving the BetaFeatures functionality into core after a while, but it'll take some cajoling [19:06:57] yup, thank you awjr [19:06:58] jdlrobson, jgonera: https://gerrit.wikimedia.org/r/#/c/82073/ is ready for a re-review whenever you have time. It is dependant on one more small Echo change which Benny is going to review later today. [19:07:13] marktraceur: have you got time later today to work on this? maybe we could hack something up [19:07:18] Mayyyybe [19:07:20] kaldari: sweet [19:07:22] I'm looking right now [19:07:32] I think you can just put the hook registration right after loading BF [19:08:24] Or right after you've loaded all extensionss [19:08:33] Sec, lunch [19:58:23] jgonera: http://stackoverflow.com/questions/5797014/why-do-browsers-match-css-selectors-from-right-to-left [20:00:01] awjr: trying to get set up in r31 [20:00:08] tv not turning on though [20:00:38] o [20:02:34] what was the URL for that planning poker site? hatjitsu or something [20:05:26] kaldari: http://hat.jit.su/ [20:06:07] kaldari: although it seems to be down... [20:06:14] boo [20:06:26] kaldari: weird... [20:07:30] kaldari: https://github.com/richarcher/Hatjitsu [20:51:27] (03PS1) 10Amire80: Add convertNumber to localize the distance [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86027 [21:33:15] (03CR) 10Kaldari: [C: 04-1] "Please add mediawiki.language as an explicit dependency for the mobile.nearby module." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86027 (owner: 10Amire80) [21:55:20] (03PS21) 10Kaldari: Various improvements to mobile notifications... [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 [21:56:15] olololololollllllllllllllll [21:56:36] aharoni: had a minor tweak suggestion for your Mobile patch [21:56:46] How do you think would == foo == would look after parsing? [21:57:41] no idea [21:58:47] wow, that actually works [21:59:26]

Foo

[21:59:52] TWO freaking headings instead of one! [21:59:56] what a mess [22:13:49] MaxSem: ? works for me... [22:14:26] jdlrobson, https://en.wikipedia.org/wiki/User:MaxSem/sandbox [22:14:56] weird.. i can't replicate that on my local instance [22:15:21] tidy going insane? [22:25:42] violetto1: vbamba so i have an icon for echo when not logged in... [22:25:50] does that mean we want to bring back the CTA for it? [22:26:28] what [22:26:52] well currently if you are not logged in the echo icon doesn't show [22:27:05] Jon, coming over to your desk [22:30:08] aharoni: what's the tweak? [22:30:28] violetto1: come over here [22:30:31] you're in trouble [22:33:34] Mayster, Jon has the icons live, they could use a size adjustment but you're the best judge [22:40:40] was with brandon [22:40:43] back now, where yall [22:45:30] vbamba, violetto can't find you [22:46:54] coming [22:48:00]