[00:01:59] kaldari: dunno if you've found a designer yet but looks like vbamba just joined the channel [00:02:22] huh im getting a timeout when trying to do a git pull - anyone else haivng issues? [00:02:23] vbamba: you're it! [00:03:16] what is the q [00:03:39] I can help with design related q's [00:04:16] i dunno, all i know is kaldari was looking for a designer earlier :) [00:04:31] he seemed concerned that someone absconded with the entire design team. [00:04:52] (03PS3) 10Jdlrobson: Story 475: Link user profile from left menu in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85803 [00:04:53] (03PS1) 10Jdlrobson: Make watchlist user icons consistent with rest of UI [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86052 [00:06:00] (03CR) 10Jdlrobson: [C: 032] Don't display file name with underscores [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86012 (owner: 10MaxSem) [00:06:39] (03CR) 10Jdlrobson: "Michelle said she needs to create a separate account for users with no uploads..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85712 (owner: 10Jdlrobson) [00:06:57] (03Merged) 10jenkins-bot: Don't display file name with underscores [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86012 (owner: 10MaxSem) [00:11:19] awjr: thanks, met with vibha [00:11:26] questions answered [00:11:37] steven walling absconded with the entire design team [00:11:39] reportedly [00:11:42] (03CR) 10Jdlrobson: [C: 032] Make language variant selection possible on all pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85923 (owner: 10JGonera) [00:11:55] * awjr shakes a fist at swalling [00:12:02] vbamba: you guys need pagers :) [00:12:17] (03Merged) 10jenkins-bot: Make language variant selection possible on all pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85923 (owner: 10JGonera) [00:17:27] i think google is basically doing device detection for us.... [00:17:39] which i think might be what's going on with https://bugzilla.wikimedia.org/show_bug.cgi?id=53667 [00:17:41] or part of it [00:20:45] if i spoof my desktop browser to be a mobile UA, and i google something (like 'peanut butter'), the link shown to me is the appropriate canonical URL (en.wikipedia.org/wiki/Peanut_butter), but this is the actual href: https://www.google.com/url?q=http://en.m.wikipedia.org/wiki/Peanut_butter&sa=U&ei=Un1DUqzYE-f1iwLZrIDIDw&ved=0CAsQFjAA&usg=AFQjCNFVQI5kCxyNvpfEoDK9CevH0Ck4Bg [00:21:27] note that it points to the .m [00:21:56] even if you have the stopMobileRedirect cookie, you can still explicitly hit the .m and get the mobile version of the site (by design) [00:22:21] so if google is doing this on purpose, they are causing problems who have the stopMobileRedirect cookie set :( [00:22:32] *causing problems for people [00:22:37] MaxSem: ^ [00:22:49] we don't control external services [00:23:16] did you manage to repro the actual result with a manualy entered URL? [00:23:48] heh no i got sidetracked by this :p [00:25:21] hmm using an opera mini UA gives me JS errors in prod [00:26:20] MaxSem: i cannot repro the issue with a manually entered URL (eg: en.wikipedia.org) - when i do that, i get taken to https desktop (as expected) [00:26:36] so dude might be following google links or otherwise links explicitly to the .m [00:26:55] mhm [00:27:31] ask Michelle if she can repro? [00:37:38] (03PS2) 10Jdlrobson: Make watchlist user icons consistent with rest of UI [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86052 [00:37:39] (03PS4) 10Jdlrobson: Story 475: Link user profile from left menu in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85803 [00:48:20] (03PS3) 10Jdlrobson: Make watchlist user icons consistent with rest of UI [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86052 [00:48:21] (03PS5) 10Jdlrobson: Story 475: Link user profile from left menu in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85803 [01:11:12] (03PS1) 10JGonera: [WIP] Hygiene: Clean up ui.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86058 [01:22:24] (03PS1) 10Kaldari: Migrating Mobile thanks into Thanks extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86061 [01:23:52] (03PS15) 10Dr0ptp4kt: Better prevent chargeable resources from being inadvertently accessed. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 [01:26:41] (03PS16) 10Dr0ptp4kt: Better prevent chargeable resources from being inadvertently accessed. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 [02:46:07] (03CR) 10Ori.livneh: "> // need to assign to a temporary variable to preserve commas" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER) [03:49:06] (03CR) 10Mgrover: "Sorry had connectivity issues all day. Yes I know that it would defeat the point of captcha which is why i asked the devs if there was so" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85955 (owner: 10Mgrover) [06:30:12] !logs [07:17:52] (03PS2) 10Yurik: Big refactoring of PageRenderingHooks to avoid globals [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85854 [07:19:55] (03PS3) 10Yurik: Big refactoring of PageRenderingHooks to avoid globals [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85854 [08:12:58] hello [08:13:16] hi cortexA9 [08:13:40] hi YuviPanda [08:15:35] YuviPanda: i have one question about the android app wikipedia mobile [08:15:42] sure! [08:16:04] i'll note that the current app is pretty much deprecated and unsupported. We're planning on starting work on a native version in November. [08:16:48] YuviPanda: is it possible to make an interactive map in the app ? [08:16:54] * Dcoetzee waves to everyone [08:16:59] hello Dcoetzee [08:17:02] hi Dcoetzee [08:17:06] It already has an interactive map, like I said :-P [08:17:10] indeed. [08:17:12] Nearby articles [08:17:14] yes [08:17:33] but we can't send messages to other wikipedians. [08:17:41] Yeah cortexA9 has this idea [08:17:48] In which we use user location category information [08:17:51] :) [08:17:53] To show some Wikipedians on a map [08:18:06] And then can tap and leave them talk page messages or email them [08:18:10] hmmm [08:18:17] It seems kinda neat, although the locations would necessarily be imprecise [08:18:19] first thing that would require is a way to figure out where users are [08:18:29] yes with GPS location. [08:18:37] aha [08:18:38] i think. [08:18:54] hmmm, nice idea - though the privacy implications need to be thought out [08:18:57] Well you can do GPS (or approx GPS) with users using the app of course [08:18:59] If they opt in to it [08:19:01] but I agree that this is a great enablr [08:19:02] indeed [08:19:10] cortexA9: can you file a bug so that this doesn't get lost? [08:19:16] ok [08:19:19] where ? [08:19:25] bugzilla.wikimedia.org [08:19:28] thanks [08:19:29] product 'Wikipedia App' [08:19:47] thanks, cortexA9! [08:19:53] cortexA9: You should mention https://en.wikipedia.org/wiki/Category:Wikipedians_by_location [08:19:57] no problem [08:20:02] yea Dcoetzee [08:20:12] It is imprecise though, not quite as suited to a plain old Maps mashup [08:20:36] Maybe would work better with polygons on Maps and a pop up list or page or something [08:28:37] ok added. [08:29:42] ty, cortexA9 [08:30:18] YuviPanda :) [08:33:55] good [09:50:28] android recorded videos are not playing in html5 base webpage [12:20:40] 01[13Commons-iOS01] 15siebrand pushed 1 new commit to 06master: 02http://git.io/1tEhDw [12:20:40] 13Commons-iOS/06master 141702985 15Siebrand Mazeland: Localisation updates from http://translatewiki.net. [12:21:49] (03CR) 10Siebrand: [C: 032] Fix typo. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86096 (owner: 10L10n-bot) [12:22:15] (03Merged) 10jenkins-bot: Fix typo. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86096 (owner: 10L10n-bot) [14:29:24] 01[13WikipediaMobile01] 15siebrand pushed 1 new commit to 06master: 02http://git.io/z8FJkw [14:29:25] 13WikipediaMobile/06master 1462cb591 15Siebrand Mazeland: Localisation updates from http://translatewiki.net. [14:49:56] 01[13WLMMobile01] 15siebrand pushed 1 new commit to 06master: 02http://git.io/VSY6RQ [14:49:56] 13WLMMobile/06master 14c3189ba 15Siebrand Mazeland: Localisation updates from http://translatewiki.net. [16:04:12] hello, we have an OTRS ticket from a user who says the contact link on mobile took them to https://en.wikipedia.org/w/index.php?title=Special:MobileFeedback&feedbacksource=WikipediaMobile%2F1.2 which doesn't exist [16:04:16] is this a known bug? [16:06:05] duh, this thing was killed aeons ago, so must be a link on-wiki [16:06:54] duh: on-wiki or in the app perhaps? [16:06:55] hmm, or in app [16:06:59] WikipediaMobile%2F1.2 [16:07:03] in app i think [16:07:10] 2013092310001478 if you have OTRS access [16:07:10] 1.2? hmm i think that's old too [16:07:17] duh, tell them to upgrade [16:07:23] heh :P [16:07:25] ok [16:07:36] thanks by the way!:) [16:07:37] what's the current version? [16:07:41] but i suspect even the current has the bug :) [16:07:48] https://play.google.com/store/apps/details?id=org.wikipedia <- 1.3.4 on android, looks like [16:08:38] ok [16:08:46] brion, confirmed with current version [16:08:57] duh, upgrade is pointless [16:09:01] d'oh [16:09:03] we screwed up:P [16:09:39] lol, and the current version says precisely WikipediaMobile/1.2 [16:09:41] if you file a bug for it, i'll link it to them [16:09:44] heh >.> [16:10:10] there is also some feedback in the email too [16:10:16] do either of you have OTRS access? [16:10:25] about colors and not being able to scroll [16:10:37] I don't have anymore [16:11:00] (and am very pleased with it, at it drank my blood( [16:12:19] hrm. well if you file a bug for it, i can give them a link to it [16:15:13] YuviPanda, ^^^ :P [16:15:28] the app is for all intents and purposes abandoned and deprecated :P [16:15:35] nooo [16:15:37] fix it! [16:15:38] i don't know how to handle this [16:15:40] brion: ^? [16:16:19] YuviPanda: should i recommend they just use a web browser to get the normal mobile interface? [16:16:27] I'd agree [16:16:39] tell them 'the app is being fixed, we reccomend using the mobile web in the meantime' [16:16:42] or something similar [16:16:43] ok [16:17:09] yeah we could do an intermediate app release with some fixes, but …. meh nobody wants to touch it ;) [16:17:33] bbl [16:19:16] (03PS1) 10MaxSem: Get rid of MobileContext::singleton() in skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86123 [16:25:22] back [16:25:35] did anyone ever get around to filing a bug for it? i can do that just so it doesnt get forgotten [16:26:09] entering [16:27:38] brion, can you check whether the iOS app is also broken? [16:28:10] * duh checks [16:28:12] MaxSem: i assume it is but lemme check [16:28:39] MaxSem: yes, it is [16:28:43] "no such special page" \o/ [16:28:44] yep [16:28:45] thanks [16:29:21] duh: looks like https://bugzilla.wikimedia.org/show_bug.cgi?id=52474 covers this [16:29:50] ah, ok [16:32:03] ok, there's one more mobile ticket in the tech-issues queue [16:32:43] whee [16:33:04] they're saying that on a Nokia Lumia 620 using IE they can't access Wikipedia in desktop nor mobile mode [16:33:25] is there anything known about that phone/OS? otherwise ill respond back asking them for more info since it's a bit vague [16:33:30] I remeber something about it [16:34:08] isn't the problem that they don't have data connectivity at all? [16:34:23] hmm [16:34:24] the particular user, not lumia [16:34:51] duh: so it *should* work [16:34:57] looks like windows phone 8 [16:35:46] i used to have a lumia 920 (fancier model) but it got lost during testing. :) [16:35:57] last i checked on the windows phone 8 emulator though IE was redirecting to mobile fine [16:37:13] hm [16:37:13] ok, i'll ask for more details [16:41:38] * tfinc looks about [16:41:52] with all this new found jetlag the morning is far less evil [16:43:00] tfinc: I'm a zombie now. [16:43:10] YuviPanda: what happened ? [16:43:12] tfinc: also, you get jet lag flying from NY to SF? [16:43:28] tfinc: so i've been waking up at about 2AM when I first got here from SF [16:43:48] tfinc: now managed to pull it up to as late as 8AM, but I can't think or keep my eyes open by 10PM - 11PM :( [16:44:24] YuviPanda: i woke up 2 hours earlier then normal. that actually gave me a great start to my day [16:44:31] if only i could normally do this well in the morning [16:44:31] heh [16:44:42] i've been waking up 8 hours before what i'd consider normal [16:44:47] fucks things up. grr. [16:44:55] i had no idea what to expect as slept from NY -> Chicago and Chicago -> SFO . but i crashed at my normal time [16:45:01] that's good [16:46:51] oh before i forget -- YuviPanda can you take a quick peek at https://gerrit.wikimedia.org/r/#/c/85925/ and make sure I didn't do anything stupid? [16:46:59] looking now [16:47:03] finally got the license label done \o/ [16:47:06] niiice [16:47:16] it was disgustingly easy once i got into it [16:47:29] brion: hehe :P [16:47:59] brion: hmm, just {{self? [16:48:02] brion: :) i'm very happy to have the license drama in code review [16:48:24] YuviPanda: well that's all we're using so far [16:48:32] i can fancy it up for the campaigns [16:48:33] brion: that'll miss things like cc-by-sa-3.0-nl :P [16:48:36] and stuff [16:48:40] aaaaaaaah dang [16:48:44] ok i'll have to make that list longer ;) [16:48:56] YuviPanda: just to confirm -- Media.license should by one of the Prefs.Licenses keys? [16:49:00] or am I putting the wrong values in there [16:49:01] brion: can we keep that 'list of license' in config? [16:49:04] like an XML? [16:49:07] yeah that'd be wise [16:49:13] just a simple map... [16:49:28] +1 [16:49:40] brion: you can use the list from UploadWizard for that [16:49:46] excellent [16:50:31] looks sane otherwise, but I'd definitely want a mapping of licenses [16:50:34] than hard coding 'em [16:50:38] brion: can merge with that, brion :) [16:51:06] excellent. i 'll have that done later today [16:51:09] when you're probably asleep ;) [16:51:10] seet [16:52:50] brion: unrelated, but do you use Vagrant? [16:52:56] if not, you should give it a shot :D [16:53:19] YuviPanda: i keep meaning to fire it up [16:53:26] brion: DO IT! [16:53:27] :D [16:53:30] is it tied into VirtualBox specifically or can it be used with other virtualization tools? [16:54:30] ok yeah looks VirtualBox-specific [16:54:34] * brion reinstalls VirtualBox \o/ [16:54:53] hmm can parallels and virtual box run at the same time? [16:54:57] * brion pushes his CPU to the limits [16:55:30] heh https://www.virtualbox.org/wiki/Linux_Downloads <- the linux downloads list is SO MUCH LONGER than the mac or windows ones [16:55:40] "can't we all just have static builds"? [16:56:32] brion: so you can run it on vmware too, if you want. [16:56:34] reminds me i have to check if there's any reason to update to parallels 9 [16:56:37] but default is to vbox [16:59:13] okay, i'm off now [16:59:17] cya in a few hours, hopefully? [17:02:57] virtual box crashed my mac :D [17:06:41] (03PS2) 10Kaldari: Migrating Mobile thanks into Thanks extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86061 [17:17:44] tfinc: http://blog.burningman.com/2013/09/tales-from-the-playa/holy-war-in-black-rock-city/ [17:19:06] (03Abandoned) 10MaxSem: Better section regex for mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/83099 (owner: 10MaxSem) [17:19:24] jdlrobson: Vibha says the Thanks button needs to be green before it goes live. We don't seem to have any code for green buttons. Is it time to switch to mediawiki.ui, or should I hard code another 1-off? [17:19:55] whack it in mobile. i'm currently in the process of redoing vector in less [17:20:04] will do [17:20:13] tfinc: welcome back :) [17:20:32] my home is a new version of mediawiki.ui will get spun out of that and we can start upstreaming the patterns we have in mobile [17:20:44] tfinc: can you weigh in on the mail from praveena about rescheduling the quarterly review? [17:21:22] jdlrobson: looking forward to it. let me know if I can help [17:21:59] kaldari: you can help me with code review.. i need to get https://gerrit.wikimedia.org/r/#/c/83591/12 merged today or close to merged [17:23:07] ok [17:23:10] awjr: sure [17:23:22] i bet its somewhere deep in my email backlog [17:23:27] Inbox(128) [17:27:56] hmm [17:28:04] YuviPanda|zzzzzz: still awake or actually sleeping? :) [17:28:35] $ update-guest-additions [17:28:35] Cannot determine host VirtualBox version. [17:29:35] hello [17:30:51] (03CR) 10Cmcmahon: [C: 032] QA#1251 Create a first time user to make sure that the tutorial displays for uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85955 (owner: 10Mgrover) [17:32:24] (03PS1) 10Yurik: Added Enable-ESI response header for varnish [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86143 [17:35:19] (03PS2) 10Yurik: Added Enable-ESI response header for varnish [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86143 [17:39:52] yurik, would you please add me to the patchset(s) you would like for me to review, and also list the patchset numbers here for m to tackle for review? i see myself on one of your patchsets, but can't remember if you want me to look at that one, nor if there's another that needs to be reviewed (and in which order). [17:40:22] dr0ptp4kt, few min [17:40:28] yurik, k [17:43:43] dr0ptp4kt, please +2 https://gerrit.wikimedia.org/r/#/c/86143/ -- itsa simple one liner, and I will base the other patch off of it and tell you which one [17:43:53] kaldari: you're review would be useful on https://gerrit.wikimedia.org/r/83591 [17:43:57] dr0ptp4kt, we will be able to deploy the redirect later today [17:44:07] (redirect to main page) [17:44:38] dr0ptp4kt, the patch above works - I tried it on api labs [17:46:44] yurik, i take it mr. bergsma or mr. liambotis has okay'dthe approach in 86143? [17:47:02] yep [17:47:03] yurik, i understand it only turns on selectively, just wanna make sure we're going down the path they'd recommend [17:47:08] yurik, great [17:47:10] dr0ptp4kt, it was mark's idea [17:47:17] yurik, excellent [17:48:09] dr0ptp4kt, once you +2 it, i will rebase the other patch off it [17:52:14] (03CR) 10Dr0ptp4kt: [C: 032] Added 'Enable-ESI: 1' response header for varnish [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86143 (owner: 10Yurik) [17:52:17] (03Merged) 10jenkins-bot: Added 'Enable-ESI: 1' response header for varnish [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86143 (owner: 10Yurik) [17:52:59] yurik, i +2'd it [17:53:02] yurik, awaiting rebase [17:53:08] dr0ptp4kt, thx [17:53:29] yurik, had to restart irc client altogether due to flakey ethernet connection, though [17:53:42] (03PS4) 10Yurik: Big refactoring of PageRenderingHooks to avoid globals [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85854 [17:54:08] dr0ptp4kt, go ahead with https://gerrit.wikimedia.org/r/#/c/85854/ [17:54:13] yurik, thx [17:54:15] there was no conflicts [18:06:51] yurik, 85854 is crashing on localhost:8080. headers = X-CS: 250-99 User-Agent: android X-Subdomain: M [18:07:14] yurik, latest master from core and latest master from MF [18:07:43] dr0ptp4kt, hmm, checking... [18:13:15] MaxSem, hi, what's the best way to formulate a link to "ru.m.wikipedia.org/wiki/Special:XXX" from "en.m.wikipedia.org/wiki/Special:XXX" ? I need to make a redirect target [18:13:25] or it could be .zero.... [18:13:53] don't want to hardcode this stuff [18:14:04] yurik, easiest would be to just use the canonical en name [18:14:25] MaxSem, yes, but what about other language link? [18:14:34] i tried this: Title::makeTitle( NS_SPECIAL, 'ZeroRatedMobileAccess', '', $dfltLang ) [18:15:24] and? [18:16:56] and after using getCanonicalURL() i get http://127.0.0.1:8080/wiki/ru:Special:ZeroRatedMobileAccess [18:17:20] i might not have all the right interwiki tables setup though [18:17:37] but i am not sure it will help [18:17:39] MaxSem, ^ [18:18:01] interwikis are the only way [18:18:31] also, remember that you have eval.php in prod [18:19:54] jdlrobson: review done, just minor fixes needed [18:20:26] yurik, maxsem@tin:~$ cd /a/common/ [18:20:26] maxsem@tin:/a/common$ mwscript eval.php enwiki [18:20:26] > $t=Title::makeTitle( NS_SPECIAL, 'ZeroRatedMobileAccess', '', 'ru' ); [18:20:33] > echo $t->getFullUrl(); [18:20:33] //ru.wikipedia.org/wiki/Special:ZeroRatedMobileAccess [18:21:07] * yurik bows to MaxSem [18:21:28] i shall use this method from hereon! [18:24:32] MaxSem, sorry, but that's not good -- what about m vs zero subdomains? [18:24:53] use your transformation magic [18:25:21] getMobileUrl()? [18:25:58] the transformation magic doesn't touch host [18:26:07] and getMobileUrl simply returns subdomain [18:26:16] i was trying to avoid regexing it :) [18:28:50] no ot touches it if you have host template properly set up [18:29:19] grrrit-wm: (CR) Jdlrobson: "fixed kaldari's comments" [core] - https://gerrit.wikimedia.org/r/83591 (owner: Jdlrobson) [18:30:34] MaxSem, not sure what you mean [18:31:53] $wgMobileUrlTemplate = "%h0.m.%h1.%h2"; [18:32:47] jdlrobson: Why did Jenkins start complaining all the sudden? [18:33:01] kaldari: not sure did something bad get merged? [18:33:23] ResourcesTest::testFileExistence with data set #16 [18:34:10] ergg rebase nightmare [18:34:43] kaldari: fixing [18:35:03] not sure what happened there [18:35:11] but some how code from patch set 3 got into patch set 1 [18:36:00] jdlrobson: it also just started complaining about the comment you added in Resources.php, although it wasn't complaining about it before. [18:36:06] weird [18:36:28] kaldari: yeh that change to Resources.php shouldn't be there.. [18:38:13] kaldari: let's try this again.. [18:38:14] https://gerrit.wikimedia.org/r/83591 [18:39:41] jdlrobson: as soon as jenkins approves, I'll +1 it [18:39:47] thanks kaldari [18:39:58] hope it doesn't complain this time :) [18:40:14] gawd gerrit is slow again today [18:41:15] kaldari: it +1ed :) [18:44:19] ^ brion any chance of a review from you in the path to less? [18:44:44] jdlrobson: i'll look it over when i get to the office after lunch [18:44:49] thanks brion :D [18:44:55] * brion opens it up so he doesn't forget :D [18:47:44] (03PS17) 10Dr0ptp4kt: Better prevent chargeable resources from being inadvertently accessed. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 [19:02:50] (03PS3) 10Kaldari: Migrating Mobile thanks into Thanks extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86061 [19:18:24] (03Abandoned) 10Yurik: Incomplete work in progress, DO NOT COMMIT [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85379 (owner: 10Yurik) [19:19:54] (03PS5) 10Yurik: Big refactoring of PageRenderingHooks to avoid globals [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85854 [19:36:56] (03PS6) 10Yurik: Big refactoring of PageRenderingHooks to avoid globals [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85854 [19:37:52] dr0ptp4kt, i think i fixed it - had some merge issues [19:42:10] (03CR) 10Awjrichards: [C: 031] "This LGTM and works as advertised, though I don't see EventLogging code in latest patchset. Jon, do you want to just add that in a future " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85803 (owner: 10Jdlrobson) [19:47:14] (03PS1) 10Yurik: Changed redirect behaviour for Special:Zero [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86162 [19:47:40] dr0ptp4kt, and i checked in the main page redirect patch per paravoid's request [19:48:28] MaxSem, i guess you meant this: https://gerrit.wikimedia.org/r/#/c/86162/1/includes/PageRenderingHooks.php [19:48:40] line 748 [19:48:50] (on the right) [19:49:18] yup [19:58:49] (03PS2) 10Yurik: Changed redirect behaviour for Special:Zero [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86162 [20:02:51] MaxSem, can we have the same logic for main page link generation? Currently it sprintfs this: '//%s.%s.wikipedia.org/wiki/Main_Page'. Is there a function "get main page for title for a given language?" [20:03:09] nope [20:03:20] just go to /wiki/ [20:03:47] but it still will be hardcoded string [20:04:14] basically, Title::newFromString( 'ru:' ) [20:05:43] yurik, which patchset should i tend to first? [20:06:02] (03CR) 10JGonera: [C: 04-1] "(25 comments)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 (owner: 10Dr0ptp4kt) [20:06:20] dr0ptp4kt, this one is the scarrier one: https://gerrit.wikimedia.org/r/#/c/85854/ [20:06:33] dr0ptp4kt, followed by https://gerrit.wikimedia.org/r/#/c/86162/ [20:06:41] which is much more palatable [20:07:33] and comiting https://gerrit.wikimedia.org/r/#/c/86147/ will make erik very happy [20:09:00] yurik, okay, i guess i know what i'm doing for the rest of the afternoon [20:09:32] dr0ptp4kt, you kidding? i hoped to get it out in the lightning deploy phase in the next few min :) [20:09:59] but maybe you are right, no need to rush this one [20:10:04] yurik, we'll see [20:13:37] (03CR) 10Jdlrobson: [C: 04-1] "Breaks desktop version of SkinMinerva" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86123 (owner: 10MaxSem) [20:14:14] (03CR) 10Jdlrobson: [C: 031] "Not sure how to test but looks harmless. Maybe Arthur can look at this?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85980 (owner: 10MaxSem) [20:17:35] awjr_lunch: what's the subject line of the email you need me to look at ? [20:18:01] tfinc: Oct. 9th - Mobile Contributions Quarterly Review Meeting [20:18:11] going afk now for lunch, back in a bit [20:18:26] jdlrobson, huh - there's desktop and mobile minerva? [20:18:43] MaxSem: has been since the beginning but you have to enable it [20:18:52] that's why there is SkinMinerva and SkinMobile [20:18:59] i want to kill SkinMobile in a fiery death [20:19:17] $wgValidSkinNames['minerva'] = "Minerva"; < MaxSem [20:19:37] this I have. I tested with ?useskin=minerva, WTF [20:20:18] it would be useful to apply the formatter section changes to the desktop version so they are more or less the same [20:20:18] as the matter of fact, if you want to show Minerva to tablets, you _have_ to kill SkinMobile;) [20:20:30] MaxSem: yup [20:20:34] otherwise, our cache hit rate will drop below basement [20:20:50] we need to try upstreaming those section changes [20:21:16] and the ability to rewrite urls with the mobile url [20:21:53] FFS, this should never go into core - we need to kill that nasty hack instead [20:22:50] MaxSem: but how i've explained to you many times before we can't do section toggling without wrapping those sections in divs or breaking out the html into a template sections variable rather than bodytext [20:23:05] so we need to find /some/ way to do that and that will result in a core change [20:23:11] I was referring to "and the ability to rewrite urls with the mobile url" [20:23:18] awjr_lunch: MaxSem do either of you have a software eng backend jd up on office wiki or other ? [20:23:32] jd? [20:23:33] I see and I guess the only way to do that is deprecate the .m domain? [20:23:39] ah, job description [20:23:51] jdlrobson, yup [20:23:59] yurik, would you please fix ApiZeroConfig.php and resubmit 85854? [20:24:16] PageRenderingHooks::getConfig doesn't work [20:25:07] so MaxSem I tend to use the word upstreaming to also meaning remove no long necessary stuff, rewrite code amongst other things… which can be confusing.. ;-) [20:25:10] ^yurik, that is to say it has a different contract now [20:26:36] yurik, then rebase the other one, too [20:26:48] MaxSem: awjr_lunch: if found this old one https://office.wikimedia.org/wiki/Job_descriptions/Software_Engineer_(Backend) [20:27:12] dr0ptp4kt, you are a testing monster! [20:27:25] MaxSem: awjr_lunch : how accurate is that in terms of your responsibilities for backend tasks ? [20:27:31] fxing... [20:27:35] yurik, i'm sorry? thx [20:27:46] dr0ptp4kt, it was a compliment :) [20:27:49] (03CR) 10Jdlrobson: [C: 04-1] "(8 comments)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 (owner: 10Dr0ptp4kt) [20:27:55] tfinc, I'd say less mysql, more caching [20:28:00] k [20:28:01] yurik :) [20:28:14] also, some stuff looks very senior [20:28:23] "Conduct design and code reviews for Wikimedia employee and volunteer developers." [20:28:48] design reviews = very sr/architect [20:38:31] yurik: i'm hangout. ready when you are [20:38:47] tfinc, oops [20:55:53] vbamba: I got some stuff for you to look at [21:01:01] kaldari and jgonera: could you take a look at the profile stuff today? [21:01:18] jdlrobson, yep, will do [21:01:19] kaldari: is this ready to go now if i review it ? https://gerrit.wikimedia.org/r/#/c/82073/ [21:03:18] kaldari: i'm in r33 whenever your ready [21:03:36] jdlrobson: yes [21:03:47] tfinc: one sec [21:05:20] jdlrobson: see my comment on https://gerrit.wikimedia.org/r/#/c/85803/ ? [21:06:37] tfinc: the JD looks good to me - i would add frontend skills to add'l qualifications (JS, CSS); imo that would be a big bonus [21:06:41] awjr: https://gerrit.wikimedia.org/r/#/c/86010/ [21:08:25] cool jdlrobson - so i presume module.hijackLink( '#mw-mf-page-left .icon-profile a', 'hamburger-profile' ); covers EL for profile stuff? [21:09:02] awjr: yup [21:09:26] (03CR) 10Jdlrobson: "https://gerrit.wikimedia.org/r/#/c/86010/ takes care of EventLogging." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85803 (owner: 10Jdlrobson) [21:09:44] (03CR) 10Awjrichards: [C: 032] Story 475: Link user profile from left menu in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85803 (owner: 10Jdlrobson) [21:10:30] (03Merged) 10jenkins-bot: Story 475: Link user profile from left menu in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85803 (owner: 10Jdlrobson) [21:16:54] (03CR) 10Jdlrobson: [C: 04-1] "Says WIP. Is this still the case or does this want to be merged?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86058 (owner: 10JGonera) [21:19:52] (03CR) 10Jdlrobson: [C: 04-1] "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86061 (owner: 10Kaldari) [21:25:09] (03CR) 10Jdlrobson: "I'm not sure about this..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86061 (owner: 10Kaldari) [21:30:06] what's the URL of the documentation page that has what is in Alpha, Beta, and Stable? I can't find it. [21:30:19] jgonera: ^ [21:31:58] (03CR) 10Awjrichards: [C: 032] Check latest revision in mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85980 (owner: 10MaxSem) [21:32:07] jdlrobson: ^ [21:32:09] jdlrobson, ^ [21:32:20] (03Merged) 10jenkins-bot: Check latest revision in mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85980 (owner: 10MaxSem) [21:32:42] kaldari, https://www.mediawiki.org/wiki/Mobile/Release_history [21:32:49] thanks! [21:34:06] (03CR) 10Awjrichards: [C: 04-1] "The associated test should be updated to reflect this change (although it still passes atm)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85865 (owner: 10MaxSem) [21:35:00] (03PS7) 10Yurik: Big refactoring of PageRenderingHooks to avoid globals [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85854 [21:36:01] (03PS3) 10Yurik: Changed redirect behaviour for Special:Zero [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86162 [21:36:41] dr0ptp4kt, fixed :) [21:36:44] sorry for the delay [21:36:46] jdlrobson, what do we need overflow: hidden in #mw-mf-main-menu-button for? [21:48:27] (03CR) 10Jdlrobson: [C: 04-1] "(6 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 (owner: 10Kaldari) [21:49:35] jgonera: awjr is it still any inline block element? [21:49:51] the text of inline block elements with overflow hidden doesn't disappear unless the latter is present [21:50:08] I jsut removed it and it didn't change a thing [21:51:44] MaxSem: boooo https://en.m.wikipedia.org/w/index.php?title=Special%3ARandomInCategory&category=Fun [21:51:58] jgonera: i suspect it is old code from a time when it was inline block [21:53:31] jdlrobson, Wikipedia: fucking serious business [21:54:22] woww you can ipsum lorem it too [21:55:14] dr0ptp4kt, any questions? [21:55:29] or any issues? :) [21:55:30] MaxSem: hehe [21:55:31] https://en.m.wikipedia.org/w/index.php?title=Special%3ARandomInCategory&category=Lorem%20ipsum%20dolor%20sit%20amet,%20consectetur%20adipiscing%20elit.%20Nunc%20volutpat%20auctor%20mauris%20vel%20laoreet.%20Donec%20in%20lectus%20magna.%20Mauris%20lacinia%20enim%20a%20risus%20luctus%20mattis.%20Donec%20quis%20enim%20enim.%20Quisque%20porttitor%20sapien%20et%20consequat%20tincidunt.%20Quisque%20sed%20massa%20ut%20nibh%20 [21:55:33] ta%20gravida%20at%20sed%20mauris.%20Nunc%20tempus%20mauris%20ut%20sem%20mollis,%20et%20blandit%20augue%20suscipit.%20Donec%20luctus%20nunc%20nibh,%20id%20posuere%20metus%20sagittis%20sit%20amet.%20Praesent%20ligula%20orci,%20bibendum%20et%20justo%20quis,%20adipiscing%20accumsan%20purus.%20Ut%20ut%20ligula%20quis%20magna%20gravida%20elementum%20sit%20amet%20ut%20eros.%20In%20augue%20tellus,%20venenatis%20pulvinar%20cong [21:55:34] 0dapibus,%20pulvinar%20quis%20ligula.%20Integer%20vestibulum%20ipsum%20cursus%20augue%20pretium,%20nec%20placerat%20elit%20fringilla.%20Aliquam%20vestibulum%20blandit%20mi,%20eleifend%20euismod%20enim%20facilisis%20et.%20Curabitur%20quis%20est%20vestibulum,%20fringilla%20ipsum%20ac,%20gravida%20nibh.%20Pellentesque%20eleifend%20nisl%20id%20auctor%20molestie.%20Maecenas%20porttitor%20et%20lorem%20sed%20hendrerit.%20Quis [21:55:36] 20condimentum%20tellus%20dui,%20eu%20imperdiet%20lacus%20venenatis%20id.%20Morbi%20dictum%20sodales%20felis%20vitae%20mollis.%20Lorem%20ipsum%20dolor%20sit%20amet,%20consectetur%20adipiscing%20elit.%20Curabitur%20nunc%20odio,%20eleifend%20hendrerit%20lobortis%20sed,%20dictum%20id%20justo.%20Mauris%20fringilla%20turpis%20odio,%20vel%20consectetur%20augue%20porta%20vel.%20Suspendisse%20eu%20enim%20sodales,%20rhoncus%20au [21:55:37] 20id,%20ultrices%20nulla.%20Donec%20in%20eleifend%20erat.%20Nulla%20ultricies,%20augue%20eget%20eleifend%20ullamcorper,%20nisl%20dolor%20eleifend%20purus,%20in%20pretium%20quam%20leo%20a%20nisi.%20Nulla%20ultricies%20viverra%20dolor,%20at%20varius%20justo%20viverra%20non.%20Etiam%20ullamcorper,%20ante%20non%20vulputate%20iaculis,%20dolor%20metus%20aliquam%20dolor,%20in%20elementum%20eros%20odio%20eu%20mi.%20Sed%20bland [21:55:38] ??? [21:55:39] 20augue%20nec%20mattis%20consequat,%20justo%20sem%20adipiscing%20turpis,%20eget%20cursus%20urna%20nisi%20ac%20nisl.%20Phasellus%20posuere%20nisl%20eget%20massa%20elementum%20tincidunt.%20Maecenas%20interdum,%20velit%20eu%20iaculis%20consectetur,%20lectus%20quam%20luctus%20ligula,%20a%20porta%20sapien%20est%20non%20nisi.%20In%20ullamcorper%20ligula%20sapien.%20Suspendisse%20porta%20ultricies%20condimentum.%20Nam%20vitae [21:55:40] mperdiet%20purus.%20Aenean%20in%20tincidunt%20mi.%20Duis%20interdum%20odio%20quis%20ligula%20elementum,%20quis%20ultricies%20magna%20hendrerit.%20Ut%20eget%20lacus%20eu%20purus%20ultricies%20iaculis%20ut%20at%20enim.%20Sed%20egestas%20orci%20eget%20rutrum%20rutrum.%20Morbi%20eleifend%20ligula%20dolor,%20sit%20amet%20feugiat%20lectus%20posuere%20nec.%20Donec%20ac%20eros%20eu%20diam%20malesuada%20feugiat%20et%20ut%20lect [21:55:42] 20Pellentesque%20vitae%20ultrices%20orci.%20Vestibulum%20hendrerit%20ante%20ac%20felis%20vehicula%20aliquam.%20Suspendisse%20sit%20amet%20dui%20scelerisque%20libero%20dignissim%20auctor.%20Donec%20eu%20magna%20accumsan,%20lacinia%20magna%20a,%20hendrerit%20nunc.%20Praesent%20ornare%20risus%20vitae%20diam%20tincidunt,%20nec%20condimentum%20nunc%20viverra.%20Sed%20sed%20neque%20ac%20arcu%20eleifend%20placerat.%20Nulla%20 [21:55:43] us%20ante%20eget%20neque%20varius%20semper.%20Ut%20imperdiet%20nisi%20at%20nisi%20porttitor,%20lacinia%20gravida%20diam%20vehicula.%20Phasellus%20eu%20fringilla%20dui,%20id%20iaculis%20orci.%20Pellentesque%20habitant%20morbi%20tristique%20senectus%20et%20netus%20et%20malesuada%20fames%20ac%20turpis%20egestas.%20Mauris%20consectetur,%20velit%20id%20vehicula%20facilisis,%20quam%20quam%20tincidunt%20ante,%20non%20condimen [21:55:45] 20ligula%20lorem%20id%20neque.%20Fusce%20at%20magna%20a%20leo%20mattis%20pellentesque%20a%20quis%20odio.%20Donec%20luctus%20turpis%20eget%20lorem%20porta%20accumsan.%20Vestibulum%20arcu%20metus,%20dictum%20ut%20scelerisque%20ut,%20euismod%20eget%20leo.%20Vivamus%20ac%20ante%20ipsum.%20Pellentesque%20consequat%20gravida%20hendrerit.%20Curabitur%20porttitor,%20purus%20sit%20amet%20hendrerit%20ullamcorper,%20metus%20ligul [21:55:46] euismod%20libero,%20vitae%20tincidunt%20diam%20neque%20in%20nisl.%20Curabitur%20condimentum%20tincidunt%20tincidunt.%20Proin%20dictum%20diam%20non%20aliquam%20ultrices.%20In%20sit%20amet%20arcu%20quis%20erat%20feugiat%20iaculis%20eu%20ac%20quam.%20Quisque%20sed%20metus%20orci.%20Vivamus%20vitae%20consequat%20nunc.%20Interdum%20et%20malesuada%20fames%20ac%20ante%20ipsum%20primis%20in%20faucibus.%20Suspendisse%20in%20mi% [21:55:48] %20velit%20condimentum%20posuere.%20Nam%20varius%20ultricies%20elit,%20eget%20dapibus%20lacus%20ultrices%20aliquet.%20Suspendisse%20imperdiet%20sollicitudin%20lacus,%20in%20semper%20nulla.%20Ut%20vitae%20luctus%20ante,%20in%20ultrices%20tortor.%20Aliquam%20tincidunt,%20tellus%20sodales%20lacinia%20mollis,%20justo%20ligula%20tincidunt%20neque,%20a%20rhoncus%20justo%20nunc%20a%20nibh.%20Etiam%20condimentum%20semper%20eli [21:55:49] 0eu%20interdum%20risus%20dictum%20et.%20Ut%20vel%20rutrum%20orci.%20Ut%20eu%20imperdiet%20tellus.%20Vestibulum%20dapibus%20vitae%20justo%20id%20tempus.%20Aenean%20in%20ornare%20ipsum.%20Nam%20nisl%20diam,%20varius%20et%20adipiscing%20ac,%20egestas%20eget%20quam.%20Pellentesque%20vulputate%20quam%20sed%20ligula%20ultrices%20molestie%20at%20ut%20sapien.%20In%20cursus,%20ligula%20id%20fermentum%20vestibulum,%20lacus%20nul [21:55:51] 0volutpat%20felis,%20nec%20dignissim%20magna%20arcu%20at%20tellus.%20In%20hac%20habitasse%20platea%20dictumst.%20Suspendisse%20fermentum%20non%20diam%20bibendum%20mollis.%20In%20hac%20habitasse%20platea%20dictumst.%20Vivamus%20pretium%20tincidunt%20felis,%20sit%20amet%20vulputate%20velit%20rutrum%20id.%20Donec%20ac%20consequat%20mauris.%20Lorem%20ipsum%20dolor%20sit%20amet,%20consectetur%20adipiscing%20elit.%20Donec%20 [21:55:52] ttis%20augue%20vel%20est%20semper%20semper.%20In%20sit%20amet%20augue%20eu%20elit%20tincidunt%20faucibus.%20Aliquam%20vel%20pulvinar%20erat,%20nec%20cursus%20eros.%20Donec%20iaculis%20justo%20sem,%20et%20bibendum%20odio%20euismod%20vel.%20Sed%20dignissim%20urna%20eget%20eros%20tristique,%20at%20semper%20nisi%20venenatis.%20Vivamus%20a%20nisi%20posuere,%20consectetur%20dolor%20nec,%20posuere%20mauris.%20Mauris%20eleifen [21:55:54] 0urna%20a%20ornare%20molestie,%20tellus%20augue%20laoreet%20tellus,%20a%20fermentum%20purus%20augue%20et%20lacus.%20Suspendisse%20semper%20tellus%20ut%20dolor%20tincidunt,%20eu%20ornare%20metus%20ornare.%20Nunc%20ullamcorper%20placerat%20ipsum,%20vitae%20ultricies%20dui%20facilisis%20sed.%20Quisque%20facilisis%20sapien%20nibh,%20sed%20facilisis%20nibh%20elementum%20eu.%20Etiam%20convallis%20mattis%20justo,%20ut%20vehic [21:55:55] 20ligula%20eleifend%20nec.%20Vivamus%20iaculis%20orci%20id%20elit%20porttitor,%20at%20ornare%20purus%20pulvinar.%20Cras%20porta%20semper%20orci,%20bibendum%20volutpat%20felis%20pretium%20et.%20Sed%20justo%20nunc,%20vulputate%20id%20hendrerit%20eget,%20pharetra%20ut%20libero.%20Maecenas%20blandit%20ut%20justo%20in%20semper.%20Mauris%20auctor%20ligula%20in%20nisi%20aliquam,%20sed%20convallis%20orci%20mattis.%20Praesent%2 [21:55:57] %20fermentum%20elit.%20Duis%20rhoncus%20pulvinar%20est,%20vel%20consectetur%20magna.%20Quisque%20eu%20metus%20euismod,%20dignissim%20urna%20id,%20tristique%20arcu.%20Nam%20facilisis,%20enim%20et%20malesuada%20convallis,%20nisi%20ante%20tempor%20leo,%20sit%20amet%20pharetra%20leo%20tellus%20ut%20sem.%20Praesent%20pellentesque%20nunc%20sodales%20ante%20gravida%20rutrum.%20Vestibulum%20volutpat,%20nisl%20sed%20imperdiet%2 [21:55:58] ta,%20ipsum%20sapien%20facilisis%20libero,%20a%20pulvinar%20nunc%20orci%20id%20massa.%20Integer%20et%20elit%20lorem.%20Fusce%20aliquet%20bibendum%20eros,%20non%20dignissim%20turpis%20dictum%20eget.%20Proin%20at%20pellentesque%20nunc.%20Vestibulum%20in%20elementum%20arcu.%20Morbi%20tristique%20sagittis%20nisl%20ac%20cursus.%20Donec%20vitae%20erat%20at%20enim%20fringilla%20fermentum [21:55:59] sorry for the spam [21:56:00] couldn't find a way to shorten it but it made me laugh [21:56:15] O__o [21:56:16] jdlrobson: too bad that isn't a QueryPage [21:56:21] * MaxSem glares at jdlrobson [21:56:38] then it would get an API for free [21:56:59] (03CR) 10Mgrover: [C: 032] QA: Add QA tests for I3f49cd50ed0c1778f8914b45cbc492fcc1775ca6 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85712 (owner: 10Jdlrobson) [21:57:22] (03Merged) 10jenkins-bot: QA#1251 Create a first time user to make sure that the tutorial displays for uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85955 (owner: 10Mgrover) [21:57:23] (03Merged) 10jenkins-bot: QA: Add QA tests for I3f49cd50ed0c1778f8914b45cbc492fcc1775ca6 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85712 (owner: 10Jdlrobson) [21:57:54] apologies to people with an irc client that didn't shorten that url :) [21:59:32] https://gerrit.wikimedia.org/r/86010 needs to be merged before the profiles story can be considered complete fyi [21:59:42] yurik, sorry, was occupied with 1:1, will resume review shortly [22:00:29] jdlrobson: can you poke kenan to set up a hangout for the overlay mtg? [22:00:36] (03PS3) 10Jdlrobson: EventLogging: Add generic form of click tracking to mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86010 [22:00:37] awjr: sure [22:00:41] ty [22:00:49] (03PS2) 10JGonera: Hygiene: Clean up ui.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86058 [22:01:51] (03PS3) 10JGonera: Story 1030: Clean up ui.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86058 [22:02:40] uuuuugh [22:02:41] https://www.mediawiki.org/wiki/Mobile_browser_testing [22:02:53] was ist das, and can we kill that page? [22:04:50] that looks very old MaxSem [22:05:06] jcmish, tfinc may have more knowledge about that ^^ [22:06:28] k cool [22:06:29] thanks [22:07:08] I think it's pretty old MaxSem let me make sure the other test pages [22:07:15] have all the info and then I'll take care of it [22:08:04] awjr: super busted keyboard in r37 delaying everything [22:08:08] doh [22:08:22] did someone spill coffee on it or something? [22:09:14] tfinc: i also still need a hangout link :) [22:09:46] (03CR) 10Kaldari: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86061 (owner: 10Kaldari) [22:10:23] wow that page was last meaningfully modified in 2011 MaxSem, jcmish [22:10:30] haha I know [22:10:48] I'm just skimming the words to see if anything on it is still true and needs to be captured [22:11:32] another zombie: https://www.mediawiki.org/wiki/Wikimedia_Mobile_engineering/Browsers_support_status [22:11:53] tfinc: as much as i'd like to be in that conversation, if it's taking this long to get remote set up im fine not attending (assuming im the only remotie) so long as someone catches me up afer [22:12:11] (03PS4) 10Kaldari: Migrating Mobile thanks into Thanks extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86061 [22:16:00] awjr: thanks . were doing that [22:16:18] track pad was busted and the keyboard was barely working [22:16:31] MaxSem: I don't have access to delete :( [22:16:39] but I looked at both and yeah we can blow them away [22:16:45] jcmish, just tell me what;) [22:16:48] ok [22:17:05] (03CR) 10Dr0ptp4kt: [C: 032] Big refactoring of PageRenderingHooks to avoid globals [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85854 (owner: 10Yurik) [22:17:08] (03Merged) 10jenkins-bot: Big refactoring of PageRenderingHooks to avoid globals [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85854 (owner: 10Yurik) [22:17:35] dr0ptp4kt, thanks! please check the https://gerrit.wikimedia.org/r/#/c/86162/ ! [22:17:38] you rock :) [22:18:01] dr0ptp4kt, https://gerrit.wikimedia.org/r/#/c/85859/ is last [22:18:47] yurik, reviewing [22:19:23] jcmish: if you need any help with those python patchsets lmk (they couldn't get the remote rig running for the meeting i was heading to) [22:19:24] jdlrobson: There's no way to have the mobile thanks code live outside of MobileFrontend without loading a bunch of mobile JS because none of the normal MW JS is available. If I want to use the API or eventLogging, etc, I have to load the mobile-specific versions from MobileFrontend. [22:19:40] k I'm looking at them now awjr [22:19:47] I'll scream if I get stuck :D [22:20:30] gerrit is my favorite! [22:21:45] jdlrobson: The real solution would be for us to use the regular core JS for things like API-interaction and eventLogging (things that have no reason to be mobile specific). [22:22:27] but that would be a rabbit-hole [22:26:14] dr0ptp4kt, can we deploy now? [22:26:21] dr0ptp4kt, ops told us we can go ahead [22:26:28] yurik, 3 mins [22:26:35] thx :) [22:30:13] yurik, in patchset 86162 when i go to http://localhost:8080/wiki/Special:ZeroRatedMobileAccess it redirects me to http://127.0.0.1:8080/wiki/Ru:Special:ZeroRatedMobileAccess, which doesn't show a list of languages??? [22:31:41] dr0ptp4kt, this is kinda expected :( [22:31:54] yurik, i see that. trying to grapple with this intellectually. hang on a sec. [22:31:55] if the interwiki table was set up [22:32:04] yurik, yeah, got it. ok, hang tight [22:32:08] :) [22:32:18] (03CR) 10Dr0ptp4kt: [C: 032] Changed redirect behaviour for Special:Zero [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86162 (owner: 10Yurik) [22:32:21] (03Merged) 10jenkins-bot: Changed redirect behaviour for Special:Zero [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86162 (owner: 10Yurik) [22:32:34] yurik, we can cherry-pick it away if necessary anyway if it breaks stuff [22:32:36] hang on [22:32:52] dr0ptp4kt, true, see if https://gerrit.wikimedia.org/r/#/c/85859 can be merged too [22:32:55] and i will push it out [22:33:06] yurik, yup looking at that right now [22:35:10] (03CR) 10Dr0ptp4kt: [C: 032] Prevented zero API 'ips' from working when running on a non-META site. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85859 (owner: 10Yurik) [22:35:12] (03Merged) 10jenkins-bot: Prevented zero API 'ips' from working when running on a non-META site. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/85859 (owner: 10Yurik) [22:35:17] yurik, JUMP [22:35:21] aaaaaaaa [22:38:15] dr0ptp4kt, y so ALLCAPS?:P [22:38:35] :) [22:45:05] dr0ptp4kt, copying... [22:45:12] almost ready :) [22:46:06] yurik, okay let me know once ready. [22:46:49] (03CR) 10Dr0ptp4kt: "(33 comments)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 (owner: 10Dr0ptp4kt) [22:46:50] dr0ptp4kt, go [22:48:58] yurik, i'm going to run the 'faster' test for one carrier, then i'll run the 'faster' test for all carriers [22:49:05] ok [22:56:16] dr0ptp4kt, finished deploying 19th [22:56:26] i don't think it should affect your quick scan (en is on 18th) [22:57:42] yurik, ok. single carrier version is finishing. [22:58:07] grr, i really should filter google bot in zero log [22:59:22] yurik, if the content below the red warning goes away on zerodot, googlebot will probably better go away, too [23:01:43] yurik, starting 'faster' job simulating all carriers [23:02:24] (03PS1) 10Yurik: Removed logging of google bot (too much noise) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86196 [23:08:15] dr0ptp4kt, i think there is something wrong with caching of the zero.wikipedia.org [23:09:17] (03CR) 10Dr0ptp4kt: [C: 032] Removed logging of google bot (too much noise) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86196 (owner: 10Yurik) [23:09:26] (03Merged) 10jenkins-bot: Removed logging of google bot (too much noise) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86196 (owner: 10Yurik) [23:09:58] (03PS5) 10Kaldari: Migrating Mobile thanks into Thanks extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86061 [23:10:07] awjr: got into the new mingle instance just fine. thanks for taking that from me [23:10:16] :) [23:10:23] yurik, got a url i can check against? [23:10:35] http://zero.wikipedia.org without any headers [23:10:40] tfinc: yeah things are looking ok (though of course the project is way out of date) and i got the api stuff working correctly [23:11:25] brion: you there? [23:11:41] jdlrobson: yo [23:12:26] so i need to fix up this brion - https://gerrit.wikimedia.org/r/#/c/83591/16/resources/mediawiki.less/mediawiki.mixins.less - is it enough to test just svg or do i also need to test fallback? [23:12:39] yurik, yeah, the Cache-Control header says private, s-maxage=0, max-age=0, must-revalidate, although i guess we'd need to look at the end-to-end [23:12:40] tfinc i really don't understand ADP - for some reason my vacation request for when i took a few weeks off in july expired or something and my vacation time didn't get updated. i emailed joady [23:12:52] tfinc: but more imporatntly, i just submitted a timeoff request for fri oct 11 [23:13:01] awjr: k [23:13:10] dunno if it automatically alerts you but figured i'd let you know either way on account of the weirdness. [23:14:27] jdlrobson: to test for embedding? [23:14:32] yeah i guess you ought to test em both [23:14:53] hmm [23:15:02] though that embed might not fall back on old IE ... [23:15:07] jdlrobson: i'd consider just not embedding the fallback [23:15:20] true [23:15:24] that's the rare case for older browsers :) [23:15:55] ok if i fix that up can i get a review out of you? [23:16:31] dr0ptp4kt, where do you think that issue is? [23:18:16] yurik, not sure. note that m.wikipedia.org it taking about 5 seconds to redirect to en.m.wikipedia.org (this is with no header forging) [23:18:37] brion: https://gerrit.wikimedia.org/r/#/c/83591/15 review welcomed.. hoped to get merged today :) [23:18:38] MaxSem, ^ ? [23:19:00] yurik, yet going to other pages yields a quick response, presumably because those are cached hits. [23:19:13] spiff i'll add some notes [23:20:51] 60ms for me [23:21:01] or should I set zero headers? [23:21:44] brion: mhurd YuviPanda|zzzzzz somehow next sprint planning fell of the calendar. i re-added it for noon tomorrow [23:21:45] MaxSem what ip do you get for zero.wikipedia.org and m.wikipedia.org based on an nslookup? [23:21:51] ^yurik cc [23:21:52] tfinc: spiff [23:22:10] (03PS4) 10Jdlrobson: Make watchlist user icons consistent with rest of UI [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86052 [23:22:12] european one [23:22:22] brion: big code review day tomorrow [23:22:39] (03PS4) 10Jdlrobson: Story 475: Add EventLogging to profile clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86010 [23:22:41] 91.198.174.236 for m [23:22:59] 208.80.154.236 for zero [23:23:20] MaxSem, same here. [23:24:16] whee [23:24:42] MaxSem, that 60ms is the time for the redirect using a standard desktop browser, correct? [23:25:00] yup [23:26:18] going offline for a bit, should be back on in about 15 mins [23:26:47] MaxSem, yurik: a direct hitfor http://208.80.154.236 takes 230ms. [23:26:49] dr0ptp4kt, much slower with spoofed CS [23:27:11] how many ms for the actual 302/301? [23:28:04] could it be that 302 doesn't have caching headers? [23:29:35] WTF, net panel in FB gets cleared [23:29:45] I can't even inspect request details [23:30:01] yurik, "Бесплатный доступ к Википедиа для абонентов Билайн" [23:30:26] dr0ptp4kt, MaxSem congratulations, we now have netmapper on all ACL sites!!! [23:30:29] i meant ZERO sites [23:30:35] IPs are live :) [23:30:45] now back to the caching issue [23:30:51] so the slowdown is due to it? [23:31:08] MaxSem, doubt it [23:31:18] separate project [23:31:21] yurik, well, also the vcl change went in 40 minutes ago [23:31:41] dr0ptp4kt, which change? [23:31:43] the slowdown is on the INITIAL redirect of zero.wikipedia.org [23:32:23] yurik, MaxSem: https://git.wikimedia.org/summary/?r=operations/puppet.git [23:32:40] and then on all the rest;) [23:33:28] yurik, MaxSem, i don't know where it went but there was a patch that had 'doh' in the patch name for the vcl stuff discussed on the ops list [23:33:34] but it seems like its gone now [23:33:58] (03PS2) 10Jdlrobson: Add convertNumber to localize the distance [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86027 (owner: 10Amire80) [23:34:08] dr0ptp4kt, yes, that was probably feiodn's - he made a fix last night and thought it was fine except that it didn't compile and brandon noticed it :) [23:34:20] (03CR) 10Jdlrobson: [C: 032] "Fixed up amir's patch with Ryan's comment" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86027 (owner: 10Amire80) [23:34:34] good thing varnish servers weren't restarting ;) [23:34:42] otherwise they wouldn't have started at all [23:34:53] (03Merged) 10jenkins-bot: Add convertNumber to localize the distance [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86027 (owner: 10Amire80) [23:40:21] yurik, MaxSem, cache-hit pages are serving under 200ms on my connection here from the office. [23:44:09] yurik, MaxSem: hockey on en.m cache-served comes at about 300ms [23:44:43] do headres say it's cache hit? [23:49:15] XFF works!!! me excited :) [23:49:19] no more X-CS spoofing :) [23:51:09] MaxSem, yeah hockey came back as cache hit. i don't know that there's a replication across the caches, so it seems to depend on whether a particular node has served the page [23:54:26] ru.m and ru.zero are coming back as cache hits for the home page and first link, for example, too [23:55:24] tfinc: https://mingle.corp.wikimedia.org/projects/mobile/cards/1200