[00:01:19] jdlrobson, jdlrobson, kaldari: have we run into and/or are we anticipating code review issues with https://mingle.corp.wikimedia.org/projects/mobile/cards/1200 ? [00:01:32] yurik, MaxSem: do you need me online right now? i'd like to put in a workout then check back in later and if needed give a hand [00:01:39] tfinc: lol [00:01:47] :) [00:01:57] dr0ptp4kt, nope, will work on it tomorrow [00:02:11] dr0ptp4kt, go in peace [00:02:27] given thats its a beta experiment i don't see the issue with running it [00:02:41] whois kaity [00:03:11] yurik, MaxSem, okay my cell info is on the office page if you don't have it already. but it seems webpages are quick, it's the stuff that's served "solely" for / on zero.wikipedia.org and m.wikipedia.org (no langdot) that's really slow. [00:03:17] yurik, MaxSem, ttyl [00:04:53] (03CR) 10JGonera: [C: 04-1] "(3 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86010 (owner: 10Jdlrobson) [00:43:58] (03CR) 10JGonera: "Ori, the semicolon doesn't seem to work in lessphp, unless I did something stupid." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER) [00:49:12] awjr: looks like i may have a lead through marie :) [00:49:18] \o/ [00:50:06] * tfinc gets back to writing a new jd  [00:55:42] (03PS5) 10Jdlrobson: Story 475: Add EventLogging to profile clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86010 [00:58:42] (03CR) 10JGonera: [C: 032] Story 475: Add EventLogging to profile clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86010 (owner: 10Jdlrobson) [00:59:07] (03Merged) 10jenkins-bot: Story 475: Add EventLogging to profile clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86010 (owner: 10Jdlrobson) [01:03:12] (03PS1) 10Jdlrobson: Ajax Page Loads: Don't drop the query string [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86211 [01:11:33] (03CR) 10Jdlrobson: [C: 031] "Feel free to +2 when the thanks extension change has been merged." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86061 (owner: 10Kaldari) [01:13:24] (03PS6) 10Kaldari: Migrating Mobile thanks into Thanks extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86061 [01:13:28] (03CR) 10jenkins-bot: [V: 04-1] Migrating Mobile thanks into Thanks extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86061 (owner: 10Kaldari) [01:27:49] (03CR) 10Jdlrobson: [C: 032] Story 1030: Clean up ui.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86058 (owner: 10JGonera) [01:28:08] (03PS5) 10Jdlrobson: Make watchlist user icons consistent with rest of UI [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86052 [01:28:14] (03Merged) 10jenkins-bot: Story 1030: Clean up ui.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86058 (owner: 10JGonera) [01:29:45] jdlrobson: I see you did actually update the clicktracking code for Thanks. I just need to copy over your fix to the new version that lives in the Thanks ext. [01:30:18] (03PS7) 10Kaldari: Migrating Mobile thanks into Thanks extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86061 [01:31:21] done: https://gerrit.wikimedia.org/r/#/c/86059/ [01:45:25] (03CR) 10Kaldari: [C: 032] "merging per jon" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86061 (owner: 10Kaldari) [01:45:50] (03Merged) 10jenkins-bot: Migrating Mobile thanks into Thanks extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86061 (owner: 10Kaldari) [01:46:35] anybody wanna get some dinner? [01:59:00] YuviPanda: morning [01:59:04] hello, tfinc [01:59:15] YuviPanda: i'm about to head out. can you make the 12-1 story meeting tomorrow ? [01:59:42] tfinc: I could, but not sure if I'll be in a non-zombie state. [01:59:53] YuviPanda: what's your cut off ? [01:59:56] tfinc: Going to try to force myself to sleep during the day to be able to stay up at night, not sure how that isg oing to go [02:00:00] tfinc: 11? [02:00:09] tfinc: or 11:30? [02:00:37] i could likely skip the biweekly hiring and keep it to 11 - 12 [02:01:05] that should mostly work, I'd think. [02:01:12] 'biweekly hiring'? [02:01:32] YuviPanda: hiring managers meeting [02:01:36] ah, ok [02:05:22] k, im out of here [02:05:46] YuviPanda: thanks for looking at the new jd [02:05:54] tfinc: :D [02:05:59] tfinc: enjoy your evening! [09:49:39] (03PS2) 10MaxSem: Get rid of MobileContext::singleton() in skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86123 [10:19:19] (03PS1) 10Ebrahim: Fixing Persian comma bug and native digit on MobileDiff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86233 [10:19:26] (03CR) 10jenkins-bot: [V: 04-1] Fixing Persian comma bug and native digit on MobileDiff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86233 (owner: 10Ebrahim) [10:20:59] (03PS2) 10Ebrahim: Fixing Persian comma bug and native digit on MobileDiff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86233 [10:23:01] (03PS3) 10Ebrahim: Fixing Persian comma bug and native digit on MobileDiff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86233 [10:27:14] (03PS2) 10MaxSem: Add context to GetMobileUrl hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85865 [11:23:47] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86233 (owner: 10Ebrahim) [11:26:18] (03PS4) 10Ebrahim: Fixing Persian comma bug and native digit on MobileDiff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86233 [11:29:46] (03PS3) 10MaxSem: Very code hygienic change: KILL WAP WITH FIRE!!1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82050 [11:31:35] (03PS4) 10MaxSem: Very code hygienic change: KILL WAP WITH FIRE!!1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82050 [14:26:35] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86233 (owner: 10Ebrahim) [15:27:30] (03PS5) 10Ebrahim: Using language aware comma in UI and native digits [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86233 [15:29:00] (03PS6) 10Ebrahim: Using language aware comma and native digits on MobileDiff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86233 [16:47:17] YuviPanda: instead of creating a new board for the next sprint i'm thinking of just adding a new column to the backlog and moving the stories over once their ready [16:47:25] YuviPanda: i'm tired of always having to add a new board, users, etc [16:48:52] YuviPanda: since your the most likely to pass out at the planning/estimation take a look at the backlog and place/add storys into the "Hold for Next Sprint" [16:49:45] * tfinc wonders if YuviPanda is asleep already  [16:53:29] jdlrobson: http://www.google.com/wallet/send-money/ [17:00:20] jgonera: stdanup! [17:01:23] jgonera: you're frozen :( [17:01:26] tfinc: was a little passed out, but had set an alarm for standup [17:01:38] awjr, I could hear you... [17:01:48] aww your video is frozen and we couldn't hear you :( [17:02:07] tfinc: looking at it now [17:05:28] I knew it was a trick question when Google Hangout asked me about enabling HD... [17:14:33] 01[13Commons-iOS01] 15brion pushed 31 new commits to 06master: 02http://git.io/SyqqHw [17:14:33] 13Commons-iOS/06master 14617cae5 15Monte Hurd: Autolayout fix for pic of day attribution label. [17:14:33] 13Commons-iOS/06master 14a6a185e 15Monte Hurd: Autolayout for Getting Started pages. [17:14:33] 13Commons-iOS/06master 1462d6210 15Monte Hurd: Login page autolayout. [17:15:13] mhurd: I have merged to master :D it's looking awesome! [17:16:14] brion: standup! [17:16:20] whee [17:20:49] dr0ptp4kt, ping [17:21:02] yurik: he's standing in on the apps team standup. [17:21:05] should be back shortly [17:21:17] thx YuviPanda [17:23:51] (03CR) 10Awjrichards: [C: 032] Add context to GetMobileUrl hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85865 (owner: 10MaxSem) [17:25:16] (03Merged) 10jenkins-bot: Add context to GetMobileUrl hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85865 (owner: 10MaxSem) [17:27:47] (03CR) 10Awjrichards: [C: 032] Get rid of MobileContext::singleton() in skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86123 (owner: 10MaxSem) [17:28:11] (03Merged) 10jenkins-bot: Get rid of MobileContext::singleton() in skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86123 (owner: 10MaxSem) [17:29:30] yurik, back [17:29:55] vbamba jdlrobson: we have competing smiley faces: http://picpaste.com/Screen_Shot_2013-09-27_at_10.27.31_AM-oOiXs0Dh.png [17:30:03] dr0ptp4kt, I found two excellent ext for chrome - makes testing much easier :) [17:30:15] hahah kaldari [17:30:36] dr0ptp4kt, modheader and "http headers" [17:31:17] modheader you can set headers automatically per domain, and http headers show all of them in a popup including all redirects [17:31:19] vbamba: lemme know if you want to make any tweaks to that thank button [17:31:37] dr0ptp4kt, this is for chrome though, not FF [17:32:39] yurik, yeah, have modheader. thx for the http headers suggestion. [17:33:37] dr0ptp4kt, so yes, basically that ext shows that its a private redirect :( [17:34:21] yurik, yup [17:37:13] today is the first day in nearly 6 months where the expected high in Tucson is less than 90 degress [17:37:15] F [17:42:54] tfinc: backlog items added [17:42:59] mhurd: thanks [17:43:16] YuviPanda: go ahead and add yours too [17:43:18] brion: you too [17:43:24] ok [17:43:28] yeah will do now [17:44:21] awjr: are we riding the deployment train in the upcoming week ? [17:44:37] no tfinc [17:44:51] waiting on timeline from ops about blockers [17:44:58] greg-g: --^ [17:45:07] so best possible projected start date is 'sometime in the future' [17:45:38] i filed an RT ticket last week but it's had no response so i actually just sent an email to ops list about it [17:45:49] awjr: link me to the RT ticket ? [17:45:55] https://rt.wikimedia.org/Ticket/Display.html?id=5805 [17:45:57] tfinc ^ [17:48:14] kenanwang: can you do a pass on the roadmap and see if its up to date https://docs.google.com/a/wikimedia.org/spreadsheet/ccc?key=0Aoizbfxc5g6KdEkza0xkQnJlM0o0TXlwQXhDOUFvYnc#gid=0 ? [17:54:12] (03CR) 10Brion VIBBER: [C: 031] "Looks good, haven't tested yet." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86233 (owner: 10Ebrahim) [17:54:43] awjr: cool, thanks (tfinc) [17:55:07] awjr: does anyone have any idea why Google has decided to redirect our mobile traffic for us? Don't we redirect mobile devices to mobile by default anyway? [17:55:24] np greg-g, feel free to poke ops too :) [17:55:52] kaldari: google doesn't appear to be redirecting mobile traffic per se but rather sending mobile devices directly to .m domains (at least for enwiki, not sure about others) [17:56:12] awjr: anything in specific I should poke them on? :) [17:56:16] oh, I see it [17:56:19] greg-g: https://rt.wikimedia.org/Ticket/Display.html?id=5805 [17:56:22] * greg-g reads full scrollback [17:57:12] kaldari: google has done various things to try and improve mobile experience particularly in regards to traffic to WP [17:57:47] we've talked them out of most of them :) [17:57:49] aha right [17:58:32] kaldari: i dont know that they've historically contacted us before trying things out, afaik they haven't contacted us about the search result links we're seeing now [17:59:10] awjr: it seems like a very strange thing to do without some sort of benefit [17:59:25] kaldari: the benefit i can think of here is quicker access [17:59:38] hmm [17:59:48] it's a couple less hops to send someone directly to a .m then send them to the canonical URL and then get redirected [18:01:15] brion: just waiting on you in the hangout [18:01:28] moment [18:02:04] does clicking the mobile link in the footer change the redirct cookie or just delete it? [18:03:01] if it changes it, we could make the cookie check bi-directional, i.e. check the state of the cookie for people coming directly to .m and directing to desktop if appropriate. [18:03:13] https://github.com/richarcher/Hatjitsu [18:06:37] kaldari: it deletes the cookie [18:08:35] awjr: maybe Google's change is an opportunity for improvement rather than a problem :) [18:09:37] what do you have in mind kaldari? [18:10:10] ah, just read scrollback and missed your previous comment [18:10:18] it used to do that, actually [18:10:44] That would also be better behavior for people running MobileFrontend without a separate hostname. [18:11:03] that's basically how it works for people running MF without a separate hostname [18:11:45] we settled on the current behavior as a means of simplification and to make it possible to access the .m if you really want to as a one-off (when you might typically prefer the desktop site) [18:12:30] and people seemed to like the change to the current state (we stopped getting related complaints whereas before we were getting tons) [18:12:41] hmm [18:12:54] kaldari, I think Google did what they did to make page loading slightly faster, it's always one HTTP request less, and I guess one DNS lookup less too [18:12:55] ideally we just wouldn't have separate subdomains for .m and .zero (what yuri brought up on the thred) [18:13:08] but, afaik that's probably a ways off [18:14:00] awjr, not sure about that. serving different HTML at the same URL might not be good for SEO [18:14:31] jgonera: ideally that switch would also come with serving the same HTML as the desktop site [18:14:36] does any big web site use the same domain for desktop and mobile? [18:15:13] awjr, I know, I know, but I don't believe in one size fits it all HTML for anything more complicated than simple web sites ;) [18:16:12] if we had thoughtfully annotated HTML i can imagine it being possible [18:17:01] So what's the main use case for the mobile redirect cookie right now? Tablet users? [18:17:28] i expect tablet users (although most tablet users don't get sent to the mobile version of the site) [18:17:44] but also people who just prefer to use the desktop site rather than MF on whatever device [18:18:19] i think we have data on this somewhere… probably on graphite [18:20:18] actually maybe not [18:20:30] graphite has become rather difficult to navigate... [18:20:39] awjr, it's possible, just not very optimal if you send HTML with 50 elements that you hide in CSS anyway, but that's just my skepticism [18:21:09] aye [18:21:26] awjr: OK, here's an idea... [18:21:59] awjr: If the referrer is Google and they have the stopMobileRedirect cookie set, we redirect them to desktop [18:22:07] wow i could've sworn we were logging data around stopMobileRedirect but i dont see anything in the code [18:22:39] awjr: That way they can still go to .m as a one-off if they want, but people coming from Google would get the expected behavior [18:22:58] kaldari: i dont think it's sustainable to start adding logic for distinct third parties into the VCLs [18:23:23] plus there's be a minor performance hit adding add'l logic at the layer [18:23:49] personally i think we either need to ask google to stop or just not care ourselves [18:24:11] awjr: I wouldn't suggest doing it for anyone besides Google. The benefit (faster access) wouldn't be worth the cost for anyone else, IMO. [18:24:22] we can pitch it to ops [18:24:58] awjr: didn't think about the performance hit there [18:25:04] hmm [18:25:35] it would be minor, but there's been a tremendous amount of work done to get the VCLs as lean as possible [18:27:27] awjr: wouldn't it still be faster than redirecting all the mobile traffic by default on our end? [18:27:40] since we don't have real data though around usage of stopMobileRedirect cookie, perhaps we should get some before making a decision [18:27:48] keep in mind this is an area I know very little about :) [18:28:06] good idea [18:28:18] possibly kaldari, im not sure [18:28:57] I also wonder if Google would have any data that they used to make the decision on their end [18:30:08] they did something rather ambitious a few months back where they served their own cached versions of MF wikipedia pages [18:30:44] wha? [18:30:59] that sounds like madness [18:31:03] which caused all kinds of concern our end (depressing page view stats, serving stale content, serving stale UX, etc) [18:31:13] we asked politely that they stop doing that, and they did [18:32:06] I wonder if Google has ever considered just caching the entire internet and serving that by default [18:32:25] tehe [18:32:44] at least we wouldn't have to worry about uptime anymore [18:32:55] lol [18:33:29] that's basically what they do with their image search [18:33:45] kaldari: iirc they tried doing that with the mobile site a while back [18:33:52] kaldari: and we asked them to piss off (in nicer terms!) [18:34:19] so I've heard. That's pretty astounding. [18:34:36] them trying to cache us or us asking them to piss off? [18:35:01] them serving their own cache by default of a major website [18:35:09] heh :D [18:35:25] and IIRC we got post-deploy messaging, rather than a pre-deploy one [18:35:34] if they had done that to a site with ads, they would have been sued for sure [18:35:44] definitely, yeah. [18:37:21] vbamba: did you ever get to look at that screenshot? [18:43:33] brion: i'm going to head to sleep in about 10 mins. got anything for me? [18:43:34] tfinc: mhurd ^ [18:51:55] (03PS1) 10Jdlrobson: Allow MFResourceLoaderModule to handle templates and files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86290 [18:51:58] (03CR) 10jenkins-bot: [V: 04-1] Allow MFResourceLoaderModule to handle templates and files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86290 (owner: 10Jdlrobson) [18:54:04] (03PS2) 10Jdlrobson: Allow MFResourceLoaderModule to handle templates and files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86290 [18:54:19] (03CR) 10jenkins-bot: [V: 04-1] Allow MFResourceLoaderModule to handle templates and files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86290 (owner: 10Jdlrobson) [18:55:25] YuviPanda: i think i'm good, i'll ping you w/ the code review reqs later :D [18:55:39] brion: :) [19:01:25] (03PS3) 10Jdlrobson: Allow MFResourceLoaderModule to handle templates and files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86290 [19:01:56] (03PS4) 10Jdlrobson: Allow MFResourceLoaderModule to handle templates and files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86290 [19:02:24] brion, where can I find an example of how to use MediaWiki classes in a CLI PHP script? [19:02:57] awjr, kaldari ^ [19:02:58] jgonera: anything in maintenance/ :) [19:03:10] aye [19:09:39] brion, thanks, didn't know I had to subclass Maintenance for it to work, I assumed requiring it would be enough [19:10:19] technically you don't *need* it, but it's nice to be consistent :) [19:11:00] anyone know how to change a user's email address associated with their account? a friend of mine doesn't remember his pwd and the email address associated with his account no longer exists [19:11:03] brion: ? ^ [19:11:41] awjr: well… you can do it manually via eval.php :) [19:11:50] i figured but that seems… scary [19:12:31] brion, I know, I just wanted to try out something quickly ;) [19:12:32] well i don't see an obvious maint script for it... [19:12:37] :) [19:12:41] gulp [19:12:55] id almost ratehr just change in the db [19:13:15] hmm i'll ask in #mediawiki to see if there's a less freaky way [19:19:02] don't change in the db, it'll fuck up cache :D [19:19:26] * awjr grumbles [19:37:19] awjr_lunch: sorry was out taking Dimi to fencing [19:37:21] what's up? [19:44:43] jcmish: i forget; did i ping you earlier? [19:45:19] oh i remember - jcmish was tehre another patchset you wanted me to look at re the git log scripts? [19:49:45] just the one I gave ya last night [19:54:17] ah yeah - jcmish if you can fix the 'str' in https://gerrit.wikimedia.org/r/#/c/86210/ i'll take another look and test [19:59:22] okay let me make sure I don't mess it up [19:59:46] I'll ping ya if I have any questions [20:14:02] crap... rebase messed up the entire LESS patch... [20:23:08] i so hate gerrit :D [20:32:34] sup gang [20:32:37] (03PS11) 10JGonera: WIP: Use .less files directly in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER) [20:33:13] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use .less files directly in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER) [20:33:35] jdlrobson, if you have a moment (probably not?) can you check out https://gerrit.wikimedia.org/r/#/c/84139, run make lesscheck and tell me what is lessphp complaining about? my brain is fried [20:35:41] jgonera: looks like variables are not being included [20:35:55] expected color value: failed at `background-color: darken( @searchBoxColor, 0.4% );` /Users/jrobson/Sites/w/extensions/MobileFrontend/less/common/ui.less on line 93 [20:36:01] i suspect it doesn't know what searchBoxColor is [20:36:06] huh, I'm not getting this one :O [20:36:19] expecting number: failed at `font-size: round( 1em / @fontScalingFactor, 2 ); // Fixed font on purpose to avoid zooming on iOS` /home/jgonera/www/extensions/MobileFrontend/less/common/common.less on line 48 [20:36:19] expecting number: failed at `margin: round( @headerHeight*0.22 ) 0 0;` /home/jgonera/www/extensions/MobileFrontend/less/common/ui.less on line 23 [20:36:26] that's what I get [20:36:58] jgonera: yeh but if you change it to ont-size: round( 1em / 0.5, 2 ) [20:37:00] what happens? [20:37:12] it moves on to the next error and shows the one i pasted [20:37:16] it works, sure [20:37:19] meaning it must be to do with variables [20:37:33] I tried including variables.less directly [20:37:42] what happens then? [20:37:50] ok, I leave this patch for monday, I just can't... [20:37:52] nothing [20:37:54] same error [20:38:48] (03CR) 10JGonera: "This is still WIP. lessCheck.php needs a cleanup. Also, getting errors in LESS, but that might be due to an error in lessCheck.php" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER) [20:40:57] (03PS12) 10JGonera: WIP: Use .less files directly in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER) [20:45:56] (03PS13) 10JGonera: WIP: Use .less files directly in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER) [20:49:23] (03PS14) 10JGonera: WIP: Use .less files directly in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER) [20:50:00] anybody has a suggestion what should I refactor?:P [20:51:56] (03PS15) 10JGonera: WIP: Use .less files directly in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER) [20:51:56] i thought we fixed that round problem… [20:51:59] lemme check core [20:53:04] brion, let me check if the error also appears in CSS comments, it might be the lessCheck.php, I commented one line from lessCompiler() I copied from ResourceLoaderModule [20:55:19] jgonera: so it's weird it seems that imports are not working [20:55:41] MaxSem: help the less stuff work so that we can throw away our stylesheets directory :) [20:56:20] brion, jdlrobson they seem to work in the real RL, must be some problem with lesscheck [20:56:26] keep unholy CSS away from me!:P [20:56:30] is the directory wrong? [20:56:35] I can help with PHP though:P [20:56:42] yeah i'm looking it over ... [20:56:45] it is PHP in fact ;) [20:57:08] hmm maybe we have to clear the compiler object for each file [20:57:45] jgonera: it passes if i move the $compiler = self::lessCompiler() inside the loop [20:58:02] i think ori had problems with reusing the object in core too, had to just create a new one for each separate file [20:58:06] hm [20:58:19] require_once __DIR__ . '/../../../maintenance/Maintenance.php'; < jgonera not the best idea [20:58:31] * brion shakes fist at state-bearing objects [20:58:37] yes, as I wrote, needs a cleanup [20:59:35] (03PS16) 10JGonera: WIP: Use .less files directly in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER) [20:59:45] jdlrobson, what would you do instead? [21:01:58] not really sure jgonera [21:03:18] is there any variable where MW root dir is stored? [21:03:28] brion, awjr, kaldari ^ [21:03:49] wait a sec, shouldn't lessCheck.php be in core? [21:03:54] jgonera: $IP … but you don't want to use it there i think [21:04:02] (and be called checkLess...) [21:04:24] dirname( dirname( dirname( ___FILE__ ) ) ) or some crap sounds familiar for some reason… i hope there's a less ugly convention though ;) [21:04:31] yeh you are no loading core so $IP is no good [21:04:53] brion, MW_INSTALL_PATH actually, but the whole file should be in core instead;) [21:05:15] perhaps :) [21:05:30] MaxSem, possibly, I can submit a patch to core too when it's ready [21:05:37] and when it gets merged, we get rid of it in MF [21:05:46] jgonera, let me put it to core right now;) [21:05:57] it's not ready [21:06:02] look at the fixme [21:06:06] I need to talk to Ori [21:06:44] MaxSem, I'll do it next week, when it's cleaned up [21:09:53] jgonera: $_SERVER['DOCUMENT_ROOT']? [21:12:29] then $wgScriptPath to get the /wiki part [21:12:38] kaldari, $_SERVER doesn't exist in CLI PHP [21:13:14] or does it? [21:13:21] ok, food [21:14:33] jdlrobson: can you seriously not edit the jd ? [21:14:43] i set mobile-tech to be able to edit [21:14:54] guess i might have to do individuals [21:14:58] tfinc: i can edit yes i was just making a comment that with documents i never know whether it's appropriate for me to edit [21:15:04] with wikis it's always much clearer [21:15:05] go for it [21:15:07] i have now [21:15:20] you can always edit ones that i send unless i say otherwise which is almost never [21:15:25] but you should clarify when you want people to edit and when you just want people to comment - if it's a document i will see it as your baby :) [21:15:31] ok good to know [21:16:46] jdlrobson: good feedback. i hadn't even thought about it that way. [21:44:55] pfft, no time to code, only to write thoughtful emails:P [21:48:08] I'm going to leave soon, anybody needs anything? [21:54:29] hsahaahharghgh less abomination! [21:54:35] jgonera: "If the mixin doesn’t need any arguments, you can leave off the parentheses when mixing it in, as seen above." [21:56:15] and then it looks confusingngly like a css class [21:56:55] aharoni: wanna meet about webfonts? [21:58:36] jgonera: http://leafo.net/lessphp/docs/#pattern_matching grep for "Optionally you can separate them by >." and look at the example o_O [21:59:49] (03PS1) 10Brion VIBBER: Fix for getMultilingualText when there's only monolingual text [apps/android/commons] - 10https://gerrit.wikimedia.org/r/86326 [22:00:17] (03CR) 10Brion VIBBER: [C: 032 V: 032] "self-merge this quick fix" [apps/android/commons] - 10https://gerrit.wikimedia.org/r/86326 (owner: 10Brion VIBBER) [22:12:17] MaxSem, how was the concert? [22:12:32] niiice [22:12:50] MaxSem, you mean LOUD [22:13:01] nooooo [22:13:21] orchestra without artificial amplification is not loud [22:13:36] boooring.... why did you even go [22:13:52] MaxSem: what concert was it? [22:14:06] http://www.serjtankian.com/content/orca-act-i [22:17:12] MaxSem, wat, i'm confused - i thought you only liked hard rock [22:17:18] sorry, heavy metal [22:17:33] and this is more like a movie score [22:18:29] (03PS1) 10Brion VIBBER: Fix media URL generation for non-ASCII filenames [apps/android/commons] - 10https://gerrit.wikimedia.org/r/86327 [22:19:10] don't worry yurik, I'm thinking of http://www.youtube.com/watch?v=sZn9xG0CLN4 as next thing to attend;) [22:19:18] (03CR) 10Brion VIBBER: [C: 032 V: 032] "another dirty self-merge! mwahahaah noone can stop me" [apps/android/commons] - 10https://gerrit.wikimedia.org/r/86327 (owner: 10Brion VIBBER) [22:19:29] there we go [23:22:05] kaldari: when you have a chance can you stick https://mingle.corp.wikimedia.org/projects/mobile/cards/987 in the right column? [23:23:14] sure, meeting with amir right now