[00:18:21] <jdlrobson>	 jgonera: https://gerrit.wikimedia.org/r/#/c/86701/
[00:25:56] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Ajax Page Loads: Don't drop the query string [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86211 (owner: 10Jdlrobson)
[00:26:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Ajax Page Loads: Don't drop the query string [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86211 (owner: 10Jdlrobson)
[00:30:48] <MaxSem>	 jdlrobson, if you've been waiting for core LESS for https://gerrit.wikimedia.org/r/#/c/84139/ , it has been deployed everywhere last week 
[00:31:45] <jdlrobson>	 MaxSem: nope not waiting on that anymore waiting for our next deployment - it's a big change so let's aim for next deployment
[00:32:10] <grrrit-wm>	 (03CR) 10Jdlrobson: "Let's aim for next deployment - I'll review this after tomorrow's deployment." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER)
[00:32:50] <MaxSem>	 whee:)
[00:33:42] <grrrit-wm>	 (03CR) 10Kaldari: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86715 (owner: 10Jdlrobson)
[00:36:53] <grrrit-wm>	 (03PS1) 10MaxSem: Remove selectors now hidden in CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86784 
[00:37:30] <grrrit-wm>	 (03CR) 10Kaldari: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86713 (owner: 10Jdlrobson)
[00:37:39] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove selectors now hidden in CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86784 (owner: 10MaxSem)
[00:38:04] <grrrit-wm>	 (03PS1) 10JGonera: Story 1030: Clean up common.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86785 
[00:38:08] <MaxSem>	 heh
[00:38:57] <kaldari>	 jdlrobson, jgonera, maxsem: anything you guys need reviewed before tomorrow?
[00:39:12] <jgonera>	 kaldari, I think we're past code cut-off
[00:39:29] <kaldari>	 geez, it's already 5? :P
[00:39:33] <MaxSem>	 kaldari, I plan to finish ^^ and push it after scap, but that's it
[00:39:47] <awjr>	 heh yeah, although if it's pressing michelle is usually ok with sneaking something in
[00:41:05] <kaldari>	 Sadly, https://gerrit.wikimedia.org/r/#/c/82073/ is still unmerged :(
[00:41:20] <kaldari>	 today is it's 1 month anniversary
[00:41:45] <kaldari>	 hopefully next week
[01:27:25] <grrrit-wm>	 (03PS2) 10JGonera: Story 1030: Clean up common.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86785 
[01:27:26] <grrrit-wm>	 (03PS1) 10JGonera: Story 1030: Clean up typography.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86795 
[01:27:27] <grrrit-wm>	 (03PS1) 10JGonera: Story 1030: Clean up footer.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86796 
[08:28:17] <dfoy>	 Anybody on?
[08:31:07] <jerith>	 o/
[09:11:33] <grrrit-wm>	 (03PS1) 10Yurik: Added "admins" parameter to the zero config [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86820 
[09:20:21] <grrrit-wm>	 (03PS1) 10Yurik: Fixed zero.wikipedia.org to show red banner for no carrier case [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86821 
[09:37:13] <grrrit-wm>	 (03PS2) 10Yurik: Fixed zero.wikipedia.org to show red banner for no carrier case [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86821 
[09:37:25] <grrrit-wm>	 (03CR) 10Yurik: [C: 032] [bug 54820] Fixed zero.wikipedia.org to show red banner for no carrier case [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86821 (owner: 10Yurik)
[09:37:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: [bug 54820] Fixed zero.wikipedia.org to show red banner for no carrier case [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86821 (owner: 10Yurik)
[09:49:33] <mhurd>	 brion: there's a "detailsWithoutTable" branch on my git hub repo that i've been pushing to if you want to poke at it. i still have to hook up the licenses part, but i should be able to heavily borrow from the categories code, so it shouldn't take too long.
[09:53:29] <YuviPanda>	 wah, brion's awake?!
[09:53:32] <YuviPanda>	 and so is mhurd?!
[09:53:34] * YuviPanda  checks timezone

[09:54:16] <mhurd>	 YuviPanda: haha had a crazy long session
[09:54:22] <YuviPanda>	 heh :D
[09:54:34] <mhurd>	 just committed so gonna crash hard :)
[09:54:37] <YuviPanda>	 :D
[09:54:38] <YuviPanda>	 mhurd: night!
[09:54:50] * YuviPanda  continues trawling through the job queue / link refresh mechanism

[09:54:50] <mhurd>	 g'night!
[09:55:21] <mhurd>	 woohoo! the things we do for fun… and pay
[10:27:26] <yurik>	 MaxSem, is there an easy way to simulate request headers via php shell on tin?
[10:27:33] <yurik>	 haven't used it  yet
[10:27:45] <MaxSem>	 $_SERVER[...] = ...?
[10:27:55] <yurik>	 I could just assign it?
[10:27:58] <yurik>	 hmm
[10:28:00] <yurik>	 bleh
[13:12:04] <brion>	 mhurd: heh i'll take a look
[13:12:08] <brion>	 i gotta remember to /away myself :)
[13:43:41] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86820 (owner: 10Yurik)
[13:52:49] <grrrit-wm>	 (03CR) 10Siebrand: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86757 (owner: 10Jdlrobson)
[17:01:45] <dfoy>	 yurik: you joining us for the standup?
[17:18:39] <grrrit-wm>	 (03PS1) 10Jdlrobson: Fix position fixed handling is iOS <= 4_2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86881 
[17:19:16] <mhurd>	 brion: YuviPanda: hey!
[17:19:30] <brion>	 mhurd: yo yo
[17:19:36] <brion>	 testing out detailsWithoutTable branch right now :)
[17:19:41] <mhurd>	 yay!
[17:19:50] <brion>	 i miss the rounded corners though :D
[17:20:20] <brion>	 but it seems to lay out correctly and gives enough room for long descriptions, which is key
[17:20:33] <mhurd>	 brion: we can re-add later for sure. just turned off embellishments whilst hacking at it :)
[17:20:42] <brion>	 yeah that's fine :D
[17:20:45] <mhurd>	 brion: yay!
[17:20:50] <YuviPanda>	 mhurd: brion hey!
[17:21:15] <mhurd>	 YuviPanda: hello!
[17:21:28] <YuviPanda>	 morning :)
[17:22:20] <mhurd>	 YuviPanda: brion: do you guys know where we keep track of app upload deletions? 
[17:22:32] <YuviPanda>	 mhurd: it should be there in the reportcard
[17:27:01] <mhurd>	 whoa! 123rd anniversary of yosemite nat'l park according to google
[17:29:58] <rfarrand>	 mhurd: yea it is, and they also had to close today
[17:30:18] <rfarrand>	 mhurd: http://www.nydailynews.com/news/politics/google-celebrates-yosemite-park-closes-shutdown-article-1.1472463
[17:31:22] <mhurd>	 rfarrand: wish the house of representatives sat on a very active fault line
[17:47:42] <mhurd>	 brion: any issues with the category swipe-to-delete from the last commit?
[17:47:55] <brion>	 no problems that i noticed, but i've only tried in the sim so far
[17:48:06] * brion  is tracking down a 'variable doesn't get set' problem over on android, whee

[17:48:30] <mhurd>	 brion: i went a little overboard maybe - you can even swipe to delete more than one item at a time
[17:48:51] <mhurd>	 brion: pesky variables hehe
[17:48:55] <mhurd>	 :)
[17:48:59] <brion>	 nice
[17:50:49] <mhurd>	 brion: didn't set out to make it all multi-touch, but there was a gesture issue that happened even when i turned multi-touch off and i couldn't figure it out right away, so just making it work multi-touch seemed like a good fix
[17:51:01] <brion>	 :)
[17:51:36] <grrrit-wm>	 (03PS8) 10Brion VIBBER: Extract and show license key [apps/android/commons] - 10https://gerrit.wikimedia.org/r/85925 
[17:55:31] <dr0ptp4kt>	 MaxSem, kaldari: we have a hot potato involving broken redirects, was wondering if you can deploy ZeroRatedMobileAccess today during the MobileFrontend deployment window. the change is decoupled. cc: awjr
[17:55:46] <MaxSem>	 np
[17:56:05] <awjr>	 what happened dr0ptp4kt?
[17:56:10] <dr0ptp4kt>	 MaxSem, thx. will get master up-to-date with the fix. cc: kaldari, awjr
[17:57:58] <dr0ptp4kt>	 awjr: condition: user is on a carrier where a config is defined by the config's 'enabled' state is set to false and the user types in m.wikipedia.org, user gets redirected to global homepage at www.wikipedia.org after hitting <lang>.m.wikipedia.org/wiki/Special:ZeroRatedMobileAccess. desired behavior, though: send user to main page in that language, like how mdot normally works. so i'll make Special:ZeroRatedMobileAcce
[17:57:59] <dr0ptp4kt>	 behave
[17:58:08] <dr0ptp4kt>	 ^MaxSem, kaldari FYI
[18:10:15] <grrrit-wm>	 (03PS1) 10Dr0ptp4kt: Redirect mdot subdomain with no or disabled config to mdot homepage. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86887 
[18:11:51] <dr0ptp4kt>	 ^MaxSem, change 86887 is the one that adds the fix. would you or awjr or kaldari please review the fix and +2 for inclusion during the deployment window? thx
[18:12:48] <kaldari>	 looking
[18:12:57] <grrrit-wm>	 (03PS2) 10Dr0ptp4kt: Redirect mdot subdomain with no or disabled config to mdot homepage. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86887 
[18:13:11] <dr0ptp4kt>	 ^MaxSem, kaldari, awjr: moved location of comment on ps2
[18:15:52] <MaxSem>	 looks plausible...
[18:18:28] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Redirect mdot subdomain with no or disabled config to mdot homepage. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86887 (owner: 10Dr0ptp4kt)
[18:18:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Redirect mdot subdomain with no or disabled config to mdot homepage. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86887 (owner: 10Dr0ptp4kt)
[18:18:36] <kaldari>	 looks good to me as well
[18:19:10] <dr0ptp4kt>	 awjr, MaxSem, kaldari: thank you
[18:19:32] <awjr>	 i had nothing to do with it :)
[18:19:34] <awjr>	 but you're welcome!
[18:24:23] <kaldari>	 awjr: I can't seem to sign in to the new mingle. it that still under construction?
[18:24:33] <awjr>	 kaldari: you need to reset your passwor
[18:24:34] <awjr>	 d
[18:24:39] <awjr>	 use the 'i forgot my password' link
[18:24:43] <kaldari>	 ok
[18:28:14] <kaldari>	 godammit: "New password: * (must be at least 5 character including a number and a symbol character, e.g. "-", ".", etc.)"
[18:28:21] <kaldari>	 "a symbol character"??
[18:28:54] <kaldari>	 arg
[18:29:04] <awjr>	 yeah, jon complained about that too :(
[18:29:23] <kaldari>	 this is why I can never remember my online bank password
[18:29:32] <awjr>	 kaldari: try a password manager
[18:29:41] <awjr>	 i've been using lastpass for a couple of years and it changed my life
[18:29:47] <awjr>	 previously i used password gorilla
[18:29:49] <kaldari>	 why does mingle even need a password?
[18:30:16] <kaldari>	 we should set everyone's password to 'password' :)
[18:30:26] <awjr>	 there's no symbol character in 'password'
[18:30:30] <kaldari>	 rats
[18:30:34] <awjr>	 password.
[18:30:35] <awjr>	 there
[18:30:41] <kaldari>	 has to ahve a number too
[18:30:47] <awjr>	 pa55word.
[18:30:53] <awjr>	 passw0rd.
[18:30:57] <kaldari>	 nice
[18:31:19] <awjr>	 was that stallman?
[18:31:30] <awjr>	 who advocated setting passwords to 'password'?
[18:32:15] <kaldari>	 all these crazy password requirements have caused me to become more and more unsecure
[18:32:40] <kaldari>	 as I have to write down the passwords everywhere
[18:32:46] <grrrit-wm>	 (03PS20) 10Dr0ptp4kt: Better prevent chargeable resources from being inadvertently accessed. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 
[18:32:55] <awjr>	 i used to be like that until all these different services i used got hacked and it turned out they were doing things like storing my pws in plaintext, or using an unsalted md5 hash..
[18:33:01] <dr0ptp4kt>	 ^jgonera, fyi, just rebasing on master
[18:33:18] <dr0ptp4kt>	 jgonera, that was regarding 83133
[18:33:30] <awjr>	 lastpass has taken the pita element out of passwords for me.
[18:33:41] <kaldari>	 i use lots of different password, but they are passwords I can remember (or at least they used to be)
[18:34:23] <YuviPanda>	 tfinc: poke
[18:34:35] <MaxSem>	 awjr, what if your passwords DB gets lost?
[18:34:54] <awjr>	 then i use 'i forgot my password' everywhere
[18:35:17] <awjr>	 that's actually part of why i started using lastpass as opposed to password gorilla
[18:35:25] <MaxSem>	 that's a circular dependency, unless you don't 
[18:35:31] <kaldari>	 yeah, but lastpass doesn't work on my Kindle
[18:35:34] <MaxSem>	 store your email password
[18:36:10] <awjr>	 yeah, email password is one of the few i don't keep in last pass
[18:36:35] <awjr>	 but i also use gmail and it's possible to reset your account password if you jump through enough hoops
[18:36:36] <dfoy>	 awjr: +1 on last pass, I've been using it several years myself
[18:36:43] <kaldari>	 passwords are the main reason I hate the internet :)
[18:37:59] <awjr>	 hehehe amen kaldari
[18:38:28] <kaldari>	 keys are so much nicer
[18:39:42] <awjr>	 kaldari: do you mean like house keys or like ssh keys?
[18:39:49] <kaldari>	 both
[18:39:53] <awjr>	 :D
[18:40:02] <kaldari>	 like I would never put a combination lock on my front door
[18:40:16] <awjr>	 i keep copies of private ssh keys in lastpass just in case, but i can't do the same wiht my house keys
[18:41:30] <kaldari>	 I usually just leave everything unlocked though. I never lock my car and I never locked by front door until I moved to Oakland :(
[18:42:06] <kaldari>	 I'm an open access advocate :)
[18:44:03] <mhurd>	 kaldari: best euphemism for burglar ever: "open access advocate"
[18:44:31] <jdlrobson>	 so awjr this hasn't been merged yet - https://gerrit.wikimedia.org/r/#/c/86754/
[18:44:45] <jdlrobson>	 if i understood correctly yesterday kenan wanted some baseline data
[18:45:04] <jdlrobson>	 would kaldari be able to review and merge so late in the game?
[18:45:31] <awjr>	 jdlrobson: looks ok to me; if it's alright with jcmish that should be fine
[18:48:26] <kaldari>	 jdlrobson: it looks like it adds clicktracking twice
[18:48:33] <jdlrobson>	 kaldari: ?
[18:48:38] <awjr>	 looks like she might be away atm - jdlrobson if you can get someone to dbl check the JS and merge it, and MaxSem is OK with it, just do it; we can double check with jcmish before deployment
[18:49:34] <kaldari>	 what does M.on( 'page-loaded', addClickTracking ); do?
[18:50:06] <jdlrobson>	 kaldari: that is an event that executes after an edit or ajax page load when screen is re-rendered
[18:50:20] <kaldari>	 ah
[18:50:46] <kaldari>	 can you add a comment there for the benefit of the clueless? :)
[18:51:16] <jdlrobson>	 kaldari: we use that pattern everywhere
[18:51:41] <kaldari>	 fair enough, I guess I just hadn't run into it yet
[18:52:34] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Story 1263: Add click tracking to last modified link in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86754 (owner: 10Jdlrobson)
[18:53:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Story 1263: Add click tracking to last modified link in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86754 (owner: 10Jdlrobson)
[18:59:41] <jdlrobson>	 kaldari: ideally we should make it so that the event fires on startup as well but we never really worked that one out
[19:00:01] <jdlrobson>	 kaldari: kung fu panda upstairs on 6 ;-)
[19:00:18] <kaldari>	 is that a chinese restaurant?
[19:01:39] <kaldari>	 guess I'll have to find out...