[16:50:06] (03PS22) 10Dr0ptp4kt: Better prevent chargeable resources from being inadvertently accessed. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 [16:53:22] (03PS23) 10Dr0ptp4kt: Better prevent chargeable resources from being inadvertently accessed. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 [17:01:49] brion: i'm running a bit behind today so if your in the office can i get you to sign in on the rig ? [17:09:04] mhurd: i'm going to be remote for the standup. can you start up the hangout in the office ? [17:09:22] tfinc: ya! [17:09:25] thanks [17:16:54] brion: where you at ? [17:19:39] awjr: oh yeah... [17:19:43] ? [17:19:54] There was one more question about card 1258... [17:20:03] doh [17:20:17] sorry what was it kald? [17:20:20] er [17:20:23] kaldari: [17:20:37] oh, main page? [17:20:57] Do we add eventlogging to the lastmodified link on the Main page (which is not really a 'last modified' link), but a 'view history' link [17:21:04] double check with kenan about that one [17:21:21] I wonder where he went.... [17:21:28] he's probably at the apps standup [17:21:36] ah [17:21:47] but you should grab him like immediately afterwards because i think he has a mtg at 11 [17:22:07] thanks [17:22:09] np [17:45:43] dr0ptp4kt: ping [17:57:47] (03PS2) 10Jdlrobson: Beta: Fix infobox styling on larger resolutions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86715 [17:59:51] (03CR) 10Jdlrobson: [C: 031] "MaxSem you need to rebase. I can confirm this does what it's meant to be but will need confirmation from SPringle that this is indeed an o" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86683 (owner: 10MaxSem) [18:00:37] (03CR) 10Jdlrobson: [C: 031] "Is this good to merge?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86995 (owner: 10Aaron Schulz) [18:00:54] (03PS5) 10Jdlrobson: Hygiene: Allow MFResourceLoaderModule to handle templates and files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86290 [18:01:09] jdlrobson: What does the class 'sibling-page' mean? [18:02:21] (03PS3) 10MaxSem: Remove selectors now hidden in CSS or otherwise unneeded [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86784 [18:02:38] (03CR) 10MaxSem: "Yes it is." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86995 (owner: 10Aaron Schulz) [18:03:11] yurik, pong [18:04:54] jdlrobson: nevermind, I think I've figured it out [18:06:34] (03CR) 10Jdlrobson: [C: 032] Remove selectors now hidden in CSS or otherwise unneeded [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86784 (owner: 10MaxSem) [18:06:57] (03Merged) 10jenkins-bot: Remove selectors now hidden in CSS or otherwise unneeded [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86784 (owner: 10MaxSem) [18:07:55] (03PS2) 10MaxSem: Optimize count queries [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86683 [18:13:26] (03PS1) 10Jdlrobson: Regression: Hide the bullet points in the page list on nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87181 [18:15:23] (03PS19) 10Jdlrobson: Use .less files directly in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER) [18:15:23] kaldari: i'm going to merge the LESS patch [18:15:26] any objections? [18:15:40] wheeee [18:15:46] lemme take one last look [18:15:53] brion: i was also going to ask you but i see your answer ;-) [18:15:59] :D [18:16:00] use the less luke! [18:16:22] (03CR) 10Jdlrobson: [C: 031] "Waiting on Kaldari's quick check before +2ing" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER) [18:17:22] '+74, -3276' :) [18:18:24] deleting code is the best code [18:20:24] jcmish: can you help me get https://gerrit.wikimedia.org/r/#/c/85138/ done today? [18:20:30] brion: yuuuppp me loves deletion [18:20:50] oh yeah I forgot about that jdlrobson give me a minute [18:20:53] and i"ll look at that first [18:20:58] kaldari: my earlier comment: +50, -3320. Epic. [18:20:59] before I start the other things [18:21:02] it's even better now ;- [18:21:30] jcmish: ping me when you're up to speed with it and then i'll fill in the gaps - we can do a hangout if that makes things easier [18:21:59] there's a few things going on in it and we probably want to split them into multiple patches [18:22:28] kaldari: waiiit [18:22:42] jdlrobson, brion: getting rid of filepage.css is bad [18:22:53] hmm [18:22:57] also references.css [18:23:04] did it get copied to a .less or just dropped? [18:23:04] yeah definitely jdlrobson [18:23:07] otherwise filepages look pretty bad [18:23:44] brion: they just got dropped [18:23:49] (03CR) 10Jdlrobson: [C: 04-1] "filepage is actually needed... going to restore" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER) [18:23:58] d'oh [18:23:59] could we just keep those two as css for now? [18:24:15] kaldari: we can just rename them to .less files, they should compile through cleanly [18:24:27] brion: good idea [18:24:39] that way no need to keep a second dir around :D [18:28:48] MaxSem: can your table of contents change also kill filetoc? [18:29:03] no [18:29:15] two unrelated things [18:30:49] (03PS20) 10Jdlrobson: Use .less files directly in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER) [18:31:02] MaxSem: can you kill filetoc in some way [18:31:18] is CSS not enough? [18:31:43] css is enough for now [18:33:59] MaxSem: yeh but it would be nice to not have to special case it - we now have a css rule on all pages that only applies to one namespace [18:34:06] it's just messssyy [18:36:08] jdlrobson: lemme know when the references.css stuff is resolved [18:43:43] jdlrobson: i need to join the remimbursement sprint [18:43:48] then I'll ping ya [18:49:06] jcmish: sure [18:49:17] (03PS21) 10Jdlrobson: Use .less files directly in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER) [18:49:18] (03PS1) 10Jdlrobson: Hygiene: Remove history less file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87184 [18:50:38] (03CR) 10Jdlrobson: [C: 031] Use .less files directly in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER) [18:50:47] (03CR) 10Jdlrobson: [C: 032] Use .less files directly in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER) [18:51:09] (03CR) 10Kaldari: [C: 031] Use .less files directly in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER) [18:51:12] (03Merged) 10jenkins-bot: Use .less files directly in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/84139 (owner: 10Brion VIBBER) [18:52:48] hmm, I accidentally my apache:P [18:55:37] if anyone's bored, the notifications improvement change is still waiting for re-review: https://gerrit.wikimedia.org/r/#/c/82073/ :) [18:55:59] (03PS23) 10Kaldari: Various improvements to mobile notifications... [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 [18:56:04] (03CR) 10jenkins-bot: [V: 04-1] Various improvements to mobile notifications... [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 (owner: 10Kaldari) [18:56:34] it's already bitrotting :( [19:00:47] I need help! [19:00:48] # apache2ctl graceful [19:00:49] /usr/sbin/apache2ctl: 150: /usr/sbin/apache2ctl: /usr/sbin/apache2: not found [19:01:01] jdlrobson: webflow.com [19:01:26] while according to apt-get, apache2.2 is installed [19:03:08] phewww [19:04:20] fixed [19:06:15] so violetto1 i can't get it to generate css for me - but having a quick chat with juliusz it doesn't sound like it will make our jobs any easier. i guess the question would be do you feel like we badly interpret your designs frequently? Giving us CSS or an annotated diagram isn't much different [19:10:11] hey jgonera [19:10:57] jgonera, I can't reproduce https://bugzilla.wikimedia.org/show_bug.cgi?id=51991 anymore - is it fixed? [19:13:07] MaxSem, hard to say, for some reason the content of that revision changed... it's possible since we changed almost everything related to section wrapping [19:13:24] so it's WORKSFORME? [19:13:54] I guess? [19:14:10] ok, closing [19:24:14] (03CR) 10Jdlrobson: [C: 04-1] "This doesn't fix the problem for the list of Special:Uploads" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87181 (owner: 10Jdlrobson) [19:43:52] brion: do i keep pushing commits to github for now? [19:44:41] mhurd: for now that'd be easiest yeah, let's plan to go over gerrit fun in person later in the week or next week [19:44:51] brion: sounds good! [19:44:51] oh and i should bug yuvi about making sure that bot is running [19:45:02] once that's on, it'll sync pull requests between github and gerrit [19:45:04] which is BITCHIN [19:45:19] brion: yeah that'd be great! [19:45:20] * brion checks schedule [19:46:05] brion: oh just pushed commit to detailsWithoutTable which has license-from-category extraction pulled into own object [19:46:09] excellent [19:46:45] brion: hooked up license extraction for existing uploads - gonna hook up license selection for new images after lunch [19:46:58] awesome [19:47:39] i'll write up some gerrit notes and make sure they're accurate about the pull req stuff :D [19:47:50] brion: woohoo! [19:47:55] * brion pulls up detailsWithoutTable branch [19:48:40] mhurd: ooh i like the little pull handle on the categories, indicating you can swipe them off [19:48:50] brion: :) [19:49:20] nice touch! [19:49:46] brion: thanks!! [20:00:28] sorry folks running just a minute late [20:07:59] awjr: your connection is super bad now [20:08:03] awjr: kill the video [20:09:09] I think you upset him [20:13:11] rebooting my router seems to have fixed it... [20:24:49] (03PS1) 10MaxSem: Make mobileformat not change the output structure [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87252 [20:37:23] https://www.mediawiki.org/wiki/Mobile/Release_history [20:47:41] http://www.youtube.com/watch?v=4r7wHMg5Yjg < MaxSem [20:48:52] jdlrobson: running to pick up the kid and then I'll ping you [20:49:57] uh-oh [20:50:07] ok jcmish [20:58:35] Maryana: i haven't had a chance to peak at how the flow team is doing with Agile. How are things going ? [20:59:30] i think we're on a pretty good path, but it might be helpful if you or arthur sat in on a meeting at some point in the next couple of weeks [20:59:45] and offered us some notes/pointers [20:59:51] sure, invite us at optional and we'll sit in [20:59:59] awesome :) [21:00:09] arthur is already doing it for the i18n team so i'm happy to help here [21:00:14] oh, cool [21:00:27] awjr: i'm more then happy to switch too since i know the i18n hours suck for PST [21:00:59] groovy, that sounds good tfinc [21:02:06] tfinc i think the worst of it is over with i18n team; im going to try and go to a few of their standups (daily at midnight, pdt) and then their next retro (1.5 weeks from now, 10pm-12am) [21:02:31] awjr: k [21:02:42] awjr: seeing you in HD today almost made me think you were in the next room [21:02:53] ha cool [21:02:59] maybe that's what borked my internet [21:11:45] (03PS6) 10Jdlrobson: Hygiene: Allow MFResourceLoaderModule to handle templates and files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86290 [21:11:46] (03PS1) 10Jdlrobson: Hygiene: Merge all special stylesheets into a single one [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87263 [21:12:14] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Allow MFResourceLoaderModule to handle templates and files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86290 (owner: 10Jdlrobson) [21:17:37] (03PS7) 10Jdlrobson: Hygiene: Allow MFResourceLoaderModule to handle templates and files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86290 [21:17:38] (03PS1) 10Jdlrobson: Hygiene: Fix commented out test in MFResourceLoaderModuleTest.php [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87267 [21:27:16] brion: quick question: am i correct that presently FileUpload.h doesn't have a license property… so beginUploadProper method doesn't end up sending any license data when upload occurs. so license association is presently implicit? [21:27:47] mhurd: lemme double-check…. but yeah i suspect it's just hardcoded at the moment :) [21:28:33] (03PS3) 10Jdlrobson: Beta: Fix infobox styling on larger resolutions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86715 [21:28:55] mhurd: yeah, so you'll have to create a new version of the FileUpload schema in the data model and add a license field [21:29:20] (03CR) 10jenkins-bot: [V: 04-1] Fix infobox styling on larger resolutions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86715 (owner: 10Jdlrobson) [21:29:52] brion: ah! thanks! [21:29:56] lucky for you that's way easier in CoreData on iOS than on Android where we have to play with SQLite manually ;) [21:30:04] (03PS4) 10Jdlrobson: Fix infobox styling on larger resolutions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86715 [21:30:16] brion: but i like sql :) [21:30:34] *sqlite* [21:30:37] heh [21:31:23] (03PS2) 10Jdlrobson: Fix position fixed handling is iOS <= 4_2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86881 [21:31:36] (03PS2) 10Jdlrobson: Make lazy loaded pages containing h1s collapse on h1s [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86966 [21:33:16] brion: so i just add a "license" attribute in the FileUpload entity in "FileUpload 3.xcdatamodel"? [21:33:20] (03PS2) 10Jdlrobson: Beta: Fix EventLogging for profile and logout clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87031 [21:33:24] (03PS3) 10Jdlrobson: Fix EventLogging for profile and logout clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87031 [21:34:08] mhurd: basically… i think you want to create a new version (FileUpload 4?), there's a button hiding in the menus for that [21:34:18] brion: was just gonna ask that haha [21:34:21] then it'll know to upgrade the schema when you open the database [21:34:28] it probably moved in Xcode 5, lemme see if i can find it :D [21:34:59] 'Editor' menu -> 'Add Model Version' [21:35:10] yeah that's it [21:35:22] brion: awesome thx! [21:35:46] and you might have to regenerate FileUpload.h (or update it manually) [21:35:53] brion: oh, one more thing - as long as i call the attribute "license" should it then get sent properly with rest of data and dealt with on server side? [21:35:56] that's easy, just throw in the new property [21:36:05] brion: makes sense [21:36:15] mhurd: you'll have to tweak the {{self|cc-by-sa-3.0}} bit in the description text [21:36:36] have that put the appropriate template name inside the {{self|…}} when selecting something other than the default [21:37:00] someday we'll convert this stuff over to nice machine metadata [21:37:05] and then we will just send a damn field :D [21:37:13] alrighty jdlrobson back [21:37:24] wanna chat on a hangout? irc? what? [21:37:35] brion: hmm in that case (tweaking description text) do i even need to mess with the model? [21:38:08] mhurd: yes, you have to save the field in the local database until it's actually upload time, and then we gene ate the description [21:38:23] brion: also makes sense :) [21:38:24] that also lets you do things like change the license before uploading :) [21:39:40] brion: good test will be to have say 3 images waiting to be uploaded, with each selecting a different license, then go back and forth between them and make sure respective selections remain [21:41:32] brion: looks like the {{self|*license*}} bit happens in "formatDescription:" method. ok i think i've got it [21:49:26] spiff [22:06:37] (03PS1) 10Dr0ptp4kt: Only load W0 JavaScript and CSS when needed. See bug 49786. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/87271 [22:08:34] (03PS2) 10Dr0ptp4kt: Only load W0 JavaScript and CSS when needed. See bug 49786. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/87271 [22:09:12] ^yurik, jdlrobson would you please review 87271 and, if it works and addresses the reported bug 49786 please +2? [22:13:42] (03PS24) 10Dr0ptp4kt: Better prevent chargeable resources from being inadvertently accessed. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 [22:19:05] (03CR) 10Jdlrobson: [C: 031] "SPringle feel free to +2" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86683 (owner: 10MaxSem) [22:19:25] (03CR) 10Jdlrobson: [C: 032] "Well let's do that then..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86995 (owner: 10Aaron Schulz) [22:19:58] (03CR) 10Jdlrobson: [C: 04-1] "Kaldari please rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 (owner: 10Kaldari) [22:20:14] (03Merged) 10jenkins-bot: Avoid using DB avoidErrors() method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86995 (owner: 10Aaron Schulz) [22:36:52] any objections if I pull out https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/703 from the bcklog as it seems I'm out of backend cards this iteration? [22:38:02] MaxSem: feel like branching out and trying some front endy stuff? [22:38:40] i expect jdlrobson, jgonera and kaldari would be supportive :) [22:39:28] no objections from me [22:39:41] I think 703 is a very nice low-hanging fruit - now that we have Zero ppl I don't need to worry that I break interwikis [22:39:47] I'm fine with either [22:40:23] heh, and I can even do the nackend part for it;) [22:40:34] s/nackend/frontend/ [22:40:50] whee, I found the consensus!:P [22:41:08] lol [22:41:14] MaxSem: 703 is pretty low priority [22:41:57] I think it's pretty important performance-wise [22:42:21] MaxSem: what about 1261 or 1205? [22:45:19] ok, picked 1205 [22:45:24] :) [22:45:29] thanks MaxSem [22:45:45] mmm, it's indeed in my area [22:48:33] awjr, so what to do with 959? [22:48:42] ah yes [22:48:54] one sec MaxSem [22:50:42] MaxSem: if https://gerrit.wikimedia.org/r/80578 resolves the ToC issue and the tidy/parser issue is reported in another bug - then the reported bug should be closed with the merge of the ToC patchset to core, right? [22:51:03] it resolves the smaller part of 959 [22:51:16] yah, but the tidy issue is the bigger one? [22:51:21] yup [22:51:34] TOC is actually blocked on tidy too [22:51:38] >_< [22:52:18] MaxSem: since you've created a new bug for tidy, perhaps open a new bug for the ToC and reference it in 50530 [22:52:34] say 5030 has a dependency on the tidy and ToC bug [22:52:44] then we can push 959 back into our bug backlog [22:52:50] how does that sound? [22:53:47] alternatively we can close 505030 since the original reported problem was fixed, but also open a bug for the ToC issue [22:53:54] er [22:54:00] s/505030/50530 [22:58:32] gotta run to a mtg in a sec MaxSem - do what you feel is right, i just wanna get that stupid card out of 'in development' :) [22:58:54] (03PS1) 10JGonera: Remove .no-margins body class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87286 [22:59:00] ok:) [23:01:03] ehm, how do I thank someone on mobile? [23:04:18] anyone knows? ^^ :P [23:06:07] kaldari, ^ [23:06:42] You have to go to a diff page for a diff done by someone other than yourself [23:28:35] (03PS25) 10Dr0ptp4kt: Hide charge-inducing features. Intercept link interstitials sooner. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 [23:31:10] grmbl Echo schema grmbl [23:34:29] jdlrobson: an advise from vbamba: never poke a lady [23:34:38] MaxSem: whats the current link for the mobile api. i can't find it searching mw [23:35:34] see https://en.wikipedia.org/wiki/Special:ApiSandbox#action=mobileview&format=json [23:36:05] MaxSem: sorry. i meant api docs [23:37:52] https://www.mediawiki.org/wiki/Extension:MobileFrontend#action.3Dmobileview [23:38:07] but the sandbox is much easier to grok [23:39:07] kaldari, is Echo not deployed on enwiki? I don't see its tables... [23:41:00] ugh, I see it on Special:Version, but where is it in the DB? [23:41:22] MaxSem: it's definitely on enwiki [23:41:36] echo_events and echo_notifications [23:41:40] should be the tables [23:41:51] are you looking on stat1 or on the cluster? [23:42:03] on cluster [23:42:26] [enwiki]> show tables like 'echo%'; [23:42:26] Empty set (0.00 sec) [23:42:43] that's whack [23:42:55] I'll check.... [23:43:14] heh [23:43:26] looks like it has non-DB backends [23:44:13] that's actually good because no way this query can perform well on MySQL:P [23:44:52] MaxSem: I guess they switched it to reddis [23:45:21] might want to ask bsitu [23:45:47] it was using MySQL last time I messed with it [23:46:59]

MaxSem: Last time I saw bsitu they were leaving the channel #wikimedia-office at 10/1/2013 1:12:51 AM (1d22h33m47s ago) [23:47:23] maybe some docs on wikitech? [23:48:10] aha, $wgEchoCluster [23:48:16] external DB [23:57:41] MaxSem: it looks like you've already done magic with test2wiki [23:57:50] yup [23:57:53] (03PS2) 10JGonera: Remove .no-margins body class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87286 [23:57:54] i can't tell where the redirector was updated though? [23:58:00] thanks for doing that MaxSem :) [23:58:09] it worked for me [23:58:23] test2 never had exceptions for test2 [23:58:32] uhhh [23:58:35] eh? [23:59:04] (03PS26) 10Dr0ptp4kt: Hide charge-inducing features. Intercept link interstitials sooner. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 [23:59:24] s/first test2/redirector/ [23:59:51] sweet