[00:00:52] i'll get jcmish to run tests there etc and see if we can get on the train for next week. [00:02:52] (03PS3) 10JGonera: Remove .no-margins body class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87286 [00:04:51] (03PS1) 10JGonera: Remove dead spinner CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87294 [00:15:59] awjr: deployment train :) [00:16:04] woo woo! [00:40:52] (03PS1) 10Kaldari: Preparing the LastModified code for Mingle cards 1262 and 1258 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 [00:45:15] (03PS2) 10Kaldari: Preparing the LastModified code for Mingle cards 1262 and 1258 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 [08:08:50] (03PS2) 10Yurik: Added "admins" parameter to the zero config [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86820 [15:42:11] (03CR) 10Siebrand: [C: 031] "L10n/i18n reviewed." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86820 (owner: 10Yurik) [16:46:04] (03CR) 10Springle: [C: 032] "This is fine. The inner query is a simple derived table, so this is just as fast as the old way but avoids sending rows over the network a" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86683 (owner: 10MaxSem) [16:46:52] (03Merged) 10jenkins-bot: Optimize count queries [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86683 (owner: 10MaxSem) [17:00:06] MaxSem: do you have permissionis to import on test2wiki? [17:00:33] MaxSem: jcmish wants to import the San Francisco article there since that's what all of here tests use; unfortunately it looks like i dont have permissions :( [17:00:40] if I don't I can grant them to myself [17:03:20] hmm, I'm stuck with mobile view on test2 [17:03:47] er really? [17:04:08] :D [17:04:14] that made me laugh [17:05:12] MaxSem: can you upgrade yours, jcmish's and my privileges on test2? [17:05:23] and did you get unstuck yet :p [17:06:02] MaxSem: and awjr I asked chrismcmahon too [17:06:07] brb [17:07:02] awjr: yeah, I am bureaucrat and admin on test2 it seems [17:07:18] nice [17:07:20] awjr: what's your user name on test2? [17:07:28] chrismcmahon: awjrichards [17:07:30] :DS [17:07:32] yurik, you able to make the hangout? [17:07:34] omw [17:08:51] awjr: you have super duper privs on test2 now [17:09:38] I don't know Michelle's user name but either of us can fix it later [17:11:03] awjr: I gave jcmish privileges on test2 also, you should be set [17:12:10] cool thanks chrismcmahon! [17:43:42] thanks chrismcmahon [18:25:58] (03PS1) 10Jdlrobson: WIP Story 1072: KeepGoing CTA [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87426 [18:25:59] (03PS1) 10Jdlrobson: Alpha: Turn random into a campaign [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87427 [18:26:16] (03CR) 10Jdlrobson: [C: 04-1] "Need to talk to Kenan about logging requirements" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87426 (owner: 10Jdlrobson) [18:30:34] i love that vibha just said 'astroturfing is really cool' [18:30:57] must be an artificial high! [18:30:59] :) [18:31:12] (obscure FotC reference) [18:31:32] @_@ [18:48:43] (03PS2) 10Brion VIBBER: Hygiene: Cleanup gallery css [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86701 (owner: 10Jdlrobson) [18:55:44] (03CR) 10JGonera: [C: 04-1] "(6 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 (owner: 10Kaldari) [18:56:43] (03PS2) 10Jdlrobson: Beta: Open sections by default in tablet view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86713 [18:56:44] (03PS1) 10Jdlrobson: Add global LESS variables shared with JavaScript to define resolutions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87433 [18:56:55] (03CR) 10Brion VIBBER: [C: 032] "Spacing's a little different with the styles changed, but probably not a big deal. Needs major lovin' anyway to make it not suck but it wa" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86701 (owner: 10Jdlrobson) [18:58:17] (03Merged) 10jenkins-bot: Hygiene: Cleanup gallery css [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86701 (owner: 10Jdlrobson) [18:58:27] * jdlrobson hugs brion  [18:58:33] aww [19:08:07] (03CR) 10Jdlrobson: "(8 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 (owner: 10Kaldari) [19:08:32] (03PS2) 10Jdlrobson: Remove dead spinner CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87294 (owner: 10JGonera) [19:10:48] (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove dead spinner CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87294 (owner: 10JGonera) [19:11:13] (03Merged) 10jenkins-bot: Hygiene: Remove dead spinner CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87294 (owner: 10JGonera) [19:12:46] brion: so the lack of embedding was on purpose [19:12:49] " /* Purposely do not embed any images in this mixin to avoid repetition of same svg file due to vendo [19:12:50] r prefixes */" [19:12:58] ehhhhh [19:13:06] gzip will compress those 2 to equivalent of 1 [19:13:09] -webkit-linear-gradient(transparent, transparent), url(@svg); linear-gradient(transparent, transparent), url(@svg); [19:13:15] o rly? [19:13:19] yep [19:13:24] ah that's good to know [19:13:49] ok so i should probably use annotations right - to ensure localization as well [19:14:22] for now…. but i think we still need a fix to the less converter for those [19:14:37] another possibility is we could make the mixins smarter [19:14:46] provide a less variable indicating whether we're in RTL mode? [19:14:52] and then the mixins could adjust... [19:15:04] (03PS1) 10MaxSem: Factor out DB work out of UserProfile to separate UI from backend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87434 [19:18:37] brion: yeh i talked to ori about having a global @dir variable [19:26:51] (03CR) 10Brion VIBBER: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87184 (owner: 10Jdlrobson) [19:29:19] (03PS2) 10Brion VIBBER: Regression: Hide the bullet points in the page list on nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87181 (owner: 10Jdlrobson) [19:51:00] tfinc: https://gerrit.wikimedia.org/r/#/c/79948/ [19:52:34] (03PS1) 10MaxSem: Card 1205 - last thanked info on UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87440 [20:04:38] (03PS24) 10Kaldari: Various improvements to mobile notifications... [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 [20:06:14] (03CR) 10Kaldari: [C: 04-1] "Just rebased, still need to address comments." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 (owner: 10Kaldari) [20:25:33] (03CR) 10Kaldari: [C: 04-1] "I support killing the voodoo in MobileSpecialPage.php, and would encourage killing all of it. However, I don't think it makes sense for us" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87263 (owner: 10Jdlrobson) [20:33:57] jdlrobson: I'm gonna take a break on the test2.m tests config so I can ask about the test you created [20:34:08] jcmish: sweet [20:34:11] how to you wanna talk through it? Hangout? [20:34:29] and kaldari i completely disagree with you :) [20:34:33] hahahhahah [20:34:40] :D I'm working on it kaldari :D [20:34:41] arm wrestle? [20:34:55] jcmish: ummmm hangouts fine let me find a room [20:34:59] I'll only stop for a minute because I can try to work on jdlrobson's stuff tonight [20:35:15] and I promise to go back to the test2.m stuff kaldari :D [20:36:17] (03CR) 10Brion VIBBER: [C: 032] "confirmed fixes regression on special:nearby" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87181 (owner: 10Jdlrobson) [20:36:41] (03Merged) 10jenkins-bot: Regression: Hide the bullet points in the page list on nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87181 (owner: 10Jdlrobson) [20:37:42] (03CR) 10Kaldari: "(10 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 (owner: 10Kaldari) [20:39:33] jcmish: https://en.wikipedia.org/?useskin=monobook [20:39:48] https://en.wikipedia.org/?useformat=mobile [20:40:10] jdlrobson: I'm afraid I don't understand the motivation for wanting to merge all the special stylesheets. What do special pages have in common? Why not put all the styles in one stylesheet if you want to cache them together. [20:41:03] Why just special pages? [20:42:43] echo $MEDIAWIKI_URL [20:43:03] kaldari: 1s [20:43:35] echo $MEDIAWIKI_URL [20:43:36] http://localhost.m:80/w/index.php/ [20:44:35] http://127.0.0.1:80/w/ [20:49:05] https://gerrit.wikimedia.org/r/#/c/85138/1/tests/acceptance/features/support/env.rb [20:49:07] ^ jcmish [20:57:48] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87440 (owner: 10MaxSem) [21:06:36] (03CR) 10Siebrand: [C: 031] "L10n/i18n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87427 (owner: 10Jdlrobson) [21:08:15] MaxSem: i'll beautify your profile stuff now [21:08:23] wee, thanks! [21:09:18] (03CR) 10Siebrand: [C: 031] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87426 (owner: 10Jdlrobson) [21:17:29] (03CR) 10Jdlrobson: [C: 04-1] "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87286 (owner: 10JGonera) [21:17:39] (03CR) 10JGonera: "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 (owner: 10Kaldari) [21:21:04] (03CR) 10Kaldari: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 (owner: 10Kaldari) [21:46:43] jdlrobson: can you respond to Trevors comment ? [21:58:05] (03CR) 10JGonera: [C: 04-1] "(4 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87433 (owner: 10Jdlrobson) [22:00:29] (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87031 (owner: 10Jdlrobson) [22:03:29] jdlrobson: will you need support from kaldari and jgonera for the review that trevor just called [22:03:39] * tfinc gets annoyed at irc changing is nick [22:05:05] YuviPanda|away: are you travel planes moving forward ? [22:06:43] awjr_away: heads up that i'll want to coordinate my thoughts about the inception that we'll be running [22:06:52] for the app team at the end of the month [22:12:04] jdlrobson read scrollback, you shouldn't have to muck around in env.rb at all. I'm not sure what you're trying to accomplish there [22:14:01] (03CR) 10JGonera: [C: 04-1] "(3 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86881 (owner: 10Jdlrobson) [22:16:13] (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87252 (owner: 10MaxSem) [22:19:48] (03PS2) 10MaxSem: Make mobileformat not change the output structure [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87252 [22:19:51] (03CR) 10JGonera: [C: 04-1] "I still don't agree with mw.template. Right now templates do depend on MF, so making them look as if they didn't is confusing. Templates a" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86290 (owner: 10Jdlrobson) [22:20:05] kaldari, any views on my comment at https://gerrit.wikimedia.org/r/#/c/86290/ ? [22:21:01] looking [22:22:24] jgonera_, jdlrobson: yeah, it seems premature to rename it 'mediawiki' before it is upstreamed to core. [22:22:51] but I don't have a strong opinion about it [22:23:06] kaldari: jgonera_ why is it okay for EventLogging to do that then? [22:23:12] we have mw.logEvent [22:23:30] oh, you mean that [22:23:32] ? I thought it was mobile.loggingSchemas [22:23:39] it probably shouldn't [22:23:51] EventLogging is an extension [22:23:59] why do we register mw.mobileFrontend ? [22:24:16] but it basically looks more reasonable, people might expect EL extension to add a logEvent() function to mw, but why would MobileFrontend add template? [22:24:31] as a precursor to upstreaming to core [22:24:41] same reason we have mw.mobileFrontend [22:24:59] there is no dependency on the template stuff to code for MobileFrontend [22:25:02] but what benefits are there? nobody will use it externally anyway, because everyone will know it's not in the core yet [22:25:06] jdlrobson: Looks like event loggings modules are 'ext.eventLogging' and 'ext.eventLogging.jsonSchema' [22:25:38] kaldari: well there's 2 things hear - naming it mobile.templates vs mediawiki.templates [22:25:43] and registering to mw or mw.mobileFrontend [22:25:59] jdlrobson, how exactly would any of those things help us get it into core faster? [22:26:10] jgonera_: i think your being pedantic in this situation - i don't see your argument for why you wouldn't do this [22:26:28] ah, I see what you mean [22:26:32] I also don't see an argument for doing it, so I default to being pedantic ;) [22:26:48] I think we should flip a coin :) [22:26:58] as it doesn't matter much either way [22:27:27] well, it doesn't but I'm still curious as to why it would help to rename it now [22:28:28] So the advantage of doing it this way is that the template resource loader module doesn't need to depend on mobile.startup which contains a lot of other cruft [22:32:33] (03CR) 10Kaldari: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 (owner: 10Kaldari) [22:39:08] (03CR) 10Jdlrobson: "(3 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87433 (owner: 10Jdlrobson) [22:39:18] (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86713 (owner: 10Jdlrobson) [22:39:19] jgonera_, jdlrobson it's going to take a lot of practice for me to remember not to use .click() :P [22:40:07] kaldari, I had to get used to it to, but it just makes more sense in the longer run [22:40:34] yeah, I'm fine with it, just have to get out of the habit :) [22:42:05] man, I sure make a lot of JS scoping errors :) [22:42:20] need to pay more attention to that [22:46:29] brion: how is https://trello.com/c/lbBitujU/51-2-android-parse-out-license-data-from-wikitext going ? [22:51:30] (03PS25) 10Kaldari: Various improvements to mobile notifications... [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 [22:53:05] jdlrobson, jgonera_ , MaxSem: All the issues with the notification fixes should be addressed: https://gerrit.wikimedia.org/r/#/c/82073/ [22:53:42] jdlrobson: I left the module loading in there for now since your change isn't merged yet [22:54:21] will have a look in a moment [22:59:12] (03CR) 10Jdlrobson: "(3 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86881 (owner: 10Jdlrobson) [23:01:09] (03PS2) 10Jdlrobson: Card 1205 - last thanked info on UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87440 (owner: 10MaxSem) [23:01:10] (03PS1) 10Jdlrobson: Tweak markup of edits and uploads text [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87474 [23:01:37] (03CR) 10Jdlrobson: [C: 04-1] "MaxSem please take another look at server side code whilst I get an icon from the design team.." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87440 (owner: 10MaxSem) [23:04:41] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86713 (owner: 10Jdlrobson) [23:04:54] tfinc: sure thing; you mean you're planning on planting dreams within dreams within dreams? is this for some kind of heist? [23:05:15] awjr: :) [23:05:21] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87184 (owner: 10Jdlrobson) [23:05:38] * jdlrobson drowning in gerrit [23:05:41] (03CR) 10MaxSem: [C: 04-1] "If a user has more than 501 edits or uploads, tyhey will see 501 instead of mobile-frontend-profile-(edits|uploads)-limit." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87474 (owner: 10Jdlrobson) [23:06:38] (03CR) 10Jdlrobson: "ohohh yeah - good catch. Siebrand gave a good suggestion - we cap it at 100 and then use plural to only need one message." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87474 (owner: 10Jdlrobson) [23:07:01] tfinc: is that what you're planning for nov when Yuvi is in SF? [23:07:02] yes [23:07:07] (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86966 (owner: 10Jdlrobson) [23:07:08] (03PS2) 10Jdlrobson: Tweak markup of edits and uploads text [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87474 [23:07:23] awjr: deep dive between design, engineering, and product to develop the backlog for the first sprint of the Wikipedia App [23:07:27] very cool. happy to help any way i can tfinc [23:07:29] (03PS2) 10Jdlrobson: Hygiene: Remove history less file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87184 [23:07:41] i'll lead it but i'm sure it'll be interesting to think through it with you [23:07:46] jdlrobson, you reverted my changes: https://gerrit.wikimedia.org/r/#/c/87440/1..2/includes/specials/SpecialUserProfile.php [23:07:48] totes [23:09:25] (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86713 (owner: 10Jdlrobson) [23:13:37] (03CR) 10JGonera: "(3 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87433 (owner: 10Jdlrobson) [23:14:19] kaldari, so can we use human readable dates from core for last modified or not? [23:14:37] (03PS4) 10Jdlrobson: Fix EventLogging for profile and logout clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87031 [23:14:38] (03PS1) 10Jdlrobson: Track anonymous clicks as well [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87478 [23:14:55] eh, it looks like we can't since there isn't client-side support for it :( [23:18:56] (03CR) 10JGonera: [C: 04-1] "(3 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 (owner: 10Kaldari) [23:20:31] (03CR) 10JGonera: [C: 032] Fix EventLogging for profile and logout clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87031 (owner: 10Jdlrobson) [23:21:00] (03Merged) 10jenkins-bot: Fix EventLogging for profile and logout clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87031 (owner: 10Jdlrobson) [23:21:45] (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87478 (owner: 10Jdlrobson) [23:22:53] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86966 (owner: 10Jdlrobson) [23:23:09] (03PS3) 10Jdlrobson: Make lazy loaded pages containing h1s collapse on h1s [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86966 [23:24:44] jgonera_: "Because someone might remove this space and then we end up with class .content_blocopenSection" really?! that seems a silly mistake to make [23:25:27] jdlrobson, what if I change the order of classes and forget to change the space at the beginning to a space at the end, what if I add one more class after that, etc. [23:25:37] yes, they are silly mistakes, but why make them possible? [23:25:47] jgonera_: but why worry about those kind of mistakes? [23:26:06] jdlrobson, I'm afraid I don't have an answer to such question... [23:26:10] :) [23:26:33] they're mistakes, silly mistakes take the longest to debug [23:26:33] also i was talking to my friend who works for iTunes about one line css rules and she says thats perfectly acceptable and does it all the time [23:26:36] (03CR) 10jenkins-bot: [V: 04-1] Make lazy loaded pages containing h1s collapse on h1s [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86966 (owner: 10Jdlrobson) [23:26:48] says OOCSS prefers smaller, mix and match style declarations [23:26:56] (object orientated CSS) [23:27:00] iTunes is possibly one of the most buggy pieces of software Apple created ;) [23:27:24] jgonera_: how would it be difficult to debug a missing space… srsly :P? [23:27:28] ok, we can try that, but I predict elements with dozens of classes inside the class attribute... [23:27:44] (03CR) 10Kaldari: "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 (owner: 10Kaldari) [23:27:53] jdlrobson, ok, let me put it the other way round: what is a counter argument for doing it your way? [23:28:06] how is it better, even in a slight way? [23:28:16] jgonera_: because it's already written and it seems silly to rewrite it [23:28:19] (03CR) 10JGonera: [C: 032] Various improvements to mobile notifications... [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 (owner: 10Kaldari) [23:28:24] i'm not saying it's better i'm just saying your way doesn't seem any better [23:28:27] rewrite? [23:28:46] (03Merged) 10jenkins-bot: Various improvements to mobile notifications... [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82073 (owner: 10Kaldari) [23:28:59] (03CR) 10Dr0ptp4kt: "(8 comments)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 (owner: 10Dr0ptp4kt) [23:29:15] well the code's written and does what it's suppose to do, you are suggesting i check it out and refactor it so it looks different and to me this just seems a silly use of my time when i have about 20 patch sets open many of which are more important :) [23:29:31] especially when there is no advantage either way [23:29:34] well, I just told you why it's better, but you just replied "why would we care about silly mistakes" which seems... inconsiderate [23:30:01] jdlrobson, kaldari 's mistake of using this instead of self is also silly, but would cause error callback not to be fired [23:30:20] jgonera_: does this introduce a mistake? No. [23:30:33] I'm really unsure why it's so difficult for you to change 3 lines in your patch, I can do it, but I prefer to do CR and let the author make the changes [23:31:07] thunderdome? [23:32:00] I'm tired of typing and it's hard to understand your attitude through the medium of text... [23:35:22] +1 kaldari [23:50:37] (03CR) 10Kaldari: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86715 (owner: 10Jdlrobson) [23:59:44] jcmish: is there any way that you can add tfinc@wikimedia.org to be an authorized user? i added the account but it doesn't seem to validate against our wmf instance