[00:03:20] (03PS2) 10Jdlrobson: Track anonymous clicks as well [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87478 [00:03:56] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87478 (owner: 10Jdlrobson) [00:04:18] for? [00:04:20] cloudbees? [00:04:39] (03PS3) 10Jdlrobson: Track anonymous clicks as well [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87478 [00:06:42] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86715 (owner: 10Jdlrobson) [00:07:10] (03CR) 10Kaldari: [C: 031] Fix infobox styling on larger resolutions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86715 (owner: 10Jdlrobson) [00:07:52] (03CR) 10Kaldari: [C: 032] Fix infobox styling on larger resolutions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86715 (owner: 10Jdlrobson) [00:08:19] (03Merged) 10jenkins-bot: Fix infobox styling on larger resolutions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86715 (owner: 10Jdlrobson) [00:08:35] (03PS3) 10Jdlrobson: Card 1205 - last thanked info on UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87440 (owner: 10MaxSem) [00:09:44] (03CR) 10MaxSem: [C: 04-1] "You reverted most of my changes factoring out MobileUserInfo: https://gerrit.wikimedia.org/r/#/c/87440/1..3/includes/specials/SpecialUserP" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87440 (owner: 10MaxSem) [00:09:49] jdlrobson, ^^^ [00:10:07] MaxSem: okay let me fix this up and then feel free to retweak it [00:10:17] i had a rebase issue [00:10:21] that may have broken it :) [00:10:35] gimme 10 minutes to fix up remaining problems that i have control over then it's all yours again :) [00:10:49] and sorry :) [00:13:28] jgonera: I'm going to change all the instances of 'last modified' to 'last edited' per Vibha, but I'm going to leave the i18n keys as they are. That way they will just be 'fuzzied' instead of requiring completely new translation from scratch. [00:17:07] Dcoetzee: howdy [00:17:21] kaldari: Hi :-) [00:18:20] Any good content liberations lately? [00:19:03] Is that all I'm known for ;-) [00:19:45] No, not since the last Google Art Project uploads, which stirred up no animosity, despite the technical barriers that they placed to prevent it [00:19:45] well, that's my favorite thing :) [00:20:06] GAP is always adding new stuff, so I have to periodically revisit them and upload more stuff [00:20:14] I'm the only one who has the tools to circumvent their restrictions. [00:20:31] Or, if they've implemented new restrictions, I get to do more reverse engineering :-P [00:20:54] It's kind of funny, people often come to me and say "can you help with this batch upload from this website" [00:21:21] I wonder if they're just adding the restrictions at the insistance of the museums [00:21:21] And most of the time, I say "no" just because it's an easy and uninteresting case where there are no protections in place whatsoever [00:21:40] It's only fun for me when I'm facing technical challenges :-P [00:22:08] lol, you should figure out how to remove digital watermarks. Now that's a challenge [00:22:10] I have two theories, one is that it's the museums compelling them to do it [00:22:21] violetto: can you poke vibha and say that the user icon is not green it's grey [00:22:36] The other is that they do it to prevent everybody from using up tons of bandwidth downloading all their pics [00:22:45] ah true [00:22:51] Although, Google runs YouTube [00:23:06] So they don't exactly want for bandwidth [00:23:23] yeah, but they don't get to tack advertisements onto the Mona Lisa :) [00:23:27] I've looked into watermark removal a lot [00:23:43] Translucent watermarks are generally straightforward to remove - I automatically removed watermarks from the LIFE archive [00:24:11] removing Digimark marks is what I would love [00:24:12] Opaque watermarks can be removed with object removal techniques, but Photoshop's content-aware fill more or less represents the state-of-the-art in that area [00:24:29] Really? I'm kind of apathetic about Digimark marks [00:25:01] They're invisible and they can't actually do anything bad to you if they find you using it [00:25:10] they make the images feel tainted to me, but I guess that's a minor complaint [00:25:30] At worst they might mislead somebody who gets the image somewhere [00:25:38] And thinks their bogus claims in the watermark are true [00:26:27] In fact, we usually don't even remove bogus EXIF metadata [00:26:34] Partly because we're lazy :-P [00:26:59] Partly cause most people aren't gonna notice it's there [00:27:22] Partly cause it's useful sometimes to document their bogus claims [00:29:46] (03CR) 10Jdlrobson: "Templates do not depend on MobileFrontend JavaScript at all. If left in this form other extensions are able to make use of them simply by " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86290 (owner: 10Jdlrobson) [00:42:40] (03PS4) 10Jdlrobson: Card 1205 - last thanked info on UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87440 (owner: 10MaxSem) [00:42:41] (03PS3) 10Jdlrobson: Tweak markup of edits and uploads text [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87474 [00:42:45] MaxSem: allyours ^ :) [00:43:48] w00t! [00:54:19] (03PS8) 10Jdlrobson: Hygiene: Allow MFResourceLoaderModule to handle templates and files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86290 [00:54:20] (03PS2) 10Jdlrobson: Hygiene: Merge all special stylesheets into a single one [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87263 [00:56:35] jdlrobson, the edit section test is broken, the tutorial doesn't show [00:56:52] something is wrong with the target = window.location.hash + ' ~ .edit-page'; [00:56:52] selector I think [00:58:18] (03CR) 10Jdlrobson: [C: 04-1] "So Kaldari and I spoke about this." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87263 (owner: 10Jdlrobson) [00:58:32] qa test or qunit ? [00:58:52] on master? [00:59:12] anyway.. this will have to wait till tomorrow i need to go! [01:04:53] (03PS3) 10Kaldari: Preparing the LastModified code for Mingle cards 1262 and 1258 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 [04:12:51] (03PS1) 10Mgrover: QA#1286 using an article that is on beta, test2 and en.m so changing from San Francisco to Barack Obama [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87504 [06:08:20] (03CR) 10Siebrand: [C: 04-1] "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87474 (owner: 10Jdlrobson) [07:49:23] (03CR) 10Siebrand: [C: 04-1] "(8 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 (owner: 10Kaldari) [08:08:14] (03CR) 10Siebrand: [C: 04-1] "(13 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87440 (owner: 10MaxSem) [13:05:32] MaxSem: ping [13:06:35] pong [13:08:27] hey MaxSem, want to give some feedback on my new security model for zero? :) [13:08:59] MaxSem: https://gerrit.wikimedia.org/r/#/c/86820/ [13:09:58] MaxSem: just take a look at https://gerrit.wikimedia.org/r/#/c/86820/2/includes/ConfigPageHooks.php [13:10:03] that's the gist of it [13:14:16] mmm, this might prevent innoculous actions like watching [13:14:53] eh, hi, just to confirm, is WAP dead or not [13:15:35] no [13:15:57] I'd really like to, but omg think of all those third world ppl [13:16:01] pls don't kill it - i have been using it extensivelly :) [13:16:04] so it still makes sense to have a bugzilla component for WAP mobile gateway [13:16:13] and in product Wikimedia [13:16:17] not in mobile ? [13:16:17] it's part of MF [13:16:21] ok [13:16:30] so no extra component needed [13:16:42] * MaxSem bites yurik_ [13:17:02] ah, ok, i'm gonna suggest that the bugmeister removes it then [13:17:03] i lost my phone, so i have been using $10 nokia i got in s africa. Works beautifully! [13:17:07] thanks Max [13:17:17] and wiki looks really useful from it, honest [13:17:27] although i'm not sure if it gets identified as wap or not [13:17:45] if you see the hamburger it's HTML [13:17:58] WAP looks like an ass [13:22:55] MaxSem: weird, i went to http://www.whatsmyuseragent.com/ and got Mozila/5 AppleWebKit/... (KHTML Google wireless transcoder) Chrome/.. Safari/.. [13:23:05] no mentioning of wap [13:23:28] i wonder if new nokias autotranslate to wap using google proxy [13:29:02] MaxSem: so is there a list of "ok" verbs? [13:29:06] actions [13:30:28] cya [13:32:27] umm, don't think so [13:32:45] mainly because what's ok for you might not be so for other uses [13:35:24] yurik_, so do you see whole article content at once or you have to use next/back link to go between sections? [13:35:32] not expand/collapse [13:35:54] MaxSem: what sections do you mean? [13:36:00] there are no sections on the zero page [13:36:21] it looks like https://meta.wikimedia.org/wiki/Zero:250-99 [13:37:15] open WP;) [13:49:45] MaxSem: sorry, still confused a bit - there are no sections, and i haven't seen anything like next/prev section buttons anywhere on wp [13:52:17] MaxSem: i will search for other actions and make a list of "ok" ones [13:52:39] pls comment on that patch [13:52:44] if you think of anything else [13:52:47] have to go now [13:52:55] grr, sucks to not have 24x7 internet [13:53:00] working offline most of the time [14:21:12] (03PS1) 10Zfilipin: Moving shared code to mediawiki-selenium Ruby gem [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87563 [14:27:48] (03PS1) 10Zfilipin: Renamed tests/acceptance folder to tests/browser [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87565 [14:51:15] (03CR) 10Cmcmahon: [C: 032] QA#1286 using an article that is on beta, test2 and en.m so changing from San Francisco to Barack Obama [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87504 (owner: 10Mgrover) [14:51:44] (03Merged) 10jenkins-bot: QA#1286 using an article that is on beta, test2 and en.m so changing from San Francisco to Barack Obama [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87504 (owner: 10Mgrover) [15:40:35] * MaxSem bites jdlrobson [15:40:48] what did i do now? [15:41:17] dude, you made https://gerrit.wikimedia.org/r/87440 not depend on https://gerrit.wikimedia.org/r/87434 [15:41:27] resulting in a total mess [15:41:57] mmmm that's confusing how did i manage that [15:41:59] sorry!! [15:42:02] * jdlrobson notices the time and decides to jump in shower so he makes standup [15:42:15] can you just merge the earlier commit? [15:42:53] then I can try to rebase it [15:45:08] MaxSem: let me try? [15:45:12] (fixing the depends) [15:45:25] YuviPanda, just merge https://gerrit.wikimedia.org/r/87434 :) [15:45:40] I'll do the rest [15:46:05] it's pretty easy to review, just code moved from one class to another [15:46:15] 116 lines! [15:46:19] and more [15:46:22] don't think I can merge that :P [15:48:29] hmm, that already has a dependency ;( [15:50:14] MaxSem: i give up, too many conflicts [15:50:21] plus I forgot my wrist hurts [15:50:40] https://gerrit.wikimedia.org/r/87434 has no dependencies [15:52:42] MaxSem: i was trying to fix the dependency situation. but oh well, i'll merge [15:52:57] MaxSem: done [15:52:57] (03CR) 10Yuvipanda: [C: 032] "In Max we trust (plus looks like a copypaste job)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87434 (owner: 10MaxSem) [15:53:04] thanks:) [15:53:22] (03Merged) 10jenkins-bot: Factor out DB work out of UserProfile to separate UI from backend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87434 (owner: 10MaxSem) [16:06:24] MaxSem: apologizes.. i see what i did - i cherry picked [16:06:29] and forgot to cherry pick the first [16:06:55] going to office now MaxSem sorry again and see you soon :) [16:57:07] jcmish: were you able to get the tests run on test2 yesterday? [16:57:26] yep just one that I'm changing now [16:57:33] the others are changed and checked in [16:57:36] cool [16:57:38] \o/ [16:57:40] yup [16:57:41] :D [16:57:47] sad that the export didn't work :D [16:57:54] i know :( [16:57:55] but it was easier to just change the tests [16:58:26] aye; and i know other teams use the barack obama article for similar purposes, so it's probably good for us to follow suit [16:58:38] yupper [17:10:41] and +2'd also btw, it's merged [17:12:02] export/import to these envs is one of those back-boiler things that will someday bubble to the top of Stuff To Figure Out, thanks for investigating that [17:12:46] chrismcmahon: I was bitten by it earlier today (reproducing production environment). I'm guessing that just importing all Template:* and Module:* should make most other things *very* easy [17:13:26] chrismcmahon: and was going to hack that up over the weekend, my wrist pain permitting. [17:13:30] chrismcmahon: think that'll be useful? [17:13:53] YuviPanda: the subject of new data to beta and test2 keeps coming up, but it hasn't yet been critical to anything in particular [17:14:08] chrismcmahon: right. [17:14:19] YuviPanda: it would definitely be worth knowing how to do it! [17:14:58] chrismcmahon: I was thinking of setting up a tool on toollabs that'll produce dumps every month or so, and that can be imported into any wiki with a single ocmmand [17:15:03] so they'll be like a month old, but that's ok [17:15:47] brion: am I in the wrong hangout? [17:15:55] YuviPanda: web is running over a little [17:15:57] ah [17:15:58] ok [17:15:59] YuviPanda: that would be pretty great. the flip side would be a tool that would actually remove data, images, etc. No one's ever done that before. [17:16:22] chrismcmahon: remove data, images from where? [17:16:36] but YuviPanda we would definitely use an automatic importer from time to time. [17:16:38] jdlrobson: you mentioned the qunit tests are failing again - sorry to cut you off but i didnt want to take time away from the apps standup [17:16:56] jdlrobson: i presume you can coordinate getitng to the bottom of it? [17:17:44] YuviPanda: remove pages, images, users, etc. so as to re-set a test environment to a previous state. (I realize that Mediawiki is not and never has been designed to do that, rather the opposite: nothing is ever deleted permanently) [17:18:17] awjr: yeh i'm trying to work it out as we speak [17:18:31] jgonera: do they fail for you? [17:18:35] wondering if it was a core change [17:18:42] seems to be mediawiki.tests.qunit.testrunner: [17:18:47] chrismcmahon: ah, hmm, right. [17:18:57] chrismcmahon: well, I use vagrant, so I can do that with a destroy / up :) [17:19:14] chrismcmahon: and since destroys are much cheaper now since the last week, it's quite nice [17:19:35] chrismcmahon: are you aware of https://wikitech.wikimedia.org/wiki/Labs-vagrant [17:19:41] not the same as beta, of course [17:19:55] YuviPanda: vagrant is very cool, and getting nicer all the time [17:20:11] jdlrobson, when did they start failing for you? [17:20:17] last night [17:20:26] bizarrely if i checkout before the echo fix they work [17:20:41] Echo fix in MF? [17:21:04] git checkout 1b8f1fa781e99427e50c605cf37d6c154d4b982b 0 errors [17:21:18] "Various improvements to mobile notifications" seems to have broken it [17:21:41] jgonera: how do you guys call the section edit markup notice used in the beta test and is there any design documentation/screenshot on mediawiki.org? [17:22:01] * DarTar is creating a summary of the notes on the a/b test that we discussed yesterday [17:22:06] jdlrobson, yes, 2 tests fail for me [17:22:13] we have our first example of thank trolling in #wikimedia-dev [17:22:40] awjr: thanktrolling is real now [17:22:46] we've a user complaining of it in -dev :) [17:22:47] DarTar, the blue thing I didn't show you because of a regression? ;) [17:22:53] lol [17:22:54] awjr: thank trolling is real! [17:22:56] who knew! [17:22:58] omfg [17:23:01] yes that thing [17:23:02] SHIT [17:23:11] the spike didn't help!! [17:23:32] lol [17:23:43] i guess someone needs to come up with policy guidelines for thank trolling :( [17:23:44] DarTar, I don't think we have an up to date screenshot because design kind of evolved organically for this one. I can fix it today and take a screenshot [17:23:53] awjr: yeah! or add a userright [17:24:02] k cool [17:24:18] awjr: however, threatening someone with 'you can no longer thank people!' doesn't seem great [17:24:24] hehehehe [17:29:23] Maryana: there has been a heavy case of thank trolling in the Dutch Wikipedia, apparently :) people are discussing whether to block the troll or not... :) [17:29:34] haha [17:29:39] it was only a matter of time [17:29:43] indeed [17:29:48] AND THE TIME IS NOW! [17:29:49] it's all your fault!:P [17:30:04] indeed, if only awjr has allocated the time for the AI work... [17:30:21] blame product, man, they're the ones who set the priority [17:30:57] :) [17:31:02] :p [17:31:08] let's blame glusterfs [17:31:12] even better [17:31:25] :D [17:31:31] i still cant believe the foershadowed thankyoupocalypse is actually happening [17:31:47] I wonder what else is going to happen... [17:31:52] 13 hour spikes? [17:32:31] 23:02 Nemo_bis: COMBAT THE THANKS DEFLATION [17:32:36] this is hilarious [17:33:18] lol, and card 1205 will result in "Last thanked by You're asshole for edits on [[Penis]]" on user profile [17:34:05] *your [17:39:21] awjr: priorities are good [17:39:28] \o/ [17:39:29] thanks kenanwang [17:39:33] jdlrobson: hey when would you like to meet. now? [17:39:51] awjr: I've got 20 minutes to my next meeting [17:39:54] i think jdlrobson is resolving the thankyoupocalypse in #wikimedia-dev [17:39:55] kenanwang: we have a thank trolling incident [17:40:51] this is… hillarious [17:40:58] awjr: to say the least [17:40:59] :D [17:41:05] hahahahah [17:41:11] seriously? [17:41:16] kenanwang: yeah, seriously. [17:41:18] 23:02 Nemo_bis: COMBAT THE THANKS DEFLATION [17:41:24] awjr: when will we be getting the rollup of all contributions to http://mobile-reportcard.wmflabs.org/ ? [17:41:24] and similar puns flowing freely [17:41:34] kenanwang: although I think he meant THANKS INFLATION [17:41:45] is there a bug associated with this? [17:41:58] tfinc do you mean https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1261 ? [17:42:01] or something different? [17:42:06] kenanwang: https://bugzilla.wikimedia.org/show_bug.cgi?id=54983 [17:42:08] just started [17:42:27] ok jdlrobson my next meeting ends at 1130 your time [17:42:37] kenanwang: we can do it now [17:43:03] ok. I'll send you a hangout invite [17:44:11] tfinc: i guess that's not really a 'rollup of all contributions' - just folks who make > 5 edits/month on mobile. afaik we don't have any stories for a rollup of all contributions [17:44:22] I'm calling you jdlrobson [17:44:27] tfinc want to create a story or let me know specifically what you're looking for and i can create one? [17:44:42] kenanwang: just send me the link [17:44:44] not seeing it [17:44:44] on google hangout [17:45:39] jdlrobson: calendar invite sent [17:45:52] awjr: i'm happy to create a card and get it prioritized with kenan [17:45:58] cool tfinc [17:46:32] but first im going to head to walgreens and get a wrist strap as i'm hurting too :( must be sympathy pains for YuviPanda [17:46:40] tfinc: heh [17:46:43] oh no! [17:46:52] tfinc: the 'wrist strap' i got sold turns out to be more of a thumb strap... [17:46:59] i recommend the ace deluxe wrist thing with a splint [17:47:18] it's kind of annoying to type with, but it works. i especially recommend sleeping with it on [17:47:23] til the pain goes away [17:47:36] http://www.acebrand.com/wps/portal/3M/en_US/AceBrand/Home/Products/Product-Catalog/?N=4304+3294605542+3294529207&rt=rud [17:47:57] hope walgreens has one [17:47:59] bbiab [17:48:40] i've seen and used cheaper varieties at walgreens, but the deluxe brace has some sort of antimicrobial magic to help keep it from getting super disgusting and stanky [17:55:40] awjr: nothing good at the one on the corner. i'm going to wait to find that one that you mentioned [17:55:43] brion: https://gerrit.wikimedia.org/r/#/c/86691/ should be ready to go now [17:55:50] whee [17:55:59] mixin uses the old way [17:56:06] tfinc: i've noticed the walgreens in downtown SF tend to not be well stocked on that kinda stuff [17:56:25] ok [17:56:32] tfinc but yeah, i've been using those braces for the last decade - they've outlasted, been more comfortable, and gotten way less disgusting than others i've used [17:57:40] (03PS2) 10Jdlrobson: WIP Story 1072: KeepGoing CTA [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87426 [17:57:47] (03PS3) 10Jdlrobson: Story 1072 (1/2): KeepGoing CTA [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87426 [17:57:58] jdlrobson: card updated. [17:57:58] (03PS4) 10MaxSem: Tweak markup of edits and uploads text [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87474 (owner: 10Jdlrobson) [17:58:01] thanks kenanwang [17:58:07] jdlrobson: let me know if it makes sense [17:58:34] ok got it [17:58:48] * jgonera going to the office [17:58:56] awesome [17:59:00] kenanwang: so no mention of actual edits just yet? i can check with DarTar / spage if we have that via Campaign extension [17:59:15] i'm not sure if all edits get logged with the query string [17:59:33] well the last line is "How many users go on from clicking on the CTA button the first time to successfully complete an edit." [18:00:00] what page are you guys referring to? [18:00:54] I'm creating subpages both for the tutorial a/b test and the CTA registration campaigns on Meta right now [18:01:20] awjr tfinc: should we call an emergency meeting over thank trolling? [18:01:43] * awjr facepalm [18:02:01] jdlrobson: not unless we have more then that one person [18:02:03] just block him [18:02:18] i dont see why this should be treated differently then editing [18:02:52] awjr: tfinc ok i've set my mental MobileFrontend advisory status from low threat to elevated threat [18:03:07] (03CR) 10jenkins-bot: [V: 04-1] Story 1072 (1/2): KeepGoing CTA [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87426 (owner: 10Jdlrobson) [18:03:57] is that like, light green to mustard yellow? [18:04:08] (03CR) 10Brion VIBBER: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86713 (owner: 10Jdlrobson) [18:04:24] awjr: basically like this> https://en.wikipedia.org/wiki/Homeland_Security_Advisory_System [18:05:13] awjr: hows this https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1288 ? [18:05:49] jdlrobson: you mean http://leftwingnutjob.net/wp-content/uploads/2011/12/Homeland-Security-bullshit-advisory-system.jpg? [18:06:28] looks straightforward tfinc - let kenanwang know so we can get it prioritized [18:06:53] awjr: :) [18:08:50] awjr, are we all set for the train - should I switch MF deployment from production to master? [18:10:44] (03PS2) 10Brion VIBBER: Hygiene: Fix commented out test in MFResourceLoaderModuleTest.php [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87267 (owner: 10Jdlrobson) [18:11:12] one sec MaxSem [18:13:22] (03CR) 10Brion VIBBER: [C: 032] "Eh, let's see what happens. :D" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87267 (owner: 10Jdlrobson) [18:14:41] awjr: tfinc got it [18:15:10] tfinc: awjr I just chatted with james and rob from the VE team about embedding Rob into our team [18:15:26] they're on board for a timeline starting next sprint [18:15:30] jdlrobson, I think https://gerrit.wikimedia.org/r/87474 is ready [18:15:40] giving us two sprints before india [18:16:02] kenanwang: for mobile VE? [18:16:06] hopefully we can look at a couple of pair programming sprints wrt VE on mobile [18:16:08] kenanwang: keep me informed about that. i'm really eager for this to happen a lot between teams [18:16:12] hello [18:16:23] specifically VE on minerva as a first experiment [18:16:42] that is exciting [18:16:43] awjr: let me know when robm starts showing up in meetings. i want to see how it goes [18:16:56] hi cortexA9 [18:17:04] greetings cortexA9 [18:17:05] hi MaxSem [18:17:07] awjr can we add him to our stand ups next week? [18:17:10] hi tfinc [18:17:14] kenanwang: if they want to start next sprint, robm should come to our planning meetings [18:17:24] and yes [18:17:27] our planning meetings [18:17:32] yes. he needs context on what were working before being thrown into the standup [18:17:48] kenanwang: sure; i'll add him as optional to the standups and obligatory for the review/kickoff meetings coming up [18:17:50] yeah we'll setup a meeting between him and I to go over the spring [18:17:55] sprint [18:18:05] kenanwang: can you loop me in on that so we can talk logistics, or should i do that with him separately? [18:18:15] and awjr can you setup a meeting with him to give him a quick overview of processes [18:18:19] kenanwang: invite me as optional so that so that i can listen in [18:18:29] yeah do you want to chat on the phone awjr? real quick? [18:18:34] tfinc: will do [18:18:34] yes kenanwang [18:18:39] 415.321.9935 [18:18:59] awjr: feel free invite me the process talk as well [18:19:06] you got it tfinc [18:19:40] one sec kenanwang [18:19:44] yep [18:21:05] kenanwang: left a msg [18:21:17] weird [18:21:21] it didn't go through? [18:21:24] what's your number? [18:22:38] hello YuviPanda [18:22:43] hi cortexA9 [18:24:28] YuviPanda: we can't do the feature on the app ? [18:24:41] YuviPanda: aboutthe wikipedians nearby [18:24:44] cortexA9: well, not right now [18:24:46] MaxSem awjr: https://gerrit.wikimedia.org/r/#/c/87184/ should be an easy merge [18:24:56] cortexA9: we're starting a rewrite of the app starting at the end of the month [18:25:04] YuviPanda: ok [18:25:15] cortexA9: we'll consider features like this once we get the basic featuers (reading, writing, offline) outta the way :) [18:26:13] (03CR) 10MaxSem: [C: 032] Hygiene: Remove history less file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87184 (owner: 10Jdlrobson) [18:26:36] jdlrobson, not to mention that the .less was registered as a script:P [18:26:50] (03Merged) 10jenkins-bot: Hygiene: Remove history less file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87184 (owner: 10Jdlrobson) [18:27:28] MaxSem: haha i didn't even notice that lolz [18:30:09] how do I reach Vibha on IRC? [18:30:17] DarTar: magic [18:30:17] so MaxSem RE the deployment train [18:30:26] DarTar use violetto as a medium [18:30:33] * DarTar starts the magic [18:30:37] she's our reliable bridge into the design world [18:30:42] yo violetto [18:30:43] my concern at this point is making sure that we're actually keeping master in a sane, deployable state [18:30:47] jdlrobson also ^^ [18:30:49] kaity hangs around in wikimedia-staff [18:31:07] we haven't been as careful about this previously [18:31:09] yo DarTar [18:31:43] what do you all think we can/should do to ensure that we're keeping master deployable so we can ride the train? [18:31:55] jdlrobson, MaxSem? ^ [18:31:58] mmm [18:32:15] awjr: more tests! [18:32:35] violetto: can I get access to the mobile design dropbox ? I'm looking for screenshots of the mobile registration CTAs (unless they are already on commons) [18:32:48] awjr: i'm sure there will be teething problems but i'm sure we will work them out through experience [18:32:51] i wouldn't worry too much [18:33:20] we just need to get into better habits of testing code before we merge or at least sanity checking the repository on a daily basis at the end of the day to check no new commits broke anything [18:33:22] jdlrobson, MaxSem are you guys confident about Just Doing It (™) then? [18:34:06] I'm not confident but I think we should try [18:34:10] lol [18:34:55] MaxSem: by when do we need to make changes and make the commitment to get on the train if we want to be on it for next week? [18:35:41] tweak make-deployment-branch before the cutoff on Monday [18:35:47] ie today [18:36:28] (03CR) 10Brion VIBBER: [C: 04-1] "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87433 (owner: 10Jdlrobson) [18:38:53] MaxSem, jdlrobson if you two are ok with Just Doing It, and michelle is ok with it, let's go for it - but let's wait til we get an OK from michelle [18:39:20] one nice thing about hte train is that the roll outs are staged, so we'll have time to cope with anything scary before it gets out to enwiki etc [18:52:47] tfinc: think you can poke leslie about the travel? should hopefully be able to get the booking done today [18:52:51] tfinc: leslie harms, not carr. [18:56:27] MaxSem: what's the latest time today you're willing to switch the deployment branch to master? [18:57:08] Sunday [18:57:31] MaxSem: what time do you think you'll be done working today? [18:57:42] dunno [18:57:48] ballpark it for me? [18:57:52] 4-6 PST [18:59:13] kthnx [19:03:48] jdlrobson, ResourceLoaderFileModule::readStyleFile: style file not found: "/data/project/apache/common-local/php-master/extensions/MobileFrontend/less/modules/notifications.less" [19:07:12] ^ that's what I discovered on beta [19:10:48] DarTar: did vbambs get back to you? [19:42:37] brion, you merged a config change on Friday?:P [19:42:42] (03CR) 10Brion VIBBER: [C: 04-1] "Commit summary says "Set username to -1 for anonymous users" but the patchset doesn't seem to do that; it seems to leave out the username " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87478 (owner: 10Jdlrobson) [19:42:52] config change? [19:43:14] https://gerrit.wikimedia.org/r/87485 [19:43:29] wtf why's that in config... [19:43:31] ah i see [19:43:38] well on the plus side it's harmless [19:43:41] want to undo it? :) [19:44:03] Reedy, ^^ [19:44:49] i'll stop reviewing for now :) [19:45:38] brion: license code! [19:45:38] :) [19:45:45] \o/ [19:45:54] * brion goes to add some i18n for the names [19:45:57] i think that's the main thing left [19:47:16] :) [19:51:57] (03PS1) 10Mgrover: QA#1286 Changed the assertion to from looking at the url to verifying that the mobileview link exists..tested on all environments and works correctly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87616 [19:52:43] chrismcmahon: can you review ^ [19:53:08] I changed the footer tests to look for something else instead of the toggle in the url [19:53:34] hi jcmish checking but that sounds reasonable on the face of it [19:53:41] danke [19:58:10] (03PS2) 10Cmcmahon: QA#1286 Changed the assertion to from looking at the url to verifying that the mobileview link exists..tested on all environments and works correctly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87616 (owner: 10Mgrover) [19:58:23] (03CR) 10Cmcmahon: [C: 032] "looks reasonable to me" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87616 (owner: 10Mgrover) [19:58:53] (03Merged) 10jenkins-bot: QA#1286 Changed the assertion to from looking at the url to verifying that the mobileview link exists..tested on all environments and works correctly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87616 (owner: 10Mgrover) [20:01:36] thanks again chrismcmahon [20:01:36] (03PS1) 10Kaldari: Removing bogus file from mobile.beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87618 [20:04:33] (03PS2) 10Kaldari: Removing bogus file from mobile.beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87618 [20:06:19] (03CR) 10MaxSem: [C: 032] Removing bogus file from mobile.beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87618 (owner: 10Kaldari) [20:06:45] (03Merged) 10jenkins-bot: Removing bogus file from mobile.beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87618 (owner: 10Kaldari) [20:09:29] (03PS9) 10Brion VIBBER: Extract and show license key [apps/android/commons] - 10https://gerrit.wikimedia.org/r/85925 [20:09:41] YuviNoPower: that's just a rebase/fix, i still have to commit the l10n [20:09:47] but feel free to look over it [20:09:52] brion: sweet [20:10:01] brion: i'll do that tomorrow. knee deep in varnish [20:10:05] ok [20:10:19] the last sentence sounded dangerous [20:11:01] get some fresh air :D [20:14:35] (03CR) 10Jdlrobson: [C: 031] "(1 comment)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/87271 (owner: 10Dr0ptp4kt) [20:18:14] (03CR) 10Dr0ptp4kt: "(1 comment)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/87271 (owner: 10Dr0ptp4kt) [20:19:05] jdlrobson, Exception thrown by mobile.watchlist.scripts: handlers.push is not a function [20:19:17] on the URL you sent [20:20:31] (03PS1) 10Jdlrobson: Revert "Regression: Hide the bullet points in the page list on nearby" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87622 [20:21:28] MaxSem: mm [20:21:37] what browser MaxSem [20:21:48] i wonder if this is the same issue that Kaldari raised [20:21:59] MaxSem: https://bugzilla.wikimedia.org/show_bug.cgi?id=53382 [20:22:11] FF/Linux [20:22:29] yup [20:22:40] and it co9mpletely kills all the JS on that page [20:23:04] even clicking on hamburger leads you to MobileMenu [20:23:34] (03PS3) 10Jdlrobson: Hygiene: Fix commented out test in MFResourceLoaderModuleTest.php [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87267 [20:23:50] (03CR) 10Jdlrobson: [C: 032] "cherry picked" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87267 (owner: 10Jdlrobson) [20:24:03] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Fix commented out test in MFResourceLoaderModuleTest.php [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87267 (owner: 10Jdlrobson) [20:24:49] (03PS4) 10Jdlrobson: Track anonymous clicks as well [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87478 [20:25:23] (03Abandoned) 10Jdlrobson: Hygiene: Merge all special stylesheets into a single one [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87263 (owner: 10Jdlrobson) [20:25:49] (03PS4) 10Jdlrobson: Make lazy loaded pages containing h1s collapse on h1s [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86966 [20:26:33] (03CR) 10jenkins-bot: [V: 04-1] Make lazy loaded pages containing h1s collapse on h1s [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86966 (owner: 10Jdlrobson) [20:27:03] (03PS5) 10Jdlrobson: Make lazy loaded pages containing h1s collapse on h1s [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86966 [20:29:09] mmm, with every minute our train looks more and more problematic [20:30:39] (03PS3) 10Jdlrobson: Fix position fixed handling is iOS <= 4_2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86881 [20:35:25] (03CR) 10JGonera: [C: 032] Revert "Regression: Hide the bullet points in the page list on nearby" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87622 (owner: 10Jdlrobson) [20:35:47] (03Merged) 10jenkins-bot: Revert "Regression: Hide the bullet points in the page list on nearby" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87622 (owner: 10Jdlrobson) [20:41:10] (03CR) 10MaxSem: [C: 031] Make lazy loaded pages containing h1s collapse on h1s [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86966 (owner: 10Jdlrobson) [20:42:08] (03PS2) 10Jdlrobson: Add global LESS variables shared with JavaScript to define resolutions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87433 [20:42:12] (03CR) 10jenkins-bot: [V: 04-1] Add global LESS variables shared with JavaScript to define resolutions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87433 (owner: 10Jdlrobson) [20:42:51] (03CR) 10Jdlrobson: "So I decided to split the tablet variable out into its own variable - this way the config variable looks consistent with the globals in mo" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87433 (owner: 10Jdlrobson) [20:43:33] (03PS3) 10Jdlrobson: Add global LESS variables shared with JavaScript to define resolutions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87433 [21:00:05] (03PS3) 10Jdlrobson: Beta: Open sections by default in tablet view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86713 [21:01:37] can someone review https://gerrit.wikimedia.org/r/#/c/87474 please? [21:02:01] brion: ready in R32 when you are [21:02:17] i can look in a few minutes MaxSem [21:02:30] ok be there in a sec tfinc [21:06:25] (03PS1) 10Jdlrobson: Remove main page special casing from alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87625 [21:06:26] (03PS1) 10Jdlrobson: Remove preferred languages from alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87626 [21:08:06] jdlrobson, do ^^^ need to be merged before the cutoff? [21:08:17] MaxSem: which one? [21:08:28] when is the cut off now any how? [21:09:28] in pirnciple, 1.22wmf21 will be branched on Monday, but you don't want to work on weekend, right? [21:15:18] (03PS2) 10Jdlrobson: Remove main page special casing from alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87625 [21:15:31] MaxSem: i just reviewed the software deployments page; it looks like the het deploy schedule has changed since i last looked. so; branch monday, deployed to test/test2/mediawiki/etc on Weds, deployed to all non-wp sites Sunday, then all wp sites the following Weds? [21:15:55] jdlrobson: let's shoot for a go/no-go by 4pm PDT today [21:16:33] awjr: MaxSem let's not merge any new features today - only bug fixes [21:16:54] (03PS2) 10Jdlrobson: Remove preferred languages from alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87626 [21:17:04] jdlrobson: that's fine with me, be sure to communicate that tho to jgonera_ and kaldari [21:17:05] (03PS3) 10Jdlrobson: Hygiene: Remove preferred languages from alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87626 [21:17:08] (mailing list!) [21:17:16] (03PS3) 10Jdlrobson: Remove main page special casing from alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87625 [21:19:53] but if there's a 2 days wait between branching and deployment, there's no need to worry about merging new features [21:20:13] as long as we backport bugfixes made during these 2 days [21:21:08] awjr: mailed out [21:21:20] MaxSem: explain the 2 day wait between branching and deployment? [21:21:35] see aw/jr ^^^ [21:21:36] so the branching happens monday but deployment wednesday? [21:22:02] correct jdlrobson [21:22:16] you can see the schedule here: https://wikitech.wikimedia.org/wiki/Software_deployments [21:23:28] ok [21:23:34] we should focus on bug fixes first then [21:23:35] :) [21:23:48] but adding features should be okay as long as they are in a complete like state [21:24:18] MaxSem: i just re-read greg-g's email from yesterday on the thread 'Getting ready for the deployment train' - he says Reedy branches on Thursday? [21:24:31] Reedy: when do you branch for the deployment train? [21:24:33] awjr: yessir [21:24:50] Thursday morning, before/during the 11am deploy window [21:24:53] pacific, of course [21:25:06] There's a Thursday deployment window? [21:25:14] o_O [21:25:17] for Core, yeah [21:25:19] greg-g: there's no Thursday window on https://wikitech.wikimedia.org/wiki/Software_deployments [21:25:41] thurs was yesterday yet there's no wmf21: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/core,branches [21:26:05] weiiiiirrrrdddddd [21:26:36] wmf20 is latest [21:26:40] see: https://www.mediawiki.org/wiki/MediaWiki_1.22/Roadmap#Schedule_for_the_deployments [21:26:53] but, the diff between the "ongoing" table and the "week of Oct 7th" is weeeriiird [21:26:56] -r [21:27:18] * greg-g fixes [21:27:33] wat? [21:27:35] {{#invoke:Deployment_schedule|row [21:27:35] |when={{#invoke:Deployment_schedule|dateOf|Thu}} 11:00 PDT [21:27:35] |who=Sam / Greg [21:27:35] |what=MediaWiki deploy window, currently following the [[mw:MediaWiki 1.22/Roadmap#Schedule for the deployments|1.22 schedule)]] [21:27:37] so confused. [21:27:39] * group2 (all Wikipedias) gets old wmf [21:27:41] * group0 (test/test2/testwikidata/loginwiki/mediawiki/) gets new wmf [21:27:44] }}| [21:27:46] that says "Thu" [21:27:57] * awjr slaps wikitext [21:28:01] where's mwalker?! [21:28:36] awjr: also, it's just [[Deployments]] btw [21:28:41] looks like he's in -dev [21:28:42] Software_Deployments redirects [21:29:15] ah thanks greg-g, i've been using that bookmark since the dawn of that page [21:30:22] :) [21:30:30] * greg-g moves all the pages [21:31:55] (03CR) 10Jdlrobson: [C: 031] Tweak markup of edits and uploads text [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87474 (owner: 10Jdlrobson) [21:32:08] (03PS1) 10JGonera: Regression: Fix section toggling when URL contains a hash [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87629 [21:32:22] MaxSem: i poked siebrand [21:32:25] about that patch [21:32:31] greg-g: ok, so we've missed the current train - next train leaves on october 10? [21:32:36] maybe awjr can merge https://gerrit.wikimedia.org/r/#/c/87474? [21:32:41] awjr: yessir [21:32:52] so… jdlrobson, MaxSem that changes things a bit [21:33:08] :/ sorry [21:33:21] so we have till thursday? [21:33:22] * MaxSem merges a random bug [21:33:28] lol [21:33:30] yes jdlrobson [21:33:33] stress over [21:33:33] good work, guys [21:33:35] :P [21:33:35] i'll mail out [21:33:38] thanks jdlrobson [21:33:55] jcmish: did you catch all of that ^? [21:34:21] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87474 (owner: 10Jdlrobson) [21:34:27] bd808 fixed the page with a null edit, btw [21:34:45] ok, thanks for clearing that up greg-g, im glad i reread your email :p [21:34:51] :) [21:35:05] (03CR) 10MaxSem: [C: 032] Hygiene: Remove main page special casing from alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87625 (owner: 10Jdlrobson) [21:35:28] (03Merged) 10jenkins-bot: Hygiene: Remove main page special casing from alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87625 (owner: 10Jdlrobson) [21:35:39] (03CR) 10MaxSem: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87474 (owner: 10Jdlrobson) [21:36:46] (03PS4) 10JGonera: Remove .no-margins body class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87286 [21:36:59] MaxSem: you made the special casing disappear :) [21:38:27] (03CR) 10Jdlrobson: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87474 (owner: 10Jdlrobson) [21:38:37] MaxSem: i think i see what's happening but the function is very misleading now [21:40:21] jdlrobson, then remove your -1 [21:40:28] (03CR) 10Jdlrobson: [C: 031] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87629 (owner: 10JGonera) [21:40:33] see the source, it's capped at LIMIT+1 [21:40:43] MaxSem: nope. Name of function needs to be changed or a comment needs to be added [21:40:47] this is error prone [21:41:37] yer suggestion? [21:43:33] MaxSem: either $this->userInfo->countRecentUploads( $fromDate, 500 ); or this->userInfo->countCappedRecentUploads [21:43:35] (03PS1) 10JGonera: Hygiene: Remove unused .show class from #content_wrapper [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87630 [21:43:48] the name suggests you count everything [21:44:03] a comment should be enough [21:44:25] MaxSem: "Returns a count of the most recent edits since a given timestamp" <- this comment is not true [21:44:38] ok [21:44:46] MaxSem: since it confused siebrand an external team member i really think this hints at a bad code smell and we should be more explicit [21:44:47] (03PS2) 10JGonera: Regression: Fix section toggling when URL contains a hash [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87629 [21:45:07] jdlrobson: was there some patchset you wanted me to look at? i accidentally closed my window and lost my backscroll [21:45:21] MaxSem: i think you had a patchset you wanted me to look at too? [21:45:54] greg-g: is there any notification when the deployment happened if you're on the deployment train? [21:45:57] that one that got -1d [21:45:58] :P [21:46:07] heh [21:46:14] or do we just check back after the time on the wiki? [21:46:22] awjr: any idea why this is failing now? https://gerrit.wikimedia.org/r/#/c/87267/ [21:46:27] (03CR) 10JGonera: [C: 032] Regression: Fix section toggling when URL contains a hash [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87629 (owner: 10JGonera) [21:46:29] * awjr looks [21:46:39] it's failing locally now as well which is weird [21:47:29] awjr: ignore [21:47:33] i know what's going on [21:47:43] k [21:48:01] (03PS5) 10MaxSem: Tweak markup of edits and uploads text [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87474 (owner: 10Jdlrobson) [21:48:11] jdlrobson, ^^ [21:48:14] (03Merged) 10jenkins-bot: Regression: Fix section toggling when URL contains a hash [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87629 (owner: 10JGonera) [21:48:18] (03CR) 10Jdlrobson: [C: 04-2] "This is dependant on I02ae1476c1ce9cdf877e2ba24c17db6c26800011" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87267 (owner: 10Jdlrobson) [21:48:25] MaxSem: looking :) [21:49:34] MaxSem: I still worry this is error prone - we render the message 'mobile-frontend-profile-contributions' which assumes on the value 500 but the value 500 is set by MobileUserInfo.php - this seems bad no? [21:49:45] what if I update MobileUserInfo to cap to 600 how I know to update the message? [21:50:15] I'll just pass the limit [21:50:41] so given that we won't be on the train til next thursday, should we plan to deploy like we normally do this coming tuesday? [21:50:53] jcmish, MaxSem, jdlrobson, jgonera_? ^ [21:51:08] no [21:51:13] (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove unused .show class from #content_wrapper [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87630 (owner: 10JGonera) [21:51:13] get used to it;) [21:51:38] (03Merged) 10jenkins-bot: Hygiene: Remove unused .show class from #content_wrapper [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87630 (owner: 10JGonera) [21:51:50] heh [21:51:54] that would mean that features will not make it to enwiki until 1.5 weeks later than normal [21:53:12] awjr: i'd say that's kenan's clal [21:53:13] *call [21:53:15] I think that has to be a call from kenan awjr [21:53:26] yeah, agreed [21:53:44] :) [21:53:51] this makes no sense: 1.5 weeks from now or the same time from next week [21:54:02] 1.5 weeks from tueday [21:54:04] *tuesday [21:54:04] (03CR) 10Kaldari: [C: 04-1] "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87286 (owner: 10JGonera) [21:54:21] (03CR) 10Jdlrobson: [C: 04-1] "jdlrobson: MaxSem: I still worry this is error prone - we render the message 'mobile-frontend-profile-contributions' which assumes on the " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87474 (owner: 10Jdlrobson) [21:57:39] jgonera_: In the commit summary for https://gerrit.wikimedia.org/r/#/c/87286/ it says "add .styled and .margins classes to #content", but I don't see this in the change. [21:58:05] MaxSem: can i +2 https://gerrit.wikimedia.org/r/#/c/87252/2 ? [21:58:38] I wanted a sanity check with yurik first [21:59:43] kaldari, forgot to update the commit message, just a sec [22:00:30] (03PS5) 10JGonera: Remove .no-margins body class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87286 [22:00:55] jgonera_: Also had a comment in the code, if you want to go ahead and fix that. [22:01:24] jgonera: Also had a comment in the code, if you want to go ahead and fix that. [22:02:14] kaldari, thanks, this is probably rebase issue, fixing [22:02:46] (03CR) 10Jdlrobson: [C: 031] "Yurik needs to sanity check" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87252 (owner: 10MaxSem) [22:03:16] Yeah, I think 90% of our pre-deployment bugs have been rebasing issues due to all the refactoring :P [22:03:57] kaldari, I blame LESS [22:11:09] (03PS6) 10JGonera: Remove .no-margins body class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87286 [22:11:59] (03PS1) 10JGonera: Fix file name in validatehtml.sh [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87634 [22:14:49] kaldari, I get Uncaught Error: Unknown dependency: ext.echo.base when I open notifications overlay [22:16:06] kaldari, now I updated Echo to the newest master and I get even more errors (PHP errors) and notifications doesn't work at all [22:16:07] (03PS6) 10MaxSem: Tweak markup of edits and uploads text [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87474 (owner: 10Jdlrobson) [22:16:16] Notice: Undefined property: stdClass::$event_page_id in /home/jgonera/www/extensions/Echo/model/Event.php on line 211 [22:16:16] Notice: Undefined property: stdClass::$event_page_id in /home/jgonera/www/extensions/Echo/model/Event.php on line 219 [22:16:20] A database query error has occurred. This may indicate a bug in the software. [22:16:39] jdlrobson, need someone to help describing $5, my brain is melting:P [22:16:46] oh, that's not the overlay actually, it's Special:Notifications [22:17:23] kaldari, even weirder, the overlay opens, the spinner shows and later it redirects me to Special:Notifications... [22:17:55] ack [22:26:47] jgonera: it's working fine for me. I wonder if you need to run maintanence/update.php perhaps [22:27:13] what does the database query error say? [22:27:52] kaldari, it works now after running update [22:28:03] yay :) [22:28:10] anyway, there's some weird jumping in the overlay as if part of the CSS was loaded later [22:28:23] also, why is the left margin of all items so huge? [22:29:10] You should get a spinner for a second and then the notifications loading in already styled once the AJAX request completes [22:29:16] CSS inspector in Chrome shows that some CSS rules are not being used [22:29:39] kaldari, that's not exactly what happens, I get the spinner, the notifications, then the styling slightly changes [22:29:52] that's only after the first time I open the overlay after a page load [22:30:50] hmm, I'll take a look [22:30:57] jgonera, $wgShowExceptionDetails = true; $wgShowSQLErrors = true; [22:31:16] MaxSem, ? [22:31:30] that doesn't seem to help in CSS debugging ;) [22:32:13] jgonera, but it helps with SQL errors;) [22:32:17] jgonera: a lot of the styles are from Echo, since Jon wanted me to reuse as much as possible. I imagine the overrides in MobileFrontend are loading after the Echo styles. [22:42:36] (03PS9) 10Jdlrobson: Hygiene: Allow MFResourceLoaderModule to handle templates and files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86290 [22:42:40] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Allow MFResourceLoaderModule to handle templates and files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86290 (owner: 10Jdlrobson) [22:43:40] (03CR) 10JGonera: [C: 04-1] "Just wanted to say that I liked the idea of showing most often used languages first. Not sure if this should be kept or started from scrat" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87626 (owner: 10Jdlrobson) [22:43:51] (03PS10) 10Jdlrobson: Hygiene: Allow MFResourceLoaderModule to handle templates and files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86290 [22:45:36] (03CR) 10JGonera: [C: 032] Beta: Open sections by default in tablet view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86713 (owner: 10Jdlrobson) [22:47:17] (03CR) 10Jdlrobson: [C: 032] Fix file name in validatehtml.sh [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87634 (owner: 10JGonera) [22:47:43] (03CR) 10Dr0ptp4kt: "(2 comments)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 (owner: 10Dr0ptp4kt) [22:47:45] (03Merged) 10jenkins-bot: Fix file name in validatehtml.sh [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87634 (owner: 10JGonera) [22:48:57] (03CR) 10JGonera: [C: 04-1] "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87433 (owner: 10Jdlrobson) [22:49:34] (03PS4) 10Jdlrobson: Add global LESS variables shared with JavaScript to define resolutions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87433 [22:50:05] (03CR) 10Jdlrobson: [C: 032] Add global LESS variables shared with JavaScript to define resolutions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87433 (owner: 10Jdlrobson) [22:50:31] (03Merged) 10jenkins-bot: Add global LESS variables shared with JavaScript to define resolutions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87433 (owner: 10Jdlrobson) [22:50:49] (03CR) 10Dr0ptp4kt: "(1 comment)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 (owner: 10Dr0ptp4kt) [22:51:57] (03CR) 10JGonera: [C: 032] Make lazy loaded pages containing h1s collapse on h1s [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86966 (owner: 10Jdlrobson) [22:52:28] (03Merged) 10jenkins-bot: Make lazy loaded pages containing h1s collapse on h1s [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86966 (owner: 10Jdlrobson) [22:58:13] (03CR) 10Kaldari: [C: 032] Remove .no-margins body class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87286 (owner: 10JGonera) [22:58:14] (03PS7) 10MaxSem: Tweak markup of edits and uploads text [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87474 (owner: 10Jdlrobson) [22:58:16] (03CR) 10jenkins-bot: [V: 04-1] Remove .no-margins body class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87286 (owner: 10JGonera) [22:58:19] jdlrobson, how about ^^^? :) [22:58:32] MaxSem: i'm looking at it now [22:58:43] it was broken but i see you reuploaded it :) [22:58:50] (03PS7) 10Kaldari: Remove .no-margins body class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87286 (owner: 10JGonera) [22:58:55] * jdlrobson switches to ps7 [23:00:22] jdlrobson: Are you find with me +2ing https://gerrit.wikimedia.org/r/#/c/87286/ (It doesn't have any tests, as you requested. Wasn't sure if that was for this change or for future improvement.) [23:00:28] find=fine [23:01:52] (03CR) 10JGonera: [C: 032] Hygiene: Allow MFResourceLoaderModule to handle templates and files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86290 (owner: 10Jdlrobson) [23:02:00] kaldari: let me give it a vigorous test on all special pages first :) [23:02:09] or if you've done that go for it [23:02:15] just make sure all the special pages look right :) [23:02:18] (03Merged) 10jenkins-bot: Hygiene: Allow MFResourceLoaderModule to handle templates and files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86290 (owner: 10Jdlrobson) [23:02:27] go ahead, I've tested it on a few, but not all special pages [23:02:37] ok feel free to +1 and i'll do the rest [23:02:44] big change so should give lots of attention to it :) [23:03:01] I'm getting JS errors in Firefox, but it isn't related to that change. [23:03:31] MaxSem: so i tested your patch and it doesn't work 1,000,000 edits and no uploads :) lemme take a look [23:03:31] (03CR) 10Kaldari: [C: 031] Remove .no-margins body class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87286 (owner: 10JGonera) [23:06:34] (03CR) 10JGonera: [C: 032] Fix position fixed handling is iOS <= 4_2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86881 (owner: 10Jdlrobson) [23:06:37] (03CR) 10jenkins-bot: [V: 04-1] Fix position fixed handling is iOS <= 4_2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86881 (owner: 10Jdlrobson) [23:08:30] kaldari: on what pages? [23:08:41] watchlist pages [23:09:00] it's that weird jQuery error again [23:09:24] jdlrobson, the count functions should never return more than LIMIT+1 [23:12:54] kaldari, what happened to typography.less changes in https://gerrit.wikimedia.org/r/#/c/87286/ ? [23:14:19] (03PS8) 10JGonera: Remove .no-margins body class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87286 [23:14:56] jgonera: I seem to have lost the change when I rebased it, sorry [23:15:07] kaldari, no worries, rebased again [23:16:26] jgonera: at the time I was in a hurry to merge it before 4 :P [23:16:43] we have more time from what I heard [23:16:46] MaxSem: i'm totally confused now [23:17:06] (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87478 (owner: 10Jdlrobson) [23:17:23] (03CR) 10Jdlrobson: [C: 04-1] "I'm totally confused but this doesn't seem to work - try setting LIMIT to 2 - "44 edits and no uploads in the last 30 days."" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87474 (owner: 10Jdlrobson) [23:19:00] jdlrobson, listen to what I'm saying. the functions never return more than limit + 1. if you're making them return more artificially, things get confused [23:19:22] but this is something that will never happen IRL [23:20:31] MaxSem: all i can say is this patch looks broken and confusing to me! Let's look at it again monday as it's frying my brain right now [23:21:00] jdlrobson, just remove your -1 if you don't understand and let a backend dev review [23:22:50] (03PS5) 10Jdlrobson: Track anonymous clicks as well [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87478 [23:23:49] (03CR) 10Jdlrobson: [C: 032] Track anonymous clicks as well [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87478 (owner: 10Jdlrobson) [23:24:16] (03Merged) 10jenkins-bot: Track anonymous clicks as well [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87478 (owner: 10Jdlrobson) [23:28:05] (03PS4) 10Jdlrobson: Fix position fixed handling is iOS <= 4_2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86881 [23:28:24] (03CR) 10Jdlrobson: [C: 032] Fix position fixed handling is iOS <= 4_2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86881 (owner: 10Jdlrobson) [23:29:27] kaldari: 1140 is done right? [23:29:31] (03Merged) 10jenkins-bot: Fix position fixed handling is iOS <= 4_2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86881 (owner: 10Jdlrobson) [23:29:40] (03PS4) 10Jdlrobson: Beta: Open sections by default in tablet view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86713 [23:29:47] (03CR) 10Jdlrobson: [C: 032] "rebased" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86713 (owner: 10Jdlrobson) [23:30:14] yes [23:30:17] (03PS4) 10Jdlrobson: Hygiene: Fix commented out test in MFResourceLoaderModuleTest.php [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87267 [23:30:32] (03CR) 10Jdlrobson: [C: 032] "Dependency now merged. PHPUnit tests will now pass :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87267 (owner: 10Jdlrobson) [23:30:42] (03Merged) 10jenkins-bot: Beta: Open sections by default in tablet view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86713 (owner: 10Jdlrobson) [23:31:02] (03PS9) 10Jdlrobson: Remove .no-margins body class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87286 (owner: 10JGonera) [23:31:20] (03CR) 10JGonera: [C: 04-1] "(7 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87426 (owner: 10Jdlrobson) [23:31:37] (03Merged) 10jenkins-bot: Hygiene: Fix commented out test in MFResourceLoaderModuleTest.php [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87267 (owner: 10Jdlrobson) [23:31:45] moved it [23:37:17] (03CR) 10Jdlrobson: [C: 032] "Fingers crossed..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87286 (owner: 10JGonera) [23:37:42] (03Merged) 10jenkins-bot: Remove .no-margins body class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87286 (owner: 10JGonera) [23:38:03] jgonera: https://www.mediawiki.org/wiki/Beta_Features/New_Features [23:39:30] (03Abandoned) 10Jdlrobson: Hygiene: Remove preferred languages from alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87626 (owner: 10Jdlrobson) [23:41:00] kaity: http://parks.sonomacounty.ca.gov/Get_Outdoors/Parks/Larson_Park.aspx [23:41:18] oh wait that one has no camping [23:41:55] where you trying to go jdl? [23:41:57] e [23:41:57] r [23:41:58] jdlrobson: [23:42:30] camping in sonoma town near vineyards [23:42:38] but doesn't seem to be any :( [23:43:03] are you open to napa instead? [23:43:19] there's a great campground i've stayed at in a state park in napa... [23:43:21] one se [23:43:22] c [23:43:47] http://napavalleystateparks.org/campground-map/ [23:43:56] bothe-napa valley state park [23:44:32] so MaxSem .. what i was trying to say with that profile patch is this [23:44:36] the LIMIT is ignored in your sql query [23:44:42] it produces the query SELECT COUNT(*) FROM (SELECT rc_timestamp FROM `recentchanges` WHERE rc_user_text = 'Jdlrobson' AND (rc_timestamp > '20130904234505') ) t [23:45:29] and surely it should be SELECT COUNT(*) FROM (SELECT rc_timestamp FROM `recentchanges` WHERE rc_user_text = 'Jdlrobson' AND (rc_timestamp > '20130904234505') LIMIT 500 ) t no? [23:45:46] FUCK [23:45:50] awjr: napa could work [23:46:00] when it got broken? [23:46:08] MaxSem: not sure but this was what i was complaining about [23:46:23] my backend knowledge might not be brilliant but i can test things to see if they work as expected :) [23:46:48] (03PS8) 10MaxSem: Tweak markup of edits and uploads text [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87474 (owner: 10Jdlrobson) [23:46:52] (03CR) 10jenkins-bot: [V: 04-1] Tweak markup of edits and uploads text [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87474 (owner: 10Jdlrobson) [23:47:05] does selectSQLText support limits? [23:47:23] most camping i know of in sanoma is not near vineyards, jdlrobson :( [23:47:29] awjr: :( [23:47:49] it does, see ^^^ :( [23:47:54] awjr: there is glamping there for vibha! [23:47:57] ^ kaity [23:48:02] no jcmish, but the answer is "not really" [23:48:06] jdlrobson: in other news though, i just sent james alexander apache rewrite rules for mingle so we should have an automatic redirect from old mingle to new mingle [23:48:16] awjr: yeyyy been bugging me :) [23:48:20] keep landing on old mingle by accident [23:48:24] he might not be able to get to it til monday [23:48:36] but now he knows what to do [23:48:51] i suggested: [23:48:52] RewriteEngine on [23:48:52] RewriteRule ^/projects/mobile/(.*)$ https://wikimedia.mingle.thoughtworks.com/projects/mobile/$1 [R=301,L] [23:50:15] jdlrobson: oct 25-27 [23:50:30] mark calendars! [23:51:10] (03PS27) 10Dr0ptp4kt: Hide charge-inducing features. Intercept link interstitials sooner. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 [23:53:28] (03PS28) 10Dr0ptp4kt: Hide charge-inducing features. Intercept link interstitials sooner. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 [23:54:51] (03PS29) 10Dr0ptp4kt: Hide charge-inducing features. Intercept link interstitials sooner. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 [23:58:54] (03PS1) 10Jdlrobson: Standardise on MEDIAWIKI_URL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87640