[00:06:04] (03Abandoned) 10Siebrand: Localisation updates from http://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87937 (owner: 10L10n-bot) [05:09:05] (03Abandoned) 10Kaldari: WIP: Initial support for webfonts [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86340 (owner: 10Amire80) [09:57:22] MaxSem: https://gerrit.wikimedia.org/r/#/c/86147/ ? [09:58:34] lgtm [10:00:17] MaxSem: +2 [10:00:35] you're going to deploy it? [10:01:55] nah, will piggyback on someone else [10:02:29] its more of a maintenance thing, so no rush [10:22:15] MaxSem: sorry, could you take a look at that thing again - https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FZeroRatedMobileAccess/d8fe2131f8d1f75b0cff4904fa9cdd08204925f5/ZeroRatedMobileAccess.namespaces.php [10:22:24] that seems like a bug [10:23:03] MaxSem: ref - https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FZeroRatedMobileAccess/d8fe2131f8d1f75b0cff4904fa9cdd08204925f5/ZeroRatedMobileAccess.php#L31 [10:25:58] yurik_, ? [10:26:20] MaxSem: not sure if the namespace will get declared as part of META or everywhere [10:26:42] and if removing it with that patch might disable it [10:27:07] try it yourself? [10:27:35] MaxSem: i did - it works fine locally, just not sure about global settings [10:27:58] global == in prod [10:28:00] then it should work globally too [11:54:07] yurik, can you take a look at the approach in https://gerrit.wikimedia.org/r/87252 - is it sane? [12:27:53] (03PS1) 10Ebrahim: Add convertNumber to localize last-modified digits [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88062 [12:30:43] (03PS2) 10Ebrahim: Add convertNumber to localize last-modified digits [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88062 [12:50:20] (03PS3) 10Ebrahim: Add convertNumber to localize last-modified digits [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88062 [13:21:52] MaxSem: have been looking at that patch [13:22:00] a bit confused how it actuall yworked [13:22:19] 'wml' !== 'WML' in param [13:23:11] or was it part of the MobileContext::parseContentFormat() normalization [13:25:50] (03CR) 10Yurik: [C: 04-1] "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87252 (owner: 10MaxSem) [13:26:04] thanks!:) [13:26:14] np [13:26:15] :) [13:27:48] (03CR) 10MaxSem: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87252 (owner: 10MaxSem) [13:27:55] yurik_, ^^ [13:29:19] * MaxSem goes away [13:29:57] MaxSem: thx, you are right, what about second comment? [13:30:26] (03CR) 10Yurik: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87252 (owner: 10MaxSem) [14:43:02] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Whee campaigns branch! \o/" [apps/android/commons] (campaigns) - 10https://gerrit.wikimedia.org/r/85654 (owner: 10Yuvipanda) [14:52:26] (03CR) 10Reza: [C: 031] "it is ok" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88062 (owner: 10Ebrahim) [15:02:41] (03CR) 10MaxSem: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87252 (owner: 10MaxSem) [15:02:48] yurik, ^ [15:06:41] (03CR) 10MaxSem: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87474 (owner: 10Jdlrobson) [15:13:30] (03PS1) 10MaxSem: Remove unused function, add annotations [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88117 [15:26:03] (03CR) 10Siebrand: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87474 (owner: 10Jdlrobson) [16:21:40] (03PS9) 10MaxSem: Tweak markup of edits and uploads text [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87474 (owner: 10Jdlrobson) [16:32:02] (03CR) 10Siebrand: [C: 031] "+1!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87474 (owner: 10Jdlrobson) [16:51:19] jdlrobson: jgonera i have friends in SF over near union station and they're asking if there are any recommendations for the best pancakes? [16:58:09] jcmish, no idea... [16:59:23] ;( [17:09:42] jdlrobson, "Dear Development Friends," that's sweet [17:09:49] jgonera: :) [17:12:48] so kenanwang MaxSem what is your preference on deploying everything vs deploying just the event logging for last modified [17:12:58] any preferences ? cc kaldari [17:13:18] I'm on board for just deploying the event logging [17:13:29] kaldari: https://gerrit.wikimedia.org/r/#/c/88062/3 [17:14:13] MaxSem: specifically it is https://gerrit.wikimedia.org/r/86754 [17:14:45] jdlrobson: can you walk we through validating it? [17:14:50] so jcmish in terms of testing last modified [17:14:52] yes :) [17:15:14] jdlrobson, well. for me, it's easier is to cherry-pick just one change - because it's less likely to need more updates when we fix bugs discovered during testing [17:15:25] the question is what's better for us as a team? [17:15:50] mhurd: i'm joining the hangout from home [17:15:54] MaxSem: i have no preference either way - stuff will get deployed to test wiki on thursday yes and enwiki by monday? [17:16:10] if I understood it right [17:16:26] so from my perspective it's how much of an inconvenience it is to you [17:16:40] it sounds like from a product pov kenanwang doesn't mind waiting for everything else [17:16:50] from my pov i always like pushing our stuff out asap [17:17:06] but i think the answer to this should be from a MaxSem pov since you have to do it :) [17:17:15] or kaldari if kaldari is likely to do it [17:17:26] agreed [17:17:29] ok, so my call is to just cherry-pick - if we jump on the train, better start getting used to it sooner rather than later [17:17:32] maybe you want to do one last deployment for old times sake ;-) [17:17:41] with tearful eyes [17:17:53] "i'm going to miss you scap" [17:18:52] (03CR) 10Kaldari: [C: 032] Add convertNumber to localize last-modified digits [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88062 (owner: 10Ebrahim) [17:19:21] (03Merged) 10jenkins-bot: Add convertNumber to localize last-modified digits [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88062 (owner: 10Ebrahim) [17:21:56] tfinc: going to add a couple backlog items [17:22:09] mhurd: thanks. you should too YuviPanda if you need them [17:22:24] sure! [17:22:46] jcmish: MaxSem wait a minute.. [17:22:55] it looks like we have page history logging on wikipedia already [17:23:03] oh? [17:23:04] unless i'm missing something [17:23:14] MaxSem: any chance that already got deployed? [17:23:26] it was merged last tuesday [17:23:32] so quite possibly it already got deployed kenanwang [17:23:39] in which case no need for a deployment at all [17:23:53] huh, brion merged the config change on Friday [17:24:18] so if someone deployed it rather than reverting... [17:24:39] are no MF changes needed? [17:24:41] nope [17:24:54] looks good MaxSem - i'm seeing 184 clicks on last modified in beta [17:25:02] ok [17:25:06] no deployment? [17:25:40] alright then [17:26:25] I'm going to move it into accepted [17:26:44] kenanwang: actually it is only logged for logged in users [17:26:48] which i guess is not what you want [17:26:53] ahh [17:26:59] no [17:27:08] that did seem a little low [17:27:10] kenanwang: MaxSem in which case we need https://gerrit.wikimedia.org/r/#/c/87478/ [17:27:21] and it's dependency [17:27:30] the dependency was merged but hopefully not deployed?! [17:28:38] MaxSem: ^ ? [17:28:47] what dependency? [17:28:57] the one in the commit MaxSem [17:29:05] actually the dependency should be harmless [17:29:09] so it doesn't matter if it was [17:33:25] MaxSem: so yeh it sounds like we need that commit above deployed [17:33:34] could even do it today if we can find someone deploying? [17:35:58] (03CR) 10Jdlrobson: [C: 032] Remove unused function, add annotations [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88117 (owner: 10MaxSem) [17:36:12] (03PS2) 10Jdlrobson: Remove unused function, add annotations [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88117 (owner: 10MaxSem) [17:36:26] (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove unused function, add annotations [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88117 (owner: 10MaxSem) [17:36:49] kaldari: is it possible to test #1140 Add mobile to Echo on beta labs? [17:37:11] MaxSem: kenanwang so.. decision? i'd like to work on some code without distractions :-) [17:37:14] (03Merged) 10jenkins-bot: Hygiene: Remove unused function, add annotations [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88117 (owner: 10MaxSem) [17:37:45] jcmich: how do we normally test eventLogging? [17:37:59] so let's cherry pick that commit [17:38:01] if El already wroks, I'm against deploying [17:38:14] MaxSem: it doesn't though - it doesn't log anonymous clicks which si what kenanwang wants [17:38:21] typically I have to wait until it hits en.m and then I have someone check for me [17:38:26] I'm still waiting for access :D [17:38:26] ah [17:38:32] https://gerrit.wikimedia.org/r/#/c/87478/ is needed to do that [17:38:32] so let's cherrypick [17:38:36] yes [17:38:39] to check myself kaldari [17:38:43] ok and can we cherry pick today to get it out of the way? [17:38:53] lets cherry pick the commit and the desk will go out with the deployment train [17:39:27] (03CR) 10Jdlrobson: [C: 032] Story 1164: Promote animations to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87641 (owner: 10JGonera) [17:39:50] (03Merged) 10jenkins-bot: Story 1164: Promote animations to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87641 (owner: 10JGonera) [17:40:25] jcmich: that doesn't sound ideal. Regardless, I imagine you'll need to test 1140 the same way, wait and see if data starts showing up in the Echo event logging. [17:40:41] that was my guess kaldari [17:40:46] but I always ask [17:41:58] MaxSem: is there any way to tell when https://gerrit.wikimedia.org/r/#/c/87031/ has been merged? [17:42:17] i'm worried that MediaWiki:Mobile.js hack will skew the results when it gets deployed if i don't kill the hack at deployment time [17:43:24] kenanwang: any objections with removing the hack tomorrow considering we will then have almost a week of data from it ? https://en.m.wikipedia.org/wiki/MediaWiki:Mobile.js [17:57:18] YuviPanda: you about? wanted to check on the git/gerrit bot status [17:57:24] brion: hey [17:57:25] i can merge some stuff manually if need be though :D [17:57:36] brion: merge manually for now, I'll see if I can start it back up [17:57:43] spiff [17:59:56] brion: also, all my travel arrangements seem to be set now. will be there in 3 weeks [18:00:03] awesome [18:00:12] we'll do some fun dev spikes while you're in town :D [18:00:42] yeah [18:00:43] :) [18:00:56] YuviPanda: are you going to do the language summit stuff in november? if so i'll plan for a big iOS sprint for that week if you'll be busy :D [18:01:04] brion: I am! [18:01:09] spiff [18:01:14] brion: provided it doesn't clash with my Software Engineering test... [18:01:17] heh [18:01:22] brion: btw, thoughts on making the app use SPDY from the get go? [18:01:50] * brion hmms [18:02:04] it'd be a nice thing to try out, should have some advantages on mobile networks [18:02:13] but if it's complicated i don't want it to slow us down [18:02:17] brion: I just added SPDY support to the labsproxy on labs [18:02:23] \o/ [18:02:30] brion: so if you go to, for example, pinklake.wmflabs.org, it'll serve over SPDY [18:02:42] i'd say plan a spike and if it's hard, drop it for later [18:02:49] if it's just a drop-in to our libraries, then sweet :D [18:03:03] brion: on the Android side, I *do* want to use OKHTTP, at which point it is just a flag [18:03:15] brion: not sure about iOS [18:03:21] brion: plus there's always transparent fallback to https [18:03:30] yep [18:03:32] spiff :D [18:03:39] brion: mostly, we won't have to do anything, really. Just a matter of getting ops to prioritize that a bit more [18:04:10] the *actual* work is all done and puppetized, they just need a solid reason to say 'okay, let us do this! [18:04:11] ' [18:04:15] not in the short term [18:17:31] (03PS2) 10Jdlrobson: Standardise on MEDIAWIKI_URL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87640 [18:17:37] jcmish: jgonera https://gerrit.wikimedia.org/r/#/c/87640/ any issues with this? [18:18:03] jdlrobson: give me a sec to look [18:18:32] (03PS1) 10Jdlrobson: Allow editors to know that undo is unsupported [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88152 [18:20:04] jdlrobson, will check when I get to the office because I need to leave right now to make it for a meeting ;) [18:23:38] ok easiest thing for now is if i just rebase the whole stack in this branch, then gerrit them in and approve them and make notes for further fixes in there [18:23:45] it'll spam channel probably though :) [18:24:32] ah crap, i gotta reinstall git-review [18:26:35] i might be about to spam the channel with apps-ios-commons updates. if so, sorry [18:29:47] (03PS5) 10Kaldari: Preparing the LastModified code for Mingle cards 1262 and 1258 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 [18:30:00] * tfinc joins the wrist strap club of awjr_away and YuviPanda [18:30:14] why does git complain about merging two changes on adjacent lines? [18:30:17] tfinc: so the doc specifically told me to not put pressure on it, so wrist straps are out [18:30:18] for now [18:30:27] YuviPanda: what was his reason ? [18:30:59] tfinc: apparently I'm 'early stage Carpel Tunnel Syndrome', and hence different from the regular 'pain in wrist', which is usually tendonitis [18:31:11] tfinc: i'm on a heavy dose of painkillers but. [18:33:53] YuviPanda, tfinc: This is what you want: http://www.bowlerx.com/Robbys-Revs-II-Bowling-Wrist-Support-RBREVS2.htm?gclid=CKv41JyuhboCFWQ6QgodaloAkg [18:46:22] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Tested along with subsequent commits; merging to gerrit." [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88155 (owner: 10Brion VIBBER) [18:46:23] \o/ [18:46:24] kaldari: yeah, hopefully will pick somethings up when I come to SF end of month [18:46:41] YuviPanda: seriously though, bowling stores have the best wrist braces. They are light years better than the medical ones and are usually cheaper and last twice as long. [18:46:57] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Tested along with subsequent commits; merging to gerrit." [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88156 (owner: 10Brion VIBBER) [18:47:07] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Tested along with subsequent commits; merging to gerrit." [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88157 (owner: 10Brion VIBBER) [18:47:36] is adam around today? [18:48:10] YuviPanda, tfinc: Seriously though, I recommend 'Robby's Leather Original': http://www.robbys.com/wrist_supports.php [18:48:35] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Tested along with subsequent commits; merging to gerrit." [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88158 (owner: 10Brion VIBBER) [18:48:37] bowling straps. interesting [18:48:55] kaldari: have you used them before ? [18:49:06] I wore them for about 10 years [18:49:19] and on both wrists for about 2 years [18:50:07] I used to have really bad wrist pain and had to get physical therapy, etc., so I spent a lot of money trying different wrist supports [18:50:17] (03PS1) 10Jdlrobson: Alpha: Make hamburger menu slide in/out when opened [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88185 [18:50:23] the medical ones were all POS [18:51:43] too early to tell on this one. i'm hoping that i wont need it for long. typing certainly sucks with it though [18:51:48] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Tested along with subsequent commits; merging to gerrit." [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88159 (owner: 10Brion VIBBER) [18:52:16] kaldari: are you going to be able to make the meeting at 12:30 or do you need me to move it to a different time? [18:52:32] (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87640 (owner: 10Jdlrobson) [18:52:34] jcmich: I can make it if I get lunch now :) [18:52:39] haha [18:52:50] sorry about that I forgot to factor in time zones [18:52:56] yell if you need me to move it [18:54:39] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87640 (owner: 10Jdlrobson) [18:55:12] (03CR) 10Siebrand: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88152 (owner: 10Jdlrobson) [18:55:15] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Tested along with subsequent commits; merging to gerrit." [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88160 (owner: 10Brion VIBBER) [18:56:29] jdlrobson, are you satisfied with https://gerrit.wikimedia.org/r/87474 ? [18:57:46] MaxSem: what about "mobile-wap" param value? [18:57:56] in parseContentFormat [18:58:13] yurik_, it had never been supported by API [18:58:22] only html and wml [18:58:25] lowercase [18:58:50] (03CR) 10Yurik: [C: 031] Make mobileformat not change the output structure [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87252 (owner: 10MaxSem) [18:59:13] right, need to crank up my brain [18:59:23] seems to be ok otherwise [18:59:33] I admit, this is a crazy shit code I wrote:P [19:00:04] yeah, i'm not very happy with ['*'] [19:00:07] tell you the truth [19:00:11] MaxSem: ^ [19:00:21] there is a func for setting those [19:01:20] in this particular case, I'm operating an array, not ApiResult [19:01:21] and if we ever try to fully remove it and switch to json, we might want to alter that func to change haw it works [19:01:33] poor users...:P [19:01:38] hehe [19:01:47] nah, that func will be backward blah blah blah [19:02:03] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Tested along with subsequent commits; merging to gerrit." [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88161 (owner: 10Brion VIBBER) [19:04:34] (03CR) 10Yurik: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87252 (owner: 10MaxSem) [19:04:34] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Tested along with subsequent commits; merging to gerrit." [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88162 (owner: 10Brion VIBBER) [19:05:23] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Tested along with subsequent commits; merging to gerrit." [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88163 (owner: 10Brion VIBBER) [19:05:49] (03CR) 10MaxSem: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87252 (owner: 10MaxSem) [19:08:18] (03CR) 10Yurik: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87252 (owner: 10MaxSem) [19:09:04] (03CR) 10JGonera: [C: 04-1] "I'm not sure how logging schema change is related." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88152 (owner: 10Jdlrobson) [19:11:15] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Tested along with subsequent commits; merging to gerrit." [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88164 (owner: 10Brion VIBBER) [19:13:29] (03CR) 10JGonera: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87640 (owner: 10Jdlrobson) [19:13:51] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Tested along with subsequent commits; merging to gerrit." [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88165 (owner: 10Brion VIBBER) [19:15:04] jdlrobson, so why do we add useformat=mobile in tests if we already set the cookie in env.rb? [19:15:09] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Tested along with subsequent commits; merging to gerrit." [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88166 (owner: 10Brion VIBBER) [19:16:02] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Tested along with subsequent commits; merging to gerrit." [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88167 (owner: 10Brion VIBBER) [19:17:14] (03CR) 10Brion VIBBER: "fixes https://bugzilla.wikimedia.org/show_bug.cgi?id=53380" [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88165 (owner: 10Brion VIBBER) [19:18:04] (03CR) 10Brion VIBBER: [C: 032 V: 032] Made My Uploads page use back arrow for consistency. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88168 (owner: 10Brion VIBBER) [19:19:23] (03CR) 10Brion VIBBER: [C: 032 V: 032] Made text box not underlap nav bar when keyboard appears. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88169 (owner: 10Brion VIBBER) [19:20:50] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Tested along with subsequent commits; merging to gerrit." [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88170 (owner: 10Brion VIBBER) [19:22:56] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Minor note: on iOS 7, status bar is transparent instead of translucent. May need slight further fix." [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88171 (owner: 10Brion VIBBER) [19:23:08] (03CR) 10Brion VIBBER: [C: 032 V: 032] Made category hamburger a bit lighter and taller for better contrast. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88172 (owner: 10Brion VIBBER) [19:25:02] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Tested along with subsequent commits; merging to gerrit." [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88173 (owner: 10Brion VIBBER) [19:26:51] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Looks awesome. :) Agree with taking out the wiki links for now, they weren't very intuitive and need a rethink." [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88174 (owner: 10Brion VIBBER) [19:30:19] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Tested along with subsequent commits; merging to gerrit." [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88175 (owner: 10Brion VIBBER) [19:31:00] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Tested along with subsequent commits; merging to gerrit." [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88176 (owner: 10Brion VIBBER) [19:34:04] hello jgonera [19:34:12] oh, he's not here anyway [19:34:40] ok, so the Schema:Edit issue is more general [19:34:53] DarTar, just to confirm, does doing the graph of editors for enwiki still seem like a good idea for now? [19:34:57] but I can give you the list of wikis currently using it, hang on [19:35:03] ok [19:35:04] yeah sure [19:36:20] jgonera: enwiki, frwiki, itwiki, plwiki, dewiki [19:36:57] I see, so those are not even all the wikis with VE, just some of them [19:37:27] and we're missing a lot of events, like I said I wouldn't trust data in that log until someone owns it [19:37:45] but you said we can trust success events, right? [19:38:03] when there's a record, yes. If a record is missing, no [19:38:05] brb [19:38:55] I'm not sure if I understand, what do you mean by a record? [19:40:07] so, when we have a page-success-event, then all the data associated with the event is kosher, but we're missing most of these events (they are not getting logged) [19:40:22] page-save-success, that is [19:40:43] oh, I see now, so we definitely want to use the mediawiki tables instead... [19:41:24] previously I thought that the data is unreliable only if we want to get more granular information, like edit attempts, etc. [19:42:20] it's worse than that [19:42:42] I'd really like to fix this log for good, but it looks like teams prefer to have and maintain their own log [19:42:55] which is fine as long as we don't start making cross-project comparison [19:43:02] that's where things get really messy [19:43:56] wait, so are we fine with that log if we only want to get edit success events from desktop on enwiki or not really? ;) [19:43:58] I'll go and get some food, swing by this afternoon if you want to talk about the State of the Logs [19:44:04] ok [19:44:21] no, we should use the regular MW tables [19:44:34] (03PS3) 10Dr0ptp4kt: Only load W0 JavaScript and CSS when needed. See bug 49786. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/87271 [19:46:50] yurik, would you please review https://gerrit.wikimedia.org/r/#/c/87271/ ? [19:47:39] (03PS4) 10Dr0ptp4kt: Only load W0 JavaScript and CSS when needed. See bug 49786. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/87271 [19:47:47] ^yurik, oops removed unnecessary space character [19:48:23] 01[13Commons-iOS01] 15siebrand pushed 1 new commit to 06master: 02http://git.io/aBAqXg [19:48:23] 13Commons-iOS/06master 144e660f0 15Siebrand Mazeland: Localisation updates from http://translatewiki.net. [19:49:13] (03CR) 10Brion VIBBER: [C: 032 V: 032] Cleared out some table view cruft. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88177 (owner: 10Brion VIBBER) [19:49:41] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix for improper call to super method. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88178 (owner: 10Brion VIBBER) [19:50:10] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Tested along with subsequent commits; merging to gerrit." [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88179 (owner: 10Brion VIBBER) [19:52:27] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Confirmed fixes cursor on iOS 6 & 7" [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88180 (owner: 10Brion VIBBER) [19:57:14] jcmish: in need of a qa test.. how can i make sure a test runs on beta mode and for a user with edit count 0 (i can force edit count 0 using javascript if i'm able to run javascript as part of the test) [19:57:24] i can also probably do as a qunit test if needed [19:57:27] (may be easier) [20:09:20] (03PS1) 10Brion VIBBER: Localisation updates from http://translatewiki.net. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88211 [20:09:21] (03PS1) 10Brion VIBBER: Localisation updates from http://translatewiki.net. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88212 [20:09:53] (03CR) 10Brion VIBBER: [C: 032 V: 032] "This l10n update landed on GitHub; merging manually to gerrit until we switch the configuration over." [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88211 (owner: 10Brion VIBBER) [20:10:04] (03CR) 10Brion VIBBER: [C: 032 V: 032] "This l10n update landed on GitHub; merging manually to gerrit until we switch the configuration over." [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88212 (owner: 10Brion VIBBER) [20:11:06] MaxSem: you never responded - are we going to simply cherry pick that commit tomorrow or is there a way we could do it today? [20:14:08] the former [20:16:32] ok [20:16:34] (03PS10) 10Jdlrobson: Tweak markup of edits and uploads text [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87474 [20:16:48] ^ i made a slight adjustment to add comments as you keep publishing it without that protection :P [20:17:13] i still think there is a nicer way to do this but i'm happy-ish to merge as is to keep things moving [20:18:26] (03CR) 10Jdlrobson: [C: 031] "MaxSem feel free to +2 if happy" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87474 (owner: 10Jdlrobson) [20:18:46] (03CR) 10MaxSem: [C: 032] Tweak markup of edits and uploads text [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87474 (owner: 10Jdlrobson) [20:19:11] (03Merged) 10jenkins-bot: Tweak markup of edits and uploads text [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87474 (owner: 10Jdlrobson) [20:19:23] (03CR) 10Jdlrobson: [C: 04-1] "If doing this you'll need to also update the Makefile script" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87565 (owner: 10Zfilipin) [20:21:12] sorry jdlrobson was on a call I already have a users [20:21:22] that has an edit count 0 [20:22:05] It's my "never been kissed" user, they've done nothing, no edits, no uploads [20:22:17] that way we can make sure tutorials launch correctly [20:23:45] You just pass: Given I am logged in as a new user and it will automatically use that user for whatever you need to do [20:23:51] jdlrobson: ^ [20:29:56] (03PS1) 10Jdlrobson: Stop people from checking in the Gemfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88220 [20:30:43] (03PS2) 10Jdlrobson: Stop people from checking in the Gemfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88220 [20:31:08] (03PS3) 10Jdlrobson: Stop people from checking in the Gemfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88220 [20:32:48] (03PS2) 10Jdlrobson: Allow editors to know that undo is unsupported [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88152 [20:40:48] MaxSem: very cool ;-) http://myleenhollero.zenfolio.com/p356851000/h7302889f#h7302889f [20:43:20] yeah, jellyfishies are cool - however some jerk obscures lots of them) [20:48:49] 01[13WikipediaMobile01] 15siebrand pushed 1 new commit to 06master: 02http://git.io/RunjSw [20:48:49] 13WikipediaMobile/06master 140d7a4e0 15Siebrand Mazeland: Localisation updates from http://translatewiki.net. [20:50:46] 01[13WLMMobile01] 15siebrand pushed 1 new commit to 06master: 02http://git.io/XFrG_A [20:50:46] 13WLMMobile/06master 14f23b5d8 15Siebrand Mazeland: Localisation updates from http://translatewiki.net. [20:51:24] grrr, the hosted mingle is slowwwwww [20:51:59] use an unhosted one [20:52:17] (03CR) 10JGonera: [C: 04-1] "Messes up the left dark border in the menu." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88185 (owner: 10Jdlrobson) [20:53:43] * MaxSem unhosts Reedy [20:53:45] (03CR) 10JGonera: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88185 (owner: 10Jdlrobson) [21:15:35] jdlrobson, are you satisfied with https://gerrit.wikimedia.org/r/87474 ? [21:16:19] (03PS32) 10Dr0ptp4kt: Hide charge-inducing features. Intercept link interstitials sooner. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 [21:17:41] jgonera, yurik, i updated PageRenderingHooks.php to reflect the w0 js and css inclusion improvement from ps 87271. but i didn't make 83133 dependent on 87271. [21:19:02] err, wrong change [21:19:07] sorry:P [21:19:07] MaxSem: it got merged so i guess :) [21:29:48] jdlrobson, what's changed in pngs in https://gerrit.wikimedia.org/r/#/c/87440/ ? [21:30:15] MaxSem: consistent resolutions [21:30:44] so these changes aren't accidental? why in this commit? [21:44:46] (03CR) 10JGonera: [C: 032] Allow editors to know that undo is unsupported [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88152 (owner: 10Jdlrobson) [21:45:14] (03Merged) 10jenkins-bot: Allow editors to know that undo is unsupported [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88152 (owner: 10Jdlrobson) [21:52:27] (03PS2) 10JGonera: Alpha: Make hamburger menu slide in/out when opened [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88185 (owner: 10Jdlrobson) [21:52:45] tfinc: added more to ios backlog [21:52:51] thanks mhurd [21:55:46] jgonera, jdlrobson: can I come and find either of you for a quick question on mobile registrations EventLogging data? [21:58:44] DarTar, you can, but not earlier than in half an hour (in my case) [21:58:51] DarTar: i've got to meet with vibha now [21:59:36] k, jgonera, ping me when you're done then? [22:04:17] jdlrobson: whats your take on the drop in successful edits between aug -> sept http://mobile-reportcard.wmflabs.org/ ? [22:04:30] almost a 30% drop [22:04:53] jdlrobson: also, how do we define a "successful edit" ? [22:04:54] tfinc: i haven't really looked at it in any data but i'd be keen to see a similar graph for desktop [22:05:13] august just might be a more busy month for editors [22:05:22] k, i'll move this to kenan to research as he might have the desktop data [22:05:24] i'll take a look at it a bit later [22:05:36] in general i really wants these stats for mobile vs desktop side by side [22:06:42] (03CR) 10Jdlrobson: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88185 (owner: 10Jdlrobson) [22:08:27] (03PS5) 10MaxSem: Card 1205 - last thanked info on UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87440 [22:08:50] err, need to address Siebrand's comments [22:11:21] jdlrobson: what are our current error rate stats on edits ? [22:11:52] ping me later in the day tfinc and i'll do a deep dive and send to mobile-l a few things i want to get through first [22:14:59] DarTar, I have some time now [22:16:15] k [22:16:45] jgonera: cool, coming to your desk [22:17:17] i'll still mail mobile tech to get the conversation going [22:20:55] (03PS4) 10Jdlrobson: Story 1072 (1/2): KeepGoing CTA [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87426 [22:20:56] (03PS1) 10Jdlrobson: Story 1072 2/2: Add EventLogging to Keep Going drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88248 [22:22:11] (03CR) 10jenkins-bot: [V: 04-1] Story 1072 2/2: Add EventLogging to Keep Going drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88248 (owner: 10Jdlrobson) [22:23:47] (03PS2) 10Jdlrobson: Story 1072 2/2: Add EventLogging to Keep Going drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88248 [22:30:12] tfinc, jgonera: any idea what day you guys will be flying to Pune? [22:31:02] kaldari: its all you guys. i'm not tagging along for this [22:31:22] mobile trio of jgonera, kaldari, and YuviPanda|zzz [22:31:30] tfinc: who all is going from SF? me, jgonera, alolita...? [22:31:37] i trust you guys to do good work [22:31:46] alolita has the master list [22:31:48] Rob Moen [22:31:54] cool, I'll ask her [22:31:56] yeah, I'm going from SF [22:32:13] given that you've never been to india pad it a little bit on both ends +/- what kenan is ok with losing velocity wise [22:32:17] I got an e-mail with some preliminary schedule but I asked for more time to look for something myself [22:32:31] flying to India from SF through NY seems kind of backwards... [22:35:49] (03CR) 10JGonera: "You may be right. I can get back to it later." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88185 (owner: 10Jdlrobson) [22:44:49] jcmish: do you have any overlap with runa and https://www.mediawiki.org/wiki/Language_Testing_Plan ? [22:45:08] nope [22:45:12] should I reach out to her? [22:45:58] jgonera: weird you'd think it would be just as easy to fly out of SF [22:46:46] jgonera, it is weird, I'd rather fly through somewhere in Asia [22:47:15] tfinc ^ [22:47:26] jcmish: i talked with alolita and it seems like the integration between i18n devs, product, and qa looks strong. i'd be eager for you to chat with her and see what works well/poorly for them. [22:47:35] heads up that she's in india so +12 hours ish [22:47:40] oh yeah forgot [22:47:43] I'll reach out [22:54:28] (03PS6) 10MaxSem: Card 1205 - last thanked info on UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87440 [22:54:29] mhurd: can you move your iOS stories from "iOS" to "Ready for estimates" ? [22:55:43] tfinc: ya! [22:57:20] DarTar, can you remind me, should I use revision or user_daily_contribs to get monthly edit counts for users? [22:58:31] revision joining on page if you want to get ns0 only edits, revision joining on page joining on change_tag if you want to get ns0-only mobile edits, otherwise user_daily_contribs for raw daily counts (all ns included, no distinction between mobile and desktop) [23:02:10] jgonera, posted q about the registration logs on mobile-tech [23:02:18] ok, thanks [23:02:26] tfinc: trello cards moved [23:02:45] DarTar, Maryana so when we talk about active editors, do we count edits only in main ns or all edits? [23:02:58] only in main ns [23:03:12] at least according to the definition we use in editor engagement [23:03:30] pretty sure that's the def in erik zachte's tables/charts, too, no? [23:03:34] the project-level reportcard use a slightly different definition [23:03:39] alas no [23:03:47] uuughhghghghghghg [23:03:51] ;) [23:04:08] the main differences are 2: [23:04:27] thanks mhurd [23:04:44] - he uses the countable article AND countable namespace definitions [23:05:08] - he doesn't include edits on pages that are later deleted [23:07:29] (03CR) 10Yurik: [C: 032] Only load W0 JavaScript and CSS when needed. See bug 49786. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/87271 (owner: 10Dr0ptp4kt) [23:07:38] (03Merged) 10jenkins-bot: Only load W0 JavaScript and CSS when needed. See bug 49786. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/87271 (owner: 10Dr0ptp4kt) [23:16:55] (03PS33) 10Dr0ptp4kt: Hide charge-inducing features. Intercept link interstitials sooner. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 [23:18:24] jgonera: lessphp how can a mixin take a parameter with a comma in it? [23:18:38] ^^yurik, rebased [23:18:41] jdlrobson, you need to assign it to a temp variable first... [23:18:54] jgonera: you got any examples that do that? [23:19:00] jcmich: I'm trying to figure out how to install selenium on my Mac, but it looks like there are 3 different versions, one for Java, one for Python, and one for Ruby. I found installation instructions for Python and Java, but not for Ruby. Do you have any pointers? [23:19:07] jgonera got a problem in core master i need to fix asap [23:19:14] yes? [23:19:21] oh [23:19:22] wait [23:19:32] common/notifications.less [23:19:55] or the new patchset for animated left nac [23:19:57] nav* [23:20:07] jgonera: oooh i just learnt something new [23:20:10] .transition( margin-left 250ms, padding 250ms; ); [23:20:21] if a semicolon is present jgonera it treats ; as the delimiter [23:20:25] jcmich: also, do I need Rails or just Ruby? [23:20:41] does it work for you in lessphp? [23:20:52] for me it converted semicolons into spaces anyway [23:21:10] jgonera: yup [23:21:11] it works [23:21:25] ok, you'll show me later [23:21:27] jgonera: see https://gerrit.wikimedia.org/r/88256 [23:25:11] jcmich: are we using Selenium RC or Selenium Webdriver? Does it matter which one I install? [23:27:38] jdlrobson, oh, I get it, there just needs to be a semicolon somewhere [23:27:47] I thought that I should use it instead of , [23:28:51] jdlrobson: you know anything about installing selenium? [23:29:32] jgonera: also https://gerrit.wikimedia.org/r/#/c/88254/1/resources/mediawiki.less/mediawiki.mixins.less [23:29:38] Krinkle has another way of doing it [23:30:23] that's the wrong way [23:30:41] transform needs to be prefixed for webkits [23:31:03] which means -webkit-transition: transform won't work, but -webkit-transition: -webkit-transform will [23:31:12] jdlrobson, ^^ [23:34:59] I don't have a different way, jdlrobson misunderstood the problem. [23:35:52] I'm also not changing any of the prefixes so not sure why you're bringing that up? Or was that abotu something else? [23:35:55] jgonera: [23:36:45] so you're doing .transition( transform ..., -webkit-transform ... ) when you want to have a transition on the transform property? [23:37:38] yes, I mixed it up, so passing a string works, but then do you have to wrap the argument in quotes? [23:38:34] (03PS3) 10MaxSem: Make mobileformat not change the output structure [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87252 [23:45:33] jgonera: can you join conversation in wikimedia-deb ? [23:46:03] forget that seems we're all here anyway ;-) [23:46:41] kaldari: i'll grab you in a minute :) [23:46:56] jdlrobson, you scared me. "what, another channel? for debian packagers?":P [23:47:03] MaxSem: haha [23:47:35] jdlrobson, it seems that Krinkle has a valid point [23:47:37] yurik, you there? [23:47:47] ^yurik_ [23:47:51] I just don't want to pass strings in there, other than that I'm fine with either mixin [23:48:03] Krinkle: i understand they both do the same. [23:48:09] jdlrobson: did you see my note on a user who hasn't edited or uploaded for your test? [23:48:20] jcmish: not yet - sorry juggling too many things [23:48:27] believe you mean I hear ya [23:48:38] jdlrobson: I'm making some progress. Looks like I need to install RVM so that I can install Ruby, so that I can install the Ruby implementation of Selenium Webdriver. [23:48:41] I need to finish up testing just ping me again if you need me to look [23:48:51] Krinkle: i guess you're right in that it's easy to omit the semicolon but the fact you managed to discover this bug shows that it is visible and could be caught during code review [23:49:33] jdlrobson: I don't strive for being able to catch it. I prefer jenkins-bot blowing up with a less parse exception with invalid arguments. [23:49:55] jdlrobson: as for the ; style, we can do that still. No problem. [23:50:01] (moving back to -dev) [23:50:14] kaldari: ping me if you get stuck [23:50:36] jcmish: thanks :) [23:50:37] I'm throwing together some notes for you [23:52:25] still installing RVM, whatever that is [23:57:14] hahah [23:57:25] it's ruby version manager [23:57:26] it seems stuck [23:57:46] hmm nothing happening? [23:58:38] nothing at the moment. It through about 200 warnings earlier, but nothing important [23:58:58] stuff like "unable to convert "\xFF" from ASCII-8BIT to UTF-8 for guides/assets/images/vijaydev.jpg, skipping" [23:58:59] I can take a bit what OS are you loading it on? [23:59:07] OSX [23:59:17] oh then yeah it should be pretty smooth [23:59:25] ah, there it goes [23:59:34] RVM is finished [23:59:37] sweet