[00:03:26] OK, selenium should be installed now [00:05:44] jcmich: so do I need to clone the browsertests repo in order to run the MobileFrontend tests? [00:05:52] nope [00:06:07] our stuff is in our own repo [00:06:21] we used to have them together but broke them out some time ago [00:08:16] I just cd'ed into the MobileFrontend acceptance directory and got the following warning: RVM used your Gemfile for selecting Ruby, it is all fine - Heroku does that too, you can ignore these warnings with 'rvm rvmrc warning ignore /Users/kaldari/Sites/core/extensions/MobileFrontend/tests/acceptance/Gemfile'. To ignore the warning for all files run 'rvm rvmrc warning ignore allGemfiles'. [00:08:25] what the heck does that mean? [00:08:53] and what is Heroku? [00:09:01] nothing really [00:09:28] it's just rvm telling you that it used your gemfile for ruby instead of you /usr/bin version of ruby [00:09:46] you can have it ignore that warning [00:09:59] I think that is a good thing [00:10:07] remember how I said that we have the gemfiles all setup and commited? [00:10:12] from what little I understand of Ruby :) [00:10:15] that pulls the correct versions [00:10:18] https://twitter.com/dheadshot/status/387369230343352320 < waaa ? [00:10:21] and it just warns you [00:10:42] hehe you would be correct kaldari definitely not a bad thing [00:10:45] * jdlrobson has replied [00:10:54] jcmish: did you see my patch? [00:11:05] haven't gotten to it [00:11:06] https://gerrit.wikimedia.org/r/#/c/88220/ < jcmish [00:11:12] I'll have to look at it tonight [00:11:16] it stops me running qa tests from Makefile [00:11:41] because it's not reviewed you mean? [00:11:46] or that was the intent of the patch? [00:12:50] oh [00:12:51] hahahhaha [00:12:58] I read it [00:13:08] I thought this was your earlier patch [00:13:13] yeah I'll +2 it [00:14:35] (03CR) 10Mgrover: [C: 032] Stop people from checking in the locked Gemfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88220 (owner: 10Jdlrobson) [00:14:58] (03Merged) 10jenkins-bot: Stop people from checking in the locked Gemfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88220 (owner: 10Jdlrobson) [00:16:03] jdlrobson, http://stackoverflow.com/a/4151540/365238 [00:20:44] jcmish: Got stuck... [00:20:56] walked off to look at my son's homework but saw the email failure jdlrobson and jgonera putting gemfile.lock back [00:21:09] k kaldari one sec [00:21:09] jcmish, ^ the link I sent [00:21:38] ah dependencies yup thanks jgonera [00:22:28] so I got up to the point where I'm supposed to try running the tests. First I tried 'bundle exec rake', which gave me 'No Rakefile found'. Then I tried 'bundle exec cucumber' which gave me a fatal error with a backtrace: '/Users/kaldari/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/json/common.rb:155:in `parse': uninitialized constant JSON::Parser (NameError) …. ' [00:22:39] jcmish: so why is my instance complaining when that exists? [00:22:48] * jdlrobson knows nothing about gems [00:23:00] not sure send me the actual message [00:23:17] error you get [00:23:21] (03PS3) 10Jdlrobson: Hygiene: Standardise on MEDIAWIKI_URL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87640 [00:24:10] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87640 (owner: 10Jdlrobson) [00:24:35] Could not find data_magic-0.15.1 in any of the sources [00:24:35] Run `bundle install` to install missing gems. [00:24:39] ^ jcmish [00:24:44] but it is installed [00:26:42] (03PS1) 10Mgrover: readding Gemfile.lock [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88263 [00:27:02] (03CR) 10Mgrover: [C: 032] readding Gemfile.lock [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88263 (owner: 10Mgrover) [00:27:24] jdlrobson: let me help kaldari then I'll take a look [00:27:28] kaldari: what's up [00:27:31] jcmish: sure [00:27:33] (03Merged) 10jenkins-bot: readding Gemfile.lock [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88263 (owner: 10Mgrover) [00:27:45] jcmish: See my last message above ^ [00:28:00] (03CR) 10Jdlrobson: "You probably should have just reverted the change... the gitignore file also got altered." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88263 (owner: 10Mgrover) [00:28:20] ah sorry jdlrobson [00:28:33] kaldari: did you do a bundle install? [00:29:07] (03CR) 10Jdlrobson: "(also the commit message could be a lot better - commit message doesn't link up with the change that it fixes and doesn't say why it was r" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88263 (owner: 10Mgrover) [00:29:20] jcmish: yes [00:30:14] and you run "bundle exec cucumber" and that gives you the rake error? [00:31:10] no "bundle exec cucumber" gives me a different error [00:31:17] k what's that one [00:31:20] "uninitialized constant JSON::Parser (NameError)" [00:31:53] I can give you the whole stacktrace if it helps [00:32:16] That's probably still a rake error but sure send it to me [00:33:44] jcmish: http://dpaste.com/1409109/ [00:33:54] (03PS1) 10Dr0ptp4kt: Vary the cache based upon source proxy. See change 88261. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/88264 [00:34:48] (03CR) 10Dr0ptp4kt: [C: 04-2] "Do not merge until change 88261 merged." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/88264 (owner: 10Dr0ptp4kt) [00:35:23] got it kaldari can you do a bundle install and send the results to me [00:36:53] jcmish: http://dpaste.com/1409110/ [00:37:55] k thanks [00:37:59] let me take a look [00:38:28] jcmish: http://stackoverflow.com/questions/18068572/cucumber-rake-task-fails-blames-json-parser [00:38:35] wonder if that's the same issue [00:39:08] that says I need to update multi_json [00:39:14] hmm i'm not sure becuase I'm using mulit_json 1.7.7 too [00:39:45] and I don't have a problem let me run a bundle update to make sure it doesn't break anything [00:41:24] k give it a shot.. just do a bundle update [00:41:31] and get all the related gems [00:41:36] let's see if that works [00:42:01] I did the same and run the tests and they passed fine so it won't make it worse at lease [00:42:04] *least [00:47:02] jdlrobson: so should I revert my change and then revert yours? or just pull down the previous gitignore file [00:47:13] what's the safest way to clean this up? [00:47:31] jcmish: i'll sort it out. it was more a note for the future [00:47:44] k [00:47:58] good commit messages are very important and sometimes we neglect that - it helps educate developers why stuff exists [00:48:24] true since I get stuck interpreting them a lot :) sorry [00:48:33] jcmich: hmm, not I get a different error: "No such file or directory - /private/wmf/secret.yml (Errno::ENOENT)" [00:48:37] not=now [00:48:44] ah k that's easy [00:51:16] kaldari: in your email [01:01:13] jcmish: I'm up and running now :) [01:02:41] woohoo! [01:02:45] welcome ! [01:02:55] I need a sinister laugh [01:03:00] but all out right now :D [01:03:43] jcmish, never heard you laughing sinisterly [01:03:57] oh MaxSem you don't know me very well! [01:04:15] but mostly I reserve it for my family ;) [01:10:35] jdlrobson: ping [06:43:43] (03CR) 10Nikerabbit: [C: 04-1] "(4 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 (owner: 10Kaldari) [07:31:18] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 (owner: 10Kaldari) [16:19:01] (03PS2) 10Dr0ptp4kt: Vary the cache based upon source proxy. See change 88261. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/88264 [16:46:18] hello [16:48:55] hi [16:49:12] yurik, is https://gerrit.wikimedia.org/r/87252 now fine? [17:08:32] yurik, you able to make the google hangout? [17:48:02] (03PS6) 10Kaldari: Preparing the LastModified code for Mingle cards 1262 and 1258 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 [17:50:07] (03PS7) 10Kaldari: Preparing the LastModified code for Mingle cards 1262 and 1258 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 [18:05:10] jdlrobson: Where was that ReadMe file that you showed me yesterday? I was going to update it, but I can't find it now. [18:05:24] kaldari: it's in the root directory of MobileFrontend [18:05:45] ah, I see, at the bottom [18:05:47] thanks! [18:18:25] (03PS1) 10Kaldari: Updating Selenium instructions in ReadMe file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88528 [18:25:10] vbamba: you look so classy today huh [18:35:31] (03CR) 10Jdlrobson: [C: 032] Updating Selenium instructions in ReadMe file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88528 (owner: 10Kaldari) [18:35:56] (03Merged) 10jenkins-bot: Updating Selenium instructions in ReadMe file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88528 (owner: 10Kaldari) [18:36:44] awjr, I see you've grabbed https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1277 - I started working on tablet detection in my fre time btw [18:51:28] MaxSem: awjr : do you guys have any interest in talking to these guys http://www.deviceatlas.com/ ? [18:52:39] ugh, forgot reply to this [18:53:48] I personally belive now that we've moved away from device detection in most aspects, their tech is not that interesting for us [18:57:57] k [19:02:13] MaxSem: awesome - that's probably something we'll need to focus more seriously on for the upcoming iteration(s) [19:02:17] (tablet detection i mean) [19:02:24] since rob from the VE team will be joining us :) [19:02:32] tfinc: what MaxSem said :) [19:03:00] awjr, actually, this is icky - what we need for WP is a merge of Minerva and SkinMobile [19:03:03] that said, it might be neat to chat with them and see what lessons they've learned, etc [19:03:10] otherwise we'll just bust the caches [19:03:13] MaxSem: for WP? [19:03:16] yes [19:03:26] MaxSem: can you explain more, im not sure i follow [19:03:51] hangout? [19:04:18] just a minute MaxSem [19:05:50] ok MaxSem [19:10:33] (03PS1) 10Dr0ptp4kt: Don't show ineligible zerodot content. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/88612 [19:11:54] ^yurik, would you please review and, if appropriate, +2? this is to stop echoing article content for ineligible zerodot access (e.g., carrier config doesn't support lang-zerodot combination, x-cs wasn't present, etc.). [19:30:42] jdlrobson, cherrypick only https://gerrit.wikimedia.org/r/#/c/87478/ , right? [19:43:20] MaxSem: yes [19:43:24] ok [19:43:28] MaxSem: but make sure dependency is also deployed [19:43:31] sure for delay! [19:50:26] (03PS1) 10MaxSem: Track anonymous clicks as well [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88620 [19:53:25] (03CR) 10MaxSem: [C: 032] Track anonymous clicks as well [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88620 (owner: 10MaxSem) [19:53:50] (03Merged) 10jenkins-bot: Track anonymous clicks as well [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88620 (owner: 10MaxSem) [19:54:42] EventLogging doesn't work on testwiki, right? so we should just push this... [19:54:57] what about test2wiki MaxSem? [19:55:29] you can't test on it before pushing to whole cluster [19:56:03] oh right i forgot it wasn't set up like testwik [19:58:32] (03Abandoned) 10Dr0ptp4kt: Suppress menu, search, icons, langs, history on unsupported zerodot. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/78909 (owner: 10Dr0ptp4kt) [20:04:57] awjr, jdlrobson, jgonera, it went live on enwiki - please test:) [20:05:11] eh, premature [20:05:18] now for realz [20:05:37] so we're deploying something? [20:06:16] yes, https://gerrit.wikimedia.org/r/#/c/87478/ [20:08:19] MaxSem: i'll quickly check [20:08:48] thanks jdlrobson [20:08:59] erp no jcmish [20:10:16] MaxSem: looks good [20:10:26] actually wait.. MaxSem [20:12:21] what are you seeing jdlrobson? [20:12:33] awjr: it's working [20:12:34] preliminary poking on enwiki suggests nothing broke but dunno about the click tracking [20:12:35] oh ok [20:12:41] there are events being logged for anonymous users in beta [20:12:56] so it looks like we are good [20:13:04] \o/ [20:13:32] jdlrobson: just noticed something weird with talk [20:13:34] in beta [20:13:41] https://en.m.wikipedia.org/wiki/Daniel_Brodhead_IV [20:13:55] i tap on the talk icon [20:14:20] i am told 'there are no conversations about this page' but there is a conversation called 'unnamed discusison', though when i tap on it i just see a blank overlay [20:14:54] we kill tables in talk discussions [20:14:56] https://en.m.wikipedia.org/wiki/Talk:Daniel_Brodhead_IV [20:15:02] yeah i saw that [20:15:05] anyway awjr there should be no regressions [20:15:11] it was a pretty harmless patch we just deployed [20:15:24] totes, just wanted to highlight the behavior - i hadn't seen it before [20:18:12] awjr: yup i'll run them now [20:18:20] en wiki tests I'm home and on my machine [20:18:36] thanks jcmish [20:18:42] you betcha [20:18:46] out of curiosity, is there a way for others to run those tests? [20:18:53] and is it documented somewhere? [20:18:56] they run automatically [20:19:17] as part of the jenkins suite they just take a while to get to free agent [20:19:32] gotcha - is that stuff documented somewhwere? [20:20:03] if you want to run them "now" yup you just run them from any dev environment as long as you have the system configured [20:20:20] cloudbees? I have the links to it on my Mobile Regression test page [20:20:30] but I can put more details around how to run commandline etc together [20:20:38] that would be cool jcmish [20:20:43] let me run this and I'll add that to my todo's [20:24:45] anyway, deploying to wmf20... [20:27:07] (03PS3) 10Dr0ptp4kt: README updates about useful globals for Wikipedia Zero. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/82030 [20:27:11] done [20:27:25] anything else, awjr, jdlrobson, jgonera? [20:27:26] ^^yurik, would you please review and +2 82030? [20:27:45] I guess that's it for today [20:28:01] i think we're good MaxSem, at least once jcmish's tests are done [20:28:08] i did some poking around and nothing seems busted. [20:30:52] awjr: MaxSem tests passed [20:32:11] wee [20:32:23] all right [20:32:29] thanks everyone! [20:32:38] thank YOU MaxSem :) [20:51:24] (03PS3) 10Dr0ptp4kt: META Wikipedia Zero side-by-side banner comparison. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/78265 [20:52:28] ^yurik, would you please review and +2 78265? [20:52:39] dr0ptp4kt: looking... [20:52:50] yurik_, thx [20:53:52] yurik, i'm heading out in about 5 mins. will be back online for email and catchup in some 4 hours or so. [20:55:16] dr0ptp4kt: oki [21:05:10] brion: how are we looking for our two releases ? [21:23:04] brion: how are we looking for our two releases ? [21:23:35] tfinc: so far so good. i'll have to self-review my latest android tweaks if yuvi stays offline but i can manage that :) [21:23:48] brb [21:31:17] Maryana: where can i find similar stats to http://mobile-reportcard.wmflabs.org/ for desktop ? [21:31:30] sadly, nowhere [21:31:36] what's the closet to it ? [21:31:54] closest [21:32:15] i'd ask dartar - we had an email exchange about this the other day, but i forget which schema he said might come closest [21:32:28] ok [21:32:42] tfinc: what stats specifically? [21:33:21] we have similar data at http://ee-dashboard.wmflabs.org/dashboards/enwiki-metrics and http://ee-dashboard.wmflabs.org/dashboards/enwiki-features [21:33:43] full list: http://meta.wikimedia.org/wiki/Research:Data/Dashboards#Project-level_metrics [21:34:20] DarTar: anything that maps to what is on http://mobile-reportcard.wmflabs.org/ [21:34:32] i want to do desktop and mobile comparisons [21:35:23] right, we have some of these already, other stats for desktop will need to be created [21:35:43] k [21:35:57] note that all the ee-dashboard graphs are project specific [21:39:17] jcmish: here's a nice glitch. we see this from time to time, best guess is that something on the Cloudbees Jenkins host returns non-zero even though all the tests pass. https://wmf.ci.cloudbees.com/job/MobileFrontend-test2.m.wikipedia.org-linux-firefox/10/ sorry for the inconvenience. [21:39:48] jcmish: check "console output" for that job to see how that looks. [21:40:15] jgonera: fyi i have a bad feeling all our media queries are broken now since we moved to core less support [21:40:37] stylesheets are wrapped in @media screen { meaning we have media queries wrapped inside @media screen { [21:40:39] chrismcmahon: looking [21:41:01] we may want to sort this out before thursday.. [21:42:03] that totally bites [21:42:06] do we know why? [21:44:00] false alarm [21:44:05] but jgonera could you double check? [21:44:11] i'm sucked into something at the moment [21:44:21] there's something weird going on - our beta doesn't look right [21:44:21] chrismcmahon: ^ [21:44:33] jdlrobson, I'm working on something with Ori now [21:44:36] I'll check later [21:44:41] ok np [21:48:56] jdlrobson: in prod or master? [21:49:40] master awjr - sucked into beta features stuff right now so can't check [21:49:44] np [22:01:09] jdlrobson: when you have a moment - what isn't looking right in beta on master? im not seeing anything particularly broken but perhaps im missing something [22:16:04] awjr: so in beta mode the info box should float to the right on a large screen [22:16:10] also the menu is smaller when open [22:16:52] actually it seems to look ok now [22:17:02] i think it's a false alarm from me :) [22:17:36] phew [22:31:11] kaldari: hey can you respond to Luis's email? [22:31:27] responding now [22:37:28] kenanwang: thats some crazy sound bleed on your headphones [22:37:32] kenanwang: granted i like daft punk too [22:37:47] kenanwang: replied [22:38:17] sorry, I hope this doesn't get dragged out too much more [23:21:44] kaldari: i responded [23:22:28] MaxSem: how did the deploy go today? [23:22:45] kenanwang, it was boooring [23:23:09] kenanwang: sounds good to me [23:23:21] too uneventful for my likling:) [23:23:51] MaxSem: is your user profile patch ready to go from your perspective? [23:23:56] next time, I'll throw a divide by zero error in there :) [23:24:04] I think it is [23:26:01] ok cool i'll take a look now [23:32:55] (03PS7) 10Jdlrobson: Card 1205 - last thanked info on UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87440 (owner: 10MaxSem) [23:32:56] MaxSem: if you +1 i will +2 ^ [23:33:10] +1 myself?:) [23:33:31] MaxSem: there are a few tweaks from me in there too [23:33:49] (03CR) 10MaxSem: [C: 031] Card 1205 - last thanked info on UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87440 (owner: 10MaxSem) [23:35:08] (03PS8) 10Jdlrobson: Card 1205 - last thanked info on UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87440 (owner: 10MaxSem) [23:35:14] (03CR) 10Jdlrobson: [C: 032] "BOOM" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87440 (owner: 10MaxSem) [23:37:15] jgonera: https://gerrit.wikimedia.org/r/86052 [23:38:35] (03Merged) 10jenkins-bot: Story 1205: last thanked info on UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87440 (owner: 10MaxSem) [23:38:41] o_0 [23:42:18] awjr: [16:44:15.500] "Exception thrown by mobile.watchlist.scripts: Module not found: loggingSchemas/MobileWebClickTracking" [23:42:20] eek [23:43:58] master on stable on watch list page- this is stopping the watch list star from showing up [23:44:04] not sure what happened there [23:46:28] ^ awjr [23:49:12] MaxSem: awjr kenanwang so the watch list /on stable/ is no longer click tracking and is throwing a JavaScript exception meaning that the watch list stars do not show on the a-z view [23:49:15] is this a problem? [23:49:17] the page is still functional [23:49:28] beta is fine [23:51:14] https://bugzilla.wikimedia.org/show_bug.cgi?id=55490 [23:51:24] I'd say it is. I reported this before, and there's a bug by kaldari [23:51:43] (03CR) 10Yurik: [C: 032] "Thanks Adam for doing this!!!" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/82030 (owner: 10Dr0ptp4kt) [23:51:46] (03Merged) 10jenkins-bot: README updates about useful globals for Wikipedia Zero. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/82030 (owner: 10Dr0ptp4kt) [23:54:11] (03PS1) 10JGonera: Update notifications icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88672 [23:56:45] (03PS1) 10Jdlrobson: Fix watchlist scripts dependency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88673 [23:56:49] ^ well that fixes that one