[00:02:53] jdlrobson: MaxSem sorry was in a mtg, reading backscroll now [00:02:56] jcmish: ^^^ [00:03:12] awjr: looking [00:04:01] jdlrobson: did you get a response from kenanwang? [00:04:04] so jdlrobson MaxSem is this new? [00:04:12] or a regression? [00:04:13] awjr: nope no word from kenanwang [00:04:23] jcmish: i'm not sure if it's new or not [00:04:33] personally i think we can live with it till monday [00:04:44] jdlrobson: give the time of day and the fact that this doesn't soundl ike a huge issue, we hold off [00:04:48] we weren't really using the watch list data for anything at the moment and we have a lot of data for it already [00:04:49] k I saw MaxSem and it sounds like it's been there but I wondered if I'm wrong [00:04:49] at least for now [00:04:56] jcmish: there is 2 bugs here [00:05:00] the other one i am exploring [00:05:02] jdlrobson: can you email out to the list and specifically ask kenanwang what we ought to do? [00:05:13] if it's urgent we can see about deploying a fix tomorrow. [00:05:25] k need any help with the other one jdlrobson ? [00:05:45] hey [00:05:51] ahha [00:05:51] catching up on this thread. [00:05:54] :) [00:06:46] I'm ok waiting until monday [00:07:10] jdlrobson: why did you suggest waiting til monday? [00:07:20] if we're riding the train the change wont be on enwiki til next thursday [00:07:31] awjr: wo wo wo [00:07:36] hahah [00:07:37] that's not what i understood [00:07:42] thursday it goes to testwiki [00:07:45] monday it goes to enwiki [00:07:57] either way https://gerrit.wikimedia.org/r/88673 should be merged asap [00:08:01] to make sure it gets on a train [00:08:03] nope I saw the email from Greg, awjr is right [00:08:12] jdlrobson: see schedule here: https://wikitech.wikimedia.org/wiki/Software_deployments [00:08:37] thursday is test and mediawiki for the new branch, enwiki (and all other wikipedias) get the old branch [00:08:44] ok [00:08:44] monday is all non-wikipedia sites [00:08:51] that wasn't clear to me [00:08:58] so kenanwang if we just ride the train on this, the issue won't be fixed til next Thursday [00:09:04] it would be nice for someone to summarize this as i'm hearing way too many conflicting messages [00:09:14] jdlrobson: i already did an email somewhere :) [00:09:38] it is confusingly in the email with subject '[mobile web] Should we deploy as usual on Tuesday? [00:09:38] ' [00:10:34] kenanwang: so are you ok til next Thurs or should we try to do an out-of-band deployment to get this fixed? [00:10:44] I [00:10:50] I'm ok with sticking it on the train [00:11:00] woo woo! [00:11:03] The data is not so urgent as to require out of band [00:11:15] groovy [00:11:27] although kenanwang apparently it's not just data - the watchstar is not appearing [00:11:56] ah sorry, apparently only not appearing on the a-z view of the watchlist [00:12:39] kenanwang: remember this does break the watch list star on stable watch list though [00:12:43] so people won't be able to unwatch [00:12:48] its' not just event logging data [00:16:02] how often does that happen do we know? [00:18:32] jdlrobson: ^ [00:20:02] (03PS1) 10Jdlrobson: Rename watch event to watched [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88676 [00:20:07] um let me look at the data we broke ;-) [00:20:32] :p [00:21:38] Well on an old sample of data considering 64,640 links to articles/diffs were clicked and only 2899 unwatch actions [00:22:00] 2899 / 103,718 * 100% of all clicks within the watch list view [00:22:15] so about 0.03% of all activity [00:24:07] It doesn't crash the site right? [00:24:12] just doesn't work [00:25:08] jdlrobson: ^ [00:25:22] nope throws a JavaScript error which might surface on certain browsers [00:25:33] kenanwang: so the deployment train pushes code to test2 on thursday and then to en wiki on the following thursday [00:25:41] jdlrobson: awjr let's put oit on the train [00:25:45] *it [00:25:54] so what day do you want to have the acceptance meeting? [00:26:12] chugga chugga choo choo [00:26:28] we typically have it on the day before the deploy but I can make it more if you prefer [00:26:32] awjr: i got antsy and created the Cross Team Exchange Best Practices [00:26:37] hmm [00:26:43] nice tfinc [00:26:43] can you schedule a time for us to talk about it/ [00:26:44] ? [00:26:48] yup [00:26:56] I think that the structure of the meeting will probably change [00:27:33] yup it will [00:27:52] k I'll find 30 mins for us to chat [00:28:14] tomorrow good or thursday better? [00:29:03] kenanwang: we'll have to change it anyway [00:29:14] because it looks like Kaity isn't available on wednesdays [00:29:30] jcmish: see my recent email re wednesdays :) [00:29:45] kaity said she's fine keeping the regular meetings on wednesdays and finding another day for 'focus' time [00:29:45] she declined my QA meetings [00:29:50] oh :( [00:29:59] oh maybe she just declined this one [00:30:01] I'll reach out [00:31:03] Let's try Wednesday and see if we need to add more [00:31:58] jdlrobson: im unable to add stuff to my watchlist on mediawiki.org (desktop view). wonder if it's relateD? [00:32:30] desktop view? [00:32:47] jdlrobson: yeah, but now it actually appears to be working [00:32:59] o_o awjr [00:33:05] don't tocuh desktop [00:33:17] i tried on a couple of articles and got an error (no JS errors thrown though), but now it appears fine [00:33:26] hehehe jdlrobson, only when i truly must. [00:36:42] I love the fact that all our mobile UI wireframes show a low battery status. It makes me want to plug them in. [00:37:00] lol [03:36:18] (03PS1) 10Kaldari: Add user to last modified [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88681 [03:36:48] (03CR) 10Kaldari: [C: 04-2] "Not ready yet." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88681 (owner: 10Kaldari) [06:37:52] (03PS1) 10Mgrover: QA-Added option to keep browser option for debugging to match the browsertests project [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88689 [07:00:51] (03CR) 10Yurik: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87252 (owner: 10MaxSem) [14:54:53] (03CR) 10MaxSem: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87252 (owner: 10MaxSem) [15:30:21] (03CR) 10MaxSem: "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88681 (owner: 10Kaldari) [15:30:57] brion: hey brion! came in a bit early for some last-minute patches. should be set in a couple hrs [15:33:15] (03CR) 10MaxSem: "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 (owner: 10Kaldari) [15:33:28] (03CR) 10MaxSem: [C: 04-1] Preparing the LastModified code for Mingle cards 1262 and 1258 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 (owner: 10Kaldari) [15:36:30] (03PS2) 10Zfilipin: Renamed tests/acceptance folder to tests/browser [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87565 [15:37:12] (03CR) 10Zfilipin: "Updated README.mediawiki and scripts/cucumber.sh" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87565 (owner: 10Zfilipin) [15:53:13] mhurd: whee! [15:53:25] brion: :) [15:54:16] mhurd: hey when's your 5S ship? I'm dying to try out my crazy video decoder on it :D [15:54:29] brion: lemme check... [15:55:36] brion: says it should arrive tomorrow! yay toys! [15:55:44] :DD [16:03:34] mhurd, whaaa - you didn't wait in a line whole night to buy it on the first day?:P [16:03:51] MaxSem: no way haha [17:01:42] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 (owner: 10Kaldari) [17:16:13] MaxSem: these keep coming up : http://www.mediawiki.org/w/index.php?title=Extension_talk:MobileFrontend&offset=20131009144612&lqt_mustshow=34183#Html_Formatter_Not_Found_34183 is there any way to tell users when they have installed an incompatible version? [17:17:30] mmm, yes - I can add a compare_version [17:20:19] * jgonera going to the office [17:22:23] MaxSem: that would be useful [17:22:33] MaxSem: just something that says "i can needz upgrade" [17:24:08] brion: will you be able to do tomorrows prioritization meeting even with your wfh day ? [17:24:31] yeah, ok to call in or should i come in for the afternoon? [17:24:49] calling in is fine [17:25:08] i want to avoid doing it on wed since were releasing today [17:25:36] yeah [17:25:37] ok [17:36:40] jdlrobson, ^^ [17:36:41] (03PS1) 10MaxSem: Fail gracefully if people are using older MW [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88768 [17:36:45] eh ^^^ [17:37:24] :D [17:37:55] (03PS1) 10Kaldari: Need to mention MediaWiki path setting as well for Selenium [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88769 [17:39:09] awjr: does that look okay to you? [17:39:28] (03CR) 10Jdlrobson: [C: 031] "Sanity check from Arthur before +2ing" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88768 (owner: 10MaxSem) [17:39:38] jdlrobson: i'll take a look in a min [17:39:42] thanks :) [17:47:50] (03CR) 10Awjrichards: [C: 032] Fail gracefully if people are using older MW [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88768 (owner: 10MaxSem) [17:48:12] (03Merged) 10jenkins-bot: Fail gracefully if people are using older MW [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88768 (owner: 10MaxSem) [18:00:35] brion: per Michaels email do you know why we don't crawl /w ? [18:02:57] brion: i'm sure you have more background then me so let michael know [18:04:35] tfinc: i'll have to ask him why he wants to crawl /w in the first place :) it sounds like the wrong thing to do [18:08:12] http://etherpad.wikimedia.org/p/Mobile-VE-Integration-Planning [18:08:45] jgonera, tfinc ^ [18:11:18] thanks brion [18:18:21] (03PS10) 10Brion VIBBER: Extract and show license key [apps/android/commons] - 10https://gerrit.wikimedia.org/r/85925 [18:25:14] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Self-reviewing version with basic i18n since Yuvi's out at the moment. (Yuvi feel free to comment and I can make further fixes, right now " [apps/android/commons] - 10https://gerrit.wikimedia.org/r/85925 (owner: 10Brion VIBBER) [18:25:57] (03CR) 10Kaldari: [C: 04-1] "I get the following JS error: 'Module not found: watchstar'" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88673 (owner: 10Jdlrobson) [18:27:47] (03PS2) 10Jdlrobson: Fix watchlist scripts dependency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88673 [18:29:46] (03CR) 10Kaldari: [C: 032] Fix watchlist scripts dependency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88673 (owner: 10Jdlrobson) [18:30:10] (03Merged) 10jenkins-bot: Fix watchlist scripts dependency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88673 (owner: 10Jdlrobson) [18:33:01] jcmich: So I had selenium working on Tuesday. I swear I didn't change anything, but now it says 'Could not locate Gemfile' when I try to run bundle exec cucumber. Any idea what that means? [18:34:20] (03PS1) 10Brion VIBBER: Repeated pinch zoom caused image to annoyingly jump back to center. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88774 [18:34:21] (03PS1) 10Brion VIBBER: Size image to fit screen more precisely on details view. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88775 [18:34:22] more merges \o/ [18:34:23] (03PS1) 10Brion VIBBER: Fixes for details fullscreen toggle. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88776 [18:34:23] (03PS1) 10Brion VIBBER: Fix for darkening area above details slider not extending far enough. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88777 [18:34:24] jcmich: the only thing I did since then was a gerrit pull [18:34:24] (03PS1) 10Brion VIBBER: Removed fairly un-noticeable fade transition. My Uploads now snappier. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88778 [18:34:25] (03PS1) 10Brion VIBBER: Improvements to details slider rotation positioning. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88779 [18:34:26] (03PS1) 10Brion VIBBER: Made debug mode actually work on release builds. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88780 [18:34:27] (03PS1) 10Brion VIBBER: Added double-tap image zoom & two finger tap zoom out. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88781 [18:34:28] (03PS1) 10Brion VIBBER: Made details image scale from aspect fit to aspect fill upon loading. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88782 [18:34:29] (03PS1) 10Brion VIBBER: Increased login text boxes height. Tweaks to login autolayout. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88783 [18:34:30] (03PS1) 10Brion VIBBER: Made settings, attribution and getting started icons consistent. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88784 [18:34:31] sorry for the spam :D [18:34:43] that Brion! [18:36:10] I tried 'gem update --system' but no luck [18:37:09] any Ruby developers in here? [18:37:30] there are no rubys for you [18:37:40] I need rubies! [18:38:02] actually I need gems apparently [18:38:11] I'm not picky [18:38:13] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Nice improvement to the icons :D" [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88784 (owner: 10Brion VIBBER) [18:38:30] agh i've got em in the wrong order, lemme start at the other end :) [18:39:29] (03CR) 10Brion VIBBER: [C: 032 V: 032] Repeated pinch zoom caused image to annoyingly jump back to center. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88774 (owner: 10Brion VIBBER) [18:39:45] jcmish: "QA/Design Acceptance Review" has no room reservation [18:40:08] argh [18:40:30] which rooms do I want again? [18:40:42] R31,R34,R35,R37 [18:41:00] (03CR) 10Brion VIBBER: [C: 032 V: 032] Size image to fit screen more precisely on details view. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88775 (owner: 10Brion VIBBER) [18:41:27] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fixes for details fullscreen toggle. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88776 (owner: 10Brion VIBBER) [18:43:14] (03CR) 10Kaldari: [C: 032] Rename watch event to watched [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88676 (owner: 10Jdlrobson) [18:43:31] jdlrobson: Thanks for fixing that tricky Firefox bug! [18:43:41] (03Merged) 10jenkins-bot: Rename watch event to watched [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88676 (owner: 10Jdlrobson) [18:44:08] kaldari: we've had that one before. it's nasty like the honey badger [18:44:18] not sure if it's a jQuery bug or something we should protect again [18:44:18] ack [18:44:59] no honey badgers in the mobile site! [18:45:29] yeah, it seems like jQuery should have some better error handling there [18:45:50] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix for darkening area above details slider not extending far enough. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88777 (owner: 10Brion VIBBER) [18:46:10] (03CR) 10Brion VIBBER: [C: 032 V: 032] Removed fairly un-noticeable fade transition. My Uploads now snappier. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88778 (owner: 10Brion VIBBER) [18:55:05] (03PS2) 10Kaldari: Need to mention MediaWiki path setting as well for Selenium [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88769 [18:59:49] greg-g: do you know if you guys will need R31 for your 12 - 1 ? [19:00:02] i've only seen Quim in the office [19:00:11] and michelle and i are hunting for a room [19:06:18] brion: when u have a sec... [19:06:24] moment [19:06:56] (03CR) 10Brion VIBBER: [C: 032 V: 032] Improvements to details slider rotation positioning. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88779 (owner: 10Brion VIBBER) [19:12:17] tfinc: sorry, using :/ [19:12:28] greg-g: thats fine. were just doing it at our desks [19:12:35] i appreciate you getting back to me though [19:13:10] http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:UserProfile/Testken [19:18:19] (03CR) 10JGonera: [C: 032] Hygiene: Standardise on MEDIAWIKI_URL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87640 (owner: 10Jdlrobson) [19:18:43] (03Merged) 10jenkins-bot: Hygiene: Standardise on MEDIAWIKI_URL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87640 (owner: 10Jdlrobson) [19:19:08] jgonera: i've found a problem with our back behavior implementation.. [19:19:17] jdlrobson, what is it? [19:19:28] doesn't seem to work with an overlay within an overlay [19:19:32] (03CR) 10Brion VIBBER: [C: 032 V: 032] Made debug mode actually work on release builds. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88780 (owner: 10Brion VIBBER) [19:19:33] i'll submit my code so you can see [19:20:48] jdlrobson, the keep going stuff is beta only? [19:20:56] (03PS1) 10Jdlrobson: Hygiene: Separate out NearbyOverlay.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88795 [19:20:57] (03PS1) 10Jdlrobson: Add back button support to nearby overlay (geonotahack) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88796 [19:20:59] jgonera: correct [19:21:16] (03CR) 10Brion VIBBER: [C: 032 V: 032] Added double-tap image zoom & two finger tap zoom out. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88781 (owner: 10Brion VIBBER) [19:21:19] ^ jgonera that's the patch set - back button not quite working as i expected. am i doing it wrong? [19:21:42] (03CR) 10Brion VIBBER: [C: 032 V: 032] "pretty :D" [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88782 (owner: 10Brion VIBBER) [19:22:15] ok, jdlrobson will have a look at it later [19:22:39] (03CR) 10Brion VIBBER: [C: 032 V: 032] Increased login text boxes height. Tweaks to login autolayout. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88783 (owner: 10Brion VIBBER) [19:23:16] aaaand.... i have to push 'submit' on all those again, cause i forgot this module doesn't have jenkins autosubmitting [19:23:17] yayyyy [19:25:06] (03CR) 10Jdlrobson: [C: 04-1] "After loading a preview I can't seem to escape the overlay. Juliusz any ideas?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88796 (owner: 10Jdlrobson) [19:29:39] (03PS8) 10Kaldari: Preparing the LastModified code for Mingle cards 1262 and 1258 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 [19:35:57] (03CR) 10JGonera: [C: 04-1] "(8 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87426 (owner: 10Jdlrobson) [19:44:38] welcome back jcmish [19:44:47] woohoo [19:45:05] jcmish: you can find LimeChat in the app store. its free [19:45:19] yup i'm downloading it as we speak! [19:45:29] YuviNoPower: turned me onto it [19:45:49] i especially like the lower window which allows you to watch all other channels your joined [19:45:55] its weird at first but then its really useful [19:47:13] (03CR) 10Siebrand: [C: 04-1] "Per comment on PS1, repeated by Juju." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87426 (owner: 10Jdlrobson) [19:47:50] YuviNoPower: we had no water yesterday! [19:48:18] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 (owner: 10Kaldari) [19:49:03] tfinc: when I'm on a shared workspace they have a bunch of firewall rules [19:49:12] so I can't use adium [19:51:02] hey tfinc [19:51:12] YuviPanda: how are those wrists ? [19:51:20] YuviPanda: Sue was worried about you [19:51:35] tfinc: terrible. [19:51:44] tfinc: but better than before. [19:51:46] yuvipanda: oh no! [19:51:54] tfinc: am one more potent painkillers. seem to be working. [19:51:59] YuviPanda: then i hope your using voice transcription right now [19:52:05] tfinc: yeah, saw the email. Put a smile on my face :) [19:52:09] YuviPanda: thats not a good direction [19:52:10] tfinc: using one hand [19:52:25] YuviPanda: if your up for it respond on the thread with Gayle and Lynette [19:52:52] will do tomorrow [19:53:03] rfarrand: it is terrible [19:53:16] brion: do you need YuviPanda to look at any patch sets ? [19:53:34] tfinc: getting more tests done. Should hopefully be able to avoid surgery. [19:53:53] yuvipanda: hire an intern to type everything for you [19:53:55] YuviPanda: good. surgery is such an aggressive solution [19:54:11] rfarrand: they are all too slow :) [19:54:53] tfinc: yeah. Need to agressively look at workspace changes. Might need to put the 'nomad' lifestyle on hold [19:57:13] YuviPanda rest up dude! [19:57:17] (03CR) 10MaxSem: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 (owner: 10Kaldari) [19:57:25] brion: yeah, will do in a couple of mins [19:58:55] awjr_lunch, story review has no hangout [19:59:21] try now MaxSem [19:59:59] still nope [20:00:03] :| [20:00:39] i have now added one three times but it still does not appear… [20:02:28] wtf [20:02:48] awjr: we don't see an invite [20:02:52] @_@ [20:02:55] err [20:02:56] hangout [20:03:00] oh [20:03:01] yeah tfinc [20:03:03] working on it [20:03:10] tfinc https://plus.google.com/hangouts/_/b849663dc3dd8ebdcd0a312c29da4dbe525c3833?authuser=1&hl=en [20:03:23] jcmish: ^ [20:03:23] YuviPanda: If it's too slow, you can scale horizontally and scale out that way ;-) [20:03:33] awjr: just mailed kenanwang the link [20:03:35] ha [20:03:36] k thanks [20:03:36] parallel typing, a new trend. [20:03:48] tfinc: cool thanks, i added it to the description on the invite as ewll [20:03:49] awjr: quick. look professional ... rob moen is here [20:03:52] i'llbe there in a minute need to run to the restroom [20:03:54] :) [20:04:02] i dunno why the hangout link is not showing up as usual in the invite :( [20:04:10] i've tried adding it a bunch of times but it doesn't seem to 'stick' [20:04:13] sigh. [20:04:14] Krinkle: heh, will just be a massive coordination problem [20:08:44] jgonera: https://meta.wikimedia.org/wiki/Research:Mobile_editor_engagement/Tutorial_test#Visual_design [20:09:56] I'm off again. [20:24:23] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88681 (owner: 10Kaldari) [20:27:44] YuviPanda|sick: are all your flights booked ? [20:28:48] (03CR) 10Kaldari: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88681 (owner: 10Kaldari) [20:35:52] (03CR) 10Siebrand: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87440 (owner: 10MaxSem) [20:39:07] (03PS1) 10Brion VIBBER: bump to 1.0beta12 [apps/android/commons] - 10https://gerrit.wikimedia.org/r/88873 [20:39:22] (03CR) 10Brion VIBBER: [C: 032 V: 032] bump to 1.0beta12 [apps/android/commons] - 10https://gerrit.wikimedia.org/r/88873 (owner: 10Brion VIBBER) [20:43:13] (03CR) 10Siebrand: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88681 (owner: 10Kaldari) [20:48:52] (03PS1) 10Brion VIBBER: Made license selection no longer automatically show up in categories. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88874 [20:48:53] (03PS1) 10Brion VIBBER: Made keystrokes to title enable upload button if description not blank. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88875 [20:48:54] (03PS1) 10Brion VIBBER: Fix for gallery picker status bar being incorrectly transparent. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88876 [20:48:55] (03PS1) 10Brion VIBBER: Fix for weird storyboard inconsistency. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88877 [20:48:56] (03PS1) 10Brion VIBBER: Fix for untitled images appearing out of order. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88878 [20:49:02] mhurd's been busy today :D [20:50:15] (03CR) 10Brion VIBBER: [C: 032 V: 032] Made license selection no longer automatically show up in categories. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88874 (owner: 10Brion VIBBER) [20:50:19] brion: mhurd YuviPanda|sick : how are our releases looking ? [20:50:38] tfinc: I'm ready to pull the trigger on Android (unless YuviPanda|sick wants to test it first) [20:50:47] tidying up monte's last iOS commits now [20:50:50] YuviPanda|sick: is out so its up to you [20:50:51] then ready to push to testflight [20:51:00] ok [20:51:40] (03CR) 10Brion VIBBER: [C: 032 V: 032] Made keystrokes to title enable upload button if description not blank. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88875 (owner: 10Brion VIBBER) [20:53:44] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix for gallery picker status bar being incorrectly transparent. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88876 (owner: 10Brion VIBBER) [20:54:26] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix for weird storyboard inconsistency. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88877 (owner: 10Brion VIBBER) [20:55:16] (03CR) 10Brion VIBBER: [C: 032 V: 032] "seems to work :D" [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88878 (owner: 10Brion VIBBER) [20:56:51] ok now to bump the version number [20:57:38] (03PS1) 10Brion VIBBER: Bump to version 1.0.8 [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88879 [20:57:54] (03CR) 10Brion VIBBER: [C: 032 V: 032] Bump to version 1.0.8 [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88879 (owner: 10Brion VIBBER) [20:58:02] * brion slaps self [20:58:05] that should be ... to 1.0.9 [20:58:06] oh well :D [20:59:16] (03CR) 10Brion VIBBER: "oops that shoulda said 1.0.9. oh wells" [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88879 (owner: 10Brion VIBBER) [21:00:52] running to pick up the kidlet [21:01:22] Nick/jcmish_picking_up_son [21:20:05] ok android build is uploaded to download.wikimedia.org, i'll push it to google play in a bit [21:20:11] now to make a test flight build for ios [21:21:19] kaldari: awjr MaxSem we need to pick a task for our backend candidates [21:21:30] can we re-use anything that we have ? [21:22:12] I already raised this question before, but it went silent [21:22:35] the generalist task can probably be used, but might need tweaks [21:22:36] awjr: kaldari --^ [21:23:06] kaldari: i'm eager to hear from you as this position will be closest to yours and you'll be doing the tech screen [21:23:08] hmm i forget what tasks we had before [21:23:13] lemme go back and look [21:23:51] MaxSem: do you remember where the tasks are recorded? [21:24:17] or tfinc ^ [21:26:00] asking emily now for the list [21:26:25] grr [21:26:33] can't find it on officewiki [21:26:44] i couldn't find them [21:26:45] yeah i couldnt find it either:( [21:26:49] tfinc: What's the generalist task? [21:27:25] connect four [21:29:09] brion: i just saw "Commons 1.0.9 (1.0.9)" is now available in my inbox :) [21:30:01] :D [21:32:32] (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88796 (owner: 10Jdlrobson) [21:34:12] (03CR) 10JGonera: [C: 032] Hygiene: Separate out NearbyOverlay.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88795 (owner: 10Jdlrobson) [21:34:40] (03Merged) 10jenkins-bot: Hygiene: Separate out NearbyOverlay.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88795 (owner: 10Jdlrobson) [21:43:52] (03PS1) 10Mhurd: Yay! [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88886 [21:44:29] (03CR) 10Jdlrobson: [C: 04-1] "(4 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 (owner: 10Kaldari) [21:45:46] (03CR) 10JGonera: [C: 04-1] "(4 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88248 (owner: 10Jdlrobson) [21:48:47] (03CR) 10Kaldari: "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 (owner: 10Kaldari) [21:52:57] (03CR) 10Kaldari: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88681 (owner: 10Kaldari) [22:00:58] (03PS1) 10JGonera: Add support for back button in nested overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88887 [22:06:31] (03CR) 10Brion VIBBER: [C: 04-2] "NNOOOOOOOO" [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88886 (owner: 10Mhurd) [22:09:57] (03PS5) 10Jdlrobson: Story 1072 (1/2): KeepGoing CTA [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87426 [22:10:49] jcmish: I think this is just a typo: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/lastCompletedBuild/testReport/ [22:11:15] jcmish: two more mobile builds behind it [22:11:22] chrismcmahon: I'm looking at this [22:12:08] jcmish: shout if you need a hand [22:12:21] ou betcha thanks! chrismcmahon [22:12:29] (03PS6) 10Jdlrobson: Story 1072 (1/2): KeepGoing CTA [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87426 [22:12:37] jcmish: I fixed about a gazillion VE tests today, they're the last to run, behind Mobile [22:13:33] Unable to pick a platform for the provided browser (RuntimeError) ./features/step_definitions/watchlist_steps.rb:28:in `/^I am logged i [22:13:35] chrismcmahon: [22:13:37] ? [22:14:01] it's not the generic issue correct? [22:15:31] jcmish: aw crap [22:16:03] :) chrismcmahon that's what I thought so yeah can you double check me by eyeballing it [22:16:25] jcmish: in https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/lastCompletedBuild/testReport/(root)/Footer%20links%20resolve/View_Edit_history_link_resolves/ I see a timeout seems to be going to the wrong page '/Main' instead of 'Main' [22:17:10] tfinc, emailed about the task [22:17:14] jcmish: wrong base url at https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/lastCompletedBuild/testReport/(root)/Feature_%20Footer%20links%20resolve%20-%20Logged%20In/View_Edit_history_link_resolves/ looks like [22:17:18] yup [22:17:18] MaxSem: thanks [22:17:24] hey jdlrobson ^ [22:17:37] is this because of the MEDIAWIKI_URL changes you put in? [22:18:04] jcmish: possibly. I'm not sure how you use MEDIAWIKI_URL but it should be in the form export MEDIAWIKI_URL=http://localhost.m/w/index.php [22:18:25] for beta labs http://en.wikipedia.beta.wmflabs.org/wiki [22:18:48] jdlrobson: no, http://en.m.wikipedia.beta.wmflabs.org/wiki/ [22:19:04] jcmish: ^^ [22:19:12] chrismcmahon: it needs updating then :) [22:19:19] right was typing that chrismcmahon [22:19:48] jdlrobson: MEDIAWIKI_URL is everything to the right of the actual page you want [22:19:56] jdlrobson: argh, everything to the left [22:22:56] chrismcmahon:well originally it was being used as the host in MobileFrontend e.g. http://127.0.0.1:80 omitting the forward slash makes it easier to concatenate with other variables e.g. wget "$URL/$TITLE?useformat=mobile" -O tmp/cached.html [22:23:49] arguably we could do $URL$TITLE but imo is less easy to grep [22:24:32] if it's problematic for qa we can rethink it [22:26:52] jdlrobson: look at any of the dozens of files in /features/support/pages in any of the repos and I think you'll see why MEDIAWIKI_URL ends with a slash. [22:29:20] jdlrobson: I'd like to have someone walk you through the design pattern 'page object' for these tests, I think it would be enlightening. If you have the patience you can follow http://www.youtube.com/watch?v=0dg6B5i0RM8, the good part starts around 42 minutes in. [22:29:29] (03PS1) 10Jdlrobson: Hygiene: Minor Resource Loader modules hygiene fix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88890 [22:32:46] chrismcmahon: well the thing that was problematic was MEDIAWIKI_URL was previously defined in MobileFrontend as meaning something else - just the host url. As far as I understand it QA adopted this and gave it a different meaning which has caused issues in MobileFrontend's development. The goal was to standardize on one that could be used in QA and for mobile as well. I don't mind what we standardize on as long as we use the same thing [22:33:33] (03PS1) 10Jdlrobson: Standardise (again) on MEDIAWIKI_URL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88892 [22:33:34] ^ chrismcmahon [22:33:36] ^ jgonera [22:33:51] jdlrobson: ha, that's the first I've heard that it MEDIAWIKI_URL was already in use. that was one of the first things we did, long before we wrote the first Mobile browser test [22:34:08] sorry folks had to walk away and get Dimi started on his homework [22:34:26] jdlrobson: nice coincidence is all I'm afraid [22:34:56] seems to be an issue with this patch set [22:35:00] (03CR) 10JGonera: [C: 04-1] Standardise (again) on MEDIAWIKI_URL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88892 (owner: 10Jdlrobson) [22:37:19] chrismcmahon: we've had it since https://gerrit.wikimedia.org/r/#/c/39346/ - so just to double check the value of it in https://gerrit.wikimedia.org/r/88892 is correct? [22:38:40] (03PS2) 10Jdlrobson: Standardise (again) on MEDIAWIKI_URL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88892 [22:38:53]