[00:06:08] jcmish++ [00:34:39] (03PS2) 10Jdlrobson: Add GENDER to message to make things clearer for translators [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88905 (owner: 10MaxSem) [00:35:06] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88905 (owner: 10MaxSem) [00:51:19] (03PS2) 10Jdlrobson: Add back button support to nearby overlay and preview overlays (geonotahack) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88796 [00:51:19] (03PS1) 10Jdlrobson: Story 1264: Promote Geo(not a)Hack to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88912 [00:51:21] (03PS1) 10Jdlrobson: Story 1264 (2/2): Add click tracking to nearby page and geo(nota)hack overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88913 [07:38:14] (03CR) 10Siebrand: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87440 (owner: 10MaxSem) [07:40:54] (03CR) 10Siebrand: [C: 032] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88905 (owner: 10MaxSem) [07:41:22] (03Merged) 10jenkins-bot: i18n: Add GENDER to message to make things clearer for translators [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88905 (owner: 10MaxSem) [10:19:32] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87426 (owner: 10Jdlrobson) [10:27:03] (03CR) 10Siebrand: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88681 (owner: 10Kaldari) [13:44:10] (03PS2) 10Cmcmahon: QA-Added option to keep browser option for debugging to match the browsertests project [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88689 (owner: 10Mgrover) [13:44:30] (03CR) 10Cmcmahon: [C: 032] "coming soon to a gem near you" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88689 (owner: 10Mgrover) [13:45:00] (03Merged) 10jenkins-bot: QA-Added option to keep browser option for debugging to match the browsertests project [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88689 (owner: 10Mgrover) [14:54:31] (03CR) 10Yurik: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87252 (owner: 10MaxSem) [16:21:25] tfinc: http://etherpad.wikimedia.org/p/ScrummasterMeetup-2013-10-10 [16:21:29] awjr: thanks [16:23:27] tfinc we're chatting about 'Hopes/concerns about scrum of scrums' [16:23:36] awjr: ok [16:49:24] (03CR) 10Jdlrobson: [C: 031] Renamed tests/acceptance folder to tests/browser [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87565 (owner: 10Zfilipin) [16:51:00] (03PS3) 10Jdlrobson: Standardise (again) on MEDIAWIKI_URL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88892 [16:52:18] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87565 (owner: 10Zfilipin) [17:04:47] awjr: i'm not seeing bugs cut into the commons app bugzilla show up in trello. is the bot not running ? [17:06:57] tfinc: huh [17:07:07] it should be but im not positive [17:07:21] it looks like they're coming in to mingle... [17:07:27] tfinc: i'll take a look shortly [17:07:43] yeah, i just cut 5+ bugs but i'm not seeing them [17:08:23] there they are [17:09:01] ahah [17:09:16] i forget the frequency that bugello runs - i think every 5 mins [17:10:31] local-bugello@tools-login:~$ crontab -l [17:10:32] */5 * * * * /usr/local/bin/jsub -once -N bugello /data/project/bugello/bin/bugello_app [17:10:34] tfinc ^ [17:10:50] ahh ok [17:11:21] so i guess theoretically it could take almost 10 mins for things to show up, assuming bugzilla and trello respond near instantly [17:11:52] wait that makes no sense [17:11:55] almost 5 minutes [17:11:55] thats fine as long as i know that its running [17:11:57] i need more coffee. [17:12:11] i wonder how we would think if it reported those posts in irc too [17:12:14] 9 am meetings are too early [17:12:20] awjr: they seriously are [17:12:27] but 9pm meetings suck too [17:12:33] yeah, way worse [17:12:44] the best is the 12am daily standup for the language team [17:12:54] yuck [17:13:02] brion: yo [17:13:10] yo [17:13:11] tfinc didnt we used to have a bot reporting bugs in IRC as they came in to bugzilla? [17:13:24] brion: did android make it our yesterday ? i didn't see an update on my phone [17:13:25] or were you thinking of bugello saying 'hey, just added to bug cards!' [17:13:29] lemme check [17:13:32] s/to/two [17:14:03] awjr: latter but now that i think about it i prefer the stand up as it includes everyone rather then irc which includes only those that are online at a particular time [17:14:22] and by standup i mean the time/indication of when you triage [17:15:19] todays fun responsive design. http://mario.ign.com/ . its not going to work for speed as it slows down chrome on my nexus4 to a crawl but it is visually pleasant to use on a desktop [17:15:32] jdlrobson: kaldari --^ [17:16:28] nice [17:19:40] tfinc: i see the updated version listed at https://play.google.com/store/apps/details?id=org.wikimedia.commons [17:20:17] brion: i wonder if it snuck in with other updates on my phone and wasnt listed in my status bar [17:20:20] * tfinc goes to check version [17:20:24] heh [17:20:29] or if you had a dev version it might not have updated [17:20:52] brion: now its crashing on startup [17:20:53] not good [17:20:57] baaaah [17:21:16] email me the crash report :D [17:21:24] sent [17:26:53] brion: bug report is on mobile-tech now [17:27:02] tx [17:27:15] Caused by: org.xml.sax.SAXParseException: Unexpected token (position:TEXT This version of ...@3:1 in java.io.InputStreamReader@41eaddd0) [17:27:53] curious... [17:28:54] tfinc: you're not on the latest version [17:28:57] APP_VERSION_NAME=1.0beta10 [17:29:29] brion: ^ [17:29:34] tfinc: and yes, travel's all booked [17:29:35] hmm [17:30:01] brion: we're at what, beta12? [17:30:08] should be beta12 yeah [17:30:09] * YuviPanda has a makeshift standing desk now [17:30:15] lemme triple-check i didn't break the build number [17:30:57] 22:59 YuviPanda: tfinc: and yes, travel's all booked [17:31:04] now i know it worked the other day. given that its a dev built -> product i'm going to re-install [17:31:35] wfm on my s4 tfinc, brion [17:31:45] (fresh install) [17:32:19] actually that reminds me [17:32:38] YuviPanda: i think sometimes i've seen it pop up old crash reports, might it be doing this here? [17:33:06] brion: well, this happens when we send a malformed request to the API and it just returns text [17:33:14] yeah [17:33:25] i wonder if we can add timestamps to those crash reports [17:33:46] ok i did a fresh install from google play and it's def claiming to be beta12 [17:50:20] (03CR) 10Jdlrobson: [C: 04-1] "(4 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88899 (owner: 10JGonera) [17:51:05] mmm, java. [17:51:42] mmm, java :( [17:52:49] This version of MobileFrontend requires MediaWiki 1.22, you have 1.22wmf21 [17:52:57] * aude wonders what i'm doing wrong? [17:54:00] brion: did campaigns make it into this market release ? [17:54:11] nope, tfinc. [17:54:15] they're on a separate branch [17:54:51] they have to make it into our next release in two weeks [17:55:00] i was expecting them to land in this one [17:55:10] aude: that is weird [17:55:28] (03PS1) 10Mhurd: Consistent nav button and text shadows between iOS 6 and 7. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/89030 [17:55:29] ok [17:56:10] i think it should be something like "if ( version_compare( $wgVersion, '1.21c', '<' ) ) {" [17:56:23] not 1.22 < [17:56:32] or i am confused? [17:56:35] aude: wait… i dont htink there is a 1.22wmf21, is there? [17:57:01] oh, that's what's being cut today [17:57:05] * awjr git pulls [17:57:06] yes [17:57:33] wikibase requires mediawiki 1.21 or higher [17:57:44] so we have "if ( version_compare( $GLOBALS['wgVersion'], '1.20c', '<' ) ) { " [17:58:31] (03CR) 10JGonera: [C: 032] Standardise (again) on MEDIAWIKI_URL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88892 (owner: 10Jdlrobson) [17:58:57] (03Merged) 10jenkins-bot: Standardise (again) on MEDIAWIKI_URL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88892 (owner: 10Jdlrobson) [18:00:18] ah crap i just hosed my local instance [18:00:36] it might be a problem for deployment [18:00:40] aude: i have to run to a meeting [18:00:43] Max [18:00:46] oh max isn't around [18:00:53] meeting can wait, let me dig into this [18:00:56] ok [18:01:09] awjr: use vagrant! :P [18:01:09] i don't know if Reedy ran into this yet or maybe it is just me [18:01:24] YuviPanda: brion https://trello.com/b/2cUtayOd/mobile-app-backlog currently has zero android storys ready for the next sprint [18:01:34] i'm sure thats not accuate [18:01:40] jdlrobson: kenanwang i'm going to be a bit late to the mtg, but i should be there shorlty [18:01:53] k [18:02:37] tfinc: there'll be some carry-over from this one, I think. I've mostly done server-side work this sprint, rather than Android work (other than reviews). I'll move cards accordingly in about 5 min [18:02:58] awjr: the version compare thing could just be removed for now [18:03:03] until someone can look into it [18:03:07] YuviPanda: thanks [18:04:00] aude: yeah, im taking a quick look now [18:04:07] k [18:04:20] @_@ betalabs appears broken [18:04:34] awjr: scheduled NFS upgrade [18:04:43] was on labs-l [18:04:45] :( [18:04:51] but okay [18:05:08] ah [18:05:14] that's also why grrit-wm is dead [18:06:25] jgonera: are you joining [18:06:48] to stop searchapocalypse [18:07:45] tfinc: i'll go through it :) [18:08:21] mhurd: brion: YuviPanda: heads up that our estimation/prioritization meeting is at 12 today [18:08:28] *nod* [18:08:35] tfinc: sounds good [18:08:41] aude: so locally, it appears to work ok for me with $wgVersion = 1.22wmf21 [18:08:48] tfinc: i owe u lunch [18:08:49] and thankfully http://hat.jit.su/86257 is up :) [18:08:50] huh [18:08:59] it's my branch name [18:09:03] local branch [18:09:04] mhurd: yup. so does kenanwang and marktraceur [18:09:09] i should start charging interest [18:09:20] tfinc: eat all 3 lunches today [18:09:20] does it consider branch name? [18:09:40] aude: no, it should just consider the value in $wgVersion [18:09:44] awjr: can i get a bot in here to collect $$ from people who owe me ? a breaking knee caps bot? [18:10:01] ! [18:10:11] i dont see why not, tfinc [18:10:22] awjr: hmmm [18:10:25] !pay up [18:10:26] :D [18:10:28] aude: what is your $wgVersion? [18:10:49] one sec [18:11:12] brion: what are you working on today relative to https://trello.com/b/XkdTvW0Z/mobile-app-sprint-16 ? [18:11:42] tfinc: You trippin', why do I owe you lunch....oh, right, JapaCurry [18:11:45] i don't see anythign in the doing column for you [18:11:47] at the moment i'm looking at the backlog for next sprint [18:11:51] Luckily they're back today [18:12:15] marktraceur: i have to be back by 12 if you want to go early [18:12:25] Hm, maybe [18:12:29] awjr: 1.22wmf21 [18:12:35] I finished breakfast roughly 30 minutes ago, but it was a really slow breakfast [18:12:46] let me know. i'm going to go early for food regardless [18:12:47] ... [18:12:53] mhurd should come with me as he's in the same meeting [18:13:01] tfinc: ya! [18:13:02] tfinc: Drag me off when yer ready [18:13:29] * aude tries master [18:14:44] aude i am fairly certain it was working in betalabs as tests were passing there after that change was merged, so it should be OK [18:15:12] on master, i think it worked [18:15:28] but then i checked out wmf/1.22wmf21 and updated all submodules [18:15:47] could be just some weirdness that i have [18:16:16] hmm looks like changes haven't been synced out to the testwikis yet [18:16:54] not yet [18:17:02] should be soon [18:17:03] aude: since i can't replicate the problem, im going to not worry about it right now, we'll know if it's broken when things get pushed out to the testwikis - it should be an easy enough thing to fix if it causes problems [18:17:13] agree [18:17:15] im gonna run to my mtg, thanks for bringing it up though - i'll keep an eye out [18:17:17] ok [18:17:33] jdlrobson, kenanwang is there a hangout for the meeting? [18:17:38] master works for me [18:17:42] i dont see one on the calendar [18:18:31] nm jdlrobson, kenanwang saw the update in my email [18:19:35] mhurd: did you see the bug report about copy/paste not working in the input fields? [18:19:46] i suspect one of the gesture recognizers is eating the presses :( [18:22:51] brion: ya! [18:22:57] brion: can fix :) [18:23:05] woohoo [18:23:40] brion: did gerrit 1st review [18:23:48] ooooh [18:23:54] brion: er… "git review" [18:24:31] brion: patch to make nav text & buttons more consistent between 6 & 7 [18:24:47] brion: working on that weird refresh control bug now. [18:24:52] awesome [18:25:05] brion: i think it's auto layout related... [18:30:22] uh: https://www.mediawiki.org/wiki/API:Query [18:31:07] aude: You were right [18:31:07] This version of MobileFrontend requires MediaWiki 1.22, you have 1.22wmf21. You can download a more appropriate version from https://www.mediawiki.org/wiki/Special:ExtensionDistributor/MobileFrontend [18:31:09] aude: you were right [18:31:10] DAMN YOU MOBILE TEAM [18:31:12] jinx Reedy [18:31:29] let's just back the change out [18:31:30] i can make a patch [18:31:45] quite sure it's what i suggest or just remove it for now [18:31:53] let's just remove it [18:31:57] k [18:31:59] we can fix it later, it's not really important [18:32:02] one sec [18:32:04] thnx [18:33:07] actually aude i can just revert max's change [18:33:30] aude, Reedy: https://gerrit.wikimedia.org/r/#/c/89038/ [18:33:50] https://gerrit.wikimedia.org/r/#/c/89039/ [18:33:56] oh, ok [18:33:58] :) [18:34:03] hehe jinx [18:34:10] i don't care [18:34:14] yay version comparisons [18:34:19] Reedy: feel free to merge one of those [18:35:13] tfinc: so we found the cause of your mystery crash ^ [18:35:24] a bad version comparison in MobileFrontend, of all things :D [18:35:32] however that definitely indicates we have... insufficient error handling int he app [18:36:32] Reedy: i self merged the revert, that shoudl resolve the problem [18:38:41] aude you were totally right, sorry about that - i dont know why i wasnt able to replicate locally... [18:38:48] thanks for catching it :) [18:39:35] https://gerrit.wikimedia.org/r/#/c/89040/ [18:39:43] when someone wants to readd it [18:39:46] no hurry [18:40:17] aude: what does 'c' signify? [18:40:27] * awjr reads docs on version_compare [18:41:34] I wouldn't bother, it's vastly broken [18:41:38] so from the docs, the way it was previously seems like it *should* work... [18:41:43] i dont see anything about 'c' [18:41:51] Reedy: you mean version_compare() in general? [18:41:59] indeed [18:42:07] >_< [18:42:12] honest, not 100% sure but "Needs to be 1.20c because version_compare() works in confusing ways." [18:42:16] when it comes to wikibase :) [18:42:21] says the comments [18:42:30] in case of mobile, 1.21c [18:43:27] brion: MobileFrontend is throwing errors on all API requests? [18:43:57] sigh [18:43:59] YuviPanda: at least some, but i believe they fixed it now [18:44:04] brion: ok [18:44:39] futzing around in php cli, c does indeed seem to work aude [18:45:24] awjr: ok :) [18:48:30] https://gerrit.wikimedia.org/r/89043 [18:48:34] Wrong paste [18:48:57] Everything is broken again [18:49:11] wtf [18:49:13] ? [18:49:27] sure you updated the submodules? [18:49:38] commit 1b482672686aafc098d73ff128195d5e2a4ddb69 [18:49:39] Merge: 7fa78eb 0aa054b [18:49:39] Author: jenkins-bot [18:49:39] Date: Thu Oct 10 18:36:24 2013 +0000 [18:49:39] Merge "Revert "Fail gracefully if people are using older MW"" [18:49:47] hmmmm [18:49:51] o_O [18:49:55] Oh, I wonder [18:49:56] Reedy: cache? [18:49:59] * Reedy touches everything [18:50:08] * YuviPanda takes Reedy to arbcom [18:50:26] lulz [18:53:54] confirm it works on my test wiki [18:54:13] test2 looks better :) [18:54:18] oh shit aude i see why i couldn't replicate locally, im an idiot [18:54:24] heh [18:54:26] yeah, issue is fixed in prod :) [18:54:27] it happens [18:55:02] aude: i didnt want to wait to update all the submodules so i just manually forced $wgVersion at the end of my localsettings but of course the version_compare was happning before my override :p [18:55:22] oh, ok [18:55:45] this is why we have the test wikis [18:56:07] :) [18:56:25] jdlrobson: i've been quite distracted - have you guys been captruing the acceptance criteria somewhere? [18:57:09] jgonera: ^ [18:59:10] kaity: ^^ [19:00:22] brion: can't get into hangout [19:00:24] tfinc: ^ [19:00:40] :( [19:01:10] 'You aren't allowed to join this video call. ' [19:01:14] bloody hell [19:01:16] "You're not allowed to join this video call." [19:01:18] yeah same [19:01:24] heh, not just me then [19:01:27] that happened to me earlier :( [19:01:51] worked when i tried in a different browser [19:02:18] awjr: always works for me incognito, not there today [19:02:25] lemme try logging out and back in [19:02:31] this is in chrome where i'm only logged in as work account [19:02:36] it's the one that usually works [19:03:14] "You're not allowed to join this video call." [19:03:29] same here [19:03:29] no dice in firefox either [19:03:32] let me do one adhoc [19:03:35] i guess we make a new one ... [19:03:42] cloud services! [19:03:46] the future is now :) [19:04:07] heh [19:04:12] yeah no luck in FF too [19:04:14] https://plus.google.com/hangouts/_/7c8eba9a1e09def8f2fa9304bf87ec6431b136e2?hl=en [19:04:25] dude [19:04:28] version_compare() makes no sense [19:04:51] yay i'm in [19:09:32] gerrit-wm i miss you [19:09:41] aude i had to −1 that patchset [19:09:55] awjr: acceptance criteria being generated yes [19:09:59] what's going on in deployment? [19:10:09] jdlrobson: thanks :) [19:10:11] jdlrobson: it's fixed now [19:10:15] awjr: what was the problem? [19:10:26] jdlrobson: the introduction of version_compare() [19:10:37] the way we were doing it caused breakage everywhere [19:10:38] see v [19:10:38] brion: mhurd YuviPanda http://hat.jit.su/86257 [19:10:39] er [19:10:40] https://gerrit.wikimedia.org/r/#/c/89038/ [19:10:42] jdlrobson: ^ [19:11:46] jdlrobson: aude caught it earlier but i couldn't replicate so i let it go out broken :( [19:11:51] but easy fix. [19:13:40] ahh so what was wrong with that fix? is someone doing a follow up? [19:13:52] or at least raising a bug capturing why it was introduced? [19:14:03] jdlrobson: we're figuring it out; version_compare() works in mysterious ways [19:14:12] jdlrobson: https://gerrit.wikimedia.org/r/#/c/89040/ [19:14:19] awjr: hmmm [19:14:32] * aude testing version compare [19:14:35] ok can i leave it with you to either raise that bug or fix it ? :) i'd hate us to keep responding to people asking why their MF doesn't work [19:14:45] jdlrobson: yes, i want to just get it fixed. [19:14:53] awjr: sweet i'll leave that with you then ;-) [19:14:55] :) [19:15:04] version_compare() is totally evil though :( [19:16:02] aude: i've tried a bunch of different approaches with version_compare() and results are unexpeted [19:16:24] for instance: [19:16:25] php > echo version_compare( '1.22bar', '1.22a', '<='); [19:16:25] php > echo version_compare( '1.22bar', '1.22a', '<'); [19:16:25] php > echo version_compare( '1.22wmf21', '1.22a', '<'); [19:16:25] 1 [19:16:26] php > echo version_compare( '1.22bar21', '1.22a', '<'); [19:16:26] php > echo version_compare( '1.21wmf12', '1.21c', '<' ); [19:16:28] php > echo version_compare( '1.21.2', '1.21c', '<' ); [19:16:29] php > [19:16:42] i would not expect version_compare( '1.22bar', '1.22a', '<'); to evaluate to true based on the docs [19:17:02] but since it does evaluate to true, i would expect version_compare( '1.22wmf21', '1.22a', '<'); to also evalute to true (like we originally had), but it does not [19:17:23] er [19:17:24] s/true/false [19:20:32] so version_compare() is really intended to evaluate PHP-standardized version #s, but the way we version MW doesn't fit into that paradigm [19:20:34] which i suspect is part of the problem [19:20:49] it is [19:23:59] version_compare( '1.22alpha', '1.22c', '<' ) [19:24:08] passes my test cases [19:24:43] yeah i just did a bunch of various things against 1.22c and it seems to work [19:24:44] i don't exactly understand why that works [19:24:49] * aude amending [19:25:00] php > echo version_compare( '1.21.2', '1.22c', '<' ); [19:25:00] 1 [19:25:00] php > echo version_compare( '1.22wmf21', '1.22c', '<' ); [19:25:00] php > echo version_compare( '1.22', '1.22c', '<' ); [19:25:01] php > echo version_compare( '1.22.1', '1.22c', '<' ); [19:25:02] php > echo version_compare( '1.22alpha', '1.22c', '<' ); [19:25:03] php > echo version_compare( '1.22beta', '1.22c', '<' ); [19:25:04] php > echo version_compare( '1.21.2', '1.22c', '<' ); [19:25:05] 1 [19:25:06] php > echo version_compare( '1.22.0', '1.22c', '<' ); [19:25:07] php > echo version_compare( '1.22.0rc1', '1.22c', '<' ); [19:25:08] neither do i, and i find that unnerving [19:25:33] yeah [19:25:48] the consequences of getting it wrong are obviously bad [19:26:04] i guess because 'c' is any string not in the list, although i've still found following that to behave unpredictably in some cases [19:26:05] so.. [19:26:15] but it at least seems to work with the conventions we use [19:26:48] perhaps we ought to prepare a unit test for that [19:29:26] agree, although the way it's used in the entry point makes direct unit test difficult [19:29:38] see https://gerrit.wikimedia.org/r/#/c/89040/ for my test cases [19:29:48] aye [19:29:48] looking [19:29:59] if you can find a place they should go [19:30:22] aude: that patchset looks good. lemme think about the tests and i'll take a look/merge after lunch :) [19:30:30] ok [19:30:55] thanks for your help! [19:31:02] happy to help [19:40:05] beta labs is down awjr_lunch ? [19:40:41] jdlrobson: they are updating nfs on labs [19:40:46] scheduled maintenance [19:40:47] ok [19:46:09] jdlrobson: we're all glaring at rsync over in #-labs right now [19:53:44] chrismcmahon: do you know if the vector extension is installed on beta labs? [19:54:43] jdlrobson: I assume that it is since we've always had the vector skin in place. If it exists as an extension though, it should always be running the master branch, so I wouldn't suspect that as a source of conflict. [19:55:28] chrismcmahon: well it should be turned off [19:55:32] i suspect this is why your test is failing [19:55:49] jdlrobson: when beta comes back up I'll check. [19:55:55] ok [19:56:09] chrismcmahon: just wanted to rull that out [19:56:12] *rule [19:56:15] jdlrobson: so Vector as an extension is gone from production completely? [19:56:42] * chrismcmahon is no expert on skins [20:24:44] chrismcmahon: that is correct > https://bugzilla.wikimedia.org/show_bug.cgi?id=45051 [20:25:00] awjr: any way we can verify https://gerrit.wikimedia.org/r/89105 on beta labs? :D [20:25:17] jdlrobson: not without merging it [20:25:19] at least, afaik [20:25:22] LETS DO IT! [20:25:24] :D [20:25:29] michelle or chrismcmahon would know for sure [20:25:32] * jdlrobson wants progress bars!! [20:25:50] jdlrobson: merge to master. revert if you hate it. [20:26:21] jdlrobson: don't deploy it it in the meantime [20:26:51] chrismcmahon: :) [20:26:58] jdlrobson: have you reviewed https://bugzilla.wikimedia.org/show_bug.cgi?id=41731? [20:27:00] * jdlrobson needs beta labs back first [20:27:20] awjr: i haven't seen that bug no [20:27:29] that seems to be a different one [20:27:46] so the bug in the comment, https://bugzilla.wikimedia.org/show_bug.cgi?id=44921, is resolved, but it sounds like 41731 may be an issue [20:28:16] well we should check and update the comment if necessary to point to that bug [20:28:26] aye im reading it all over right now [20:28:57] awjr: the other thing is that we can enable progress bars on commons itself so should :) [20:29:07] as commons doesn't need CORS [20:29:38] that makes sense; however this patchset doesn't seem to support site-specific configuration [20:30:48] awjr: correct but i was being hopeful that it would work [20:30:58] if not we need to reference this new bug [20:31:10] (i don't know why the original bug was fixed as if this bug is true it doesn't seem to have been fixed) [20:31:21] im not sure i 100% grok the issues but it sounds like 41731 is going to make this not work - does the OPTIONS query only happen when doing CORS? [20:31:21] awjr: heads up this bug is important for Honey Badger [20:31:27] we need this bug fixed [20:31:34] awjr: correct [20:32:07] awjr: we'll wait till jgonera gets back [20:33:26] jdlrobson: now that i've read through the bugs, it sounds like 41731 is going to still be a blocker [20:35:24] although im really confused; i dont know much about CORS [20:35:53] jdlrobson: so there's a workaround suggested in https://bugzilla.wikimedia.org/show_bug.cgi?id=41731 [20:36:23] anyway looks like jgonera has been following the bug - he'll probably be able to say one way or another [20:37:34] awjr: can you tell me what commit is live on enwiki? [20:37:44] jdlrobson: for mobilefrontend? [20:37:45] I need to verify if something has been fixed [20:37:48] awjr: yup [20:38:13] yeah give me a minute [20:39:05] oh Special:Version doesn't show the sha1 on enwiki [20:39:09] * awjr checks git [20:39:18] jdlrobson: 8cfb088699977947e8c5ddee0983e848cd4e3951 [20:39:28] commit 8cfb088699977947e8c5ddee0983e848cd4e3951 [20:39:28] Author: jrobson [20:39:28] Date: Thu Oct 3 16:15:03 2013 -0700 [20:39:28] Track anonymous clicks as well [20:39:31] Optionally include the username / edit count to reflect [20:39:32] dependency [20:39:34] Bug: 54900 [20:39:35] Dependency: Iaf762601c296c289f4380ed5c995caf15b263bff [20:39:36] Change-Id: I72a4d7cf271d391583cbae0962f7e931cbc5ae9a [20:41:29] thanks :D [20:41:35] oh wait that was cherry picked [20:41:42] actually it doesn't matter any how :) [20:41:47] next one was 48ac529896c8cd962fe28f11aadbc256901a113c [20:41:50] kk [20:46:28] ODEN! GUIDE OUR SHIPS [20:46:37] whattup MaxSem [20:46:39] OUR AXES, SPEARS AND SWORDS [20:46:41] how was the show? [20:46:56] GUIDE US THROUGH STORMS THAT WHIP [20:47:08] AND IN BRUTAL WAR [20:48:12] MaxSem is still at the county fair [20:48:23] ha [20:48:34] MaxSem: we had a bit of a problem with version_compare() this morning during deployment [20:48:55] uh? [20:49:16] yeah, 1.22wmf21 didn't pass the version_compare() :p [20:49:22] so things broke [20:49:26] i reverted the change [20:49:41] here's a fix: https://gerrit.wikimedia.org/r/#/c/89040/4 [20:51:50] MaxSem: awjr if I have a Title object how do i check if it is the Special:UserLogin title? [20:52:13] $title->isSpecial('UserLogin') [20:52:28] berfect :) [20:52:31] make sure that casing is proper ot it will barf in debug log [20:53:15] RIP grrrit-wm? [20:53:40] MaxSem: nfs upgrades on labs i think [20:55:03] 10-30 minute planned outage has turned into a little more than that :p [21:03:33] awjr: user stories applied by cohn arrived today :) [21:03:45] nice tfinc [21:03:51] i hope you find it useful [21:04:07] i can't believe this book as 256 pages on just user stories [21:04:32] i also love the fact that its 2^8 number of pages [21:04:41] YuviPanda: are you all set with your visas ? [21:04:48] tfinc: yeah [21:04:54] kaldari: jgonera: how are your tickets and visas for inda ? [21:04:56] india* [21:05:02] tfinc: don't need a special visa. Just tickets and those are set [21:05:23] YuviPanda: you don't need a new visa for the US ? [21:05:32] tfinc: my visa is valid for 10 years :) [21:05:42] tfinc: so that's like, 2021 [21:05:48] then why can you only stay for a certain amount of time on each trip then [21:05:52] lol tfinc [21:06:12] YuviPanda: or am i thinking more when you travel to other countries [21:06:25] tfinc: I can stay for upto 90 days in the US [21:06:34] tfinc: yeah, you're thinking EU / Hong Kong [21:07:18] tfinc: working on it... [21:08:54] jgonera: what about you? [21:10:20] YuviPanda, I thought it's not 90 days but whatever the immigration officer will stamp upon entry [21:10:27] usually 180 days [21:10:32] MaxSem: they don't do the stamping anymore :D [21:11:52] in Hong Kong they stapled a piece of paper into my passport instead of a stamp [21:16:20] awjr: yeah, same to me. but i got only 15 day thing [21:22:25] kaldari: https://m.mediawiki.org/wiki/Special:MobileDiff/797556 [21:22:31] thank button is screwed up for me.. [21:22:40] shows above the name [21:22:50] eh [21:23:26] looks like the CSS isn't loading [21:25:27] brion: which current iteration story solves https://trello.com/c/mFwsCQaM/314-bug-55572-dual-spinners-show-up-with-pulling-to-refresh ? [21:26:24] i'm guessing this one https://trello.com/c/4fKk7xMU/74-1hr-spike-pull-to-refresh-can-double-up-and-be-all-weird [21:28:59] yep [21:29:21] jdlrobson: what's that bug? [21:29:46] https://bugzilla.wikimedia.org/show_bug.cgi?id=55596 [21:30:22] on a plus note it's really nice to jump between people's profiles https://m.mediawiki.org/wiki/Special:UserProfile/Maryana_(WMF)?mobileaction=beta [21:30:29] kenanwang: just saw your cal invites - 10/14 is a holiday [21:30:33] yep [21:30:38] just realized that too [21:30:40] sending new dates [21:30:45] i'm jumping between work colleagues via thanking - really nice to see who collaborates together [21:30:46] but, honeybadger dont care [21:30:55] I was like OHHH my monday is soooo open [21:31:05] hahaha [21:31:08] YuviPanda: cc me on the mail about https://trello.com/c/bqvlyePK/323-android-track-people-using-campaigns [21:31:11] I thank travelled from Maryana all the way to Lmcinnish [21:31:24] tfinc: will do [21:36:32] YuviPanda: brion mhurd : i did a first pass for priorities https://trello.com/b/2cUtayOd/mobile-app-backlog ... it may change depending on whats left over from the current sprint [21:37:00] as we still have 20 story points that are in ready for dev [21:37:22] tfinc: the 8 i'm working on should be merged tomorrow, mostly. I'll keep it up to date [21:37:30] great [21:37:39] jdlrobson: ? [21:40:45] awjr: so when we see a problem with mediawiki.org how do we get the fix on the deployment train? what is the process? see https://bugzilla.wikimedia.org/show_bug.cgi?id=55596 [21:41:30] i think cherrypick the fix into the correct production branch; but best to double check with Reedy [21:42:00] and/or greg-g^ [21:42:01] jdlrobson: ^ [21:42:15] After the initial deploy, I don't do any other updates by default [21:44:53] right, cherry-picks then deploy that cherry-pick [21:57:18] brion: you about? [21:57:30] tfinc: yo [21:57:50] brion: were setting up katie and kenan on test flight [21:58:03] do you see their access requests on test flight / [21:58:04] ? [21:58:08] lemme open that up [22:00:42] hmmm i can't find em tfinc [22:00:57] but lemme keep looking, their dashboard interface is kinda weird [22:01:02] mhurd: --^ [22:01:46] tfinc: brion: ken an had a meeting so he's not through the test flight acct creation just yet [22:01:53] ah ok [22:02:09] mhurd: what about katie though [22:02:09] ? [22:02:38] tfinc: she did and i messaged brion the email address associated with her test flight acct. [22:03:06] mhurd: ok maybe i have to explicitly invite her at that adde, lemme try that [22:03:16] brion: ah i think so. it was kaitymh@gmail.com [22:04:19] mhurd: tfinc: ok I sent laity an invite at that adde, so that should ping her [22:04:26] brion: yay! [22:04:26] and i see ken an signed up from before actually [22:04:41] brion: so he's in the current build ? [22:05:38] tfinc: no but he should have an email [22:05:46] it's on a gmail account though [22:05:57] shouldn't matter. i told them to use their apple id [22:06:10] ok [22:06:20] tfinc, I'm still looking at flights and a possibility of staying a few days after the summit and departing from a different airport [22:06:25] anyway i'll see soon enough if he signs in with that account or makes a new one :) [22:06:48] ok im in [22:07:04] but it says there are no available builds [22:07:25] kaity: sing you just singed up you'll have to wait for the next build that will include your key [22:07:28] since* [22:07:50] next built is scheduled for 10/23 [22:07:56] build [22:08:12] well we can make one earlier than that [22:08:24] but yeah gotta wait a little. . . patience! :) [22:09:14] im getting ready to leave for the day, and i'll be hitting the road for LA in a few hours. anybody need anything from me before i go? if not; see you all on tuesday [22:09:14] tfinc, jdlrobson, jgonera, MaxSem, kaldari ^ [22:09:23] i'm good awjr [22:09:37] nope [22:09:44] travel safely awjr [22:09:52] thanks MaxSem [22:09:53] drive safely! [22:09:59] thanks guys :) [22:10:16] see you on tuesday - i'll be checking my email later this afternoon/eve if anything else comes up [22:10:40] brion: can you invite tfinc@wikimedia.org [22:11:26] ok thanks! [22:11:52] tfinc: you're already in the system under that addr [22:12:28] i see an iPhone 4s and an iPod touch 4th gen... got another device to add? [22:13:43] jdlrobson: https://gerrit.wikimedia.org/r/#/c/89122/ [22:13:46] thanks button fix [22:15:06] brion: what account are those under ? [22:15:32] tfinc: tfinc@wikimedia.org [22:15:51] so when i log into that account i *only* see the wikipedia app. not commons [22:16:11] hmm, well it shows you as a "member since Apr 16" [22:16:34] perhaps.... you didn't make it into the device list updates [22:16:43] lemme make sure [22:17:05] i wonder if i'm looking at my own uploaded builds [22:17:07] this interface is confusing [22:17:24] but that's not surprising given that is running on top of the apple provisioning system [22:17:24] yeah i get lost in there too :) [22:21:10] ok i can add up to 8 new devices; 3 slots reserved for may and kaitlin so 5 left :) [22:21:15] mhurd: did that iPhone 5s show up yet? :D [22:22:50] brion: ya! just got it all activated! [22:23:18] brion: is nice! [22:24:40] yay [22:24:48] register it up and i'll add it to the profile for next build [22:25:59] brion: 5 spots left in total ? [22:26:31] 4 spots after monte's new phone [22:26:41] jdlrobson: The thanks fix ended up being slightly more complicated than I thought [22:27:05] we're gonna have to start clearing people out of the list soon [22:32:12] brion: finding the phone id now... [22:32:54] jdlrobson: If that ends up being problematic, I can either add a 3rd selector to that scoping block (which will generate a lot more CSS) since it's multiplied by 3 other more specific selectors), or I can add the content div back to the diff page. [22:34:56] mhurd: if you just log into test flight and do reconnect device it'll send me the id :D [22:37:28] brion: ah - just emailed it to you for the portal [22:38:35] that works too :) [22:41:19] updating provisioning profile.... [22:41:33] brion: YuviPanda mhurd : am i missing any of our big docs on https://www.mediawiki.org/wiki/Wikimedia_Apps/Team ? [22:41:41] looking [22:42:11] MaxSem, tfinc: We have a live bug that hasn't been deployed to en.wiki yet (https://bugzilla.wikimedia.org/show_bug.cgi?id=55596). If the fix for it is merged before 4pm, do you want me to lightning deploy it? [22:42:53] could add the app page links [22:43:15] kenanwang: ^ [22:43:36] or is that out of scope.... yeah [22:43:47] keep it to the team :) [22:44:03] the bug is currently live on mediawiki.org and test.wiki and will presumably ride the train to en.wiki on Monday [22:44:05] tfinc: http://hat.jit.su/ [22:45:03] tfinc: http://mobile-reportcard.wmflabs.org/ [22:45:51] tfinc: one more: https://www.mediawiki.org/wiki/Gerrit/git-review [22:46:12] ah good ones! [22:46:49] jdlrobson, what's the brokenness in https://bugzilla.wikimedia.org/show_bug.cgi?id=55600 ? [22:48:03] updated MaxSem [22:48:09] MaxSem, overall brokenness, similar to Opera Mini [22:48:38] but identifies as gecko [22:48:43] brion: would you have a chance to add my 5s id to a member center provisioning profile? [22:49:11] mhurd: it's in the latest profile, i'm about to poke a build :D [22:49:22] jdlrobson, so is it unable to execute our JS, or does it badly? [22:49:27] that'll include may and kaity [22:49:52] brion: ah. from Xcode it wasn't letting me push to device [22:50:17] hmm you might have to update your dev profile? [22:50:22] the ways of Xcode are mysterious [22:50:32] MaxSem: the latter [22:50:56] hmm, so we need more capability tests? [22:51:01] It says "none of the valid provisioning profiles include the device Monte Hurd's iPhone 5 [22:51:08] MaxSem, it's one of those proxy browsers, nothing is rendered without a roundtrip to the proxy [22:51:30] brion: ^ and "Xcode can resolve this issue by downloading a new provisioning profile from the member center" [22:52:02] brion: but when i click "fix" it says only admins are allowed to perform operation [22:52:23] kaldari: let's merge the fix [22:53:56] hmm [22:54:12] jgonera: https://gerrit.wikimedia.org/r/#/c/88672/ fixed talk icon on profile :( [22:54:20] moment [22:56:26] mhurd: maybe it needs to sync updates, .... [22:56:38] jdlrobson: I don't think the breakage of the talk page button on UserProfile is related to the button scoping change. The talk page button is of class secondary-button, which shouldn't be affected. [22:56:51] mhurd: try going to Xcode preferences -> accounts -> details -> click the little refresh icon on the profiles etc [22:56:59] jdlrobson, do we have an Asha now or it's been reported? [22:57:12] we have 2 now MaxSem :) [22:57:12] i see a commons development profile that appears to have just been updated, with all 96 devices [22:57:18] so hopefully it just needs to sync to you [22:57:19] jdlrobson: when does the next web sprint start ? [22:57:28] :headbang: [22:57:48] tfinc: next iteration is tuesday due to public holiday [22:58:22] brion: will do [22:59:07] mhurd: ok I've pushed out an updated build on test flight, so if you connect the 5S to your test flight account it should install that way now too [23:00:08] kenanwang: were going to get out of sync with the web teams iteration due to our inception week. do you want us to wait a week or stagger ? [23:00:13] brion: thank you for the Xcode tip! totally worked :) [23:00:13] its the same to me [23:00:19] yay! [23:00:26] when in doubt, refresh account [23:00:35] brion: true! [23:01:17] MaxSem: one for you.. http://ikeaordeath.com/ [23:01:25] brion: test flight worked too!! [23:01:53] jdlrobson, HATE [23:02:08] they don't know the difference between black and death metal [23:02:20] and use it interchangeably [23:02:47] tfinc: when you say wait a week what does that entail? [23:04:54] MaxSem: What do you think about doing a lightning deploy for pushing out https://gerrit.wikimedia.org/r/#/c/89122/ to 1.22wmf21? Greg says we can have the window today, and I would be happy to push it out if you're busy with other stuff. [23:05:38] kaldari, why not? I can do it too [23:06:01] it's still in review though [23:06:36] hmm, where'd jgonera go? [23:06:51] you love it MaxSem [23:06:54] maybe he could drop the +2 hammer [23:07:00] you'd win that game easily [23:07:58] actually, I finished it with roughly 50% accuracy [23:08:27] prolly because I've a bunch of guitars ringing in my ears right now [23:12:26] brion: ping [23:13:27] MaxSem: eek https://m.mediawiki.org/wiki/Special:UserProfile/sassass [23:14:19] jdlrobson, Exception from line 17 of /usr/local/apache/common-local/php-1.22wmf21/extensions/MobileFrontend/includes/MobileUserInfo.php: MobileUserInfo i [23:14:19] s intended for logged in users only [23:14:36] MaxSem: https://bugzilla.wikimedia.org/show_bug.cgi?id=55601 [23:14:43] that's not true [23:14:48] YuviPanda: yo [23:14:51] you can view profiles when not logged in [23:15:04] brion: been thinking of the wikipedia app, and things we should do from the start different from Commons [23:15:21] brion: thinking of making it have tests from the get go, and that'll also impact the way the code gets architected [23:15:30] brion: thoughts? aim for close to 100% code coverage... [23:15:35] brion: how's unit testing and such on iOS? [23:15:39] jdlrobson, it means that user doesn't exist or whatever:P [23:15:48] *target* user [23:15:52] not the viewer [23:15:59] YuviPanda: testssss yesssss [23:16:25] YuviPanda: so there seems to be some favored framework that default projects in Xcode can create, i should check that out [23:16:47] brion: I looked at Dependency injection too, but all the ones I found were either overcomplicated (meant for Enterprise ENTERPRISE Java projects) or slow [23:17:02] brion: I guess we can do without direct DI, and just construct around the same ideas [23:17:13] MaxSem: just correcting the english ;-) [23:17:23] yeah, just avoid globals and have clean interfaces :D [23:17:24] btw why no notifications on gerrit in wikimedia-mobile today? [23:17:27] jdlrobson, that's what code review is for;) [23:17:28] brion: yeah, pretty much. [23:17:34] then we can mock-object things like the network source or whatever [23:17:50] brion: so one of the ways we can do it is to have the underlying layers separate from being 'mobile' at all. [23:17:52] that's why small commits are nicer MaxSem ;-) [23:18:06] *nod* [23:18:10] brion: like have the fetching, etc code out in a library that can be used on desktop too [23:18:16] brion: can that be done on iOS too? [23:18:33] brion: like, Obj-C on desktop is close to that on iOS? [23:18:34] so for iOS, we could fairly easily do non-UI code that can be shared with OS X [23:18:41] right [23:18:44] most of the low-level obj-c frameworks are the same [23:18:55] right [23:19:09] so in principle many components can run unit tests as a CLI app on OSX natively [23:19:18] brion: right [23:19:30] mhurd: hat.jit.su added to https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/Development_cycle [23:19:31] that's cleaner than running some thing in the iOS simulator ui :) [23:19:35] brion: the patch to make Parsoid output valid XML just landed [23:19:39] nor sure where/if i want the others [23:19:50] brion: so we can just use the nice XML parsers rather than hunt for a html one [23:20:07] yay [23:20:08] tfinc: ya i didn't add them myself for the same reason [23:20:11] brion: so http://square.github.io/okhttp/ exists, gives us SPDY support [23:20:28] jdlrobson, so logs say that that S40OviBrowser thingie is used by 100% of Ashas [23:20:29] brion: we can mock that around. [23:20:46] YuviPanda: let me know if you need anyone from square for that. i know people there [23:20:48] brion: also current API layer uses XML API. Should probably switch to JSON [23:20:49] MaxSem: that wouldn't surprise me [23:20:50] blacklist it in RL and be done with it? [23:20:59] JSON for the win [23:21:17] tfinc: mmm, Jake Wharton is awesome, and pretty much every android app has some of his work in it. Not right now, but I believe we can use that in the future [23:21:27] let me know when you do [23:21:31] brion: yeah, so I guess writing a JSON API to replace the current XML one would be nice [23:21:49] brion: and then layer a higher level API on top of it, that can switch between using Parsoid or the Mediawiki API [23:22:11] +1 flexibility in APIs [23:22:50] YuviPanda: he should be pretty easy to find as one of my friends is on their Android dev team [23:22:56] nice tfinc [23:23:43] jdlrobson, can you verify that killing JS fixes the situation? [23:24:24] brion: tfinc: think i solved the double refresh issue [23:24:30] :) [23:24:59] brion: another thing I want to do is identify a number of metrics that we can measure for performance [23:25:01] yay [23:25:04] brion: and keep CI tests of them [23:25:09] so we can optimize [23:25:12] yeah [23:25:20] brion: yet another thing - thoughts on dropping 2.3 support? [23:25:34] of course the things i most want to measure for performance are things like 'startup time' and 'smoothness' that are a huge pain to test [23:25:46] brion: yeah, true. [23:25:53] ah, 2.3 [23:25:57] brion: but Android seems to have an... okay testing framework. [23:26:13] brion: we *can* test starting time, etc - but by default they'll be on emulators and hence useless [23:26:19] heh [23:26:24] brion: so, 2.3? [23:26:47] brion: https://developer.android.com/about/dashboards/index.html [23:26:56] brion: 28% [23:27:05] 28%? ugh [23:27:07] die 2.3 DIE [23:27:24] brion: well, 2.8 will still have the old app... [23:27:25] Oh that nice fragmentation [23:27:27] brion: and no new phones with 2.3 [23:28:18] YuviPanda: so i'm not willing to make that call, but if tomasz and kenan were to make it i would be happy to implement the abandonment of 2.3 ;) [23:28:27] brion: yeah, I agree [23:28:34] brion: makes sense [23:29:40] it'd be nicer to know the version share of actual usage [23:29:53] but do we measure usage of the crappy old app, or the web site, or .... [23:30:08] brion: yeah, our current monitoring sucks [23:30:12] we'll have nice EL in the new one! [23:30:28] WMF is the new NSA [23:30:31] we know EVERYTHING YOU DO [23:30:32] hehe :P [23:30:50] ;) [23:31:11] brion: yeah, we can stub out EL and test it too :P [23:31:51] brion: we'll also have to make a gradle vs maven call [23:32:11] brion: i'll happily go with gradle if the libraries we want are available in that package. XML sucks [23:33:02] brion: i just pushed another change to gerrit, but didn't see irc alert... [23:34:06] mhurd: grrrit-bot is dead [23:34:12] mhurd: labs maintenance. will be back up [23:34:22] YuviPanda: ah! thanks yuvi! [23:34:25] whee maintenance [23:34:59] YuviPanda: i'll leave the gradle vs maven call to you; whichever seems stabler to you is fine [23:35:07] brion: whee, ok [23:35:46] brion: so, another radical proposal - do the unit tests in a non Java language [23:35:48] thoughts? [23:36:59] o_O [23:37:13] not sure i understand that :D [23:37:23] brion: well, write our unit tests in Scala [23:37:40] ahh [23:37:59] well it's all java in the end. ;) (jvm, anyway) [23:38:03] yeah [23:38:08] but at least it won't be *as* painful [23:38:16] less boilerplate == win [23:38:34] brion: it won't affect our app, but you'll have to learn a bit of Scala :D [23:38:38] but I guess that's an awesome win [23:38:44] it'll be good for me to learn :D [23:38:51] exercise my old brain [23:39:00] * brion whinges about whippersnappers who don't even know perl [23:39:01] yeah [23:39:12] brion: i'm taking the 'functional programming in scala' course :P [23:39:37] brion: halfway through and all assignments clearing! [23:39:45] \o/ [23:40:59] brion: so action items: rewrite org.mediawiki.api to use JSON, write tests for that (in Scala!), start thinking of the layer on top of that [23:41:02] brion: makes sense/ [23:41:03] ? [23:41:34] YuviPanda: +1 [23:42:09] brion: sweet :) [23:42:21] brion: exciting times! :) [23:42:31] :DD [23:42:47] brion: also seen https://www.mediawiki.org/wiki/Requests_for_comment/TitleValue [23:42:47] ? [23:43:02] oh i gotta read over that again sometime :) [23:43:30] brion: yeah. we could probably also re-use some of the concepts [23:43:36] brion: also i'm going to spend some time on Wikidata [23:43:44] brion: I've a feeling tha we should be leveraging it a fair bit [23:44:00] in future hell yeah [23:44:07] it's going to become our friend in many things [23:44:38] * brion wonders how long before someone makes natural language query on top of wikidata nodes [23:44:48] hook that up to display facts, media, and articles... [23:44:53] take THAT siri [23:45:01] brion: magnus already did that somewhere, maybe [23:45:28] isn't that like some rule of the internet? [23:45:37] if you can imagine it, magnus has already prototyped it [23:46:39] hehe :D [23:47:46] brion: have you checked out the search on wikidata? [23:48:02] brion: it would be amazing if it didn't suck, so we can display that [23:48:07] as our primary search interface [23:48:15] heh [23:48:40] brion: search results with descriptions! [23:51:59] YuviPanda: how are you still awake ? [23:52:13] YuviPanda: go to sleep [23:52:21] tfinc: must be the meds, I guess? I took like, 12 tonight :| [23:52:33] YuviPanda: how is the wrist ? [23:52:48] tfinc: better! less pain, numbness still persists. [23:52:48] YuviPanda: did you ever followup with lynette and gayle ? [23:53:01] tfinc: no, not sure what exactly to do to start the thread. [23:53:16] tfinc: I've been talking to greg and andrew about steps they took, and following up [23:53:42] Lynette and Gayle would have a lot of perspective given the companies they've worked at [23:53:48] so they've seen a lot of this before [23:53:51] right [23:54:01] i'll think about it when I wake up and then email [23:58:27] jgonera: I did a quick fix for Jon's UserProfile bug: https://gerrit.wikimedia.org/r/#/c/89139/ [23:58:34] did he leave? [23:58:37] yep [23:59:13] you need to configure your editor for whitespace removal kaldari ;) or at least highlighting [23:59:20] yes, just fixed it :P [23:59:22] configure git for it! :D [23:59:35] YuviPanda: How do you do that? [23:59:40] moment [23:59:55] kaldari: whitespace = trailing-space,space-before-tab [23:59:58] kaldari, is that something urgent or can Jon review it tomorrow?