[00:00:00] under [core] in ~/.gitconfig [00:00:16] hm, interesting YuviPanda [00:00:16] kaldari: strips both of those out even if you commit [00:00:28] jgonera: according to Jon, it was urgent, but I'm ambivalent about it [00:00:30] so if you commit with trailing space, they'll just not be added [00:00:39] you learn something new everyday ;) [00:00:41] YuviPanda: awesome [00:00:45] it doesn't work when you *add* a new file, but other than that it works great [00:00:51] like, a completely new file [00:01:02] kaldari: jgonera do you also know of 'git commit -p'? :) [00:01:04] I learned yesterday that in Chrome's JS console you can use $0 to access the DOM node you selected in the web inspector [00:01:15] oh wow, I didn't know that! [00:01:19] ;) [00:01:44] what does git commit -p do? [00:01:51] jgonera: try it out! [00:01:52] jgonera: double-awesome [00:02:02] jgonera: it shows you each 'chunk' of change, and you can either add it to the commit or leave it [00:02:05] I tried but the question it asked me was confusing and I'm scared [00:02:12] haha! [00:02:13] "Stage this hunk [y,n,q,a,d,/,j,J,g,s,e,?]?" [00:02:22] you type 'y' and it adds it to the commit being formed [00:02:24] yikes [00:02:25] you type 'n' and it skips it [00:02:31] those were obvious [00:02:34] q quits [00:02:43] e is actually damn awesome, since it lets you edit the *patch* itself [00:02:54] so you can remove a line or so out of a big block if you don't want it going into the commit [00:03:05] s is almost as awesome - it 'splits' a big hunk into smaller ones [00:03:11] for you to pick and choose [00:03:12] I think I just prefer to keep my working dir with only changes that I commit anyway ;) [00:03:18] hm [00:03:33] it's a replacement for the 'git diff && git add && git commit' workflow [00:03:36] just git commit -p [00:03:38] lol kaldari, I noticed that you committed that fix only when I did it myself:P [00:03:40] I like when git status show nothing after git commit ;) [00:03:51] jgonera: heh, yeah :) [00:03:52] I always do git add . [00:03:56] ow [00:04:00] that's rather dangerous [00:04:04] nope [00:04:13] well, I do git status before that [00:04:17] and sometimes git diff [00:04:28] hmm, I guess I've stopped caring about keeping working directory clean [00:04:31] because i always use commit -p [00:04:32] ;) [00:04:35] so know exactly what goes in [00:04:44] it also makes whitespace errors obvious [00:04:49] and helps keep my commit small [00:04:49] jgonera: so if we want to deploy either of those fixes today it's up to you or MaxSem to drop the +2 hammer on them. Otherwise, we wait until next Tuesday. [00:04:50] I guess that's just a different workflow [00:04:59] oh true true [00:05:05] jgonera: still, good to know it exists :) [00:05:35] yep, might be handy in really confusing cases, or if need a quick-fix commit [00:05:52] yeah [00:06:02] git rebase -i is equally powerful [00:06:07] especially with gerri [00:06:07] t [00:06:26] kaldari, I think it's not a big deal, profiles are in beta and I don't think many people will hit URLs of users that don't exist [00:06:38] oh yeah, git rebase -i is something I use often [00:07:10] yeah. e is fun [00:09:15] jgonera: any opinion on deploying https://gerrit.wikimedia.org/r/#/c/89122/? [00:09:53] kaldari, it won't go to all the projects immediately? [00:09:59] brion: http://etorreborre.github.io/specs2/ and https://code.google.com/p/mockito/ [00:10:08] no only to mediawiki.org and test and test2 [00:10:14] what is the deadline for +2? [00:10:36] no deadline, but if it's going to be deployed today, we should do it now. [00:10:52] since I don't want to stay all night :) [00:11:36] Jon and Kenan wanted to deploy it today if possible (i.e. if it got merged) [00:14:07] I'm just working on something else now, I can blindly +2 or test later [00:19:53] I guess we'll just wait til Tuesday [00:20:09] Jon was the main person pushing to get it out, but he left :P [00:27:05] mhurd: leaving in 3 [00:27:17] tfinc: ya! [00:39:27] jgonera: if you have any time, I have a couple questions about writing selenium tests [07:22:29] (03CR) 10Siebrand: [C: 04-1] "(6 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89139 (owner: 10Kaldari) [16:12:05] (03CR) 10MaxSem: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89139 (owner: 10Kaldari) [16:12:25] yo jdlrobson [16:12:59] yo MaxxxSeeemmmm [16:14:27] \m/ [16:40:57] (03PS1) 10MaxSem: Remove obsolete comment and todo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89233 [17:04:53] is there a hangout other than the link in the calendar ? [17:09:33] ^^ found it [17:15:13] hey brion [17:15:14] standup? [17:15:35] yo [17:15:44] ok i'm on [17:16:33] jdlrobson, so IEMobile/9 is 1225 reqs of 173527 [17:17:04] so 0.7% of all traffic? [17:17:22] MaxSem: can you add that to the bug report? [17:17:26] yup, roughly [17:17:27] this data is useful :-) [17:19:45] sooooo [17:20:05] anything paticular you want me to writre tests for, team? [17:22:47] ok lemme finish off this random commit and then make sure bart's still running ;) [17:25:14] kenanwang: where does mingle hide moving a card like https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1303 to the backlog ? [17:25:49] kenanwang: jdlrobson do you usually change iteration to bug backlog for these ? [17:25:50] on the right there is a list of team favorites [17:25:57] one of those is the bug backlog [17:26:05] yes [17:26:19] kenanwang: what would you like to do with https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1304 'Add mobile editing support to Windows phone (IE9) ' ? [17:26:25] backlog or current iteration ? [17:26:40] let's backlog until we have a better sense of browser support or until we get a complaint [17:26:46] keep in mind that i'm pretty certain your at the end of your current iteartion [17:26:48] k [17:26:55] browser support is one of my items to look at [17:27:48] same thing with the other support question [17:28:41] ok web team bug triage column is now empty [17:28:56] * tfinc takes off his arthur hat for the day  [17:29:03] correction [17:29:13] * tfinc takes off his arthur stache for the day  [17:42:07] (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89137 (owner: 10Jdlrobson) [17:43:05] (03CR) 10JGonera: [C: 032] Separate activity and thanks section when no uploaded image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89134 (owner: 10Jdlrobson) [17:43:44] (03Merged) 10jenkins-bot: Separate activity and thanks section when no uploaded image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89134 (owner: 10Jdlrobson) [17:45:16] (03PS1) 10MaxSem: Remove hardcoded removals from ExtractFormatter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89239 [17:45:27] (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89130 (owner: 10Jdlrobson) [17:47:13] (03CR) 10JGonera: [C: 032] Don't try to watch special pages after a successful CTA [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89108 (owner: 10Jdlrobson) [17:47:36] (03Merged) 10jenkins-bot: Don't try to watch special pages after a successful CTA [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89108 (owner: 10Jdlrobson) [17:51:33] (03CR) 10JGonera: [C: 032] Tweak caption styling (yet another table hack) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89106 (owner: 10Jdlrobson) [17:52:27] (03Merged) 10jenkins-bot: Tweak caption styling (yet another table hack) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89106 (owner: 10Jdlrobson) [17:59:13] Duh [18:00:08] Again connectivity problems [18:10:53] (03PS4) 10JGonera: Add back button support to nearby overlay and preview overlays (geonotahack) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88796 (owner: 10Jdlrobson) [18:11:05] (03CR) 10JGonera: [C: 032] Add back button support to nearby overlay and preview overlays (geonotahack) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88796 (owner: 10Jdlrobson) [18:12:21] (03Merged) 10jenkins-bot: Add back button support to nearby overlay and preview overlays (geonotahack) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88796 (owner: 10Jdlrobson) [18:21:40] (03PS4) 10Kaldari: Fixing UserProfile for invalid usernames [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89139 [18:26:19] kaldari: is there an easy way to calculate for a given article how many unique users edited it? [18:26:48] easy? no [18:27:31] it's easy to get the latest editor or the creator, but that's all [18:28:20] unless someone has added a function to Article or WikiPage I don't know about [18:30:37] (03CR) 10JGonera: [C: 04-1] "(5 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88912 (owner: 10Jdlrobson) [18:44:53] (03CR) 10JGonera: [C: 04-1] "(3 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88913 (owner: 10Jdlrobson) [18:44:54] (03PS9) 10Kaldari: Preparing the LastModified code for Mingle cards 1262 and 1258 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 [18:46:19] (03CR) 10Kaldari: [C: 04-2] "I'm going to squash change I8126b3e1 with this one." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 (owner: 10Kaldari) [18:47:09] (03CR) 10JGonera: [C: 032] Hygiene: Minor Resource Loader modules hygiene fix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88890 (owner: 10Jdlrobson) [18:48:42] (03Merged) 10jenkins-bot: Hygiene: Minor Resource Loader modules hygiene fix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88890 (owner: 10Jdlrobson) [18:56:05] (03PS1) 10Dr0ptp4kt: Send W0 interstitial "No" clicks to mobile URL. Fixes bug 55578. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/89248 [18:56:56] ^yurik, would you please review change 89248 and +2? [19:00:25] (03CR) 10Brion VIBBER: [C: 032 V: 032] Consistent nav button and text shadows between iOS 6 and 7. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/89030 (owner: 10Mhurd) [19:03:17] (03CR) 10Brion VIBBER: [C: 032 V: 032] "woohoo!" [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/89138 (owner: 10Mhurd) [19:11:25] (03PS1) 10Jdlrobson: Hygiene: Merge Special:Watchlist doFeedQuery doListQuery functons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89280 [19:11:26] (03PS1) 10Jdlrobson: Hygiene: Remove dead code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89281 [19:11:27] (03PS1) 10Jdlrobson: Hygiene: Turn getHtmlBetaAlphaOptIn into a static reusable method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89282 [19:11:28] (03PS1) 10Jdlrobson: Beta: Add Special:History [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89283 [19:14:36] (03PS1) 10Mhurd: Attribution label uses UILabelDynamic height and no longer fades. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/89319 [19:42:13] (03PS9) 10Jdlrobson: Story 1072: KeepGoing CTA [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87426 [19:43:28] (03CR) 10Jdlrobson: "Any ideas Chris / Michelle / Zeljko?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89137 (owner: 10Jdlrobson) [19:49:29] (03PS2) 10Jdlrobson: Fix regression in user profile talk [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89130 [19:49:39] (03PS3) 10Jdlrobson: Fix regression in user profile talk [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89130 [20:01:34] (03PS4) 10Jdlrobson: Hygiene: Cleanup the progress bar FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89105 [20:01:50] (03PS2) 10Jdlrobson: Remove obsolete comment and todo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89233 (owner: 10MaxSem) [20:02:03] (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove obsolete comment and todo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89233 (owner: 10MaxSem) [20:02:15] (03PS2) 10Jdlrobson: Remove hardcoded removals from ExtractFormatter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89239 (owner: 10MaxSem) [20:03:09] (03Merged) 10jenkins-bot: Hygiene: Remove obsolete comment and todo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89233 (owner: 10MaxSem) [20:04:39] (03PS3) 10Jdlrobson: Hygiene: Remove hardcoded removals from ExtractFormatter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89239 (owner: 10MaxSem) [20:04:44] (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove hardcoded removals from ExtractFormatter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89239 (owner: 10MaxSem) [20:05:32] (03Merged) 10jenkins-bot: Hygiene: Remove hardcoded removals from ExtractFormatter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89239 (owner: 10MaxSem) [20:05:51] kaldari: i wonder if we should not 404 instead for https://gerrit.wikimedia.org/r/#/c/89139/ ? We do this for the diff view.. [20:10:35] (03CR) 10Jdlrobson: [C: 04-1] "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89139 (owner: 10Kaldari) [20:13:12] so the nexus 5 is supposedly about to come out [20:13:19] whee more devices [20:19:55] (03PS1) 10JGonera: Regression: Fix empty watchlist message styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89333 [20:21:14] (03PS2) 10JGonera: Regression: Fix empty watchlist message styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89333 [20:21:54] (03PS3) 10JGonera: Regression: Fix empty watchlist message styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89333 [20:22:27] (03CR) 10Cmcmahon: "it's a bash thing. the script isn't going to the right directory:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89137 (owner: 10Jdlrobson) [20:29:34] kaity: you are awesome [20:29:49] cupcakes are awesome [20:49:01] (03PS5) 10Kaldari: Fixing UserProfile for invalid usernames [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89139 [20:49:14] arrrrr [20:50:14] jdlrobson: can you merge this before Siebrand comes back: https://gerrit.wikimedia.org/r/#/c/89139/ [20:50:46] kaldari: haha [20:52:05] i18n looks good [20:52:08] (03CR) 10Jdlrobson: [C: 032] "Siebrand: your comments are unrelated to this patchset so I'm +2ing. Please can you raise a bug/write a patch if you think these are probl" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89139 (owner: 10Kaldari) [20:52:11] BOOM [20:52:23] arrggg [20:52:32] (03Merged) 10jenkins-bot: Fixing UserProfile for invalid usernames [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89139 (owner: 10Kaldari) [20:52:46] I was writing "...but let me nitpick something else" [20:52:47] :P [20:53:20] MaxSem: oops sorryz I figured you'd nitpicked already [20:53:24] follow up on the cards! [20:53:33] ROFL [20:54:34] ROFL? [20:54:42] surely something is not that funnny... [21:05:02] (03CR) 10MaxSem: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89105 (owner: 10Jdlrobson) [21:06:23] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89105 (owner: 10Jdlrobson) [21:07:16] (03CR) 10Jdlrobson: [C: 04-1] "Isn't this what unstyledContent exists for?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89333 (owner: 10JGonera) [21:08:04] (03CR) 10JGonera: "It is? And it's true there. We don't want article styling, we want different styling." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89333 (owner: 10JGonera) [21:08:26] jdlrobson, answered ^ [21:09:42] (03PS1) 10Brion VIBBER: UI matching in detail view to iOS version [apps/android/commons] - 10https://gerrit.wikimedia.org/r/89339 [21:12:46] jgonera: i'll grab you if it's not clear but why not just add content to the div with class info? this seems overkill [21:12:54] (03CR) 10MaxSem: [C: 04-2] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89280 (owner: 10Jdlrobson) [21:13:13] jdlrobson, isn't it what I did? [21:13:48] no you added additional styling to watchlist.less? [21:14:02] MaxSem: -2 seems harsh - especially when i've added comments so of course the size is going to go up :) [21:14:52] jdlrobson, if (foo) { long block of text } else { long block of text } is bad [21:15:13] an elegant solution would be to use inheritance [21:15:36] though it's not very suited in this case [21:15:50] i still think it's an improvement - and if you see the follow up patch its of interest to be able to override these functions [21:16:14] another way would be to use private variables that get set elsewhere [21:17:03] my main annoyance was the logical for wl_namespace and rc_namespace - identical but in two different places [21:17:23] if you want i can remove all the comments to show the improved diff size ;-) [21:17:26] (03CR) 10Brion VIBBER: "Woops -- I didn't i18nize all the labels yet, so if this gets merged before that is done that should be added." [apps/android/commons] - 10https://gerrit.wikimedia.org/r/89339 (owner: 10Brion VIBBER) [21:19:41] (03CR) 10Jdlrobson: [C: 04-1] "A -2 is harsh in my opinion. I'm sure this can be improved and is trying to fix a real code hygiene problem. I'd suggest you see the goals" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89280 (owner: 10Jdlrobson) [21:20:10] jgonera: jdlrobson: no you added additional styling to watchlist.less? [21:20:32] jdlrobson, that styling was erroneously removed in a commit mentioned in this commit [21:20:44] that's the correct design for this [21:21:55] jgonera: i barely notice the difference between that and just applying the class .content to it [21:22:14] well, jdlrobson, what can I say [21:22:22] you can discuss it with designers [21:22:28] jgonera: i will [21:22:40] I think it's a waste of time for everyone personally [21:23:11] and the perceived difference is subjective, I do notice it [21:23:12] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Height is dynamic as expected. I kinda liked the fade, but if it doesn't work quite right that's fine. :)" [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/89319 (owner: 10Mhurd) [21:28:26] (03PS1) 10Dr0ptp4kt: Support language selector on on feature phones. Fixes bug 48752. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/89341 [21:30:32] (03PS2) 10Dr0ptp4kt: Support language selector on on feature phones. Fixes bug 48752. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/89341 [21:37:11] (03PS1) 10MaxSem: Address a fixme with title building [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89342 [21:42:22] (03CR) 10MaxSem: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89280 (owner: 10Jdlrobson) [21:44:37] jdlrobson, okay - if your main concern is mostly duplicated switch( $this->filter ) this can be factored out. however other stuff is still bad, for example getQueryTables() gives you nothing [21:45:03] MaxSem: yeh we could probably achieve the same using a private variable? [21:45:32] (in Special:History page which I want to be based off this that only needs access to the recent changes table) [21:53:05] (03CR) 10Kaldari: [C: 04-1] "(7 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89280 (owner: 10Jdlrobson) [21:54:02] (03PS1) 10MaxSem: WIP: factor out common code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89345 [21:54:26] jdlrobson, we could start with this^^^ [21:54:49] looks like a good start MaxSem :) [21:55:03] but please use the word hygiene in the final commit message ;-) [21:55:44] (03PS2) 10Jdlrobson: Hygiene: Remove dead code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89281 [21:56:32] (03CR) 10Kaldari: [C: 04-1] "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89282 (owner: 10Jdlrobson) [22:00:26] (03CR) 10MaxSem: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89282 (owner: 10Jdlrobson) [22:00:38] (03PS3) 10Jdlrobson: story 1264 (2/2): Add click tracking to nearby page and geo(nota)hack overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88913 [22:00:39] (03PS3) 10Jdlrobson: Story 1264: Promote Geo(not a)Hack to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88912 [22:01:34] (03CR) 10Jdlrobson: "(3 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89282 (owner: 10Jdlrobson) [22:03:23] (03CR) 10MaxSem: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89282 (owner: 10Jdlrobson) [22:06:32] (03PS5) 10Jdlrobson: Hygiene: Cleanup the progress bar FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89105 [22:07:12] (03PS2) 10Jdlrobson: Address a fixme with title building [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89342 (owner: 10MaxSem) [22:07:51] (03PS3) 10Jdlrobson: Hygiene: Address FIXME for title building in MobileDiff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89342 (owner: 10MaxSem) [22:08:37] (03CR) 10Jdlrobson: [C: 032] Hygiene: Address FIXME for title building in MobileWatchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89342 (owner: 10MaxSem) [22:09:14] (03Merged) 10jenkins-bot: Hygiene: Address FIXME for title building in MobileWatchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89342 (owner: 10MaxSem) [22:11:07] (03CR) 10Jdlrobson: [C: 04-2] "It's apparently a WIP according to title so making sure it doesn't get merged ;-)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89345 (owner: 10MaxSem) [22:11:43] jdlrobson, any code comments about ^^? [22:18:47] it looks very sane to me MaxSem (assuming "$column IN (2, 4)"; is the same as $conds['rc_namespace'] = array(2, 4); [22:19:11] were you planning to do any more? add tests for example? [22:19:34] tests for special pages suck [22:19:38] (03CR) 10Jdlrobson: "In terms of the code itself it doesn't look terrible - not sure why marked as WIP" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89345 (owner: 10MaxSem) [22:19:49] so MaxSem is it a WIP or not? [22:20:08] because I was going to demo a strategy with it and continue after coming to agreement [22:20:43] MaxSem: any issues with https://gerrit.wikimedia.org/r/89281 ? [22:20:52] MaxSem: sounds great :) [22:21:10] (03PS10) 10Kaldari: Adding user to last modified [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 [22:21:28] (03PS2) 10MaxSem: Hygiene: factor out common code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89345 [22:21:41] (03PS4) 10Jdlrobson: Fix regression in user profile talk [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89130 [22:21:52] (03PS5) 10Jdlrobson: Regression: talk icon in user profile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89130 [22:22:08] (03Abandoned) 10Kaldari: Add user to last modified [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88681 (owner: 10Kaldari) [22:27:21] (03PS3) 10MaxSem: Hygiene: Remove dead code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89281 (owner: 10Jdlrobson) [22:27:43] jdlrobson, you forgot an orphaned now function:) [22:28:01] oohh more orphans to kill! [22:29:07] (03PS3) 10Dr0ptp4kt: Support language selector on on feature phones. Fixes bug 48752. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/89341 [22:30:24] MaxSem: happy for me to +2 [22:30:33] yup [22:34:10] (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove dead code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89281 (owner: 10Jdlrobson) [22:34:35] (03Merged) 10jenkins-bot: Hygiene: Remove dead code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89281 (owner: 10Jdlrobson) [22:38:08] (03PS4) 10Dr0ptp4kt: Support language selector on on feature phones. Fixes bug 48752. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/89341 [22:40:20] (03PS5) 10Dr0ptp4kt: Support language selector on on feature phones. Fixes bug 48752. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/89341 [22:44:23] ^^yurik, it can obviously wait until after the weekend, but if you happen to be coding on w0 at the moment, a review on change 89341 with a +2 would be welcome. [22:50:54] jdlrobson, what is .talk in pageactions.less? [22:51:54] (03PS11) 10Kaldari: Adding user to last modified [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 [22:53:58] jgonera: 1s [23:04:34] jdlrobson, the talk icon in the user profile looks wrong on master again [23:04:37] at least for me [23:04:43] did my patch get merged? [23:04:45] like if background-size was missing [23:04:47] hm [23:04:57] jgonera: nope: https://gerrit.wikimedia.org/r/89130 [23:04:57] I thought it did [23:06:02] why is border: none needed there? [23:06:14] just tell me this one and I'll merge it now ;) [23:07:00] jdlrobson, ^ [23:07:24] jgonera: try it without [23:07:30] a border appears.. [23:07:55] no difference for me... [23:08:01] (see the refresh cleanup) [23:08:11] oh, only in nearby [23:08:41] (03CR) 10JGonera: [C: 032] Regression: talk icon in user profile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89130 (owner: 10Jdlrobson) [23:08:42] it's a button there rather than a link [23:09:18] (03Merged) 10jenkins-bot: Regression: talk icon in user profile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89130 (owner: 10Jdlrobson) [23:10:52] jdlrobson, I don't know where #ca-talk is created in HTML... I'm leaving this one out... [23:11:22] its magic [23:11:30] *it's [23:11:35] (03PS1) 10JGonera: Story 1030: Clean up CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89358 [23:24:43] (03CR) 10JGonera: [C: 032] Hygiene: Cleanup the progress bar FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89105 (owner: 10Jdlrobson) [23:25:24] (03Merged) 10jenkins-bot: Hygiene: Cleanup the progress bar FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89105 (owner: 10Jdlrobson) [23:28:19] (03CR) 10JGonera: [C: 04-1] "I hate to repeat myself, but this is totally broken in alpha with dynamic loading of pages (old language button shows up and that's it)." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88912 (owner: 10Jdlrobson) [23:30:24] (03CR) 10Jdlrobson: "Sorry missed that - my fixes only focused on the inline comments. Will take another look." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88912 (owner: 10Jdlrobson) [23:31:41] so jdlrobson, when would we have a drawer open and an overlay? shouldn't we close the drawer before opening an overlay? [23:32:52] jgonera: kenan or the designers never specified. I have no preference either way [23:33:26] (03CR) 10JGonera: [C: 032] Story 1072: KeepGoing CTA [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87426 (owner: 10Jdlrobson) [23:33:56] (03Merged) 10jenkins-bot: Story 1072: KeepGoing CTA [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87426 (owner: 10Jdlrobson) [23:34:34] (03CR) 10JGonera: [C: 032] story 1264 (2/2): Add click tracking to nearby page and geo(nota)hack overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88913 (owner: 10Jdlrobson) [23:34:39] (03CR) 10jenkins-bot: [V: 04-1] story 1264 (2/2): Add click tracking to nearby page and geo(nota)hack overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88913 (owner: 10Jdlrobson) [23:38:11] (03PS4) 10Jdlrobson: Regression: Fix empty watchlist message styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89333 (owner: 10JGonera) [23:38:13] ^ jgonera i made a minor change [23:38:56] just a FIXME and a display block to ensure it looks like stable [23:39:02] (on enwiki) [23:39:02] jdlrobson, only CSS or PHP too (or is it a rebase)? [23:39:12] stable? [23:39:20] jgonera: https://gerrit.wikimedia.org/r/#/c/89333/4/less/specials/watchlist.less [23:39:35] well jgonera if you look at enwiki with an empty watch list the back home button is on the far left of the screen [23:39:46] yes [23:39:56] (03CR) 10Jdlrobson: [C: 031] "Feel free to +2 if you are happy with my changes" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89333 (owner: 10JGonera) [23:39:57] how is it different? [23:40:14] jgonera: display: block; [23:41:15] resize your browser... [23:41:15] oh, ok, I tested only with mobile screen size [23:41:25] (03CR) 10JGonera: [C: 032] Regression: Fix empty watchlist message styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89333 (owner: 10JGonera) [23:42:35] (03Merged) 10jenkins-bot: Regression: Fix empty watchlist message styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89333 (owner: 10JGonera) [23:43:52] (03PS2) 10JGonera: Story 1030: Clean up CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89358 [23:44:14] (03PS1) 10Dr0ptp4kt: Reinstate interstitial warning for switch to Desktop. See bug 52536. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/89366 [23:45:02] (03PS6) 10Jdlrobson: Make watchlist user icons consistent with rest of UI [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86052 [23:45:35] (03CR) 10Jdlrobson: "Good to go now the echo icon is no longer a smiley face.." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86052 (owner: 10Jdlrobson) [23:46:48] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89282 (owner: 10Jdlrobson) [23:51:53] ^^^^yurik, for after the weekend. also just emailed you like on the others