[00:03:03] (03CR) 10Reedy: [C: 032] Localisation updates from http://translatewiki.net. [apps/android/commons] - 10https://gerrit.wikimedia.org/r/89638 (owner: 10L10n-bot) [00:03:10] (03CR) 10Reedy: [C: 032] Localisation updates from http://translatewiki.net. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/89639 (owner: 10L10n-bot) [00:07:49] (03CR) 10Reedy: [V: 032] Localisation updates from http://translatewiki.net. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/89639 (owner: 10L10n-bot) [05:09:04] (03PS3) 10Mhurd: Better autolayout of login and my uploads items. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/89620 [05:19:54] (03CR) 10Mhurd: "Converted the last remaining gradient buttons to use dynamic height labels." [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/89620 (owner: 10Mhurd) [05:29:05] (03CR) 10Mhurd: "Here's a pretty github diff:" [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/89620 (owner: 10Mhurd) [07:13:29] (03CR) 10Nikerabbit: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 (owner: 10Kaldari) [10:54:40] (03CR) 10Zfilipin: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87565 (owner: 10Zfilipin) [16:16:38] dr0ptp4kt: you are back :) [16:17:06] yurik_, yes sir [16:17:16] it seems google is painfully slow in russia [16:17:25] i'm sure something evily/sinister is brewing [16:19:50] dr0ptp4kt: do you know if Kul or Carolynne are around? [16:21:11] yurk_, i believe they'll be in later today. [16:33:34] dr0ptp4kt: talking to carolynne right now [16:33:45] yurik_, cool [16:35:28] adam, did you see any problems with gmail recently? [16:45:15] dr0ptp4kt: any questions for me? [16:45:21] re patches [16:46:01] yurik_, no, not just yet, anyway. still getting through email, then after the standup i'll get to gerrit. [17:12:51] brion: hey! [17:13:40] mhurd: brion YuviPanda : i'm going to setup the board for sprint 17 but before i do. are all the stories in https://trello.com/b/XkdTvW0Z/mobile-app-sprint-16 still in code review ? [17:14:22] tfinc: yes i believe so [17:14:24] tfinc: added one more to CR that wasn't on it before [17:14:40] k [17:14:44] brion: can you pass me link to the 'de-tableize' patch? [17:24:54] (03PS1) 10Yuvipanda: Merge branch 'campaigns' [apps/android/commons] - 10https://gerrit.wikimedia.org/r/89858 [17:25:14] brion: ^ merging! [17:26:08] YuviPanda: brion: mhurd: i dont see a good room for a sprint kick off so take a look @ https://trello.com/b/XkdTvW0Z/mobile-app-sprint-17 [17:26:17] tfinc: k [17:26:25] you'll notice that we only have 22 story points loaded [17:26:41] in the last two sprints we've attempted 42 & 55 points respectively [17:26:51] but we've only finished 22 [17:27:10] trailing velocity is here https://docs.google.com/a/wikimedia.org/spreadsheet/ccc?key=0AlEIL4N8KjNndHp1LTlmbkFqRkV0amNIRUhxaHdmV1E&usp=drive_web#gid=0 [17:27:33] yeah, I think the inital sprint that dragged on for weeks kinda threw us off. [17:27:55] tfinc: 22 in *code review* i think. didn't we finish more though? [17:28:02] mhurd: nope [17:28:08] tfinc: huh! [17:28:14] there were only 22 points that were in the done column [17:28:17] s/only/ [17:28:53] tfinc: let's shoot for 30? [17:29:10] not with that code review column were not [17:29:13] and were down a day [17:29:37] plus brion is only with us mwf due to architecture resonsibilities [17:29:45] hmm, ok [17:29:49] oh [17:29:49] right [17:29:56] is he going to be online today? [17:29:59] if the code review column was empty then i'd pad it [17:30:04] yeah he will [17:30:09] tfinc: i'm not seeing some cards i finished during sprint 16... [17:30:20] mhurd: because i archived them ? [17:30:45] YuviPanda: here are our trailing stats https://docs.google.com/a/wikimedia.org/spreadsheet/ccc?key=0AlEIL4N8KjNndHp1LTlmbkFqRkV0amNIRUhxaHdmV1E&usp=drive_web#gid=0 [17:31:10] tfinc: true, but there are 22 points in the code review column which doesn't reflect the "done" cards. so still confused about 22 [17:31:35] mhurd: there were 22 points in the code review column and there were 22 points in the done column [17:31:49] all separate stories [17:31:58] tfinc: ah. so 44 points this sprint [17:32:24] mhurd: you can add those two but it doesn't tell you much as you then have to include the ready for dev column [17:32:36] mhurd: we actually attempted 55 story points [17:32:44] but only completed 22 points [17:32:55] if we had finished code review then we would have come out better [17:33:03] tfinc: makes sense [17:33:12] it shows us that we have a code review backlog that we need to improve on [17:33:18] very normal and typical [17:33:35] live and learn [17:35:31] tfinc: hmm, okay. if we clear out the CR backlog and also finish the ones in the ready for dev, we'll overshoot the ready for dev, but i guess that's better [17:35:58] YuviPanda: actually hold on the 22 vs 30. i'm calling bs on the trello extension number. doing a re-count :) [17:36:21] heh [17:36:21] ok [17:37:15] yup. manual count shows 30 :) [17:37:33] tfinc: huh! [17:37:40] so 30 finished. and 22 in code review [17:37:56] tfinc: right, so our velocity last time was 30, not 22 [17:38:10] YuviPanda: it was not [17:38:23] i'm confused again [17:38:23] '30 finished'? [17:38:25] nope [17:38:33] look at https://docs.google.com/a/wikimedia.org/spreadsheet/ccc?key=0AlEIL4N8KjNndHp1LTlmbkFqRkV0amNIRUhxaHdmV1E&usp=drive_web#gid=0 [17:38:53] oh i thought you mean the 9/16 - 9/27 [17:39:06] no, 9/30 - 10/11 [17:39:09] if you were talking about the sprint just finished then yes [17:39:14] velocity was 30 [17:39:33] let me load us up to 30 story points [17:39:37] yeah [17:41:40] YuviPanda: brion : what did you come up with design about https://trello.com/c/Cs8q48sh/225-ux-bug-45408-in-my-uploads-view-there-are-blank-placeholders-for-deleted-images ? [17:41:51] i'd love to take it on but as of now the card is not actionable [17:42:27] mhurd: can i get a gut check estimate on https://trello.com/c/B9u8PKnT/112-when-keyboard-is-entering-text-for-the-image-title-the-keyboard-shows-a-done-button-but-should-show-a-next-button-to-move-text-i? [17:42:51] tfinc: 1 [17:43:09] thanks. brion: feel free to gut check on that one one you sign on [17:43:36] tfinc: brion was supposed to meet up with kaity right after that, but if not we can get away with generic 'X' signs that android ships by default [17:43:55] YuviPanda: let me mail them and ask [17:44:31] ok mailed [17:44:34] tfinc: ok [17:45:46] YuviPanda: were at 29 story points now and i'm going to wait till kaity and brion to get back to me [17:46:08] tfinc: ok [17:47:04] oh man. having story points and a trailing velocity makes this so much easier to think about [17:47:08] awjr: --^ [17:47:09] :D [17:47:18] awjr: https://docs.google.com/a/wikimedia.org/spreadsheet/ccc?key=0AlEIL4N8KjNndHp1LTlmbkFqRkV0amNIRUhxaHdmV1E&usp=drive_web#gid=0 [17:48:10] and we don't have to suffer through mingle for it! [17:48:10] :D [17:48:22] if the charg works well for us i bet we can automate the creation of it [17:48:23] YuviPanda: i have to suffer without it [17:48:31] YuviPanda: it requires me to do a lot of manual work [17:48:48] YuviPanda: which im ok for now but we'll see as time goes on [17:48:49] (03CR) 10Kaldari: "Still -2" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 (owner: 10Kaldari) [17:49:00] tfinc: yeah, sure. [17:49:09] YuviPanda: i may ask you to trouble shoot the chrome extension if it keeps miscounting [17:49:10] tfinc: it should be easily automatable though, in the same vein as bingle or bugello [17:49:23] is it open source? [17:49:24] hopefully [17:53:25] YuviPanda: http://github.com/Q42/TrelloScrum. [17:53:54] tfinc: ah, right [17:54:04] * YuviPanda stars [17:54:18] mhurd: brion YuviPanda: any other questions/concerns about https://trello.com/b/XkdTvW0Z/mobile-app-sprint-17 ? this is our final sprint on the commons app [17:54:45] tfinc: android / server parts look okay to me [17:54:49] especially when combined with CR [17:54:50] at most we'll do tiny bug fixes after. no feature work [17:54:55] tfinc: looks good! [17:54:59] yeah [17:55:07] and we'll re-asses in Q3 after fabrice comes back to us [17:55:18] makes sense [17:55:27] sweet then i call sprint 17 to order! [17:55:37] AYE AYE SIR! [17:55:39] no lets get through the horrible code review column [17:55:44] YuviPanda: haha [17:58:36] awjr, I see no video link for today's kickoff [17:59:09] oops MaxSem probably because it was a one-off invite. try now? [17:59:43] "You're not allowed to join this video call." [18:01:13] @_@ [18:01:14] me neitehr [18:01:28] erase/rewind? [18:01:31] yeah… fml [18:01:46] one sec [18:02:00] https://plus.google.com/hangouts/_/ffe83ad24f91e6313200a35f5055ffb1d4a4bf75?authuser=1&hl=en [18:02:22] awjr: you'll have to do an adhoc hangout [18:02:29] tfinc already done [18:02:29] https://plus.google.com/hangouts/_/ffe83ad24f91e6313200a35f5055ffb1d4a4bf75?authuser=1&hl=en [18:02:34] i added it to the description of the invite as well [18:04:05] mhurd: slightly off topic, but I think me and brion managed to find a way to do 'real' realtime notifications for Android in an elegant way :) [18:04:31] YuviPanda: nice! how? [18:04:45] mhurd: Extension:MobileApp, and then hook into Echo :) [18:05:03] mhurd: and use Google Cloud Messaging for Android, and then do our own encryption on top so Google doesn't know what we're talking about [18:05:08] mhurd: i guess there's something similar for iOS? [18:05:16] like Google Cloud Messaging, that is [18:05:29] YuviPanda: yes i believe so [18:05:36] mhurd: yeah, so we can do that too :D [18:05:42] YuviPanda: ya! [18:06:03] kaldari: click on our video in the hangout so that it loses focus [18:06:17] mhurd: so no need to compromise between user privacy (Google / Apple knowing which wikii user is on which device) vs battery effeciency (background process checking once in a while) [18:06:43] otherwise we'll always see ourselves :) [18:06:51] no matter whose talking [18:07:09] self reflection! [18:10:32] YuviPanda: hows the wrist doing ? [18:10:44] tfinc: painkillers are wonderful [18:10:48] kaldari: looks like it hasn't lost focus [18:11:00] tfinc: plus I'm now with a proper 'rented' chair + a mech keyboard, so *much* better [18:11:08] YuviPanda: hurrah [18:11:24] tfinc: still can't lift things, or use it anywher else. but i can at least brush with it! [18:11:24] we'd prefer you not being a total wrist gimp when you arrive [18:11:31] progress ? [18:11:32] so progress [18:11:32] tfinc: yeah [18:11:43] tfinc: as in, now I could brush my teeth with my right hand [18:11:51] tfinc: couldn't do that last week [18:39:33] * YuviPanda pokes brion again [18:39:34] mhurd: is brion in the office? [18:39:44] YuviPanda: haven't seen him [18:40:07] hmm ok [18:46:20] (03PS2) 10Jdlrobson: Hygiene: Turn getHtmlBetaAlphaOptIn into a static reusable method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89282 [18:46:41] YuviPanda: mhurd brion : https://trello.com/b/TvfzwNZf/mobile-design hasn't been active since July [18:46:56] any reason to no close it ? [18:46:58] not* [18:47:28] team! so far I've seen only one revision from jcmish that she wants to have deployed today [18:47:32] anything else? [18:47:49] tfinc: it's a ghost town… close away [18:48:04] tfinc: looking over your notes from earlier now [18:48:56] tfinc glad the velocity thing is working for you all :) [18:49:41] tfinc: close it [18:50:04] jcmish, can you explain why is that revision important to have in prod? [18:50:29] mhurd: just txt'd brion [18:53:04] yes because it has a change to fix the beta toggle [18:53:30] so until it's in prod MaxSem it'll spam us as a broken test and that toggle isn't working correctly [18:53:41] it's a low risk patch too [18:53:50] okay [18:54:10] ah don't see Kenan, should I get him to confirm MaxSem ? [18:54:26] jdlrobson, jgonera - anything else urgent for MaxSem to deploy today? [18:59:43] okay - no response, no deploy. only Michelle's change will go out;) [19:00:04] greg-g, can you confirm that we still have a window today? [19:01:30] MaxSem: ....I thought you were riding the train? [19:01:36] did something break last week? [19:01:57] greg-g, yep - but we've never surrendered the window:) [19:02:13] well, define surrender ;) [19:02:16] but, what do you need [19:02:17] ? [19:02:40] we need to deploy https://gerrit.wikimedia.org/r/#/c/89144/ to STFU the tests [19:03:39] MaxSem: lightning deploy? [19:03:43] MaxSem: gotcha, well the schedule is open until the lightning deploy... [19:04:02] either LD or before. Growth is doing something in the LD you could tag along with [19:04:31] greg-g, the schedule is misleading ATM - we still have a window in ongoing deployments, but not in this week's [19:05:07] ideally, we should retain the window for accidental deployments until stuff gets very smooth:) [19:05:19] MaxSem: LDs [19:05:25] ;) [19:05:35] greg-g, what if we need to scap? ;) [19:05:55] given you're the awesome group to be the first to ride the train since the quickening of the cycle, you get a pass ;) [19:11:07] greg-g, so LD is the way to go? [19:11:59] MaxSem: that's fine yeah, if you can wait that long (sounds like you can?) [19:12:11] we can [19:12:24] err, jcmish is gone [19:15:18] mhurd: confirmed http://www.theverge.com/2013/10/15/4840404/apple-event-october-22-ipads [19:19:42] tfinc: nice! [19:20:53] tfinc: I'll hopefully be able to get the laptop I need this time I'm around. Let's hope Dell XPS 15 is available by then [19:20:56] will email you and oit when i've figured out [19:33:46] is kenan on here? [19:33:55] not at the moment, violetto [19:34:14] violetto: unless he's using a secret nick… he's usually 'kenanwang' [19:36:59] okay thanks, i just got a hold of him now [19:37:39] MaxSem: did the thanks styling fix get applied in the end? [19:37:56] the one that kaldari provided a patch for and was going to deploy? [19:38:15] jdlrobson, that's what we deployed last week? [19:38:23] jdlrobson: No, it didn't get merged in time [19:38:28] arrgh [19:38:42] argh indeed [19:39:02] it was this one - https://gerrit.wikimedia.org/r/#/c/89122/ [19:48:23] oy [19:49:30] woo, a brion [19:49:31] * YuviPanda attacks brion with https://gerrit.wikimedia.org/r/89853 and https://gerrit.wikimedia.org/r/#/c/89858/ [19:49:46] my sleep schedule's all fucked up, i napped all morning by accident :( [19:49:54] brion: i've tasked a friend with dragging me into bed by 2AM everyday :D [19:49:56] brion: awww [19:50:46] hah [19:51:14] brion: think i can get quick reqview on those two before that? [19:51:17] that's like.,.. 40mins away :D [19:52:07] yes :D [19:52:11] brion: the campaign merge needs some testing, tho. I think it broke retry, for example. [19:52:11] but oh well [19:53:17] hey brion! [19:53:22] jdlrobson, https://bugzilla.wikimedia.org/show_bug.cgi?id=51991#c7 [19:53:39] hey mhurd [19:53:58] mhurd: oh thanks for reminding me about the iOS key thing [19:53:59] a wolf has 100 ways to go, a hunter has only one [19:54:13] let's poke that tomorrow when i'm in the office [19:54:20] brion: sounds good! [19:54:23] is bart running tomorrow? [19:54:44] ok so far so good..... tomorrow then :D [19:54:52] i'll have to look up all the keychains tuff [19:55:19] i just made a fresh os x virtual machine for testing the 10.8 version of safari, i can use it as a 'blank slate' keychain ;) [19:55:33] brion: nice [19:55:54] incidentally, os x VMs are kind of a pain -- you have to install from the recovery partition [19:56:08] which means if you want to install the previous version of osx you have to dig up an old machine :P [19:56:21] brion: really? that's weird [19:56:32] yeah there might be another way but i never had luck trying to install from a .dmg [19:56:38] and they don't ship plain .isos anymore [19:56:43] anyway.... lemme review stuff for yuvi :D [19:56:53] brion: ugh, after new deployment, http://commons.wikimedia.org/w/api.php?action=query&list=allcampaigns&uwlimit=1 doesn't even return :| [19:56:53] wat [19:57:01] brion: http://commons.wikimedia.org/w/api.php?action=query&list=allcampaigns doesn't either [19:57:06] hmm [19:57:10] that doesn't sound good [19:57:20] YuviPanda: try it with a small limit [19:57:26] oh that was a small limit [19:57:27] well shit :D [19:57:33] brion: http://commons.wikimedia.org/w/api.php?action=query&list=allcampaigns&uwlimit=1 is with a 1 [19:57:34] limit [19:57:43] brion: it 500'd [19:57:54] you got some debugging to do friend [19:58:00] brion: oh i have a couple commits for you in gerrit [19:58:02] brion: on both [19:58:02] :D [19:58:03] err [19:58:05] u:'( [19:58:14] \o/ [19:58:33] brion: https://test.wikipedia.org/w/api.php/?action=query&list=allcampaigns is much faster than it was before [19:58:36] brion: i'm so confused now [19:58:59] :( [19:59:04] brion: did more on the login auto layout over the weekend for the user name and pwd box auto layout story. the colors are a bit different but we can tweak [19:59:15] awesome [19:59:43] YuviPanda: pooh! my campaigns api request eventually returned data on commons [19:59:52] heh... json blobs in xml :D [19:59:55] brion: after how long? [20:00:05] like... a long time [20:00:08] i just noticed the tab was done [20:00:36] ok i can now fetch https://commons.wikimedia.org/w/api.php?action=query&list=allcampaigns&uwlimit=1 fairly regularly [20:00:42] mtg anyone? [20:00:44] oh hey that uwlimit is not recognized :) [20:01:00] brion: yeah [20:01:00] brion: i guess cache stampede? :) [20:01:07] brion: gah, uclimit [20:01:09] yeah, i suspect so [20:02:06] brion: i'm doing one with uclimit=500 [20:02:07] YuviPanda: yeah i'm betting it's just hitting lots of items and having to parse/cache them [20:02:09] should 'prime' the caches [20:02:10] heh [20:02:26] YuviPanda: so i was thinking earlier we might want to limit more aggressively the number of items returned, if they're not cached [20:02:49] turned off video/sound so y'all dont have to watch me stuff the last of my sandwich in my face [20:02:50] it'd still take a while to get through the full list after a cache clear though [20:03:02] in HD [20:03:10] brion: yeah, but hopefully not all of them will cache clear at once [20:03:27] tfinc: sorry i wasn't online earlier -- sleep schedule's all messed up, fell asleep for a couple hours and left my phone downstairs. catching up on review with yuvi now [20:03:28] awjr: heh, my video feed is in retina resolution :P [20:03:38] ooooooooh HD [20:03:38] awjr: all black! [20:03:43] lol [20:03:54] hard-to-see definition [20:04:20] haha [20:05:43] brion: uclimit=500 timedout for me [20:05:50] yeah i don't doubt that :D [20:07:34] brion: okay, 3s now :) [20:07:42] brion: for 500 [20:07:42] so not bad! [20:07:50] brion: and i blame my connection [20:07:53] brion: try http://commons.wikimedia.org/w/api.php?action=query&list=allcampaigns&uclimit=500 [20:08:27] YuviPanda: yeah now ask in another language... it'll have to re-render the whole batch :( [20:08:41] brion: yeah [20:08:45] brion: ways around it? [20:08:53] brion: i don't know if we can 'do less work!' [20:08:56] heh [20:09:04] brion: because wikitext parsing is nice and imo needed [20:09:32] brion: we could limit max number of campaigns requested [20:09:34] so there's a few possibilities ranging from 'create a JobQueue item to pre-render them for you' ... [20:09:44] brion: in all the languages? terrible! [20:09:47] ...to 'when fetching the list, only parse the title so we do less work' :) [20:10:12] brion: well, that'll be cache fragmentation... ;) [20:10:22] brion: but yeah, a 'prop=titles' 'prop=titles|description' might work [20:10:35] *nod* [20:10:43] brion: can you file bugs? [20:10:46] ok [20:10:56] brion: i've 10 mins left before someone drags me off [20:11:01] heh [20:11:08] YuviPanda: special page looks fine, i've +2'd that [20:11:21] brion: yeah, saw that :D [20:11:25] prtksxna said he can hook up a design for it at some time [20:11:34] brion and i'll prettify it then [20:11:37] brion: for edit page, i'm thinking of using Swig [20:11:39] the other one is a merge of the entire campaigns branch? or is it just a tidy up on the branch? [20:11:47] brion: merge of campaigns into master [20:11:52] yeah def try that out [20:11:58] brion: so nothing that we've not already +2'd, but yeay, need to try it out [20:12:03] brion: since it also includes the cotnroller refactor [20:12:09] ok yeah i'll test that up before i merge then [20:12:17] i might have some 'fix this' feedback ;) [20:12:26] brion: think you can spend some time on that today? :D [20:12:32] yeah [20:12:38] brion: sure! [20:14:28] brion: from next project, tests from day 0 :) [20:14:49] yessssss tessssssts [20:18:41] tfinc: https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1296 [20:18:56] thanks [20:19:42] YuviPanda: ok notes for you on the campaigns api - https://bugzilla.wikimedia.org/show_bug.cgi?id=55754 [20:23:21] brion: if you're not reviewing https://gerrit.wikimedia.org/r/#/c/89620/ presently i have a quick amend... [20:23:55] mhurd: go ahead [20:24:02] brion: cool thanks! [20:24:44] (03Abandoned) 10Brion VIBBER: Yay! [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88886 (owner: 10Mhurd) [20:25:18] brion: best commit ever [20:25:25] :) [20:26:04] ah, [back to: [Objective C]] [20:26:12] [I love: brackets] [20:26:26] (03PS4) 10Mhurd: Better autolayout of login and my uploads items. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/89620 [20:31:17] whoa, xcode [20:31:27] i got not one, but *two* "An unknown error occurred" popups [20:31:46] wiiiiierd [20:33:21] (03CR) 10Mhurd: "Updated github diff:" [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/89620 (owner: 10Mhurd) [20:34:12] dr0ptp4kt: is there a meeting? [20:34:26] (03PS1) 10Jdlrobson: Fix bad PHP [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90001 [20:34:27] ^ MaxSem eek :) [20:35:12] (03CR) 10MaxSem: [C: 032] "I'ts not bad, it's simply stupid;)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90001 (owner: 10Jdlrobson) [20:35:21] jdlrobson, I've finished analysis of yet another section weirdness [20:35:35] the outcome was "WE ARE DOOMED" [20:35:52] MaxSem: did Idd1821b1c0c97e83bd5b3bdb48a7ae98d3788327 get deployed? [20:35:53] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ah, this is nice. :D Seems to work as expected on iOS 6 & 7. Yay!" [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/89381 (owner: 10Mhurd) [20:35:57] (before we talk about that) [20:36:08] (03Merged) 10jenkins-bot: Fix bad PHP [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90001 (owner: 10Jdlrobson) [20:36:31] yurik_, jumped on [20:36:36] YuviPanda: still here? any chance to look over https://gerrit.wikimedia.org/r/#/c/89339/ ? [20:36:41] or i'll just poke you later ;) [20:36:47] he's on a phone call [20:36:49] so i've a few mins [20:36:58] yeah, too big for a few mins [20:36:58] heh [20:37:03] ok later then :D [20:37:05] thanks! [20:37:12] brion: will do tomo [20:37:24] brion: awesome. the remaining commit contains fixes for the rest of the items i put in "code review" column [20:37:52] woohoo [20:38:05] mhurd: oh for reference can you paste the gerrit URL into the comments on a card when you move it to in review? [20:38:08] makes it easier to find :D [20:38:13] MaxSem: are you looking? [20:38:20] brion for sure! [20:38:40] because if it was deployed we should think about lightning deploying https://gerrit.wikimedia.org/r/90001 as we're generating bad CSS [20:38:48] jdlrobson, on wmf21 but not wmf20 [20:38:57] so on mediawiki.org and testwiki? [20:39:12] http://noc.wikimedia.org/conf/highlight.php?file=wikiversions.dat [20:40:11] i suggest we considering lightning deploying it then - i'm worried that an old browser might choke if it is given invalid CSS [20:41:03] can do:) [20:43:11] mhurd: brion YuviPanda : day one and we have 9 story points done [20:43:15] YuviPanda: did you self review? [20:43:33] mhurd: --^ [20:43:33] jdlrobson, about sections... [20:43:34] tfinc: nope, brion :P [20:43:37] sweet [20:43:49] whee [20:43:49] i still haven't seen him today which is frustrating for all of us [20:44:04] MaxSem: sure. so why are we doomed? [20:44:24]

sec1