[00:00:07] tfinc: oh that's fixed and merged as of today. i had to use "go" rather than "login" though as "login" isn't on the preset list of button titles apple lets you choose from. [00:00:53] no, not that one [00:00:54] (03PS1) 10JGonera: Hygiene: Clean up overlays.less and pagelist.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90068 [00:01:23] mhurd: "On settings,its confusing that the radio buttons and links are identical in appearance" [00:01:42] tfinc: ah. can do, though i don't agree it's confusing [00:01:55] then feel free to respond on the thread [00:02:12] tfinc: will do [00:02:19] (03PS2) 10JGonera: Hygiene: Clean up overlays.less and pagelist.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90068 [00:08:59] (03PS1) 10Jdlrobson: Hygiene: Add namespace helper function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90070 [00:09:00] (03PS1) 10Jdlrobson: Remove dead search button code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90071 [00:09:01] (03PS1) 10Jdlrobson: Ensure namespace is passed when history code loaded [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90072 [00:16:28] (03PS3) 10JGonera: Story 1269: AbuseFilter support [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88899 [00:17:35] (03PS4) 10JGonera: Story 1269: AbuseFilter support [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88899 [00:18:30] (03PS5) 10JGonera: Story 1269: AbuseFilter support [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88899 [00:20:22] tfinc does bugello appear to be working for teh apps team atm? [00:20:55] monty brion YuviPanda|zzzz ^ [00:21:26] oh [00:21:33] dr0ptp4kt: i think i might see the problem with bugello for you guys [00:22:38] dr0ptp4kt: it looks like the name of your board changed, which is causing bugello to fail [00:22:49] awjr: generally yes [00:24:22] dr0ptp4kt: you should see bugs coming in now [00:24:34] thanks tfinc [00:25:27] awjr, thanks man! [00:25:37] np dr0ptp4kt, easy fix :) [00:27:19] awjr: did you have a chance to look at https://docs.google.com/a/wikimedia.org/document/d/1pu9AqpaVjW0uTaJMEc6mlWoFtYmMWWQeWmSYNQJnrOo/edit ? [00:28:25] not yet tfinc [00:28:30] later this week [00:28:51] awjr: thanks [00:43:08] (03PS12) 10Kaldari: Adding user to last modified [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 [00:43:12] (03CR) 10jenkins-bot: [V: 04-1] Adding user to last modified [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 (owner: 10Kaldari) [00:43:36] (03PS1) 10Jdlrobson: Don't let headings be HTML [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90075 [00:44:47] (03PS13) 10Kaldari: Adding user to last modified [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 [00:45:00] (03CR) 10Kaldari: Adding user to last modified [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 (owner: 10Kaldari) [00:46:22] jdlrobson: https://gerrit.wikimedia.org/r/#/c/87298/ is ready for review now. Such a simple change required editing 14 files :P [00:48:55] jgonera: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/VectorBeta [01:18:39] (03PS1) 10Jdlrobson: Add topics to the correct namespace [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90079 [01:20:26] (03CR) 10JGonera: [C: 04-1] "(3 comments)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 (owner: 10Dr0ptp4kt) [01:21:46] (03PS6) 10Jdlrobson: Story 1269: AbuseFilter support [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88899 (owner: 10JGonera) [01:28:33] (03CR) 10Jdlrobson: "Juliusz had a good idea - let's simply make it a history link for non-JavaScript users and only add the profile link in JavaScript. This w" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 (owner: 10Kaldari) [05:38:12] (03CR) 10Yuvipanda: [C: 04-1] "Looks blocky and terrible on my phone, and takes far far too much space." [apps/android/commons] - 10https://gerrit.wikimedia.org/r/89339 (owner: 10Brion VIBBER) [05:38:18] (03PS2) 10Yuvipanda: UI matching in detail view to iOS version [apps/android/commons] - 10https://gerrit.wikimedia.org/r/89339 (owner: 10Brion VIBBER) [06:02:21] (03PS1) 10Yuvipanda: Provide usable menu actions for Media object pagination too [apps/android/commons] - 10https://gerrit.wikimedia.org/r/90086 [13:33:25] morning all [14:53:11] hi brion [14:53:26] hey YuviPanda [14:53:28] what's up [14:53:35] wrist got worse today [14:53:36] oh well [14:53:52] :( [15:03:18] brion: tested the merge? [15:03:31] not yet sorry [15:03:45] brion: if we want campaigns out next week hopefully we can get that merged in a few days [15:05:06] well, do we want campaigns in the main release or in a beta, or behind a config switch, or what's the plan currentyl? [15:06:48] brion: i am thinking beta [15:06:57] brion: or a config switch [15:07:20] *nod* don't want it pinging campaign list until we've got that all sorted out :) [15:07:26] brion: heh, yeah [15:08:22] brion: still, the thing I want us to test is the controller refactor and stuff [15:08:33] brion: since that affects everything [15:08:40] brion: so even if we ship it with campaigns completely disbaled... [15:09:40] *nod* [15:09:56] lemme put that on my 'must do today' list :D [15:10:53] brion: whee [15:10:59] YuviPanda: oh and we should sync up with monte about the detail page design, i think we want to tighten it up a bit and be both in sync and awesome looking [15:11:11] it got a little extra blocky during recent refactors [15:11:22] brion: hmm, ping design? :P [15:11:36] brion: i don't know if it is a 'must have' for the 'last' for a while release [15:11:36] yeah prolly [15:11:51] it'd be nice to fix though, the current display is not too pretty either :) [15:12:04] yeah, but not that blocky [15:12:31] :) [15:13:03] ah shit i have to update the translatewiki config for iOS too [15:13:05] * brion adds to the list [15:15:33] ah, that apple event that was rumored for the 15th got pushed to the 22nd [15:16:33] brion: are you doing android dev on an air? [15:16:36] i've started to hate it [15:16:42] almost 30s compile time [15:17:09] come to the dark side -- iOS compiler is faster! ;) [15:17:41] brion: heh [15:17:45] brion: are you using the Air? [15:17:47] brion: or the rMBP? [15:17:53] no mostly using the rMBP [15:17:59] which is pretty nice :) [15:19:56] brion: heh. [15:20:09] brion: if I can't find a nice non apple laptop I might just give up and get that [15:20:57] i can't vouch for the 13" (different GPU and such) but i've been very happy with the 15" [15:22:13] oh fun, it's ubuntu 13.10 time [15:23:05] i'll have to flash my old phone again, see how that runs :D [15:23:16] brion: heh [15:24:04] i just wish ubuntu weren't doing their own window manager and display server. :P i *like* gnome 3, i'm some kind of weirdo ;) [15:29:32] brion: heh [15:29:33] brion: okay, food time [15:29:44] see ya in a bit :) [16:27:38] jon's not here? [16:43:42] greg-g: not right now [16:44:34] YuviPanda: no worries, thanks [16:55:12] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 (owner: 10Kaldari) [17:01:49] greg-g: ^ [17:02:13] jdlrobson: standup? [17:02:13] awjr: technical issues... [17:02:16] k [17:12:08] brion: i was hacking at https://trello.com/c/kXPlgG6w/110-3-accounts-bug-41704-commons-app-doesn-t-handle-changed-login-passwords-properly and it looks to be harder than thoguht :| [17:12:25] brion: i've added a 'signout' button to settings, think you can pick that card up at some point? not urgent, maybe [17:12:34] brion: i want to finish off campaigns support [17:12:38] on the app [17:12:49] YuviPanda: yeah sounds good [17:17:06] so awjr as long as the information in that bug gets recorded somewhere - wiki page / story i'm fine with a WONTFIX [17:17:23] i never know where to record this stuff [17:17:24] jdlrobson: ok cool - i'll follow up with kenan [17:17:36] i like bugzilla as it is the most public thing we have and it gets more discussion [17:17:47] jdlrobson: i dont think design/product really look at bugs that much unless they're forced to [17:17:57] jdlrobson: so that's probably a better question for them :) [17:18:14] awjr: not true [17:18:22] awjr: if i add the design tag jared always looks at them [17:18:46] jdlrobson: oh good! [17:18:51] that's great [17:37:02] awjr: when you guys retrospect do you go over the what didn't work well first or last ? [17:38:48] tfinc: last [17:38:56] thanks [17:38:58] tfinc: nice to get the positive vibes going first :) [17:39:08] yeah, i've long wavered where to put it [17:39:13] nothing has felt "right" [17:40:33] * jgonera going to the office, be back in 30 min [17:49:17] awjr: hey can we start a new iteration/ [17:49:18] ? [17:49:39] kenanwang: you mean the next one after honey badger? [17:49:52] yep [17:50:05] on mingle [17:50:12] yeah, sorry i usually get that set up when i roll over the new iteration [17:50:18] give me a few minutes [17:50:36] kenanwang: i need a tentative iteration name; an animal that starts with 'i' [17:50:37] the letter is I, what animal should it be?:P [17:50:43] we can vote on it later, but i need a placeholder :) [17:50:48] jdlrobson, MaxSem [17:50:53] kaldari ^ [17:51:18] iguana? [17:51:20] ibis? [17:51:25] oo [17:51:43] im going with ibis because i dont know it is [17:51:43] Illithid [17:51:51] we can brainstorm/vote later [17:51:55] ilmao [17:52:07] !! [17:52:10] wtf are these things [17:53:50] also we have a list of "not set" story cards that we should clean up awjr [17:54:05] ok kenanwang, it is done and i added an 'ibis' column to iteration planning [17:54:10] 'not set' kenanwang? [17:54:20] lemme see [17:54:44] kenanwang: i dont see any stories with 'not set' as a status [17:57:37] kaity|away, violetto, kenanwang: jdlrobson captured some UX/design ideas for user profiles in a bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=55627 - is that the place for you all to capture ideas/conversation like that, or do you prefer it somewhere else? [17:57:41] YuviPanda: brion mhurd : feel free to fill out https://etherpad.wikimedia.org/p/MobileAppRetrospective before we kick off. i have a feeling the meeting in our room will run late [17:57:53] tfinc: ok [17:57:56] tfinc: sent out some possible interview coding task ideas [17:58:22] awjr: I'd rather have them as stories [17:58:45] especially looking for feedback from awjr and MaxSem since they are back-end tasks. [17:58:59] cool kaldari, i'll look at some point today [17:59:07] awjr: if you go to iteration planning its one of the columns now "not set" [17:59:42] brion: mhurd YuviPanda : i shall name you guys if you don't on the etherpad [17:59:53] tfinc: oops [18:00:35] heh [18:00:44] (03PS1) 10Mhurd: Scrolling description text now pre-empts scrolling details view. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/90172 [18:00:46] ah - kenanwang that 'not set' means those stories are not part of a particular backlog, they're just orphaned; but im pretty sure we went over those when we went through the backlogs a few weeks ago [18:01:17] i think, at least - is there anything in there you want to keep, kenanwang? [18:01:27] awjr: ahh, can't see anything [18:01:33] k [18:02:00] kenanwang: yeah i forgot to delete the stories we didn't want anymore from the backlogs like i said would [18:02:55] kenanwang: im cleaning them up now [18:30:52] brion: did you look at the screenshot of the app as it looks on my phone? [18:30:59] brion: it's not just 'blocky', the padding etc seem too big too [18:31:19] YuviPanda: yeah it's awfully big :) but that's about how it looks on iOS currently. we should brainstorm a bit on tidying it up :D [18:31:29] ow, I didn't know that :P [18:32:54] ok let's throw some quick ideas around :D ^ mhurd [18:33:26] so i really like the spacing between elements that resulted in just letting auto layout determine spacing [18:33:58] mhurd: https://test.wikipedia.org/wiki/File:Blocky_and_terrible.png on Android [18:33:58] it's a bit .... undense though :) [18:34:11] mhurd: brion plus the white on black seems a bit ugh [18:34:47] i would darken the backgrounds a bit [18:35:22] and add a bit of padding between below the "title" "description" etc [18:35:50] awjr: sweet thanks [18:35:58] mhurd: brion this will also be several screenfulls on a screen that's not as large as mine [18:36:05] does it progressively darken as it scrolls up? [18:36:09] mhurd: nope [18:36:12] mhurd: it comes out like this [18:37:19] no i didn't add the darkening [18:37:25] so what i did which seems to work nicely is there is a view behind the elements which scroll up, and as it scrolls this background view darkens which de-emphasizes the image [18:37:37] ok we could def change the tone, the android blocks are lighter than the iOS ones [18:39:01] brion: mhurd still looks like a lot of space to me, tbh. do we really need 'Title', 'Description' to be so big? [18:39:37] brion: mhurd feels a bit 'off' with the rest of the system [18:41:24] (mhurd is typing :) [18:41:47] hah [18:41:54] YuviPanda: what i found was initially i had a the same feeling about the spacing - it seemed too expansive, but after a few days of looking at it, when i went back to the old layout the old layout seemed really cramped. once i got used to the spaciousness i liked it way better. maybe give it a couple days, then if it still seems too spacious re-asses? [18:42:17] mhurd: hmm, or maybe with the tones adjusted it won't look like that? :) [18:42:18] we can certainly change it before next week's release :D [18:42:28] lemme take a quick screenie of the iOS one [18:42:28] mhurd: brion this is also close to android's 'cards', but used in a completely different context [18:42:34] YuviPanda: for sure the tone adjustment will help :) [18:42:50] brion: mhurd plus, smaller screens? [18:43:01] I guess autolayout will reduce the padding proprtionally, but android won't [18:43:44] YuviPanda: https://upload.wikimedia.org/wikipedia/test/d/d2/Blocky_android_and_blocky_ios_side_by_side.png [18:43:45] YuviPanda: haven't noticed that it adjusts it too much [18:44:12] okay, definitely looks much nicer on iOS :) [18:44:15] :) [18:44:24] ok so definitely darken it up [18:44:34] YuviPanda: any thoughts on round vs sharp corners? [18:44:46] an earlier version on iOS had round corners for the fields, i kinda liked that [18:44:48] sharp, definitely :) [18:44:52] oh and add tiny bit of padding under titles [18:45:26] +1 to padding under the title [18:45:36] i'll try rounding on iOS and post screen shots. the area where it may not work so well is the settings page where i use outline to denote selection... [18:45:40] also can we not have a blank box if the field is empty (description) but... something else? [18:45:54] YuviPanda: yeah we can probably just hide the field or something [18:45:59] yeah [18:46:00] probably [18:46:13] and that should be easy on both iOS w/ auto layout and android w/ LinearLayout [18:46:14] on iOS i think i put "Description not found" or some such [18:46:25] that works too, description should usually be there :D [18:46:47] yeah [18:47:17] confirmed on iOS it says "No Description Found" [18:47:27] YuviPanda: so we had two followup from the standup. one is the tabelize issue and i'm blanking on the second [18:47:44] * tfinc needs to take notes at the standup [18:47:59] we should record our standup hangouts and upload the videos to mediawiki.org for reference ;) [18:48:13] tfinc: decide how we expose the campaigns [18:48:17] yes! [18:48:19] ah that was it yeah [18:48:20] tfinc: separate beta? a flag? a setting? [18:48:25] I like a separate beta [18:48:33] YuviPanda: i'm leaning toward seperate beta [18:48:36] tfinc: i did the 1h spike, and the only place we have 'beta' is the version numbber [18:48:40] YuviPanda: compile-time switch then? [18:48:43] brion: +1 [18:48:55] but i *do* want a market release of bugs fixed [18:48:57] brion: compile time switch to hide it / show it [18:48:58] can we do that ? [18:49:01] tfinc: yes! [18:49:03] sounds good yeah [18:49:04] then lets do that [18:49:09] *still working on rounded corner screenshot* [18:49:13] market release with everything but campaigns turned on [18:49:14] YuviPanda: you want to add that on the branch or shall i after review? [18:49:16] tfinc: like how we have 'Wikipedia' and 'Wikipedia Beta' we can have these too [18:49:19] brion: after [18:49:20] then we do a beta release for fabrice [18:49:23] ok [18:49:24] tfinc: +1 [18:49:43] YuviPanda: we can do market *or* test flight for the beta [18:49:49] pros/cons ? [18:49:56] tfinc: market is easier, zero setup [18:50:06] tfinc: testflight doesn't give much for Android unless you want your beta to be *really* controlled [18:50:13] YuviPanda: ok. then lets do market [18:50:21] i'll mail on the list to capture this [18:50:42] sweet [18:52:16] ok sent [18:52:34] now lets talk about https://trello.com/c/Fo3VzdPO/85-5-de-tableize-the-detail-overlay-on-android [18:52:55] brion: do i remember right that YuviPanda was concerned that it was too "blocky" ? [18:53:16] tfinc: we've been hashing out that issue above :) [18:53:20] tfinc, is the decision on the coding task final? I posted my thoughts just a minute ago [18:53:21] tfinc: https://test.wikipedia.org/wiki/File:Blocky_and_terrible.png [18:53:32] tfinc: vs iOS https://upload.wikimedia.org/wikipedia/test/d/d2/Blocky_android_and_blocky_ios_side_by_side.png [18:53:40] jgonera: i want it by 1pm today so feel free to chat with kaldari [18:53:50] jgonera: we can always change the task [18:53:55] we've decided on some short-term tweaks that tidy it up a bit more [18:53:59] ok, jdlrobson have you read the thread about the coding task? [18:54:01] YuviPanda: brion: tfinc: almost done with screenshots [18:54:02] so don't stress too much aboutit [18:54:05] whee [18:54:05] ok [18:54:44] YuviPanda: what are your concerns ? [18:55:40] to rehash, 1. it doesn't line in with the rest of android, 2. it's 'long', and will span multiple screens on phones that are smaller displays (my phone has a relatively large one) [18:55:59] tfinc: brion and mhurd suggested some changes that brion is going to make and then we'll take a look at it again. [18:56:17] YuviPanda: great. send me a screenshot when you have it ready then [18:56:23] tfinc: brion's working on it. [18:56:57] ok monte's uploading some screenshots from iOS plus rounded corners also [18:58:35] YuviPanda: brion: tfinc: rounded to 4px corner radius: http://imgur.com/a/RL7IW#0 [18:58:39] (03PS14) 10Kaldari: Adding user to last modified [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 [18:59:20] the last 3 are with square corners for comparison [18:59:27] (03CR) 10jenkins-bot: [V: 04-1] Adding user to last modified [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 (owner: 10Kaldari) [18:59:58] brion: YuviPanda: tfinc: i could go either way [19:00:24] mhurd: brion we don't really have rounded corners anywhere else in the app in Android, no [19:00:39] yeah let's stick with the straight corners for now [19:00:53] looks spiffy though :D [19:01:12] that's fine - we can always re-visit [19:01:49] mhurd: offtopic, but I guess you are a lot more visually attuned when programming, than I am, I guess :) [19:01:58] iOS looks in general more gorgeous than Android :D [19:02:24] YuviPanda: i like tweaking tiny details…probably to a fault haha [19:02:31] heh yeah [19:02:57] YuviPanda: the more i look at the rounded corner screenshots the more it's growing on me... [19:03:10] mhurd: Android has very little rounded corners... [19:03:21] mhurd: this is something we need to resolve too, cross platform looks... [19:04:56] yeah for the reader app we'll want to nail down how much of the wikimedia widget styles we want to absorb into ios- and android-specific look and feel [19:05:41] YuviPanda: mhurd: do you think make the field labels a smaller font size or leave them as they are? [19:05:56] YuviPanda: true. my general outlook on cross platform consistency is it's nice to keep the Android / iOS versions close, but not necessarily pixel-perfect-consistent [19:06:29] mhurd: hmmm, I like keeping apps blend into their native environments as much as possible, since I'm going to keep switching between Android apps all day, not between Android and iOS apps (as a user) [19:06:43] YuviPanda: *exactly* [19:06:44] jdlrobson, tfinc let's move to r31 [19:06:51] apparently you can't hear me :) [19:06:59] r31 is still available, and i just re-reserved it [19:07:05] it that room free awjr ? [19:07:08] also, i've sent techsupport@ an email and pinged chip [19:07:12] jdlrobson: yes, i just re-reserved it. [19:08:55] jdlrobson, come [19:11:07] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87298 (owner: 10Kaldari) [19:19:37] i wonder if there is a faster way of always splitting screens between hangout and mingle/trello etc [19:21:06] rmoen|away: you still away [19:23:16] (03CR) 10JGonera: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88912 (owner: 10Jdlrobson) [19:23:23] mhurd: YuviPanda brion: we need to pick if were going to do another test flight release or market for the this weeks push [19:23:23] jdlrobson, https://gerrit.wikimedia.org/r/#/c/88912/2/less/common/secondarypageactions.less [19:23:37] my thinking is that we release a test flight build as normal [19:24:00] wait 24 hrs then do a market push [19:24:07] what do you think mhurd YuviPanda brion ? [19:24:28] tfinc: i think that's excellent :D [19:24:29] tfinc: sounds good to me [19:24:36] tfinc: Android has no 'test flight' system. I suggest we setup the 'Commons (Beta)' app (new app!) in market, push to that, and then wait 24 hours, then push to the regular one [19:24:42] (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88912 (owner: 10Jdlrobson) [19:24:46] brion: mhurd ^ [19:25:02] YuviPanda: do it [19:25:07] ok [19:25:08] YuviPanda: ya [19:25:12] sweet [19:25:25] now i don't like to have these two systems long term. its confusing. can we use testflight for the wikipedia android app ? [19:26:17] tfinc: it's IMO less easy for people than Market, so I don't like it [19:26:21] tfinc: it's an extra step, while market it is just 'oh, search for commons beta!' [19:26:33] YuviPanda: what is the android experience like ? [19:26:55] tfinc: with Market beta app? [19:27:05] with android test flight [19:27:21] i don't think we've actually tried it [19:27:43] from what I've looked at it is similar to the iOS one [19:28:02] brion: it'll also complicate our build system further [19:28:40] I mean, it makes sense when you want a 'closed' beta [19:28:45] to restrict who has access [19:28:57] do we have to change the build, or just upload it to a different place? [19:29:32] brion: depends on how much integration we want [19:29:50] brion: if we want to do crash reporting, etc via it, then we need to include their SDK [19:30:00] i think we just want the 'send an email to people with an installer link' and 'tell us when they install it' [19:30:13] we should do crash reporting on the store builds too, so i wouldn't rely on TF for that [19:30:26] brion: well, more like https://play.google.com/store/search?q=org.wikipedia.beta [19:31:04] if people actually have the beta installed via play then they'll get upgrade notices, but if they don't keep it around they won't get pinged automatically i think [19:31:24] brion: well, I think the play store should be the primary way of distributing beta, no? [19:31:38] i'm indifferent, we could go either way on that [19:31:56] meh, it's extra work and I don't see what adding testflight gives us [19:32:02] ok we think we now have monte set up to make test flight builds for iOS :D [19:32:07] vs just having a regular and beta version on the play store [19:32:44] YuviPanda: depends on whether we want to be able to ping potential testers or just hope they show up, i guess? [19:33:14] brion: we can still ping them with just the market link, no? [19:33:27] brion: anyway, we can have this in 2 weeks. no need to resolve it now. [19:33:48] yep [19:33:51] :) [19:33:53] :D [19:34:33] brion: i moved https://trello.com/c/kXPlgG6w/110-3-accounts-bug-41704-commons-app-doesn-t-handle-changed-login-passwords-properly back [19:35:44] brion: do take a look through the merge code, and point out things that need doing before it can go out. General commons workflow should still function right, I guess [19:35:44] looked okay on my testing [19:35:44] but I should poke more [19:36:17] ok [19:36:37] brion: i'll go away in like, 30 mins [19:37:33] ok [19:37:50] tfinc: headsup i'm referring a friend / former-coworker for the mobile backend opening. Emailing recruiters now, putting you on cc [19:38:00] YuviPanda: cool [19:38:18] YuviPanda: heads up that i'm not going to want someone whos many time zones away [19:39:00] tfinc: http://hire.jobvite.com/Jobvite/Job.aspx?j=o09WXfwM&c=qSa9VfwQ says 'San Francisco or Remote', but he's very open to relocating, IIRC. [19:39:17] YuviPanda: i'm ok with remote but not a large time zone difference [19:39:51] *shrug*, I'll just email it in, I guess the recruiter folks can take care of it [19:40:21] tfinc: might help to put that on the JD, it is news to me. [19:42:17] (03PS3) 10Brion VIBBER: UI matching in detail view to iOS version [apps/android/commons] - 10https://gerrit.wikimedia.org/r/89339 [19:42:27] YuviPanda: sure [19:42:30] YuviPanda: that's just work in progress, i'm switching over to the other review for now [19:42:38] brion: okay :) [19:43:00] (03CR) 10Brion VIBBER: "This patchset updates visual style a little, needs further tweaking before merge." [apps/android/commons] - 10https://gerrit.wikimedia.org/r/89339 (owner: 10Brion VIBBER) [19:45:22] (03CR) 10Mhurd: "The padding on the categories text is a little less than the padding on the other fields." [apps/android/commons] - 10https://gerrit.wikimedia.org/r/89339 (owner: 10Brion VIBBER) [19:46:38] lol assert onComplete.isJavaAPieceOfShit(); [19:47:32] (03CR) 10JGonera: "(3 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88912 (owner: 10Jdlrobson) [19:47:35] brion: i took it out! [19:47:36] :P [19:47:39] yes you did :) [19:48:06] brion: the app would actually crash if there was a return false; there :) [19:48:25] hehe [19:48:45] android-apt-compiler: [commons] /Users/brion/src/wiki/apps-android-commons/commons/res/values/styles.xml:3: error: Error retrieving parent for item: No resource found that matches the given name 'Theme.Sherlock'. [19:48:46] hrmmm [19:48:52] i thought we fixed that [19:49:06] brion: intelliJ? [19:49:12] oh i probably have to reimport the maven structure [19:49:38] brion: yeah, switching branches does that to me too. ANd a lot of other spurious errors [19:49:53] brion: messing around in the 'project structure' dialog, taking care of the red underlined items fixes it [19:49:59] * brion pokes [19:51:22] awjr: now that we have rob shall we get back to ve ? [19:53:19] YuviPanda: ok i fiddled and it's happy building again \o/ [19:53:23] (03PS1) 10Mhurd: Changed first pic of day which displays to castle image. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/90189 [19:53:24] brion: woo [19:53:26] lemme run it through its paces real quick [19:53:29] brion: ok [19:56:50] YuviPanda: emily is changing the JD to be clearer about location [19:56:51] YuviPanda: ok nothing's standing out as broken in the merge so far [19:56:58] tfinc: ok [19:57:08] tfinc: i sent the email anyway [19:57:13] brion: sweet [19:57:30] brion: settings? (licenses)/ [19:57:32] brion: pause/ resume? [19:57:35] brion: multiple upload? [19:58:07] YuviPanda: i'll test those a bit more before i merge, but if you have to sleep that's fine :D [19:58:14] http://etherpad.wikimedia.org/p/MobileWeb-IterationName [19:58:19] brion: yeah, thinking of heading in now :) [19:58:29] http://etherpad.wikimedia.org/p/MobileWeb-IterationName [19:59:35] (03CR) 10Dr0ptp4kt: [C: 04-1] "(3 comments)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86820 (owner: 10Yurik) [20:00:18] impala! https://upload.wikimedia.org/wikipedia/commons/d/d3/Impalajump.jpg [20:00:57] i thought impala was type of car [20:01:38] wow [20:01:40]