[00:55:27] (03PS1) 10Dr0ptp4kt: Add interstitial to all appropriate footer links. Fixes bug 55748. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90465 [00:57:35] (03Abandoned) 10Dr0ptp4kt: Add interstitial to all appropriate footer links. Fixes bug 55748. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90465 (owner: 10Dr0ptp4kt) [00:58:07] (03PS1) 10Dr0ptp4kt: Add interstitial to all appropriate footer links. Fixes bug 55748. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90466 [01:00:54] (03CR) 10Kaldari: [C: 032] Fix wrong variable in a template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90452 (owner: 10JGonera) [01:02:58] (03Merged) 10jenkins-bot: Fix wrong variable in a template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90452 (owner: 10JGonera) [01:20:54] (03PS1) 10JGonera: Change "security text" to "confirmation code" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90473 [01:29:04] (03PS3) 10JGonera: Alpha: Make hamburger menu slide in/out when opened [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88185 (owner: 10Jdlrobson) [02:36:57] (03PS1) 10Brion VIBBER: Fix for weird crash changing languages on hub [apps/win8/wikipedia] - 10https://gerrit.wikimedia.org/r/90477 [02:36:58] (03PS1) 10Brion VIBBER: Fix for missing RC entries [apps/win8/wikipedia] - 10https://gerrit.wikimedia.org/r/90478 [02:36:59] (03PS1) 10Brion VIBBER: Fix bug in new Win 8.1 search (broken backspace) [apps/win8/wikipedia] - 10https://gerrit.wikimedia.org/r/90479 [02:37:19] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix for weird crash changing languages on hub [apps/win8/wikipedia] - 10https://gerrit.wikimedia.org/r/90477 (owner: 10Brion VIBBER) [02:37:28] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix for missing RC entries [apps/win8/wikipedia] - 10https://gerrit.wikimedia.org/r/90478 (owner: 10Brion VIBBER) [02:37:47] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix bug in new Win 8.1 search (broken backspace) [apps/win8/wikipedia] - 10https://gerrit.wikimedia.org/r/90479 (owner: 10Brion VIBBER) [06:13:07] (03PS1) 10Jdlrobson: Make sure KeepGoingDrawer gets set correctly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90493 [07:35:19] MaxSem: around? [07:35:36] yup [07:36:04] MaxSem: hi, i found a fun bug - spoof user agent to be "android",and visit http://en.m.wikipedia.beta.wmflabs.org/ [07:36:20] if you go to article's history, it switches to desktop [07:36:34] by desgn [07:36:39] wa? [07:36:53] no mobile history so far [07:36:58] oh,i see [07:37:00] ok [07:37:01] thx [10:40:01] (03PS1) 10Yurik: Allow zero banner on ALL wiki sites (if configured) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90519 [10:42:35] (03PS2) 10Yurik: Allow zero banner on ALL wiki sites (if configured) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90519 [10:59:31] (03PS3) 10Yurik: Allow zero banner on ALL wiki sites (if configured) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90519 [13:57:04] *yawn* good morning [14:47:16] * brion wonders how long this iPhone 5s will take to ship [14:47:32] maybe i'll cancel it and just get the new iPad, assuming they announce an update next week [14:47:54] someone's gotta tell apple about this "product roadmap" idea that's all the rage [14:47:59] telling your customers what you're working on and all that [14:49:27] People will not buy the old stuff then [14:50:22] heh [14:50:44] anyway what i really want to test is the new armv8-based processor [14:50:51] and they better be putting that in an iPad too :) [14:51:22] now i gotta go check alternate bus routes to the office \o/ [15:32:26] (03PS4) 10Yurik: Allow zero banner on ALL wiki sites (if configured) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90519 [16:38:57] (03PS1) 10Yurik: Simplified banner rendering and fixed empty partner URL [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90566 [16:48:05] (03CR) 10Jdlrobson: [C: 032] Hygiene: Clean up editor.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90435 (owner: 10JGonera) [16:48:43] (03Merged) 10jenkins-bot: Hygiene: Clean up editor.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90435 (owner: 10JGonera) [16:53:16] (03PS2) 10Jdlrobson: Story 1281: Promote section level editing tutorial A/B test to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90450 (owner: 10JGonera) [16:56:11] MaxSem: is it ok to add a enableZero setting to the mediawiki-config\wmf-config\mobile-labs.php [16:56:22] yes [16:56:42] I mean, who cares about labs anyway?:P [17:00:41] MaxSem: https://gerrit.wikimedia.org/r/#/c/90568/ pls +2 [17:01:36] MaxSem: gratsy [17:01:59] (03PS3) 10Jdlrobson: Story 1281: Promote section level editing tutorial A/B test to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90450 (owner: 10JGonera) [17:02:26] jdlrobson: we're going to go ahead and start [17:12:46] MaxSem: could you also +2 https://gerrit.wikimedia.org/r/90570 [17:12:54] missed it on the first pass [17:15:38] jdlrobson, I didn't quite get what you said about throttling [17:26:53] jgonera: i was just saying i was going to run a data query [17:27:23] jdlrobson, what query? throttling is not logged in any way [17:27:31] it's not? [17:27:37] I don't think so [17:27:42] it doesn't log an error.. that seems very broken.. [17:28:02] ? [17:28:12] no, it just doesn't throttle, however that works [17:28:37] I guess it means that a warning should show up every X times but instead it's showing up every time or something similar [17:29:06] I think Kaldari knows how it works [17:29:15] what does AbuseFilter API say when it is throttling you [17:29:15] nothing? [17:29:47] i'll ask him when he shows up [17:30:04] jgonera: can you merge https://gerrit.wikimedia.org/r/90493 ? [17:30:27] (03PS7) 10Jdlrobson: Make watchlist user icons consistent with rest of UI [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86052 [17:30:36] jdlrobson, well, that's what we need to investigate to fix the bug [17:30:49] jgonera: huh? [17:30:55] or maybe: what do we need to tell AbuseFilter so that it throttles [17:31:01] ? [17:31:18] (03PS2) 10Jdlrobson: Change "security text" to "confirmation code" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90473 (owner: 10JGonera) [17:31:22] (03CR) 10Jdlrobson: [C: 032] i18n: Change "security text" to "confirmation code" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90473 (owner: 10JGonera) [17:31:41] jgonera: yeh don't worry i'll wait till kaldari shows up and ask him [17:32:15] (03Merged) 10jenkins-bot: i18n: Change "security text" to "confirmation code" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90473 (owner: 10JGonera) [17:32:41] kenanwang: question around the keep going cta.. what should happen when the user hits edit - should the cta disappear or should it still be there in case they want to find another article? (i suspect the latter) [17:32:43] jdlrobson, I'll go through patches in a moment [17:32:50] as currently it just hides the editor overlay save button [17:39:09] kenanwang: ? [17:39:32] latter [17:39:33] yes [17:39:44] jdlrobson: ^ [17:39:55] ok i'll write a patch [17:41:28] actualy… arg you've gone [17:41:31] jgonera, kaldari: are you on flight LH 491 from Seattle to Frankfurt ? [17:42:07] howdy howdy all [17:42:37] rmoen: jgonera kaldari i just realized that if i had stayed for about a week more I could've flown back with you uys [17:42:38] oh well [17:43:02] YuviPanda :( [17:43:06] rmoen, nope, I still haven't bought it, but I'll be flying SFO->Dubai->Mumbai [17:43:10] ino [17:43:56] YuviPanda: you in GOA boss ? [17:44:04] rmoen: no, Bangalore [17:44:13] rmoen: Carpel tunnel syndrome :( [17:44:21] greg-g: https://www.mediawiki.org/wiki/Mobile/Release_history [17:44:33] YuviPanda: do you have speech to text ? [17:44:39] rmoen: no [17:44:43] YuviPanda: stop typing! [17:44:48] rmoen: just typing less [17:44:50] i tell you you gotta upgrade to 10.8 [17:45:03] except you know that won't work for coding :) [17:45:42] YuviPanda: gotta get some of that salve they sell on the train for like 20IRP [17:46:13] YuviPanda: err balm w/e [17:46:35] there's a balm on the train [17:46:56] brion: luls don't say that too loud in here [17:46:59] rmoen: hehe :D [17:47:00] heheh [17:47:09] brion: i upgraded [17:47:18] rmoen: yeaha, yeah, from the folks on the beach :D [17:47:22] rmoen: i forgot her nme [17:47:26] YuviPanda: anything I should look over today ? [17:47:43] brion: the merge! [17:47:50] YuviPanda: are you talking about the girl who hustled me on the beach? [17:47:52] and list of things you want to fix after the merge :D [17:47:56] rmoen: for two days? yeah ;) [17:48:50] greg-g: correction late oct / early dec [17:48:53] err nov [17:48:58] huh, i thought i finished the branch merge [17:49:03] ok let me poke that then YuviPanda :D [17:49:05] YuviPanda: rmoen no fair that you get reunited in india :( [17:49:11] jdlrobson: do you remember he name ? [17:49:15] jdlrobson: :P [17:49:17] i must have tested and then forgotten to finish ;) [17:49:18] * her * [17:50:27] jdlrobson: sorry boss, we will have to drink a king fisher in your honor. ( of course after we remove the glycerin ) [17:51:27] ;-) [17:51:47] beta labs is *still* broken?! [17:54:37] jdlrobson: yeah looks like the ssl issue is still present [17:54:45] jcmish: do you know if this is being actively worked on? ^ [17:55:13] yeah they're still working on the https issue [17:55:24] jdlrobson: you can kinda work around the ssl issue by making escurity exceptions for the domains from which the other assets get loaded [17:55:32] jcmish: is there a bug/rt ticket open for it? [17:55:35] there's a ticket [17:55:39] yeah let me find it [17:55:44] I'm watching it [17:55:45] awesome, thanks [17:55:49] eggcellent [17:57:01] https://bugzilla.wikimedia.org/show_bug.cgi?id=55760 [17:57:02] https://bugzilla.wikimedia.org/show_bug.cgi?id=55804 [17:57:17] awjr: i sent a mail [17:57:28] looks like the annoying login screen is back from the dead [17:58:26] (03CR) 10Jdlrobson: [C: 04-1] "Seems to be a slight error in the login link not using returnto query properly. Looking into and fixing as I speak" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90450 (owner: 10JGonera) [17:58:30] er i thought that was still always the case [17:58:41] i dont recall us figuring out a awy around it [17:58:55] but i do ercall jgonera playing around with it ^ [17:58:56] jdlrobson, [17:59:06] jdlrobson, the login link should not show the cta [17:59:55] annoying login screen? [18:00:01] brb gotta run to get the kid [18:02:25] jgonera: is that the correct behavior? what about users who hit login first then create accounts... [18:02:45] also commit message could be clearer in that case [18:03:48] wouldn't it be better to do this for users who login with edit count 0 as well? [18:05:33] hm, I haven't thought about that... would the returntoquery be persisted anyway if they click create account on the login screen? [18:05:45] it is at the moment for that reason [18:06:22] (03PS4) 10Jdlrobson: Story 1281: Promote section level editing tutorial A/B test to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90450 (owner: 10JGonera) [18:06:29] greg-g: where on https://wikitech.wikimedia.org/wiki/Deployments/Beta do you want links to our project trackers ? [18:06:35] hm, we could make it be displayed for all people with 0 edits then, although it slightly changes the story [18:06:42] jgonera: updated commit message - let's check with kenan when he returns [18:06:48] yep [18:07:01] i worry the results won't be as complete without that situation [18:07:03] seems to happen a lot [18:07:22] (03CR) 10Brion VIBBER: [C: 032 V: 032] "New controllers seem to work in my testing from Wednesday; need to make the campaigns feature disable-able at build time for now, but can " [apps/android/commons] - 10https://gerrit.wikimedia.org/r/89858 (owner: 10Yuvipanda) [18:07:33] whee [18:07:35] brion: woooo [18:07:39] jdlrobson, yeah, we should somehow include, I just forgot about it [18:07:54] YuviPanda: you want to do the build-time disable or shall i do that later? [18:08:06] tfinc: interesting idea, I was initially thinking "no where, unless you have something coming up specifically" but, maybe having links to everyone's/team's 'dashboard' (whatever it is) in *one* place would be good (and this makes sense as that place, maybe? more so than the SOS?) [18:08:08] (03CR) 10Jdlrobson: [C: 04-1] "Currently doesn't work for case when a user clicks login then create an account. Need to check with Kenan if this is desired behaviour." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90450 (owner: 10JGonera) [18:08:12] brion: can you pick up the card for the login stuff instead? [18:08:27] brion: i'll do the disable [18:08:28] ok [18:09:08] greg-g: its https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/grid?aggregate_property%5Bcolumn%5D=story+points&aggregate_type%5Bcolumn%5D=sum&color_by=type&filters%5B%5D=%5BType%5D%5Bis%5D%5BStory%5D&filters%5B%5D=%5BType%5D%5Bis%5D%5BTask%5D&filters%5B%5D=%5BType%5D%5Bis%5D%5BBug%5D&filters%5B%5D=%5BType%5D%5Bis%5D%5BInfrastructure%5D&filters%5B%5D=%5BIteration%5D%5Bis%5D%5B%28Current+iteration%29%5D&group_by%5Blane%5D=s [18:09:08] tatus&lanes=In+Analysis%2CReady+for+Estimation%2CReady+for+Development%2CIn+Development%2CAwaiting+Final+Code+Review%2CReady+for+Testing%2CIn+Testing%2CReady+for+Signoff%2CAccepted&style=grid&tab=Story+Wall and https://trello.com/wikimediafoundation for us .. feel free to add where it makes sense [18:09:29] wow .. that was long [18:09:37] how about just https://wikimedia.mingle.thoughtworks.com/projects/mobile/overview [18:09:51] tfinc: actually, so, my irssi/gnome-terminal interaction sucks, if you said anything after the long link, I missed it :) [18:10:07] how about just https://wikimedia.mingle.thoughtworks.com/projects/mobile/overview and https://trello.com/wikimediafoundation [18:10:14] awesome [18:10:33] story wall being what you linked to before? [18:11:03] * YuviPanda hugs trello [18:11:46] wheee [18:12:06] greg-g: their the high level links to the project trackers [18:12:20] cool [18:12:27] YuviPanda: trello actually makes sucks for generating consistent links if you don't keep the boards the same [18:12:45] tfinc: to cards? [18:12:55] YuviPanda: boards [18:13:25] YuviPanda: thus if i name a board sprint-17 i can't keep a consistent link when we switch to sprint-18 [18:13:48] now i was thinking of just using sprint-current to mitigate that [18:13:49] btu [18:13:49] but [18:13:54] (03PS2) 10Brion VIBBER: Provide usable menu actions for Media object pagination too [apps/android/commons] - 10https://gerrit.wikimedia.org/r/90086 (owner: 10Yuvipanda) [18:14:00] then i can't close the board and easily see what we tried to do in previous sprints [18:14:16] YuviPanda: if you have ideas on how to get around that let me know [18:14:34] tfinc: i'll noodle about it [18:15:17] thanks [18:15:23] man i hate android devices with a menu button now. i crave the overflow menu icon indicator on the action bar [18:15:45] (03CR) 10Brion VIBBER: [C: 032 V: 032] Provide usable menu actions for Media object pagination too [apps/android/commons] - 10https://gerrit.wikimedia.org/r/90086 (owner: 10Yuvipanda) [18:15:51] nice grrrit-wm [18:16:04] (03CR) 10Jdlrobson: [C: 04-2] "Geohack overlay text is now too close to the images and nearby page is completely broken" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90068 (owner: 10JGonera) [18:17:17] (03CR) 10Brion VIBBER: [C: 032 V: 032] Update Github repo address [apps/android/commons] - 10https://gerrit.wikimedia.org/r/89385 (owner: 10Timothy Gu) [18:17:24] awjr: i was wondering is there any way visually to show status of stories in mingle [18:17:37] ie. show them as red if the patch associated with them is -1 or -2ed? [18:17:48] show them as green if +1ed [18:17:54] (03PS4) 10Brion VIBBER: UI matching in detail view to iOS version [apps/android/commons] - 10https://gerrit.wikimedia.org/r/89339 [18:18:11] jdlrobson: we could add that as a property, but it would require some serious effort to make that happen automatically from gerrit [18:18:14] i wonder if a bingle like thing for gerrit could help us with code review [18:18:22] awjr: i can look into the gerrit side of things [18:18:23] jdlrobson: diederik is working on 'gingle' [18:18:29] whichi s basically that [18:18:33] you should chat with him [18:18:49] drdee: ^ [18:19:04] :) [18:19:25] drdee: i was thinking if gerrit commits come in it could scan them for keywords such as story/bug and then update the mingle card associated [18:19:42] (move it into the awaiting final code review column/ change the colour) [18:19:51] gingle does that, i am in a meeting now but happy to talk about this later [18:27:13] (03CR) 10Jdlrobson: "(5 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89283 (owner: 10Jdlrobson) [18:30:20] (03PS2) 10Jdlrobson: Hygiene: Merge Special:Watchlist doFeedQuery doListQuery functons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89280 [18:30:21] (03PS2) 10Jdlrobson: Beta: Add Special:History [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89283 [18:31:30] (03CR) 10Jdlrobson: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87252 (owner: 10MaxSem) [18:32:01] (03PS3) 10Jdlrobson: Hygiene: Turn getHtmlBetaAlphaOptIn into a static reusable method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89282 [18:32:18] (03Abandoned) 10Jdlrobson: Hygiene: Turn getHtmlBetaAlphaOptIn into a static reusable method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89282 (owner: 10Jdlrobson) [18:32:41] (03PS3) 10Jdlrobson: Hygiene: factor out common code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89345 (owner: 10MaxSem) [18:33:55] (03CR) 10Jdlrobson: [C: 032] Hygiene: factor out common code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89345 (owner: 10MaxSem) [18:34:25] (03Merged) 10jenkins-bot: Hygiene: factor out common code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89345 (owner: 10MaxSem) [18:36:04] heh nice :D http://starkravingfinkle.org/blog/2013/10/geckoview-embedding-gecko-in-your-android-application/ [18:42:54] brion: i'll be back after lunch [18:42:59] ok [18:44:58] (03PS3) 10Jdlrobson: Beta: Add Special:History [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89283 [18:46:01] (03Abandoned) 10Jdlrobson: Hygiene: Merge Special:Watchlist doFeedQuery doListQuery functons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89280 (owner: 10Jdlrobson) [18:46:14] MaxSem: https://gerrit.wikimedia.org/r/#/c/89283/ .. :) ? [18:46:32] (03PS4) 10Jdlrobson: Beta: Add Special:History [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89283 [18:53:48] (03CR) 10Jdlrobson: [C: 04-1] "(3 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88185 (owner: 10Jdlrobson) [18:57:13] code coverage is depressing.. v [18:57:21] https://integration.wikimedia.org/cover/mediawiki-core/master/php/ < jcmish any chance we can get one of these? [18:58:33] hehe [18:58:40] I already asked Antoine [18:58:53] he's not sure because it looks like it's not as easy to set it up for the extensions [18:58:57] but I'll keep ya posted [19:18:43] (03CR) 10Awjrichards: "This looks groovy and I'm excited to see this happening; has product/design seen this yet? If not, this may be more suitable for alpha." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89283 (owner: 10Jdlrobson) [19:19:40] (03PS5) 10Brion VIBBER: UI matching in detail view to iOS version [apps/android/commons] - 10https://gerrit.wikimedia.org/r/89339 [19:20:59] (03CR) 10Jdlrobson: [C: 031] Hide charge-inducing features. Intercept link interstitials sooner. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 (owner: 10Dr0ptp4kt) [19:27:39] jgonera: is it possible to test the abusefilter work? if so can you give me a way to test it? [19:27:58] it's in the commit message for the story [19:28:52] I have no idea if AbuseFilter is installed on test/test2/betalabs, if it is then you need an administrator account there and you just create a filter as described in the commit message [19:29:56] abusefilter is on all production wikis [19:29:58] has been for a while [19:32:28] (03CR) 10Awjrichards: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90454 (owner: 10Jdlrobson) [19:51:22] (03PS1) 10Brion VIBBER: Fix regression: was crashing when changing orientation on detail [apps/android/commons] - 10https://gerrit.wikimedia.org/r/90637 [19:57:45] is anyone using deployment-staging-cache-mobile02 (betalabs) ? [19:58:03] MaxSem, brion ^ ? [19:58:16] not me [19:58:17] (03CR) 10JGonera: [C: 032] Make watchlist user icons consistent with rest of UI [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86052 (owner: 10Jdlrobson) [19:58:21] i don't touch those staging things :) [19:58:31] not me either, ask hashar [19:58:39] something tells me that its the frontend varnish server [19:58:47] which i am about to break! [19:58:49] whooo [19:58:49] (03Merged) 10jenkins-bot: Make watchlist user icons consistent with rest of UI [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/86052 (owner: 10Jdlrobson) [19:59:16] do you have hashar's permission? [19:59:47] jdlrobson, how did keepgoing work without https://gerrit.wikimedia.org/r/#/c/90493/1 ? [20:01:19] jgonera: i'm not sure i follow.. it didn't work [20:01:26] only if you add a qs parameter [20:01:31] oh [20:01:36] i think it's food time [20:01:41] (03CR) 10JGonera: [C: 032] Make sure KeepGoingDrawer gets set correctly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90493 (owner: 10Jdlrobson) [20:01:46] brion: !!! [20:02:01] Svg-edit on Firefox24 [20:02:07] (03PS4) 10Kaldari: Hygiene: Clean up overlays.less and pagelist.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90068 (owner: 10JGonera) [20:02:14] T13|needsCoffee: ah i saw some ping from you about that before [20:02:16] what's up [20:02:20] Doesn't load anything but an empty window. [20:02:23] (03Merged) 10jenkins-bot: Make sure KeepGoingDrawer gets set correctly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90493 (owner: 10Jdlrobson) [20:02:35] T13|needsCoffee: the MW extension? lemme check the current state [20:02:55] It's a browser plugin. [20:03:17] jgonera: I fixed the overlay css for notifications, but apparently jdlrobson found some more problems with it [20:03:40] I can get you a screenshot in about an hour when I get home if it will help. [20:04:12] T13|needsCoffee: send me an email with a link and a screenshot when you get home and i'll take a peek over it [20:04:20] i don't think i've used the browser plugin before, it might have bit rotted :) [20:04:33] Can do. [20:04:36] sweet [20:04:43] ok... now food time :D [20:05:52] kaldari, I see, did you fix it in the same patchset? [20:07:26] (03PS2) 10Jdlrobson: Story 1258: Move last modified to top of page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90454 [20:07:27] (03PS5) 10Jdlrobson: Story 1262: Adding user to last modified [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90443 [20:09:12] (03CR) 10JGonera: [C: 04-1] "I get:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90079 (owner: 10Jdlrobson) [20:10:50] (03PS3) 10Jdlrobson: Story 1258: Move last modified to top of page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90454 [20:12:45] jgonera: yeah [20:16:24] brion: google guys need a response [20:38:15] (03CR) 10JGonera: "I know, I only rebased it to see if we have to rewrite it from scratch after the recent CSS refactoring. I'll sandbox it today." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/88185 (owner: 10Jdlrobson) [20:40:33] jdlrobson: gingle is available at https://github.com/dvanliere/gingle have a look at the README.md -- the setup is totally tailored to our Mingle setup but I am happy to show you around. We are slowly adopting it atm [20:54:40] jdlrobson: https://www.mediawiki.org/wiki/Architecture_guidelines/Meetings/Architecture_Summit_2014 [20:56:18] (03CR) 10JGonera: [C: 04-1] "(7 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89283 (owner: 10Jdlrobson) [21:01:10] jcmish: i'm going to be about 5 min late [21:01:25] tfinc: no problem the parent teach conference is running a bit late too [21:01:32] so that's fine [21:03:22] (03PS5) 10Jdlrobson: Beta: Add Special:History [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89283 [21:03:47] (03CR) 10Jdlrobson: [C: 04-1] "Forgot to say this is a WIP and needs some refinement still (doesn't show full page history for example)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89283 (owner: 10Jdlrobson) [21:05:04] jcmish: ready when you are [21:05:12] k [21:05:16] jdlrobson, why do we need gender for last edited? is "by" gender-specific in some languages? [21:06:06] jgonera: yes [21:06:28] hm, interesting [21:06:33] i've asked siebrand for an i18n review anyway and kaldari has already gone through on [21:06:35] e [21:09:31] I'm confused as to what renderHistoryLink does [21:10:24] or, why do we have renderHistoryLink and getHistoryLink [21:10:27] and in separate files [21:17:59] (03CR) 10JGonera: [C: 04-1] "Doesn't seem to match the attached spec (background color, contrast, margins, font size). Margins are kind of confusing because each asset" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90454 (owner: 10Jdlrobson) [21:21:03] (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90443 (owner: 10Jdlrobson) [22:04:37] (03CR) 10Jdlrobson: "I sat with Vibha for 30 minutes perfecting this. I assure you this is how it is supposed to look." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90454 (owner: 10Jdlrobson) [22:05:59] (03PS4) 10Jdlrobson: Pass query string parameters to mobile view url [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90062 [22:06:13] ^ MaxSem [22:13:23] (03CR) 10MaxSem: [C: 032] Pass query string parameters to mobile view url [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90062 (owner: 10Jdlrobson) [22:16:40] (03Merged) 10jenkins-bot: Pass query string parameters to mobile view url [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90062 (owner: 10Jdlrobson) [22:19:29] jdlrobson: for some reason, with https://gerrit.wikimedia.org/r/#/c/90454/ in beta i still see the old-style last modified timestamp... [22:19:40] any idea what might be going on? [22:20:04] awjr: i wouldn't worry too much about that commit the one before might never get merged depending on i18n [22:20:24] only issue i can think of is if you are on the main page or in stable [22:20:34] or there is caching going on [22:20:35] no, neither :( [22:20:39] refreshed all my caches [22:21:01] awjr: send me a screenshot? [22:22:28] sure jdlrobson [22:22:43] sent [22:25:22] oh im an idiot jdlrobson, i think i see the problem [22:25:48] something weird i had done to my setup earlier this week [22:26:31] jdlrobson: fixed, and it looks as expected now; sorry to bug ya [22:31:17] dfoy: check your email [22:31:40] dfoy: i might have found another reason for our analytics number mismatch [22:33:34] yurik: interesting catch - good work! [22:44:56] jdlrobson, did you ask kenanwang about the tutorial story? [22:45:10] jgonera: huh? [22:45:17] ? [22:45:32] https://gerrit.wikimedia.org/r/#/c/90450/ [22:45:57] ok, I guess not, so, when we have the CTA, there's a login link and a sign up link [22:46:15] currently only people coming to the editor through the sign up link are bucketed [22:46:30] but, if you go to the login page first, there's also a sign up link [22:46:40] and people who go this route, don't get bucketed [22:47:17] we could fix this but then people who simply login would also get bucketed. we could make a condition that we bucket only people with 0 edits though [22:47:52] so in other words, no matter how they get logged in/registered, we show them the tutorial or take them to the editor if they have 0 edits [22:47:56] kenanwang, [22:47:57] ^ [22:49:13] … any chance we log those clicks? [22:49:30] the people that click login but then actually create an account? [22:50:37] (03CR) 10JGonera: [C: 032] "Well, if you say so... doesn't look anything like https://dl.dropboxusercontent.com/sh/vu7e21juyxjs9bn/jMj3TPxaB3/HumanizingArticles_Visua" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90454 (owner: 10Jdlrobson) [22:56:02] we should only bucket those we know for sure have hit sign up jgonera [22:56:47] so let's drop the people that go through the login button but sign up, but let's get an idea of how many people that is [22:56:53] kenanwang: check you pms when you are done :) [22:56:55] hm [22:57:19] kenanwang: can't we just limit it to editors with user edit count 0? [22:57:20] jdlrobson, is there any easy way of tracking that? we're not doing it now, right? [22:57:28] what about people who signed up pre editing? [22:57:29] I'm in chambers with the product team jdlrobson [22:57:51] jdlrobson: jgonera we don't want to interfere with the desktop testing [22:58:09] kenanwang ? what would interfere with what now? [22:58:17] there are instances of people signing up on desktop making no edits and making edits on mobile [22:58:26] jdlrobson: growth team is doing tests [23:00:34] well we could add logic in the login form that appends something to the campaign string before setting the returntoquery [23:00:51] that way we could track who those users are [23:01:02] in the login form or in the cta? [23:01:07] both jgonera [23:01:14] login cta would have a different parameter [23:01:40] the login form would then pass this to create account when clicked [23:07:35] hm, seems a bit hacky, it's also unclear to me how we interfere with desktop in this particular case [23:07:43] let's get back to it on Monday [23:07:55] jdlrobson, is geonotahack supposed to be loaded on special pages? [23:21:16] jgonera: in what context does it load? [23:21:41] I'm getting "Exception thrown by mobile.geonotahack: Module not found: loggingSchemas/MobileWebClickTracking " on master when I visit Uploads [23:24:50] (03PS6) 10Jdlrobson: Beta: Add Special:History [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89283 [23:24:52] mm that's not good [23:25:10] uploads loads at the top so that sounds like a dependency issue [23:25:18] we load all modules on special pages - most lay dormant [23:25:30] jgonera: is that on the deployment train? [23:25:52] on the deployment train? [23:26:03] jgonera: awjr yeh looks like uploads page is broken on mediawiki.org ^ [23:26:08] it's on master [23:26:10] https://m.mediawiki.org/wiki/Special:Uploads/Kaldari [23:26:16] RED ALERT! :D [23:26:31] ruhroh [23:26:59] although strangely it works on my maser [23:27:03] jgonera: are you up to date on master? [23:27:14] jdlrobson: it appears to be the result of an xmlhttprequest error [23:27:20] cors issue? [23:27:20] it appears to be beta related [23:27:52] jdlrobson, I am up to date [23:28:09] awjr: yeh 2 issues it looks like [23:28:13] er i am seeing a differenterror? [23:28:15] ah yea [23:28:15] 1) i can only replicate on mediawiki.org [23:28:23] seems there is a CORS issue [23:28:32] thats what im seeing [23:28:36] 2) in beta there is a dependency issue which also effects mediawiki.org [23:28:48] ah i was just looking in stable [23:29:25] hmm [23:29:31] i wonder if the cors issue was present before? [23:29:45] i've got a fix for 2 [23:29:55] jcmish: check backscroll if you havent been following ^ [23:30:18] jdlrobson: groovy we can tyr to get that out with lightning deploy on monday [23:30:19] k let me look [23:30:33] jdlrobson: if you can get it reviewed/merged before then, let max know [23:30:53] (03PS1) 10Jdlrobson: Add missing module dependency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90673 [23:30:54] ^ jgonera awjr MaxSem [23:31:23] hmm i checked on test2 but it looks like test2 might upload locally [23:31:43]