[04:46:35] (03PS1) 10Mgrover: QA#1211 External links and images test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90862 [06:50:49] (03CR) 10Kaldari: [C: 04-1] "Clicking the edit link needs to end the random campaign, otherwise you might invoke KeepingGoing for two different things simultaneously." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87427 (owner: 10Jdlrobson) [09:59:26] (03PS1) 10Yurik: New warning page [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90881 [11:35:07] (03CR) 10Siebrand: [C: 031] "L10n changes reviewed." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90881 (owner: 10Yurik) [11:36:07] (03PS37) 10Yurik: Hide charge-inducing features. Intercept link interstitials sooner. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 (owner: 10Dr0ptp4kt) [11:50:48] (03CR) 10Yurik: [C: 04-1] "Testing on api.beta.wmflabs.org - clicking on external link showed the warning, BUT it caused a new entry in the history, and clicking bro" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 (owner: 10Dr0ptp4kt) [13:39:27] (03CR) 10Siebrand: [C: 031] "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90443 (owner: 10Jdlrobson) [13:53:59] (03CR) 10Zfilipin: "Michelle (and the rest of the mobile team), is there a reason nobody has voted on this commit for the last two weeks? Do you have any ques" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87563 (owner: 10Zfilipin) [14:21:54] (03PS2) 10Yurik: Add interstitial to all appropriate footer links. Fixes bug 55748. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90466 (owner: 10Dr0ptp4kt) [14:28:20] (03CR) 10Yurik: [C: 032] "i did minor cleanup, +2" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90466 (owner: 10Dr0ptp4kt) [14:28:22] (03Merged) 10jenkins-bot: Add interstitial to all appropriate footer links. Fixes bug 55748. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90466 (owner: 10Dr0ptp4kt) [16:48:36] (03CR) 10Jdlrobson: "mm..good point. Will think about this some more." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87427 (owner: 10Jdlrobson) [16:57:25] (03CR) 10Kaldari: [C: 04-1] "UserProfile link doesn't work in lazy-loaded version, sets the link href to '$6'." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90443 (owner: 10Jdlrobson) [17:11:23] (03PS1) 10Mhurd: Reworked image of day code for better encapsulation. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/90926 [17:15:53] (03CR) 10Brion VIBBER: "(1 comment)" [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/90926 (owner: 10Mhurd) [17:18:29] just a head's up mobile web folks - just saw an email form fundraising saying they're running a banner test which will affect 100% of anonymous readers in the US today; 10:25am-11:27am PDT [17:18:35] keep an eye out for weirdness :) [17:23:36] YuviPanda: brion mhurd : specifically what i meant was that we started the sprint with 22 points code reviewed from the previous sprint and we haven't moved much more then that. what i want us to keep in mind is if were under estimating stories that are actually much harder then we expect [17:25:00] we'll know more by the end of the sprint [17:25:45] tfinc: ok [17:28:57] awjr: does mingle give you a day by day velocity graph ? [17:29:09] tfinc it can [17:29:21] you can build graphs out of basically any data available in mingle [17:29:23] * tfinc is jealous. i'm eager to see where the app team bursts [17:30:00] (03PS2) 10Jdlrobson: Fix image width in user profiles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90674 (owner: 10JGonera) [17:30:00] yeah so far this sprint has been mostly a lot of review/merging and cleanup, we haven't pushed a lot of new features [17:30:08] kaldari, jgonera: either of you interested in going to the architecture summit? [17:30:16] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90674 (owner: 10JGonera) [17:30:34] awjr: probably not [17:30:50] kaldari: ! [17:31:01] so what was the issue with last modified? [17:31:09] okidoke kaldari [17:31:25] awjr, when is it? I think jdlrobson is going [17:31:34] going where? [17:31:44] architecture summit [17:31:45] yeh im going [17:31:52] (03CR) 10MaxSem: [C: 04-1] "(9 comments)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90881 (owner: 10Yurik) [17:32:01] i'm not interested in going but i'm going ;-) [17:32:08] jdlrobson: UserProfile link doesn't work in lazy-loaded version [17:32:17] might be an easy fix, but haven't looked into it yet [17:32:19] kaldari: what do you mean by doesn't work? [17:32:27] jgonera: attendee list has not been finalized yet but jdlrobson is indeed on the list as is MaxSem; the summit is jan 23-24 [17:32:47] the href is set to '$6' so it's not getting passed to the message [17:32:54] kaldari: oh i see - looking now should be easy fix [17:33:06] jgonera: but even if jdlrobson goes, that doens't mean that you can't - if you're interested at all you should sign up :) deadline is tomorrow [17:33:51] rmoen: do you think you'll be at the sprint kickoff meeting on monady, or will you need to miss that? [17:33:57] jdlrobson: lol, I'm amazed Siebrand is willing to go along with it, but I'm glad he thinks it's OK [17:34:13] why amazed? I think it's a creative use of translation [17:34:26] he sent a mail to the localization team [17:35:07] kaldari: forwarded to you ;-) [17:35:26] yes, definitely creative :) [17:38:14] brion: quick question on attribution for blurred image when u have a sec [17:38:47] (03CR) 10JGonera: [C: 032] Fix image width in user profiles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90674 (owner: 10JGonera) [17:39:00] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90881 (owner: 10Yurik) [17:39:25] (03Merged) 10jenkins-bot: Fix image width in user profiles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90674 (owner: 10JGonera) [17:41:04] brion: did u want me to amend that last commit to have the proj file changes? [17:41:15] mhurd: oh yeah go ahead before we forget it :D [17:41:19] brion: will do [17:42:44] (03PS2) 10Mhurd: Reworked image of day code for better encapsulation. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/90926 [17:42:50] brion: done [17:43:44] kaldari: good catch with the alpha bug [17:44:26] (03PS8) 10Jdlrobson: Story 1262: Adding user to last modified [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90443 [17:44:30] ^ kaldari the i18n string was wrog [17:44:32] *wrong [17:44:40] (03PS1) 10MaxSem: Don't mention 0 edits and 0 uploads on UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90930 [17:45:42] jdlrobson: also Siebrand suggested moving the 'by' out of the PLURAL in the i18n messages [17:45:55] kaldari: roger [17:46:10] will do that nw [17:47:44] (03PS9) 10Jdlrobson: Story 1262: Adding user to last modified [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90443 [17:48:43] (03CR) 10Brion VIBBER: [C: 032 V: 032] Reworked image of day code for better encapsulation. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/90926 (owner: 10Mhurd) [17:49:21] kaldari: you should sign up for arch summit and give front end a strong representation https://www.mediawiki.org/wiki/Architecture_Summit_2014 [17:50:48] YuviPanda: want to do a quick review on this crash workaround? https://gerrit.wikimedia.org/r/#/c/90637/ [17:50:54] looking [17:51:10] brion: the upgrade to mavericks wiped my java, so i'm re-downloading it [17:51:19] fun! [17:51:28] yeah and now you have to install oracle java [17:51:34] YuviPanda: mhurd brion : i didn't ask this explicitly so i'll do it now. any blockers on the wed release as of now ? [17:51:39] tfinc: I'll think about it. Not sure what I would be interested in addressing in particular [17:51:57] brion: intellij neads jdk 1.6 [17:52:02] tfinc: on android, mostly getting the campaign mode stubbed out [17:52:05] heh [17:52:06] kaldari: the front end representation is tiny and as an engineer who sits in the middle i think you'd have a lot to contribute [17:52:07] oh java [17:52:11] why you gotta have incompatible versions [17:52:20] kaldari: plus i think you would bring the right arguments to the table [17:52:25] tfinc: i think we're good [17:52:26] (03PS1) 10Jdlrobson: Regression: Fix images on uploads page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90931 [17:52:38] and that crash fix :D [17:52:46] brion: then lets push aggressively on that. we won't have any scheduled time for this after this sprint is over [17:52:47] and i'd like to land the detail page update, but if it has to it can wait [17:53:03] MaxSem: did you see https://gerrit.wikimedia.org/r/#/c/87252/4/includes/api/ApiParseExtender.php ? [17:53:08] (my comment) [17:53:14] well you have 2 full days and a half day to get all those out [17:53:21] so the rush is on brion :) [17:53:27] :D [17:54:14] (03CR) 10MaxSem: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87252 (owner: 10MaxSem) [17:54:22] jdlrobson, ^ [17:54:40] brion: i want to do the compile time move the same way we do commons vs testwiki [17:54:43] brion: as a patch [17:54:47] MaxSem: can't you link already to the change id? [17:54:48] brion: since it'll touch only androidmanifest.xml [17:54:58] brion: thoughts? [17:55:00] awjr: Sorry for delay, checking calendar.. [17:55:00] YuviPanda: sounds good [17:55:09] brion: ok [17:55:12] jdlrobson, nope - there will be an email for non-developers [17:55:18] YuviPanda: have it on by default, patch to disable for release build? [17:55:21] np rmoen [17:55:26] brion: yeah [17:55:29] excellent [17:56:38] awjr: yeah, I'm afraid I will be dead in the middle of moving. Most likely driving still. I may be able to tune in while driving. Would that be a first? [17:57:06] rmoen: afraid not? :P [17:57:14] rmoen: YuviPanda may have you beat :) [17:57:59] awjr: while I know YuviPanda may have tuned in via the back of an auto rickshaw, has anyone ever tuned in while driving a 20' long U-haul ? [17:58:01] rmoen: in that case, please make sure to sync up with kenan this week to ensure that card #1311 that we're planning for the next iteration is *really* clear and that any other VE-related work is well defined before monday [17:58:03] jcmish: you have two rooms for the 11. can you remove r31 in favor of r35 ? [17:58:07] rmoen: ok, that might be a first [17:58:23] rmoen: 20' bus? [17:58:25] awjr: Ok will do :) [17:58:27] oh i thought I did that sorry [17:58:28] :D [17:58:28] :P [17:58:37] let me move it and yeah r31 the Ops folks needed [17:58:55] yeah. just drop r31 from the invite [18:02:17] kaldari: jdlrobson jgonera : were in r35 [18:02:24] (03PS1) 10Jdlrobson: Hide drawers underneath overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90932 [18:02:26] (03CR) 10Yuvipanda: [C: 04-1] "Bad idea, since it'll still crash if the user switches to something else and comes back" [apps/android/commons] - 10https://gerrit.wikimedia.org/r/90637 (owner: 10Brion VIBBER) [18:02:28] brion: ^ [18:03:13] kaldari: will you be able to join? [18:03:23] hmm [18:03:41] yes [18:03:56] brion: usually things crashing on rotate is a sign of things that'll crash when evicted and put back [18:04:03] so fixing that just there won't actually usually work [18:04:05] YuviPanda: so i think the correct fix is to make the media detail fragment actually retain its media file, instead of just an index [18:04:31] then it can reload it by name (or keep the bundle?) across invocations [18:04:40] (03CR) 10Jdlrobson: [C: 04-1] "When a user has no uploads in the last 30 days - the statement should read" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90930 (owner: 10MaxSem) [18:05:04] brion: well, that has 2 problems: 1. increased memory, 2. it'll be a 'copy' of the media object, so won't change when the underlying one changes [18:05:19] brion: proper thing is probably to make sure that whatever needs initialization is properly initialized? [18:05:39] yusss, download completed! [18:05:58] media objects are gonna be what a couple kb tops, if that? [18:06:07] i wouldn't worry that much about memory there [18:06:17] we're talking about retaining like two of them in ram :) [18:06:28] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90443 (owner: 10Jdlrobson) [18:06:29] but yeah it'd be nice to make sure they update... [18:06:55] brion: yeah, true. [18:06:56] in general i never liked the solution of having the fragments refer to the parent activity's grid view adapter [18:07:04] it's very indirect and feels fragile [18:07:38] offhand i'm not sure how to make them delay on the loader... could rig up some kind of notification from the activity to the fragments maybe [18:07:52] brion: there is already one, IIRC? [18:08:00] brion: onActivityCreated [18:08:02] or something [18:08:26] well created is one thing, that happens before the cursor loads right? [18:08:46] ah, hmm, right [18:08:58] brion: want me to take a look at it after i'm done with the other 2 patches? [18:09:04] onCreate, onCreateLoader, onLoadFinished [18:09:07] sure [18:09:41] if you don't get to it i'll rig something up later and see if i can figure it out :D [18:09:48] ok [18:09:52] grr, now intellij wants to update [18:13:16] brion: for wikipedia app, we need to think how we're going to do this [18:13:23] probably in a much cleaner way [18:13:27] Otto, perhaps [18:13:36] yes [18:13:50] reminds me we should do a quick test project using otto to get the hang of it before building the main code :D [18:14:48] YuviPanda: oh re IDEs -- shall we stick with maven & intellij? [18:14:57] android studio & gradle don't seem fully baked yet [18:15:00] brion: IntelliJ definitely [18:15:05] ok good :D [18:24:34] awjr: Hey so there is a lightning deploy for the getting started bug today right? [18:24:56] awjr: jdlrobson has another fix to that feature that should probably go out today too [18:25:10] kenanwang: yeah that's what we talked about last week; MaxSem are you still able to take care of that? [18:25:44] sure. what revisions need to go out? [18:26:09] jdlrobson: ^^ [18:26:48] awjr: kenanwang MaxSem jgonera kaldari https://gerrit.wikimedia.org/r/90932 [18:27:23] anything else? [18:27:28] jdlrobson: do you have the specific rev for the getting started bug too? [18:32:30] brion: the description, etc code looks okay to me provided we say something when there's no info found [18:32:31] awjr: ? [18:32:32] (03CR) 10Brion VIBBER: "Quick notes from IRC; a couple possible better fixes:" [apps/android/commons] - 10https://gerrit.wikimedia.org/r/90637 (owner: 10Brion VIBBER) [18:32:32] currently it's just blank [18:32:42] YuviPanda: ah crap, yeah that'd be an improvement :D [18:32:47] MaxSem: also I'm curious about 2 profile related fixes that are delaying a blog post about profiles [18:32:51] brion: i can merge right after that. [18:32:55] spiff [18:33:04] brion: not hide it, but just say something along the lines of 'no description found' [18:33:06] and as suich [18:33:09] yeah [18:33:21] brion: ok :) [18:33:31] YuviPanda: can you add a comment on the change set? thx :D [18:33:49] brion: eugh, every action of mine on gerrit seems to have a 10s latency, for each click [18:33:52] jdlrobson, do they fall within the LD seriousness? [18:33:52] will do anywya [18:33:59] hah [18:34:01] MaxSem: that was what i was asking kenanwang [18:34:11] they're only urgent from the blog post pov [18:34:41] jdlrobson: https://gerrit.wikimedia.org/r/#/c/90493/ is the other one that needs to go out today, right? [18:34:44] (03CR) 10Yuvipanda: [C: 04-1] "Looks good to me (still not a fan of the look!), but would be nice to merge after we have a 'no description provided' kinda thing, rather " [apps/android/commons] - 10https://gerrit.wikimedia.org/r/89339 (owner: 10Brion VIBBER) [18:34:52] whee [18:34:54] awjr: correct [18:35:07] anything else jdlrobson or just those two changesets? [18:35:59] jgonera, kaldari, rmoen|away: can one of you take a look at https://gerrit.wikimedia.org/r/#/c/90932/1 and get it merged so we can get it deployed today during lightning deploy? [18:36:37] https://gerrit.wikimedia.org/r/#/c/90674/, https://gerrit.wikimedia.org/r/90931, https://gerrit.wikimedia.org/r/#/c/89134/ < profile related fixes kenanwang MaxSem if needed [18:36:59] awjr: the only 2 major ones are https://gerrit.wikimedia.org/r/#/c/90493/ and https://gerrit.wikimedia.org/r/90932 [18:38:49] some of this stuff isn't even reviewed [18:39:37] imo those profile related fixes should wait for the regular train - i do not think they meet the criteria for an out-of-band lightning deploy [18:39:50] kenanwang jdlrobson MaxSem ^ [18:40:15] concur [18:40:35] (03PS1) 10Yuvipanda: Add patch file to selectively disable campaigns on compile [apps/android/commons] - 10https://gerrit.wikimedia.org/r/90937 [18:40:39] brion: ^ [18:41:29] ok awjr and MaxSem agreed [18:41:47] jdlrobson: and jgonera ^ [18:42:02] fine with me [18:43:34] (03PS2) 10Yuvipanda: Add patch file to selectively disable campaigns on compile [apps/android/commons] - 10https://gerrit.wikimedia.org/r/90937 [18:43:54] jgonera: https://gerrit.wikimedia.org/r/90931 [18:44:19] but kaldari jgonera https://gerrit.wikimedia.org/r/90932 does need to be merged before today's lightning deploy [18:44:24] (03CR) 10JGonera: [C: 032] Regression: Fix images on uploads page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90931 (owner: 10Jdlrobson) [18:44:40] YuviPanda: could i get you to talk about where we are with campaigns at the showcase today? [18:44:55] (03Merged) 10jenkins-bot: Regression: Fix images on uploads page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90931 (owner: 10Jdlrobson) [18:45:36] (03CR) 10JGonera: [C: 032] Hide drawers underneath overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90932 (owner: 10Jdlrobson) [18:45:42] awjr: https://www.mediawiki.org/wiki/Mobile_web/Team/Development_cycle is missing the showcase [18:45:59] feel free to add it tfinc :) [18:46:00] (03CR) 10Kaldari: [C: 032] Hide drawers underneath overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90932 (owner: 10Jdlrobson) [18:46:14] (03Merged) 10jenkins-bot: Hide drawers underneath overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90932 (owner: 10Jdlrobson) [18:46:18] awjr: if we change "Regular planning meetings" to "Rituals" then it'll fit right in [18:46:19] awjr: k [18:46:20] brion: there were some whitespace issues, should be fixed in ps2 :) (which i've also pushed) [18:46:27] MaxSem, awjr so we have a lightning deployment today anyway, right? [18:46:37] YuviPanda: could i get you to talk about where we are with campaigns at the showcase today? [18:46:39] yes jgonera to fix some bugs in produciton [18:46:47] tfinc: probably not. I'd probably show that off next showcase, when it is complete and out [18:47:26] whee [18:47:32] awjr, would it make the deployment much harder if we included the profile fixes too? they're mostly CSS [18:49:05] jgonera: it increases risk and complexity; best to save it for regular deployment unless it meets the criteria for lightning deploy (or kenanwang says we need it in produciton now) [18:49:23] what are the criteria? [18:49:32] * awjr digs up email [18:49:56] YuviPanda: it'll be a month before you get another shot at it [18:50:15] jgonera: see 'handling bugs on the deployment train' [18:50:23] i'll add that to the wiki [18:50:24] tfinc: I'm fine with that. should also hopefully have some data from fabrice by then. [18:51:31] YuviPanda: bummer. then we'll just have to talk through what were doing next. [18:51:42] awjr, thanks [18:51:48] tfinc: okay! [18:52:57] brb, grabbing things before showcase [18:58:44] (03PS1) 10Mhurd: Pre-blurred settings image. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/90943 [19:01:42] (03CR) 10Jdlrobson: [C: 031] "Kenan says this is by design." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90450 (owner: 10JGonera) [19:09:19] (03PS6) 10Yuvipanda: UI matching in detail view to iOS version [apps/android/commons] - 10https://gerrit.wikimedia.org/r/89339 (owner: 10Brion VIBBER) [19:11:31] jdlrobson, I'm not sure if the word "profilic" is the one you're looking for, or even if it exists [19:15:52] jgonera, 'prolific' ? [19:16:22] Platonides: jgonera probably a pun on user profiles [19:16:23] I know ;) [19:17:10] seems I was out of context :) [19:18:15] RequestContest::getMain() [19:18:20] or is it getSomethingElse()? [19:32:17] YuviPanda: LOL https://twitter.com/VenuSpeak/status/390723703043944448 [19:32:30] favourite yet! [19:32:30] is that another one about the app sucking? [19:32:35] haha [19:32:35] :D [19:32:47] jdlrobson: very relevant, and actually quite fine :D [19:39:23] MaxSem: http://www.freelancer.com/projects/Articles-Web-Scraping/Get-data-from-Wikipedia-nearby.html o_O [19:39:57] (03PS2) 10Mhurd: Pre-blurred settings image. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/90943 [19:40:29] jdlrobson, *yawn*:P [19:44:42] violetto: kaity|away https://twitter.com/JAMIE_B88/status/389781925143273472/photo/1 < don't KILL it! [19:45:42] jdlrobson: haha, we'll think about it more [19:51:35] going to get some lunch [19:52:35] brion: the app design discussion, hopefully ther's a hangout [19:54:25] mhurd: brion the app design discussion, hopefully has a hangout [19:54:50] YuviPanda: hangout yes :D [19:54:56] physical room.... not yet [19:55:07] brion: heh, ok [19:55:18] (03PS1) 10Yuvipanda: Switch to using ThreadedPoolConnectionManager [apps/android/commons] - 10https://gerrit.wikimedia.org/r/91035 [20:00:15] brion: has it started? [20:00:32] mhurd: kenanwang ^ [20:00:37] hah! [20:03:27] brion: we've three! [20:03:39] or two [20:06:21] heya, can someone from the mobile have a look at comment 17 at https://bugzilla.wikimedia.org/show_bug.cgi?id=54782 and chime in? [20:32:33] https://commons.wikimedia.org/wiki/File:Deployment_train_tube_map_for_MediaWiki_2013-10-21_13-30.jpg < awjr i clarified the deployment train to make it easier to understand [20:32:47] lol [20:32:51] nice jdlrobson [20:34:05] awjr: is there a way to access the current deployed branch on gerrit? [20:34:19] yes jdlrobson [20:34:25] sec [20:34:48] jdlrobson, can you check https://gerrit.wikimedia.org/r/#/c/90685/ and https://gerrit.wikimedia.org/r/#/c/90686/ today? [20:37:03] jdlrobson: so yeah jdlrobson the deployment branches are tracked as remote branches in core [20:37:23] jdlrobson: if you go into your clone of core and do: git branch -r [20:37:30] you'll see all the remote branches available [20:37:38] jgonera: as soon as the last modified stuff is merged i can think about other things that requie brain [20:37:44] the deployment branches are origin/wmf/1..wmf [20:37:49] ooo, that was *so* close to being a meeting where i didn't say anything [20:37:58] jdlrobson, this blocks me on the photo upload story... [20:38:01] awjr: i see.. the confusion is i don't know what's live where [20:38:13] jgonera: i know but my brain is blocked :) [20:38:17] (incidentally, you can also check out specific stable releases, which are tagged) [20:38:32] jdlrobson: one easy way to look is Special:Version on the wiki you care about [20:39:16] the other way to check is loko at what the latest branch is, and compare it to the deployment train calendar [20:39:54] alos, you can just ask me;) [20:40:08] is that what you need, jdlrobson? :P [20:40:26] an automated MaxSem bot would be useful [20:41:45] does it -2 everything? [20:41:47] monty: you are going to upset YuviPanda with that mail to mobile-tech! [20:41:50] so for wmf21 it's 4d683e54006c42f63e959471d92ee35c112d670b with cherry-picked 58adb4d53b848803a6f03703b38042c9a04bf3ab and 61e82e991da0d8638b3b79289fee99c51924eb85 [20:42:08] (03PS2) 10Yurik: New warning page [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90881 [20:42:18] jdlrobson: the app sucks man [20:42:32] jdlrobson: wait, were you curious about what branch is currently in deployment, or the current sha1 of MobileFrontend in the deployment branches? [20:42:35] for wmf20 it's c02dc810931a9e7fbea16a3a85037d4f10d32e16 with same cherry-picks [20:42:38] "I've only tried the m.wikipedia.org and fell that it is sufficient. What am I missing with it that I can get with an app?" [20:42:39] MaxSem: thanks for the review! i really should spend more time in the frontend :) [20:43:50] jdlrobson: 'Hmm, that's funny, they have one of my most-hated mobile websites. I find that for me, it serves no purpose other than to collapse all the sections, forcing me to tap a lot in order to read, or at the very least, wasting the taps it takes to switch to the real Wikipedia site.' [20:44:09] jdlrobson: not that I agree with that, but can we at least stop this 'omg the app sucz lool!!!' things? [20:44:24] yeh i saw that too [20:44:34] YuviPanda: i'm not doing that you're overly sensitive [20:45:03] jdlrobson: I asked you to stop doing that as a courtesy, could you please? [20:45:05] i'm not lolling i'm just reading monte's email and saying he's going to upset you because you always react this way and you've proved me right :P [20:45:13] har har [20:45:22] who's laughing?!! [20:45:26] not me. [20:45:37] jdlrobson: see, a couple of times is fine, but you've been doing this for what, a year now? [20:45:37] me neither so i'm totally confused with what you are taking objection to [20:45:50] jdlrobson: well, can you stop doing it? Specifically you, I mean. [20:45:53] did i attack the app? no? [20:45:57] jdlrobson: since you've done it a thousand times before [20:45:59] so chill out [20:46:12] why do I even bother. [20:46:38] * jdlrobson totally confused [20:47:22] hey brion! [20:47:30] brion: two patches: https://gerrit.wikimedia.org/r/#/c/90937/ and https://gerrit.wikimedia.org/r/#/c/91035/ [20:47:33] i think it's an important question - what is the app going to do better? how is reiterating what someone else says an attack on you? [20:48:02] i think it can do things much better than mobile web and it's an important question to think about [20:48:09] jdlrobson: 1. You know we haven't been working on the app for almost a year now, 2. We just got off a meeting from that, and 3. you haven't actually said anything other than point it out and laugh. [20:48:17] jdlrobson: it's an important question when we actually talk about it. [20:48:24] HOW AM I POINTING AND LAUGHING FFS YuviPanda !!! [20:48:28] which isn't what's happening here. [20:48:34] please just fricking answer me you are becoming frustrating [20:48:48] 02:15 yuvipanda: jdlrobson: I asked you to stop doing that as a courtesy, could you please? [20:48:52] really? [20:49:05] yes but i don't see how anything i said above that warranted that response [20:49:18] jdlrobson: you know very well this isn't the first time I asked you that [20:49:22] you were the one that says and i quote "YuviPanda: jdlrobson: the app sucks man" [20:49:36] jdlrobson: it's a fact. the current one does. [20:49:40] meh, mountain out of a molehill [20:49:45] let's talk about this next week when i'm in person [20:49:54] you personally attacked yourself and blamed me for it - i didn't pass any judgement and it annoys me that you are now telling me off for something i didn't do [20:49:58] wat [20:50:55] this is nowhere near constructive. let's stop. [20:52:03] yes please. We're having a conversation about subtext and connotation. These conversations are best had in person not over text. [20:53:00] kenanwang: it probably looks worse on IRC than it actaully is [20:54:23] (03CR) 10Yurik: "(3 comments)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86820 (owner: 10Yurik) [20:56:05] (03CR) 10Brion VIBBER: [C: 032] "Sounds sane and doesn't explode, I'll take it. :D" [apps/android/commons] - 10https://gerrit.wikimedia.org/r/91035 (owner: 10Yuvipanda) [21:00:18] jdlrobson & awjr, I'm lost - do we need to LD today, or not now that we decided not to deploy https://gerrit.wikimedia.org/r/90932 and https://gerrit.wikimedia.org/r/90493 ? [21:00:45] jdlrobson: I'll be in town Sunday, hopefully we can talk about it then :) [21:00:48] MaxSem: we need to deploy them yes [21:02:13] jdlrobson, but ok awjr and MaxSem agreed [21:02:22] ...that it's not for LD [21:02:29] (03PS5) 10Jdlrobson: Story 1281: Promote section level editing tutorial A/B test to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90450 (owner: 10JGonera) [21:02:31] now i'm confused [21:02:44] or several things were discussed? [21:02:48] ok i'm confused. kenanwang ? [21:03:24] We're deploying the getting started patches. [21:03:44] which ones? [21:03:49] there are two changesets that we agreed to push for lightning deploy today: https://gerrit.wikimedia.org/r/#/c/90493/ and https://gerrit.wikimedia.org/r/90932 - i sent the email "changes for today's lightning deploy" to record the decision [21:03:53] I believe there are two [21:03:54] yes [21:04:00] nothing else [21:04:08] oh, so something else was discussed? [21:04:24] next time, let's use Etherpad [21:04:24] MaxSem: there was some discussion about deploying some profile-related changes [21:04:31] ok [21:04:44] but we said no to those for lightning deploy [21:04:50] jdlrobson, ok - let's get greg-g's approval [21:05:04] ? [21:05:49] MaxSem: +1 to etherpad [21:06:21] MaxSem: what do you want to use etherpad for? [21:06:28] greg-g, we want to LD two fixes today, https://gerrit.wikimedia.org/r/#/c/90493/ and https://gerrit.wikimedia.org/r/90932 cuz they're fixing serious UI breakages [21:06:41] awjr, for a structured triage [21:06:47] ahha [21:12:37] kaldari: can we merge the last modified stuff now? [21:12:51] awjr: hows this look https://www.mediawiki.org/w/index.php?title=Mobile_web%2FTeam%2FDevelopment_cycle&diff=805676&oldid=805674 ? [21:12:59] yeah, I think it should be good now [21:13:20] jdlrobson: I'll give it one more look in a bit [21:14:05] tfinc: looks good - one change though, i would add product owner to the list of require participants [21:15:28] awjr: i thought about that and i would still run that meeting if the product owner wasn't there [21:15:37] its ideal but i don't see it as a req [21:16:13] now that would make it differ from a traditional showcase but were not treating it as one here [21:16:15] i guess that depends on what you envision as the purpose of that meeting. traditionally, the showcase is specifically for the product owner and other stakeholders [21:17:47] MaxSem: do you know where CORS rules are defined in config? [21:17:59] im not finding it quickly [21:18:23] awjr, $wgCrossSiteAJAXdomains [21:18:23] MaxSem: nm just found it [21:18:25] yah [21:18:27] hehe [21:18:29] :) [21:19:03] well i see the CORS problem with mediawiki.org [21:20:29] kenanwang: you there? [21:20:34] awjr: i see the purpose with the points that are there [21:20:37] we need to make a decision on the golden toast [21:20:46] brion: ping? [21:20:50] YuviPanda: pong [21:20:54] In a meeting [21:20:59] its not going to be useful the product owner as the'll have to wait two cycles to see a demo [21:20:59]