[00:06:11] YuviPanda: you still awake? [00:06:21] tfinc: yup [00:06:33] weird, *weird* bug in the final checklist item, so debugging [00:06:42] can you screenshot a campaign listing that doesn't include html comments and/or "test" bits ? [00:07:00] s/html comments/html markup [00:07:04] hmm, think so [00:07:10] let me just delete those campaigns [00:07:13] thanks [00:08:02] YuviPanda: i don't see what the complete action using screen is showing me [00:08:55] screenshot -50 is super ambigious as to what its trying to show me [00:09:08] as its just grey [00:11:02] tfinc: moment, getting screenshot [00:13:36] (03CR) 10Kaldari: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89362 (owner: 10Jdlrobson) [00:13:56] -50 is just screenshot of 'images other people have uploaded for this campaign' screen [00:14:21] 'tis from a test campaign with mostly just screenshots i uploaded, hence that grey (cropping took out the interesting bits) [00:14:28] let me see if I can get it on a more interesting one [00:15:35] (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90072 (owner: 10Jdlrobson) [00:16:23] YuviPanda: we need something that stands on its own without any text [00:16:45] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90072 (owner: 10Jdlrobson) [00:17:29] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89362 (owner: 10Jdlrobson) [00:18:21] (03CR) 10JGonera: [C: 031] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89362 (owner: 10Jdlrobson) [00:19:23] tfinc, did you get my email about the API conference? [00:19:37] jgonera: yeah, i'll take a look today [00:19:48] ok [00:20:23] tfinc: sent new screenshots, of 1. campaign lists 2. images people have uploaded from a particular campaign [00:20:34] (03CR) 10Kaldari: [C: 031] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89362 (owner: 10Jdlrobson) [00:21:05] YuviPanda: now your talking :) [00:21:24] tfinc: this is from the german WLM folks [00:21:42] tfinc: and the reason so many of them are just 'wlm-' on the list is because they havne't bothered setting a title [00:22:46] (03CR) 10Kaldari: [C: 032] Make sure auto expanded sections have contents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89362 (owner: 10Jdlrobson) [00:23:49] (03Merged) 10jenkins-bot: Make sure auto expanded sections have contents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89362 (owner: 10Jdlrobson) [00:26:44] (03PS1) 10Yuvipanda: Show campaign title if we are displaying a campaign [apps/android/commons] - 10https://gerrit.wikimedia.org/r/91330 [00:39:40] (03CR) 10Kaldari: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90072 (owner: 10Jdlrobson) [00:41:04] (03CR) 10Dr0ptp4kt: "(2 comments)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90270 (owner: 10Dr0ptp4kt) [00:42:02] (03PS3) 10Dr0ptp4kt: Interstitial zerodot File: and Image: links on non-NS_ZERO pages. Fixes bug 55819. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90270 [01:03:22] jdlrobson: If you want to fix https://gerrit.wikimedia.org/r/#/c/90072 real quick, I'll merge it [01:04:32] kaldari: looking [01:04:44] kaldari: ok [01:05:50] (03PS3) 10Jdlrobson: Ensure namespace is passed when history code loaded [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90072 [01:06:05] kaldari: ^ [01:07:34] (03CR) 10JGonera: "(5 comments)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 (owner: 10Dr0ptp4kt) [01:09:43] (03CR) 10Kaldari: [C: 032] Ensure namespace is passed when history code loaded [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90072 (owner: 10Jdlrobson) [01:10:22] (03Merged) 10jenkins-bot: Ensure namespace is passed when history code loaded [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90072 (owner: 10Jdlrobson) [01:10:36] (03PS5) 10JGonera: Add template partials support to View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90686 [01:11:02] (03CR) 10JGonera: "Not WIP anymore." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90686 (owner: 10JGonera) [01:17:27] (03PS4) 10Dr0ptp4kt: META Wikipedia Zero side-by-side banner comparison. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/78265 [01:17:31] brion: OT, but yeah, maven for WP app too. I also realized we can have a 'maven check' that runs code style / static analysis checks on stuff before merging :D [01:26:33] (03CR) 10JGonera: [C: 032] Hygiene: Cleanup handling of stylesheets in skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91106 (owner: 10Jdlrobson) [01:27:15] (03Merged) 10jenkins-bot: Hygiene: Cleanup handling of stylesheets in skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91106 (owner: 10Jdlrobson) [01:29:35] (03CR) 10JGonera: "This is usually run by doing make cucumber in the main directory, but it still doesn't work as expected then. I'm investigating this." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89137 (owner: 10Jdlrobson) [01:29:45] brion: http://googletesting.blogspot.in/2013/10/espresso-for-android-is-here.html! [01:29:47] http://googletesting.blogspot.in/2013/10/espresso-for-android-is-here.html [02:01:44] (03PS1) 10Yuvipanda: Add refresh button only for Campaigns [apps/android/commons] - 10https://gerrit.wikimedia.org/r/91340 [02:01:47] brion: ^ [03:20:06] (03PS1) 10JGonera: Fix scripts/cucumber.sh [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91343 [03:20:56] (03CR) 10JGonera: "Alternative fix: https://gerrit.wikimedia.org/r/#/c/91343/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89137 (owner: 10Jdlrobson) [03:21:48] (03PS2) 10JGonera: Fix scripts/cucumber.sh [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91343 [03:23:40] (03PS3) 10JGonera: Fix scripts/cucumber.sh [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91343 [04:10:08] (03PS5) 10JGonera: Hygiene: Clean up overlays.less and pagelist.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90068 [04:11:03] (03CR) 10JGonera: "-2s are persistent and it seems only the person who gave them can remove them." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90068 (owner: 10JGonera) [05:01:19] (03CR) 10Yurik: [C: 032] META Wikipedia Zero side-by-side banner comparison. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/78265 (owner: 10Dr0ptp4kt) [05:01:23] (03Merged) 10jenkins-bot: META Wikipedia Zero side-by-side banner comparison. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/78265 (owner: 10Dr0ptp4kt) [05:57:00] (03CR) 10Yurik: "I will check in a few fixes - please see why i did them. Also, please don't rebase and fix in the same revision - it would be much easier " [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90270 (owner: 10Dr0ptp4kt) [05:57:34] (03CR) 10Yurik: "(3 comments)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90270 (owner: 10Dr0ptp4kt) [06:28:41] (03PS4) 10Yurik: Interstitial zerodot File: and Image: links on non-NS_ZERO pages. Fixes bug 55819. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90270 (owner: 10Dr0ptp4kt) [06:30:11] (03PS5) 10Yurik: Interstitial zerodot File: and Image: links on non-NS_ZERO pages. Fixes bug 55819. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90270 (owner: 10Dr0ptp4kt) [06:50:52] (03CR) 10Adamw: [C: 031] "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91343 (owner: 10JGonera) [12:17:19] (03PS1) 10Yuvipanda: Fix crash when looking at images in campaign view [apps/android/commons] - 10https://gerrit.wikimedia.org/r/91371 [13:35:17] hey brion [13:35:24] hey hey [13:35:29] (03CR) 10Yuvipanda: [C: 04-1] "Doesn't actually work!" [apps/android/commons] - 10https://gerrit.wikimedia.org/r/91371 (owner: 10Yuvipanda) [13:35:41] brion: two patchsets awaiting review, not counting the one I just -1'd [13:36:00] moment [13:36:29] YuviPanda: oh before i forget -- when do you get into town? [13:36:40] brion: i'll be in office Monday! [13:36:47] brion: I'm landing on Sunday [13:37:21] awesome [14:00:56] (03CR) 10Brion VIBBER: [C: 032 V: 032] Show campaign title if we are displaying a campaign [apps/android/commons] - 10https://gerrit.wikimedia.org/r/91330 (owner: 10Yuvipanda) [14:01:39] (03PS2) 10Yuvipanda: Fix crash when looking at images in campaign view [apps/android/commons] - 10https://gerrit.wikimedia.org/r/91371 [14:01:48] brion: that patch works too now [14:01:56] yay [14:06:02] (03CR) 10Brion VIBBER: "Am I missing something? I don't see the menu item..." [apps/android/commons] - 10https://gerrit.wikimedia.org/r/91340 (owner: 10Yuvipanda) [14:06:47] brion: not in the overflow menu? [14:06:58] nope [14:07:23] 1) launch Campaigns activity 2) click 'Wiki takes San Francisco' 3) look in the overflow menu [14:07:30] all i see is settings / about / send feedback [14:08:06] brion: okay i'll take a look, moment [14:10:08] campaign is null when onCreateOptionsMenu runs [14:11:00] probably because... nothing sets campaign [14:12:32] brion: gah, right [14:14:25] missed that, let me fix [14:23:41] brion: up kinda early? [14:24:02] bugs wouldn't let you sleep? [14:24:06] yurik_: oh i tend to get up early these days :) [14:24:13] sleep schedule has migrated in interesting ways :D [14:24:17] age... it does strange things [14:24:23] :) [14:24:34] ten years ago i'd be going to bed around now ;) [14:24:58] lol [14:25:08] my cycle is about 5 months, not 10 years [14:26:03] perhaps you're on sidereal time yurik_ [14:26:12] i think so [14:26:48] ugh this needs to be redone as an SVG - https://en.wikipedia.org/wiki/File:Sidereal_Time_en.PNG [14:27:20] that would also be bitchin' as an animation [14:27:32] * brion tries to figure out how to teach spell checker that "bit chin" is one word [14:36:18] i'm about to start breaking betalabs mobile... hope noone minds :) [14:37:34] (03PS3) 10Yuvipanda: Fix crash when looking at images in campaign view [apps/android/commons] - 10https://gerrit.wikimedia.org/r/91371 [14:37:35] (03PS2) 10Yuvipanda: Add refresh button only for Campaigns [apps/android/commons] - 10https://gerrit.wikimedia.org/r/91340 [14:37:38] brion: ^ [14:37:57] \o/ [14:37:59] brb [14:50:25] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Works now :D" [apps/android/commons] - 10https://gerrit.wikimedia.org/r/91340 (owner: 10Yuvipanda) [14:52:43] brion: one more! [14:52:43] :D [14:53:47] hah, missing constructor? :D [14:53:56] the compiler should really bitch about that shouldn't it? [14:54:09] or is that not enforced... [14:54:13] java is weird :) [14:54:27] (03CR) 10Brion VIBBER: [C: 032 V: 032] "whee works!" [apps/android/commons] - 10https://gerrit.wikimedia.org/r/91371 (owner: 10Yuvipanda) [15:36:55] (03PS2) 10Zfilipin: Moving shared code to mediawiki-selenium Ruby gem [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87563 [16:08:17] (03PS1) 10Kaldari: Set a 30 days cookie when someone edits on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91401 [16:20:27] (03CR) 10Jdlrobson: "/Why/ is this needed? Couldn't local storage or edit count be used?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91401 (owner: 10Kaldari) [16:21:29] (03CR) 10Jdlrobson: "you could even set an option on the user and make this work cross device..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91401 (owner: 10Kaldari) [16:42:57] (03CR) 10Cmcmahon: [C: 032] "use the common gem" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87563 (owner: 10Zfilipin) [16:43:25] (03CR) 10Cmcmahon: "use the common gem" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87563 (owner: 10Zfilipin) [16:43:35] (03Merged) 10jenkins-bot: Moving shared code to mediawiki-selenium Ruby gem [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87563 (owner: 10Zfilipin) [16:54:01] yurik, yurik_ you there? [16:54:19] dr0ptp4kt: not really [16:54:24] this is a bot [16:54:31] * yurik_ yurikBot [16:54:37] yurik_ 2 + 2 = ? [16:54:53] dr0ptp4kt: thank you [16:55:21] yurik_ fn = fn ( add ( 2, fn ) ); fn(); ? [16:55:25] GRR [16:55:28] what's the question :) [16:55:49] would you please hop on google chat for a moment? i'd like to have a quick hangout [16:56:24] ^yurikBot yurik [16:56:44] dr0ptp4kt: there already [16:59:13] (03PS1) 10Dr0ptp4kt: Apply output escaping conditionally. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/91413 [16:59:45] (03CR) 10Awjrichards: "I haven't looked at this patchset yet - but adding cookies can cause issues with cache fragmentation. I'll take a closer look today." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91401 (owner: 10Kaldari) [17:09:28] (03PS2) 10Yurik: Apply output escaping conditionally. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/91413 (owner: 10Dr0ptp4kt) [17:12:01] (03PS3) 10Yurik: Apply output escaping conditionally. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/91413 (owner: 10Dr0ptp4kt) [17:17:43] (03PS4) 10Yurik: Apply output escaping conditionally. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/91413 (owner: 10Dr0ptp4kt) [17:17:55] hey guys [17:18:05] sorry I had a personal emergency and missed the stand up [17:18:13] anything I need to take a look at? [17:19:43] (03CR) 10Dr0ptp4kt: [C: 031] Apply output escaping conditionally. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/91413 (owner: 10Dr0ptp4kt) [17:20:07] jdlrobson, so Opera Mobile is 602/132539 [17:22:30] (03CR) 10Yurik: [C: 032] Apply output escaping conditionally. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/91413 (owner: 10Dr0ptp4kt) [17:22:32] (03Merged) 10jenkins-bot: Apply output escaping conditionally. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/91413 (owner: 10Dr0ptp4kt) [17:27:03] rmoen|away, is it that cold in SF? [17:28:06] where's kaldari? [17:30:07] (03CR) 10Dr0ptp4kt: [C: 031] Interstitial zerodot File: and Image: links on non-NS_ZERO pages. Fixes bug 55819. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90270 (owner: 10Dr0ptp4kt) [17:30:22] (03CR) 10Yurik: [C: 032] Interstitial zerodot File: and Image: links on non-NS_ZERO pages. Fixes bug 55819. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90270 (owner: 10Dr0ptp4kt) [17:30:25] (03Merged) 10jenkins-bot: Interstitial zerodot File: and Image: links on non-NS_ZERO pages. Fixes bug 55819. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90270 (owner: 10Dr0ptp4kt) [17:31:13] jdlrobson, MaxSem: need to get this merged today if possible (for the mobile editor survey we want to start on Monday): https://gerrit.wikimedia.org/r/#/c/91401/ [17:31:23] it's small [17:31:37] kaldari, but can melt the cluster quite well;) [17:31:47] what is it intending to do? [17:32:03] melt the cluster :) [17:32:08] how CN will use the cookie - from PHP or JS? [17:32:14] from JS [17:32:46] to determine whether to show the banner or not [17:33:02] from which domain does the JS come? [17:33:53] it is run from within the host site [17:34:11] that is, not from meta or desktop site? [17:34:21] (03CR) 10Yurik: [C: 032] Support language selector on on feature phones. Fixes bug 48752. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/89341 (owner: 10Dr0ptp4kt) [17:34:26] (03Merged) 10jenkins-bot: Support language selector on on feature phones. Fixes bug 48752. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/89341 (owner: 10Dr0ptp4kt) [17:34:35] not from meta, and not on the desktop site [17:35:12] next - the cookie stays if the user logs out [17:35:14] yeah looks like the cookie gets set onArticleSaved from the mobile site [17:35:22] what repercussions can this have? [17:35:26] so it'll get the mobile domain [17:35:32] the banner is allocated to only load on iOS and android. [17:35:45] before it even does the cookie check [17:36:34] (03CR) 10MaxSem: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91401 (owner: 10Kaldari) [17:37:10] brion: thanks for mailing in your status. can you code review https://trello.com/c/dVeWwX04/100-5-android-let-people-upload-things-to-the-campaign-they-are-currently-looking-at ? [17:37:10] from the looks of VCLs, it shouldn't bust the cache, but would need ops approval anyway [17:37:18] so kaldari for that to work, we need to also modify the varnicsh confs [17:37:32] no he doesn't [17:37:34] after we'll only have https://trello.com/c/l4thWyl1/107-2-user-facing-bug-when-uploading-but-user-selects-image-and-details-page-loads-the-details-page-elements-should-no-longer-be-edi for iOS which mhurd is rushing to finish up [17:37:34] MaxSem: correct, but we'd still need to add it to the VCL [17:37:44] mhurd: can brion help you with it ? [17:37:56] awjr: ? can you elaborate? [17:38:02] MaxSem: varnish will unset the cookie if we don't explicitly pass it [17:38:15] kaldari: do you have the puppet repo checked out? [17:38:41] (03CR) 10Kaldari: "jdlrobson: The reason we can't use edit count is because we have to make sure the user actually made an edit on mobile, not via desktop." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91401 (owner: 10Kaldari) [17:38:53] MaxSem: unless i am mistaken? [17:39:00] awjr, 1) we need it only in JS, 2) it won't because the user is logged in and cookies aren't changed in this case [17:39:44] YuviPanda: since its in code review i'm guessing that the last acceptance criteria is done even though its not checked on https://trello.com/c/dVeWwX04/100-5-android-let-people-upload-things-to-the-campaign-they-are-currently-looking-at [17:40:02] oh i missed the bit about JS [17:40:16] MaxSem: What does WebResponse::setcookie do? [17:40:39] MaxSem: that makes sense. but (hypothetically) if we needed to access the cookie via PHP, we'd still need to add it to the exceptions even for logged in users, right? [17:41:00] (03CR) 10Dr0ptp4kt: [C: 031] "(1 comment)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86820 (owner: 10Yurik) [17:41:04] kaldari, same stuff, but cares about cookie paths and prefixes [17:41:13] awjr, no [17:41:18] tfinc: ok looks like we merged the first two parts of the android campaigns upload card, and decided to split off the last criterion for later/backlog [17:41:26] (03CR) 10Yurik: [C: 032] Added "admins" parameter to the zero config [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86820 (owner: 10Yurik) [17:41:27] brion: k [17:41:30] lemme split out a separate card [17:41:30] (03Merged) 10jenkins-bot: Added "admins" parameter to the zero config [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86820 (owner: 10Yurik) [17:41:50] kaldari, that depends on how JS is going to use the cookies though [17:42:12] MaxSem: logged in users completely bypass vcl_recv()? [17:43:09] cookies areb't unset if any of the needed cookies is there [17:43:18] (03CR) 10Kaldari: "Also, local storage isn't as widely supported as cookies." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91401 (owner: 10Kaldari) [17:44:26] (03CR) 10Kaldari: "I considered setting a user option, but would rather do something temporary instead of spamming the database with data that will never be " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91401 (owner: 10Kaldari) [17:47:10] MaxSem: oh yeah, you're righ [17:47:10] t [17:51:12] MaxSem: doesn't look like WebResponse::setcookie is static, and I don't have a response object from within the hook. [17:52:51] Do you know if I can get a response object from any of the other parameters for the hook? [17:53:31] doesn't look like that [17:54:05] so yeah, screw it [17:54:13] :) [17:57:34] hey tfinc / brion [17:57:40] welcome back YuviPanda [17:57:51] yo YuviPanda [17:57:53] got caught in the rain. [17:58:00] YuviPanda: branch cut off @ noon today [17:58:02] rain + rain induced traffic [17:58:02] yeah [17:58:25] brion: how's the crash coming along? I noticed another small bug (local images that failed aren't showing up), that i'm going to look at now [17:58:47] i'll ping ya when it's ready :D [17:58:53] ok [18:00:20] (03CR) 10MaxSem: [C: 031] "Looks good to me however still needs ops approval - from the looks of it, this cookie shouldn't bust caching and is set only when user is " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91401 (owner: 10Kaldari) [18:02:16] (03CR) 10Kaldari: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91401 (owner: 10Kaldari) [18:02:22] dr0ptp4kt: go ahead and test pls [18:02:26] deploying 22 [18:02:30] 21 is live [18:02:50] yurik, sorry, which wikipedias is it on? [18:03:01] dr0ptp4kt: en for sure [18:03:14] yurik, thx [18:03:25] yurik, lemme know once it's everywhere and i'll run the script [18:03:33] yurik, meanwhile i'll manually check on enwiki [18:03:38] ok [18:05:02] seems like gerrit is really slow today, that's why we had issues [18:05:45] kaldari: are you taking the card about fixing the schemas? [18:06:13] also kaldari did you see my comment about the cookie on https://gerrit.wikimedia.org/r/#/c/91401/1 - do we really need this? [18:06:41] wouldn't a more generic user option be better e.g. setOption( 'editsOnMobile', true ) [18:07:02] oh sorry i saw your comments hidden away ;-) [18:07:16] yurik, ho hum looks like the "Desktop" url rewriting didn't work out (recall we thought it might not work, but it's low risk). oh well, guess will try to get that fixed and get it on the train. [18:07:17] I guess it comes down to who the story wants to target [18:07:38] ok [18:07:41] I think localStorage support can be mostly assumed though… [18:08:02] do we support editing anywhere that there's not localStorage? [18:08:05] dr0ptp4kt: meta is still on old code because gerrit is slow [18:08:12] i will deploy it later today [18:08:18] yurik_ thx [18:08:26] check that en works ok pls [18:08:32] have to go for a bit [18:09:08] (03CR) 10Jdlrobson: "Browsers that support jQuery and the editor and we care about will have localStorage (the only one I can see that might be problematic is " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91401 (owner: 10Kaldari) [18:10:04] YuviPanda: what's the justification/need for getting you the most expensive MacBook Pro? [18:10:32] tfinc: the ones without the GPU have terrible performance issues (can't support the screen) [18:10:35] YuviPanda: is the graphics chipset the only difference ? [18:10:44] its a $600 difference [18:10:55] YuviPanda: can't support what screen ? [18:11:07] tfinc: it has a higher capacity SSD too, but I don't care about that, but apple doesn't let you get a smaller capacity ssd *and* a GPU [18:11:17] tfinc: the screen on the Macbook Pro? [18:11:37] YuviPanda: you said "(can't support the screen)" [18:11:42] wondering what your getting at [18:12:05] tfinc: the Macbook Pro's screen has a large number of pixels, and the Intel Graphics Chipset cannot power it without stuttering once you start putting any amount of load on it [18:12:13] i want to be able to justify what you need [18:12:26] tfinc: and in terms of what it gives me [18:12:29] brion: have you run into that issue on your MacBook Pro ? [18:12:41] tfinc: mine has the nvidia gpu [18:12:56] tfinc: now my 'compile cycle' is about 20s, and that's terrible. Everytime I make a change I've to wait that long [18:13:04] the newer ones mostly have the intels except that one model [18:13:20] brion: and have you heard about the same issue that Yuvi is reporting on the Intels ? [18:13:50] i've heard some general grumbling about the older 13" which also had the intel integrated GPU, but i dunno how bad it is [18:13:56] see performance section of http://www.theverge.com/2012/11/1/3585082/13-inch-macbook-pro-with-retina-display-review [18:14:04] and I noticed it when I checked out a friend's locally [18:14:39] jdlrobson: localstorage seems like kind of overkill (we only want to set a single boolean value) [18:14:48] the newer one is a slightly newer generation intel GPU so ... who knows :) [18:15:04] imo the most important thing is maxing out the RAM [18:15:49] brion: the only issue i think is that if you want the GPU, you have to pay for the 512 SSD, and that drives prices up [18:15:54] I know cookies are evil, but every once in while they're actually the best tool for the job [18:15:58] brion: no way to get GPU + 256G SSD [18:16:12] :P ah apple [18:18:12] kaldari, since we edit from JS, can we actually set the cookie in JS too? [18:18:18] k. that gives me enough to info to justify what you need. thanks all. [18:19:00] tfinc: ty [18:19:25] i'll be eager to see if reviews of the new non intel machines show better perf but i'm not going to block on that [18:19:36] MaxSem: we could. would be a bit more code, but it's definitely possible. [18:21:28] I'm assuming we don't load jQuery.cookie on mobile [18:22:11] would be easy enough either way though [18:22:41] brion: iirc you drive a couple of monitors from your laptop - are you using a displaylink? [18:23:18] awjr: nope, just using both Thunderbolt/DisplayPort outputs on the macbook pro [18:23:28] ah ok [18:23:38] that's another reason to get the newer retina pro models :D [18:23:44] upgrading to mavericks has made my second external display wonky with my displaylink [18:23:57] :( [18:24:04] early adopter blues [18:24:08] hehehehe [18:24:22] oh: http://arstechnica.com/information-technology/2013/10/os-x-mavericks-breaks-multi-monitor-setups-with-some-usb-displays/ [18:35:31] MaxSem: if you want me to move it to client-side, let me know. [18:36:15] what do other folks think? ^^^ [18:37:34] kaldari: i think we already have some js to make setting mobile-related cookies pretty easy [18:37:57] imo it's a good idea [18:38:12] yurik: do you want to go to the architecture summit? [18:39:06] awjr: yurik_ should certainly go [18:39:46] im looking over the invitee list and and yurik hasn't RSVPd so wanted to dbl check; the selection committee is meeting in a bit to hopefully finalize the list [18:39:54] awjr: actually, I was wrong, it looks like we do load jQuery.cookie :) [18:40:05] zounds! [18:40:09] maybe that's what i was talking about :p [18:40:42] actually i dont think it was, last i remember there was some custom js that jdlrobson and i worked on but that was a long time ago [18:42:43] Eh [18:42:58] (cur | prev) 21:09, 22 October 2013‎ Yurik (Talk | contribs | block)‎ . . (20,569 bytes) (+320)‎ . . (→‎Requests) (undo | thank) [18:43:50] (03Abandoned) 10Brion VIBBER: Fix regression: was crashing when changing orientation on detail [apps/android/commons] - 10https://gerrit.wikimedia.org/r/90637 (owner: 10Brion VIBBER) [18:43:57] (03PS1) 10Brion VIBBER: Crash fix for rotate in media detail view [apps/android/commons] - 10https://gerrit.wikimedia.org/r/91428 [18:44:04] YuviPanda: ^ try that [18:44:24] I'm kind of surprised that jQuery.cookie has never been merged into jQuery. It's useful enough and pretty lightweight. [18:44:53] Krinkle: ^ [18:45:18] kaldari: Like MediaWiki, they like the core to be lightweight. [18:45:29] It's not mandatory for basic DOM interaction. [18:45:41] true [18:46:06] there's also various different implentations and versions of it. But that's easy to figure out and improve. [18:46:17] MediaWiki? lightweight? [18:46:22] hah [18:46:27] kaldari: also like MediaWiki, it's not very lightweight at all at the moment, btu that's a state, not a goal :) [18:46:35] MaxSem: :) [18:47:14] well, I would say jQuery is more lightweight than MediaWiki, but I suppose that's apples and oranges :) [18:47:23] plugins are cheap and rarely perform better when in core, and with combination of files, it should be trivial to add more plugins and that way leave the choice to the community what version to use. [18:47:28] ah yeah, thanks Reedy - spreadsheet hadn't been updated [18:47:29] hehe, I suppose. [18:47:33] Ahhhh [18:47:49] awjr: I was WTFing and wondered if we'd gone 24 hours back in time or something ;) [18:48:10] kaldari: MaxSem: though jQuery core is indeed not very light weight, they do have a core core now as of 2.x [18:48:18] :p [18:48:25] you can make a custom build and get a working version with a drastically reduced API [18:48:36] its' gotten much more modular since 1.8 [18:48:44] dropping old IE support helps too :D [18:48:45] essentially like us, bundling plugins [18:48:55] Krinkle: I imagine it's also much more lightweight since they dropped a lot of backwards compat [18:49:07] true, but overestimated. They had to drop IE6 IE7 and IE8 at the same time to make the difference worth it. [18:49:13] with old IE, etc [18:49:15] Y U NO LIEK IE5? [18:50:18] the modularity is actually from 1.10, not 2.x only. both 1.x and 2.x interate side by side with only browser support being different. No API or feature difference (yet). [18:50:33] nice [18:51:27] tfinc, are you in the office? [18:51:31] jgonera: i am [18:52:01] ok, quick question: can I take 3 days off after Pune to visit something in India? [18:52:31] jgonera: shoot me a mail about it so that we have it logged and ill respond [18:53:20] mhurd: YuviPanda: ok I'm gonna grab a burrito, then it's final merge & fix time :D [18:53:25] brion: \o/ [18:56:19] dr0ptp4kt: what about you, did you want to go to the architecture summit? [18:56:31] (03PS2) 10Kaldari: Set a 30 days cookie when someone edits on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91401 [18:58:39] MaxSem, awjr: new client-side version checked in: https://gerrit.wikimedia.org/r/#/c/91401/2/javascripts/modules/editor/EditorOverlay.js [18:59:47] (03CR) 10MaxSem: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91401 (owner: 10Kaldari) [19:04:17] (03PS3) 10Kaldari: Set a 30 days cookie when someone edits on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91401 [19:06:16] (03PS9) 10MaxSem: Beta: Add Special:History [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89283 (owner: 10Jdlrobson) [19:06:28] jdlrobson, ^^^ [19:06:32] awjr, i had initially showed intent to go. but i decided that my input wouldn't add significant value on the strict rfc focus that rob pointed out in his deadline message. yurik will be there to discuss api and esi, so i'll pass on it this time around. [19:06:48] ok dr0ptp4kt thanks, just wanted to make sure [19:07:10] awjr, you are a man of tao [19:07:59] _/|\_ [19:17:53] brion: seems to work as advertised :D [19:17:57] brion: any corner cases I should test for? [19:19:14] YuviPanda: you're more likely to come up with corner cases on that than i am :D [19:19:20] hehe :P [19:19:21] righto [19:19:24] just keep on swiping and rotating until it crashes ;) [19:19:47] ok for iOS mhurd says the upload button proper fix turns out to a lot bigger than we initially thought [19:19:48] hehe [19:20:04] so we're gonna go with a smaller quick hack and it can make it into a bug fix release when time permits [19:20:20] heh ok [19:20:21] if there's no other crashes, i think we're about done otherwise... \o/ [19:26:13] brion: failed and in-progress downloads don't show the image [19:26:23] i know where exactly the problem is, am trying to track it down [19:26:37] (03CR) 10Yuvipanda: [C: 032 V: 032] Crash fix for rotate in media detail view [apps/android/commons] - 10https://gerrit.wikimedia.org/r/91428 (owner: 10Brion VIBBER) [19:32:47] ah whee [19:57:39] (03PS1) 10Yuvipanda: Load images from local disk if possible [apps/android/commons] - 10https://gerrit.wikimedia.org/r/91487 [19:57:39] brion: missing character issue. Grr. [19:57:41] brion: ^ [19:58:28] heh [19:59:40] okay, I see 2 review mtgs in my cal. which should I use for hangouts? [19:59:45] ! [19:59:55] shit i do too... [20:00:15] wtf [20:01:07] i am confused [20:01:29] MaxSem: office and i went with https://plus.google.com/hangouts/_/calendar/YXJpY2hhcmRzQHdpa2ltZWRpYS5vcmc.35q7orakeuq4958c4ahc38vp2c?authuser=1 [20:01:58] kenanwang: ^^ [20:02:13] (03PS1) 10Mhurd: Fix for github repo link. Fix for iOS 7 share by email title color. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/91489 [20:02:33] (03CR) 10Brion VIBBER: [C: 032 V: 032] Load images from local disk if possible [apps/android/commons] - 10https://gerrit.wikimedia.org/r/91487 (owner: 10Yuvipanda) [20:06:34] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix for github repo link. Fix for iOS 7 share by email title color. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/91489 (owner: 10Mhurd) [20:09:43] brion: mhurd YuviPanda really interesting to see the bugs that are at the top of "Done" column as their all good items to work on but have no estimates. this is giving us more weight to *not* estimate bugs as it really is a drag on our overall velocity [20:09:54] tfinc: yup [20:10:10] simpler answer: don't create bugs in the first place ;) [20:10:19] brion: anything else you think we should get on? [20:10:23] tfinc: true [20:10:29] (03CR) 10Dr0ptp4kt: "(5 comments)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 (owner: 10Dr0ptp4kt) [20:10:44] brion: i'd disagree. bugs are fine to create as it allows anyone to jump on them and they don't get forgotten [20:10:52] YuviPanda: not off the top of my head -- i'm running some more tests on 2.3, 4.2, and 4.3 phones in case anything explodes that i haven't seen before [20:10:57] its just giving us more weight to not estimate them [20:11:02] tfinc: i mean.... write software that's not buggy ;) [20:11:15] brion: silly brion thinking thats possible [20:11:18] :) [20:11:19] :D [20:11:22] brion: yeah, 2.3! [20:11:24] nice [20:12:07] that reminds me, next week we should decide if we want to keep up with android 2.3 and iOS 5 support [20:12:17] it makes our leaves easier to drop the older versions [20:12:22] not sure if we're ready to kill android 2.3 tho [20:12:48] brion: we can do a similar thing to what we do now - really target 4.x+, but make sure that essential functions work on 2.3 [20:12:54] *nod* [20:13:03] android has the compat library so that helps a lot [20:13:12] on iOS, there's no auto layout for iOS before 6... [20:13:19] and auto layout helps A LOT when making the ui :D [20:13:28] brion: indeed [20:13:38] brion: definitely no .2 [20:13:39] 2.2 [20:13:43] yeah [20:14:33] brion: YuviPanda we still have to support 2.3 [20:14:34] https://developer.android.com/about/dashboards/index.html [20:14:44] 28.5% of all android phones are on that [20:14:45] tfinc: yeah, agreed [20:15:01] kill 2.2 [20:15:03] tfinc: just don't think we'll need to do pixel-perfect parity, but 'working' parity [20:15:05] whee [20:15:11] "better than the current app" [20:15:15] heh [20:15:16] which won't be hard ;) [20:15:27] it'll be the product owners call but i'm sure you can lobby him [20:15:40] hey kenanwang [20:15:45] ok :D [20:15:53] (03PS39) 10Dr0ptp4kt: Hide charge-inducing features. Intercept link interstitials sooner. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 [20:16:01] bah battery ran down on nexus1 again... it dies every time i unplug it for a second :) [20:16:18] i should reflash it with CM some time, i'd at least have more room for apps [20:16:55] kaldari: we're looking at https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1301 [20:17:00] kenan is updating AC [20:17:04] thanks [20:17:45] brion: I'm going to step away for a bit but will be back. Think you can prep for the market release? [20:17:55] sure [20:17:58] brion: ty [20:22:48] kenanwang: https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1321 [20:28:17] kenanwang, https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1289 [20:30:39] whose "WeAreLegion" are https://etherpad.wikimedia.org/p/MobileAsks/timeslider#221 ? [20:30:55] s/are/on [20:34:03] (03PS1) 10Brion VIBBER: bump version to 1.0beta13 (rev 14) [apps/android/commons] - 10https://gerrit.wikimedia.org/r/91497 [20:34:22] (03CR) 10Brion VIBBER: [C: 032 V: 032] "selfmerge :D" [apps/android/commons] - 10https://gerrit.wikimedia.org/r/91497 (owner: 10Brion VIBBER) [20:40:41] YuviPanda|away: http://dumps.wikimedia.org/android/wikimedia-commons-1.0beta13.apk <- please test :D [20:43:52] tfinc, it's me [20:44:10] YuviPanda|away: hah i already found another crash :D [20:44:13] "and that's why we test things" [20:44:31] brion: hah [20:44:33] where now [20:46:15] brion: lets no longer call this a beta [20:46:26] we agreed on that when we did the spike on remove all beat text [20:46:27] beta [20:47:07] MaxSem: in unclear what you mean from your comment on the asks [20:48:00] tfinc: yeah, let's call it 1.0 [20:48:18] YuviPanda: in the last crash fix ;) [20:48:21] Reedy: are you comfortable merging this? chris steipp +1'd: https://gerrit.wikimedia.org/r/#/c/91058/2 [20:48:38] brion: ? [20:48:39] tfinc: ok [20:48:40] tfinc, ops are constantly understaffed and if they had more people they would have been able to do more for us, and we wouldn't have to wait a long time for them to fulfill even trivial requests [20:48:48] YuviPanda: i'll show you a pull request in a moment :) [20:49:16] mhurd: brion YuviPanda one idea that i've been kicking around with kenanwang and awjr is to leave 11/4 - 11/8 unstructured for plumbing work and have 11/11 - 11/22 as the first sprint [20:49:44] MaxSem: are there mobile tasks that have not been completed due to this in the last quarter ? [20:50:01] tfinc, OSM?:) [20:50:06] tfinc: wfm [20:50:27] MaxSem: anything else past OSM ? [20:50:29] thats a good one [20:52:05] tfinc, don't remember anything that epic, but review times are generally long, you have to do a lot to gt your stuff noticed [20:52:06] neat. Activity monitor now shows you who you'r battery hog is [20:52:13] brion: mhurd YuviPanda --^ [20:52:49] MaxSem: review times for packages, puppet, etc ? [20:53:11] yup [20:53:22] tfinc: first sprint would be lots of plumbing if we do plan it all out anyway, unstructured probably makes sense rather than a bunch of big question marks :D [20:53:41] brion: yeah, we'll finalize on tuesday but i'm liking the idea of it [20:53:58] YuviPanda: given the language summit which days are you going to be out for in November ? [20:54:06] tfinc: let me check [20:56:52] dr0ptp4kt: everything is live, you can see your iframes in action on meta :) [20:57:35] tfinc: 15-20, I think? [20:57:42] (03PS1) 10Brion VIBBER: fix crash in crash fix [apps/android/commons] - 10https://gerrit.wikimedia.org/r/91502 [20:57:50] YuviPanda: ^ [20:57:56] yurik_ thx [20:58:32] so basically the middle of the first sprint YuviPanda [20:59:26] yup tfinc [20:59:56] yurik_ would you please rebase 90566 and resolve any merge conflicts? i don't want to break it [21:00:26] tfinc: activity monitor update is neat [21:00:47] (03PS1) 10Brion VIBBER: Bump version to 1.0 (rev 15) -- we're dropping beta marker \o/ [apps/android/commons] - 10https://gerrit.wikimedia.org/r/91503 [21:01:15] brion: what exactly was the crash scenario? [21:01:30] YuviPanda: load, rotate, explode [21:01:38] actually i'm not sure how it didn't explode the first time i tested it o_O [21:01:49] brion: hmm, same for me [21:02:03] possibly a race [21:02:29] mhurd: i noticed it when i clicked on batter and it told me that Chrome was the biggest batter hog. When you click on Chrome there it brings up Activity Viewer energy consumption [21:02:31] brion: coming to the selection committe mtg for the arch summit? [21:02:31] but it was dying when calling unregisterDataSetObserver [21:02:36] r31 if you're in the office [21:02:37] awjr: agh is that now? [21:02:40] aye [21:02:44] momentarily [21:05:49] brion: still can't reproduce it, but happy to merge, if you can modify the commit message [21:06:04] ok [21:06:49] (03PS1) 10MaxSem: Add a warning about mobileformat changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91504 [21:07:31] (03PS2) 10Brion VIBBER: fix intermittent crash in rotate-on-detail-view crash fix [apps/android/commons] - 10https://gerrit.wikimedia.org/r/91502 [21:08:11] awjr & yurik & yurik_, quick review please ^^^ :) [21:08:25] in a mtg MaxSem but can look after [21:09:31] (03CR) 10Yuvipanda: [C: 032 V: 032] fix intermittent crash in rotate-on-detail-view crash fix [apps/android/commons] - 10https://gerrit.wikimedia.org/r/91502 (owner: 10Brion VIBBER) [21:09:34] brion: merged [21:09:37] thx [21:09:49] i'll push up another build after this mtg i'm in [21:10:25] MaxSem: checking... [21:14:05] MaxSem: don't think its that important, but most of the time people have just called $this->setWarning(), not result-> [21:14:18] that method is part of the ApiBase [21:14:25] so up to you [21:14:27] yurik_, it's a hook handler, not an api module [21:14:47] opening hidden code... [21:15:11] MaxSem: i guess my statement refers to $module->setWarning [21:15:23] for consistency [21:15:29] meh, it works [21:15:50] as i said up to you - will +2 then [21:16:10] (03CR) 10Yurik: [C: 032] Add a warning about mobileformat changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91504 (owner: 10MaxSem) [21:16:14] thanks:) [21:16:18] np [21:16:41] (03Merged) 10jenkins-bot: Add a warning about mobileformat changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91504 (owner: 10MaxSem) [21:31:26] (03CR) 10JGonera: [C: 031] "Looks fine to me." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/83133 (owner: 10Dr0ptp4kt) [21:32:35] (03PS1) 10Jdlrobson: Define EventLogging schemas in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91513 [21:32:36] (03PS1) 10Jdlrobson: Update editing schema to support A/B test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91514 [21:32:37] (03PS1) 10Jdlrobson: Group schemas together [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91515 [21:32:49] (03CR) 10Jdlrobson: [C: 04-2] "Dependency needs review first" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91515 (owner: 10Jdlrobson) [21:33:31] (03CR) 10jenkins-bot: [V: 04-1] Define EventLogging schemas in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91513 (owner: 10Jdlrobson) [21:34:08] (03CR) 10jenkins-bot: [V: 04-1] Update editing schema to support A/B test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91514 (owner: 10Jdlrobson) [21:34:44] (03CR) 10jenkins-bot: [V: 04-1] Group schemas together [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91515 (owner: 10Jdlrobson) [21:44:24] brion: i'm going to head off in a while. anything else you want from me? [21:44:30] brion: I guess you can push the release out? [21:44:33] YuviPanda: i think i'm good [21:44:34] brion: remember to disable campaigns :D [21:44:36] will do :D [21:44:37] yes :DD [21:46:13] jdlrobson: Looks like you have 3 schema updates. Only the first one needs to be cherry-picked right? https://gerrit.wikimedia.org/r/#/c/91513/ [21:46:52] and of course https://gerrit.wikimedia.org/r/#/c/91511/ from the config file [21:52:02] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91514 (owner: 10Jdlrobson) [21:53:53] brion: re: Wikipedia app, I think we should go with JSON for the API and drop XML. Opposition? [21:53:57] I know it'll make yurik very happy :) [21:54:03] YuviPanda: agreed :D [21:57:12] (03PS1) 10JGonera: Regression: Fix "Start uploading" button on lead uploads tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91519 [21:57:22] jdlrobson, ^ [22:11:10] (03PS2) 10Kaldari: Define EventLogging schemas in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91513 (owner: 10Jdlrobson) [22:12:36] (03CR) 10Jdlrobson: [C: 032] Fix scripts/cucumber.sh [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91343 (owner: 10JGonera) [22:13:08] (03Merged) 10jenkins-bot: Fix scripts/cucumber.sh [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91343 (owner: 10JGonera) [22:13:09] (03Abandoned) 10Jdlrobson: Make "make cucumber" work (attempt 2) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89137 (owner: 10Jdlrobson) [22:24:30] (03PS6) 10JGonera: Hygiene: Clean up overlays.less and pagelist.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90068 [22:24:47] (03PS2) 10MaxSem: Don't mention 0 edits and 0 uploads on UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90930 [22:25:52] MaxSem: do you feel comfortable merging https://gerrit.wikimedia.org/r/#/c/91058/2? [22:26:20] awjr, we'll have a LD today, right? [22:26:59] eh not that im aware of MaxSem - was there something that needs to go out? [22:27:10] EL stuff [22:27:54] MaxSem: https://gerrit.wikimedia.org/r/#/c/91513/ ? [22:28:21] was reviewing it right now:) [22:28:36] MaxSem: i think that's safe for the train, isn't it? [22:29:11] (03CR) 10MaxSem: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91513 (owner: 10Jdlrobson) [22:29:19] ah [22:30:18] (03CR) 10MaxSem: "No need in -2 btw:)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89283 (owner: 10Jdlrobson) [22:30:28] MaxSem: i guess the only challenge is making sure that the config change goes out too [22:31:08] greg-g: if we have a config change that needs to happen in conjunction with the deployment train, how do we handle that? [22:33:07] awjr: I guess I should make a reserved window after train deploys for teams to do config changes.... [22:33:20] awjr: but, for now, just schedule a window, could be a LD [22:34:00] ok greg-g, the change im thinking of in particular would be best to happen in tandem with a config change; perhaps we should push both the change & config change out at the same time during LD [22:34:33] MaxSem: what do you think? ^ should we try to do this today? [22:34:33] * greg-g nods [22:35:15] awjr, afaik the result of non-sync deployment is the loss of EL, we can't afford this for a couple hours? [22:35:35] * awjr shrugs [22:36:00] the impression that i got was basically 'no' but i haven't heard specifically from kenan, and i don't see him around right now [22:36:05] lemme see if i can find him [22:39:05] MaxSem: i sent him a sms [22:39:05] (03CR) 10Brion VIBBER: [C: 032 V: 032] Bump version to 1.0 (rev 15) -- we're dropping beta marker \o/ [apps/android/commons] - 10https://gerrit.wikimedia.org/r/91503 (owner: 10Brion VIBBER) [22:39:12] ok back to releasing [22:40:40] * awjr waves to kenanwang [22:41:48] jdlrobson jgonera_ - does the EventLogging issue (danger zone!) affect account creation? [22:41:50] or just editing? [22:42:07] I think only editing, jdlrobson ? [22:53:22] (03PS3) 10Kaldari: Define EventLogging schemas in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91513 (owner: 10Jdlrobson) [22:54:08] if it's only mobile edit event logging then I'm ok letting it be down for 5-6 hours [22:54:18] MaxSem: ^ [22:54:24] but if it includes account creations I think we need to get it back up [22:54:26] (03PS4) 10Kaldari: Define EventLogging schemas in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91513 (owner: 10Jdlrobson) [22:54:39] anybody see jon wandering around in the office? [22:55:26] i sms'd him too [22:55:28] (03PS5) 10Kaldari: Define EventLogging schemas in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91513 (owner: 10Jdlrobson) [22:55:29] aw hello [22:55:52] (03CR) 10MaxSem: [C: 04-1] Define EventLogging schemas in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91513 (owner: 10Jdlrobson) [22:56:51] jdlrobson: the eventlogging issue - does it affect account creation too or just editing? [22:56:54] (03CR) 10MaxSem: "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91513 (owner: 10Jdlrobson) [22:57:31] awjr: i do not follow it effects all editing event logging [22:57:55] if we do not fix this during the lightning deployment window we will not collect any editing data [22:58:02] not sure what account creation has to do with it [22:58:09] (03PS1) 10JGonera: Load notifications overlay dynamically [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91526 [22:58:47] (03PS2) 10JGonera: Load notifications overlay dynamically [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91526 [22:58:57] jdlrobson: right; that is what im trying to figure out. kenanwang says if it's *only* editing-related events that won't get logged, he doesn't care if logging is busted for a few hours (eg between deployment train deploy and tomorrow's lightning deploy) [22:59:08] awjr: this will mess up our graphs [22:59:11] jdlrobson: kenanwang expressed specific concern about losing any account creation data [22:59:13] which i assume are important [22:59:15] jdlrobson: tell kenanwang [22:59:18] kenanwang: ^ [22:59:21] done [22:59:24] lol [22:59:30] (i'm not sure where he is right now) [22:59:39] probably heading to the same meeting as me [22:59:57] tfinc: ok Android version is uploaded & listed at https://www.mediawiki.org/wiki/Mobile/Release_history#Commons and uploaded to Google Play, pending automatic processing & release [22:59:59] ahh [23:00:08] brion: great. now lets do test flight [23:00:09] looks like max is already on it, but those changes *need* to get merged [23:00:10] if it breaks the graphs then lets fix jdlrobson [23:00:12] whee [23:01:19] so MaxSem awjr i'm pretty happy with merging kaldari's latest patch that MaxSem has -1ed - i agree with MaxSem that it could be better encapsulated but i think here the important thing is to make the fix - we can always add a FIXME to ensure this gets cleaned up later [23:01:30] although as i said to kaldari i think the enabled property shouldn't be used [23:02:07] ok; MaxSem can you manage getting this stuff out during this LD? [23:02:11] which is… hapening right now [23:02:34] yes if kaldari replaces the variable with a class existence check [23:02:38] :) [23:02:49] yeah, I can do that [23:02:49] kaldari: could we also move all the module definitions into the hook? [23:02:59] seems strange and unnecessary to have code in 2 places [23:03:33] jgonera_: is there an easy way to trigger mobile captcha? [23:03:54] and/or do you have a screenshot of it in action? because that's what i really need :) [23:04:24] awjr, if you have ConfirmEdit installed, then this is my config: [23:04:27] # ConfirmEdit (captcha) [23:04:27] require_once "$IP/extensions/ConfirmEdit/ConfirmEdit.php"; [23:04:27] require_once "$IP/extensions/ConfirmEdit/FancyCaptcha.php"; [23:04:27] $wgCaptchaClass = 'FancyCaptcha'; [23:04:27] $wgCaptchaDirectory = "$IP/cache/captcha"; [23:04:28] $wgCaptchaDirectoryLevels = 0; [23:04:30] $wgCaptchaSecret = "FOO"; [23:04:32] /$wgCaptchaTriggers['edit'] = true; [23:04:36] (uncomment the last line) [23:04:50] (03CR) 10Jdlrobson: [C: 04-1] "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91513 (owner: 10Jdlrobson) [23:05:06] cool thanks jgonera_ [23:05:09] I can make a screenshot later if you want [23:06:18] (03PS1) 10Brion VIBBER: bump version to 1.0.9.2 [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/91527 [23:06:30] jgonera_: ok, i can probably take care of it - i'll letcha know if i need one later. thanks! [23:06:43] (03CR) 10Brion VIBBER: [C: 032 V: 032] "(already pushed .0 and .1 via TestFlight)" [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/91527 (owner: 10Brion VIBBER) [23:07:44] MaxSem: I forget, what's the MediaWiki equivalent for class_exists()? [23:07:57] class_exists() [23:08:17] we're not planning to use hphp complier anymore [23:08:22] I thought there was a special function for MediaWiki, but maybe not :P [23:08:41] yeah, but it's not needed anymore [23:10:45] jdlrobson, when you have a chance, check https://gerrit.wikimedia.org/r/#/c/90686/ [23:11:09] (03PS6) 10Kaldari: Define EventLogging schemas in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91513 (owner: 10Jdlrobson) [23:11:56] (03CR) 10jenkins-bot: [V: 04-1] Define EventLogging schemas in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91513 (owner: 10Jdlrobson) [23:12:19] (03PS7) 10Kaldari: Define EventLogging schemas in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91513 (owner: 10Jdlrobson) [23:12:40] MaxSem, jdlrobson: OK, I think everyone will love this version: https://gerrit.wikimedia.org/r/91513 [23:13:01] (03CR) 10jenkins-bot: [V: 04-1] Define EventLogging schemas in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91513 (owner: 10Jdlrobson) [23:13:36] kaldari, I can't beat Jenkins to it:P [23:14:15] don't like it [23:14:16] :P [23:14:37] (03CR) 10Jdlrobson: [C: 04-1] "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91513 (owner: 10Jdlrobson) [23:15:39] (03PS8) 10Kaldari: Define EventLogging schemas in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91513 (owner: 10Jdlrobson) [23:16:07] OK, now it's perfect :) [23:16:42] greg-g, we're desperately trying to get something to deploy this LD window^^:) [23:17:13] just about there [23:17:17] hopefully ;) [23:17:18] kaldari, FAIL [23:17:18] (03PS1) 10Brion VIBBER: Release fixes; bump ver to 1.0.10 [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/91529 [23:17:31] misses a global [23:17:55] (03CR) 10Brion VIBBER: [C: 032 V: 032] Release fixes; bump ver to 1.0.10 [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/91529 (owner: 10Brion VIBBER) [23:18:18] good eye MaxSem :) [23:19:50] (03PS9) 10Kaldari: Define EventLogging schemas in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91513 (owner: 10Jdlrobson) [23:20:58] jdlrobson, fine with you?^ [23:21:00] Now it's new and improved! [23:21:45] MaxSem: just testing quickly [23:22:24] kaldari, how can something be new after 9 patchsets?:P [23:22:51] MaxSem: lol, remind me not to enter any timed programming contests [23:23:40] (03PS6) 10JGonera: Add template partials support to View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90686 [23:24:33] MaxSem: it's not working for me [23:24:39] testing testflight install... [23:25:27] looks ok \o/ [23:25:44] MaxSem: LD's aren't pokemon [23:25:50] :P [23:26:48] greg-g, because they're MMORPG! [23:27:18] in a way, yeah ;) [23:27:32] MaxSem: you do realize this will cause EventLogging to run on any wiki which has EventLogging installed [23:27:39] do we want this or should we have a special flag? [23:27:55] isn't it what we did before?\ [23:28:19] no [23:28:22] (03PS10) 10Jdlrobson: Define EventLogging schemas in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91513 [23:28:24] the wgLogEvents flag protected against it [23:28:35] tfinc: ok android upload pending on google play; iOS out now on test flight. [23:28:41] ah, so we should just use it? [23:28:41] hence why originally we used that instead of class_exists [23:28:49] this would be my suggestion [23:29:20] MaxSem: yes? no? i can fix up now.. [23:29:32] sure [23:29:58] (03PS11) 10Jdlrobson: Define EventLogging schemas in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91513 [23:29:59] MaxSem: ok done ^ [23:30:31] it also works [23:30:45] daaaemn jdlrobson - it's a WMF var [23:31:04] this is what i was saying [23:31:16] nope [23:31:42] extensions must not depend on external vars [23:32:01] I thought you said we still have a MF-specific var [23:32:14] OK [23:32:16] this works.. [23:32:24] (03PS12) 10Jdlrobson: Define EventLogging schemas in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91513 [23:32:25] ^ apply this one. It seems  [23:32:43] it seems $wgEventLoggingBaseUri exists to protect us from logging on wikis we shouldn't [23:33:00] i need to leave in 30 mins promptly and would like to test this on production before leaving :) [23:33:55] (03CR) 10MaxSem: [C: 032] Define EventLogging schemas in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91513 (owner: 10Jdlrobson) [23:34:23] we need greg-g's permission [23:34:25] (03Merged) 10jenkins-bot: Define EventLogging schemas in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91513 (owner: 10Jdlrobson) [23:34:28] ok so kaldari LD time :D [23:34:56] MaxSem: You want to do the LD or shall I? [23:34:57] (03PS2) 10Jdlrobson: Update editing schema to support A/B test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91514 [23:37:42] thank brion and mhurd for getting it out [23:38:14] jgonera: https://gerrit.wikimedia.org/r/91514 [23:38:25] mhurd: YuviPanda brion two regular releases :D [23:38:33] wooo! [23:38:50] yay! [23:39:06] doesn't it makes it so much easier to know that we release every sprint? [23:39:35] tfinc: ya [23:43:03] (03CR) 10JGonera: [C: 032] Update editing schema to support A/B test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91514 (owner: 10Jdlrobson) [23:43:06] MaxSem: I'm starting on the deployment now [23:43:20] need help? [23:43:43] (03Merged) 10jenkins-bot: Update editing schema to support A/B test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91514 (owner: 10Jdlrobson) [23:46:58] (03CR) 10Jdlrobson: [C: 032] Regression: Fix "Start uploading" button on lead uploads tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91519 (owner: 10JGonera) [23:47:32] (03Merged) 10jenkins-bot: Regression: Fix "Start uploading" button on lead uploads tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91519 (owner: 10JGonera) [23:47:48] (03CR) 10Jdlrobson: [C: 04-1] "Before merging I'd like to check with Kaity if this is actually desired behaviour - this makes the uploads link inaccessible on user's who" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90930 (owner: 10MaxSem) [23:48:09] (03PS1) 10Robmoen: Eliminate api fixmes from PageApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 [23:48:47] MaxSem: are you good to cut a deployment branch or does Michelle do that? [23:49:16] jdlrobson, a script does that [23:49:23] from master [23:49:26] MaxSem: at what time? [23:49:35] some time tomorrow [23:49:37] ok cool [23:49:49] * jdlrobson wonders if we should merge history before tomorrow :) [23:50:46] (03PS2) 10Jdlrobson: Eliminate api fixmes from PageApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen) [23:58:48] (03PS1) 10Jdlrobson: Hygiene: Simplify how make phpunit works in Makefile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91535