[00:08:04] (03PS1) 10Jdlrobson: Fix QUnit in Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91537 [00:17:07] kaldari, MaxSem: how did the LD go? [00:17:31] seems like it's working [00:17:44] is logmsgbot dead? [00:17:55] heh [00:20:33] far out, thanks kaldari and MaxSem : [00:20:34] :) [00:21:34] awjr: only tested on test.wiki so far, syncing to other wikis now [00:23:05] kk [00:24:19] awjr: it's synced everywhere now, and seems to be working [00:25:13] \o/ [00:29:13] awjr: hmm, actually it doesn't look like everything is actually updated [00:29:40] need to wait for RL cache to refresh perhaps? [00:29:45] but it is firing event logging events [00:30:14] are you seeing that in console or in the datastream? [00:30:23] console [00:30:47] it looks like the cherrypick didn't actually pick up the change for some reason [00:30:54] gimme a minute... [00:31:50] maybe a touch and rescyn? [00:31:54] *resync [00:31:57] the config change went out too? [00:34:05] awjr: I think you copied "Test agile hybrid template" to set up Flow in mingle. In them and in test___scrum_template, the "How does this velocity chart work?" link to the wiki is a 404. [00:34:57] that is lame [00:35:05] ah, found a working one at https://wikimedia.mingle.thoughtworks.com/projects/mobile/wiki/How_does_this_velocity_chart_work%3F [00:35:06] unless they are expecting you to create the wiki page yourself, spagewmf? [00:35:32] (03CR) 10CSteipp: "(1 comment)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/86820 (owner: 10Yurik) [00:36:06] MaxSem: you still around? [00:36:12] yup [00:36:17] how do you feel about merging https://gerrit.wikimedia.org/r/#/c/91058/2 ? [00:36:24] kaldari: get it worked out? [00:36:50] awjr, can do if kaldari deploys [00:37:20] ah yeah maybe he has his hands too full now; it can wait til tomorrow - it's already been broken for basically ever [00:41:21] kaldari, need help with this stuff? [00:41:30] I might in a sec [00:44:08] MaxSem, awjr: sorry about that. I just restored the config stuff in mobile.php for now, to make sure it keeps working while I figure out why the cherrypick didn't work [00:45:21] MaxSem: so I thought I cherrypicked the change, but it didn't seem to get picked up. Here's one of my cherrypick commits: https://gerrit.wikimedia.org/r/#/c/91534/ [00:45:40] does that look right? [00:46:39] kaldari, I usually create MF branches corresponding to WMF ones and cherry-pick into them [00:47:01] ah [00:47:11] I've no idea if cherrypicking into submodules work [00:47:39] yeah, I guess it doesn't :P [00:47:50] because submodules are just pointers to tree state and you need your own tree for cherrypicks [00:47:55] I'll do it from the extension repo [00:59:48] MaxSem: I tried creating a deployment branch for the extension and updating .gitreview (like it says at https://wikitech.wikimedia.org/wiki/How_to_deploy_code#Creating_an_extension_deployment_branch), but whenever I try to do git push origin wmf/1.22wmf22 it gives me Authentication failure :( [01:00:42] kaldari, did you touch the existing wmf21 and wmf22 branches? [01:01:41] eariler, yes, but not just now [01:01:44] kaldari: what does git config —get remote.origin.url show? [01:02:04] (that's two dashes) [01:02:30] https://gerrit.wikimedia.org/r/p/mediawiki/extensions/MobileFrontend.git [01:02:52] kaldari: i think you cloned a read-only copy [01:02:56] the proto should be ssh [01:03:21] kaldari: actually i take that back [01:03:27] that's the origin url for the submodule? [01:03:27] dammit, I'm too sleepy to be efficient now [01:03:36] (03CR) 10Dr0ptp4kt: [C: 04-1] "(4 comments)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90519 (owner: 10Yurik) [01:03:53] that's the origin from within MobileFrontend in my MediaWiki deployment branch [01:04:09] ok [01:04:16] apparently I don't know how to do this :( [01:04:27] what does 'git branch' show you? [01:04:36] wmf/1.22wmf22 [01:04:52] and you created the branch with —track to track the remote? [01:04:58] yes [01:05:30] (03PS1) 10MaxSem: Define EventLogging schemas in MobileFrontend [extensions/MobileFrontend] (wmf22) - 10https://gerrit.wikimedia.org/r/91545 [01:05:34] I've never actually done a cherry-pick of an extension before, so maybe I'm doing something wrong [01:05:45] kaldari, ^^^ [01:05:54] do we need to do wmf21? [01:06:10] bleh, yes [01:06:27] (03CR) 10Kaldari: [C: 032] Define EventLogging schemas in MobileFrontend [extensions/MobileFrontend] (wmf22) - 10https://gerrit.wikimedia.org/r/91545 (owner: 10MaxSem) [01:06:31] (03PS1) 10MaxSem: Define EventLogging schemas in MobileFrontend [extensions/MobileFrontend] (wmf21) - 10https://gerrit.wikimedia.org/r/91546 [01:06:43] (03CR) 10MaxSem: [C: 032 V: 032] Define EventLogging schemas in MobileFrontend [extensions/MobileFrontend] (wmf21) - 10https://gerrit.wikimedia.org/r/91546 (owner: 10MaxSem) [01:06:44] MaxSem: yeah, both unfortunately [01:07:07] (03Merged) 10jenkins-bot: Define EventLogging schemas in MobileFrontend [extensions/MobileFrontend] (wmf22) - 10https://gerrit.wikimedia.org/r/91545 (owner: 10MaxSem) [01:07:35] MaxSem: Sorry for my FAILs. Maybe next time you can walk me through it so I can figure out what I'm doing wrong [01:07:44] i've never actually tried to create a remote deployment branch from the command line before; you can (or at least used to be able to) do it from gerrit [01:07:59] kaldari, no problem - we're almost done [01:08:08] it's also possible you need special permissions to do it for the project [01:08:37] kaldari: take a look at https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/MobileFrontend,branches [01:08:50] that's the easiest way to manage the remote branches [01:09:33] ah [01:09:56] kaldari, I've created the submodule commits - can you deploy them? [01:10:57] I don't risk deploying myself at 5:10 am [01:11:18] MaxSem: sure... [01:14:14] ok, it's on test.wiki now [01:14:18] checking it [01:14:57] still works :) [01:15:02] deploying elsewhere [01:20:28] arg, it still wasn't picked up on tin [01:20:37] kaldari@tin:/a/common/php-1.22wmf22$ git submodule update --init --recursive extensions/MobileFrontend/ [01:20:37] Submodule 'extensions/MobileFrontend' () registered for path 'extensions/MobileFrontend' [01:20:38] fatal: reference is not a tree: f8e8b5b8695d61f46ea03f4b3d9e3f116313ebe5 [01:20:39] Unable to checkout 'f8e8b5b8695d61f46ea03f4b3d9e3f116313ebe5' in submodule path 'extensions/MobileFrontend' [01:21:23] kaldari: did you git fetch and rebase? [01:21:24] why init and recursive? [01:21:34] awjr: yes [01:22:03] er try again kaldari? [01:22:10] MaxSem: doesn't work regardless [01:22:22] did you do the git log and make sure the commit was there? [01:22:41] awjr: yeah, looks like it [01:22:46] :| [01:22:48] it's not seeing the commit [01:23:00] ah - did the commit get merged? [01:23:03] for that specific branch [01:23:04] ? [01:23:12] i've totally done that before - merge one branch but forget to merge the other [01:23:33] yeah the —init —recursive thing shouldnt be needed for MobileFrontend but it's in the documentation as some extensions need it [01:23:52] kaldari, the problem is that my commits were just merged [01:24:07] https://gerrit.wikimedia.org/r/#/c/91548/ [01:24:24] never trust jerkins when deploying, always set V+2 and submit, or it's going to take a looong time [01:24:33] ahha [01:24:42] so if you try again, should work kaldari [01:24:43] ok, lemme try it agian... [01:25:18] no, still not seeing the commit [01:25:23] yeah the deployment branches are the one place it's actually acceptable to hit 'submit' rather than just +2 [01:25:27] kaldari, I've updated code on tin [01:25:32] or so i've been told [01:26:25] MaxSem: how'd you get it to work? [01:26:56] pull && submodule update, nothing special [01:27:16] your mistake was that you attempted to deploy before stuff got merged [01:27:19] maybe you did it before my 2nd try [01:27:29] yeah, I guess so [01:27:52] alright, if this doesn't work, let's scrap it and deal with it tomorrow [01:28:00] it's way too late for everyone - especially MaxSem [01:28:27] kaldari, are you pushing or I should? [01:28:49] I can push it [01:28:52] hopefully :) [01:32:11] ok, those are both pushed out [01:32:26] and everything seems to be running still [01:32:39] now I'll do the config change again, which is the easy part [01:36:34] OK, that's done too [01:36:52] testing [01:37:17] still firing events [01:37:32] OK, I think everything is good now [01:37:36] huzzah! [01:37:39] wee [01:37:59] * MaxSem hits the pillow [01:38:01] thanks kaldari and MaxSem [01:38:03] night night MaxSem [01:38:09] MaxSem: thanks for rescuing the deployment. I hope I can figure out how to do that correctly in the future [01:38:52] kaldari: real quick - were youa ble to verify events properly coming into the data stream? [01:39:01] i dont have access to the data so i can't dbl check [01:39:02] yeah [01:39:05] far out [01:39:07] nice work [01:39:23] awjr: oh I thought you were going to tell me how to do that :) [01:39:39] ! [01:39:53] I only know how to check the events are firing [01:40:26] ok [01:40:31] i dont know myself [01:40:42] would I run a query on stat1? [01:40:57] kaldari: send an email out to the team, let everyone know the current state of things and ask for folks to verify everything is OK [01:41:04] kaldari: yeah i believe the data goes to stat1 but i dont know details [01:41:06] awjr: good idea [01:42:06] oh kaldari [01:42:11] yeah [01:42:13] i think i may have found an email on the swubject [01:42:30] oh nope, it's for campaign tracking; different thing [01:43:10] alright, i have no idea. events firing is good but only half the battle. [01:43:28] so, shoot out the email and if you can keep an eye out for responses [01:43:29] true [01:43:50] i have to jet but i'll be back in an an hour and a half and i can check back then [02:32:47] blerch [07:04:29] tfinc: around? [08:33:51] playing with varnish on mobile01 . beta [10:49:22] (03CR) 10Mark Bergsma: [C: 031] "Adding cookies is only problematic for caching if the cache needs to Vary on this cookie. This doesn't appear to be the case here." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91401 (owner: 10Kaldari) [15:52:14] (03CR) 10Krinkle: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91537 (owner: 10Jdlrobson) [15:53:50] (03CR) 10Krinkle: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91537 (owner: 10Jdlrobson) [16:08:07] (03PS1) 10Jdlrobson: Regression: Fix login logo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91615 [16:23:35] hrmmmmmmm [16:23:37] http://wiki.verkata.com/license/ [16:23:43] > This site, WikiPedia Mobile, uses Verkata's Content Transcoder Technology to reformat content so that it can be viewed on mobile devices. Content is optimized for the phones of the mobile operator Helio. [16:24:21] it's apparently a guy in SF even [16:52:48] jeremyb, we're moving away from HTML reformatting [16:55:21] ahaha, http://wiki.verkata.com/en/wiki/2013_Harbin_smog <-- edit links still there [16:59:46] https://en.wikipedia.org/w/index.php?title=Wikipedia:Mirrors_and_forks/Vwxyz&diff=578571054&oldid=548239089 [17:00:22] MaxSem: special:random is served in place, doesn't redirect [17:00:23] :P [17:00:34] sometimes looks like vector, sometimes not [17:04:17] (03CR) 10Awjrichards: [C: 032] Regression: Fix login logo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91615 (owner: 10Jdlrobson) [17:04:18] brion: gah, looks like i've been missing emails from mobile-feedback-l because mailman decided to automatically unsubscribe me :| [17:04:30] dang [17:04:51] (03Merged) 10jenkins-bot: Regression: Fix login logo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91615 (owner: 10Jdlrobson) [17:05:14] brion: need to get re-added [17:05:30] brion: also, i had apps/android/java-mwapi created. Doing a new js api [17:06:32] brion: any complaints from the commons release so far? [17:06:49] not that i've noticed [17:07:23] ah we should go ahead and create apps/android/wikipedia and apps/ios/wikipedia so they're ready to start committing :D [17:08:08] brion: heh, yeah [17:08:24] brion: also, I want to enforce some jenkins things for the new repos [17:08:32] brion: prepped the one for java-mwapi, will commit shortly [17:08:40] awesome [17:09:02] brion: mostly around tests, javadoc and such [17:11:05] (03PS1) 10Yuvipanda: Initial commit with appropriate project structure [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/91628 [17:11:08] brion: ^ [17:11:33] brion: 1. TDD, so I first write tests, then stub them out to get them to compile, then write the code, 2. Checkstyle checks for plenty of things [17:11:44] ok reqs to end of https://www.mediawiki.org/wiki/Git/New_repositories/Requests [17:11:54] nice [17:12:24] brion: thoughts on mandatory JavaDoc? [17:12:29] I have been doing it and I quite like it [17:12:34] i say yes [17:12:37] docs are good [17:12:41] similar to forcing git commit messages [17:12:42] it's good to stay in the habit :D [17:12:44] yeah, agreed brion [17:12:55] brion: so I am going to make checkstyle voting on jenkins [17:13:06] niiiice [17:13:41] brion: it'll also stick to the mw guidelines where possible ' if ( than if(' for example [17:13:51] brion: but those also exist in the Sun java style guidelines, so it's ok [17:13:58] killed the 80 char limits tho [17:13:59] :P [17:14:04] heh [17:14:08] we ain't using no teletypes [17:14:11] we can always tweak it later if we feel like [17:14:12] indeed [17:14:32] brion: want to +2? :D [17:14:38] i wish java had map and array list literal primitives :) [17:14:41] looking it over right now [17:14:47] brion: heh, ok [17:15:32] (03CR) 10Brion VIBBER: [C: 032 V: 032] "woo" [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/91628 (owner: 10Yuvipanda) [17:17:05] now lemme make sure i can build it :D [17:17:12] hehe :D [17:18:28] whoops gotta reinstall mvn [17:18:40] brion: hehe [17:19:08] "BUILD SUCCESS" [17:19:51] brion: try intellij? [17:19:59] i'm wondering if we should ship the IML files [17:23:16] ok that was weird [17:23:25] intellij wasn't showing the directory in the import dialog for like a minute [17:23:34] i see [17:23:43] some sort of inotify-in-os-x equvialent bug? [17:23:50] likely yeah [17:23:54] weeeeird [17:23:58] ok it opened, let's try build [17:24:47] YuviPanda: trying to figure out if i can make a run config for the tests... [17:25:04] brion: yeah, there's a junit runner thing that worekd for me [17:27:30] YuviPanda: ok i seem to be able to make a junit runner with *either* the ApiTests or the ApiConstructionTests but not both? [17:27:38] YuviPanda: brion mhurd : how are our releases looking ? [17:27:42] yeah sharing the .iml might be easier, if it doesn't include per-user crap :D [17:27:55] tfinc: i haven't heard any pitchforks yet so that's a good sign :D [17:27:56] brion: it sadly does, and changes for tiny things (like re-arranging your damn window) [17:28:03] damn [17:28:29] tfinc: what brion said [17:28:45] assuming that holds lets do a market push at the same time as yesterday then [17:28:57] tfinc: I looked for reviews (none yet) but apparently i have been unsubscribed from mobile-feedback-l for a while automatically(!?!) and hence have missed a few crash reports [17:29:00] tfinc: sounds good [17:29:13] tfinc: can you re-subscribe me? [17:29:21] hmmi may have to fix my sub to that as well [17:29:41] YuviPanda: why can't you just subscribe ? its just a mailman list [17:29:48] tfinc: nope, it's a private list [17:30:01] you added me the first time, IIRC [17:33:25] brion: https://bugzilla.wikimedia.org/show_bug.cgi?id=56110 [17:33:39] brion: can you try running checkstyle? [17:33:50] brion: brew install checkstyle, then checkstyle -c checkstyle.xml -r src [17:34:35] Successfully subscribed: ypandian@wikimedia.org [17:34:36] YuviPanda: [17:34:46] tfinc: hmm, okay [17:35:21] YuviPanda: it whinges about a couple things in tests [17:36:48] brion: in the tests directory? [17:36:51] brion: i hadn't fixed those yet [17:36:56] yeah [17:36:58] ok :D [17:37:17] brion: but I geuss this is reasonable enogh [17:37:24] brion: don't want to have unreasoanble coding standards :D [17:37:28] ha [17:37:33] brion: also there are checkstyle plugins for IntelliJ too [17:38:06] nice [17:47:27] brion: i forgot how much fun untangling retain cycles can be... uuuhhhhhh [17:51:08] (03PS1) 10Robmoen: Modify epoch test to restore original url on teardown [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91635 [17:54:15] awjr: jdlrobson I was trying to reply with https://wikitech.wikimedia.org/wiki/EventLogging for the thread about how to verify if events are coming in, but it just bounced :| [17:54:45] huh, i got it YuviPanda but it looksl ike you sent from your gmail account which might be why it bounced [17:55:10] awjr: hmm, cross posting between mobile-tech and analytics-l, I think. it went through to analytics [17:55:22] awjr: essentially, you can do 'zsub vanadium.eqiad.wmnet:8600 | grep ' and watch [17:55:55] marktraceur: have i broken anything so far today? :) [17:56:03] YuviPanda: from somewhere on the cluster (eg fenari/tin)? [17:56:03] Not to my knowledge [17:56:05] I can check [17:56:12] marktraceur: hehe [17:56:18] awjr: yeah, I remember running it from stat1 [17:56:25] YuviPanda: can you add that :) [17:56:28] awjr: since that's all I have access to, but rest of cluster should work too [17:56:36] mhurd: Confirmed not banned at commons. :) [17:56:43] it would've taken us a while to figure that out from this documentation [17:56:44] awjr: it's kinda obvious, because of the .wmnet thing, no? [17:56:45] marktraceur: haha yay! [17:56:53] awjr: ah, yeah. [17:57:17] YuviPanda: a "here's you double check daata's coming in" section would be useful for quick needs [17:57:22] thanks :) [17:58:06] MaxSem: add education reqs to https://office.wikimedia.org/wiki/Job_descriptions/Software_Developer_Backend_(Mobile) [17:59:30] tfinc, doned [17:59:37] wow, i was looking for an image of a 'hat tip' and there's a whole category on commons called 'hat tipping' [18:03:10] awjr: check https://wikitech.wikimedia.org/wiki/EventLogging now [18:05:52] awjr: slide 18 still needs love [18:06:33] it will be done :) [18:07:06] tfinc: headsup I might not last all of the quarterly meeting, it goes on until 4:30 AM. Will try to stick on for as much as possible tho [18:07:34] thanks YuviPanda [18:07:47] (03PS1) 10Kaldari: Making last modified text darker so that it is readable. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91640 [18:07:58] we'll break it up into two parts. feel free drop off on the second as it'll be very data heavy [18:08:12] (03CR) 10jenkins-bot: [V: 04-1] Making last modified text darker so that it is readable. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91640 (owner: 10Kaldari) [18:08:53] https://gerrit.wikimedia.org/r/#/c/91401/ didn't get merged :( [18:08:59] tfinc: ok [18:09:39] has deployment branch been cut yet Reedy? [18:09:42] Yup [18:09:44] k [18:09:51] tfinc: gail wants to climb tonight [18:10:08] kaldari: if we ened to get that out asap we can lightning deploy it [18:10:14] mhurd: yup, she mailed me [18:10:16] looks like we got ops' blessing [18:10:38] awjr: yeah, we need to have that deployed before Monday [18:11:40] ok kaldari [18:12:11] kaldari: wait - deployed everywhere, or just in sync with the deployment train? [18:12:38] deployed everywhere would be best [18:12:54] Guess I'll ping greg about another lighting deploy [18:13:22] kaldari: ok. i need to focus on quarterly review stuff until it's over this afternoon. can you work with MaxSem to get it merged and you guys figure out getting it deployed during LD today? of course be sure to schedule with greg-g as necessary [18:13:33] sure [18:13:36] sure [18:14:12] * greg-g waves [18:14:27] Something seems to be wrong with Jenkins. It can't merge this change even though it's completely rebased: https://gerrit.wikimedia.org/r/#/c/91640/ [18:15:12] I hope I didn't screw up the entire MobileFrontend repo yesterday [18:16:08] greg-g: Do you know if Jenkins is having any problems today? [18:17:17] (03PS2) 10Kaldari: Making last modified text darker so that it is readable. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91640 [18:20:32] oh well, seems to be fine now [18:20:35] kaldari: haven't looked specifically [18:20:39] ah, just slow? [18:21:28] greg-g: it gave a "Build failed" on a completely rebased patch. [18:22:04] greg-g: I deleted 1 whitespace character, resubmitted, and it worked. [18:22:21] without doing another rebase [18:22:32] multichill|2, have you seen my response at https://bugzilla.wikimedia.org/show_bug.cgi?id=50857 ? [18:22:49] awjr: About your EventLogging question [18:22:56] YuviPanda: as long as your around for slides 19 - 31 to include anything that i forget then we'll be fine [18:23:12] tfinc: can you share the presentaiton iwth me? [18:23:14] *with [18:23:47] YuviPanda: check mobile tech [18:23:51] Was the concern that events were not getting recorded at all, or not replicated to tables on stat1 log db? [18:23:56] kenanwang mailed it out [18:24:16] tfinc: ah, got it [18:24:30] kaldari: huh, sorry, not sure how to debug that one [18:24:51] greg-g: no problem, at least it worked the 2nd time :) [18:25:07] tfinc: slide 18 done. [18:26:00] kaldari: if at first.. [18:29:40] (03CR) 10Jdlrobson: "has this change been run through a designer?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91640 (owner: 10Kaldari) [18:30:00] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91640 (owner: 10Kaldari) [18:30:58] kenanwang: https://bugzilla.wikimedia.org/show_bug.cgi?id=53902 this needs your input asap (obviously after quarterly review) [18:31:46] awjr: haha .. ok [18:31:55] awjr: way to go with cheesy [18:32:12] my mom always said 'go with what you know' [18:32:23] kaity: can I run a design tweak by you? [18:41:06] kaldari, do you want to LD today? [18:41:22] maybe :) [18:41:45] cuz if it's today we need to prepare now due to the meeting [18:42:11] StevenW: the concern was that we weren't sure whether or not events were getting recorded and if they were getting recorded correctly. i felt it important to dbl check since we made a small bug significant change [18:42:37] since we just had the branch cut, would anyone object to a deploy from master, or would we want a cherry pick? [18:42:51] who added "* moretime from VE team to make skin, RL and workon JavaScript Ulibraries in core " to https://etherpad.wikimedia.org/p/MobileAsks ? [18:42:56] i need more detail [18:43:05] past with rmoen is supporting us on [18:43:14] awjr: Yeah, as far as best practices, we always have the data analyst and/or PM check the log db on stat1 for events getting recorded. [18:43:30] You can also record events from labs, or your local setup with vagrant [18:43:43] kaldari: jgonera jdlrobson --^ [18:43:58] StevenW: yah - usually when we deploy stuff like that folks who know what's up are around to check stuff like that, but we were in a situation last night where it was just kaldari and me, and we didn't know what to do :) [18:44:20] tfinc: me sorry [18:44:29] s/with/what [18:45:20] StevenW: fwiw, vagrant's local one doesn't actually work (yet?) and I don't know who all has access to the labs ones [18:46:58] YuviPanda: idk how it works, but in our log for most recent GettingStarted test (GettingStartedOnRedirect_5944134 is the table) you can see events from 127.0.0.1 [18:47:14] StevenW: oh, sure, sending events *from* vagrant works, just not *to* vagrant [18:47:27] StevenW: so the only current way to easily test is to send them to production and then check from stat1 [18:47:28] Ah yes. [18:47:48] Yep [18:48:12] you can hack up a local instance trivially (2-3 commands, and they are even documented!) but obviously it won't be the same pipeline [18:48:45] Anyway tfinc awjr: DarTar should be able to walk you through how to check the production data pipeline step by step. But the skinny is basically that you need to go look on stat1. [18:49:16] dang, computer crashed again and ate my scrollback [18:49:43] ty StevenW, i think YuviPanda's additions to the documentation on wikitech was a big help [18:50:03] MaxSem: since we just had the branch cut anyway, do you think we should just do the LD from master (rather than cherrypicking)? [18:50:17] why not [18:50:20] kaity: ping [18:50:23] (if jcmish approves) [18:50:54] kaldari: kaity is AFK. She may be interviewing someone I think. [18:50:55] if nothing else gets merged today, it might not matter anyway [18:51:14] well apart from pushing things to en.wiki sooner [18:52:13] mhurd: YuviPanda: any final fixes I should poke at in the time before the meeting? [18:52:33] brion: nope [18:53:28] kaldari: what was your question? [18:53:46] jgonera: Is it cool if I pick up the AbuseFilter bug or is Rob working on that? [18:54:03] kaity: I have a small design tweak I want to run by you for approval. [18:54:16] I'll come over in a minute [18:54:19] thanks! [18:55:05] kaldari, I think he's not, but check with him [18:55:40] rmoen: is it cool if I take the AbuseFilter throttling issue or are you working on that? [18:56:54] brion: no fixes. i did however vastly refactor the uploading for cancel-ability but it needs further cleanup and testing [18:57:04] woohoo [18:57:14] ok we'll poke that into a bug fix release later as time permits [18:57:21] brion: ya. won't be ready in time for the release [18:57:38] brion: but hope to have something for you to look at this afternoon [18:57:43] spiff [18:57:55] brion: pretty big diff [18:58:00] hehe [18:58:22] brion: should finally be rid of that retain cycle warning :) [18:58:26] yay! [19:00:00] mhurd: that reminds me; for the new reader app YuviPanda and I are thinking of using an event bus for the Android version to allow different parts of the app to send notifications to each other. I think for iOS NSNotificationCenter can provide this role right? [19:00:17] brion: yes [19:00:21] excellent :D [19:00:31] that's one less external library we need [19:04:12] greg-g: I signed up for the Lightning deploy window again. Hope that's OK :) [19:05:22] (03CR) 10Jdlrobson: [C: 04-1] "(3 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen) [19:09:52]