[00:01:12] <YuviPanda>	 brion: I have code coverage tools working!
[00:01:26] <YuviPanda>	 brion: with per line coverage reports!
[00:01:57] <kaldari>	 awjr, MaxSem: Yay, it works!
[00:02:01] <grrrit-wm>	 (03PS1) 10Yuvipanda: Produce code coverage reports in html [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/91808 
[00:02:05] <YuviPanda>	 brion: ^ :D
[00:02:10] <awjr>	 \o/
[00:03:10] <MaxSem>	 wee
[00:06:38] <kaldari>	 pushing to en.wiki now
[00:07:51] <grrrit-wm>	 (03PS1) 10Yuvipanda: Add trivial test for behavior when undefined method is given [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/91810 
[00:10:11] <Reedy>	 http://www.techradar.com/au/news/phone-and-communications/mobile-phones/new-sony-xperia-phones-including-8-core-monster-could-debut-nov-12-1193473
[00:10:40] <YuviPanda>	 Reedy: whatever happened to the Nexus you took back from the US?
[00:11:23] <awjr>	 saw the sync to enwiki - nothing looks broken on enwiki kaldari but dunno how to test; things look ok?
[00:11:39] <kaldari>	 nothing yet...
[00:11:45] <kaldari>	 it's working on test and mediawiki...
[00:11:59] <Reedy>	 YuviPanda: Which one? I brought 3 back :P
[00:12:05] <awjr>	 oh might need to wait for RL cache to expire for new js
[00:12:07] <YuviPanda>	 Reedy: ah, the one that had issues
[00:12:12] <kaldari>	 if the JS doesn't update soon, I'll touch and sync
[00:12:14] <Reedy>	 LG repaired it for me in the UK
[00:12:20] <kaldari>	 the new code is definitely in the right place on tin though
[00:12:23] <jdlrobson>	 jgonera: https://gerrit.wikimedia.org/r/91785
[00:12:25] <Reedy>	 Forwarded it onto Norway a couple of days ago
[00:12:29] <awjr>	 although judging from the sync time it should be good by now
[00:12:31] <YuviPanda>	 Reedy: ah, nice
[00:12:43] <Reedy>	 They suggested I could send it back to Google
[00:12:51] <Reedy>	 Considering Google were out of stock...
[00:12:58] <YuviPanda>	 heh
[00:13:06] <YuviPanda>	 you'd probably not get it back for a while, perhaps
[00:13:53] <awjr>	 kaldari: did you try with ?debug=true?
[00:14:03] <kaldari>	 no, good idea
[00:14:53] <grrrit-wm>	 (03CR) 10JGonera: [C: 032] Regression: Ensure last modified link renders consistently when dynamically loaded [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91785 (owner: 10Jdlrobson)
[00:15:18] <grrrit-wm>	 (03PS5) 10Jdlrobson: Hygiene: Eliminate api fixmes from PageApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen)
[00:16:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Regression: Ensure last modified link renders consistently when dynamically loaded [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91785 (owner: 10Jdlrobson)
[00:16:18] <kaldari>	 awjr: it works with debug=true
[00:16:28] <grrrit-wm>	 (03PS6) 10Jdlrobson: Hygiene: Eliminate api fixmes from PageApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen)
[00:16:41] <kaldari>	 awjr: must just have the old JS cached
[00:17:08] <awjr>	 aye, although it should have refreshed by now… RL ttl is 5 mins, right?
[00:17:25] <kaldari>	 MaxSem: Look like the LD was successful so you can go to bed now :)
[00:17:29] <kaldari>	 Thanks for the help!
[00:17:37] <kaldari>	 Now I know how to do this correctly :)
[00:17:59] <kaldari>	 awjr: yeah, I'll give it a few more minutes
[00:18:05] <awjr>	 ok
[00:18:35] <awjr>	 kaldari: i gotta run but give me a call on my cell if something explodes
[00:18:39] <kaldari>	 NP
[00:18:42] <awjr>	 thanks dude!
[00:18:45] <awjr>	 and nice work :D
[00:20:29] <YuviPanda>	 brion: i'm off now. the code seems to be rather close to 100% coverage, but of course, it is so tiny it doesn't matter.
[00:20:37] <YuviPanda>	 brion: but I like that we used this to setup the process, so woo!
[00:20:45] <YuviPanda>	 brion: am off to sleep now, hopefully for real
[00:21:13] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen)
[00:50:11] <MaxSem>	 kaldari, anything wrong?
[00:53:28] <kaldari>	 just ResourceLoader being dumb
[00:55:15] <MaxSem>	 heh
[00:55:57] <kaldari>	 MaxSem: https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=true&lang=en&modules=mobile.editor&skin=vector&version=20131024T012259Z&* has the new code in it, but https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=mobile.editor&skin=vector&version=20131024T012259Z&* doesn't :(
[00:56:09] <kaldari>	 I've tried touching and syncing twice
[00:56:24] <kaldari>	 the only difference in those is one is debug=true and the other is debug=false
[00:56:46] <MaxSem>	 what did you touch?
[00:56:52] <kaldari>	 the JS file
[00:57:35] <kaldari>	 javascript/modules/editor/EditorOverlay.js
[00:58:15] <kaldari>	 that's the file that has the new JS in it to set the cookie
[00:59:29] <MaxSem>	 try touching everything
[00:59:33] <kaldari>	 lemme try touching the main file
[00:59:36] <kaldari>	 or everything
[00:59:51] <MaxSem>	 find -type f -exec touch {} \;
[01:01:17] <kaldari>	 syncing again
[01:07:30] <grrrit-wm>	 (03PS1) 10Dr0ptp4kt: Prevent against future badly behaving userCan hook implementations. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/91814 
[01:07:49] <kaldari>	 MaxSem: Finally, it works!
[01:08:15] <kaldari>	 MaxSem: guess I just needed to touch everything :)
[01:09:47] <kaldari>	 MaxSem: thanks again, you should go to bed :)
[02:12:45] <grrrit-wm>	 (03PS3) 10JGonera: Load notifications overlay dynamically [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91526 
[07:52:52] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Load notifications overlay dynamically [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91526 (owner: 10JGonera)
[07:52:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Load notifications overlay dynamically [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91526 (owner: 10JGonera)
[09:35:02] <grrrit-wm>	 (03PS1) 10Ebrahim: Native digits on Minerva skin notification count [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91832 
[09:38:25] <grrrit-wm>	 (03CR) 10Ebrahim: "This is for making https://f.cloud.github.com/assets/833473/1406735/182532f6-3d59-11e3-952c-a5b89fa0245a.png native digits" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91832 (owner: 10Ebrahim)
[12:24:44] <grrrit-wm>	 (03PS1) 10Yurik: Added a few test modes to test ESI bug on beta - should be reverted [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/91850 
[12:24:58] <grrrit-wm>	 (03CR) 10Yurik: [C: 032] Added a few test modes to test ESI bug on beta - should be reverted [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/91850 (owner: 10Yurik)
[12:25:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Added a few test modes to test ESI bug on beta - should be reverted [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/91850 (owner: 10Yurik)
[12:59:39] <grrrit-wm>	 (03PS4) 10Zfilipin: Renamed tests/acceptance folder to tests/browser [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87565 
[13:00:59] <grrrit-wm>	 (03CR) 10Zfilipin: "Could somebody please merge this into master before another merge conflict happens? :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87565 (owner: 10Zfilipin)
[13:46:16] <brion>	 my iPhone 5s is in... kentucky
[16:26:13] <grrrit-wm>	 (03CR) 10Mgrover: [C: 032] Renamed tests/acceptance folder to tests/browser [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87565 (owner: 10Zfilipin)
[16:26:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Renamed tests/acceptance folder to tests/browser [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/87565 (owner: 10Zfilipin)
[17:12:01] <YuviPanda>	 hey brion
[17:12:05] <brion>	 hey hey
[17:13:05] <YuviPanda>	 brion: saw my last two commits from y'day?
[17:13:10] <brion>	 grr my nexus 7 battery ran down again, have to wait for it to charge enough to show the 'no battery' warning
[17:13:15] <brion>	 not yet
[17:13:19] <brion>	 lemme pull up the ol' gerrit dashboard
[17:13:43] <brion>	 on java-mwapi?
[17:13:53] <YuviPanda>	 brion: yeah
[17:13:59] <brion>	 fancy, code coverage reports :D
[17:14:15] <YuviPanda>	 brion: indeed
[17:14:25] <YuviPanda>	 brion: we'll have the unit tests *and* coverage reports run after every merge
[17:14:30] <YuviPanda>	 once i get hold of hashar, at least
[17:15:13] <brion>	 YuviPanda: hmm, where do the .html get generated?
[17:15:25] <YuviPanda>	 brion: target/site
[17:15:41] <brion>	 i don't see it... does 'mvn test' not produce them?
[17:15:48] <brion>	 standup time
[17:16:00] <YuviPanda>	 brion: nope! mvn cobertura:cobertura
[17:16:11] <YuviPanda>	 brion: that runs the tests and produces the reports
[17:16:21] <YuviPanda>	 brion: am I in wrong hangout?
[17:19:07] <grrrit-wm>	 (03PS2) 10MaxSem: Native digits on Minerva skin notification count [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91832 (owner: 10Ebrahim)
[17:19:16] * Reedy  waves his hand at YuviPanda

[17:19:27] <Reedy>	 This is not the hangout you are looking for...
[17:26:49] <mhurd>	 brion: https://github.com/couchdeveloper/RXPromise
[17:27:12] <brion>	 [ERROR] Failed to execute goal org.codehaus.mojo:cobertura-maven-plugin:2.6:instrument (default-cli) on project api: Execution default-cli of goal org.codehaus.mojo:cobertura-maven-plugin:2.6:instrument failed: Plugin org.codehaus.mojo:cobertura-maven-plugin:2.6 or one of its dependencies could not be resolved: Could not find artifact com.sun:tools:jar:0 at specified path 
[17:27:12] <brion>	 /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home/../lib/tools.jar -> [Help 1]
[17:27:41] <YuviPanda>	 brion: you do have the jdk installed, right?
[17:28:00] <brion>	 $ javac
[17:28:00] <brion>	 Usage: javac <options> <source files>
[17:28:01] <brion>	 sure do
[17:28:20] <brion>	 but that exact path to a tools.jar does not exist
[17:28:42] <YuviPanda>	 brion: hmm, jdk6 or 7?
[17:28:46] <brion>	 6
[17:28:53] <brion>	 http://comments.gmane.org/gmane.comp.jakarta.turbine.maven.user/124000
[17:29:27] <brion>	 apparently it doesn't work with apple java unless you fuck around with symlinks?
[17:29:28] <brion>	 hah
[17:29:58] <YuviPanda>	 brion: heh, I've Sun's JDK7
[17:30:03] <YuviPanda>	 so i guess that's why I'm not hitting it?
[17:30:11] <brion>	 i'll just download sun java :P
[17:30:40] <YuviPanda>	 brion: :D
[17:30:56] <brion>	 "Sorry, you must accept the License Agreement before downloading."
[17:30:58] <brion>	 fuck you oracle
[17:31:10] <YuviPanda>	 heh
[17:31:13] <brion>	 there we go, it's downloading now
[17:31:31] <grrrit-wm>	 (03PS7) 10Robmoen: Hygiene: Eliminate api fixmes from PageApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 
[17:32:45] <brion>	 wtf
[17:32:50] <brion>	 it's still trying to run on the apple java 1.6
[17:33:04] <YuviPanda>	 brion: downloaded so fast?! \o/
[17:33:06] <YuviPanda>	 err
[17:33:07] <YuviPanda>	 :O
[17:33:17] <brion>	 :)
[17:36:24] <tfinc>	 mhurd: YuviPanda brion bad of me to note triage https://bugzilla.wikimedia.org/show_bug.cgi?id=56150
[17:36:27] <tfinc>	 i'm out of practice 
[17:36:30] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] Hygiene: Eliminate api fixmes from PageApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen)
[17:36:35] <jdlrobson>	 ^ MaxSem can you +2 ?
[17:36:59] <tfinc>	 brion: looks like thats a time box if your doing an audit
[17:45:18] <jcmish>	 jdlrobson:  I'm off to dimi's fencing class can we do desktop nearby tests around 1:30pm PT? 
[17:45:33] <jdlrobson>	 that should work yeh
[17:46:11] <tfinc>	 kenanwang: can you add our new quarterly goal to https://www.mediawiki.org/wiki/Wikimedia_Engineering/2013-14_Goals#Mobile ?
[17:47:30] <grrrit-wm>	 (03CR) 10Brion VIBBER: "With Apple Java 1.6 on OS X 10.9 installed this fails, unless you either figure out where they messed up the pom.xml in cobertura, or hack" [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/91808 (owner: 10Yuvipanda)
[17:47:38] <kenanwang>	 k will do
[17:47:44] <kenanwang>	 tfinc: ^
[17:49:28] <kenanwang>	 done
[17:50:01] <awjr>	 kenanwang: you should go to bed.
[17:50:34] <grrrit-wm>	 (03PS2) 10Brion VIBBER: Produce code coverage reports in html [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/91808 (owner: 10Yuvipanda)
[17:50:48] <brion>	 YuviPanda: ok I added a readme file that says how to run the tests and has the workaround for my apple java issue ;)
[17:50:52] <awjr>	 tfinc: do you still have my retrospectives book?
[17:50:53] <brion>	 sound good?
[17:51:21] <YuviPanda>	 brion: yeah
[17:51:24] <YuviPanda>	 brion: feel free to +2
[17:51:33] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] Produce code coverage reports in html [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/91808 (owner: 10Yuvipanda)
[17:51:36] <brion>	 whee
[17:51:50] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Address FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91900 
[17:51:51] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Address wgMFMode FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91901 
[17:51:52] <grrrit-wm>	 (03PS2) 10Brion VIBBER: Add trivial test for behavior when undefined method is given [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/91810 (owner: 10Yuvipanda)
[17:52:20] <kaldari>	 running to the post office
[17:52:24] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Address FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91900 (owner: 10Jdlrobson)
[17:52:39] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] Add trivial test for behavior when undefined method is given [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/91810 (owner: 10Yuvipanda)
[17:52:48] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Address wgMFMode FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91901 (owner: 10Jdlrobson)
[17:53:02] <mhurd>	 brion: RXPromise compiles...
[17:53:09] <brion>	 woo
[17:55:34] <brion>	 YuviPanda: ok to close out https://gerrit.wikimedia.org/r/#/c/91770/ ?
[18:12:01] <grrrit-wm>	 (03CR) 10MaxSem: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen)
[18:20:23] <mhurd>	 violetto: hey may. do you have a couple minutes today to chat about the iOS commons app login screen buttons?
[18:30:54] <violetto>	 yes mhurd
[18:31:17] <violetto>	 what about 1pm? 
[18:31:24] <mhurd>	 violetto: sounds good!
[18:31:33] <violetto>	 k :)
[18:54:16] <grrrit-wm>	 (03CR) 10CSteipp: [C: 031] Prevent against future badly behaving userCan hook implementations. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/91814 (owner: 10Dr0ptp4kt)
[19:42:40] <grrrit-wm>	 (03PS1) 10MaxSem: Use core's facilities for disabling TOC [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91985 
[19:43:36] <grrrit-wm>	 (03PS4) 10JGonera: Load notifications overlay dynamically [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91526 
[19:43:57] <grrrit-wm>	 (03PS2) 10MaxSem: Use core's facilities for disabling TOC [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91985 
[19:44:27] <jgonera>	 kaldari, I rebased dynamic notifications loading ^
[19:44:44] <kaldari>	 cool, I'll merge it then
[19:44:59] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Load notifications overlay dynamically [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91526 (owner: 10JGonera)
[19:45:16] <jgonera>	 is Jon in the office?
[19:49:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Load notifications overlay dynamically [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91526 (owner: 10JGonera)
[19:52:38] <grrrit-wm>	 (03CR) 10Jdlrobson: "MaxSem what is being deprecated?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen)
[19:53:25] <grrrit-wm>	 (03CR) 10MaxSem: "The API output structure. It's changing, this can break existing callers." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen)
[19:54:10] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Address wgMFMode FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91901 
[19:54:11] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Address FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91900 
[19:54:12] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Consolidate ajax loading code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91988 
[20:06:51] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: [C: 032] Simplified banner rendering and fixed empty partner URL [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90566 (owner: 10Yurik)
[20:06:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Simplified banner rendering and fixed empty partner URL [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90566 (owner: 10Yurik)
[20:07:16] <grrrit-wm>	 (03PS1) 10MaxSem: Standardise docs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91991 
[20:09:09] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] Native digits on Minerva skin notification count [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91832 (owner: 10Ebrahim)
[20:09:17] <grrrit-wm>	 (03PS3) 10Jdlrobson: Native digits on Minerva skin notification count [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91832 (owner: 10Ebrahim)
[20:09:24] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] i18n: Native digits on Minerva skin notification count [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91832 (owner: 10Ebrahim)
[20:10:33] <jgonera>	 jdlrobson, will you have time to merge or -1 https://gerrit.wikimedia.org/r/#/c/90686/ today?
[20:12:41] <grrrit-wm>	 (03PS7) 10JGonera: Add template partials support to View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90686 
[20:13:49] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: [C: 04-1] "Please review my comments in patchset 4." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90519 (owner: 10Yurik)
[20:16:12] <grrrit-wm>	 (03PS7) 10JGonera: Hygiene: Clean up overlays.less and pagelist.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90068 
[20:16:26] <jgonera>	 jdlrobson, this too ^
[20:21:18] <grrrit-wm>	 (03PS8) 10Robmoen: Hygiene: Eliminate api fixmes from PageApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 
[20:21:48] <grrrit-wm>	 (03CR) 10Robmoen: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen)
[20:28:05] <jdlrobson>	 jgonera: it's a hygiene day so i'm not planning on working on any of the stories or anything relating to them - just cleaning stuff up.
[20:28:34] <jdlrobson>	 guess he wasn't happy with that statement
[21:06:22] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Merge mobile.head and mobile.startup modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91999 
[21:06:23] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Kill navigation.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92000 
[21:06:24] <grrrit-wm>	 (03PS1) 10Jdlrobson: Show loader whilst lazy loading geonotahack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92001 
[21:06:25] <grrrit-wm>	 (03PS1) 10Jdlrobson: Beta desktop feature: Nearby pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92002 
[21:07:05] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] Hygiene: Eliminate api fixmes from PageApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen)
[21:11:15] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Standardise docs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91991 (owner: 10MaxSem)
[21:11:42] <grrrit-wm>	 (03PS2) 10Jdlrobson: Standardise docs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91991 (owner: 10MaxSem)
[21:11:49] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Hygiene: Standardise docs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91991 (owner: 10MaxSem)
[21:12:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Standardise docs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91991 (owner: 10MaxSem)
[21:13:01] <grrrit-wm>	 (03PS8) 10Jdlrobson: Hygiene: Clean up overlays.less and pagelist.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90068 (owner: 10JGonera)
[21:27:50] <jgonera>	 jdlrobson, both patchsets that I want you to review are strictly related to code hygiene, your answer doesn't make any sense
[21:35:06] <tfinc>	 mhurd: did you talk to Quim about FOSDEM ?
[21:35:43] <mhurd>	 tfinc: just talked to him about gsoc mentoring. not fosdem yet but i will
[21:36:00] <tfinc>	 great
[21:36:14] <YuviPanda>	 mhurd: rope me in if you're thinking of apps stuff in FOSDEM
[21:36:45] <mhurd>	 YuviPanda: yes apps stuff for sure!
[21:37:14] <YuviPanda>	 mhurd: yeah, I could do apps stuff *or* vagrant *or* labs stuff, so need to pick
[21:38:12] <mhurd>	 YuviPanda: nice! i'm more silo'ed in apps
[21:48:59] <grrrit-wm>	 (03PS1) 10JGonera: Introduce OverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92012 
[21:51:15] <jgonera>	 kaldari, if you have a moment then could you possibly check and merge or -1 https://gerrit.wikimedia.org/r/#/c/90686/ and possibly https://gerrit.wikimedia.org/r/#/c/90068/ ? jdlrobson seems to be too busy with his own hygiene...
[21:52:18] <kaldari>	 sure, I'm trying to track down a weird AbuseFilter bug at the moment though
[21:53:26] <jgonera>	 sure, thanks
[22:11:42] <grrrit-wm>	 (03PS1) 10Jdlrobson: WIP: Basic QA tests for Nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92018 
[22:11:43] <grrrit-wm>	 (03PS1) 10Jdlrobson: WIP: QA Add basic nearby tests for Vector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92019 
[22:11:50] <grrrit-wm>	 (03Abandoned) 10Jdlrobson: [WIP] QA: Add basic tests for nearby desktop and mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/85138 (owner: 10Jdlrobson)
[22:12:14] <jcmish>	 got em jdlrobson 
[22:12:17] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-2] "Michelle is going to get these working" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92018 (owner: 10Jdlrobson)
[22:12:35] <jdlrobson>	 so jcmish those are what I want to achieve
[22:12:45] <jdlrobson>	 that would be an excellent starting point
[22:13:00] <jcmish>	 I forgot to ask about desktop
[22:13:09] <jcmish>	 so the tests do still work the same way just different vectors
[22:13:16] <jcmish>	 for desktop vs mobile yes?
[22:13:20] <jdlrobson>	 jcmish: so basically we need to be able to support going into desktop mode
[22:13:25] <jdlrobson>	 it's the same test
[22:13:29] <jdlrobson>	 just slight different environment
[22:13:33] <jcmish>	 gotcha
[22:13:47] <jdlrobson>	 i wrote the desktop test as simple as possible to show you how i imagine it might work
[22:14:07] <jcmish>	 yep it makes sense
[22:18:36] <greg-g>	 yo mobile-ites!
[22:18:43] <awjr>	 sup greg-g
[22:19:15] <greg-g>	 quick question: where should I link to in trello (I assume, or mingle? what do you use) to know what's planned/upcoming for deployments (yes, it'll be over kill, but just for me)
[22:19:52] <greg-g>	 I see this: </td>
[22:19:52] <greg-g>	 <td valign=top style="padding-left:1.25em; padding-right:2%; -moz-border-radius:5px; -webkit-border-radius:5px; background-color:#eaeaea; overflow:auto;">
[22:19:54] <awjr>	 greg-g: for mobile web i guess you could link to our story wall
[22:19:55] <greg-g>	 gah
[22:19:58] <greg-g>	 https://trello.com/b/XkdTvW0Z/mobile-app-sprint-17
[22:20:02] <greg-g>	 ah, where's that?
[22:20:06] <awjr>	 that's for apps
[22:20:16] <awjr>	 greg-g: http://tinyurl.com/m7mavjl
[22:21:38] <greg-g>	 awjr: so this wikipage wouldn't be as good, right? https://www.mediawiki.org/wiki/Mobile/Release_history
[22:21:54] <greg-g>	 awjr: gah, that's apps again
[22:21:56] <greg-g>	 my bad,
[22:22:02] <greg-g>	 really, I do know the distinction ;)
[22:22:14] <awjr>	 heh greg-g correct; (although that's both apps and web)
[22:22:44] <awjr>	 greg-g: the story wall will be most complete
[22:22:47] <greg-g>	 the mobile app team talks here, too, right?
[22:22:50] <awjr>	 yes
[22:23:02] <greg-g>	 the story wall is both?
[22:23:08] <greg-g>	 app/web?
[22:23:14] <awjr>	 the story wall is web only; the apps team uses trello
[22:23:20] * greg-g  sighs

[22:23:22] <greg-g>	 :)
[22:23:22] <awjr>	 but apps doesn't deploy to the cluster :)
[22:23:30] <greg-g>	 yeah, but I like knowing :)
[22:23:35] <awjr>	 totes
[22:23:43] <awjr>	 mhurd can probably give you the dirty details
[22:23:49] <greg-g>	 cuz, they could do somethign that affects the cluster (heavy search api whatever)
[22:23:56] <awjr>	 or YuviPanda
[22:24:02] <greg-g>	 YUVI!
[22:24:02] <awjr>	 brion too but he's not around atm
[22:24:18] <greg-g>	 he (yuvi) may be asleep now
[22:24:25] <YuviPanda>	 hmpf
[22:24:28] * YuviPanda  reads backlog

[22:24:37] <awjr>	 yuvi doesnt sleep greg-g
[22:24:40] <greg-g>	 YuviPanda: heya, link me to where I should look to see what's coming up in mobile apps land
[22:25:06] <YuviPanda>	 greg-g: https://trello.com/wikimediafoundation. we change 'boards' every sprint, so there's no static location
[22:25:17] <greg-g>	 :(
[22:25:29] <YuviPanda>	 greg-g: you can see the active ones from there
[22:26:02] <YuviPanda>	 greg-g: we update https://www.mediawiki.org/wiki/Mobile/Release_history#Apps too
[22:26:22] <YuviPanda>	 greg-g: if you want me, I can give you a headsup when we do something that might affect the cluster in any way
[22:26:35] <greg-g>	 YuviPanda: the wiki page is just historical though, no? I want upcoming
[22:26:45] <YuviPanda>	 greg-g: yeah, upcoming is Trello only for now
[22:26:48] <greg-g>	 k
[22:27:03] <greg-g>	 I want a window, not a telephone game ;)
[22:27:13] <YuviPanda>	 hehe
[22:27:17] <greg-g>	 'cuz I don't want to bother you unless needed, mostly
[22:27:20] <YuviPanda>	 greg-g: yeah
[22:27:41] <greg-g>	 sprint-17 is current, correct?
[22:27:44] <YuviPanda>	 greg-g: yup
[22:28:04] <YuviPanda>	 greg-g: it's *Commons* sprint 17, and we'll be switching over to Wikipedia Sprint 1 starting two weeks from now.
[22:28:37] <greg-g>	 huh, ok
[22:28:47] <greg-g>	 GAH!
[22:28:59] <YuviPanda>	 hmm?
[22:29:05] <greg-g>	 stupid mingle and it's stupid square brackets in it's urls breaking mediawiki parsing
[22:29:29] <YuviPanda>	 heh
[22:29:40] <YuviPanda>	 s/and it's stupid square brackets in it's urls breaking mediawiki parsing//
[22:29:58] <YuviPanda>	 greg-g: I'm heading to sleep in abut 5 mins, want anything else?
[22:30:07] <greg-g>	 YuviPanda: nope, go sleep
[22:30:19] <greg-g>	 YuviPanda: and yeah, thanks for fixing that for me ;)
[22:30:30] <YuviPanda>	 ok :)
[22:30:31] <YuviPanda>	 greg-g: I'll be in the office next week to try out your kinesis!
[22:30:35] <greg-g>	 yay!
[22:30:37] <greg-g>	 see you then!
[22:30:39] <YuviPanda>	 :D
[22:30:41] <YuviPanda>	 see you!
[22:30:44] <greg-g>	 g'night
[22:41:21] <greg-g>	 ok, for realz, how do you link to those urls in wikitext
[22:41:23] <greg-g>	 VE?
[22:41:25] <greg-g>	 lets see
[22:43:40] <greg-g>	 nope, VE doesn't like it either
[22:49:59] <mhurd>	 violetto: this shadowing issue it proving tricky :(
[22:50:07] <mhurd>	 *is*
[22:57:09] <grrrit-wm>	 (03PS1) 10Dr0ptp4kt: Don't show banners unless proxy is known to be zero-rated. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92027 
[23:01:05] <grrrit-wm>	 (03PS2) 10Dr0ptp4kt: Don't show banners unless proxy is known to be zero-rated. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92027 
[23:02:03] <grrrit-wm>	 (03PS3) 10Dr0ptp4kt: When proxied, don't show banners unless proxy is known to be zero-rated. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92027 
[23:05:06] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: "Un -2'ing to prepare for production change. This should be entered into production so that the cache doesn't get poisoned with improper ba" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/88264 (owner: 10Dr0ptp4kt)
[23:07:39] <mhurd>	 violetto: i'm going to have to come back to the login page changes - that weird shadowing w text boxes needs more time than i have today
[23:15:53] <grrrit-wm>	 (03PS3) 10Dr0ptp4kt: Vary the cache based upon source proxy. See change 88261. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/88264 
[23:23:49] <grrrit-wm>	 (03PS4) 10Dr0ptp4kt: Vary the cache based upon source proxy. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/88264 
[23:25:42] <grrrit-wm>	 (03PS3) 10Jdlrobson: Use core's facilities for disabling TOC [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91985 (owner: 10MaxSem)
[23:25:50] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Upstream: Use core's facilities for disabling TOC [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91985 (owner: 10MaxSem)
[23:26:17] <violetto>	 mhurd: what about just a light grey box around the fields?
[23:26:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: Upstream: Use core's facilities for disabling TOC [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91985 (owner: 10MaxSem)
[23:27:56] <grrrit-wm>	 (03PS8) 10JGonera: Add template partials support to View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90686 
[23:28:35] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] i18n: Native digits on Minerva skin notification count [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91832 (owner: 10Ebrahim)
[23:29:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: i18n: Native digits on Minerva skin notification count [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91832 (owner: 10Ebrahim)
[23:30:33] <grrrit-wm>	 (03PS2) 10JGonera: [WIP] Introduce OverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92012 
[23:30:34] <grrrit-wm>	 (03PS1) 10JGonera: [WIP] Separate stable and beta upload overlay code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92031 
[23:31:19] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-2] "WIP" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92012 (owner: 10JGonera)
[23:31:31] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-2] "WIP" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92031 (owner: 10JGonera)
[23:41:08] <grrrit-wm>	 (03PS4) 10Dr0ptp4kt: When proxied, don't show banners unless proxy is known to be zero-rated. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92027 
[23:44:03] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] "(7 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92000 (owner: 10Jdlrobson)
[23:44:40] <grrrit-wm>	 (03PS1) 10MaxSem: WIP: Tablet detection support [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92036 
[23:45:17] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Tablet detection support [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92036 (owner: 10MaxSem)
[23:45:19] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] "Not sure about that. One was loading at the top, the other one at the bottom, wasn't it?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91999 (owner: 10Jdlrobson)
[23:46:55] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91988 (owner: 10Jdlrobson)
[23:48:42] <grrrit-wm>	 (03CR) 10JGonera: [C: 032] Hygiene: Address wgMFMode FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91901 (owner: 10Jdlrobson)
[23:49:43] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91900 (owner: 10Jdlrobson)
[23:50:34] <grrrit-wm>	 (03CR) 10JGonera: [C: 032] Show loader whilst lazy loading geonotahack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92001 (owner: 10Jdlrobson)