[06:27:38] <grrrit-wm>	 (03PS1) 10Yurik: Another debug output for ESI beta testing [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92269 
[06:28:40] <grrrit-wm>	 (03CR) 10Yurik: [C: 032] Another debug output for ESI beta testing [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92269 (owner: 10Yurik)
[06:28:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Another debug output for ESI beta testing [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92269 (owner: 10Yurik)
[08:57:56] <grrrit-wm>	 (03PS1) 10Yurik: Another debugging checkin for beta cluster [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92274 
[08:58:29] <grrrit-wm>	 (03CR) 10Yurik: [C: 032] Another debugging checkin for beta cluster [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92274 (owner: 10Yurik)
[08:58:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Another debugging checkin for beta cluster [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92274 (owner: 10Yurik)
[11:14:16] <grrrit-wm>	 (03PS1) 10Brion VIBBER: README.md [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/92290 
[11:14:43] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] README.md [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/92290 (owner: 10Brion VIBBER)
[11:17:00] <grrrit-wm>	 (03PS1) 10Brion VIBBER: fix links in readme [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/92291 
[11:17:10] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] fix links in readme [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/92291 (owner: 10Brion VIBBER)
[11:31:44] <grrrit-wm>	 (03PS1) 10Brion VIBBER: rm -rf 'All rights reserved' :D [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/92294 
[11:31:56] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] rm -rf 'All rights reserved' :D [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/92294 (owner: 10Brion VIBBER)
[14:24:04] <grrrit-wm>	 (03PS1) 10Brion VIBBER: Throw in a quick UI demo in the app stub [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/92309 
[14:24:20] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] Throw in a quick UI demo in the app stub [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/92309 (owner: 10Brion VIBBER)
[16:48:44] <grrrit-wm>	 (03PS2) 10MaxSem: Deprecate $wgMFForceSecureLogin in favor of core setting [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80324 
[16:49:07] <grrrit-wm>	 (03CR) 10MaxSem: "Can be merged now." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80324 (owner: 10MaxSem)
[17:16:45] <brion>	 tfinc: where did that agenda get sent? can't find it on the calendar link
[17:17:20] <YuviPanda>	 jgonera: I could hardly recognize you with the beard
[17:17:32] <brion>	 ah i found it
[17:18:10] <brion>	 lemme paste link on the invite 
[17:18:20] <awjr>	 kaldari: can you mail out your travel dates for india?
[17:18:28] <kaldari>	 sure
[17:18:32] <awjr>	 ty :D
[17:20:01] <jgonera>	 YuviPanda, I'm a man of many faces
[17:20:32] <YuviPanda>	 jgonera: I'll take note :D
[17:20:45] <jdlrobson>	 kaity|away: can you add the latest profile mockups to https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1312 ?
[17:21:19] <MaxSem>	 dr0ptp4kt, what is this API used for? https://gerrit.wikimedia.org/r/#/c/88264/4/includes/ApiZeroConfig.php
[17:27:22] <dr0ptp4kt>	 MaxSem, two things: (1) netmapper's polling of X-CS-to-IP addresses, (2) for W0-specific JavaScript to obtain configuration information on page load. the delta in 88264 for ApiZeroConfig.php to add extra variance is to account for the notion that a configuration object will be different depending on whether it's mdot vs. zerodot, as well as whether it went through a proxy.
[17:28:02] <MaxSem>	 eh, so you're making on API request per W0 pageview?
[17:37:02] <MaxSem>	 dr0ptp4kt, so you're making one API request per W0 pageview?
[17:39:55] <tfinc>	 awjr: did you have a chance to take a look at day 1 of MVP planning ?
[17:40:25] <awjr>	 tfinc: on the google doc?
[17:40:46] <awjr>	 i haven't yet - but im looking now
[17:41:55] <tfinc>	 awjr: yes
[17:42:02] <tfinc>	 the one i shared with you
[17:42:04] <tfinc>	 on Sunday
[17:42:21] <tfinc>	 it kicks off in 20min so no drastic changes 
[17:43:36] <awjr>	 tfinc is slide 17 out of order?
[17:44:26] <tfinc>	 no, i meant to put it there. it was bizarre for me to see brainstorm after brainstorming the roles
[17:44:33] <awjr>	 makes sense
[17:44:36] <awjr>	 glad you kept slide 41
[17:44:46] <awjr>	 tfinc looks good
[17:44:52] <tfinc>	 slide 41 is whats its all about 
[17:44:53] <tfinc>	 its the magic
[17:44:55] <tfinc>	 :D
[17:45:13] <awjr>	 tfinc: i didnt get an email saying the doc was shared with me :(
[17:45:17] <tfinc>	 i re-used a lot of our slides and updated mingle -> trello 
[17:45:21] <awjr>	 otherwise i woulda taken a look yesterday
[17:45:22] <tfinc>	 shame on goole
[17:45:35] <tfinc>	 google*
[17:45:44] <marktraceur>	 jdlrobson: Yo, I've bugged a bunch of people to get your extension reviewed, please reply-all if you want to clarify something about it, but if it's a straightforward review then the wheels are in motion
[17:45:53] <awjr>	 but overall looks good tfinc :D
[17:46:01] <tfinc>	 awjr: thanks for the sanity check
[17:46:14] <awjr>	 np im excited to hear how it goes
[17:46:25] <jdlrobson>	 marktraceur: thanks. where is this email? I can't see it in my mail box :)
[17:46:26] <marktraceur>	 And ideally everything will come to a head in three days
[17:46:33] <marktraceur>	 jdlrobson: Sent to jrobson@wikimedia.org
[17:46:41] <jdlrobson>	 marktraceur: what is the subject?
[17:46:59] <marktraceur>	 Sec
[17:47:33] <marktraceur>	 jdlrobson: "Deploy review for three extensions"
[17:47:58] <jdlrobson>	 marktraceur: i don't seem to have that mail… o_O
[17:51:05] <dr0ptp4kt>	 MaxSem, sorry for delay. once the change is in production, on first page load of a w0-scoped request, the api will be accessed. additional api requests are bound by the 900 second expiration on each varied response.
[17:51:27] <MaxSem>	 mmm, I don't like this
[17:51:57] <MaxSem>	 can it be embedded into page HTML using ESI instead?
[17:55:46] <dr0ptp4kt>	 MaxSem, mind opening a thread on mobile-l so that we can discuss there? i'm going to be in that app meeting today and tomorrow. regarding esi, it's conceivable it could be done there as a page dom element, yes, it's possible perhaps in a future state.
[17:57:10] <marktraceur>	 jdlrobson: That's weird
[17:57:26] <jdlrobson>	 marktraceur: very confused.. 
[17:57:30] <jdlrobson>	 can you cc me again?
[17:57:37] <marktraceur>	 I can try
[17:57:42] <marktraceur>	 jdlrobson: How are you looking for it?
[17:57:52] <jdlrobson>	 just in my gmail..
[17:58:05] <jdlrobson>	 ahh got it now marktraceur 
[17:58:08] <marktraceur>	 jdlrobson: Fabrice CC'd you on his reply there
[17:58:08] <jdlrobson>	 some sort of delay
[18:25:05] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Hygiene: Clean up overlays.less and pagelist.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90068 (owner: 10JGonera)
[18:26:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Clean up overlays.less and pagelist.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90068 (owner: 10JGonera)
[18:26:45] <grrrit-wm>	 (03PS1) 10Jdlrobson: Regression: Fix Geonotahack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92349 
[18:27:31] <jgonera>	 be back in 30 min, going to the office
[18:33:17] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90686 (owner: 10JGonera)
[18:33:44] <jdlrobson>	 kaldari: https://gerrit.wikimedia.org/r/92349 i broke geonotahack care to fix?
[18:35:17] <grrrit-wm>	 (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91900 (owner: 10Jdlrobson)
[18:36:31] * awjr  grumbles

[18:36:37] <awjr>	 anyone else having problems with mingle?
[18:45:58] <awjr>	 http://support.thoughtworks.com/entries/22905975-Unplanned-Mingle-downtime-on-October-28-2013
[18:51:02] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Kill navigation.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92000 
[18:51:09] <grrrit-wm>	 (03CR) 10Jdlrobson: "(5 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92000 (owner: 10Jdlrobson)
[18:52:57] <grrrit-wm>	 (03PS4) 10Jdlrobson: Hygiene: Kill navigation.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92000 
[19:05:20] <jdlrobson>	 MaxSem: https://gerrit.wikimedia.org/r/89283
[19:12:00] <grrrit-wm>	 (03CR) 10JGonera: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90686 (owner: 10JGonera)
[19:14:19] <grrrit-wm>	 (03CR) 10MaxSem: [C: 04-1] "Some styling problems:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89283 (owner: 10Jdlrobson)
[19:17:51] <grrrit-wm>	 (03PS2) 10Jdlrobson: Regression: Fix Geonotahack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92349 
[19:17:52] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Consolidate ajax loading code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91988 
[19:17:53] <grrrit-wm>	 (03PS4) 10Jdlrobson: Hygiene: Address FIXME in PagePreviewOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91900 
[19:19:45] <grrrit-wm>	 (03CR) 10JGonera: [C: 032] Regression: Fix Geonotahack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92349 (owner: 10Jdlrobson)
[19:22:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Regression: Fix Geonotahack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92349 (owner: 10Jdlrobson)
[19:35:58] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Separate overlay code from mobile.stable.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92362 
[19:36:29] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Separate overlay code from mobile.stable.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92362 
[19:37:37] <grrrit-wm>	 (03PS9) 10JGonera: Add template partials support to View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90686 
[19:38:12] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-2] "Fundamentally this patch was about grouping our modules logically. It seems the only reason we have this code is for navigation.js which s" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91999 (owner: 10Jdlrobson)
[19:39:05] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Add template partials support to View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90686 (owner: 10JGonera)
[19:39:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add template partials support to View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90686 (owner: 10JGonera)
[19:56:19] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Separate overlay code from mobile.stable.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92362 
[19:56:20] <grrrit-wm>	 (03PS3) 10Jdlrobson: Beta desktop feature: Nearby pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92002 
[19:59:20] <marktraceur>	 jdlrobson: Did kaity|away do the typography logo also, or just the VE ones?
[19:59:49] <marktraceur>	 (I ask so I know who to credit when I upload to Commons)
[20:00:39] <marktraceur>	 Or I could just ask kaity herself I guess
[20:01:23] <kaity>	 marktraceur: what was the question?
[20:01:42] <marktraceur>	 kaity: Did you do the typography BetaFeatures logo for jdlrobson, or was it someone else?
[20:01:48] <marktraceur>	 It looks like the same style as the VE logos
[20:02:21] <kaity>	 yes i did
[20:02:56] <marktraceur>	 'kay
[20:03:13] <marktraceur>	 kaity: Thanks very much, you'll be appropriately credited on the Commons pages. :)
[20:03:25] <kaity>	 oh ok cool!
[20:03:33] <kaity>	 I thought there was a problem with it
[20:04:12] <marktraceur>	 No no
[20:04:14] <marktraceur>	 Looks great
[20:04:28] <marktraceur>	 Just needed to avoid allegations of copyvio
[20:21:57] <kenanwang>	 awjr: hey I'm in the planning meeting for the native app
[20:22:13] <kenanwang>	 I'm trying to close out any cycles before the sprint kickoff
[20:22:24] <kenanwang>	 not sure if I'll be able to make the kick off
[20:28:01] <awjr>	 kenanwang: there are stories in 'in analysis' for the upcoming iteration that do not appear ready to go and still have not been estimated. we won't be able to get through them without you.
[20:28:19] <kenanwang>	 looking now
[20:28:45] <awjr>	 kenanwang: even if the acceptance criteria is finalized for those stories, we still need you there for estimation as the team may have questions for you
[20:30:33] <awjr>	 kenanwang: so if you can't make it, we either need to reschedule the kickoff or kick off the sprint with what's currently in 'ready for development'
[20:31:00] <grrrit-wm>	 (03PS2) 10JGonera: [WIP] Separate stable and beta upload overlay code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92031 
[20:31:01] <grrrit-wm>	 (03PS3) 10JGonera: [WIP] Introduce OverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92012 
[20:31:45] <grrrit-wm>	 (03CR) 10Kaldari: [C: 031] "Does this have any core dependencies that need to be deployed first or is it safe to merge?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80324 (owner: 10MaxSem)
[20:32:15] <grrrit-wm>	 (03CR) 10MaxSem: "It's safe, yes:)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80324 (owner: 10MaxSem)
[20:34:57] <awjr>	 kenanwang: let me know asap one way or the other; we can't have the mtg without you.
[20:35:53] <grrrit-wm>	 (03CR) 10Yurik: [C: 032] Vary the cache based upon source proxy. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/88264 (owner: 10Dr0ptp4kt)
[20:39:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Vary the cache based upon source proxy. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/88264 (owner: 10Dr0ptp4kt)
[20:40:21] <grrrit-wm>	 (03CR) 10Yurik: [C: 04-1] "You want to flood zero log with ALL visits from that carrier?" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92038 (owner: 10Dr0ptp4kt)
[20:44:15] <kenanwang>	 awjr: could we move 1 hour back?
[20:45:43] <kenanwang>	 we're in the middle of a conversation that I can't really jump out of now, I think that the remaining stories should be pretty good now but if you feel like I need to be at the meeting let's see if we can move back an hour?
[20:47:32] <awjr>	 kenanwang: there is no conference available an hour later and moving it back conflicts with other people's schedules
[20:48:03] <kenanwang>	 hmmm
[20:48:14] <kenanwang>	 maybe we can start the meeting at 230
[20:48:38] <awjr>	 dude it's way too last minute for a change like that
[20:50:03] <awjr>	 kenanwang: we'll do the sprint kickoff meeting as usual without you
[20:50:08] <awjr>	 and get through what we can
[20:50:41] <kenanwang>	 ok I'll let you know when things are ending here
[20:50:46] <kenanwang>	 and I'll be available on irc
[20:51:27] <grrrit-wm>	 (03CR) 10Kaldari: [C: 031] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92000 (owner: 10Jdlrobson)
[20:51:42] <kenanwang>	 sorry about the last minute crunch
[20:51:53] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Deprecate $wgMFForceSecureLogin in favor of core setting [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80324 (owner: 10MaxSem)
[20:52:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Deprecate $wgMFForceSecureLogin in favor of core setting [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/80324 (owner: 10MaxSem)
[21:39:52] <jdlrobson>	 https://en.m.wikipedia.org/wiki/Special:MobileDiff/579133189?mobileaction=beta
[21:57:05] <grrrit-wm>	 (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92000 (owner: 10Jdlrobson)
[21:59:54] <MaxSem>	 humm https://bugzilla.wikimedia.org/show_bug.cgi?id=19859
[22:01:04] <grrrit-wm>	 (03PS3) 10JGonera: [WIP] Separate stable and beta upload overlay code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92031 
[22:06:18] <kenanwang>	 awjr: hey how did things go?
[22:07:19] <awjr>	 kenanwang: things went OK; we got all the cards moved over to 'ready for development'. we took best guesses where necessary. 
[22:07:40] <awjr>	 kenanwang: please double check priority order of stuff in 'ready for development' on https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards?favorite_id=10053&view=Next+iteration+story+wall
[22:07:46] <kenanwang>	 ok cool thanks
[22:07:50] <kenanwang>	 K i'll check
[22:08:04] <kenanwang>	 also, I tried to move this bug into the iteration
[22:08:06] <kenanwang>	 https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1187
[22:08:17] <awjr>	 kenanwang: also, we need to figure out what to do with the stories currently in 'ready for development' on the regular story wall - should we move them into the new iteration or backlog them?
[22:08:18] <kenanwang>	 and it sorta looks like I did but it doesn't show up in the story wall
[22:08:31] <kenanwang>	 lots of bugs yes?
[22:09:05] <awjr>	 kenanwang: ok, i fixed that bug so it shows up now
[22:09:22] <awjr>	 kenanwang: and sorta, there are 4 bugs in 'ready for dev' on current storyw all
[22:09:23] <kenanwang>	 let's move them over
[22:09:25] <awjr>	 k
[22:09:36] <kenanwang>	 they look like important work
[22:10:05] <awjr>	 jcmish: will you be able to get 1254 and 1324 tested and run by kenanwang/accepted today?
[22:10:17] <awjr>	 and jcmishshould i keep your QA cards for the new iteration?
[22:10:41] <jcmish>	 Oh can you look at my gitlogs one?
[22:10:47] <jcmish>	 the others yes they should move over
[22:10:52] <awjr>	 yup
[22:11:23] <jcmish>	 and yep 1254 is the one Kenan will need to look at
[22:11:35] <jcmish>	 I accept the bugs and am almost finished with 1324
[22:17:11] <grrrit-wm>	 (03Abandoned) 10Jdlrobson: Don't mention 0 edits and 0 uploads on UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90930 (owner: 10MaxSem)
[22:30:11] <kaldari>	 For some reason I can't get selenium to run on my local machine anymore. It just complains that it "Could not locate Gemfile". Any idea how to fix that?
[22:30:41] <awjr>	 jcmish: ^
[22:32:06] <kaldari>	 looks like the directory was changed
[22:32:31] <kaldari>	 you have to run from the browser dir now, instead of acceptance.
[22:33:29] <kaldari>	 Hmm, it looks like the server name is wrong now too :(
[22:33:50] <kaldari>	 it's trying to use http://127.0.0.1/w/index.phpMain_Page which is wrong on several counts
[22:38:17] <kaldari>	 fixed it :)
[22:39:30] <kaldari>	 jcmich: I forget, how do you run just one test?
[22:48:26] <grrrit-wm>	 (03Abandoned) 10Jdlrobson: Group schemas together [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91515 (owner: 10Jdlrobson)
[22:49:24] <kaldari>	 anybody know?
[22:54:54] <kaldari>	 For some reason I'm no longer seeing the user/notifications icon at all in my local instance. Did we remove it or something?
[22:55:13] <kaldari>	 jgonera, jdlrobson: ^
[22:55:18] <kaldari>	 ah, nevermind
[22:55:19] <grrrit-wm>	 (03PS1) 10JGonera: Regression: Adjust thumbnail size in uploads overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92444 
[22:55:47] <jgonera>	 jdlrobson, https://gerrit.wikimedia.org/r/92444
[23:00:23] <kaldari>	 jcmish:  I forget, how do you run just one test?
[23:00:48] <jcmish>	 features/notification.feature
[23:01:16] <kaldari>	 bundle exec cucumber features/notification.feature ?
[23:01:38] <jcmish>	 right
[23:01:50] <kaldari>	 that runs all of them for me
[23:02:00] <kaldari>	 oh nevermind
[23:02:15] <kaldari>	 that works
[23:02:24] <jcmish>	 coolness
[23:02:55] <kaldari>	 jcmich: OK, so the notification selenium tests work for me, but they require that Echo is installed on that wiki
[23:03:05] <jcmish>	 ahhhhh
[23:03:12] <kaldari>	 jcmich: any idea how to make selenium skip a test if a condition isn't true?
[23:03:38] <jcmish>	 yeah what's not true?
[23:03:50] <jcmish>	 what condition? then I'll give you the syntax
[23:04:14] <kaldari>	 on(HomePage).notification_button_element.when_present ?
[23:05:49] <jcmish>	 if on(HomePage).notification_button_element.when_present != true end
[23:06:02] <kaldari>	 cool
[23:06:57] <kaldari>	 trying that now
[23:07:49] <kaldari>	 hmm, gives me a syntax error. I need to learn Ruby :)
[23:07:56] <kaldari>	 When /^I click on the notification icon$/ do
[23:07:57] <kaldari>	   if on(HomePage).notification_button_element.when_present != true end
[23:07:58] <kaldari>	   on(HomePage).notification_button_element.when_present.click
[23:07:59] <kaldari>	 end
[23:08:08] <kaldari>	 where the syntax error for that? any idea?
[23:09:49] <jcmish>	 wait a minute
[23:09:59] <jcmish>	 so if it's not there
[23:10:14] <jcmish>	 you want to do what? we need to put more syntax
[23:10:25] <kaldari>	 I think I got it...
[23:10:32] <kaldari>	 When /^I click on the notification icon$/ do
[23:10:33] <kaldari>	   if on(HomePage).notification_button_element.when_present
[23:10:34] <kaldari>	     on(HomePage).notification_button_element.when_present.click
[23:10:35] <kaldari>	   end
[23:10:36] <kaldari>	 end
[23:11:01] <jcmish>	 k right
[23:11:15] <jcmish>	 if it's present click otherwise it'll pass through
[23:12:43] <kaldari>	 hmm, that still fails if Echo is off :(
[23:13:05] <MaxSem>	 siiiiiiggghhhhhhhhhhhhhhhhhhhhh
[23:13:12] <kaldari>	 jcmish: do I need some explicit skip command?
[23:13:17] <MaxSem>	 our diff stuff sucks big time
[23:13:51] <jcmish>	 so if echo is off what happens? you don't get the overlay?
[23:14:02] <kaldari>	 I don't get the button
[23:14:15] <kaldari>	 that's where it fails...
[23:14:25] <kaldari>	 timed out after 5 seconds, waiting for {:id=>"secondary-button", :tag_name=>"a"} to become present
[23:15:05] <kaldari>	 it seems to be failing on the if statement itself
[23:15:21] <jcmish>	 no I mean logically
[23:15:37] <jcmish>	 if I didn't have echo installed I won't see that button?
[23:15:42] <jcmish>	 in general
[23:15:43] <kaldari>	 correct
[23:16:44] <kaldari>	 lemme poke around a bit...
[23:17:40] <jcmish>	 kayo
[23:23:25] <kaldari>	 grr. No matter what I try it keeps failing on the element test
[23:23:27] <kaldari>	 timed out after 5 seconds, waiting for {:id=>"secondary-button", :tag_name=>"a"} to become present
[23:24:04] <jcmish>	 so that should be there
[23:24:10] <jcmish>	 whether echo is there or not?
[23:25:29] <kaldari>	 no
[23:25:40] <kaldari>	 the button shouldn't show up if Echo is off
[23:25:57] <kaldari>	 but how do I check for the button without automatically failing the test?
[23:26:34] <kaldari>	 I need a DOM element equivalent of 'if page.text.include? "There is no user by the name "'
[23:26:36] <jcmish>	 so it changed from the archive link to this then yes?
[23:26:48] <kaldari>	 ?
[23:27:01] <kaldari>	 didn't parse that last sentence
[23:27:26] <jcmish>	 sorry this notifications-archive-link changed to secondary-button?
[23:27:35] <kaldari>	 no
[23:27:46] <kaldari>	 this is before it's even looking fo rthe archives link
[23:28:03] <kaldari>	 this is in the very first step
[23:28:32] <jcmish>	 so secondary button should always be available but it doesn't see the element correct?
[23:28:35] <kaldari>	 the first step is to click on the notifications icon, but if echo is off, there is no notifications icon
[23:28:54] <kaldari>	 the notiifcations icon is the 'secondary button'
[23:29:04] <kaldari>	 it should not be there if echo is off
[23:29:13] <kaldari>	 but it should also not fail in that case
[23:29:16] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Regression: Adjust thumbnail size in uploads overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92444 (owner: 10JGonera)
[23:29:19] <jcmish>	 okay 
[23:29:27] <awjr>	 hmm mavericks seems to have broken my python :(
[23:29:32] <jcmish>	 so hold one sec and let me pull it down
[23:29:43] <jcmish>	 ohnos awjr maybe I'll wait!
[23:29:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: Regression: Adjust thumbnail size in uploads overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92444 (owner: 10JGonera)
[23:29:50] <jcmish>	 I kinda need python 
[23:30:02] <jcmish>	 kaldari: let me pull it down and see what's happening
[23:30:04] <jcmish>	 give me one sec
[23:30:10] <kaldari>	 NP
[23:30:19] <awjr>	 jcmish: yeah im trying to figure out what exactly went sideways
[23:31:57] <awjr>	 meh jcmish it appears that python packages i had installed previously are missing or busted
[23:32:05] <awjr>	 but reinstalling them seems to work fine
[23:32:11] <jcmish>	 oh whew
[23:32:13] <jcmish>	 I started to worry 
[23:42:59] <jcmish>	 kaldari: I don't get a failure
[23:43:13] <jcmish>	 not at the notification only on the overlay
[23:43:31] <jcmish>	 what server are you pointing at?
[23:43:38] <kaldari>	 hmm, they both fail for me, but only if Echo is off
[23:43:45] <kaldari>	 otherwise they both pass
[23:44:10] <kaldari>	 jcmish: my local server
[23:44:18] <kaldari>	 are you on beta labs?
[23:44:21] <jcmish>	 yeah
[23:44:25] <jcmish>	 is echo on beta labs?
[23:44:29] <jcmish>	 and is it on test2?
[23:44:31] <kaldari>	 it should be
[23:44:56] <kaldari>	 yes, also on test2
[23:45:38] <kaldari>	 looks like echo isn't on beta labs
[23:46:04] <jcmish>	 k so that's why I'd get the failure at the overlay 
[23:46:25] <kaldari>	 they should both be failing on beta labs
[23:46:40] <kaldari>	 both scenarios that is
[23:46:58] <jcmish>	 check in your branch please and make me a reviewer
[23:47:44] <kaldari>	 well, my branch doesn't work any better I'm afraid :(
[23:48:02] <kaldari>	 still haven't figured out how to skip the test by testing for the element
[23:48:16] <jcmish>	 yeah no worries
[23:48:21] <jcmish>	 I just wanna see your code
[23:48:42] <jcmish>	 I'm guessing there's just some minor tweak but I need to see it since I  don't have the failures
[23:49:02] <jcmish>	 well I don't have "both" failures :)
[23:49:20] <jgonera>	 jdlrobson, I've just realized something... we should also implement AbuseFilter and captcha in photo uploads since they also modify pages...
[23:49:24] <jgonera>	 kenanwang, ^
[23:49:33] <jdlrobson>	 jgonera: mmm good point.
[23:50:17] <kaldari>	 jcmish: This was the last thing I was trying: http://pastebin.com/hGXJTuFp
[23:50:48] <kaldari>	 but I don't think that if statement is the correct way to do it
[23:50:54] <jcmish>	 nope that's not right
[23:51:04] <jcmish>	 one sec let me update it and then send it back after I verify
[23:51:18] <kenanwang>	 ahhh
[23:51:30] <kenanwang>	 yes jgonera let's capture that in a card
[23:52:02] <jgonera>	 kenanwang, can you start it and I add details later?
[23:52:20] <jcmish>	 so kaldari why are we changing When /^I click on the notification icon$/ do
[23:52:31] <jcmish>	 that should always work that's just clicking on the icon
[23:52:42] <kaldari>	 the icon doesn't exist
[23:52:57] <kaldari>	 at least not on Beta labs
[23:53:06] <jcmish>	 it does on betalabs
[23:53:19] <jcmish>	 that's why it's not failing for me it takes me to the notifications page
[23:53:31] <jcmish>	 by clicking on the the icon
[23:53:48] <kaldari>	 is http://deployment.wikimedia.beta.wmflabs.org/ the right server?
[23:54:08] <jcmish>	 nope en.m.wikipedia.beta.wmflabs.org
[23:54:12] <kaldari>	 oh :)
[23:54:28] <jcmish>	 what's deployment that's a new one for me but sounds like one to bookmark
[23:54:50] <jdlrobson>	 kenanwang: high priority for LD? https://bugzilla.wikimedia.org/show_bug.cgi?id=56154
[23:55:30] <kaldari>	 jcmish: http://en.wikipedia.beta.wmflabs.org loads for me, but not http://en.m.wikipedia.beta.wmflabs.org/
[23:56:09] <kaldari>	 jdlrobson: Can you load http://en.m.wikipedia.beta.wmflabs.org/ ?
[23:56:25] <kaldari>	 I get "The connection to the server was reset while the page was loading."
[23:57:15] <kenanwang>	 jdlrobson: ld?
[23:57:21] <jdlrobson>	 lightning deploy kenanwang 
[23:57:22] <jdlrobson>	 coming over
[23:57:25] <kenanwang>	 jgonera: I can probably wont' get to today
[23:57:32] <jcmish>	 https://en.m.wikipedia.org/wiki/Main_Page
[23:57:34] <jgonera>	 ok, no problem
[23:57:41] <jcmish>	 kaldari: 
[23:58:19] <kaldari>	 that works
[23:58:32] <jcmish>	 dangit typed the wrong one :D