[00:00:17] jdlrobson: can I get you the mockup for user profiles 1st thing tomorrow morning? [00:00:27] jcmish: hmm, looks like the overlay is loading. Does it not load for you? [00:00:43] You can tell based on whether the URL in the toolbar changes or not [00:01:03] ah what changes so I would know [00:01:23] and nope it's not that's where it fails on betalabs on the overlay [00:01:26] it will either go to the archives page (Special:Notifications) or it will load the overlay on the current page (without changing the URL in the toolbar) [00:01:57] just f everyone's i, i'm futzing with bingle so there mere be some weidrness [00:02:02] on the story wall [00:02:03] (03CR) 10Jdlrobson: "Juliusz is it possible for you to review this before BetaFeatures launch on Thursday." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92002 (owner: 10Jdlrobson) [00:02:16] or maybe through some JS error instead if something is broken [00:02:18] so if to goes to special notifications does that mean the overlay won't work? [00:02:31] correct, that's the fallback behavior [00:02:36] k gotcha [00:02:51] so on betalabs it goes to specialnotifications in the url [00:03:04] strange, it doesn't for me [00:03:11] which browser are you in? [00:03:15] firefox [00:03:54] jcmish: I'm seeing results for the survey so I think that the survey is fine [00:04:03] \o/ [00:04:04] weird, it's working for me in Firefox (loading the overlay when clikcing on the icon) [00:04:13] thanks kenanwang I shall move it on [00:04:37] kaldari: let me poke around and check all the browsers [00:04:48] and all the test systems and then ping you [00:04:58] maybe it's a very specific case [00:05:11] but now I understand the default behavior so that helps [00:05:26] I wasn't sure how it behaved with or without echo [00:05:57] jcmish: are you logging in as Selenium_user? [00:06:04] I was logging in as myself [00:06:46] I'm logging in as me [00:07:01] just to make sure and I get the same results as selenium_user [00:07:59] kaldari: is this notification stuff still in beta only? [00:08:04] or did it get moved to stable? [00:08:09] jcmish: The overlay, yes [00:08:25] k just wanted to make sure [00:10:38] jcmish: oops, I think I was testing on en.wiki, not beta labs [00:10:53] kaldari: can you revert your code changes then export MEDIAWIKI_URL='http://en.m.wikipedia.beta.wmflabs.org/wiki/' [00:11:18] then run bundle exec cucumber features/notification.feature [00:11:22] see if it'll fail [00:11:49] jcmich: I still can't get https://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page to work for me. It looks like it still has that security certificate problem [00:12:14] which would explain why the overlay doesn't load [00:13:09] looks like the same problem it's had for for the past couple weeks [00:13:31] They have more issues related to certificates over there [00:14:02] let me follow up but still do me a favor and instead of going straight there set MEDIAWIKI_URL [00:14:25] I'll check on the https certificate bugzilla ticket [00:14:36] sure, one sec... [00:14:40] thanks [00:15:16] shouldn't it be export MEDIAWIKI_URL='https://en.m.wikipedia.beta.wmflabs.org/wiki/' ? [00:15:54] no it'll correct I'm not sure why :D [00:16:08] doesn't correct for me, just fails [00:16:24] but https seems to load successfully [00:16:34] what's the new Selenium_user password? [00:16:55] on beta labs? [00:17:09] it's long and complicated let me grab it [00:17:16] oh, I guess I should have it use my account... [00:17:32] I would [00:19:15] jcmish: OK now I'm finally seeing exactly the same behavior you are [00:19:18] awjr: kenan gave the all clear [00:19:28] so I'm moving the last ticket [00:19:32] w00t thanks jcmish [00:19:32] woohoo kaldari! [00:19:55] jcmish: I'm 99% sure it's the security certificate problem though, since it wouldn't be able to load the overlay with a bogus cert. [00:20:04] gotcha [00:20:10] k I'll open up a follow up ticket [00:20:10] sicne it's an API request [00:20:19] test2 should have echo? [00:20:31] yes, I believe it does [00:21:30] yep test 2 works just fine [00:21:49] funny that this just broke on betalabs though [00:21:56] it's been running fine for a pretty good clip [00:22:19] and the certificate problem has been on and off for a while now [00:26:14] jcmish: Here's the bug https://bugzilla.wikimedia.org/show_bug.cgi?id=48501 [00:27:20] yep I was just sticking a comment in [00:27:23] thanks Kaldari [00:29:32] tfinc: Is there anything you can do on your end to light a fire under Ops? This bug has been open for more than 5 months: https://bugzilla.wikimedia.org/show_bug.cgi?id=48501 [00:29:52] kaldari: sure. mail me as im about to head out [00:30:06] will do [00:30:56] awjr: can I eavesdrop on the scrum of scrums? [00:31:04] of course jcmish [00:31:12] event details are on the engineering calendar [00:31:17] :D k I'm intrigued [00:32:34] (03CR) 10Jdlrobson: "I will investigate the no link issue. In terms of your other requests I believe these can be fixed in a second iteration. Our design team " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89283 (owner: 10Jdlrobson) [00:43:38] (03PS1) 10Kaldari: Updating some Selenium documentation for MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92470 [00:44:54] jcmish: thanks for walking me through getting all the selenium stuff worked out [00:45:10] totally no worries Kaldari [00:45:16] and I'll get the info updated tonight [00:45:19] jcmich: I can't believe ops still hasn't gotten new certs yet :( [00:45:51] jcmish: and if you figure out how to skip a test based on a DOM element being present or not, let me know [00:45:52] MONTHS kaldari [00:45:55] makes me said [00:45:57] *sad [00:46:02] and yeah I know how to fix it [00:46:09] cool [00:46:15] I'm gonna fix that tonight too and have you code review it tomorrow for me [00:46:23] sounds good to me :) [00:46:34] sorry, I suck at Ruby [00:46:45] bah [00:46:54] when you see it you'll say ohhhhh [00:46:59] whenever I have some free time, I'm going to try to learn some [00:47:00] that's simple [00:47:08] it's basic if else really [00:47:13] simple is good :) [00:47:23] hehe I'm a simple person [00:47:37] I coded in Java for a long time so I embrace simple now ;-) [00:48:55] I need to get my son practicing piano [00:49:00] I'll be back in a bit [01:16:22] (03PS4) 10Jdlrobson: Beta desktop feature: Nearby pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92002 [01:27:46] (03PS12) 10Jdlrobson: Beta: Add Special:History [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89283 [01:31:43] (03PS1) 10Jdlrobson: Define wgMFMode as stable for desktop Nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92474 [03:22:44] (03PS1) 10Yuvipanda: Create wrapper exception to wrap around JSONException [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/92477 [03:29:24] (03PS2) 10Yuvipanda: Create wrapper exception to wrap around JSONException [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/92477 [03:29:25] (03PS1) 10Yuvipanda: Wrap IOException when it happens with ApiException [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/92478 [06:25:12] (03PS1) 10Mgrover: Add conditional for notification overlay to display or not based on whether echo is available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92488 [08:18:46] mlitn: you up? [15:30:24] man when's that nexus 5 coming out [15:30:31] and what are its exact dimensions... [15:31:38] about 0.5mm wider, 4mm taller, .5mm thinner, 5g lighter [15:31:42] ok that's not too huge [15:31:50] though i'm already annoyed at how large my nexus4 is [15:32:04] Get a curved screen [15:32:10] And use it as a see-saw for your fingers [15:32:15] hah [15:32:39] I think there was some Nexus 10 revamp leak earlier [15:32:45] ooh [15:33:31] Also! Did you see the suggestion that whatever Google is building in the bay could be a Google Glass shop? [15:33:44] haha [15:34:15] http://www.theverge.com/2013/10/27/5035120/giant-floating-object-in-san-francisco-bay-could-be-a-google-glass-store [15:34:21] rumor also says they'll be doing an invite system for the new version of glass [15:34:26] maybe we can get a couple invites :D [15:35:03] i already have enough trouble not getting hit by buses with my smartphones [15:35:15] if i get glass, i expect to be flattened by muni within days [15:35:30] maybe i'll just stay indoors [15:48:42] *grumble grumble* apparently to finish activating this new SIM I need to find the activation card that came with the phone [15:48:57] guess i'll do that at the office then since i left the box there :P [15:49:08] * brion wants some LTE goodness [15:49:37] or i'll just leave the iPhone on wifi and wait until nexus5 for let ;) [15:49:38] *lte [17:02:20] o_0 [17:02:27] SMS is being integrated into hanhouts [17:02:29] *hangouts [17:26:41] awjr: scrum of scrums room has been invaded by flyingclimber and co [17:26:49] flyingclimber: you disbanding? [17:26:55] hmm ? [17:26:58] as it looks like you're all deep in the middle of something [17:27:02] tfinc: you have our room [17:27:15] i have nothing on my calendar for right now [17:27:23] my next meeting starts @ 11:30 [17:27:29] and i'm in the analytics quarterly review [17:27:36] in r37 [17:27:43] tfinc: it looks like that room was double booked [17:27:50] jdlrobson: which room ? [17:27:54] the scrum of scrums is meant to be in r37 now [17:28:09] hoping awjr will surface [17:28:16] jdlrobson: i am here [17:28:18] jdlrobson: the Analytics quarterly review has the room [17:28:30] awjr: so it looks like we need to move the room for the scrum of scrums - looks like it got double booked [17:28:41] @_@ [17:28:43] shit [17:28:51] poor orphan scrum^2 [17:29:22] jdlrobson: no rooms available [17:29:23] fuck [17:29:28] awjr: vibe and pau seem to be in r31 [17:29:29] jdlrobson: join from your laptop, i guess [17:29:41] yeah, 'weekly design review' [17:30:32] how annoyingz [17:31:59] awjr: seeing a lot of confused faces outside r37 [17:32:09] tfinc see email [17:32:13] room got double booked, no one told us [17:33:23] tfinc join form laptop; no rooms available (at least judging by google calendar) [17:34:57] awjr: yup, i see the note. i'm attending the analytics quarterly review so i wont be joining today. was just relaying to make sure people weren't lost. [17:35:06] wonder how you guys lost the room [17:36:10] (03CR) 10Kaldari: [C: 04-1] "If Echo isn't on, this will fail regardless since the first step fails. When Echo is off, there is no notifications icon to click on." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92488 (owner: 10Mgrover) [17:48:20] chrismcmahon: see hangout chat [17:52:28] chrismcmahon: i'd suggest raising a bug about the echo bug [17:52:33] that will get it attention [17:52:39] jdlrobson: I think the missing feature is that -1 above just now [17:52:48] ahh ;-) [17:53:44] chrismcmahon: apparently this is due to invalid https certificates on beta.. [17:54:30] chrismcmahon: can you summarize for kaldari so he is up to speed? [17:55:47] jdlrobson: what I know about SSL for beta labs now: https://bugzilla.wikimedia.org/show_bug.cgi?id=48501#c46 [17:56:02] chrismcmahon: the -1 above is unrelated to the tests currently failing [18:03:18] awjr: just found out about this bug - seems pretty major - https://bugzilla.wikimedia.org/show_bug.cgi?id=48501 [18:03:31] i've added michelle as well as she didn't seem to be in the loop but this is why our QA tests are failing [18:03:32] I emailed tfinc about it yesterday [18:03:33] * awjr looks [18:03:42] yup. i saw it [18:03:45] i've added it to scrum of scrums but alas a little late [18:03:46] since I've been poking Ops about it for 2 weeks with no luck [18:03:55] and other have been poking them about it for months [18:04:07] let me know what happens at the scrum of scrums with it [18:04:31] tfinc: scrum of scrums is over - i only found out about it during but too late to raise :) [18:04:36] thanks jdlrobson - feel free to mail out about the issue since it didnt get brought up during SoS; this has beena longstanding issue tho [18:04:52] awjr: i could do with some more background from Ryan and Michelle - e.g. what is failing [18:05:01] but no css/js is loading on https [18:05:19] jdlrobson: mail wikitech-l about it; conversation there might push this forward faster [18:05:30] if someone could summarize on mobile-tech to me i can mail wikitech [18:05:35] awjr: I believe this has already been discussed there [18:05:39] but I could be wrong [18:05:44] * jdlrobson waves at Ryan_Lane  [18:05:56] Ryan_Lane: we're just talking about the https problems on beta labs [18:06:21] kaldari: maybe you're right; this has been going on for a long time and i can't remember where iv'e seen discussion about it… worth dbl checking [18:06:29] where is michelle? [18:07:21] okay, done with diffs spike... [18:07:27] kaldari: if resources were loaded from http would that make a difference? [18:07:37] MaxSem: that was fast :) [18:07:45] just pinged her on gchat jdlrobson [18:07:45] see my email [18:07:59] but she's marked away [18:09:08] jdlrobson: Yeah, if we loaded resources from HTTP that would probably fix the issue, but that doesn't seem like a realistic solution due to the security warnings it would cause. [18:09:25] actually kaldari jdlrobson i just quickly searched through wikitech-l posts and i dont see anything explicitly about it [18:10:00] kaldari: mixed content warnings often dont even get surfaced on mobile devices [18:10:08] just silent failure [18:10:21] awjr: oh, that's even worse :P [18:10:26] yep. someone needs to take ownership of that bug [18:10:33] it's not blocked on ops [18:10:36] it never has been [18:10:40] what's it blocked on Ryan_Lane? [18:10:54] the list of steps in comment #46 on the bug [18:10:59] anyone with projectadmin can do it [18:11:08] ops will buy the certs, but that takes relatively no time [18:11:10] like a couple days [18:11:19] the other steps are necessary for us to be willing to install it [18:11:35] Ryan_Lane: who manages betalabs atm, QA? [18:11:40] also, if your code doesn't work with both http and https it's broken, but as I mentioned, that's a different story [18:11:43] platform/qa [18:12:32] jdlrobson: what is the test that's failing on betalabs? [18:14:02] ok, thanks Ryan_Lane - when it's time to buy the SSL certs, RT ticket? [18:14:17] Ryan_Lane: this may be a dumb question, but what is the name of the Beta Labs project? [18:14:26] deployment-prep [18:14:33] ah yeah! [18:15:16] OK, I'll go ahead and take care of removing the volunteers then [18:15:35] sudo needs to be cleaned up too [18:16:08] Ryan_Lane: who can do that? [18:16:17] anyone with projectadmin [18:17:17] I'm not sure I understand what 'cleaning up sudo' means. [18:17:37] kaldari: "Clean up sudo policies to disallow root on varnish systems " [18:17:51] yeah, that's Greek to me :) [18:18:07] kaldari: we should coordinate with platform or qa on this; probably greg-g or chrismcmalunch [18:18:07] projectadmin needs to be removed from volunteers, not membership [18:18:14] ? [18:18:21] oh, I should be reading backlog here [18:18:30] greg-g: we're talking about getting https://bugzilla.wikimedia.org/show_bug.cgi?id=48501 resolved finally [18:18:41] in particular, addressing the steps in https://bugzilla.wikimedia.org/show_bug.cgi?id=48501#c46 [18:18:49] * aude notes i am not a volunteer :) [18:18:54] I mean that volunteers should still have access to the project, but they shouldn't have projectadmin permissions and they shouldn't be able to get root on the varnish systems [18:19:07] if anyone is not sure.... [18:19:12] awjr: yeah, was chatting with apergos in -operations about it, didn't realize it was also being talked about in here :) [18:19:22] ha [18:19:32] great minds. [18:20:09] Ryan_Lane: That makes sense. Personally, I have no idea how to accomplish that though. [18:20:33] the design of this system is specifically so that I don't have to do this stuff for people [18:20:36] awjr: where did you leave the planning poker cards in the office ? [18:20:53] okay, the volunteers with projectadmin are: Aude (WMDE staff, should have no probs with NDA), TheDJ and petrb [18:20:54] tfinc: I have some if you need them [18:21:00] kaldari: sure [18:21:08] "Manage Projects" [18:21:15] "Manage Sudo Policies" [18:21:34] petrb is actually an important labs person, removing access from him would suck:( [18:21:49] he has an NDA signed [18:21:53] wee [18:21:59] https://wikitech.wikimedia.org/wiki/Help:Sudo_Policies [18:22:05] is J still employed by us? [18:23:00] is Mdale considered staff? [18:23:01] who is J? [18:23:04] no clue [18:23:11] Ryan_Lane, Jan Gerber [18:23:27] kaldari: mdale was never staff [18:23:30] I have no idea on any of this stuff ;) [18:23:31] he has an @wmf.o email [18:23:35] I don't think Jan is still on contract [18:23:59] MaxSem: RobLA would know if he's still under contract. last time i checked he was not [18:24:07] but RobLA can tell you [18:24:19] okay, we need to finalize the list before shooting:) [18:24:46] tfinc: what exactly is his status? he's not really a 'volunteer' either, per my understanding [18:24:54] kaldari: mdale ? [18:24:57] yeah [18:25:28] he's an (and has always been) employee of kaltura [18:25:28] tfinc: er are they not in the drawer? [18:25:33] (the poker cards) [18:25:36] awjr: the agile drawer was empty [18:25:52] tfinc: yeah, but what does that translate to as far as server permissions? Do we have some kind of policy on that? [18:25:52] tfinc: the only other place i can think of is in my bag or on your desk [18:25:54] * awjr checks bag [18:26:15] kaldari: if he signed an NDA then he would have access [18:26:16] tfinc: i have my set of poker cards, there should be two more in the office somewhere [18:26:30] if i didn't put them back in the drawer or on our desk, i have no idea where they are [18:26:37] s/our/your [18:26:39] sure would be great if we had a canonical list of "who is currently covered by an up-to-date NDA" :/ [18:26:45] awjr: i have the deck from kaldari which looks just like the deck i used to have on my desk [18:26:51] so i'm sure they've wandered [18:27:02] argh [18:27:07] check jdlrobson's desk? [18:27:12] * aude steal them :) [18:27:15] just kidding [18:27:17] heh [18:27:32] i remember absent mindedly leaving a few things on jon's desk [18:29:45] OK, so we need to remove TheDJ, possibly J, and possibly Mdale, although I imagine Mdale has signed an NDA as well. [18:30:47] ^d just removed him [18:30:58] btw, let's bring this conversation back into -operations so everyone is on the same page [18:31:30] (03PS1) 10Jdlrobson: POC: Do section collapsing without wrapping [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92555 [18:31:30] where "him" == "mdale" [18:32:06] (03CR) 10Jdlrobson: [C: 04-2] "This is what is in my brain. Whether we can achieve section styling and toggling via this cleaner method is my question." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92555 (owner: 10Jdlrobson) [18:39:57] (03CR) 10jenkins-bot: [V: 04-1] POC: Do section collapsing without wrapping [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92555 (owner: 10Jdlrobson) [18:40:11] (03CR) 10Jdlrobson: "(6 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen) [18:40:17] (03PS2) 10Jdlrobson: Don't change address bar in QUnit in Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91537 [18:40:18] (03PS9) 10Jdlrobson: Hygiene: Eliminate api fixmes from PageApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen) [18:54:17] kaldari: are you okay to review https://gerrit.wikimedia.org/r/92474 and MaxSem can we lightning deploy that today? (cc awjr ) [18:54:37] (03CR) 10Jdlrobson: [C: 031] "Addresses Max's concerns." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89283 (owner: 10Jdlrobson) [18:54:43] Also MaxSem +2 hammer please? ^ [18:55:10] sure [18:56:35] jdlrobson, my version had styling for hidden content - why did you remove it? [18:57:11] MaxSem: as i stated we should get design input for this [18:57:26] it doesn't need to be perfect first time round [18:57:33] we're not even linking to it anywhere yet [18:57:37] also, // @todo: recent changes view [18:57:48] wtf is this?:) [18:57:54] kaldari, MaxSem if one of you can manage getting that change out today during LD (or our apparently still existing deployment slot), please respond to the email i just sent [18:58:03] i don't know looks like something you added? I don't use @todo notation..? [18:58:25] i think that can die [18:58:34] yeh that can die [18:59:22] I convert TODO: to @todo:. but the cvomment itself isn't mine;) [18:59:39] but MaxSem we are in a chicken and an egg situation - kenan doesn't want to create a story for it until he has the initial prototype and I asked the design team about how to style deleted users but again they want the initial prototype [19:00:04] MaxSem: as soon as I can show them something I promise to get that styling in place [19:00:13] and they need it in prod? [19:00:20] (03PS13) 10Jdlrobson: Beta: Add Special:History [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89283 [19:00:26] MaxSem: or beta labs [19:00:28] they just need real data [19:00:51] MaxSem: just trust :) [19:01:22] bzzt! [19:01:35] don't kill my momentum! [19:01:36] unknown identifier "trust" [19:03:10] (03PS1) 10Jdlrobson: Story 1283: Add infinite scroll to Special:Uploads in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92560 [19:04:21] (03CR) 10Jdlrobson: [C: 04-1] "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92470 (owner: 10Kaldari) [19:04:27] (03PS2) 10Jdlrobson: Updating some Selenium documentation for MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92470 (owner: 10Kaldari) [19:04:42] (03CR) 10Jdlrobson: [C: 04-1] "See PS1 I also renamed the commit to make it clearer it is about docs" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92470 (owner: 10Kaldari) [19:05:48] (03PS2) 10Jdlrobson: Hygiene: Simplify how make phpunit works in Makefile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91535 [19:06:20] MaxSem: who can verify https://gerrit.wikimedia.org/r/#/c/91202/ ? [19:06:39] (03PS14) 10MaxSem: Beta: Add Special:History [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89283 (owner: 10Jdlrobson) [19:06:49] also jgonera re you coming into the office today [19:06:49] anyone:P [19:06:58] MaxSem: how do i verify? [19:07:27] jdlrobson, I've contributed too much to the history PS to merge it myself, would love someone else to review [19:08:04] MaxSem: sure completely understand. hopefully awjr or kaldari could take a look [19:08:22] o_O [19:08:32] pfft, does this function exist? if so, it works:P [19:08:42] jdlrobson: https://gerrit.wikimedia.org/r/#/c/91202/? [19:08:58] awjr: yeh that too but was specifically talking about history [19:09:06] jdlrobson: https://gerrit.wikimedia.org/r/#/c/89283/? [19:09:12] awjr yeh both those ones [19:09:16] k [19:09:21] i can take a look [19:09:35] i can't see the wood from the trees in gerrit right now way too much stuff going on [19:09:56] * jdlrobson pings jgonera again [19:10:08] i havent been paying much attn to IRC this morning - anyone able to deploy the bugfix today? [19:10:31] mobile team gone awol apart from awjr and MaxSem :( [19:10:45] MaxSem: I assume you can deploy? [19:10:50] awjr, I surely can [19:10:54] I need jgonera or kaldari though to check it and merge [19:11:56] kk thanks MaxSem [19:12:17] jdlrobson, be right there [19:12:38] MaxSem: also I don't know if you saw - but I tried to explain what was in my head related to a new way to do section toggling / page formatting https://gerrit.wikimedia.org/r/92555 < long way to go though [19:12:39] thanks jgonera [19:12:45] jdlrobson: what's up [19:12:58] sorry I guess my irc wasn't actually online didn't realize it [19:14:01] jcmish: we were talking about the failing QA tests on beta labs - I was trying to understand the problem better. To summarize I think we are not blocked on ops to fix it so we may want to make a card for fixing bug https://bugzilla.wikimedia.org/show_bug.cgi?id=48501#c46 to resolve this issue (awjr is that correct) [19:14:26] jdlrobson, yeah I've seen it, haven't actually checked out how it performs in reality [19:14:42] ohhh [19:14:45] (03Abandoned) 10Jdlrobson: Hygiene: Merge mobile.head and mobile.startup modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91999 (owner: 10Jdlrobson) [19:14:53] really jdlrobson is this something we could handle? [19:15:41] jcmish: all explained in comment 46 (link above) [19:15:50] Supposedly not blocked on ops [19:17:11] sweet I'll write it up! damn no kenan... I'll send an email and see if it's okay for us to add this to the sprint jdlrobson and awjr [19:17:12] jdlrobson, jcmish yeah that's more or less correct. basically it sounds like it's up to platform/QA to finalize getting that issue resolved. i know greg has been carrying the conversation forward in the operations channel with apergos [19:17:42] jcmish: it may be something that greg-g is already pushing forward so there may not be much for us to do, but it sounds to me like something for platform/QA to champion [19:18:04] yep let me go eavesdrop [19:18:05] argggg no kenanwang [19:18:10] * jdlrobson gets grumpy [19:18:19] jdlrobson: is it ok if i wait to look at the history changeset til later this afternoon? [19:18:24] awjr: sure. [19:18:24] so I'll keep up with it [19:18:26] jdlrobson: i presume he is in the apps planning meetings [19:18:31] kk jdlrobson i'll be sure to get to it today [19:18:39] awjr: i was hoping it could go out on thursday as ken an wanted to work on it in next iteration [19:18:51] aight [19:18:51] thus it would be good to have a point of reference for designers and him [19:18:57] (even if on beta labs i guess) [19:19:02] (if that works again;)) [19:19:27] yeah, you can pawn this off to me (finishing up the ssl cert business on beta) [19:19:34] jcmish: ^ [19:19:55] and jdlrobson it looks like most of the big things are fixed in that patchset already, i trust if max is happy i'll be happy but i will scrutinize closely later [19:20:05] thanks awjr [19:20:11] * jdlrobson is grabbing lunch [19:24:50] (03PS2) 10Awjrichards: Collect mobileview cache hit statistics [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91202 (owner: 10MaxSem) [19:24:57] (03CR) 10Awjrichards: [C: 032] Collect mobileview API memcache hit statistics [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91202 (owner: 10MaxSem) [19:26:35] (03Merged) 10jenkins-bot: Collect mobileview API memcache hit statistics [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91202 (owner: 10MaxSem) [19:46:47] (03CR) 10Mgrover: "Which step in the feature fails? I'm able to run this against all the systems and they pass:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92488 (owner: 10Mgrover) [19:48:51] (03PS2) 10Jdlrobson: Add conditional for notification overlay to display or not based on whether echo is available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92488 (owner: 10Mgrover) [19:49:12] (03CR) 10Jdlrobson: [C: 04-1] "See Kaldari's -1 I simply amended the commit message which I felt could be clearer." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92488 (owner: 10Mgrover) [19:53:44] (03CR) 10Kaldari: [C: 04-1] "Mgrover: I believe all of those test servers have Echo installed. The step where it will fail is "When I click on the notification icon"." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92488 (owner: 10Mgrover) [19:54:48] hey guys and gals, we still need to merge https://gerrit.wikimedia.org/r/#/c/92474/ if we want to deploy it today;) [20:05:36] kaldari: I'm missing something so I thought that if echo is not installed then you go to the (Special:Notifications) [20:05:37] ? [20:06:11] No, if Echo isn't installed, there are no notifications at all, no special page, no icon. [20:06:22] AHHHH [20:06:30] got it [20:06:52] so if it's installed what makes it go to Special:Notifications vs [20:06:53] sorry, I wasn't clear about that [20:06:55] just the url? [20:07:01] with nothing after it? [20:07:05] totally no worries [20:07:13] kaldari: jgonera_ https://gerrit.wikimedia.org/r/92474 [20:07:59] jcmich: If you're in beta mode + the JS loads successfully then you get the overlay, otherwise, it takes you to the special page instead. [20:08:10] as a fallback [20:08:18] (03CR) 10JGonera: [C: 032] Define wgMFMode as stable for desktop Nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92474 (owner: 10Jdlrobson) [20:08:21] okay cool I'll make a change after I grab a bite [20:08:24] then have you review [20:08:28] MaxSem: feel free to deploy at will ^ [20:09:04] (03Merged) 10jenkins-bot: Define wgMFMode as stable for desktop Nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92474 (owner: 10Jdlrobson) [20:10:27] jcmish: put me on the review for that? I'm almost out of popcorn. [20:11:46] jdlrobson: jgonera_ beat me to +2ing it :) [20:25:24] (03CR) 10Dr0ptp4kt: "Ha! True, this would not be a good configuration for it. Resubmitting shortly." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92038 (owner: 10Dr0ptp4kt) [20:26:21] (03PS2) 10Dr0ptp4kt: Verify User-Agent versus source proxy for X-CS=502-16. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92038 [20:38:28] jdlrobson, gah - just noticed your poke:( [20:39:49] greg-g, we need to deploy a fix to total nearby failure on desktop - https://gerrit.wikimedia.org/r/92474 - when can we do this, LD or our ex window which happens to be right now? [20:40:21] MaxSem: go for it now [20:40:26] I forgot to delete your window this week :) [20:40:42] thanks greg-g:P [20:49:49] (03PS1) 10MaxSem: Define wgMFMode as stable for desktop Nearby [extensions/MobileFrontend] (wmf22) - 10https://gerrit.wikimedia.org/r/92575 [20:51:00] (03CR) 10MaxSem: [C: 032 V: 032] Define wgMFMode as stable for desktop Nearby [extensions/MobileFrontend] (wmf22) - 10https://gerrit.wikimedia.org/r/92575 (owner: 10MaxSem) [20:52:08] (03PS1) 10MaxSem: Define wgMFMode as stable for desktop Nearby [extensions/MobileFrontend] (wmf1) - 10https://gerrit.wikimedia.org/r/92576 [20:52:22] (03CR) 10MaxSem: [C: 032 V: 032] Define wgMFMode as stable for desktop Nearby [extensions/MobileFrontend] (wmf1) - 10https://gerrit.wikimedia.org/r/92576 (owner: 10MaxSem) [20:54:43] (03CR) 10JGonera: [C: 04-1] "(8 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92002 (owner: 10Jdlrobson) [20:55:07] kaldari, I think it would be good if you added your comments too ^ [21:00:16] (03CR) 10Yurik: [C: 04-1] "(1 comment)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92038 (owner: 10Dr0ptp4kt) [21:00:38] jdlrobson, the fix is live on testwiki:) [21:00:47] MaxSem: testing now :) [21:01:05] MaxSem: haha.. unable to test https://test.wikipedia.org/wiki/Special:Nearby [21:01:17] need Geodata.. :) [21:01:30] any geodata articles on test wiki? [21:01:55] there used to be [21:01:59] ...a couple:P [21:02:02] MaxSem: i can spoof my geolocation if you know of one [21:02:11] just let me know the article name that has geo data [21:03:29] MaxSem, any comments on my comment at https://gerrit.wikimedia.org/r/#/c/91532/8/includes/api/ApiMobileView.php ? [21:04:30] jdlrobson, San_Francisco [21:04:35] Samuel_N._Patterson_House [21:04:41] Øresund_Bridge [21:04:46] has anyone seen adam? [21:04:54] Coollsjfsjlfs [21:05:05] yurik_, he was there today [21:05:15] hmm... missing in action [21:05:16] as in on IRC [21:05:17] (03PS10) 10JGonera: Hygiene: Eliminate api fixmes from PageApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen) [21:06:22] MaxSem: I added geo data here .. https://test.wikipedia.org/wiki/Page_which_has_geodata [21:06:43] Solr index isn't instantly updated [21:08:01] (03CR) 10JGonera: [C: 031] Hygiene: Eliminate api fixmes from PageApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen) [21:09:26] MaxSem: for https://test.wikipedia.org/w/api.php?format=json&action=query&colimit=max&prop=pageimages%7Ccoordinates&pithumbsize=180&pilimit=50&generator=geosearch&ggscoord=37.7867886%7C-122.39953589999999&ggsradius=10000&ggsnamespace=0&ggslimit=50 i don't get any results.. [21:10:10] anyway MaxSem i don't see anything noticeably broken we may have to do it live [21:10:17] ok [21:10:28] (03CR) 10Kaldari: "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92002 (owner: 10Jdlrobson) [21:10:30] i can't test the actual problem unless i have results [21:10:34] (03CR) 10Kaldari: [C: 04-1] Beta desktop feature: Nearby pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92002 (owner: 10Jdlrobson) [21:10:35] (03CR) 10JGonera: [C: 04-1] "Why exactly are we removing mfe.suite.xml? It has a bunch of config settings which don't look like defaults. Do we really want to get rid " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91535 (owner: 10Jdlrobson) [21:11:49] jgonera: reviewed the desktop nearby [21:11:57] thx [21:12:53] (03CR) 10JGonera: Hygiene: Simplify how make phpunit works in Makefile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91535 (owner: 10Jdlrobson) [21:13:03] jdlrobson, should be live on enwiki [21:13:18] MaxSem: works [21:13:19] thanks! :) [21:15:03] okay, deployed everywhere [21:15:19] greg-g, we're done [21:16:20] sweet [21:16:48] (03CR) 10JGonera: [C: 032] Story 1283: Add infinite scroll to Special:Uploads in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92560 (owner: 10Jdlrobson) [21:17:36] (03Merged) 10jenkins-bot: Story 1283: Add infinite scroll to Special:Uploads in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92560 (owner: 10Jdlrobson) [21:18:34] (03CR) 10JGonera: [C: 04-1] "(3 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91537 (owner: 10Jdlrobson) [21:20:15] (03CR) 10JGonera: [C: 04-1] "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91988 (owner: 10Jdlrobson) [21:21:21] (03CR) 10JGonera: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91988 (owner: 10Jdlrobson) [21:21:48] i've found another less serious bug - beta page preview is broken :( [21:24:33] MaxSem: Fatal error: Class 'ApiQueryGeoSearchDb' not found in /Users/jrobson/Sites/w/includes/api/ApiModuleManager.php on line 95 [21:24:35] how can i fix that? [21:25:03] I thought it ws fixed a year ago? [21:25:16] is GeoData up to date? [21:26:05] i think so MaxSem [21:26:23] hahah how funny [21:26:31] you think or you ran git pull?:P [21:27:16] (03PS1) 10Kaldari: Beginning to move some common test steps into a 'common' file. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92582 [21:27:48] my GeoData seems to not be a git repository [21:30:03] (03PS1) 10Jdlrobson: Fix page previews on nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92583 [21:30:26] MaxSem: works now [21:30:31] :) [21:32:30] (03PS3) 10Kaldari: Docs: Updating some Selenium documentation for MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92470 [22:00:23] (03PS1) 10Kaldari: Moving mobile notifications overlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92586 [22:01:58] jdlrobson: is Beta Features and your patch available anywhere? I don't seem to have a #mw-prefsection-betafeatures [22:02:39] (03CR) 10Kaldari: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92586 (owner: 10Kaldari) [22:02:41] marktraceur: ^ ? [22:03:01] spagewmf: http://multimedia-alpha.wmflabs.org/wiki/Special:Preferences#mw-prefsection-betafeatures [22:03:08] That [22:03:10] Yes [22:03:34] ahh. Are you going to configure it on en-beta ? [22:11:42] (03PS2) 10Jdlrobson: Beginning to move some common test steps into a 'common' file. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92582 (owner: 10Kaldari) [22:11:52] (03CR) 10Jdlrobson: [C: 04-1] "Commit message seems to suggest this is a WIP?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92582 (owner: 10Kaldari) [22:12:13] MaxSem: kaldari any issues with this https://gerrit.wikimedia.org/r/91535 ? [22:12:44] (03CR) 10Jdlrobson: [C: 032] Docs: Updating some Selenium documentation for MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92470 (owner: 10Kaldari) [22:12:59] Also MaxSem +2 hammer on https://gerrit.wikimedia.org/r/91532 please? [22:13:18] (03Merged) 10jenkins-bot: Docs: Updating some Selenium documentation for MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92470 (owner: 10Kaldari) [22:13:34] (03PS3) 10Jdlrobson: Don't change address bar in QUnit in Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91537 [22:13:35] jdlrobson, that custom config made MF tests slightly faster by not loading suites other than extensions' [22:13:42] (03PS2) 10Kaldari: Moving mobile notifications overlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92586 [22:14:07] MaxSem: define slightly faster? [22:14:16] YMMV [22:14:43] but slightly faster that it is noticeable to the average developer? [22:15:24] (03CR) 10Kaldari: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92586 (owner: 10Kaldari) [22:15:44] (03CR) 10MaxSem: [C: 04-2] "Still API structure change - can we rename the new lastmodified element and keep the old one for b/c?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen) [22:16:01] dunno, probably [22:19:01] (03PS3) 10Kaldari: Moving some common test steps into a 'common' file. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92582 [22:19:20] (03PS4) 10Kaldari: QA: Moving some common test steps into a 'common' file. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92582 [22:32:30] (03PS5) 10Kaldari: QA: Moving some common test steps into a 'common' file. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92582 [22:36:31] https://gerrit.wikimedia.org/r/#/c/91532/ < MaxSem care to explain your -2? I don't understand why this change is a problem [22:36:35] it's just adding to the result JSON [22:37:08] how can this break existing callers? [22:37:13] jdlrobson, this change breaks existing callers [22:37:16] how? [22:37:21] give me an example [22:37:33] was: lastmodified: "fooo" [22:37:45] now: lastmodified: { ... } [22:38:00] oh i didn't see that was there already [22:38:06] you obviously need to interpet these differently [22:38:31] ok i can fix this [22:38:37] what if we specify a timestamp type? [22:38:50] e.g. unix [22:39:19] (03PS4) 10Jdlrobson: Don't change address bar in QUnit in Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91537 [22:39:59] we historically use only one format... [22:41:14] MaxSem: let me write up my suggestion on it [22:42:32] (03PS3) 10Dr0ptp4kt: Verify User-Agent versus source proxy for X-CS=502-16. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92038 [22:47:55] jdlrobson, I0323a6ae739515bc3157114eac40c62ecf66823f [22:49:44] yurik_ you happen to be there? [22:50:04] dr0ptp4kt: no, i'm happened to be falling asleep [22:50:32] but i'm always happy to get some reviews from you [22:50:42] yurik_. ha: quick question: 10 am pacific time tomorrow instead of 10:30 am pacific time work for the thing with diederik? dan said he's cool with that [22:50:49] (there are a few patches waiting for your thoughtful comments) [22:51:20] dr0ptp4kt: my best time - around 1pm pacific [22:51:34] anyway we can push things up? [22:52:04] but if need be, i could be here at 10 or 10;30 [22:52:35] yurik_, sorry i meant thursday. what about for thursday? [22:53:00] thursday - same thing - 1pm PST would be ideal [22:53:20] yurik_ the calendar tells me that 1 pm isn't available that day [22:53:32] 2? [22:53:38] 11:30 am or 3:00 pm look available [22:53:43] ^yurik_ [22:57:32] ^yurik_ i'll email with dan and diederik on rescheduling. regarding patchsets, which ones you want me to look at? i think i actually looked at them all, but we're just waiting on verbiage? [22:57:51] i think so [22:58:24] btw, dr0ptp4kt check that carriers that ZERO their own websites don't get asked a confirmation [22:58:48] i suspect we don't do it correctly atm [22:59:03] just a sneak suspiscion :0 [23:01:22] yurik_ i'll add a card to trello [23:01:56] thx [23:02:35] jdlrobson: lemme know when you can discussion profile message [23:03:03] (03PS1) 10Jdlrobson: Add the phantom schema MobileWebCta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92593 [23:03:47] ^ MaxSem we need to lightning deploy this too according to Kenan [23:03:55] we are not collecting any data on the feature we added [23:04:10] greg-g, ^^ [23:09:18] jdlrobson, Greg needs an IRL poke:) [23:09:55] not sure where he is MaxSem [23:14:47] (03CR) 10Jdlrobson: [C: 04-1] "Suggested way to fix this:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen) [23:17:36] (03PS11) 10Jdlrobson: Hygiene: Eliminate api fixmes from PageApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen) [23:17:48] (03CR) 10MaxSem: [C: 032] Add the phantom schema MobileWebCta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92593 (owner: 10Jdlrobson) [23:19:57] (03Merged) 10jenkins-bot: Add the phantom schema MobileWebCta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92593 (owner: 10Jdlrobson) [23:22:40] (03PS5) 10Jdlrobson: Don't change address bar in QUnit in Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91537 [23:23:27] (03PS6) 10Jdlrobson: Don't change address bar in QUnit in Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91537 [23:23:38] (03CR) 10Awjrichards: [C: 04-1] "(6 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89283 (owner: 10Jdlrobson) [23:23:47] jdlrobson: sorry bud, it's close ^ [23:23:55] awjr: i'll blitz through that now then [23:24:19] jdlrobson: the big thing that im concerned about is checking beta-ness of the special pages [23:24:23] you'll see in the comments [23:24:31] awjr: reading through now [23:30:00] brion: i am now getting a "NeedToken" response :) [23:30:45] woohoo [23:31:09] awjr: i get your point - i'm not sure how generic beta-ness checker would work [23:31:21] how do you make parent::execute() kill execution of the child? [23:31:58] brion: can you merge those two patches? [23:32:04] moment [23:32:31] brion: we missed catching hashar again [23:37:31] jdlrobson: move beta checker into parent; if the checker passes, have it execute a method dfined in the abstract class (like childExecute() or whatever) and move dependent code in subclasses into that method [23:37:59] awjr: yeh that's what i was doing - am calling method render though [23:38:15] that works :) [23:40:13] (03CR) 10Brion VIBBER: "(1 comment)" [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/92477 (owner: 10Yuvipanda) [23:40:53] (03CR) 10Yuvipanda: "(1 comment)" [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/92477 (owner: 10Yuvipanda) [23:41:23] (03CR) 10Brion VIBBER: "(1 comment)" [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/92478 (owner: 10Yuvipanda) [23:42:44] (03CR) 10Brion VIBBER: [C: 032 V: 032] "(1 comment)" [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/92478 (owner: 10Yuvipanda) [23:43:46] (03PS3) 10Yuvipanda: Create wrapper exception to wrap around JSONException [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/92477 [23:43:56] (03PS2) 10Yuvipanda: Wrap IOException when it happens with ApiException [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/92478 [23:44:17] brion: updated [23:46:37] (03CR) 10Brion VIBBER: [C: 032 V: 032] Create wrapper exception to wrap around JSONException [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/92477 (owner: 10Yuvipanda) [23:47:00] (03PS15) 10Jdlrobson: Beta: Add Special:History [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/89283 [23:47:03] ^ awjr