[10:31:43] MaxSem: have a sec? [10:31:55] sure [10:32:41] MaxSem: i'm looking at our varnish repo (debian package) [10:33:01] do you know what's the usual git process to apply a patch to it? [10:33:06] that has been done in the upstream repo [10:33:29] you'd beter ask ops [16:58:31] dr0ptp4kt: ping [17:16:18] mhurd: you about ? [17:17:18] jdlrobson: do you see mhurd in the office ? [17:18:11] (03PS2) 10Yurik: Changed warning message for Zero [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/91787 [17:18:43] Hello mobile team, I'm working on wikimania2014 wiki, and mobilefrontend is already installed but the site is not responding responsively. Any idea why it might not be redirecting to .m? [17:19:04] (03PS4) 10Yurik: New warning page [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90881 [17:24:18] .EdSaperia, redirector rules? let me take a look [17:25:25] (I got as far as discovering that mobilefrontend exists and is installed on wm2014, and have delved no deeper) [17:25:34] yup [17:33:58] awjr: jdlrobson here [17:34:13] awjr: can you start a story wall for the next iteration? [17:34:37] EdSaperia, commited a fix in https://gerrit.wikimedia.org/r/92671 - not sure how long will it take to get this deployed [17:35:46] oh, hey, awesome [17:35:51] kenanwang: awjr ok so 1) As I understand it the A/B test for blue tutorial vs loading editor automatically measures the end result - did the edit get saved and answers the question which of these 2 workflows is more likely to get the edit saved? [17:36:10] not sure how long = 1 day, 1 week, 1 month, 3 months, 6 months? [17:37:20] let's hope soon:) [17:37:41] jdlrobson: awjr there are two things we [17:37:47] we're measuring [17:37:52] activation [17:37:58] and productivity [17:38:29] it won't affect activation i.e. likelihood of making first edit [17:38:44] but it could affect productivity [17:39:08] ok [17:39:21] so jdlrobson, kenanwang it sounds to me like we should turn off the first a/b test before starting the second [17:39:25] i.e. chance of having an unreverted edit in 7 days [17:39:38] otherwise the results of the second may be tainted by the effects of the first [17:39:59] jdlrobson: the current a/b test is running on all wikis? [17:40:10] :) thank you anyway! [17:40:17] tfinc: ya he's here - sry just saw your msg [17:40:37] tfinc: opps you were looking for me haha [17:43:11] jdlrobson: if the current a/b test is everywhere, but we're planning on enabling the second a/b test via the deployment train, then i think we can safely disable test #1 and enable test #2 with the deployment train [17:43:15] does that sound right to you? [17:43:23] mhurd: you got the video on the standup up going so you did want i wanted :) [17:43:37] tfinc: ah awesome :) [18:08:10] sorry i got grabbed by designers awjr [18:08:27] 2) the golden toast A/B test only fires AFTER an edit [18:08:32] jdlrobson: that's disturbing [18:08:44] so yes productivity measurements could be effected kenanwang [18:08:56] so the question is do we keep the golden toast or kill it [18:09:01] what is the correct answer? [18:09:05] violetto: yes very.. [18:09:10] let's kill it jdlrobson awjr [18:09:15] kenanwang: i want data [18:09:23] otherwise what was the point in doing this [18:09:35] jdlrobson: we still have data even if we kill the test [18:10:03] kenanwang: sure but you are creating more work on the long term if we decide to reinstate it [18:10:05] i want to kill the right bit of code in the A/B test [18:10:12] and from past experience no one will follow up [18:10:17] let's do this properly first time round [18:10:48] jdlrobson: When do we need to make a decision by? [18:12:39] kenanwang: we should decide asap - if we have to make code changes that need to go out with tomorrow morning's deployment train deployment, we need time to review and merge [18:13:38] jdlrobson, kenanwang: is "golden toast" the tutorial a/b test? [18:13:52] DarTar: no this is an older a/b test [18:13:55] no it's another ab test that we forgot about until recently [18:14:01] on beta? [18:14:33] https://meta.wikimedia.org/w/index.php?title=Research:Mobile_PEF#Mobile_PEF_1 i think [18:14:42] I'll see what I can turn up in the next hour [18:14:49] i think maryana ran it [18:14:58] in the meantime, awjr can you start the next iteration storywall? [18:15:23] greetings :) [18:15:27] missed me? [18:15:35] as long as it's not on stable and interfering with the other one I'm ok to kill it [18:15:36] haha [18:15:37] hey [18:15:37] your call [18:16:02] did upi do analysis on the golden toast ab test? [18:16:20] Maryana: ^ [18:16:31] upi? [18:16:39] u [18:16:42] lulz [18:16:44] :-) [18:16:55] i thought maybe we had a secret research committee that i wasn't aware of ;) [18:17:22] i did some back-of-the-napkin calculations a few days and a few weeks after it was released - test and control were dead even [18:17:35] i'm not sure i ever got a chance to document that anywhere, tho :( [18:17:48] kenanwang: done [18:18:22] the data's all there in stat1, though… i could poke around in it if you're interested [18:18:37] k [18:18:51] which one would you rather keep :-) [18:19:22] i think they're both fine - if we want golden toast, i'd suggest making it even more blinged-out and shiny! :) [18:20:33] hahah [18:20:39] aight [18:21:15] jdlrobson: ^ we don't have recorded data [18:21:31] jdlrobson: but Maryana's research found them dead even [18:22:02] ok kenanwang so it's your call - it makes no difference either way [18:22:12] golden toast it is! [18:22:16] ok i'll do that now [18:22:19] yeah, why not :) [18:22:25] i want to see sparkly toast [18:22:29] sparkly toast a/b test [18:22:30] we should make it more bling and sparkly though [18:22:35] ^ yes [18:22:35] violetto maybe can help with that [18:22:38] +++ [18:25:10] (03PS1) 10Jdlrobson: Golden toast wins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92676 [18:25:22] done but kenan left grumble grumble [18:25:42] hahahahahha, i am the PM now! sparkle allll the things!!! [18:25:47] :D [18:29:38] jdlrobson: Maryana golden toast for some reason reminded me of this http://bit.ly/HuWAj9 [18:29:55] haha [18:30:14] GOLDEN TOAST [18:30:34] http://files.abovetopsecret.com/images/member/045da852517a.jpg < it's brandon harris!!! [18:30:49] that's horrifying [18:31:04] rofl [18:31:26] Maryana: so, was golden jesus toast on stable or beta? [18:32:00] stable [18:32:05] ouch [18:32:12] so still running now? [18:32:34] yeah, looks like [18:32:35] heh [18:32:44] so we've definitely got a large enough sample size :) [18:32:46] *sigh* [18:33:03] yeah, but it's been running concurrently with another test [18:33:17] it's a really subtle change with no measured affect - pretty sure it's ok [18:33:28] *effect [18:33:47] I need to look up the mobile pef1 docs anyway [18:34:01] mhurd: hey! I want to talk about the way you are doing the network requests and chaining them, 'coz I'm doing that in Android now. Poke me when you have time [18:34:14] YuviPanda: ya i have time now [18:42:10] jdlrobson: hahaha there's definitely a huge resemblance [18:45:56] yurik: lets switch to irc [18:46:16] yurik: pm [18:47:25] ok, got that little robots.txt update for google guys done [18:48:18] and spent some time tracking down more fun a/v codec wackiness. thanks mozilla and cisco for announcing weird half-done stuff! [18:49:02] (03CR) 10Jdlrobson: [C: 032] QA: Moving some common test steps into a 'common' file. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92582 (owner: 10Kaldari) [18:49:19] MaxSem: https://gerrit.wikimedia.org/r/#/c/91532/? [18:49:34] (03Merged) 10jenkins-bot: QA: Moving some common test steps into a 'common' file. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92582 (owner: 10Kaldari) [18:52:39] (03CR) 10Jdlrobson: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92601 (owner: 10Awjrichards) [18:53:31] (03CR) 10MaxSem: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen) [18:53:40] jdlrobson, ^ [18:55:25] (03CR) 10Jdlrobson: [C: 032] "Oh wait.. ignore MobileSpecialPageFeed::execute is inherited and calls execute so this is fine!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92601 (owner: 10Awjrichards) [18:55:52] MaxSem: looking [18:55:57] (03Merged) 10jenkins-bot: Update mobile specialpages to use executeWhenAvailable() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92601 (owner: 10Awjrichards) [18:56:25] So MaxSem about https://gerrit.wikimedia.org/r/#/c/91532/11/includes/api/ApiMobileView.php [18:56:33] although that may be the case the unix timestamp is more useful in JavaScript [18:56:38] for this purpose at least [19:01:02] awjr: howie is in our room :( [19:01:13] give him a smack, jdlrobson [19:01:33] a friendly one, of course [19:01:35] we're in [19:04:25] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen) [19:04:44] "The Nexus 5 looks likely to be announced October 31" [19:50:21] http://etherpad.wikimedia.org/p/MobileWeb-IterationName [20:42:44] (03PS1) 10Brion VIBBER: stub readme reference the java-mwapi project where work is starting [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/92766 [20:50:26] (03PS1) 10Dr0ptp4kt: Hide W0 banner on File pages when carrier doesn't zero-rate images. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92768 [20:51:55] ^ yurik yurik_ you there? if so, would you please review and +2 [20:52:07] dr0ptp4kt: was about to -1 it ;) [20:52:32] yurik_! :) alright lemme know [20:53:03] dr0ptp4kt: problem is - we will get rid of that code -- we need to make it work for ESI mode [20:53:11] although we might do it as a separate patch [20:53:38] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen) [20:53:52] MaxSem: so the question is do we care? ^ [20:53:54] maybe not is the answer [20:54:11] i suppose if this does expose bugs this is a good thing [20:56:55] (03CR) 10Brion VIBBER: [C: 032 V: 032] stub readme reference the java-mwapi project where work is starting [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/92766 (owner: 10Brion VIBBER) [20:59:08] yurik_ your call. could ZeroSpecialPage::showBanner call $this->state->createBanner instead? [20:59:29] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen) [21:01:25] yurik_, going for a short walk. i'm cool with whatever, lemme know if you want me to update some other parts of the code or if we just add a TODO :) [21:01:30] TODO bleh [21:05:48] jdlrobson, still... whole API returns one format, you want another. how about the following: we keep the ISO format for now, but I add a centralised facility to the API to select timestamp format? [21:06:24] MaxSem: that sounds like a good idea I'm just trying to work out the best way forward for now [21:06:41] I suppose we could add a JavaScript wrapper that converts it into a unix timestamp to avoid caching issues [21:06:47] yeh that makes sense [21:07:09] MaxSem: should I raise a bug about supporting unix timestamp formats? [21:07:39] wee, it could help to justify the feature [21:09:42] (03PS3) 10Kaldari: Moving mobile notifications overlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92586 [21:10:12] jdlrobson: Haven't fix the problem with the Upload tutorial, but fixed a few other things [21:10:26] jdlrobson: feel free to merge it as is if you like [21:11:00] I'm looking into the Upload tutorial issue now [21:11:06] kaldari: will do! [21:12:38] (03PS4) 10Jdlrobson: Hygiene: Consolidate ajax loading code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91988 [21:24:54] (03CR) 10Robmoen: [C: 031] Golden toast wins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92676 (owner: 10Jdlrobson) [21:26:15] (03PS1) 10Yuvipanda: Initial commit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/92775 [21:26:55] brion: ^ Think we can test it out on your laptop and see if it builds properly? [21:27:06] \o/ [21:27:08] Tests are a little flaky on my machine/phone combo [21:27:15] even though those are trivial [21:27:20] brion: also, it has an AsyncTask replacement! [21:27:28] and nothing much else, but still [21:28:47] brion: going to step out for lunch, brb [21:29:23] (03CR) 10JGonera: [C: 032] Golden toast wins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92676 (owner: 10Jdlrobson) [21:30:23] (03Merged) 10jenkins-bot: Golden toast wins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92676 (owner: 10Jdlrobson) [21:30:28] ok [21:30:46] YuviPanda: [ERROR] Failed to execute goal on project wikipedia: Could not resolve dependencies for project org.wikimedia:wikipedia:apk:1.0-SNAPSHOT: Could not find artifact org.mediawiki.api:json:jar:1.0-SNAPSHOT in android-support-repository (file:////Users/brion/android-sdks/extras/android/m2repository/) -> [Help 1] [21:32:02] [WARNING] The POM for org.mediawiki.api:json:jar:1.0-SNAPSHOT is missing, no dependency information available [21:32:02] ^ [21:35:45] (03CR) 10Brion VIBBER: [C: 04-1] "'mvn test' fails for me:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/92775 (owner: 10Yuvipanda) [21:43:00] (03PS4) 10Jdlrobson: Moving mobile notifications overlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92586 (owner: 10Kaldari) [21:46:38] (03PS5) 10Jdlrobson: Moving mobile notifications overlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92586 (owner: 10Kaldari) [21:53:52] (03PS2) 10Yurik: Hide W0 banner on File pages when carrier doesn't zero-rate images. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92768 (owner: 10Dr0ptp4kt) [21:55:17] (03PS2) 10Jdlrobson: Fix left margin in top bar (last edited) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92608 (owner: 10JGonera) [21:55:22] (03CR) 10Jdlrobson: [C: 032] Design tweak: Fix horizontal padding for top bar (last edited) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92608 (owner: 10JGonera) [21:56:44] (03CR) 10Jdlrobson: [C: 032] Moving mobile notifications overlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92586 (owner: 10Kaldari) [21:57:19] MaxSema awjr what's the status of https://gerrit.wikimedia.org/r/#/c/88903/ [21:57:23] been sitting there for a long time without any movement [21:57:30] (03Merged) 10jenkins-bot: Design tweak: Fix horizontal padding for top bar (last edited) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92608 (owner: 10JGonera) [21:57:35] (story card: https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1293) [21:58:39] (03Merged) 10jenkins-bot: Moving mobile notifications overlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92586 (owner: 10Kaldari) [22:00:29] blerg [22:00:32] i think im getting sick [22:00:49] (03PS3) 10Dr0ptp4kt: Hide W0 banner on File pages when carrier doesn't zero-rate images. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92768 [22:03:18] dr0ptp4kt: adam, did you look at my code, or you just uploaded yours? [22:03:35] yuirk_ ha, i just noticed you uploaded a patchset. let me test that [22:05:18] compare 2 & 3 [22:05:39] i'm glad they are so similar, but you have made a number of incorrect assumptions - will post -1 in a sec [22:06:56] (03CR) 10Yurik: [C: 04-1] "(4 comments)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92768 (owner: 10Dr0ptp4kt) [22:09:49] (03Abandoned) 10Dr0ptp4kt: Hide W0 banner on File pages when carrier doesn't zero-rate images. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92768 (owner: 10Dr0ptp4kt) [22:10:04] (03Restored) 10Dr0ptp4kt: Hide W0 banner on File pages when carrier doesn't zero-rate images. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92768 (owner: 10Dr0ptp4kt) [22:12:11] dr0ptp4kt: need help reverting? [22:12:23] yurik_ yeah :) [22:12:25] kaldari: just checking, you did email and/or remove all the people from deployment-prep that haven't signed an NDA right? [22:12:38] yurik_ seems like gerrit doesn't have it built in [22:12:42] I emailed them, but haven't heard back from eaither of them [22:12:49] yurik_ but i'm sure there's a way to do this [22:12:53] aude: ^ [22:12:55] (besides painful ones) [22:13:01] dr0ptp4kt: sec [22:13:08] kaldari: gotcha, so two are potential removes still. [22:13:13] yes [22:13:27] If I don't hear back from them by the end of the week, I'll remove them [22:13:29] yurik_ alright [22:15:35] (03PS4) 10JGonera: Separate stable and beta upload overlay code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92031 [22:15:36] (03PS4) 10JGonera: Introduce OverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92012 [22:15:37] (03PS1) 10JGonera: Story 1280 (1/2): Overhaul of image uploading overlay design [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92787 [22:15:47] (03PS1) 10Yurik: Hide W0 banner on File pages when carrier doesn't zero-rate images. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92789 [22:16:37] (03Abandoned) 10Yurik: Hide W0 banner on File pages when carrier doesn't zero-rate images. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92768 (owner: 10Dr0ptp4kt) [22:16:38] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok, went over how to run the Android-specific tests, we have to use IntelliJ for now and either an emu or device. Seems to build and run. " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/92775 (owner: 10Yuvipanda) [22:16:39] (03CR) 10JGonera: "No longer WIP, but should be merged together with Ie00b8d76caae882ae27e726478d1662fcced63d6" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92012 (owner: 10JGonera) [22:16:50] dr0ptp4kt: re-check in was the easiest [22:16:59] (03CR) 10JGonera: "No longer WIP, but should be merged together with Ie00b8d76caae882ae27e726478d1662fcced63d6" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92031 (owner: 10JGonera) [22:16:59] could you test it for me pls [22:17:41] dr0ptp4kt: btw, also - the current problem with warnings given when they shouldn't won't be a problem once the code is released - it was fixed in my recent patch [22:17:59] and last thing - does your test check for it? [22:19:16] (03CR) 10Dr0ptp4kt: [C: 032] Hide W0 banner on File pages when carrier doesn't zero-rate images. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92789 (owner: 10Yurik) [22:19:30] dr0ptp4kt: did you run it? :) [22:19:35] yurik, i ran it [22:19:41] (your patchset) [22:19:43] excellente :) [22:19:44] thx [22:19:54] maybe we should depl it today [22:20:21] sigh. I feel I'm terribly overengineering the ToU stuff:P [22:20:42] (03CR) 10jenkins-bot: [V: 04-1] Hide W0 banner on File pages when carrier doesn't zero-rate images. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92789 (owner: 10Yurik) [22:21:39] yurik, yeah if you can make it happen, that'd be cool. i'll need to add some extra checks for banners to the phantomjs stuff. will add a card for that [22:21:43] damn you jenkins! [22:23:52] (03PS2) 10Yurik: Hide W0 banner on File pages when carrier doesn't zero-rate images. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92789 [22:24:04] yurik_ you want me to pull and rebase? i know how fun it can be if your working directory gets hosed [22:24:24] (03PS1) 10Yuvipanda: Remove random cruft that should never have been commited [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/92790 [22:25:24] dr0ptp4kt: could you +2 again pls [22:25:26] https://gerrit.wikimedia.org/r/#/c/92789/ [22:25:54] yurik_ uno momento [22:26:01] dr0ptp4kt: sec [22:26:14] maybe we should wait to +2 until jenkins does +1 ? [22:26:27] never mind, we got +1, go ahead [22:26:32] dr0ptp4kt: ^ [22:28:08] (03CR) 10Dr0ptp4kt: [C: 032] Hide W0 banner on File pages when carrier doesn't zero-rate images [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92789 (owner: 10Yurik) [22:28:12] (03Merged) 10jenkins-bot: Hide W0 banner on File pages when carrier doesn't zero-rate images [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92789 (owner: 10Yurik) [22:28:18] yuirk_ done [22:28:37] question: why does MobileContext->getMobileUrl() updates mobile URLs when shouldDisplayMobileView() returns false [22:29:08] I'm solving the bug where CN will always use desktop URLs even on the mobile site [22:30:12] MaxSem: that sort of makes sense; but I'm curious why inside getMobileUrl it looks to see if it should be displaying in that case [22:30:36] The status for your app, Wikimedia Commons (630901780), is now Ready for Sale. [22:30:38] wheeeeee [22:31:05] awjr should know better ^^^ [22:31:59] mwalker: there arre times you may still want a mobile URL even if you're displaying desktop view [22:32:11] eg in generating the 'mobile view' link in the footer of the desktop site [22:33:34] so that method should really be independent of whether or not you're in the mobile view [22:33:50] right; but internal to it; it's not independent which is why I thought it was going to be [22:34:04] eh [22:34:05] * awjr looks [22:34:18] @_@ [22:34:24] hmm [22:34:32] did i add that hook? [22:35:07] according to annotate it was MaxSem* who did it [22:35:15] yah just saw that from git blame [22:35:26] i forget what that hook's al about [22:35:27] * awjr looks [22:35:57] hmm [22:36:10] i dont know - MaxSem do you know/recall? ^^ [22:36:34] no idea - I've never touched that part of code [22:36:42] that's not what git blame says :p [22:37:18] oh that's from a refactoring [22:37:52] if it's working as expected though -- *shrugs* -- I think what I really want to know is if shouldDisplayMobileView() will only return true when on the mobile site [22:38:05] (03CR) 10Dr0ptp4kt: "(4 comments)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92768 (owner: 10Dr0ptp4kt) [22:38:10] because then I can use that to gate if I want to transform CN urls [22:38:25] shouldDisplayMobileView() will only return true if the mobile view is being displayed [22:38:37] that is, it is used to determine whether or not the mobile view is displayed [22:38:41] mwalker: ^ [22:38:46] shiney [22:38:53] ^^&&&yurik_ just updated comments on the the abandoned change so we have a history. [22:40:44] dr0ptp4kt: thx [22:41:12] oh [22:41:16] MaxSem, mwalker: https://gerrit.wikimedia.org/r/#/c/4377/ [22:41:28] it's for updating the .m with .zero [22:41:30] ah [22:41:57] interesting [22:41:58] (03PS1) 10Kaldari: Make sure header is rendered before binding events to it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92794 [22:42:22] i wonder why that needs to be wrapped in a shouldDisplayMobileView() [22:43:07] jdlrobson: If you get a chance would be good to get https://gerrit.wikimedia.org/r/#/c/92794/ merged [22:43:12] it's the fix for the upload page [22:43:17] and possibly others [22:43:34] dr0ptp4kt: syncing right now [22:45:04] kaldari: you can just use $( function(){} ) in this case [22:45:19] jdlrobson: I know, but I think the longer version is easier to read [22:46:21] jdlrobson: But if you want me to change it, let me know [22:46:22] kaldari: oh gawd not this conversation again…. (Remembers conversation on wikitech) [22:46:41] jdlrobson: currently, neither is specified in the coding conventions [22:46:54] so it's a matter of preference, ASAIK [22:46:56] oops [22:47:00] AFAIK [22:47:05] Fri 21 Jul 2023 is the 10th anniversary of document.ready standardization [22:47:12] ori-l can testify [22:47:21] * jdlrobson digs out conersation [22:48:06] kaldari: https://gerrit.wikimedia.org/r/#/c/74079/ [22:48:13] MaxSem: do you see any reason to keep that wrapped in a shouldDisplayMobileView() check? [22:48:25] specifically my last comment ;-) [22:48:27] Yes, Krinkle and I disagree on this :P [22:48:29] "The way i look at this is in 10 years time I highly doubt anyone is going to look back and say "That day we choose $( document ).ready over $(function(){ was a turning point in the development of MediaWiki"." [22:48:37] awjr, "don't touch if it ain't broken"? :P [22:48:39] ori set up a calendar invite [22:48:44] heh [22:48:53] dr0ptp4kt: pls go ahead, en is live [22:49:13] as do a few other developers [22:49:23] jdlrobson, do we need to deploy your fix of yesterday? [22:49:38] MaxSem: which fix? THe one I emailed about today? [22:49:42] kaldari: on what? $() vs $(document).ready? [22:49:43] ask kenan [22:49:48] NOOO [22:50:01] Krinkle: yes, $(document).ready is more readable and grepable [22:50:08] jdlrobson, no - the one you wanted me to LD but we couldn't locate Greg:) [22:50:34] Krinkle: but like I said, I'm willing to use either [22:50:40] why would you need to grep for it? As for readability, it is an upstream API, knowing what $() does is jQuery 101. [22:50:43] but above all, consistency. [22:50:53] any other argumetns are negligible imho [22:51:12] Krinkle: knowing everything that $() does isn't jQuery 101 [22:51:20] it's jQiery 102 [22:51:26] MaxSem: I forget you need to describe links to me [22:51:37] AHAHRHGHGHGHGGH at the Krinkle kaldari conversation [22:51:43] lol [22:51:45] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92794 (owner: 10Kaldari) [22:51:50] ^ that's all i have to say about it [22:51:51] sure, but being a mediawiki front-end engineer certainly has a higher entry level than jQuery 102, so it's moot. [22:51:51] where's my flamethrower [22:51:56] The following app has been approved and the app status has changed to Ready for Sale: [22:51:57] brion: : [22:51:58] yurik_ thx [22:52:00] : [22:52:02] well that was a fail [22:52:04] brion: app passed :D [22:52:13] yayyy [22:52:29] jdlrobson, ok - so apparently it's not important if you don't remeber) [22:52:34] Krinkle: I hope our code is readable by more than just WMF engineers [22:52:49] s/mediawiki// [22:52:59] shrug [22:53:10] MaxSem: it might be important. I may have assumed it was taken care of so please send me a link if you remember [22:53:29] where's kenanwang again when you need him [22:53:42] Krinkle: anyway, I don't really see either as having a huge advantage, so I think either should be acceptable personally [22:54:33] kaldari: actually you could make the point that code size decreases significantly since this is a common pattern.. that seems like an advantage (although a micro-optimisation) [22:54:38] jdlrobson: he's in a mtg [22:54:47] with tfinc [22:54:51] in r34 [22:55:03] at least, according to the calendar [22:55:15] kaldari: that's where coding style and consistency comes in. See, worrying about someone not knowing what $() seems weird to me, because if that's a problem, that person has a lot to learn. But if someone sees the same project using 2 different methods for exactly that same, that just makes us look like a fool. [22:55:22] he;'s got another mtg at 430 so you got 35 minute to corner him [22:55:33] MaxSem: it's possible that https://gerrit.wikimedia.org/r/92583 was the other patch for LD but I'm not sure if Kenan said yes to it or not [22:55:38] jdlrobson: in my experience, sending him an sms works if he's in a mtg and it's urgent/urgent-ish [22:55:44] yurik_ it seems to be working. lemme know once it's everywhere and i'll manually kick off the script [22:55:47] awjr: tfinc is here and he's not next to him [22:55:49] his # is on officewiki [22:55:56] well well well [22:56:02] dr0ptp4kt: pushing #23, sec [22:56:07] Krinkle: I agree with you to a point, but I think there is room for some style variation [22:56:29] "All code in any code-base should look like a single person typed it, no matter how many people contributed." –rwaldron [22:56:40] (03CR) 10Jdlrobson: [C: 04-2] "WIP please remove my -2 when it isn't" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92036 (owner: 10MaxSem) [22:56:45] jdlrobson, anyway - such things should be decided before the LD :) [22:56:51] MaxSem: agreed [22:56:54] anyway, sure there's some variance. but I don't think that should apply to functions. Maybe to structure (e.g. if/else switch etc.) [22:57:05] Krinkle: that doesn't seem like a realistic ideal for open source software, IMO [22:57:43] kaldari: Similar to how in PHP you shouldn't use both !$array and !count( $array ) and $array === array(). Stick to one for the same purpose. [22:57:50] the rest is just confusing. [22:58:56] in those contexts it is imho not about being able to understand it (a developer should be able to understand both of those variations), but it is about being easier to read in the same context. e.g. like switching languages or accents within 1 post, that's harder to interpret. [22:59:02] anyway, moving on :) [22:59:13] (03PS1) 10MaxSem: Golden toast wins [extensions/MobileFrontend] (wmf22) - 10https://gerrit.wikimedia.org/r/92801 [22:59:22] (03CR) 10MaxSem: [C: 032 V: 032] Golden toast wins [extensions/MobileFrontend] (wmf22) - 10https://gerrit.wikimedia.org/r/92801 (owner: 10MaxSem) [22:59:23] Krinkle: anyway, we might just have to agree to disagree, but if $() is going to be enforced it should put in the coding conventions [22:59:33] kaldari: It has [22:59:46] (03PS1) 10MaxSem: Golden toast wins [extensions/MobileFrontend] (wmf1) - 10https://gerrit.wikimedia.org/r/92802 [22:59:56] (03CR) 10MaxSem: [C: 032 V: 032] Golden toast wins [extensions/MobileFrontend] (wmf1) - 10https://gerrit.wikimedia.org/r/92802 (owner: 10MaxSem) [22:59:58] or was [23:03:21] dr0ptp4kt: fini [23:09:03] jdlrobson, deployed [23:09:09] yurik_ test kicked off [23:09:39] (03PS2) 10Kaldari: Make sure header is rendered before binding events to it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92794 [23:09:41] dr0ptp4kt: interestingly enough - https://gdash.wikimedia.org/dashboards/jobq/deploys -- we have caused a spike in the job que for some reason [23:10:04] jdlrobson: https://gerrit.wikimedia.org/r/92794 :P [23:16:08] dr0ptp4kt: could you kill your test please, something weird is going on, and check whatever results it already got [23:20:39] awjr, kaldari - red alert, prod is fataling [23:20:51] PHP Fatal error: Class 'MFResourceLoaderModule' not found in /usr/local/apache/common-local/php-1.23wmf1/includes/resourceloader/ResourceLoader.php on line 408 [23:20:55] see #-ops [23:22:18] MaxSem: what got deployed? [23:22:40]