[00:17:25] (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92000 (owner: 10Jdlrobson) [00:41:42] (03PS1) 10Yuvipanda: Remove AppCompat dependency for now [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/92822 [00:41:43] (03PS1) 10Yuvipanda: Add tests for thread affinities of Safe AsyncTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/92823 [00:43:36] (03PS1) 10Yurik: Excluded a number of common bots from the zero log [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92824 [02:02:36] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92000 (owner: 10Jdlrobson) [06:27:07] (03PS3) 10Mgrover: fix Nearby overlay automation test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92488 [06:27:11] (03CR) 10jenkins-bot: [V: 04-1] fix Nearby overlay automation test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92488 (owner: 10Mgrover) [06:37:42] (03PS2) 10Yuvipanda: Add tests for thread affinities of Safe AsyncTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/92823 [06:38:38] (03PS4) 10Mgrover: fix Nearby overlay automation test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92488 [06:38:42] (03CR) 10jenkins-bot: [V: 04-1] fix Nearby overlay automation test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92488 (owner: 10Mgrover) [06:42:11] (03PS1) 10Yuvipanda: Make all AsyncTask based tests run on the UI Thread [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/92830 [06:46:17] (03PS1) 10Yuvipanda: Rename the new AsyncTask to be less of a mouthful. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/92831 [06:50:44] (03PS1) 10Yuvipanda: Reduce timeout for each AsyncTask test from 1s to 100ms [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/92833 [06:56:29] (03PS1) 10Yuvipanda: Add test to verify SaneAsyncTask exception handler thread affinity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/92834 [06:56:51] (03Abandoned) 10Yuvipanda: Reduce timeout for each AsyncTask test from 1s to 100ms [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/92833 (owner: 10Yuvipanda) [07:08:03] * YuviPanda waves at violetto [07:11:11] YuviPanda: yoohoo! [07:11:35] violetto: just got back to the hotel. 'twas a nice evening :) Thanks for inviting me over! [07:13:13] YuviPanda: glad you're hotel safe. np! good to hear you had fun! [07:13:24] :D [07:20:15] * YuviPanda goes to sleep [07:41:11] (03PS2) 10Yuvipanda: Rename the new AsyncTask to be less of a mouthful. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/92831 [07:41:12] (03PS2) 10Yuvipanda: Make all AsyncTask based tests run on the UI Thread [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/92830 [07:41:13] (03PS2) 10Yuvipanda: Add test to verify SaneAsyncTask exception handler thread affinity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/92834 [07:41:14] (03PS3) 10Yuvipanda: Add tests for thread affinities of Safe AsyncTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/92823 [14:30:17] (03PS1) 10Zfilipin: Removed unused gem from Gemfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92876 [16:16:13] (03CR) 10Cmcmahon: [C: 032] Removed unused gem from Gemfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92876 (owner: 10Zfilipin) [16:17:02] (03Merged) 10jenkins-bot: Removed unused gem from Gemfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92876 (owner: 10Zfilipin) [16:56:58] hello boys and girls [16:57:36] good morning Professor MaxSem [17:00:22] greetings! [18:11:17] brion: heya! [18:11:29] brion: saw the patches I sent in y'day night? [18:11:46] brion: maven *can* run the tests now, but apparently they run on mvn install than mvn test [18:12:12] yay! i'll pull em up momentarily [18:12:34] brion: woo! [18:16:31] dr0ptp4kt: https://github.com/montehurd/apps-ios-clean-operations/tree/master/apps-ios-clean-operations/Objects [18:19:43] (03CR) 10Brion VIBBER: [C: 032 V: 032] Remove random cruft that should never have been commited [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/92790 (owner: 10Yuvipanda) [18:20:09] (03CR) 10Brion VIBBER: [C: 032 V: 032] Remove AppCompat dependency for now [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/92822 (owner: 10Yuvipanda) [18:23:43] (03CR) 10Brion VIBBER: [C: 032 V: 032] Add tests for thread affinities of Safe AsyncTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/92823 (owner: 10Yuvipanda) [18:25:03] (03CR) 10Brion VIBBER: [C: 032 V: 032] Make all AsyncTask based tests run on the UI Thread [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/92830 (owner: 10Yuvipanda) [18:26:22] (03CR) 10Brion VIBBER: [C: 032 V: 032] Rename the new AsyncTask to be less of a mouthful. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/92831 (owner: 10Yuvipanda) [18:27:32] (03CR) 10Brion VIBBER: [C: 032 V: 032] Add test to verify SaneAsyncTask exception handler thread affinity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/92834 (owner: 10Yuvipanda) [18:28:17] https://play.google.com/store/devices/details?id=nexus_5_black_16gb [18:33:32] brion: heh, already out of stock [18:35:01] " Thank you. Your order has been placed, and you will receive an email shortly with the details of your purchase. " [18:35:04] i must have clicked early enough \o/ [18:37:07] brion: "Chromium, the web engine behind Chrome, is finally the web engine that powers third party apps in KitKat, which will hopefully make more apps faster and better-looking." [18:37:14] mhurd: ^ [18:37:19] interesting... [18:37:27] the real question is "will they keep it updated"? [18:37:29] yurik yurikNY for some reason it seems that w0 banners are showing for "Free Wikipedia from Wikimedia" when coming from the corporate network. i'm going to remove the 21.6.38.130.160/28 subnet for now. [18:37:34] or will it be a fixed version per Android rev? [18:37:36] brion: worries me slightly, if it'll be open source [18:38:06] "chrome: it's mostly open source!" [18:38:09] heh [18:38:14] at least it says chromium [18:39:53] brion: I bet my Galaxy S3 is going to be stuck on 4.1 forever, tho [18:40:03] :( [18:42:09] brion: YuviPanda: stepping out for lunch / errands. back at 1 [18:42:16] ok! [18:42:17] spiff [18:42:56] brion: hopefully I can switch to a Nexus 5 for testing, instead of the S3. If we can get one before the India summit thing, I guess someone from SF can get it to me [18:42:57] sigh [18:44:07] it says mine will ship by november 8 [18:44:16] looks like the white version is still in stock, and the 32GB version [18:44:27] meh, I need to ask tomasz before I can order [18:44:57] expense report approval for the win! [18:45:07] i usually buy my own, but it's an expensive habit ;) [18:45:22] after this one i'll wait another product generation or so i think [18:45:28] heh [18:45:58] playing with firefox os is way cheaper, they're low-end phones ;) [18:46:22] but at half the cost of other flagship devices, i just can't pass up the n5 [18:46:30] yeah [18:46:56] yurik thx for the update - banners bye bye [18:48:39] brion: did they all get merged? [18:48:44] oh yeah they did :D [18:48:48] \o/ [18:48:55] brion: did you find time to take a look at otto? [18:49:15] not in detail yet [18:49:29] brion: ah ok [18:50:54] awjr_away, any ideas when the list of arch summit attendees will be approved? [18:54:03] and here i thought everyone would enjoy banners at the office -- wiki is free afterall for all of WMF! [19:11:42] jcmish: any chance this means anything to you? https://gerrit.wikimedia.org/r/92804 [19:11:51] jgonera: quick suggestion about https://gerrit.wikimedia.org/r/#/c/92031/4 [19:12:06] instead of using uploadsNew folder why not put it in uploads/v2/ [19:12:11] to keep all the uploads code together? [19:12:55] jdlrobson, it's temporary anyway, do I have to do it? ;) that's a lot of paths to change [19:13:16] we can do it later yeh i just feel it might organize things a little letter [19:13:24] maybe I should have asked about this before I wrote it as I wasn't sure about the naming [19:13:31] also less/modules/uploads/PhotoUploaderButton.less and less/modules/uploadsNew/PhotoUploadOverlay.less are identical [19:13:44] i assume the new one is going to change? [19:13:50] are you sure? button and overlay? [19:13:55] but i wonder why you just didn't import the content of the old stuff [19:14:02] for readability purposes [19:14:10] let me see [19:14:15] e.g. @import "../uploads/PhotoUploadOverlay.less" [19:14:37] they're two totally different files for me jdlrobson [19:14:41] (just struggling to grok what's going on) [19:14:50] not sure how you ended up with them being the same [19:15:19] i'll play around a bit more [19:15:28] i guess the 2 folders are just massively confusing me [19:16:15] well, I needed to separate it somehow, I reused some code, but I couldn't reuse too much because I'd end up with lots of if inBeta all over the place... [19:18:43] jgonera: just to clarify - everything in uploadsNew is a clone of that in uploads ? [19:19:40] jdlrobson: nope [19:19:43] let me dig in though [19:20:09] jdlrobson, more or less, it just inherits from OverlayNew instead of Overlay in most cases, sometimes the code is different too (as is the case with upload progress) [19:20:31] jgonera: ok i'm going to rewrite the commit message and check it with you - i just want to make sure i completely understand what you are doing here [19:20:40] YuviPanda: oh hey when i'm done with some notes on monte's iOS code i'm gonna take a look over otto -- do you have a doc page you recommend for it or should i just skim the source?e :D [19:20:53] brion: http://square.github.io/otto/ [19:21:01] brion: I emailed it as well y'day night [19:21:05] jdlrobson, sure, are you coming to the office today? [19:21:12] jgonera: nope i'm in monterey [19:21:16] i'm not in the office tomorrow either [19:21:21] jdlrobson, oh I see [19:21:28] YuviPanda: right, but it's just that one page and then the source, no more right? [19:21:29] do you want a hangout or irc then? [19:21:36] brion: ya [19:21:45] heh. nice and bare bones :D [19:21:48] let the code do the talking ;) [19:21:51] jgonera: irc is fine for time being but if it gets more complicated we can do a hangout yeh [19:21:59] ok [19:23:38] (03CR) 10JGonera: [C: 032] Don't change address bar in QUnit in Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91537 (owner: 10Jdlrobson) [19:25:45] (03Merged) 10jenkins-bot: Don't change address bar in QUnit in Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91537 (owner: 10Jdlrobson) [19:27:07] jgonera: PhotoUploaderButton.less - is that for the styling of the button on the uploads dashboard? [19:28:01] (03PS5) 10Jdlrobson: Separate stable and beta upload overlay code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92031 (owner: 10JGonera) [19:28:17] jdlrobson, that part did not change, I just split uploads.less into two separate files [19:28:25] it's styling of the upload button everywhere I think [19:28:51] but i think the only place there is an uploads button is the Special:Uploads page (not saying you introduced this i just think that's an opportunity to make this less confusing [19:30:03] brion: I'm also considering using http://square.github.io/dagger/ but not sold on it yet [19:30:09] (03CR) 10Jdlrobson: [C: 04-1] "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92031 (owner: 10JGonera) [19:30:42] jgonera: i think there's a minor mistake in that correct me if i'm wrong - can you check my commit message assesses the patch well and fix those 2 things up (and i'll merge)?^ [19:31:46] (03CR) 10Jdlrobson: "Also when visiting Special:Uploads in stable" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92031 (owner: 10JGonera) [19:31:49] jdlrobson, right, that's probably used only on special:uploads now that we have page actions... I forgot [19:31:50] brion: dagger doesn't have the performance penalty of most Java DI implementations, since it does stuff at compile time [19:32:15] about the other file, it should belong to the next commit... I'll try to rebase this but first I want to finish with the tutorial [19:32:43] (03CR) 10Jdlrobson: [C: 04-1] "Patch commit message mentions nearby (I got excited) but this looks like notification tests (I got sad :P)?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92488 (owner: 10Mgrover) [19:33:26] jgonera: np when you have time [19:33:35] also https://gerrit.wikimedia.org/r/#/c/92000/4/less/common/ui.less can we clear this up quickly so i can just fix it and be done with it? [19:33:36] ok, otto looks pretty easy to use :D [19:33:41] is my assessment here correct? [19:34:00] looks like we can either attach our activities/fragments directly or use anonymous inner classes easily either way [19:34:56] ^ jgonera [19:35:34] looking at dagger [19:36:06] yurik yyou there? [19:36:34] jdlrobson, yes, this is for this corner case, also, it might be for others, if your set your operating system colors to something else (so that your test inputs are not white background, which you can do anywehere besides Mac OS X), then some browsers will use that as their default background [19:36:55] ok so in that case i'm only going to apply the color to the body tag and remove the background on #mw-mf-page-center [19:37:06] jdlrobson, I don't have time now to analyze height: 100% but I would assume it's for either overlays, or position fixed fallback (or both) [19:37:30] (03PS5) 10Jdlrobson: Hygiene: Kill navigation.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92000 [19:37:36] jgonera: ok i've assumed overlays (but that was the reason for the FIXME - I just wanted to leave some kind of pointer) ^ [19:37:39] jdlrobson, I think that will cause the background to become dark grey if you open the left nav [19:37:51] jdlrobson, so maybe it should stay only in page-center [19:37:52] jgonera: negative [19:38:03] oh wait i see what you mean [19:38:07] ok i'll add a comment to that [19:38:31] no, it should be in both [19:38:52] because then if you open the menu, part of the background will be default system color when you open left nav ;) [19:39:17] (on short pages, tablet view) [19:39:42] jgonera: yeh i see that now - it's a little confusing. but in this case if i'm not mistaking the background color on body is only there for the purpose of overlays [19:39:48] since everything else has a background color.. [19:40:13] yeah but page-center might not be height 100% so then you need something under it to have color [19:41:20] jdlrobson: no idea at all [19:41:29] want me to poke around [19:42:26] YuviPanda: dagger is kinda bending my mind, looking more into it :) [19:42:50] brion: it is bending my mind a little too, hence trying to use it for a trivial use case [19:42:57] (03PS6) 10Jdlrobson: Hygiene: Kill navigation.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92000 [19:43:20] hehe [19:44:31] brion: hmm, it gives me a feeling of 'hmm, I seem to be overarchitecting this' :P [19:44:41] :D [19:44:45] brion: so i'm going to stash it and just do it the normal way for now [19:44:50] sounds good [19:44:56] jcmish: antoine or crinkle would be the best people to understand the jenkins qunit test [19:45:34] hehe crinkle [19:48:38] haha yeh spelling correct! [19:49:17] (03PS1) 10Dr0ptp4kt: Be stricter about inclusion of JS and CSS in case UA is feature phone. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92924 [19:49:36] hahaha [19:49:44] k I'll take that [19:50:04] ^^yurik [19:51:54] * jdlrobson off to get some lunch bbiab [20:01:54] (03PS2) 10Yurik: Excluded a number of common bots from the zero log, stricter css & js inclsion [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92824 [20:05:14] greg-g: weird that your invite got denied on the room. did you just book it? [20:05:31] i saved it about 25 ago [20:05:35] when i saw it availabel [20:06:42] (03CR) 10Dr0ptp4kt: [C: 032] Excluded a number of common bots from the zero log, stricter css & js inclsion [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92824 (owner: 10Yurik) [20:06:49] (03Merged) 10jenkins-bot: Excluded a number of common bots from the zero log, stricter css & js inclsion [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92824 (owner: 10Yurik) [20:10:22] tfinc: yeah, odd, it told me it was available when I checke dat 12:55 :/ whatever [20:12:10] (03Abandoned) 10Dr0ptp4kt: Be stricter about inclusion of JS and CSS in case UA is feature phone. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92924 (owner: 10Dr0ptp4kt) [20:19:09] brion: good comments! will adjust :) [20:23:01] \o/ [20:31:25] (03PS3) 10Yurik: Changed warning message for Zero [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/91787 [20:31:45] (03PS4) 10Yurik: Changed warning message for Zero [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/91787 [20:32:04] (03PS5) 10Yurik: New warning page [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90881 [20:41:43] * brion reads up on android 4.4 changes [20:41:54] new printing framework! [20:41:55] hah printing [21:17:32] (03PS1) 10Jdlrobson: Story 1301: Measure infobox view time [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92986 [21:17:53] jgonera: kaldari can you merge https://gerrit.wikimedia.org/r/92583 before today's deployment (not sure if branch was cut yet) [21:18:37] preview overlay completely broken in beta [21:18:51] live on all wikis in beta now [21:19:05] i was gonna ask kenanwang if he wanted to lightning deploy it [21:27:37] brion: YuviPanda mhurd : are you guys doing a commons release next week ? [21:27:50] I'd guess not [21:28:04] tfinc: nothing in the hopper presently [21:28:05] there are a couple of bugs we might want to fix in the License extractor code, but I'd skip this week [21:28:18] YuviPanda: then i leave it in your capable hands [21:28:24] :) [21:28:26] (03PS2) 10Jdlrobson: Story 1280 (1/2): Overhaul of image uploading overlay design [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92787 (owner: 10JGonera) [21:28:38] if thats the case then i'm thinking of just closing out the commons backlog and sprint boards [21:28:41] we had work in there [21:28:59] but honestly if were not releasing then its telling us that its not very important [21:29:41] YuviPanda: weird error: https://test.wikipedia.org/w/api.php [21:30:00] mhurd: the sites were broken [21:30:03] mhurd: are broken, actually :P [21:30:14] YuviPanda: ahh! [21:30:15] mhurd: blame marktraceur :P [21:30:15] * YuviPanda ducks [21:30:20] mhurd: they'll be unbroken shortly [21:30:29] Rawrrrr [21:30:48] YuviPanda: I'm afraid you win for now, though - it's not going out today, but tomorrow [21:31:12] marktraceur: heh, mhurd thought he broke it [21:31:23] marktraceur: that's what you said yesterday! [21:31:30] Orrrr Monday [21:31:33] brion: YuviPanda mhurd : thoughts on me closing all the commons boards/bug lists ? [21:31:44] i'm incline to just do it [21:31:49] and re-open if we actually need them [21:31:53] agreed [21:31:55] tfinc: sounds good [21:31:55] less clutter that way [21:32:11] if were not paying any attention to them then they need to go away [21:32:11] ko [21:32:12] ok [21:32:13] done [21:33:21] kaldari: jgonera would it now make sense for us to separate MobileFrontend.i18n.php into a languages folder as is done in core [21:33:24] that file is getting HUGE [21:36:33] tfinc: whee! go for it [21:37:15] * brion is trying out android 4.4 in emulator [21:40:30] ah crap i think i forgot to check 'use host gpu' [21:41:01] nope it's just slow :D [21:41:37] argh browser won't run in emu [21:41:44] maybe try a beefier hardware config [21:43:50] brion: do you understand AbuseFilter at all? https://gerrit.wikimedia.org/r/#/c/92266/ [21:44:55] (03CR) 10Jdlrobson: [C: 04-1] "(4 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92787 (owner: 10JGonera) [21:44:58] emulator crashed! sheesh today is not my day with the emu [21:45:15] jdlrobson: heh i'll take a look but no guarantees, not too familiar with AF [21:45:45] brion: http://commons.wikimedia.org/wiki/File:Emu-wild.jpg [21:45:58] :) [21:46:08] brion: i helped [21:46:13] brion: thanks - i just want to poke someone who knows it better than me so we can get it merged :) [21:46:29] if you can point me at someone better equipped that would be awesome [21:49:54] brion: i just mentioned to mhurd and YuviPanda that you guys have a week left for plumbing. none of the backlog on 11/12 should be a surprise so make sure to get what you can out of the way. especially if it drops estimates [21:50:47] excellent [21:50:52] we shall make many features :D [21:54:06] jdlrobson, that might be a good idea, that file is huge and takes a while to load for me with all the vim plugins that try to parse it [21:54:52] jgonera: i raised a bug so we don't forget to do it [21:54:58] maybe good exercise for hygiene days [21:55:07] agh i have to set up permissions for abusefilter beyond the defaults... heh [21:55:07] jgonera: i looked at the new image overlay code and made a few suggestions [21:55:11] jdlrobson, good [21:55:27] jdlrobson, ok, I'm almost done with the tutorial, there was a lot to clean up [21:55:45] jgonera: hah [21:55:49] this is another case of a story that was more than 8 points ;) [21:56:15] brion: the 4.4 AVD is taking forever to load for me [21:56:26] been waiting for 5minutes now with GPU turned on [21:58:34] so...much...cake! [22:01:10] brion: good point about op lifecycle - was actually just playing around with that exact issue [22:01:30] brion: Thanks for looking at the AbuseFilter stuff! [22:02:30] \o/ [22:02:41] brion: There are also a couple AntiSpoof fixes that could use your expert eyes :) [22:02:52] oh man [22:02:58] anti spoof brings me back to the olden days [22:03:17] iirc someone wrote PoC python code that i ported back to php to use :) [22:03:20] yeah, it doesn't look like anyone's touched AntiSpoof since you and Tim [22:03:43] (03PS1) 10MaxSem: Don't force WMF terms of use upon everyone [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92994 [22:04:24] brion: mhurd how are you guys going to represent page contents in the app? [22:04:28] Section and Page objects? [22:04:32] or just one huge string? [22:04:38] * YuviPanda is thinking of section and page objects [22:04:48] brion: i just gave up on the emu booting [22:04:53] not worth my battery [22:05:06] which is just sad [22:05:15] tfinc: yeah i can get it to boot but the browser doesn't launch o_O [22:05:24] FAIL [22:05:24] hopefully a point release on the sdk will be coming soon :D [22:05:46] YuviPanda: hmm prob see what jared thinks.. [22:05:56] mhurd: no, I mean, internally? [22:05:58] in the app? [22:07:15] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen) [22:08:26] MaxSem: apparently mediawiki api returns dates in form 20130730174438 which is even worse in JavaScript land.. [22:10:26] example? [22:10:47] I looked at it briefly for prop=revisions and it was iso [22:11:14] and grepping $IP/inludes/api shows that ISO is prevalent [22:13:01] MaxSem: https://en.m.wikipedia.org/w/api.php?format=json&action=mobileview&page=San%20Francisco&variant=en&redirect=yes&prop=lastmodified%7Csections%7Ctext&noheadings=yes§ionprop=lastmodified%7Clevel%7Cline%7Canchor§ions=all [22:13:22] aha, mobileview [22:13:41] well, we didn't have problems with it in the past? [22:13:43] so how should i handle this without breaking backwards compatibility? [22:13:49] MaxSem: we never used it in the past [22:14:01] Maybe the app was using it but mobile web never [22:14:03] I'm definitely eager to add a centralised setting for timestamp format [22:14:16] MaxSem: anything we can do as a short term measure? [22:14:19] mobile view is a special beast :) [22:14:43] api should in general use iso format yeah [22:14:52] ok [22:14:54] (03PS12) 10Jdlrobson: Hygiene: Eliminate api fixmes from PageApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen) [22:15:13] lemme double-check that the app doesn't use that field (i don't think it does) [22:15:27] (03CR) 10Jdlrobson: [C: 04-2] "Assumes ISO 8601 timestamp - but this is not the case" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen) [22:15:31] I don't see backend cards this iteration, so can assaulting it:P [22:15:42] MaxSem: that would be useful to get this unblocked [22:15:46] let me know when done so i can update this patch [22:15:50] *start* assaulting [22:15:59] it would be a good one to get fixed as the history link gets messed up when you edit a page [22:16:15] ok, current mobile app does not use the mobileview 'lastmodified' property [22:16:20] so feel free to change its format :D [22:16:50] brion, will be done smartassly [22:17:04] :) [22:18:07] there will be a general API parameter for TS format, with every module having a default format for b/c [22:18:41] so you'll do api.php?action=mobileformat×tamps=iso and voila! [22:18:54] ooooh [22:19:27] (03CR) 10Jdlrobson: [C: 04-1] "(3 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92994 (owner: 10MaxSem) [22:20:16] kaldari: jgonera did you see my mail about https://gerrit.wikimedia.org/r/92583 ? [22:20:20] running out of timezzz [22:20:32] (Nearby QA tests) [22:21:19] jdlrobson, nope, haven't seen it [22:21:22] (03PS2) 10Jdlrobson: Fix page previews on nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92583 [22:21:59] jgonera: is ken an in the office? if so can you tell him to get on irc [22:22:08] jdlrobson, what "this"? [22:22:18] jdlrobson, haven't seen him [22:22:31] jgonera: oh.. maybe he said he was away today [22:22:44] i remember him being away one day this week [22:22:56] MaxSem: that API parameter sounds lovely [22:23:11] (03CR) 10jenkins-bot: [V: 04-1] Fix page previews on nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92583 (owner: 10Jdlrobson) [22:23:31] (03PS2) 10MaxSem: Don't force WMF terms of use upon everyone [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92994 [22:24:25] (03CR) 10Kaldari: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92583 (owner: 10Jdlrobson) [22:25:16] (03CR) 10jenkins-bot: [V: 04-1] Don't force WMF terms of use upon everyone [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92994 (owner: 10MaxSem) [22:27:00] kaldari: in response to your comment: It essential switches to use JSONP when the wgNearbyEndpoint set - I can add this JavaScript comment if that makes sense? [22:27:28] btw jenkins is -1ing due to adding qunit support - working with hashar about this right now [22:28:09] jdlrobson: that makes sense, feel free to add something to that effect [22:30:09] (03PS3) 10Jdlrobson: Fix page previews on nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92583 [22:32:11] (03CR) 10jenkins-bot: [V: 04-1] Fix page previews on nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92583 (owner: 10Jdlrobson) [22:46:41] mm qunit jenkins fail [22:46:53] ": jdlrobson: you have the $wgDebugLogFile for both cli commands and apache on the build page https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-qunit-mobile/2/" [22:47:14] any idea what's exploding with jenkins anyone? [22:54:24] does anyone other than antoine and Krinkle|detached understand jenkins? [22:59:12] jdlrobson, "Exception thrown by mobile.stable.common: Cannot read property 'defaults' of undefined " enwiki, stable [22:59:27] jgonera: where are you getting that? [22:59:33] enwiki stable all pages? [22:59:34] enwiki, stable, main page [22:59:45] aww gawd [22:59:51] all pages [23:00:02] jgonera: any idea why? [23:00:07] not yet [23:00:10] ^ greg-g something wrong with latest deployment [23:00:17] which i assume is happening now [23:00:33] not on mediawiki.org - so maybe it's just teething problems? [23:00:34] * jdlrobson hopes [23:01:38] doesn't happen with debug=1 [23:02:58] those JS stact traces are useless now... [23:03:02] stack* [23:08:46] (03CR) 10Kaldari: [C: 031] Fix page previews on nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92583 (owner: 10Jdlrobson) [23:09:03] jenkins is angry [23:09:53] jgonera: could it be due to old JavaScript before templatePartials loading or something similar? [23:10:11] yes, likely, that's my best guess [23:10:40] i forget exactly what changed [23:11:45] jgonera: this points to using ResourceLoader to describe functionality [23:12:04] for example if we had Exception thrown by mobile.overlays at least we'd know where a bouts things were exploding [23:12:12] greg-g: you there? [23:12:32] desktop seems fine [23:12:57] reminds me of the older issues we had when files needed touching [23:13:12] jdlrobson, I think the JS stack trace should also point to the problem [23:13:19] yep, looks similar [23:13:34] jgonera: sure i don't doubt :) [23:18:49] (03PS3) 10Jdlrobson: Hygiene: Throw JS exception on bad template file rather than PHP exception. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91658 [23:20:29] jgonera: i can't locate anyone :( [23:20:33] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Throw JS exception on bad template file rather than PHP exception. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91658 (owner: 10Jdlrobson) [23:21:30] jdlrobson, who should I look for? [23:23:09] wikimedia-dev [23:23:14] #wikimedia-dev jgonera [23:24:48] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91658 (owner: 10Jdlrobson) [23:31:21] (03PS7) 10Jdlrobson: Hygiene: Kill navigation.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92000 [23:33:10] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Kill navigation.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92000 (owner: 10Jdlrobson) [23:34:53] Hey mobile people, I was just working with StevenW in #wikimedia-growth on some Special:GettingStarted stats for Sept. on Enwiki. [23:34:59] I thought I'd come share. [23:35:12] brion: i retooled and tweaked and think i may have nice way of chaining ops w/o having them report back to delegate/controller... will try chaining a third op to the 2 test cases and if it works i'll push a commit so you can check it out [23:35:20] Specifically, we were looking at the proportion of users who register and then have made an edit. [23:35:22] OK. Here's the breakdown. (autocreate is new filtered) Mobile: 6248/27534=22.7% edit rate. Desktop: 42983/123810=34.7% edit rate. [23:35:32] s/new/now [23:35:39] * halfak facepalms [23:36:00] jgonera: looks fixed now can you confirm? [23:36:13] jdlrobson: when will the monthly total contribs graph be up ? [23:36:23] tfinc: when YuviPanda or jgonera merge it.. [23:36:39] YuviPanda: jgonera --^ [23:36:41] * YuviPanda points at jgonera, slowly backs away from Limn [23:36:56] halfak: that's cool - so mobile is not quite there yet but getting there.. ;-) [23:37:07] dr0ptp4kt: https://gerrit.wikimedia.org/r/#/c/93006/ [23:37:10] jdlrobson, yes, it's fixed [23:37:13] drdee: https://gerrit.wikimedia.org/r/#/c/93006/ [23:37:14] halfak: can you summarize your findings on the mobile-l mailing list? Would be good to get them recorded [23:37:15] Yeah. I'm baffled at how successful mobile is! [23:37:26] Boo. I was just hoping to do this in passing. [23:37:31] thx yurik [23:37:33] Sure. :) [23:38:39] jdlrobson: Which is the right list? [23:38:45] -tech? [23:38:57] you can send to wikitech too yeh that would be cool :) [23:39:04] Hokay. [23:39:13] it will help make mobile more fashionable :) [23:40:53] yurik, you looking for a cursory review before adding ops? [23:41:09] dr0ptp4kt: yep [23:41:16] ^drdee [23:41:20] yurik, ok [23:43:40] YuviPanda: when do you fly out ? [23:43:55]