[00:09:16] jgonera: $wgResourceLoaderLESSImportPaths [00:18:44] (03PS1) 10Yuvipanda: Normalize page titles when creating PageTitle objects [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93623 [00:18:45] (03Merged) 10jenkins-bot: Style main page last modified link correctly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93410 (owner: 10Jdlrobson) [01:11:34] (03PS1) 10JGonera: Hygiene: Remove unused LESS mixin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93629 [01:18:11] (03PS4) 10MaxSem: Don't force WMF terms of use upon everyone [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92994 [01:22:37] (03PS4) 10JGonera: Remove uploads CTA [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93012 [01:22:38] (03PS4) 10JGonera: Remove uploads blue pointer tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93013 [01:22:40] (03PS9) 10JGonera: Separate stable and beta upload overlay code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92031 [01:22:40] (03PS4) 10JGonera: Story 1280 (2/2): Overhaul of image uploading overlay design [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93014 [01:22:41] (03PS7) 10JGonera: Introduce OverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92012 [01:22:42] (03PS6) 10JGonera: Story 1280 (1/2): Overhaul of image uploading overlay design [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92787 [01:23:02] jdlrobson, fixed that one thing in upload overlay overhaul and rebased everything ^ [01:24:44] (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove unused LESS mixin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93629 (owner: 10JGonera) [01:25:04] jgonera: did you just rebase? [01:25:19] I said you can +2 a few of them yourself if happy [01:25:21] e.g https://gerrit.wikimedia.org/r/#/c/92012/ [01:25:24] oh [01:25:30] and https://gerrit.wikimedia.org/r/#/c/92031/ [01:25:40] did you checkout the version i changed? [01:25:45] or did you rebase an older version? [01:26:05] oh crap... [01:26:08] jgonera: oh wait [01:26:11] now i'm confused [01:26:31] jgonera: for example https://gerrit.wikimedia.org/r/#/c/93404/ [01:26:34] I don't know how to do it now [01:26:42] I didn't know you separated thse patches [01:26:44] eek this is now a mess [01:26:47] I mean this patch [01:27:04] i don't know what i could have done differently… i commented on the relevant ones explaining what i had done [01:27:18] should i git review it again? [01:27:23] where is the other one then? [01:27:38] you say it's separated but I don't know where [01:27:54] i thought that was obvious from the dependencies.. [01:27:59] (03CR) 10Awjrichards: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92994 (owner: 10MaxSem) [01:28:13] (03Merged) 10jenkins-bot: Hygiene: Remove unused LESS mixin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93629 (owner: 10JGonera) [01:28:16] ok did you make any changes to Introduce OverlayNew or Hygiene: Button style cleanup on diff view [01:28:17] ? [01:28:23] maybe it was, how can I check dependencies of a previous patchset? [01:28:31] no and yes [01:28:48] (03PS8) 10Jdlrobson: Introduce OverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92012 (owner: 10JGonera) [01:28:49] (03PS2) 10Jdlrobson: Hygiene: Button style cleanup on diff view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93404 [01:29:07] https://gerrit.wikimedia.org/r/#/c/93404/ [01:32:55] (03CR) 10JGonera: [C: 032] Hygiene: Button style cleanup on diff view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93404 (owner: 10Jdlrobson) [01:33:26] (03Merged) 10jenkins-bot: Hygiene: Button style cleanup on diff view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93404 (owner: 10Jdlrobson) [01:35:18] (03PS1) 10Yuvipanda: Add static method to parse out PageTitle from an internal link [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93631 [01:35:50] (03PS3) 10Jdlrobson: Tweak main file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93589 (owner: 10MaxSem) [01:36:14] (03PS5) 10MaxSem: Don't force WMF terms of use upon everyone [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92994 [01:36:36] (03PS5) 10JGonera: Remove uploads CTA [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93012 [01:36:37] (03PS5) 10JGonera: Remove uploads blue pointer tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93013 [01:36:38] (03PS10) 10JGonera: Separate stable and beta upload overlay code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92031 [01:36:39] (03PS5) 10JGonera: Story 1280 (2/2): Overhaul of image uploading overlay design [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93014 [01:36:40] (03PS9) 10JGonera: Introduce OverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92012 [01:36:41] (03PS7) 10JGonera: Story 1280 (1/2): Overhaul of image uploading overlay design [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92787 [01:39:50] anybody in here at the yan zhu talk right now? [01:40:12] kaldari: i've got a question for yan zhu - can you ask for me? [01:40:30] sure [01:40:46] (03CR) 10Jdlrobson: [C: 032] Make $wgMFDeviceWidthTablet and $wgMFDeviceWidthMobileSmall configurable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93589 (owner: 10MaxSem) [01:41:38] kaldari: i live in an area where there is a tiny tech scene and an even smaller open source/'hacktivist' scene - i'd love to be able to participate from afar in some of the conversations/hackathons/etc that happen in places like the bay area. are there any of these events that are open to remote participation? [01:42:00] awjr: cool, I'll ask [01:42:04] thanks! [01:42:13] kaldari, is the talk over? [01:42:27] (03Merged) 10jenkins-bot: Make $wgMFDeviceWidthTablet and $wgMFDeviceWidthMobileSmall configurable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93589 (owner: 10MaxSem) [01:42:46] jgonera: still going on [01:46:32] sweet thank kaldari! [01:46:53] er thanks [01:48:25] NP [02:01:50] (03PS1) 10Yuvipanda: Move webView initialization into the Bridge code [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93632 [02:19:22] (03CR) 10Awjrichards: [C: 032] Don't force WMF terms of use upon everyone [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92994 (owner: 10MaxSem) [02:19:54] (03Merged) 10jenkins-bot: Don't force WMF terms of use upon everyone [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92994 (owner: 10MaxSem) [02:36:06] (03PS2) 10Yuvipanda: Handle links being clicked [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93422 [02:36:28] (03PS3) 10Yuvipanda: Do not keep all of past page fragments fully in memory [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93423 [02:36:32] (03PS3) 10Yuvipanda: Handle external links [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93424 [02:36:36] (03PS2) 10Yuvipanda: Normalize page titles when creating PageTitle objects [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93623 [02:36:40] (03PS2) 10Yuvipanda: Add static method to parse out PageTitle from an internal link [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93631 [02:36:45] (03PS2) 10Yuvipanda: Move webView initialization into the Bridge code [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93632 [02:38:31] (03PS3) 10Yuvipanda: Move webView initialization into the Bridge code [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93632 [02:38:32] (03PS3) 10Yuvipanda: Normalize page titles when creating PageTitle objects [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93623 [02:38:33] (03PS4) 10Yuvipanda: Handle external links [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93424 [02:38:34] (03PS3) 10Yuvipanda: Add static method to parse out PageTitle from an internal link [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93631 [02:38:35] (03PS3) 10Yuvipanda: Handle links being clicked [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93422 [02:38:36] (03PS4) 10Yuvipanda: Do not keep all of past page fragments fully in memory [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93423 [02:43:50] (03PS4) 10Catrope: Move webView initialization into the Bridge code [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93632 (owner: 10Yuvipanda) [02:43:51] (03PS4) 10Catrope: Normalize page titles when creating PageTitle objects [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93623 (owner: 10Yuvipanda) [02:43:52] (03PS5) 10Catrope: Handle external links [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93424 (owner: 10Yuvipanda) [02:43:53] (03PS4) 10Catrope: Add static method to parse out PageTitle from an internal link [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93631 (owner: 10Yuvipanda) [02:43:54] (03PS4) 10Catrope: Implement a JS <-> Java bridge [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93420 (owner: 10Yuvipanda) [02:43:55] (03PS4) 10Catrope: Handle links being clicked [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93422 (owner: 10Yuvipanda) [02:43:56] (03PS5) 10Catrope: Do not keep all of past page fragments fully in memory [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93423 (owner: 10Yuvipanda) [02:49:54] (03PS5) 10Yuvipanda: Move webView initialization into the Bridge code [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93632 [02:49:55] (03PS5) 10Yuvipanda: Normalize page titles when creating PageTitle objects [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93623 [02:49:56] (03PS6) 10Yuvipanda: Handle external links [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93424 [02:49:58] (03PS5) 10Yuvipanda: Add static method to parse out PageTitle from an internal link [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93631 [02:49:58] (03PS5) 10Yuvipanda: Implement a JS <-> Java bridge. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93420 [02:49:59] (03PS5) 10Yuvipanda: Handle links being clicked [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93422 [02:50:00] (03PS6) 10Yuvipanda: Do not keep all of past page fragments fully in memory [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93423 [02:56:40] (03CR) 10Yuvipanda: "I just moved the webview setup code to the bridge itself in a later commit(Icbe24d1306c89a9bfe87bff91ca7a5745986136e), since the bridge is" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93420 (owner: 10Yuvipanda) [03:01:16] (03PS6) 10Yuvipanda: Move webView initialization into the Bridge code [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93632 [03:01:16] (03PS6) 10Yuvipanda: Normalize page titles when creating PageTitle objects [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93623 [03:01:18] (03PS7) 10Yuvipanda: Handle external links [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93424 [03:01:19] (03PS6) 10Yuvipanda: Add static method to parse out PageTitle from an internal link [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93631 [03:01:20] (03PS6) 10Yuvipanda: Handle links being clicked [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93422 [03:01:21] (03PS7) 10Yuvipanda: Do not keep all of past page fragments fully in memory [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93423 [14:01:30] (03CR) 10MaxSem: "(1 comment)" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/91787 (owner: 10Yurik) [14:43:20] (03CR) 10Siebrand: [C: 031] "Trivial i18n/L10n." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93012 (owner: 10JGonera) [14:56:14] (03CR) 10MaxSem: [C: 04-1] "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93430 (owner: 10Jdlrobson) [17:49:28] (03PS10) 10Jdlrobson: Introduce OverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92012 (owner: 10JGonera) [17:51:18] (03PS11) 10Jdlrobson: Introduce OverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92012 (owner: 10JGonera) [17:52:27] (03CR) 10Jdlrobson: [C: 032] Introduce OverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92012 (owner: 10JGonera) [17:52:54] (03PS11) 10Jdlrobson: Separate stable and beta upload overlay code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92031 (owner: 10JGonera) [17:53:03] (03Merged) 10jenkins-bot: Introduce OverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92012 (owner: 10JGonera) [17:54:54] (03CR) 10Jdlrobson: [C: 032] Separate stable and beta upload overlay code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92031 (owner: 10JGonera) [17:55:24] (03PS8) 10Jdlrobson: Story 1280 (1/2): Overhaul of image uploading overlay design [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92787 (owner: 10JGonera) [17:55:30] (03Merged) 10jenkins-bot: Separate stable and beta upload overlay code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92031 (owner: 10JGonera) [17:57:47] (03CR) 10Jdlrobson: [C: 031] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92787 (owner: 10JGonera) [17:58:00] (03PS6) 10Jdlrobson: Remove uploads CTA [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93012 (owner: 10JGonera) [17:58:05] (03CR) 10Jdlrobson: [C: 032] Remove uploads CTA [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93012 (owner: 10JGonera) [17:58:14] (03PS6) 10Jdlrobson: Remove uploads blue pointer tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93013 (owner: 10JGonera) [17:58:19] (03CR) 10Jdlrobson: [C: 032] Remove uploads blue pointer tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93013 (owner: 10JGonera) [18:02:28] yurik: you there? [18:24:26] jdlrobson: what's up [18:24:43] just wondered about the https bug on beta labs and what needs to happen to get that fixed [18:25:16] greg-g: was taking that back on [18:25:29] kaldari: they made a change so it steps forcing you into https [18:25:42] does that work for you now? Or is are you still getting redirected to https? [18:25:55] let's see [18:26:45] btw eek regression https://en.m.wikipedia.org/w/index.php?title=Special:Watchlist&watchlistview=feed&filter=all [18:27:26] Yay, it works now :) [18:28:05] sweet kaldari :D so that's the work around while they get the certificate fixed [18:28:24] cool [18:28:42] and the tests will be green when I commit the notification changes.. chrismcmahon gave me a way to skip tests I just need to make the changes [18:28:55] then I'll get them committed and have you guys review [18:29:31] hey jcmish [18:29:38] howdy! [18:29:53] I'm reading up on try/catch rescue [18:31:29] weee [18:31:33] brb need to snag a bite [19:11:27] jdlrobson: https://code.stypi.com/e9nfcdtk [19:15:01] kaldari: jcmish jgonera > broken :( https://en.m.wikipedia.org/w/index.php?title=Special:Watchlist&watchlistview=feed&filter=all [19:15:32] (https://bugzilla.wikimedia.org/show_bug.cgi?id=56625) [19:15:37] ? [19:15:44] Wfm [19:16:04] see attachment [19:16:06] works fine in Firefox :) [19:16:12] ui bug [19:16:24] true it does work in FF :) [19:16:42] Chrome only? [19:16:50] and safari [19:16:59] possibly only on big screens [19:17:05] what are you looking at it in? [19:17:11] ah Chrome [19:18:24] hmm, I can't reproduce in Chrome either [19:20:00] I think it's another candidate for display: table so that we avoid such issues [19:20:20] (03CR) 10Jdlrobson: [C: 031] "Looks good to me Max - thanks for fixing it!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93514 (owner: 10Jdlrobson) [19:20:37] going to the office, be back in 30min [19:21:16] jdlrobson: BTW, if you want to ask Jan about his coding task at all, here is his code: https://github.com/SunSurfer/mwtest1 [19:21:27] (03PS2) 10Jdlrobson: Regression: Error styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93406 [19:22:03] thanks kaldari - should be okay [19:25:36] (03CR) 10Brion VIBBER: "(2 comments)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93623 (owner: 10Yuvipanda) [19:26:44] (03CR) 10Brion VIBBER: "(2 comments)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93631 (owner: 10Yuvipanda) [19:28:35] brion: pay no attention to the fact that Roan now has some patchsets. we were just investigating a gerrit issue [19:28:45] :) [19:34:49] mhurd: my name isn't actually on the list, but I signed it anyway :P [19:35:02] YuviPanda: nice :) [19:36:41] hey chrismcmahon [19:36:47] so question about rescue [19:36:58] brion: why does the API prefer spaces? [19:36:59] hi jcmish [19:37:05] howdy [19:37:13] YuviPanda: they're prettier? i dunno :D [19:37:20] so if I say that if echo is not enabled then do the rescue in that clause [19:37:30] it won't run the other steps in the scenario? [19:37:43] or would I have to put a rescue in each? [19:37:49] haha, the API optimizes for prettiness? [19:38:29] YuviPanda: if you try using the _ form you'll find that it normalizes it to the " " form: https://en.wikipedia.org/w/api.php?action=query&prop=info&titles=Main_Page&format=jsonfm [19:38:43] brion: ah [19:38:52] brion: so I guess I can get rid of the \s+ replacement there [19:38:57] also ZWNJ issues, etc [19:39:04] jcmish: rescue is a Ruby thing not a test thing. if the begin() clause returns false, rescue() runs whatever block is inside rescue() [19:39:14] ah okay [19:39:20] jcmish: I think the Java equivalent is try/catch [19:39:24] YuviPanda: hopefully we can leave those to the server yeah \o/ [19:39:30] as long as we don't try to compare titles for equality locally [19:39:30] brion: also re: URL Decoding, I think we should decide to do that at whatever point receives it from the JS ridge [19:39:46] k thanks chrismcmahon [19:39:56] brion: heh, we can write a custom equals method for PageTitle that'll take care of that [19:40:13] YuviPanda: so that makes sense to me *if* that same point decomposes the URL (/wiki/Foo?bar=baz -> /wiki/ + (title "Foo") + parameter "bar"="bas") [19:40:26] an equals method really shouldn't do a server round trip [19:40:29] that way lies madness ;) [19:40:45] jcmish: in the past I used rescue() when I did not care if the begin() clause was true or not. for example, if I have to dismiss a popup that may or may not be there in order for the test to run [19:41:08] re URI decoding: don't forget that ? and & are valid in page titles [19:41:11] gotcha so really if echo isn't enabled then bail [19:41:12] and + [19:41:21] and %, as long as it's not followed by two hex digits :P [19:41:23] but otherwise keep moving for everything in the block [19:41:29] brion: reduce the madness [19:41:30] brion: lol :P [19:41:45] jcmish: yes, if whatever you're checking isn't there, then just do some other thing, or nothing at all. [19:41:50] brion: and yea, equals should be based off the page object contents itself, which I think are just NS and Text. so no server call :P [19:42:11] got it [19:42:15] yeah, let's leave a simple .equals() that is explicitly non-normalized [19:43:15] brion: yeah, I tink we should add it when we feel the need, rather than right now [19:43:21] *nod* [19:43:35] if we can't be bothered to write tests for it and don't need it for something else, don't write it :D [19:43:42] yeah [19:43:43] :D [19:44:47] mhurd: I'm wondering if we can simplify the async testing by writing a function that wraps the async code in a block [19:44:54] maybe pass it a block to run on completion [19:44:58] and encapsulate the runloop trick in that [19:45:37] brion: hhmmm... i'll play with it [19:45:48] spiffy :D [19:46:09] brion: thoughts on null vs "" for mainspace? [19:46:23] brion: we could also have a NAMESPACE_MAIN constant [19:46:23] i'm liking the NSOperations... just slap a completion block on it and it runs :D [19:46:24] brion: presently i'm adding a couple non-unit tests to the code - more comprehensive stuff [19:46:36] brion: ya is nice :) [19:47:00] YuviPanda: i slightly prefer "" .... or we could wrap namespaces in a class and have a special main value :) [19:47:12] * brion hmms [19:47:38] in general though namespaces could be tricky, unless we can get the list of available namespaces and aliases on the site from the server [19:47:58] when we're given a page title in single-string form like "Star Trek: The Next Generation"... [19:48:12] how do we know whether "Star Trek:" is a namespacec or part of the text? [19:48:25] MediaWiki knows because it has internal state with the namespace lists [19:48:46] i'm almost wondering if we should leave namespaces as an opaque internal detail [19:48:58] when they're exposed on the API at all, it's with a number [19:49:29] only times we really need them are: [19:49:36] 1) special handling of some namespaces [19:49:45] 2) making Talk/subject page links [19:49:52] and there may be a better way to do both [19:50:00] (03PS7) 10Yuvipanda: Move webView initialization into the Bridge code [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93632 [19:50:01] * brion checks API response details for page info & revisions [19:50:01] (03PS7) 10Yuvipanda: Make the PageTitle object follow design of MW's Title object. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93623 [19:50:02] (03PS7) 10Yuvipanda: Add static method to parse out PageTitle from an internal link [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93631 [19:50:24] brion: modified the normalizing behavior [19:51:25] https://en.wikipedia.org/w/api.php?action=query&prop=info&titles=Talk:Star%20Trek:%20The%20Next%20Generation&format=jsonfm <- this page 'info' chunk exposes the title as an opaque blob ('Talk:' and "Star Trek:" both appear in there with no differentiation), and exposes the namespace identifier simply as a number [19:52:01] meh [19:52:05] my bouncer crashed [19:52:06] !logs [19:52:43] https://en.wikipedia.org/w/api.php?action=mobileview&page=Talk:Star_Trek:%20The%20Next%20Generation&format=jsonfm&prop=normalizedtitle|text|sections|lastmodified <- action=mobile view doesn't currently expose the namespace at all [19:52:56] it's just an opaque part of the title [19:52:57] !ping [19:53:15] wm-bot2: poke poke [19:53:19] bouncer's back again [19:53:22] \o/ [19:53:58] brion: hmm, so we *could* do that - treat the title as just a string, rather than NS:Title [19:54:54] YuviPanda: yeah i think the way to go may be "opaque title object" plus "some namespace info object which can do transformations when we explicitly need it" [19:55:03] which could be initialized with the meta site info from the api [19:55:09] right [19:55:10] so we don't have to hardcode in language translations of namespaces [19:55:38] brion: I'm also wondering when we'll need to do transformations on titles based on ns at all [19:57:13] YuviPanda: finding the associated talk page (or vice-versa) is the only thing i can think of [19:57:27] and there might be an api way to do that, i'm not sure offhand [19:59:16] the hell? https://en.wikipedia.org/w/api.php?action=query&prop=info&titles=Main%20Page&format=jsonfm&inprop=talkid <- you can get the talk/subject page via prop=info BUT IT GIVES YOU A PAGE ID NOT A TITLE [19:59:19] * brion stabs API [20:02:35] meh, shitty bouncer [20:05:13] awjr: how are we doing at moving other mingle customers to the hosted instance ? [20:05:25] tfinc: i haven't gotten the OK from erik yet [20:05:44] last i heard we are waiting on getting the testimonial for thoughtworks finished [20:06:00] i spoke with the woman doing it last week and gave her my edits, but havent heard anything since [20:06:10] k [20:06:43] awjr: is there a way i can have mingle shows me the beg / end sprint dates when looking at the story wall ? [20:07:07] hmm [20:07:29] ok i'm going to grab some lunch then redo the PageTitle class on iOS to treat internals as opaque [20:07:40] and then finish up the other half of the bridge communication :D [20:07:58] tfinc there probably is but it is probably not elegant [20:08:28] you don't have a lot of control over the interface elements, but you have huge control over the cards that show up and how they are displayed [20:10:04] yeah, i cant think of a good way to do it in a card-view like the story wall [20:10:30] but you could totally set something like that up on a page and use a macro [20:11:01] dunno if you saw my msgs tfinc [20:11:01] tfinc there probably is but it is probably not elegant [20:11:01] 1:08 [20:11:01] you don't have a lot of control over the interface elements, but you have huge control over the cards that show up and how they are displayed [20:11:01] 1:10 [20:11:02] yeah, i cant think of a good way to do it in a card-view like the story wall [20:11:07] but you could totally set something like that up on a page and use a macro [20:18:37] awjr: can *i* easily do that? really what i care about is when can i anticipate most cards being done *if* i don't know sprint end dates [20:20:18] brion: re: URL Decoding, I think that should be in LinkHandler.java [20:20:23] (03PS1) 10MaxSem: [Card 1366] Add page image to last edited information [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93801 [20:20:24] brion: and not PageTitle [20:20:28] tfinc you can always look at the 'iteration' card (at least for mobile web) https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1310 [20:21:01] tfinc there is a lot of customization you can do; but afaik there is no way to get what you're talking about for free [20:21:40] tfinc: you'll notice that our iteration cards have fields for start date/end date; but we haven't been setting them [20:22:45] awjr: if we set it ... will it show up when looking at the story wall? [20:23:44] no, at least not on our story wall - like i said before there may be some way to make it happen but i cant think of an easy way off the top of my head [20:23:49] brion: meh, bouncer dead again [20:24:12] brion: I'm thinking that the URLDecoding stuff should be in LinkHandler and not PageTitle [20:24:12] tfinc the story wall is basically just a saved query for different card types - mingle itself doesn't really have a concept of 'story wall' [20:25:37] probably the right/easiest place to do what you're talking about is on the main page of the project, which for mobile web is the 'overview' page [20:25:41] https://wikimedia.mingle.thoughtworks.com/projects/mobile/overview [20:26:09] we haven't really done anything with that page; the graphs are out of date with the exception of the 'current iteration' chart [20:28:50] (03PS6) 10Awjrichards: Story 1280 (2/2): Overhaul of image uploading overlay design [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93014 (owner: 10JGonera) [20:31:57] jdlrobson: have you/juliusz had a chance to sync up with kenan/design RE https://gerrit.wikimedia.org/r/#/c/92787/8 ? [20:32:06] that patchset is holding up a ton of stuff [20:32:21] yo jgonera [20:32:27] a bunch of which has been already submitted, so if there are further changes to 92787 you guys are going to be in a world of git hurt [20:32:35] DarTar, are you at your desk? [20:32:37] are you at your desk? [20:32:40] ha ha [20:32:45] yes ;) [20:32:45] coming over [20:32:58] jgonera: just missed a msg i posted for you/jon: have you had a chance to sync up with kenan/design RE https://gerrit.wikimedia.org/r/#/c/92787/8 ? [20:33:14] ok, will check after I talk with Danny_B [20:33:18] DarTar... [20:33:32] w00t [20:34:16] yes? [20:45:33] brion: ping? [20:46:53] (03PS8) 10Yuvipanda: Move webView initialization into the Bridge code [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93632 [20:47:05] YuviPanda: pong [20:47:06] awjr_lunch: kenan : do you guys need my help to fill this out https://www.mediawiki.org/wiki/Wikimedia_engineering_report/2013/October#Mobile ? [20:47:22] YuviPanda: yeah that probably makes sense [20:47:29] LinkHndler knows it's dealing with a URL [20:47:32] PageTitle shouldn't have to [20:48:16] brion: yup [20:48:38] brion: so I'm going to add a test for the bridge now, as a separate commit [20:48:53] brion: is there anything else I need to do in the current sets of commtis? [20:48:59] brion: it's getting pretty long :P [20:49:18] YuviPanda: sounds good... i'll make a wrap-up set of notes if there's anything outstanding [20:49:18] brion: URL Decoding will also be a separate commit, since I don't want to do it before it can be testable, and the js bridge tests need to exist for that [20:49:26] brion: okay! [20:49:27] ok :) [21:11:57] brion: yuvipanda : mhurd : heads up that kenan has started seeding the backlog for sprint 18 https://trello.com/b/buxMRu19/mobile-app-sprint-18 .. take a peek to see what's coming up. all subject to change before thursday [21:12:16] whee [21:12:20] i think his choices make a lot of sense [21:12:26] and should tie nicely into our plubming [21:13:53] nice [21:13:57] yeah that's a good starting set [21:21:04] brion: have a working test case for the bridge! \o/ [21:21:07] will add more test cases and commit [21:21:10] woohoo! [21:21:48] (03CR) 10Brion VIBBER: [C: 032 V: 032] "add'l tests & cleanup to come in future commits!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93420 (owner: 10Yuvipanda) [21:21:52] lemme finish these up [21:21:56] nice! [21:23:37] (03CR) 10Brion VIBBER: [C: 032 V: 032] "(1 comment)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93422 (owner: 10Yuvipanda) [21:23:52] little note on the js in that one [21:24:15] (03CR) 10Brion VIBBER: [C: 032 V: 032] Do not keep all of past page fragments fully in memory [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93423 (owner: 10Yuvipanda) [21:24:24] brion: shouldn't they bubble up automatically? [21:24:44] YuviPanda: they bubble up, but the target object is different [21:24:44] iirc [21:24:49] aaah [21:24:50] anyway we should just double-check that later [21:24:50] got it [21:24:52] yeah [21:25:17] brion: this is the first time I'm working on JS without jQuery. lots of looking up things :D [21:25:41] (03CR) 10Brion VIBBER: [C: 032 V: 032] Handle external links [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93424 (owner: 10Yuvipanda) [21:25:47] hehe [21:26:00] modern DOM js isn't that bad, without the IE back-compat crap [21:26:13] though sometimes methodNamesAreREallyLong [21:26:32] $('#foo') <-> document.getElementById('foo') [21:27:09] but you're doing java so you're used to that ;) [21:27:27] brion: yeah [21:27:29] hehe [21:27:44] i looooove having tests integrated in the ide [21:27:49] (03CR) 10Jdlrobson: [C: 04-1] "(6 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92986 (owner: 10Jdlrobson) [21:28:09] kaity|away you there? [21:28:22] MaxSem: any ideas on how to fix https://gerrit.wikimedia.org/r/91532 [21:28:33] jcmish: any progress on nearby automation tests? [21:29:01] some jdlrobson heads down on something [21:29:26] (03CR) 10Brion VIBBER: [C: 032 V: 032] "We're gonna change this to drop the namespace handling and normalization (leave those to the server, which knows more about the wiki confi" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93623 (owner: 10Yuvipanda) [21:29:45] kaldari jgonera: needs to be merged before thursday cut off https://gerrit.wikimedia.org/r/93406 [21:30:20] (03PS5) 10Jdlrobson: fix Nearby overlay automation test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92488 (owner: 10Mgrover) [21:30:56] (03CR) 10Brion VIBBER: [C: 032 V: 032] "We're going to change this one as well in another commit; will move the URL handling to the LinkHandler to keep it distinct from titles th" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93631 (owner: 10Yuvipanda) [21:31:30] (03CR) 10Brion VIBBER: [C: 032 V: 032] Move webView initialization into the Bridge code [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93632 (owner: 10Yuvipanda) [21:31:50] YuviPanda: ok i think that's the last of em [21:31:57] wooo [21:32:13] brion: I'm adding an injectScript method that lets us inject scripts at runtime [21:32:21] brion: will help with testing [21:32:23] and other things [21:32:46] ah nice [21:32:56] (03CR) 10jenkins-bot: [V: 04-1] Fix notification overlay automation test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92488 (owner: 10Mgrover) [21:34:51] (03CR) 10JGonera: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92787 (owner: 10JGonera) [21:38:50] MaxSem: what word would you suggest in place of 'member' ? [21:39:31] * brion ponders PageTitle class again [21:39:47] maybe rather than a *title* we need a page reference object... [21:40:09] that could pair the wiki identifier like the language along with the opaque title string [21:40:22] jdlrobson, "registered since"? [21:40:23] and we could then easily store those as history entries [21:41:11] jdlrobson, my patchset that allows to set TS formats have met some resistance - how many vrowsers don't really supprot ISO 8601? [21:47:40] brion: thoughts on naming convention for event names? [21:47:51] brion: first letter capital - yes or no? [21:50:29] I think JS in general goes with 'no' [21:50:33] so I'll go with that too [22:01:15] (03PS1) 10Yuvipanda: Add test cases for CommunicationsBridge [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93863 [22:01:18] brion: ^ [22:01:24] brion: tests two way! [22:01:59] (03CR) 10JGonera: "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92986 (owner: 10Jdlrobson) [22:05:26] (03PS2) 10Yuvipanda: Add test cases for CommunicationsBridge [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93863 [22:06:30] brion: going to head out for lunch. brb [22:08:51] brion: do look at the js for injecting a script too. Not sure if that's how it has to be done or if there are better ways [22:08:58] now for food [22:09:34] MaxSem: as stated in that patch it's not returning ISO 8601 :) [22:09:47] that is easily fixable [22:10:18] that's the thing we need to fix whilst maintaining backwards compatibility with anyone who might be relying on the current format [22:10:38] it returns in format 20131105141000 [22:14:42] (03CR) 10Kaldari: [C: 04-1] "One problem. If Selenium fails to actually log into the wiki, all of these tests will still pass." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92488 (owner: 10Mgrover) [22:20:06] kaity|away: ping [22:20:08] violetto: ping [22:20:18] UserProfile page - does it need to have a footer? [22:20:26] jdlrobson: what kind of footer [22:20:33] the same footer as on normal pages [22:20:42] (03CR) 10Jdlrobson: "(3 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93430 (owner: 10Jdlrobson) [22:21:02] (03PS2) 10Jdlrobson: Begin Special:UserProfile overhaul [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93430 [22:21:16] jdlrobson: hang [22:22:05] jdlrobson: yes, the cc by sa and privacy stuff right [22:22:41] violetto: ok so it should look identical to a normal page? [22:23:49] jdlrobson: im thinking the footer should be available because the profile page's content is also udner the same license? [22:24:20] page shouldn't feel identical to an article page, but should have somewhat of the same structure [22:25:20]