[00:00:14] the one i used in the design is smaller than 80x80 [00:00:21] can you scale it down? [00:02:42] kaity: yeah, that works fine! Thanks! [00:08:08] (03CR) 10Jdlrobson: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen) [00:08:32] (03PS2) 10Yurik: Make clicks on "Yes" for Desktop interstitial redirect properly. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/93893 (owner: 10Dr0ptp4kt) [00:09:26] jdlrobson: now that the i18n issue is cleared up what's holding back merge of https://gerrit.wikimedia.org/r/#/c/92787/8? [00:09:36] * jdlrobson looks [00:09:44] awjr: doing that now [00:09:48] :D [00:09:50] leave it with me [00:09:59] far out [00:11:32] (03PS9) 10Jdlrobson: Story 1280 (1/2): Overhaul of image uploading overlay design [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92787 (owner: 10JGonera) [00:11:54] (03CR) 10Jdlrobson: [C: 032] "Tweaked the message after discussion with Kenan and Juliusz. It's on." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92787 (owner: 10JGonera) [00:12:48] (03CR) 10Yurik: "PS2 is a minor formatting fixes (new line and removed space at the end before ";")." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/93893 (owner: 10Dr0ptp4kt) [00:12:54] (03CR) 10Jdlrobson: [C: 04-1] "Noticed we still define wgMFEnablePhotoUploadCTA which should be removed. Fixing now." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93012 (owner: 10JGonera) [00:12:56] (03Merged) 10jenkins-bot: Story 1280 (1/2): Overhaul of image uploading overlay design [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92787 (owner: 10JGonera) [00:13:13] (03CR) 10MaxSem: "Caching." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen) [00:15:48] MaxSem: are you sure? I killed memcached and hard refreshed numerous times [00:16:42] (03PS7) 10Jdlrobson: Remove uploads CTA [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93012 (owner: 10JGonera) [00:16:50] (03CR) 10Jdlrobson: [C: 032] Remove uploads CTA [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93012 (owner: 10JGonera) [00:17:07] (03PS7) 10Jdlrobson: Remove uploads blue pointer tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93013 (owner: 10JGonera) [00:17:11] (03CR) 10Jdlrobson: [C: 032] Remove uploads blue pointer tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93013 (owner: 10JGonera) [00:17:17] (03PS7) 10Jdlrobson: Story 1280 (2/2): Overhaul of image uploading overlay design [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93014 (owner: 10JGonera) [00:17:36] jdlrobson, yep - just checked again:) try another page;) [00:18:04] MaxSem: anything we can do to ensure it doesn't cache? as this has serious effects on the UI (e.g. breaks the rendering of the last modified timestamp) [00:18:16] MaxSem: just finishing reviewing the upload stuff and i'll be right back on it [00:19:06] jdlrobson, cache version has been incremented, you just have stuff cached by a previous PS of that change [00:19:20] (03Merged) 10jenkins-bot: Remove uploads CTA [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93012 (owner: 10JGonera) [00:19:44] MaxSem: so why is my cache ignoring it? [00:19:52] 1 sec [00:21:30] (03Merged) 10jenkins-bot: Remove uploads blue pointer tutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93013 (owner: 10JGonera) [00:22:15] (03PS14) 10MaxSem: Hygiene: Eliminate api fixmes from PageApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen) [00:22:15] argh, another code path [00:23:58] (03CR) 10CSteipp: "Without knowing the code, this looks wrong. Why is the href encoded with htmlspecialchars? Decoding a valid url and then writing it back c" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/93893 (owner: 10Dr0ptp4kt) [00:24:21] (03CR) 10Jdlrobson: [C: 04-1] "As discussed, visiting Special:Uploads in stable with no uploads no longer shows the blue tutorial - a change not specified in the commit " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93014 (owner: 10JGonera) [00:24:36] ok MaxSem looking now.. [00:25:25] MaxSem: still seeing the problem - did you say you found another code path? [00:26:04] yes - https://gerrit.wikimedia.org/r/#/c/91532/13..14/includes/api/ApiMobileView.php [00:30:59] MaxSem: i don't know what's going on - still seeing the old timestamp [00:31:04] could there be something odd about my setup? [00:31:18] CACHE_DB? [00:31:22] oh wait…nowww it's working [00:31:38] let me just double check [00:33:33] MaxSem: needs a bit more debugging [00:33:45] how to repro? [00:34:03] MaxSem: in alpha load a page via search [00:34:09] it's always showing just edited now [00:34:14] i'm looking now [00:35:30] MaxSem: probably a frontend problem.. [00:38:34] ahh.. MaxSem it's because PHP does unix time in seconds not ms :) [00:39:37] unix time in ms? Netscapers must've been abusing drugs really hard when they invented this [00:40:07] MaxSem: fix on the way :) [00:40:26] (03PS15) 10Jdlrobson: Hygiene: Eliminate api fixmes from PageApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen) [00:40:47] (03CR) 10Jdlrobson: [C: 031] Hygiene: Eliminate api fixmes from PageApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen) [00:40:51] ^ MaxSem +2 ? [00:41:39] (03CR) 10MaxSem: [C: 032] Hygiene: Eliminate api fixmes from PageApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen) [00:41:54] brion: ping? [00:41:55] I rounded it up:P [00:42:05] YuviPanda: yo [00:42:15] (03Merged) 10jenkins-bot: Hygiene: Eliminate api fixmes from PageApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/91532 (owner: 10Robmoen) [00:42:36] (03CR) 10Jdlrobson: [C: 032] Set wgArticleId correctly after a page is dynamically loaded [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93885 (owner: 10JGonera) [00:43:12] (03Merged) 10jenkins-bot: Set wgArticleId correctly after a page is dynamically loaded [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93885 (owner: 10JGonera) [00:43:19] brion: so I'm thinking of the site object [00:43:25] brion: a domain name is all that is needed [00:43:42] brion: since it encapsulates all the info (lang (if applicable!) and project) [00:43:54] for now that should do yeah [00:44:25] brion: yeah, I was thinking of making it be encapsulated as lang + project, but commons has no language... [00:44:28] neither does wikidata [00:44:53] on the other hand if we pull in wiktionary or wikisource or such, those'll have a language and we'd want the matching one usually [00:45:07] but that could be a meta-property :D [00:46:15] brion: yeah [00:46:32] brion: I think we can have a constructor service of some sort that can construct it given a project + language [00:46:33] or just project [00:46:45] brion: but the object itself... I think domain is enough [00:46:59] hmm, or maybe not [00:47:02] * YuviPanda thinks some more [00:47:07] yeah [00:47:12] heh [01:08:51] marktraceur, is it easy to make license fetching work on any instance of mediawiki? I applied Gergo's patch but I'm still not getting any license info on my local dev instance [01:15:43] jgonera: Short answer no. [01:15:57] jgonera: The information template takes, like, five minutes to parse on a normal dev machine [01:15:59] marktraceur, I was hoping for something better ;) [01:16:08] Sorry [01:16:15] hm [01:16:21] jgonera: I've tested using categories, but not with license templates [01:16:27] I see [01:16:27] I guess you can use a barebones version [01:17:15] (03PS1) 10Yuvipanda: Add Site object, make it part of PageTitle [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93906 [01:17:16] brion: ^ [01:17:32] brion: anything I missed before I go on to search? [01:17:49] brion: the creation part is stubbed out to be always enwiki, because we need a way to put that domain in our prefs [01:18:07] brion: will also need interlang link handling when using interwiki prefixes, but that can come later I guess [01:19:54] looking [01:20:41] YuviPanda: were we dropping that namespace field from PageTitle? [01:20:56] brion: I want to think on that for a day more before making that decision [01:21:06] ok [01:21:12] my current inclination is to keep it with a sentinal NAMESPACE_MAIN constant [01:21:59] brion: although that does not solve the Star Trek: problem [01:22:05] :) [01:22:20] brion: I'm guessing we can keep it as is now, and then add support for listed namespace checking later [01:22:34] brion: if Site exposes language data, that should be doable in the constructor itself [01:23:45] (03CR) 10Brion VIBBER: "(1 comment)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93906 (owner: 10Yuvipanda) [01:23:50] YuviPanda: ^ [01:24:50] brion: hmm, agreed [01:28:08] brion: patch coming up [01:28:51] (03PS2) 10Yuvipanda: Add Site object, make it part of PageTitle [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93906 [01:28:52] brion: ^ [01:30:13] nom nom [01:31:10] YuviPanda: actually we might want to do the same for getting a title by name on a given site [01:31:24] brion: hmm, and get rid of the PageTitle constructor? [01:31:31] yeah, or at least hide it [01:31:37] natural dependency injection \o/ [01:33:08] brion: hehe yeah [01:34:00] brion: hmm, not sure if there's a way to hide it from the rest of the package but make it visible to just Site [01:34:03] brion: no 'friend' here [01:34:17] yeah, i think it's fine to rely on convention here [01:34:28] have an ugly constructor and just tell people not to use it [01:35:07] brion: right [01:41:17] marktraceur, so what's the fallback for the desktop media viewer when license can't be fetched? a link to the file page? [01:41:36] (03PS1) 10JGonera: Story 1289: Promote image viewer overlay to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93908 [01:42:00] (03CR) 10JGonera: [C: 04-2] "Depends on Ibaf09360041408e9bf9692056572f5b23b7f7c08" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93908 (owner: 10JGonera) [01:43:08] jgonera: Yeah [01:48:09] brion: I will do the PageTitle thing as a separate change [01:49:02] ok [01:55:25] (03PS3) 10Yuvipanda: Add Site object, make it part of PageTitle [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93906 [01:59:52] (03CR) 10Dr0ptp4kt: "Yuri, will think upon the entity quotes de-interpolation (MF uses htmlspecialchars in one place, but doesn't attempt sanitization on the i" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/93893 (owner: 10Dr0ptp4kt) [02:10:16] (03PS4) 10Kaldari: WIP: Allow users to modify their UserProfile intro [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93018 [02:10:20] (03CR) 10jenkins-bot: [V: 04-1] WIP: Allow users to modify their UserProfile intro [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93018 (owner: 10Kaldari) [02:17:32] (03PS5) 10Kaldari: WIP: Allow users to modify their UserProfile intro [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93018 [02:20:15] (03PS6) 10Kaldari: WIP: Allow users to modify their UserProfile intro [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93018 [02:49:07] brion: i'm adding animations now! [02:56:01] (03PS1) 10Yuvipanda: Add custom animation when navigating to a new page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93913 [02:59:42] violetto: fast, smooth animations from day 1 for the apps! [02:59:42] :D [03:32:12] (03PS1) 10Robmoen: WIP: Prototype ve editing on mobile. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93916 [03:32:17] (03CR) 10jenkins-bot: [V: 04-1] WIP: Prototype ve editing on mobile. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93916 (owner: 10Robmoen) [03:35:54] (03PS2) 10Robmoen: WIP: Prototype ve editing on mobile. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93916 [03:35:59] (03CR) 10jenkins-bot: [V: 04-1] WIP: Prototype ve editing on mobile. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93916 (owner: 10Robmoen) [03:50:05] (03PS6) 10Mgrover: fix notification overlay automation test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92488 [03:50:09] (03CR) 10jenkins-bot: [V: 04-1] fix notification overlay automation test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92488 (owner: 10Mgrover) [03:50:43] (03PS1) 10Yuvipanda: Add 'loading page' progress indicator on page loads. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93917 [03:50:46] brion: more animations! [03:59:03] YuviPanda: *gasp*! [10:27:59] MaxSem: alert [10:28:08] did anything change for https redirect? [10:28:09] yup? [10:28:21] as far as I know, no [10:28:23] seems like all traffic gets bounced to https [10:28:36] which means all of our zero might be off [10:29:17] hah [10:29:18] i will go try to find someone with beeline phone to test [10:29:33] everyone might be getting charged [10:29:35] ruwiki HTTPS test? [10:29:38] yep [10:30:30] if i fake the X-CS header, it shows the banner, but that is served via https, which means that in production its not detected by the carriers [10:30:49] yurik, see UserRequiresHTTPS hook [10:33:16] gotta run [10:44:24] MaxSem: will do, btw, if you find beeline phone without opera, could you try visiting m.wiki pls? [10:44:27] see if the banner shows [10:44:41] I don't have beeline [11:38:20] MaxSem: around? [11:40:07] i found the issue - somehow my browser had forceHTTPS cookie set, no idea how [12:47:17] yurik, I'm back [12:48:57] MaxSem: false alarm - somehow I got a forceHTTPS cookie on my machine [12:48:59] no idea how [12:49:17] hence - everything turned weird :) [12:49:28] probably they should be ignored in zero? [12:49:49] probably, but i suspect its done by varnish [12:50:20] although funny enough - some ppl might want them on in zero - they don't care about charges, but want secure browsing :) [12:50:29] can't wait for IP switch [12:51:30] MaxSem: do you know how to set page title from the content model? [12:52:01] not by varnish1 [12:52:07] and dunno [14:42:03] (03CR) 10MaxSem: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93430 (owner: 10Jdlrobson) [14:44:42] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93514 (owner: 10Jdlrobson) [14:51:39] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93430 (owner: 10Jdlrobson) [15:01:59] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92002 (owner: 10Jdlrobson) [15:07:17] (03CR) 10MaxSem: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93430 (owner: 10Jdlrobson) [15:09:54] (03PS4) 10MaxSem: Begin Special:UserProfile overhaul [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93430 (owner: 10Jdlrobson) [15:22:22] (03CR) 10Hoo man: "Comment by Graham (https://en.wikipedia.org/wiki/User:Graham87) regarding this change: "Thanks, everything works!"" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93490 (owner: 10Hoo man) [16:20:59] (03PS5) 10MaxSem: Begin Special:UserProfile overhaul [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93430 (owner: 10Jdlrobson) [18:01:37] having crazy audio problems, please start without me im gonna restart [18:16:17] kenanwang, kaldari you guys good to chat now? [18:16:35] I'm in the next stand up [18:16:44] ok kenanwang, ping me when you're done [18:16:45] but I might not make it to that... [18:17:14] awjr: I can chat whenever [18:17:24] ok kaldari, let's wait for kenanwang [18:18:52] okay, top priority for review: https://gerrit.wikimedia.org/r/#/c/93430/ :) [18:26:48] hey awjr available now [18:26:59] cool kenanwang, kaldari let's hang out [18:27:45] ok [18:28:16] do you think it would be better for me to skip the trip? [18:28:40] kaldari: https://plus.google.com/hangouts/_/7ecpiu5836o61c2r4q0696bc68?authuser=1&hl=en [18:33:31] (03PS2) 10JGonera: Story 1289: Promote image viewer overlay to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93908 [18:35:22] can't we just move the meeting? [18:36:46] MaxSem: they're going to come to the meeting [18:36:50] (03PS3) 10JGonera: Story 1289: Promote image viewer overlay to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93908 [18:36:52] boo [18:37:01] does anyone know how i can fix beta labs? [18:37:11] i'm still stuck on https and it's unusable as a result [18:37:19] anyway, someone please look at https://gerrit.wikimedia.org/r/#/c/93430/ :) [18:37:21] tfinc looks like I can't make the computer history museum [18:37:31] MaxSem: with more notice we could move the meeting, but it's increasingly difficult to reschedule a meeting in the office with so many people in a room that needs remote participation gear - especially on short notice [18:37:43] do i just need to kill the cookie? [18:38:04] jdlrobson, yep - yurik had the same problem today [18:38:04] jdlrobson: i thought https was turned off on betalabs [18:38:17] awjr: yeh but a cookie is forcing a redirect to https i suspect [18:38:23] oh [18:38:23] doh [18:39:16] killed all cookies but still happening.. [18:39:36] try it in private browsing jdlrobson? [18:39:53] awjr: yeh but that's annoying [18:40:13] jdlrobson: i dont mean do it that way forever, i mean do it that way to rule out something else going on [18:40:54] (03CR) 10Brion VIBBER: [C: 032 V: 032] Add Site object, make it part of PageTitle [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93906 (owner: 10Yuvipanda) [18:41:01] awjr: yeh it works in private browsing mode [18:41:24] awjr: any idea what the cookie is that does this? [18:41:46] i think it's called forceHTTPS [18:41:47] GOT IT [18:41:48] win! [18:41:49] jdlrobson: ^^ [18:41:52] w00t [18:42:05] what was it/ [18:51:57] (03CR) 10Brion VIBBER: [C: 04-1] "Hmm, a few notes:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93913 (owner: 10Yuvipanda) [18:55:09] (03CR) 10Brion VIBBER: [C: 04-1] "The web view seems to have its own background color which differs from the space under it; since it's now completely hidden during loading" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93917 (owner: 10Yuvipanda) [18:56:13] (03CR) 10Brion VIBBER: "I also find that the animation makes me feel like I should be able to swipe to go back/forward like in a pager view... in which case the l" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93917 (owner: 10Yuvipanda) [18:56:34] rmoen: when do we lose you back to the the VE team? [18:56:38] jdlrobson: https://gerrit.wikimedia.org/r/93490 Could you please review that or find someone to do that soon? I've already did all the screen reader testing and wrote unit tests, that's all I can do. That change is very important for disabled users. [18:58:35] hoo: it's on my radar - my major concern is the code is not usable on mobile (no concept of space or enter) and i'm keen to explore if there is a standard way to support both. Note we've not had any ARIA support since the beginning of mobile so although important i don't think we should rush into a solution without thinking carefully about it. Hopefully I'll get a chance to look at it later today :) [18:59:54] YuviPanda|away: poke poke awake yet? :D [19:00:04] jdlrobson: This really shouldn't break anything, it just makes the site usable to desktop screen reader users (which often use mobile sites, eg. Facebook's mobile site is much better for screen readers than the desktop one). [19:00:17] that reminds me [19:00:22] we should test on mobile screen readers [19:00:31] iOS has a pretty good one built in (VoiceOver) [19:00:38] the aria setup I've used is very similar to the one I've used for the sidebar (which now is in MediaWiki core) [19:00:40] and Android has something that I've never tried [19:01:29] brion: Yes, you should :) Both of them have support, I haven't tested any of these myself before (I only have a pretty crappy android which always is out of memory, ...) [19:11:54] kaldari: MaxSem https://gerrit.wikimedia.org/r/#/c/93430/ ? [19:12:13] (MaxSem i assume your ps5 means you have happy with it? [19:12:34] jdlrobson: getting ready for interview in a few minutes [19:12:53] dunno... I wanted someone else to review the styles [19:13:04] jgonera, ^^ [19:13:49] ok, will do in a few minutes [19:16:30] awjr: not really sure, I think it might be just until the end of this iteration [19:17:03] (03CR) 10Awjrichards: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93430 (owner: 10Jdlrobson) [19:17:52] MaxSem: ^ [19:18:00] thanks [19:23:00] (03PS2) 10Jdlrobson: Story 1301: Measure infobox view time [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92986 [19:23:50] (03CR) 10jenkins-bot: [V: 04-1] Story 1301: Measure infobox view time [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92986 (owner: 10Jdlrobson) [19:24:56] (03PS3) 10Jdlrobson: Story 1301: Measure infobox view time [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92986 [19:24:57] (03PS2) 10Yuvipanda: Add 'loading page' progress indicator on page loads. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93917 [19:24:58] (03PS2) 10Yuvipanda: Add custom animation when navigating to a new page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93913 [19:29:27] (03PS3) 10Yuvipanda: Add 'loading page' progress indicator on page loads. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93917 [19:29:28] (03PS3) 10Yuvipanda: Add custom animation when navigating to a new page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93913 [19:31:01] brion: I changed the direction of animation and made it faster. can I show you? [19:34:24] dfoy: ping [19:34:48] yurik: hey Yuri [19:35:06] dfoy: did you see my email re zero [19:35:18] yurik: yes, thanks for looking into that [19:35:26] we can try testing it together [19:35:31] maybe i have missed something [19:36:02] yurik: yes let's schedule a test with Kazakhstan - it's always happened during a test with them :) [19:36:21] brion: I switched everything to just accelerate, I think it feels more 'normal' now? [19:36:53] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93430 (owner: 10Jdlrobson) [19:36:54] (03PS4) 10Yuvipanda: Add 'loading page' progress indicator on page loads. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93917 [19:36:55] (03PS4) 10Yuvipanda: Add custom animation when navigating to a new page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93913 [19:37:05] (03PS6) 10Jdlrobson: Begin Special:UserProfile overhaul [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93430 [19:37:42] dfoy: i think the best way to test anything with them is to add your own IP to their config page - this way you will be identified as part of their network [19:37:58] yurik: Can I send you an introduction and you can conduct the test with them? [19:38:03] sure [19:38:20] dfoy: btw, it might be easier for them - similar TZ with me [19:38:32] as long as its in the afternoon [19:38:53] dfoy: 1-6pm MSK is ideal [19:39:02] yurik: ok, I'll see what I can set up [19:39:06] thx [19:40:21] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Yes this is looking way awesomer now :D" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93913 (owner: 10Yuvipanda) [19:40:23] (03PS8) 10JGonera: Story 1280 (2/2): Overhaul of image uploading overlay design [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93014 [19:41:45] (03CR) 10Brion VIBBER: [C: 032 V: 032] Add 'loading page' progress indicator on page loads. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/93917 (owner: 10Yuvipanda) [19:43:44] jdlrobson, fixed + removed learnmore in beta + updated carousel tests: https://gerrit.wikimedia.org/r/93014 [19:52:32] MaxSem, how do i jumphost to flourine? [19:52:45] ssh fluorine [19:52:56] doesn't resolve [19:52:57] ??? [19:53:03] what's the fqdn? [19:53:28] i tried from the local box and from bast1001 [19:53:31] I never use it [19:53:35] you have a typo [19:53:46] uo ou [19:53:47] fluorine, not flourine;) [19:53:56] MaxSem :) [19:54:22] thanks! [19:55:43] brion: the 'looks awesome now!' comment is for both of them accelerating, right? [19:56:52] yeah the acceleration and changed direction makes me happy [19:56:54] and the speed [19:57:01] all around awesome :D [19:57:06] brion: :D [19:57:17] awjr_lunch, are you satisfied with https://gerrit.wikimedia.org/r/#/c/93430/ now? [20:02:06] (03CR) 10Jdlrobson: [C: 032] Story 1280 (2/2): Overhaul of image uploading overlay design [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93014 (owner: 10JGonera) [20:02:43] (03Merged) 10jenkins-bot: Story 1280 (2/2): Overhaul of image uploading overlay design [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93014 (owner: 10JGonera) [20:03:57] awjr_lunch: MaxSem tests for profile stuff would be nice - but it's hard for me not really understanding PHP let alone PHPunit to write some. If there are some existing ones to work off of I can personally get better at that.. [20:04:58] jdlrobson, unit tests are the wrong way for this - integration is much more appropriate [20:05:21] MaxSem: just responding to awjr_lunch 's question :) [20:05:34] i think unit tests can be useful here though for things like lastEdit etc. [20:06:41] not with our current level of isolation - you'll have to write various crap to the DB [20:07:14] tfinc: ping [20:07:19] because wfGetDB() kills any chances of testing anything without using half of MediaWiki [20:07:22] (real life not working) [20:07:45] any reason mobile-tech is not on the t-shirt thread? [20:09:12] (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93430 (owner: 10Jdlrobson) [20:09:43] jdlrobson: hmm ? [20:14:11] brion: hmm, I wonder what next [20:18:45] (03PS7) 10Jdlrobson: Begin Special:UserProfile overhaul [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93430 [20:19:06] (03PS3) 10Jdlrobson: Make Special:UserProfile look like an article page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93431 [20:19:12] (03PS4) 10Jdlrobson: Card 1362: Show last edit on Special:UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93514 [20:22:26] (03PS1) 10Dr0ptp4kt: Remove 2% sampling for X-CS=502-16. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/93997 [20:23:21] ^yurik, would you please review and +2? this is removing the logging for 502-16. [20:23:44] looking [20:24:02] thx, gonna grab some food. i'll be back after a bit [20:25:39] (03CR) 10Yurik: [C: 032] Remove 2% sampling for X-CS=502-16. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/93997 (owner: 10Dr0ptp4kt) [20:25:42] (03Merged) 10jenkins-bot: Remove 2% sampling for X-CS=502-16. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/93997 (owner: 10Dr0ptp4kt) [20:25:50] (03PS5) 10Jdlrobson: Card 1362: Show last edit on Special:UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93514 [20:25:51] ^yurik thx ok i go in a minute [20:25:51] (03PS3) 10Jdlrobson: [Card 1366] Add page image to last edited information [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93801 (owner: 10MaxSem) [20:26:06] dr0ptp4kt: go where? [20:26:10] confused [20:26:11] lunch [20:26:14] ^yurik [20:26:14] a, ok [20:26:26] enjoy [20:26:42] jgonera, does https://gerrit.wikimedia.org/r/93430 look good now? [20:31:16] YuviPanda: your amazon package has arrived up on 6th :D [20:36:50] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93514 (owner: 10Jdlrobson) [21:03:44] jdlrobson, jgonera, estimation time [21:05:36] awjr, am I needed during the whole meeting? [21:05:36] awjr, fail [21:05:51] jgonera: yes [21:06:28] awjr, ok, coming [21:07:38] (03PS1) 10Brion VIBBER: Work in progress: Site info class [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/94047 [21:10:22] yurik, you able to take a look at https://gerrit.wikimedia.org/r/#/c/91814/ and +2? [21:10:48] be back in a bit, gotta run do some house stuff wheeee [21:12:10] dr0ptp4kt: for some reason the current code doesn't work correctly - the "edit" does not even appear for the partner admins [21:12:34] yurik, you saying in production, or with that 91814 installed? [21:12:40] prod [21:13:00] yurik, zoiks [21:13:09] yurik, lemme take a look at -TEST [21:13:26] try it with a test account [21:14:27] yurik, are you saying to create a wikipedia test account, then add that to the "admins" group of -TEST, and then see if the Edit button shows? [21:14:59] yep, but it didn't for me, so doubt it would for you :) [21:15:15] yurik, ok, gimme a couple minutes to repro. [21:15:37] np, i guess low priority ATM [21:19:35] yurik, yeah, i see the same. no presentation of the edit button, nor ability to edit if manually adding ?action=edit while logged in as a test account in the "admins" group of -TEST [21:27:00] dr0ptp4kt: not a very good account name i must say :) something like ABaso_test would have been a better choice - identifiable with you rather than a spam :) [21:27:42] :) [21:45:52] jgonera: what's the exact parameter I should be looking for in SSAccountCreation? article_action=signup-edit ? [21:46:07] DarTar, yes, that's the one [21:46:12] k [21:48:29] ok we have 1437 users so far on enwiki [21:50:00] 2494 across all wikis [21:50:38] so this parameter only applies to users who were bucketed in the test right? I don't need to filter further based on registration dates [21:50:41] right? [21:56:56] DarTar, right [21:56:58] select count(*) from ServerSideAccountCreation_5487345 where event_returnToQuery = 'article_action=signup-edit'; [21:57:08] gives me 2502 though [21:57:37] yeah they are 2502 now :p [21:57:54] ok, it looks like we're good then [22:33:24] anyone knows how to configure irc bot to report changes to any page in a namespace of META ? [22:40:06] I can haz https://gerrit.wikimedia.org/r/#/c/93430/ merged?:P [22:41:08] yurik: yes [22:41:53] legoktm: kul! do you think we can set up meta zero: ns monitoring? [22:41:58] sure [22:42:01] to be outputed here? [22:42:01] what channel do you want it in? [22:42:17] (03PS1) 10Jdlrobson: Enable photo upload progress bar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94061 [22:42:26] !stalk meta.wikimedia page Zero:.* [22:42:40] Rule added. [22:42:41] legoktm: yep [22:42:44] WOW [22:42:47] looking MaxSem [22:42:48] that was easy [22:42:51] :) [22:43:06] (03CR) 10Jdlrobson: [C: 04-2] "Feel free to remove my -2 when no longer a WIP" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93916 (owner: 10Robmoen) [22:46:01] [[Zero:-TEST]]; Yurik; - ru test; https://meta.wikimedia.org/w/index.php?diff=6283848&oldid=6283187&rcid=4654582 [22:46:58] hmm my CORS settings do not seem to be working anymore [22:48:41] (03CR) 10Awjrichards: [C: 031] "LGTM; if someone can verify the less changes, feel free to +2" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93430 (owner: 10Jdlrobson) [22:49:06] MaxSem jgonera jdlrobson kaldari if someone can look at the style changes in ^^, feel free to +2 [22:49:28] legoktm: thanks, works beautifully :) [22:49:40] :) [22:53:00] (03CR) 10JGonera: [C: 032] Begin Special:UserProfile overhaul [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93430 (owner: 10Jdlrobson) [22:53:33] (03Merged) 10jenkins-bot: Begin Special:UserProfile overhaul [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93430 (owner: 10Jdlrobson) [23:01:23] weeeeee [23:02:36] (03CR) 10Jdlrobson: [C: 04-1] "(5 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93490 (owner: 10Hoo man) [23:02:56] https://gerrit.wikimedia.org/r/93406 < jgonera [23:07:37] (03CR) 10JGonera: [C: 032] Regression: Error styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93406 (owner: 10Jdlrobson) [23:08:09] (03Merged) 10jenkins-bot: Regression: Error styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93406 (owner: 10Jdlrobson) [23:11:29] kenanwang: I'm at jgonera's desk [23:11:41] reviewing the a/b test numbers- wanna join us here? [23:11:50] ok [23:15:37] awjr: i can't seem to login to wikipedia ... [23:15:44] (on mobile) [23:16:02] awjr: MaxSem are you able to login on mobile? [23:16:59] jdlrobson, WFM [23:17:06]