[00:01:22] (03CR) 10MaxSem: [C: 031] Make Special:UserProfile look like an article page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93431 (owner: 10Jdlrobson) [00:01:37] (03PS2) 10Jdlrobson: Enable photo upload progress bar 1/2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94061 [00:01:38] (03PS1) 10Jdlrobson: Enable photo upload progress bar 2/2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94068 [00:03:07] kaldari: jgonera https://gerrit.wikimedia.org/r/#/c/93431/ [00:04:09] kaity, violetto are you going to http://ichaseyou.com/upcoming-journeys/ ? [00:05:15] aw I dont think I can make it [00:06:56] (03CR) 10JGonera: [C: 04-1] "Notice: Undefined index: useAlternativeChrome in /home/jgonera/www/extensions/MobileFrontend/includes/skins/MinervaTemplate.php on line 23" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93431 (owner: 10Jdlrobson) [00:12:42] (03PS5) 10Jdlrobson: Make Special:UserProfile look like an article page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93431 [00:13:01] jdlrobson: That was probably breaking because setHeaders() isn't called from SpecialUserProfile::executeWhenAvailable() [00:13:34] although I don't know if you fixed that in your change [00:13:38] already [00:13:40] class SpecialMobileUserlogin extends LoginForm < awjr this has executeWhenAvailable function [00:13:52] but it is not a child of MobileSpecialPage... [00:14:21] awjr: not sure how it still works :) [00:14:34] o_O [00:14:44] did i do that? [00:15:42] awjr: yeh as part of the MobileSpecialPage beta/alpha opt in banner [00:15:52] it seems to change the language of the headers so should be renamed back to execute [00:15:54] i sure did [00:16:01] yeah [00:16:06] that's basically all SpecialMobileUserLogin does anyway [00:17:51] (03CR) 10Kaldari: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93431 (owner: 10Jdlrobson) [00:19:53] (03PS1) 10Awjrichards: Change SpecialMobileUserlogin::executeWhenAvailable() back to execute() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94074 [00:34:05] kaldari, MaxSem, jgonera we should get ^^ merged before tomorrow's deployment [00:34:20] otherwise the mobile login page will be wonky [00:34:35] (03PS1) 10JGonera: [WIP] Separate stable and beta search JS code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94078 [00:35:18] (03CR) 10Kaldari: [C: 031] Change SpecialMobileUserlogin::executeWhenAvailable() back to execute() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94074 (owner: 10Awjrichards) [00:35:19] (03PS6) 10Awjrichards: Card 1362: Show last edit on Special:UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93514 (owner: 10Jdlrobson) [00:36:22] awjr, I'm not sure why we even change those messages [00:36:31] it seems to be more consistent if we don't [00:36:37] we have "Log in" in the left nav [00:36:52] eh let's see [00:36:53] this patch changes the heading on the login page from "Log in" to "Sign in" [00:37:15] well actually it just keeps it that way in production [00:37:53] it also makes it possible to have the 'mobile header' thing - the big W on enwiki - for instance [00:38:05] jgonera: ^ [00:38:13] I have the big W both with and without this patch [00:38:24] orly? [00:38:40] yep [00:38:42] didja try clearing your cache? [00:38:49] cache disabled [00:38:53] huh what does the mobile.htmlHeader property do? [00:38:57] you don't? [00:39:08] it changes the message [00:39:14] but I don't know what for [00:39:23] the default from desktop is fine [00:39:30] and more consistent with everything else [00:39:34] in English [00:39:45] because in Polish both messages were translated the same way [00:39:45] ok well, the patch restores login in master back to what is currently in production everywhere [00:40:04] I can merge it and follow up with a patch completely removing this code ;) [00:40:24] heh jgonera i think that's the right thing to do - just dbl check the language issue with kenanwang [00:40:30] it would be nice to get rid of that anyway [00:40:41] yep [00:40:51] I'll chat with you jgonera [00:41:21] where did my big W go [00:41:46] oh well [00:41:55] anyway yeah jgonera, that is the right course of action :) [00:43:34] (03CR) 10MaxSem: [C: 032] Change SpecialMobileUserlogin::executeWhenAvailable() back to execute() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94074 (owner: 10Awjrichards) [00:44:21] (03Merged) 10jenkins-bot: Change SpecialMobileUserlogin::executeWhenAvailable() back to execute() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94074 (owner: 10Awjrichards) [00:48:42] (03CR) 10Dr0ptp4kt: "Yuri, following up on the ENT_QUOTES question:" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/93893 (owner: 10Dr0ptp4kt) [00:53:07] is gerrit going hella slow for anyone else? [00:53:47] (03CR) 10Awjrichards: [C: 031] "LGTM; jgonera if you're happy with the JS fixes let's merge." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92986 (owner: 10Jdlrobson) [00:54:21] (03PS4) 10Awjrichards: [Card 1366] Add page image to last edited information [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93801 (owner: 10MaxSem) [00:54:28] (03CR) 10jenkins-bot: [V: 04-1] [Card 1366] Add page image to last edited information [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93801 (owner: 10MaxSem) [00:56:21] (03CR) 10Awjrichards: [C: 032] [Card 1366] Add page image to last edited information [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93801 (owner: 10MaxSem) [00:56:28] (03CR) 10jenkins-bot: [V: 04-1] [Card 1366] Add page image to last edited information [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93801 (owner: 10MaxSem) [00:57:57] awjr, you can't merge it without the dependency anyway [00:58:14] MaxSem: ? [00:58:29] ^^^^ [00:58:30] oh MaxSem, you mean the dependency i merged? [00:58:40] :p [00:59:10] awjr, no - https://gerrit.wikimedia.org/r/#/c/93431 [00:59:16] man im getting timeouts from gerrit [00:59:22] oh [00:59:26] damn [00:59:33] didnt notice that [01:00:12] these crazy dependency chains are tough [01:01:12] *I usually prefer to get first change merged before starting the second one [01:01:20] slower, but less PITA [01:01:28] kenanwang, do you have 2 minutes now? [01:01:50] yeah; same - but since it had a story card # on it i thought it was a standalone and i didn't check if it had deps [01:01:50] oh well [01:02:21] yeah [01:12:48] hey back [01:12:49] causing jgonera lots of laughter [01:13:16] awjr: thanks for fixing that issue with the login [01:13:26] (03CR) 10JGonera: [C: 032] Enable photo upload progress bar 1/2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94061 (owner: 10Jdlrobson) [01:13:31] np jdlrobson how are you r teeth [01:14:08] (03Merged) 10jenkins-bot: Enable photo upload progress bar 1/2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94061 (owner: 10Jdlrobson) [01:14:29] jdlrobson: if you fix kaldari's concerns im happy to merge https://gerrit.wikimedia.org/r/#/c/93431/5 [01:14:40] kaldari: what name would you suggest? [01:14:48] awjr: half my mouth is out of action [01:14:50] overlayCrhome? [01:14:54] i'm trying not to drool [01:14:57] hhehehe [01:15:04] awjr: but overlayChrome is a bad name since we are changing overlay styling.. [01:15:04] me too but my mouth is fine :p [01:15:08] gah [01:15:11] specialPageChrome? [01:15:18] ok that will do [01:15:19] sometimesChromeForSpecialPages [01:15:23] $dontShowSearchAndFooter [01:15:32] or something like that [01:15:38] ^ jgonera any opinions [01:15:40] that actually says what it does [01:15:57] disableSearchAndFooter? [01:16:04] what's that coming over the hill? is it a bike shed? is it a bike sheddddd ;-) [01:16:08] yeah, that's better than my suggestion :) [01:16:17] or hideSearchAndFooter [01:16:20] even shorter [01:16:23] but they [01:16:23] $bikeShedOverThisVarName [01:16:31] hey, do you know how to get jenkins to run maintenance/checkLess.php for extensions? It does it for core but I don't think for MobileFrontend, etc. E.g. https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-lint/6459/console [01:16:34] i like awjr's suggestion [01:16:38] but they're not there at all, hide suggests something like display: none ;) [01:16:49] ok i'm going with disable [01:16:50] going once [01:16:54] going twice [01:16:54] sounds good [01:16:59] SOLD at disableSearchAndFooter [01:22:12] (03PS6) 10Jdlrobson: Make Special:UserProfile look like an article page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93431 [01:22:14] ^ kaldari jgonera awjr MaxSem BOOM [01:22:34] it explodes, no hope? [01:22:35] Any opinion on whether edits to the UserProfile should show up in RecentChanges or not? [01:22:41] MaxSem: ^ [01:22:56] kaldari, how are you going to store it? [01:23:08] i would say probably not, at least not until userprofile is something in stable [01:23:15] (03PS7) 10Awjrichards: Card 1362: Show last edit on Special:UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93514 (owner: 10Jdlrobson) [01:24:43] It's stored as a WikiPage so that we don't have to create interfaces for flagging, oversighting, unflagging, unoversighting, etc. Currently my plans is to store it as a subpage of the UserPage. [01:26:01] if it's an ordinary page, it should be featured in RC as usual [01:26:46] Cool, I won't suppress it then. [01:27:02] anybody else getting intermittent gerrit timeouts? [01:29:00] PHOTO UPLOAD BAR [01:29:01] WOOOOO [01:29:13] (PROGRESS FOR PROGRESS!) [01:29:22] (03CR) 10JGonera: [C: 032] Enable photo upload progress bar 2/2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94068 (owner: 10Jdlrobson) [01:29:24] kaldari: yeh but it in RC [01:29:41] gahhh gerrit is killing me [01:29:54] (03Merged) 10jenkins-bot: Enable photo upload progress bar 2/2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94068 (owner: 10Jdlrobson) [01:30:12] awjr: in what way? [01:30:21] jdlrobson: it keeps timing out [01:30:24] and is going super slow [01:30:25] erg [01:30:28] it's working for me [01:30:34] it's been like this for the last 90 mins or so [01:30:45] (03CR) 10JGonera: [C: 032] Story 1301: Measure infobox view time [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92986 (owner: 10Jdlrobson) [01:31:00] awjr: try a different browser and see if that's any better? [01:31:09] (03CR) 10JGonera: [C: 04-2] "WIP" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94078 (owner: 10JGonera) [01:31:11] psh [01:31:21] (03Merged) 10jenkins-bot: Story 1301: Measure infobox view time [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92986 (owner: 10Jdlrobson) [01:31:46] kaldari can you merge https://gerrit.wikimedia.org/r/93431 then? [01:32:05] yes... [01:32:11] (03CR) 10Kaldari: [C: 032] Make Special:UserProfile look like an article page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93431 (owner: 10Jdlrobson) [01:32:17] (03PS5) 10Jdlrobson: [Card 1366] Add page image to last edited information [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93801 (owner: 10MaxSem) [01:32:27] :D [01:32:49] (03Merged) 10jenkins-bot: Make Special:UserProfile look like an article page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93431 (owner: 10Jdlrobson) [01:32:53] so i'm pretty confident the other 2 should be ready to go since Max and I worked on them [01:33:02] jdlrobson, are you interested in https://gerrit.wikimedia.org/r/#/c/90679/ or should I abandon it? [01:33:43] jgonera: first i've seen of it. I'll take a look tomorrow. It seems like it will be useful and is uncontroversial [01:34:18] actually what happens if you set $options['override-height'] to false? [01:34:25] or auto [01:34:29] doesn't that have the same effect? [01:36:57] (03CR) 10Awjrichards: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93514 (owner: 10Jdlrobson) [01:37:34] jdlrobson: you will be mad at me but I -1'd 93514 [01:37:49] once that's fixed though i think that and its dependent can be merged [01:43:06] awjr: looking [01:43:41] awjr: how about getLastEditHtml ? [01:43:52] i'll need to change the thanks and upload one too to be consistent.. [01:44:05] actually can i do that in a follow up commit? [01:45:54] jdlrobson: Hey im still not geting data for ge [01:46:03] Getting started jdlrobson [01:46:12] 1s kenanwang [01:46:19] (03PS1) 10Jdlrobson: Hygiene: Give more meaningful function names and add documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94085 [01:46:21] ^ awjr i did a follow up to keep things tidier [01:46:25] can you +2 on that basis? [01:46:44] sure jdlrobson, gimme a minute to get back to it [01:46:53] (03CR) 10Jdlrobson: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93514 (owner: 10Jdlrobson) [01:47:24] kenanwang: i'm seeing a few on MobileWebCta_5972684 [01:47:31] actually wait.. no i'm not [01:47:32] mm [01:47:44] let me explore.. [01:48:48] kenanwang: o_O Validation error against schema MobileWebCta: Unknown schema: MobileWebCta [01:49:23] Hmm did it still not get deployed? [01:49:47] kenanwang: i'm not sure what's going on.. it's in master [01:51:00] (03CR) 10Awjrichards: [C: 032] Card 1362: Show last edit on Special:UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93514 (owner: 10Jdlrobson) [01:51:21] kenanwang: seems to be on mediawiki.org [01:51:33] (03Merged) 10jenkins-bot: Card 1362: Show last edit on Special:UserProfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93514 (owner: 10Jdlrobson) [01:51:33] kenanwang: i just triggered an event [01:51:37] so i guess it will go to enwiki tomorrow [01:52:40] kenanwang: interestingly the random feature in alpha is getting a little usage on the small amount of projects it is deployed too [01:52:46] *deployed to [01:52:55] Random in alpha? [01:53:03] kenanwang: yup [01:53:06] awjr: one more for you :) https://gerrit.wikimedia.org/r/#/c/93801/ [01:53:17] although it has a dependency :( [01:53:21] (03PS6) 10Jdlrobson: [Card 1366] Add page image to last edited information [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93801 (owner: 10MaxSem) [01:53:30] oh but it has been merged! yet! [01:53:32] *yey [01:53:41] https://gerrit.wikimedia.org/r/#/c/93801/ < kaldari you can help here too :) [01:53:51] (03CR) 10Awjrichards: [C: 032] Hygiene: Give more meaningful function names and add documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94085 (owner: 10Jdlrobson) [01:54:00] would be nice for all the profile changes so far to go through in the next train [01:54:34] jdlrobson: i alrady merged the dependency on pageimages [01:54:58] awjr: yup so no problems with adding the image to the profile last edit card :) [01:55:11] yah [01:55:22] (03Merged) 10jenkins-bot: Hygiene: Give more meaningful function names and add documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94085 (owner: 10Jdlrobson) [02:13:23] ergh sorry jdlrobson got pulled away, im testing https://gerrit.wikimedia.org/r/#/c/93801/6 now [02:15:04] np thanks awjr [02:15:49] for some reason cors is not working right for me locally :| [02:16:54] i dont know if it's something that's gone sideways in MF, core or my setup [02:17:13] jdlrobson: do you have cors set up locally for testing? [02:17:25] awjr: whoops messaged you in wrong channel :) [02:17:29] awjr: no why do you need cors? [02:17:35] np [02:18:05] also awjr if https://gerrit.wikimedia.org/r/93988 gets merged that means story 1301 can be considered complete [02:18:23] awjr: you can test CORS stuff on beta labs [02:18:26] oh nm jdlrobson figured out my problem [02:19:12] hmm although for some reason Special:UserProfile is showing that i have 0 uploads even though that is not true [02:19:46] oo progress bar! [02:19:46] awjr: which wiki? [02:19:50] awjr: :D [02:19:55] local [02:20:01] are you sure it is not true? [02:20:09] heh yes [02:20:15] i just uploaded yet another image and it is still showing 0 [02:20:25] is the upload checker looking only at the local wiki? [02:23:42] (03PS7) 10Kaldari: WIP: Allow users to modify their UserProfile intro [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93018 [02:27:44] awjr: where did it upload to? [02:27:55] jdlrobson: it uploaded to my upload wiki [02:28:03] also what's value of $wgMFPhotoUploadWiki [02:28:09] so i wonder if there's something wrong with the count code checking the upload wiki [02:28:20] but i dont think it's related to that patchset [02:28:28] awjr: check your LocalSettings as $wgMFPhotoUploadWiki should be null [02:28:40] jdlrobson: wait wha? [02:28:52] i upload to another wiki [02:29:02] i've tried to get my setup close to production [02:29:34] (hence needing CORS working right, having a separate upload wiki, etc) [02:30:19] (03CR) 10Awjrichards: [C: 032] [Card 1366] Add page image to last edited information [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93801 (owner: 10MaxSem) [02:30:24] meh [02:30:34] jdlrobson: im rushing to get out of here, i need to cook [02:30:50] (03Merged) 10jenkins-bot: [Card 1366] Add page image to last edited information [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93801 (owner: 10MaxSem) [02:30:52] haha woops [02:31:09] see you 2mo [02:31:09] but at least all of those patchsets are merged now :) [03:38:32] (03PS1) 10Yuvipanda: Recognize `lead` and `nonlead` section specifications in the Api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94093 [04:12:43] (03CR) 10Legoktm: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94093 (owner: 10Yuvipanda) [04:13:46] $sections = array_flip( array_map( 'trim', explode( '|', $str ) ) ); <-- Why doesn't the module use the normal API method of doing that? [04:14:33] ApiBase::PARAM_MULTI [04:14:58] YuviPanda: the word 'nonlead' sounds weird to me. [04:26:08] YuviPanda: where r u [04:26:19] (03CR) 10CSteipp: [C: 031] "After looking at this with Adam, it should be fine. Since the decoded value is run through urlencode anyway, there shouldn't be a way to b" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/93893 (owner: 10Dr0ptp4kt) [04:33:00] legoktm: sure, but what else to call it? [04:33:01] jdlrobson: at the office, showing a friend around. Will prolly leave for dinner in a bit [04:33:01] legoktm: i can't come up with a better name [04:33:24] Yeah, neither could I. [06:11:39] (03PS7) 10Mgrover: fix notification overlay automation test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92488 [07:00:05] (03CR) 10Yuvipanda: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94093 (owner: 10Yuvipanda) [07:50:26] [[Zero:401-01]]; Yurik; my test ip; https://meta.wikimedia.org/w/index.php?diff=6287203&oldid=6278194&rcid=4655288 [08:02:41] [[Zero:401-01]]; Yurik; -bannerWarning per partner request; https://meta.wikimedia.org/w/index.php?diff=6287284&oldid=6287203&rcid=4655299 [08:32:47] [[Zero:401-01]]; Yurik; removed testing IP, leaving as enabled per partner req; https://meta.wikimedia.org/w/index.php?diff=6287504&oldid=6287284&rcid=4655306 [08:50:05] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92002 (owner: 10Jdlrobson) [09:15:28] (03CR) 10Yurik: [C: 032] "sounds good, will try to remember to remove once mobile is updated" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/93893 (owner: 10Dr0ptp4kt) [09:15:45] (03Merged) 10jenkins-bot: Make clicks on "Yes" for Desktop interstitial redirect properly. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/93893 (owner: 10Dr0ptp4kt) [09:29:54] MaxSem: something keeps setting my "forceHTTPS" [09:29:57] is that a new feature? [09:30:38] i can always work around it by using privacy mode [09:30:45] but just curious i guess [09:33:09] hi MaxSem! [09:33:15] hey [09:33:16] MaxSem: did you get my email? [09:33:41] yurik, the cookie isn't new, but there might've been new changes around it [09:34:06] not a biggie i guess [09:34:08] thx max [09:36:14] YuviPanda, looking [09:36:20] MaxSem: woo, thanks! :D [09:37:02] YuviPanda, first of all, 'lead' isn't needed as you can just use 0 [09:37:23] MaxSem: sure. added it for symettry with 'nonlead' [09:37:31] I"m happy to remove that [09:37:42] if you think that is unnecessary bloat [09:37:43] I like it tho [09:38:01] second, isn't lead WP-centric? [09:38:31] well, we can make it 'first' and 'rest' [09:38:34] which is accurate [09:38:38] and generic enough [09:39:33] MaxSem: want me to amend that patch with those changes/ [09:39:34] ? [09:39:38] 'first' and 'rest' [09:39:44] mmm [09:40:30] if 'first' is killed, 'rest' makes no sense. also, it'd better be clear even without context [09:40:41] indeed, so I suggest we keep 'first' and 'rest' [09:42:00] (03PS2) 10Yuvipanda: Recognize `first` and `rest` section specifications in the Api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94093 [09:42:02] MaxSem: ^ [09:42:08] yurik, what do you think^^^? [09:42:31] looking... [09:42:46] *eventually* the app will just move to using the parsoid service and its content API, but that's severl months away... [09:44:22] boo, PDF will use it next week!:P [09:44:44] heh, SURE! :P [09:45:31] yurik: thoughts? I'd want to convince MaxSem to merge it soon, so I can go to sleep *and* this gets deployed tomorrow [09:45:47] YuviPanda: sec, commenting :) [09:47:47] YuviPanda, sleep assured that I'll fix it myslef [09:49:32] wooohoo MaxSem! [09:49:43] MaxSem: thanks! [09:50:42] (03CR) 10Yurik: [C: 04-1] "(3 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94093 (owner: 10Yuvipanda) [09:50:56] MaxSem: ^ [09:52:20] fixing [09:55:31] MaxSem: yurik ^ [09:55:56] YuviPanda: ? [09:55:57] (03PS3) 10Yuvipanda: Recognize `first` and `rest` section specifications in the Api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94093 [09:56:04] yurik: ^ i mean [09:56:12] (03CR) 10Yuvipanda: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94093 (owner: 10Yuvipanda) [09:56:18] YuviPanda: you meant "v" [09:56:22] heh [09:56:28] got it right the second time :D [09:56:59] go to bed Yuvi, we'll take care of the rest [09:57:34] :D [09:57:39] ok! will do now [09:57:42] thanks! [10:05:32] YuviPanda|away: not really, but will let max fix it :)))) [10:05:44] (re "got it right" :P ) [10:08:37] MaxSem: i will fix it up a bit and commit [10:49:29] MaxSem: tut? [10:49:37] da [10:51:21] MaxSem: i'm a bit confused - what does $data['sections'] contain? all sections with the header, or excluding the header? [10:52:36] with it [10:55:17] yurik, need help? [10:55:49] no no, fine so far, just fixing up the logic a bit, give me another sec [10:55:55] (had to step away for a few) [10:59:22] afk, will be back in a couple hours [13:05:18] yurik, I'm back [13:14:38] (03PS1) 10Yurik: Bug 56704: Allow mobileview api to handle section ranges [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94127 [13:14:38] MaxSem: commiting [13:14:42] ^ [13:19:15] MaxSem: thoughts? [13:25:03] MaxSem: brb [13:41:07] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/82050 (owner: 10MaxSem) [13:54:37] MaxSem: ping [13:54:41] any q for me? [13:54:54] i have a class in 5 min [14:02:41] yurik, that looks huge and without tests I'm not confident [14:18:29] (03PS8) 10Cmcmahon: fix notification overlay automation test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92488 (owner: 10Mgrover) [14:19:37] (03CR) 10Cmcmahon: [C: 032] fix notification overlay automation test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92488 (owner: 10Mgrover) [14:20:10] (03Merged) 10jenkins-bot: fix notification overlay automation test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92488 (owner: 10Mgrover) [14:51:43] yurik, found a few edge cases - fixing [15:12:59] MaxSem: hey [15:16:42] hell I love unit tests [15:25:12] (03PS2) 10MaxSem: Bug 56704: Allow mobileview api to handle section ranges [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94127 (owner: 10Yurik) [15:25:30] yurik, feel free to merge:) [15:26:25] (03CR) 10MaxSem: [C: 031] Bug 56704: Allow mobileview api to handle section ranges [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94127 (owner: 10Yurik) [15:35:10] MaxSem: why do you want to use regex for splitting? slower and doesn't add any value imho [15:35:34] because it has PREG_SPLIT_NO_EMPTY [15:35:50] once you have tests, the difference is noticeable;) [15:41:15] MaxSem: true, and i agree i miseed that case, but wouldn't it be easier to just add an extra test for it and skip it? [15:41:29] i suspect that running a full regex like that costs much more [15:43:49] we're talking about a microsecond in a module that runs for 300ms on average [15:44:12] yurik, ^ [15:44:40] MaxSem: as they say, if you problem and solve it with regex, you now have two problems ;) [15:44:49] i prefer to use regex when its clear advantage [15:44:54] of complex patterns [15:45:04] meh [15:45:12] in this case i would really insist on checking extra case [15:45:22] i will fix the case [15:46:11] MaxSem: also, are you sure we should sort it? [15:46:17] up to you really [15:46:32] just that if it was specified in a weird way, why bother :) [15:46:34] (03PS3) 10MaxSem: Bug 56704: Allow mobileview api to handle section ranges [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94127 (owner: 10Yurik) [15:48:51] MaxSem: and why public? someone else uses it? [15:49:02] to test;) [15:49:09] oh [15:49:11] hmm [15:49:13] bleh [15:49:15] ok [15:57:13] yurik, merge? [15:57:21] sec [15:59:12] (03CR) 10Yurik: [C: 031] Bug 56704: Allow mobileview api to handle section ranges [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94127 (owner: 10Yurik) [15:59:20] MaxSem: % [15:59:36] too lazy for +2?: [15:59:37] P [15:59:50] MaxSem: i wrote most of it - i shouldn't +2 :-P [15:59:52] (03CR) 10MaxSem: [C: 032] Bug 56704: Allow mobileview api to handle section ranges [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94127 (owner: 10Yurik) [16:00:57] (03Merged) 10jenkins-bot: Bug 56704: Allow mobileview api to handle section ranges [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94127 (owner: 10Yurik) [16:01:48] MaxSem: i guess we should abandon the other patch [16:02:32] (03Abandoned) 10MaxSem: Recognize `first` and `rest` section specifications in the Api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94093 (owner: 10Yuvipanda) [16:05:00] thx :) [17:40:00] (03PS1) 10Jdlrobson: Use getUrl rather than wikiGetlink [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94162 [17:53:08] awjr, I've fixed https://gerrit.wikimedia.org/r/#/c/88903/ [17:53:35] cool thanks MaxSem, will look after i get through my mtgs [18:16:07] kaldari or awjr, I would really appreciate your help with a couple of core changes: https://gerrit.wikimedia.org/r/#/c/92598 and https://gerrit.wikimedia.org/r/92588 [18:21:03] MaxSem: I'll take a look [18:21:10] thanks:) [18:24:11] MaxSem: thanks a lot :D [18:24:19] MaxSem: although that means I still have no patches in MF :P [18:24:21] but 'tis k! [18:24:37] good morning Yuvi [18:24:52] I can give you a card if you like:P [18:25:02] MINGLEEEE! [18:25:03] no :P [18:25:08] and you should thank Yurik who did most of the work:) [18:25:20] :D yurik ^ ty [18:25:23] :) [18:25:29] you are welcome :0 [18:25:31]