[09:31:29] (03PS1) 10Yuvipanda: Add equals methods to the value objects [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/94710 [11:26:45] brion: heya! [11:26:48] brion: you're up early! [11:27:49] brion: have a search patch coming up! [11:32:02] yo [11:32:03] whee [11:32:23] brion: i also have a couple of other patches already there [11:32:27] brion: do take a look. Added testing [11:32:30] sweet [11:32:57] brion: violetto also put up https://www.mediawiki.org/wiki/Wikipedia_App_Design [11:33:00] very drafty [11:33:05] and not even remotely close to 'final' [11:33:09] but do take a look :D [11:33:21] wheeee [11:33:45] late night crews [11:33:48] or early morning? [11:33:49] hehe [11:34:05] violetto: early morning for brion, and I haven't slept for about 20 hours now [11:34:11] man i need to find my glasses, i cranked my resolution up to virtual 1920x1200 to give me more room in xcode [11:34:17] haha :D [11:34:21] brion: i'm still at the default [11:34:28] YuviPanda: tired brains are the most creative ones [11:34:33] violetto: hehe :D [11:34:36] the 1440x900 hi dpi is all around awesome looking isn't it :D [11:34:42] but sometimes it's nice to change the res for extra space [11:37:22] lemme crank the res back down, even with my glasses i'm getting eyestrain at this time of night.... day... morning.... whatever ;) [11:37:34] aaaaaaah better [11:38:19] brion: :D [11:38:34] whooooooa some crazy ideas in this ui doc :D i love it [11:39:05] (03PS1) 10Yuvipanda: Add preliminary search interface [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/94719 [11:39:05] brion: hehe, yeah [11:39:07] brion: LOOK! [11:39:16] brion: :D [11:39:18] i'm not sure how drag-pull up and down are going to work tho [11:39:29] brion: well, imagine pull to refresh on the twitter app [11:39:32] but... sideways! [11:39:34] or dowanwards [11:39:39] aah [11:39:43] so beyond the top or bottom of the article [11:39:54] you pull a little extra and get down an opportunity for more [11:39:58] pull enough and it snaps open? [11:40:07] bitchin :D [11:40:22] i like the "zooming out gives you a bird's eye view" also [11:40:43] this reminds me of the semantic zoom idea on windows 8 which i liked the idea of, but i wasn't happy with my implementation on the windows 8 app [11:40:59] could definitely be made awesomer with pictures and section snippets [11:41:25] brion: :D video / screenshots? [11:41:45] we're gonna have the coolest demos every [11:41:46] *ever [11:41:52] hehe yeah [11:41:58] brion: check out the search stuff [11:41:59] which reminds me, i tested the video capture rig with updated google hangouts [11:42:05] it works much better with the new HD support [11:42:27] sometimes the picture gets garbled, but that's the nature of video chat; when it's nice it's detailed [11:42:32] (03PS2) 10Yuvipanda: Add preliminary search interface [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/94719 [11:42:35] brion: wooo! [11:42:47] brion: think you can order one more rig off amazon and have it delivered by thursday? [11:42:48] but i still need the ugly "three extra widgets to strip HDCP encryption" for the nexus 4 / nexus 5 [11:42:50] or is that too little time? [11:43:15] well that's the hard part ;) [11:43:39] brion: the three extra widgets? [11:43:50] yeah :( [11:44:03] i'll do another run with cyanogenmod and see if i can get the hdcp disabled on the nexus4 [11:44:07] brion: hmm, maybe I could steal yours, and you could get new one? :D [11:44:12] cause if i can figure that out, it's WAY easier to ship you just the capture widget :D [11:44:37] oh -- android 4.4 includes a method to do screen capture to .mp4 file... but it has no user interface [11:44:42] you must launch it from adb shell [11:44:44] brion: hahah! [11:56:00] brion: I'm going to have... some meal, and be back in a bit, hopefully awake. Do take a look at the patches :D [11:56:08] ok :D [11:56:23] brion: language summit next week, so need to have a 'normalish' workday too [11:56:24] grrr [11:56:44] hehe [11:57:04] YuviPanda: so reminder; today is a holiday in US [11:57:16] brion: yeah, I remember. [11:57:22] but knowing us nerds a lot of us will be online anyway ;) [11:57:27] indeed, I'm counting on it :P [11:57:40] :DD [11:57:42] brion: I mean, violetto just (hopefully!) went to sleep, and I'm still here [11:57:46] and so are you :P [11:57:47] * brion fires up gerrit [11:58:10] brion: oooh, also, I put up a thread on mobile-l about experimenting with different methods to find 'related' articles [11:58:10] i'm excited... we've got some good ui idea discussions [11:58:12] brion: do take a look [11:58:13] brion: yeah [11:58:13] good infrastructure internals [11:58:23] and an excited team :D [11:58:26] brion: :D [11:58:41] brion: we also should be using a... GRID! for the css / html [11:58:52] so we can do neat things without fucking ourselves up [11:59:00] :D [11:59:23] 'Fixed when writing tests for Parcelable' mwahahah [11:59:27] tests for the win [11:59:28] brion: :D [11:59:33] brion: yeah, the tests are in a latter commit [11:59:40] i should sleep soon [11:59:42] brion: although eventually, I would want to have PageTitleTests, SectionTests, etc [11:59:45] but i have a q [11:59:46] brion: rather than what we have now [11:59:52] violetto: ask! [12:00:46] on the infobox, im thinking we should include wikidata info upon uncollapsing (not collapsing normal infobox info but uncollapse to reveal more) possible? [12:01:05] *uncollapse to reveal wikidata info [12:01:10] "More info" [12:01:16] "Hugely amount more info" [12:01:23] brion: violetto only thing I can think of is that a lot of things will be repeated [12:01:36] brion: violetto we can also experiment by killing infoboxes and completely replacing them with wikidata [12:01:41] since that is the future anyway [12:01:50] brion: violetto and we can format the individual properties as we see fit [12:01:52] yeah that's the future..... we'll have to experiment :D [12:02:09] violetto: so answer to that question is... 'YES!' [12:02:17] violetto: the only question is how exactly to show it [12:02:25] I'm in favor of stripping those infoboxes and just using wikidata [12:02:32] im not sure if we should kill infoboxes, although i agree wikidata is future [12:02:42] cus for example: https://en.wikipedia.org/wiki/Bankrupt! [12:02:50] has much more info than https://www.wikidata.org/wiki/Q4856442 [12:02:50] with wikidata, we'll *also* get free editing! [12:03:15] violetto: hmm, true [12:03:16] free editing? [12:03:27] violetto: well, in the sense, that editing wikidata items is far, *far* easier to build [12:03:32] than editing wikipedia infoboxes [12:03:38] we can get true wysiwyg without any complexit [12:03:39] y [12:04:02] editing infoboxes yayyyyyyy [12:04:19] violetto: but yeah, infoboxes are sometimes more... useful [12:04:30] violetto: we need a way to show the user both, and then we can collect info on which they prefer :D [12:04:44] intelligent personal digital agent [12:04:50] determine what info you like [12:04:55] and present it to you with a paper clip [12:05:00] hahaha [12:05:19] yep im thinking how we can do that, encourage use/editing of wikidata [12:05:36] tbh, ive looked at this wikidata site a few times i still dont know how to edit it [12:05:41] or that it's not even inviting me [12:05:50] "I will hug him and pet him and squeeze him and name him Clippy" [12:05:52] it's not yet the most inviting user interface no :D [12:05:56] not that infobox is any more inviting [12:06:11] violetto: really? I see [edit] links all over on wikidata [12:06:16] it has more edit links than wikipedia even [12:06:21] (03CR) 10Brion VIBBER: [C: 032 V: 032] Properly put a Section into a parcelable [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/94589 (owner: 10Yuvipanda) [12:06:23] are you logged in? [12:06:53] yes im logged in [12:06:59] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix bug in Parcelable implementation for Page class [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/94616 (owner: 10Yuvipanda) [12:07:02] but where do i put my sources? i dont want my edits reverted [12:07:21] violetto: 'edit' is for editing, there's an 'add' link right below it for adding sources [12:07:38] violetto: it is called 'add source' if there are no sources, and 'add' if there is already at least one source [12:07:39] iiii seeee [12:07:54] violetto: you can expand the '1 source' link to the left of 'add' to see what the source is [12:07:55] we may need your help on wikidata ui at some point ;)) [12:07:55] yeah doesn't help when there isn't any sources before i add one [12:08:01] heh [12:08:07] brion: it'll be my pleasure [12:08:09] violetto: in that case, I'd suggest that you BE BOLD and JUST FIX IT [12:08:12] :D [12:08:20] hmmmm testPingbackHandling failed, lemme run again [12:08:43] violetto: wikidata editing is far, far more addicting than wikipedia editing [12:08:44] let's see if this app helps [12:09:00] yes i was just about to say, i could totally get addicted to this [12:09:02] lemme check if this is a 4.4-specific bug ..... [12:09:06] * brion digs the nexus 4 back out [12:09:19] brion: ugh, 4.4 has a new webview engine (CHrome) [12:09:22] hope that doesn't give us bugs [12:09:28] brion: all tests pass on my current n4 [12:09:51] yeah it'll be just our luck if the new web view implementation efts up [12:09:55] yeah [12:09:55] grr [12:10:04] now we'll have three different webview implementations! [12:10:19] brion: if only firefox weren't such knuckleheads about embedding [12:12:40] yep, it passes on the n4 [12:12:44] ok i'll see if i can fix that later [12:13:01] i'll add a plumbing card [12:13:45] im adding band members to Phoenix the band on wikidata, but if there isn't a wikipedia page for the artist, you can't add any [12:13:49] whaaaaattttt [12:14:00] heh [12:14:08] violetto: welcome to notability guidelines :D [12:14:54] that just means i have to create wikipedia articles for my favorite band members [12:14:58] :D [12:15:00] :} [12:15:16] violetto: https://www.wikidata.org/wiki/Wikidata:Glossary and https://www.wikidata.org/wiki/Wikidata:Notability [12:15:20] :D [12:15:28] brb food! [12:17:32] (03CR) 10Brion VIBBER: [C: 04-1] "(3 comments)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/94710 (owner: 10Yuvipanda) [12:19:06] (03CR) 10Brion VIBBER: [C: 04-1] "android-apt-compiler: [wikipedia] /Users/brion/src/wiki/apps-android-wikipedia/wikipedia/res/layout/item_search_result.xml:7: error: No re" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/94719 (owner: 10Yuvipanda) [12:25:40] (03PS3) 10Yuvipanda: Add preliminary search interface [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/94719 [12:25:45] brion: weird, marginEnd should work. eprhaps you're on an older sdk [12:25:47] brion: updated anyway [12:25:51] (03CR) 10Brion VIBBER: "Ok, I have to bump the Module SDK up from "Maven Android 4.1.2 Platform" to "Maven Android 4.2.2 Platform" in project settings to get this" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/94719 (owner: 10Yuvipanda) [12:26:07] brion: heh, I updated patchset to not need it [12:26:11] heh [12:26:24] brion: I'm just going to do left right now. can do start end later [12:26:29] ok [12:26:36] amir will tell su what we're doing wrong when we test ;) [12:26:54] :D [12:26:55] yeah [12:26:56] that reminds me [12:27:07] left/right swipe gestures -- should they swap on rtl as well? :D [12:27:27] we'll cross over/under that bridge when we come to it :P [12:27:30] hehe [12:27:54] YuviPanda: i was also considering swipe left/right for page back/forward navigation [12:28:22] brion: I was too, but there's already back button... [12:28:28] well there's back button on android [12:28:31] i gotta deal with iOS too ;) [12:28:34] and there's no forward button ;)) [12:28:40] brion: and did you see the 'reading history' re-implementation we dreamed up on the mediawiki.org page? [12:28:44] that should help too :D [12:28:45] yeah [12:28:46] ah yes [12:28:55] if that's easy to use that'll tide us over eh [12:29:39] oh wow the search bar is floating over the fragments? [12:29:43] nice [12:30:08] brion: what about partial drag to back/forward? [12:30:49] brion: it has a shadow too! [12:30:55] brion: and the search bar itself is a fragment! [12:31:06] the shadow is kinda shitty, but we can fix that later [12:31:24] YuviPanda: i get these a lot: java.lang.RuntimeException: Could not dispatch event: class org.wikimedia.wikipedia.LinkHandler$NewWikiPageNavigationEvent to handler [EventHandler public void org.wikimedia.wikipedia.PageActivity.onNewWikiPageNavigationEvent(org.wikimedia.wikipedia.LinkHandler$NewWikiPageNavigationEvent)] [12:31:38] brion: crashes? [12:31:42] yeah [12:31:47] brion: steps to repro? [12:32:45] YuviPanda: not sure [12:33:00] (03PS4) 10Yuvipanda: Add preliminary search interface [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/94719 [12:33:01] (03PS2) 10Yuvipanda: Add equals methods to the value objects [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/94710 [12:33:02] brion: updated equals tests. [12:33:11] brion: does the basic search + tap to navigate work? [12:33:33] yeah [12:33:41] just crashes randomly eh [12:33:46] yeah i'm not seeing the crash again now. if it turns up i'll try and repro more detailly [12:34:00] okay! [12:34:02] but it did it like 3 times in a row :) [12:34:05] hehe [12:34:17] that sounds very much like a statelessness thingy [12:34:22] that we should fix [12:34:26] try rotating :P [12:35:14] brion: also, FUCK YEAH!?! http://tools.android.com/tech-docs/new-build-system/user-guide#TOC-Using-sourceCompatibility-1.7 [12:35:55] brion: also I hope that we get Java 8 when that comes out [12:36:03] (03CR) 10Brion VIBBER: [C: 032 V: 032] Add equals methods to the value objects [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/94710 (owner: 10Yuvipanda) [12:36:31] "strings in switches" [12:36:33] oh hells yes [12:36:53] if(foo.equals("some string") { } else if (foo.equals("seriously fuck you java") {} else... [12:36:55] hehe, early 2000s here we come [12:37:30] course i say the best solution is to make a Map ;) [12:37:45] don't suppose they have collection object literals [12:38:26] brion: no, but they have a poor, homeless, smelly man's version of type inference [12:38:35] \o/ [12:39:21] i swear i want to kill those file:///android_asset/ absolute links everywhere [12:39:28] brion: hehe, that can be arranged :D [12:39:30] but then we'd have to fix up the base path on images [12:39:36] yeah [12:39:39] we have to do that anyway [12:39:41] we are doing that anyway [12:39:52] whee [12:39:56] brion: also, the search bar will do http://www.androiduipatterns.com/2012/08/an-emerging-ui-pattern-quick-return.html anyway [12:40:10] +1 [12:40:26] at some point [12:40:45] brion: do leave comments on https://www.mediawiki.org/wiki/Talk:Wikipedia_App_Design :) [12:40:56] :D [12:43:25] brion: wikidata is pending that one patch from me. I've been asked to add tests, will do them in the next wake-cycle [12:43:43] ok [12:44:41] brion: they're also having some perf trouble... as you saw [12:44:47] we might want to reconsider based on where they are [12:46:10] (03CR) 10Brion VIBBER: [C: 032 V: 032] "(1 comment)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/94719 (owner: 10Yuvipanda) [12:46:20] heh yeah [12:53:33] brion: requested MobileApp extension :D [12:53:40] \o/ [12:54:08] ok brb [13:43:15] brion: i'm going to head to sleep now :) [13:43:17] night [13:43:20] ok [13:43:22] nini [13:43:51] YuviPanda, what time are you living in? [13:43:54] brion: I *would* really appreciate the HDMI capture setup if we can't find a way to get it into hangouts [13:44:03] MaxSem: no fucking idea. woke up at 10pm y'day [13:44:09] MaxSem: not sleepy at all, actually [13:44:16] MaxSem: i'm going to try to sleep toh [13:44:18] *nod* [13:45:02] night [13:49:37] sweet dreams [14:23:34] haha [14:23:45] YuviPanda: i fixed on android 4.4 [14:24:00] ping extension was claiming to be loaded before it registered its listener [14:24:14] the new web view must be a little faster :D [14:26:52] lol android.os.NetworkOnMainThreadException [14:27:10] ok i'll do the full 4.4 fixups on a branch since it seems to have more picky stuff in general [14:30:21] (03PS1) 10Brion VIBBER: Fix order of operations in pingback event registration [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/94735 [14:31:47] (03CR) 10Brion VIBBER: "This fixes the bridge tests on Nexus 5 running Android 4.4. I'm not sure if it's the new WebView implementation backend or just the faster" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/94735 (owner: 10Brion VIBBER) [16:27:23] (03PS1) 10Bartosz Dziewoński: Add a note for SpecialWatchlistQuery hook usage for Iec4aab87 in core [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94762 [16:40:24] (03CR) 10Hoo man: [C: 032] "Needs tests... just kidding, documentation only change" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94762 (owner: 10Bartosz Dziewoński) [16:43:42] (03Merged) 10jenkins-bot: Add a note for SpecialWatchlistQuery hook usage for Iec4aab87 in core [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94762 (owner: 10Bartosz Dziewoński) [20:05:44] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94620 (owner: 10Jdlrobson) [21:40:10] (03CR) 10Siebrand: [C: 04-1] "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94434 (owner: 10Jdlrobson) [22:29:52] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/92027 (owner: 10Dr0ptp4kt)