[00:13:50] brion: still on the call? :D [00:13:57] YuviPanda: just finished [00:13:59] whassup [00:14:06] brion: about 4 patches :D [00:14:16] well [00:14:24] that was anticlimatic [00:14:41] hehe [00:15:15] brion: so 4 patches, and one on the way [00:15:16] wha [00:15:17] got disconnected somehow, i think i hit 'power' by mistake [00:15:19] hehe [00:15:20] lol [00:15:21] mhurd: how's the network ops going? [00:15:41] brion: there's also a patch from Tpt, that I'm reviewing now [00:15:46] (03CR) 10Brion VIBBER: [C: 032 V: 032] Create a new package for Event objects [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/94885 (owner: 10Yuvipanda) [00:15:49] ooh nice [00:15:56] brion: i'm trying to get search into a robust shape before leaving [00:16:10] you're ahead of the game so far YuviPanda :D [00:16:22] brion: heh yeah. [00:16:27] 'Make the number of threads available for a Task customizable' o_O [00:16:29] (03CR) 10Kaldari: [C: 04-1] "(4 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94434 (owner: 10Jdlrobson) [00:16:40] brion: customizable on a per-task-class basis [00:16:46] wacky [00:16:52] brion: so search gas two, content fetching only has one [00:17:09] so if we trigger multiple content fetches somehow, they'll be serialized on one thread? [00:17:10] will be useful when we fetch pageimages and stuff [00:17:14] brion: yeah [00:17:20] brion: we can change that later [00:17:27] ok... might want to make that extensible yeah [00:17:36] * brion wants HTTP 2.0 :D [00:17:41] brion: the previous behavior was always 1 thread [00:17:45] now it is custom [00:17:52] brion: pretty good - ran into a snag but i think i have it ironed out [00:18:01] rmoen: new Page( { title: title, el: $( '#content_wrapper' ) } ).on( 'ready', M.reloadPage ); [00:18:10] brion: will push soon [00:18:24] mhurd: awesome, i'll look over it and then we can merge it into the main app repo [00:18:33] and then... the fun begins :D [00:18:35] brion: sounds good [00:18:38] ya haha [00:19:08] (03CR) 10Brion VIBBER: [C: 032 V: 032] Make the number of threads available for a Task customizable [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/94888 (owner: 10Yuvipanda) [00:19:43] private ParcelableLruCache> searchResultsCache = new ParcelableLruCache eTitle>>(4, List.class); [00:19:45] oh java [00:19:50] why you gotta make us repeat ourselves [00:20:27] brion: yeah. "That thing that looks like generics? HAHAH NOT ACTUALLY USEFUL! FUCK YOU!" [00:20:36] hehe [00:20:43] if you want C++ you know where to find it ;) [00:21:05] hehe [00:21:22] brion: actually, I think we'll be doing some amount of HTML rewriting for the apps [00:21:29] oh my [00:21:33] brion: so perhaps we could write it in C++ [00:21:36] and share it across the apps [00:21:39] lol [00:22:14] hey if you find a really bitchin' html5 DOM library for C++ we'll consider it ;) [00:22:48] maybe let's start with javascript though [00:23:01] brion: parsoid has made their output XML compatible because I asked for it [00:23:05] so libxml [00:23:07] \o/ [00:23:12] that will simplify things a bit then :D [00:24:40] M.pageApi.invalidatePage( title ); [00:24:45] (03CR) 10Brion VIBBER: "test case for ParcelableLruCache? Every time I see unlabeled readInt() calls I wonder how likely those are to break if they get modified." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95053 (owner: 10Yuvipanda) [00:24:46] brion: the ParcelableLruCache doesn't actually have a lot of runtime type safety [00:24:53] kenanwang, jgonera: yt? [00:24:58] wanna chat? [00:25:03] DarTar, coming [00:25:07] cool [00:25:07] jgonera is just finishing a couple htings [00:25:09] brion: will add test case in a later patch. yeah [00:25:16] ok [00:25:26] brion: *thank you* [00:25:39] i was starting to seethe with impotent rage.. [00:25:49] Maryana: where? [00:25:53] eh, lists [00:25:54] i am still just a rat in a cage [00:25:58] hehehe [00:26:14] srsly, how did no wikipedian go "ummm…" [00:26:17] ? [00:26:58] WHERE IS THE DRAMA I MUST KNOW! [00:27:01] we got a lot of hippies [00:27:54] brion: hehe [00:29:45] (03CR) 10Kaldari: "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94434 (owner: 10Jdlrobson) [00:31:26] (03CR) 10Brion VIBBER: [C: 032 V: 032] "should work but i want more tests later :D" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95053 (owner: 10Yuvipanda) [00:34:22] (03CR) 10Brion VIBBER: [C: 04-1] "This also hides the search list if it's open when you rotate the screen." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95057 (owner: 10Yuvipanda) [00:34:43] brion: yeah, that is what I'm fixing in the next patch [00:34:44] brion: I [00:34:57] brion: I made a not about it in the commit summary too [00:35:31] let's try to keep fixes together :) [00:36:13] brion: alright [00:36:18] brion: will amend [00:36:23] tx [00:38:44] brion: anything else you think needs to be done for search? [00:39:03] well depends how polished we want it [00:39:17] back button, page image thumbnails, ... :) [00:39:39] brion: image thumbnails are gonna be messy when we start using wikidata [00:39:56] brion: back button sounds like something that should be done, yeah [00:39:57] i expect we'll have to do a separate query for the thumbs [00:40:37] brion: with opensearch xml we wouldn't have needed to [00:40:50] *sniff* [00:40:56] well worst case... Special:MobileApp! [00:40:59] brion: and I guess I would've just added a patch for extended json opensearch xml that'll return the images stuff too [00:41:00] haha [00:41:07] action=dothingformobileapp [00:41:19] action=compilehtmltoarmcode [00:41:23] brion: can you take a look at the wikidata patch this week? [00:41:28] i will yes [00:41:32] ty [00:41:45] it's my cross-department thing to follow up on for the scrum of scrums meeting :) [00:41:48] aude was super helpful in helping me setup the extension etc [00:41:52] brion: aha! saw that [00:41:55] cool [00:43:41] (03CR) 10Kaldari: [C: 032] Avoid fatals in Special:History without parameter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94619 (owner: 10Jdlrobson) [00:44:14] (03Merged) 10jenkins-bot: Avoid fatals in Special:History without parameter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94619 (owner: 10Jdlrobson) [00:47:43] (03CR) 10Kaldari: [C: 032] Hygiene: Use getUrl rather than wikiGetlink [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94162 (owner: 10Jdlrobson) [00:48:22] (03Merged) 10jenkins-bot: Hygiene: Use getUrl rather than wikiGetlink [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94162 (owner: 10Jdlrobson) [00:59:44] Hey jgonera, you said that you figured out how to skip a Selenium test. Can you elaborate? [01:00:15] you guys experiencing earthquakes today kaldari ? [01:00:25] I haven't felt any [01:00:30] are they on their way? [01:00:57] http://xkcd.com/723/ [01:01:56] I'll put all my knives away just to be safe [01:04:41] jgonera: Also, where is that Cucumber documentation you were talking about? [01:10:09] yurik, can you hop on gchat? want to invite you to a hangout [01:11:50] yurik, the 5 pm invitation should work... [01:16:00] (03PS1) 10Yuvipanda: Add tests for ParcelableLruCache [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95087 [01:32:19] I guess everyone was killed by the earthquake [01:32:36] kaldari: or the accupuncture [01:46:17] (03PS5) 10Robmoen: WIP: VE editing on tablets in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93916 [01:47:21] (03CR) 10Jdlrobson: [C: 04-2] "FIXME's relate to EditorOverlay - when that is overhauled this should be ready to merge. Reviews welcomed in meantime." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93916 (owner: 10Robmoen) [01:52:59] kaldari, the official page is http://cukes.info/ [01:55:11] jgonera: seen https://upload.wikimedia.org/wikipedia/commons/d/d2/Nov12_ArticleLayout-09.png? [01:57:46] kaldari, http://stackoverflow.com/questions/7323608/how-do-i-do-if-statements-in-cucumber-scenarios [01:58:47] YuviPanda, looks like mobile web but with slightly worse typography and everything grayed out :P [01:58:58] hehe :P [01:59:11] why is everything gray? [01:59:27] well, it is a first cut mock up that violetto just made [02:02:17] kaldari, http://stackoverflow.com/a/6320514/365238 [02:06:26] kaldari, coauthor of the cucumber book recommends tags: https://groups.google.com/forum/#!topic/cukes/DhtzH899SC0 [02:13:02] (03PS1) 10JGonera: Hygiene: Remove autoless from Node.js dependencies [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95093 [02:38:07] (03CR) 10Shirayuki: "Additional "500" parameter causes PLURAL validation error like "{{PLURAL:}} was given 3 forms but 2 forms are supported (excluding 0= and " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94901 (owner: 10Shirayuki) [03:01:37] (03PS1) 10Yuvipanda: Rewrite Section#toHtml to use StringBuilder [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95099 [03:32:41] hello [03:34:22] hey aidano1011 [03:37:36] hey YuviPanda [04:12:38] (03PS2) 10Yuvipanda: Do not trigger search if search text has not changed [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95057 [04:42:52] (03PS3) 10Yuvipanda: Do not trigger search if search text has not changed [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95057 [04:46:08] (03PS1) 10Yuvipanda: Make the search box lose focus when the user goes to an article [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95107 [04:54:27] (03PS1) 10Yuvipanda: Remove unused longclick functionality [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95108 [04:54:28] (03PS1) 10Yuvipanda: Extracted the search result adapter into an inner class [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95109 [04:58:27] (03PS1) 10Yuvipanda: Select full contents of the search box when you tap it. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95110 [05:46:55] (03PS1) 10Yuvipanda: Make the search bar non-floating [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95113 [06:31:52] (03PS1) 10Yuvipanda: Handle pressing back when search results are displayed [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95114 [06:46:56] (03CR) 10Yuvipanda: [C: 04-1] "Woohoo, thanks for getting involved!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95061 (owner: 10Tpt) [08:37:28] (03PS2) 10Tpt: Allow to open Wikipedia pages directly in the app [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95061 [16:36:42] jdlrobson: here= [16:36:43] *? [16:47:10] thedj: thedj[work]: Around? ;) [17:01:04] (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove autoless from Node.js dependencies [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95093 (owner: 10JGonera) [17:01:28] hoo: hey [17:01:45] jdlrobson: :) [17:01:46] (03Merged) 10jenkins-bot: Hygiene: Remove autoless from Node.js dependencies [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95093 (owner: 10JGonera) [17:02:24] So are you ok in general with having keyboard navigation in MobileFrontend? [17:03:32] jdlrobson: If so, I'll split up my patches on by one. It would be nice to get them fast merged then ;) [17:04:03] hoo: i'm still not sure about the use case for keyboard navigation - i'd like a second opinion from someone - maybe brion ? [17:04:11] but yeh i'm fine with the attributes being there [17:04:27] and the link fix should be fixed separately [17:04:31] i can merge the latter 2 pretty speedily [17:05:05] Well, first I'd just update the unit tests a bit... right now they're partly doing the work of the actual module... that's not what a unit test should do [17:05:44] be my guest hoo :) those tests have been around since the dawn of time :) [17:06:06] :) [17:09:27] (03CR) 10Jdlrobson: "Surely we would be better addressing https://bugzilla.wikimedia.org/show_bug.cgi?id=42631 ?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94901 (owner: 10Shirayuki) [17:11:16] (03CR) 10Jdlrobson: "(I see that bug is fixed as of yesterday [1] - is this no longer a problem?)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94901 (owner: 10Shirayuki) [17:16:14] (03PS3) 10Jdlrobson: Hygiene: The big skin cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94247 [17:19:10] (03CR) 10Jdlrobson: "MaxSem not sure what you mean - could you expand on what issue you are seeing? Maybe give me a sample wikitext page to play with as well?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94245 (owner: 10Jdlrobson) [17:23:40] (03PS1) 10Jdlrobson: Hygiene: Cleanup diff css [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95186 [17:25:40] (03CR) 10Jdlrobson: "I split the mobilediff fix and tweaked it a bit more in" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94596 (owner: 10Amire80) [17:26:25] (03CR) 10MaxSem: "My standard section test:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94245 (owner: 10Jdlrobson) [18:01:12] rmoen jdlrobson MaxSem standup :D [18:01:23] nope:P [18:01:30] I'm already at one;) [18:02:02] ohh yeah [18:02:03] :) [18:06:57] (03CR) 10Brion VIBBER: [C: 032 V: 032] Add tests for ParcelableLruCache [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95087 (owner: 10Yuvipanda) [18:09:49] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Note for later: there's no tests covering this code!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95099 (owner: 10Yuvipanda) [18:14:19] (03CR) 10Brion VIBBER: [C: 032 V: 032] Do not trigger search if search text has not changed [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95057 (owner: 10Yuvipanda) [18:17:33] (03PS1) 10Hoo man: Modernize and fix the toggle tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95189 [18:17:34] (03CR) 10Jdlrobson: "(4 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94434 (owner: 10Jdlrobson) [18:18:45] (03CR) 10jenkins-bot: [V: 04-1] Modernize and fix the toggle tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95189 (owner: 10Hoo man) [18:19:42] (03PS2) 10Hoo man: Modernize and fix the toggle tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95189 [18:20:18] jdlrobson: ^ Would be nice, if you could merge this ;) [18:20:32] Will do the other changes after that is in [18:23:52] (03PS7) 10Jdlrobson: Story 1312 Card 1312: Style UserProfile page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94434 [18:31:35] (03CR) 10Jdlrobson: [C: 04-1] "(4 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95189 (owner: 10Hoo man) [18:44:52] (03PS1) 10Hoo man: Fix mode for qunit tests on non-english wikis [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95195 [18:45:10] jdlrobson: That fixes the wgMFMmode bug [18:47:38] * wgMFMode [18:50:52] (03CR) 10Jdlrobson: [C: 032] Fix mode for qunit tests on non-english wikis [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95195 (owner: 10Hoo man) [18:51:25] (03Merged) 10jenkins-bot: Fix mode for qunit tests on non-english wikis [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95195 (owner: 10Hoo man) [18:51:41] yay :) [18:51:55] (03CR) 10Jdlrobson: "Amire are you okay to abandon this patchset based on the conversation going on now on design-l and the promise to review this and the othe" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94596 (owner: 10Amire80) [18:56:41] (03CR) 10Jdlrobson: [C: 032] Update progressive action button in new overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94466 (owner: 10JGonera) [18:57:15] (03Merged) 10jenkins-bot: Update progressive action button in new overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94466 (owner: 10JGonera) [19:01:18] jdlrobson: Hi. There's something that we REALLY need to clear up. [19:01:21] My name is Amir :) [19:04:03] sorry Amir - it's because your email has you as 'amire80' :) [19:04:10] it always confuses me [19:04:20] what do we need to clear up aharoni ? [19:04:30] my name :) [19:04:43] now the uppercase thing: [19:06:01] Why abandon the patch? I'm not very emotionally attached to it or anything, but why not just leave it? [19:06:12] Until there's some decision at the mailing list? [19:07:41] hey kaldari I have been released from the kids school [19:07:44] aharoni: i just don't like patch rot.. [19:07:45] so I'm here [19:07:58] patches can always be resubmitted [19:08:24] and it sounds like the design team will need to completely rethink the design without uppercase so i'm not sure how useful it is [19:08:42] If you split the diff thing, the only one line is left, and either it's submitted or not. [19:08:49] out of interest aharoni why 'amire80' and not 'amir80' is the e a middle name or something? [19:08:53] Really? Is it taking so long? [19:09:01] Middle name: Amir Elisha Aharoni. [19:09:09] ahh that makes sense then :-) [19:10:05] aharoni: i guess it's a personal preference but my dashboard is my Getting things done list so if there are things that are there that I can't do anything about it just causes noise for me (not just this one but i usually close any patches that are open longer than a month with no further activity). [19:10:20] well, OK. [19:10:21] aharoni: i basically spend most of my day in https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/MobileFrontend,n,z [19:10:54] (03Abandoned) 10Amire80: Clean up the use of uppercase in CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94596 (owner: 10Amire80) [19:11:24] aharoni: (amir ;-)) any idea what the status of https://gerrit.wikimedia.org/r/#/c/94901/ is ? [19:11:30] are you familiar with this problem / discussion ? [19:13:44] jcmish: That's OK, I talked to one of the cucumber developers on IRC and he answered some of my questions. I did have one thing I wanted to mention though. The new acceptance test for Notifications passes even if the Given condition fails. In other words, even if Selenium can't log into the wiki, the tests still all pass, which I imagine isn't what is intended. [19:14:11] no sir [19:20:10] kenanwang: heads up that put a story review for thursday @ 3-4 [19:20:20] (03PS3) 10Hoo man: Modernize the toggle tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95189 [19:20:26] it'll be the first lite pass so make sure we have stories prepped but don't fret too much about design [19:20:34] (03CR) 10Hoo man: "(4 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95189 (owner: 10Hoo man) [19:21:50] (03CR) 10Hoo man: "Addressed Jdlrobson's comments, also (accidentally) rebased." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95189 (owner: 10Hoo man) [19:23:03] YuviPanda: i purposely put that meeting late as your going to be out [19:23:18] tfinc: I mentioned on standup that I wanted to be on it [19:24:40] YuviPanda: k, then i'll have to move it to Friday [19:24:46] tfinc: ok thanks! [19:24:49] done [19:25:00] brion: hey! [19:25:08] brion: seven more patches :D [19:25:08] YuviPanda: now get back to studying [19:25:15] hey hey [19:25:24] tfinc: yeah, took a break for dinner. will be off in about 30min [19:25:26] YuviPanda: hey i got a new toy to play with later [19:25:31] brion: oh? [19:25:32] google glass :D [19:25:36] brion: .... [19:25:37] WAT [19:25:40] after I leave [19:25:41] GODDAMN IT [19:25:44] wikihow got me an invite [19:25:52] brion: have you gotten it yet? [19:25:54] consider it incentive to come back ;) [19:25:54] awjr: see the conf room update ? [19:25:56] just arrived this morning [19:26:01] shipped *fast* [19:26:05] tfinc: from chip? [19:26:08] yup [19:26:11] yeah :) [19:26:17] brion: we should definitely experiment on it when I'm back from the exammess [19:26:18] i wasn't expecting it for weeks [19:26:21] hell yes :) [19:26:25] also godamnit! :D [19:26:30] haha [19:26:31] im curious to see what r61 is like [19:26:40] brion: anyway, patches? [19:26:42] have you tried it yet tfinc? [19:26:44] gerritglass? :D [19:26:49] im mostly curiousa bout the jabra speaker phone [19:26:59] awjr: i just booked a friday meeting in there [19:27:00] about to poke the rest of the patches yes :D [19:27:05] (03PS2) 10Jdlrobson: Make child overlay hide the parent forcefully [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94468 (owner: 10JGonera) [19:27:08] brion: I'll be on for abour 30min more want to do any fixups so they can all be merged :D [19:27:12] awjr: you should respond and let him know your excited about it [19:27:14] ok [19:27:36] YuviPanda: you going to be on the call for the story prio? [19:27:59] YuviPanda: i spoke with the Developer advocate for glass at Engadget Expand and he added us to the purchase list. I should be able to put those buys in soon [19:28:30] cool tfinc, will do - let me know how you like it; i tired to reschedule some of my mtgs this week for r61 but it's booked :( [19:28:31] yeah i only got one cause wikihow graciously paid for it :) [19:28:38] still hella expensive [19:28:40] (03CR) 10Jdlrobson: [C: 031] "I think this is a little clearer (although still not perfect) - I think documenting the interface of Overlay is more important here - JGon" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94468 (owner: 10JGonera) [19:29:31] dang yuvi you have been busy [19:30:09] brion: yeah tfinc just moved it to friday [19:30:13] so i'll be on the call [19:30:16] ah ok [19:30:18] brion: hehe :D [19:30:22] whee [19:30:26] pass those tests dude :D [19:30:28] tfinc: sweeet! [19:30:31] (03CR) 10Jdlrobson: [C: 032] Modernize the toggle tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95189 (owner: 10Hoo man) [19:30:32] brion: yeah will do :D [19:31:07] (03Merged) 10jenkins-bot: Modernize the toggle tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95189 (owner: 10Hoo man) [19:31:18] (03CR) 10Brion VIBBER: [C: 032 V: 032] Make the search box lose focus when the user goes to an article [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95107 (owner: 10Yuvipanda) [19:31:39] (03CR) 10Brion VIBBER: [C: 032 V: 032] Remove unused longclick functionality [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95108 (owner: 10Yuvipanda) [19:32:55] (03CR) 10Brion VIBBER: [C: 032 V: 032] Extracted the search result adapter into an inner class [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95109 (owner: 10Yuvipanda) [19:33:11] (03PS4) 10Hoo man: Make collapsible sections accessible to screen reader users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93490 [19:33:36] (03CR) 10Hoo man: [C: 04-1] "Rebased, still needs fixing." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93490 (owner: 10Hoo man) [19:34:18] (03CR) 10Brion VIBBER: [C: 032 V: 032] "landing this experimentally so it can be adjusted :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/93609 (owner: 10Brion VIBBER) [19:34:26] (03PS1) 10Yuvipanda: Fetch only 5 results [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95204 [19:34:31] brion: one more patch! [19:36:46] (03PS2) 10Brion VIBBER: Work in progress: Site info class [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/94047 [19:37:17] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Merging another half-done class so we can keep working on it :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/94047 (owner: 10Brion VIBBER) [19:37:25] ok back to yuvi's stuff :D [19:37:31] :D [19:37:47] brion: mhurd iOS has a bit of catching up to do :D [19:39:31] we'll have a few days to do that ;) [19:40:15] hah checked out a commit into the wrong repo [19:40:21] "why's it not updating!?" hah [19:40:23] YuviPanda: yes! you've set a good pace! [19:41:28] (03CR) 10Brion VIBBER: [C: 032 V: 032] "nice touch!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95110 (owner: 10Yuvipanda) [19:42:12] YuviPanda: is search bar going to do the 'hide on scroll' thing? [19:42:21] or is it going to be fixed to the top of the viewport? [19:42:22] brion: yeah. not implemented yet [19:42:24] ok [19:42:34] brion: the 'quick return' pattern i talked about [19:42:38] see also: Chrome on mobile [19:42:43] just wanted to make sure it's expected that the web view still extends under it [19:42:49] which it is so cool :D [19:43:05] brion: heh yeah [19:43:25] brion: remember the amount of pain having just a fixed position header gave us on phonegap :D [19:43:41] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Note that the web view still extends under the search bar: this is deliberate, as the bar will use the 'quick return' pattern (disappear o" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95113 (owner: 10Yuvipanda) [19:43:46] brion: "I vertically aligned an image, and it took me only one line!" [19:43:49] :D [19:44:02] brion: need graphic assets for the W logo there [19:44:14] *nod* [19:44:32] i'll grab a temp one or bug kaity [19:44:51] brion: i've a black rectangle there [19:44:53] which [19:44:56] I guess is fine [19:44:57] hah [19:44:59] your signature ;) [19:45:20] brion: they need to have appropriate threeline/back button thingy there [19:45:22] brion: see http://developer.android.com/design/patterns/navigation-drawer.html [19:45:29] (03PS5) 10Hoo man: Make collapsible sections accessible to screen reader users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93490 [19:45:33] so a little more care than just dumping a regular w there [19:45:39] ah yeah [19:45:43] tricksy [19:45:53] (03CR) 10Brion VIBBER: [C: 032 V: 032] Handle pressing back when search results are displayed [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95114 (owner: 10Yuvipanda) [19:45:57] (03CR) 10Hoo man: "(5 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93490 (owner: 10Hoo man) [19:47:00] jdlrobson: looking at https://gerrit.wikimedia.org/r/#/c/94901/ [19:47:06] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fetch only 5 results [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95204 (owner: 10Yuvipanda) [19:47:11] thanks aharoni [19:47:30] (03CR) 10Hoo man: "Removed all code for keyboard navigation (and behaviour on desktops w/o screen reader), those will be different changes later. Also addres" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93490 (owner: 10Hoo man) [19:47:58] violetto: whats your opinion on the W logo vs hamburger? [19:48:04] YuviPanda: ok to merge https://gerrit.wikimedia.org/r/#/c/94735/ ? [19:48:08] (03CR) 10Jdlrobson: [C: 04-1] "Claims to need a rebase.." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93018 (owner: 10Kaldari) [19:48:11] brion: looking [19:48:17] mmmmm hamburger [19:48:24] (03PS2) 10Yuvipanda: Fix order of operations in pingback event registration [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/94735 (owner: 10Brion VIBBER) [19:48:37] (03CR) 10Yuvipanda: [C: 032 V: 032] Fix order of operations in pingback event registration [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/94735 (owner: 10Brion VIBBER) [19:48:43] whee [19:49:05] kaity: violetto note that Android convetion is to have *both* http://developer.android.com/design/patterns/navigation-drawer.html [19:49:58] oh sweet we have a patch for incoming urls! YuviPanda you going to review updated https://gerrit.wikimedia.org/r/#/c/95061/2 or shall i? [19:50:18] kaity: violetto and the three lines sortof animate when you open and close the nav drawer [19:50:42] kaity: violetto check out the gmail app or play store pp [19:50:44] *app [19:51:26] awjr, I guess I'm not needed for prio? [19:51:27] kind of a mini hamburger on the side [19:51:32] (sliders?) [19:51:36] * brion wants White Castle now [19:51:48] yeah don't worry about it MaxSem [19:52:02] kebabs! [19:52:04] awjr: are we still having the story prioritization meeting today? [19:52:11] :D [19:52:37] yes kaldari, but don't forget you're optional if you've got more pressing stuff to cope with [19:52:47] brion: yeah sortof half hidden t hree lines [19:53:09] awjr: we're all in the mediawiki.ui hack day [19:53:39] which has on-site lunch scheduled at noon [19:53:48] but maybe we can grab the food and run :) [19:54:40] (03PS3) 10Brion VIBBER: Allow to open Wikipedia pages directly in the app [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95061 (owner: 10Tpt) [19:55:12] i wonder if we can write test cases for that one [19:55:26] ah i think the events changed [19:55:44] brion: the method answerToViewIntent shouldn't exist [19:56:01] just inline it! [19:56:03] awjr: may I opt out as I'm just wrapping up this iteration ? Also preparing for my flight tomorrow and trying to get things all sorted around the house. [19:56:07] ok :D i'll adjust and test it [19:56:13] brion: yeah [19:56:17] rmoen totally; i'll remove you from the upcoming invites [19:56:26] awjr: :/ [19:56:29] brion: trying to not make a new method unless it is a logical unit of work and also not duplicated elsewhere [19:56:58] brion: the bus with the event already handles a new PageTitle, so we shouldn't have a method for it [19:57:30] fair enough :D [19:57:41] hmm [19:57:58] we'll miss you rmoen; you're always welcome to swing by ): [19:57:59] er [19:57:59] awjr: Sad to be leaving the cool kid club [19:58:00] :) [19:58:02] that's more like it [19:58:06] :p [19:58:09] awjr: thanks :) [19:58:16] when i launch the wikipedia app from chrome, the Wikipedia activity shows up as part of Chrome in the app switcher [19:58:18] YuviPanda: we'll be using hamburger for now [19:58:25] we haven't looked into "W" for other languages [19:58:29] violetto: we should stick to android conventions! [19:58:36] well, Logo + the three lines [19:58:37] (03PS4) 10Brion VIBBER: Allow to open Wikipedia pages directly in the app [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95061 (owner: 10Tpt) [19:58:58] YuviPanda: that sounds good to me [19:59:01] violetto: the favicon for all languages is W for example [19:59:12] rmoen: i think i got you off all the invites, lemme know if there are still any lingering mobile cal invites on your calendar [19:59:13] violetto: so no pure three lines :) [19:59:28] also calling it hamburger feels weird to me. og [19:59:29]