[00:06:15] <grrrit-wm>	 (03PS1) 10Jdlrobson: i18n: Fix menu in RTL mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95303 
[00:10:34] <grrrit-wm>	 (03CR) 10Awjrichards: [C: 032] Story 1218: Allow users to modify their UserProfile intro [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93018 (owner: 10Kaldari)
[00:11:09] <awjr>	 jdlrobson: +2'd ^
[00:11:17] <jdlrobson>	 thanks awjr 
[00:11:44] <awjr>	 jdlrobson: anything else high priority?
[00:11:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Story 1218: Allow users to modify their UserProfile intro [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93018 (owner: 10Kaldari)
[00:11:57] <jdlrobson>	 just the nearby pages but i know that's on your radar :)
[00:12:01] <kaldari>	 almost done with the Nearby stuff
[00:12:08] <awjr>	 far out
[00:14:24] <awjr>	 jgonera: mind if i forward your 'state of mobile limn dashboard' email to the analytics team?
[00:14:39] <jgonera>	 awjr, not at all
[00:15:10] <kaldari>	 jdlrobson: Mainly I'm trying to figure out this line...
[00:15:10] <kaldari>	 $( 'body' ).attr( 'id', 'mw-mf-viewport' );
[00:15:30] <kaldari>	 this obviously seems like a bad idea, but it sounds like there's some weird Opera mobile bug that needs this
[00:16:08] <jdlrobson>	 kaldari: let me double check that
[00:16:11] <jdlrobson>	  so basically the mobileBridge 'decorates' the desktop skin so it has elements that mobile expects
[00:16:26] <jdlrobson>	 kaldari: why happens if you remove that line?
[00:16:45] <kaldari>	 well a bunch of styles don't get applied
[00:17:05] <kaldari>	 and probably overlays don't work at all
[00:17:19] <kaldari>	 due to line 15 in Overlay.js
[00:17:36] <kaldari>	 here's what it says...
[00:17:37] <kaldari>	 		// use '#mw-mf-viewport' rather than 'body' - for some reasons this has
[00:17:37] <kaldari>	 		// odd consequences on Opera Mobile (see bug 52361)
[00:17:38] <kaldari>	 		appendTo: '#mw-mf-viewport',
[00:18:46] <jdlrobson>	 ah that's why then
[00:18:57] <kaldari>	 it looks like there's a bunch of stuff depending on this hack, but it feels extra dirty applying it to desktop
[00:19:20] <jdlrobson>	 mm
[00:19:35] * jdlrobson  thinks

[00:19:44] <kaldari>	 it doesn't look like anything else tries to set an ID on body, so it's probably OK
[00:20:23] <jdlrobson>	 kaldari: it /should/ be harmless considering it is a beta feature - but I agree that should be resolved
[00:20:44] <kaldari>	 I think I'll just ask for a FIXME comment for now
[00:21:01] <jdlrobson>	 kaldari: ok i'll do that now
[00:21:40] <grrrit-wm>	 (03CR) 10Kaldari: [C: 04-1] "(3 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92002 (owner: 10Jdlrobson)
[00:22:06] <jdlrobson>	 kaldari: fixing right now don't move
[00:22:39] <kaldari>	 jdlrobson: there's also one other minor request in that -1
[00:23:19] <jdlrobson>	 kaldari: already on it
[00:23:24] <grrrit-wm>	 (03PS9) 10Jdlrobson: Beta desktop feature: Nearby pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92002 
[00:23:27] <jdlrobson>	 ^ kaldari 
[00:23:33] <kaldari>	 rapid
[00:25:39] <kaldari>	 OK, 1 more test run and I'll +2...
[00:29:02] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Beta desktop feature: Nearby pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92002 (owner: 10Jdlrobson)
[00:29:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Beta desktop feature: Nearby pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92002 (owner: 10Jdlrobson)
[00:30:14] <jdlrobson>	 kaldari: whoops just noticed one minor issue
[00:30:25] <kaldari>	 oops, too late :)
[00:30:29] <grrrit-wm>	 (03PS1) 10Jdlrobson: Nearby pages: Don't change the background when open [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95308 
[00:31:04] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Nearby pages: Don't change the background when open [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95308 (owner: 10Jdlrobson)
[00:31:38] <jdlrobson>	 thanks kaldari :)
[00:31:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Nearby pages: Don't change the background when open [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95308 (owner: 10Jdlrobson)
[00:35:16] <awjr>	 MaxSem: when you need a break from PDF stuff, can you please respond to https://bugzilla.wikimedia.org/show_bug.cgi?id=53539
[00:42:24] <grrrit-wm>	 (03CR) 10Awjrichards: [C: 04-1] "seems to work as advertised, but why the new png/svg for the edit icon?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94445 (owner: 10Jdlrobson)
[00:42:57] <kaldari>	 spagewmf: So the documentation says after you have subclassed OO.ui.Dialog, you "let a dialog manager create instances of it as needed". I'm not sure I understand what that part means. Is a "dialog manager" something I build or something that OO.ui provides?
[00:43:10] <grrrit-wm>	 (03PS3) 10Jdlrobson: Center heading on Special:Userlogin and friends [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94445 
[00:47:13] <kaldari>	 spagewmf: It looks like it's something in OO.ui. I think it would be a good idea to add a section on dialog managers to the Ooui page, since it looks like that's an important concept to understand.
[00:53:02] <grrrit-wm>	 (03CR) 10Awjrichards: [C: 032] i18n: Fix menu in RTL mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95303 (owner: 10Jdlrobson)
[00:53:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: i18n: Fix menu in RTL mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95303 (owner: 10Jdlrobson)
[00:55:05] <grrrit-wm>	 (03CR) 10Awjrichards: [C: 032] Center heading on Special:Userlogin and friends [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94445 (owner: 10Jdlrobson)
[00:55:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Center heading on Special:Userlogin and friends [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94445 (owner: 10Jdlrobson)
[01:05:14] <grrrit-wm>	 (03CR) 10Awjrichards: [C: 04-1] "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94620 (owner: 10Jdlrobson)
[01:05:36] <dfoy>	 dr0ptp4kt: ping
[01:05:57] <dr0ptp4kt>	 dfoy, pong
[01:10:32] <grrrit-wm>	 (03CR) 10Jdlrobson: "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94620 (owner: 10Jdlrobson)
[01:22:01] <grrrit-wm>	 (03PS1) 10Jdlrobson: Story 1347 1/2: Use new overlay for this page has issues [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95314 
[01:23:37] <grrrit-wm>	 (03PS2) 10Jdlrobson: Story 1347 1/2: Use new overlay for this page has issues [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95314 
[01:30:29] <jgonera>	 tfinc, graphs seem to be up to date now, except for the one I mentioned in the e-mail. if you experience any problems, try clearing browser cache
[01:32:22] <jdlrobson>	 jgonera: i'm heading off now - make sure you take from mingle any story you want to work on in plane. Before working on any overlay stories I suggest you take a look at https://gerrit.wikimedia.org/r/95314 to understand how my brain is working for serving different overlays in beta/stable
[01:32:29] * jdlrobson  waves everyone goodbye

[01:42:52] <jdlrobson>	 jgonera: can speak a little more turns out i'm not leaving just yet
[01:42:59] <jgonera>	 ok ;)
[01:43:09] <jdlrobson>	 main thing i wanted to do was have two modules for overlays and new overlays and to move away from using mobile.stable and define modules by the feature they required
[01:43:39] <jdlrobson>	 I think in the cleanup templates overlay though ti makes little sense to split them up since the code is so simple
[01:43:54] <jgonera>	 that's a good idea, especially if that grouping is also consistent with directory structure
[01:44:04] <jdlrobson>	 jgonera: yeh we've started it with uploads and editing
[01:44:14] <jgonera>	 it might make it easier for me to experiment with that automatic generation of modules definitions I told you about
[01:44:22] <jgonera>	 sure
[01:44:42] <jdlrobson>	 jgonera: definitely
[01:46:17] <jdlrobson>	 jgonera: if you get a chance pre-flight at the airport would be good to get your feedback on the patch as i'm going to base all of any overlay work i do off that and would love your views to avoid any going back and forth
[01:46:40] <jgonera>	 ok, I'll try
[01:46:49] <jdlrobson>	 anyway really have to go now - basketball game! happy travels and when india pisses you off remember it's part of its charm and to go with it :)
[02:27:45] <grrrit-wm>	 (03CR) 10Shirayuki: "Bug 42631 is about "nested PLURAL"." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94901 (owner: 10Shirayuki)
[03:25:42] <grrrit-wm>	 (03PS2) 10JGonera: Separate stable and beta search JS code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94078 
[03:25:43] <grrrit-wm>	 (03PS1) 10JGonera: [WIP] Story 1099: Better search UX [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95318 
[03:31:17] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] "(1 comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94468 (owner: 10JGonera)
[03:31:40] <grrrit-wm>	 (03CR) 10JGonera: Separate stable and beta search JS code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94078 (owner: 10JGonera)
[03:31:56] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-2] "Still WIP..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95318 (owner: 10JGonera)
[03:51:23] <StevenW>	 Woo! 
[03:51:30] <StevenW>	 jgonera: https://gerrit.wikimedia.org/r/#/c/93584/
[03:51:49] <StevenW>	 One small step for man, one giant leap for UI library compatibility.
[08:59:06] <grrrit-wm>	 (03CR) 10Hoo man: "Got a reply from Graham. He commented on the fact we rely on aria for keyboard navigation support. "For what it's worth I can still toggle" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93490 (owner: 10Hoo man)
[16:07:33] <grrrit-wm>	 (03PS7) 10Cmcmahon: QA: Attempt to get around bogus failure to type password [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94273 
[16:12:19] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] QA: Attempt to get around bogus failure to type password [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94273 (owner: 10Cmcmahon)
[16:13:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: Attempt to get around bogus failure to type password [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94273 (owner: 10Cmcmahon)
[17:40:21] <grrrit-wm>	 (03PS3) 10Jdlrobson: Story 1347 1/2: Use new overlay for this page has issues [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95314 
[17:40:22] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Cleanup enwp.less prepare to destroy it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95452 
[17:40:23] <grrrit-wm>	 (03PS1) 10Jdlrobson: Story 1347 2/2: Update this page has issues in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95453 
[17:44:54] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94078 (owner: 10JGonera)
[18:00:44] <grrrit-wm>	 (03PS4) 10Jdlrobson: Story 1347 1/2: Use new overlay for this page has issues [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95314 
[18:00:45] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Cleanup enwp.less prepare to destroy it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95452 
[18:00:46] <grrrit-wm>	 (03PS2) 10Jdlrobson: Story 1347 2/2: Update this page has issues in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95453 
[18:05:06] <brion>	 ok, i got my HDMI capture setup working on Nexus 5 with just two widgets (HDMI capture, plus an EDID emulator to force the mode to one that works with the capture widget)
[18:05:18] <brion>	 one's powered by thunderbolt, the other by usb
[18:05:24] <brion>	 so no AC power plug needed
[18:05:41] <brion>	 lemme see if i can reproduce it on stock nexus 4
[18:25:45] <awjr>	 MaxSem: any luck with the solr issue on betalabs?
[18:26:29] <MaxSem>	 nope - don't know what could've happened
[18:26:59] <awjr>	 MaxSem: i know you're busy with pdf stuff - is there someone else i can poke to look into it?
[18:27:20] <MaxSem>	 hmm - is there someone who knows java?
[18:27:30] <awjr>	 maybe the search guys?
[18:27:35] <MaxSem>	 they might be of much more use than me anyway:P
[18:27:44] <awjr>	 heh ok i'll ask chad or nick
[18:28:17] <jdlrobson>	 awjr: is there a bug open for that?
[18:28:29] <awjr>	 not yet jdlrobson
[18:28:45] <awjr>	 at least, not that i know if
[18:28:48] <awjr>	 *of
[18:28:56] <jdlrobson>	 awjr: worth opening one so we don't lose track of the issue?
[18:29:05] <jdlrobson>	 awjr: i'm gonna run out of stories today fyi
[18:29:22] <awjr>	 yeah jdlrobson; im just checking the state of things on betalabs now; i can open it when im done
[18:29:25] <awjr>	 jdlrobson: o_O
[18:30:22] <awjr>	 do you know if juliusz still workin gon the search ux stuff or did he finish and forget to move the card, jdlrobson?
[18:30:30] <awjr>	 looks like he also grabbed the edit ui overhaul card
[18:30:57] <awjr>	 jdlrobson: if you run out of cards today, maybe you can help jcmish with the 'ready for testing' column
[18:31:02] <jdlrobson>	 awjr: it's a good problem to have :)
[18:31:06] <awjr>	 yes :)
[18:31:31] <jdlrobson>	 awjr: i guess/hope juliusz will work on the search overlay and edit overlay on the plane and have them ready for me on touchdown
[18:31:53] <awjr>	 aye
[18:35:35] <jdlrobson>	 awjr: i realize it's a huge patch - but i'm going to have massive merge conflicts with https://gerrit.wikimedia.org/r/#/c/94247/ not merged
[18:35:38] <jdlrobson>	 any chance you could take a look?
[18:36:15] <awjr>	 yes jdlrobson
[18:36:19] <awjr>	 soon
[18:36:21] <jdlrobson>	 thanks dude
[18:42:04] <awjr>	 chrismcmahon: have your tucson plans firmed up yet?
[18:42:31] <chrismcmahon>	 awjr: I'm driving to Tucson tomorrow actually, will be there for about 3 months
[18:42:58] <awjr>	 nice!
[18:43:11] <jcmish>	 awjr:  I told chrismcmahon you love to entertain!
[18:43:16] <awjr>	 lol
[18:43:18] <jcmish>	 and buy drinks especially
[18:43:18] <awjr>	 it's true
[18:43:19] <jcmish>	 ;-)
[18:43:31] <awjr>	 chrismcmahon: especially if you help us move into our new house ;)
[18:44:01] <chrismcmahon>	 awjr: might could.  when do you move? 
[18:44:08] <awjr>	 tbd
[18:44:19] <awjr>	 im partially kidding anyway; we should definitely hang out
[18:45:44] <chrismcmahon>	 awjr:  for sure.  
[18:52:04] <jdlrobson>	 kaity: you there?
[18:52:35] <jdlrobson>	 kaity: i'm looking at https://www.dropbox.com/s/vyl5vftst9tkk9l/notifications-overlay-02.png and wondering about the styling of the '2'
[18:54:50] <jdlrobson>	 kaity: ping me when you are back :)
[18:58:52] <kaity>	 jdlrobson: hello!
[18:59:06] <jdlrobson>	 kaity!
[18:59:26] <jdlrobson>	 basically i'm wondering why the 2 is so close to the header - shouldn't we just show the echo number as it is when the overlay is closed on the right?
[18:59:32] <tfinc>	 brion: yo. reminder about our retrospective @ 11 today
[18:59:38] <brion>	 yep
[18:59:43] * brion  fires up Hangouts

[19:00:45] <kaity>	 oh I see. Thats a good point
[19:01:01] <kaity>	 I'll get back to you after this meeting
[19:01:17] <kaity>	 30 min at most
[19:01:55] <tfinc>	 brion: https://docs.google.com/a/wikimedia.org/spreadsheet/ccc?key=0AlEIL4N8KjNndHp1LTlmbkFqRkV0amNIRUhxaHdmV1E&usp=drive_web
[19:01:55] <jdlrobson>	 thanks kaity
[19:02:07] <jdlrobson>	 (note it would actually be a lot easier to reuse the styling of the button when closed)
[19:03:31] <awjr>	 blergh jdlrobson i havent gotten to the review yet - can it wait til later this afternoon?
[19:03:36] <jdlrobson>	 awjr: sure
[19:03:40] <awjr>	 kk
[19:03:44] <jdlrobson>	 i'm resigned to having to rebase
[19:03:51] <awjr>	 :(
[19:31:58] <jdlrobson>	 kaity: looks like http://imgur.com/RMVKNKB
[19:44:24] <kaity>	 jdlrobson: I put the number next to the header bc its following the modal overlay pattern of "Header" "context"
[19:44:38] <kaity>	 like in the upcoming language overlay https://www.dropbox.com/s/s0lzlo5oeyyabmf/language-overlay-01.png
[19:44:59] <kaity>	 if we leave it where the button was, it still looks like a button, but doesn't do anything
[19:52:38] <jdlrobson>	 kaity: ok that makes sense. Still seems very close though?
[19:52:57] <jdlrobson>	 i thought it was a mistake in the design when i first saw it
[19:53:19] <kaity>	 jdlrobson: true. Can we increase the space just a little?
[19:53:25] <jdlrobson>	 sure i'll have a fiddle around
[19:53:34] <kaity>	 thanks!!!
[19:59:57] <jdlrobson>	 awjr_lunch: er… https://m.mediawiki.org/wiki/Special:Nearby
[20:00:11] <jdlrobson>	 i guess mediawiki having issues
[20:01:39] <jdlrobson>	 kaity: http://imgur.com/hw6syLz
[20:02:39] <awjr>	 jdlrobson: there has been an ongoing outage, i presume it is related
[20:02:52] <kaity>	 can we move it back towards the header just the tiniest tiniest bit?
[20:03:04] <jdlrobson>	 kaity: sure
[20:03:26] <awjr>	 although apparently site should have recovered by now...
[20:03:32] <awjr>	 jdlrobson:  i gotta run to a mtg but iwll check back after
[20:03:46] <jdlrobson>	 kaity: ok
[20:13:10] <grrrit-wm>	 (03PS1) 10Jdlrobson: Story 1345: Redesign notifications overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95482 
[20:52:17] <StevenW>	 awjr: invite sent
[20:52:24] <awjr>	 thanks StevenW
[20:52:29] <StevenW>	 for the test, I just put our current sprint items in there
[20:52:50] <StevenW>	 so it's missing some of the epics that are in analysis
[20:53:27] <awjr>	 right on, i'll take a look probably later this afternoon
[21:03:17] <tfinc>	 jcmish: you about ?
[21:27:04] <jdlrobson>	 awjr: since i'm going to run out of things to do this week maybe i can pair with you to automate those deployment scripts
[21:27:25] <jdlrobson>	 since i also have that weekly report mailer would maybe be good to put all these scripts in one place with bingle etc
[21:28:57] <awjr>	 jdlrobson: i think that's a great idea
[21:28:59] <awjr>	 hows your python?
[21:29:07] <awjr>	 (bout to run to a mtg)
[21:29:37] <jdlrobson>	 awjr: my python is exquisite if not a little rusty
[21:29:44] <jdlrobson>	 it's my preferred scripting language
[21:30:01] <awjr>	 awesome, you can teach me some good stuff ):
[21:30:02] <awjr>	 er
[21:30:03] <awjr>	  :)
[21:30:06] <awjr>	 that's what i meant
[21:30:09] <awjr>	 ok mtg
[21:30:16] <awjr>	 jdlrobson: also, we need to get those cards out of 'in testing'!
[21:30:19] <awjr>	 can you work with jcmish?
[21:30:42] <tfinc>	 awjr: i'm seeing R37 go late
[21:30:55] <jdlrobson>	 awjr: i can try although i have a steep learning curve still to write a lot of tests.
[21:30:57] <awjr>	 tfinc: i hope you are making faces at them through the window
[21:31:11] <tfinc>	 not yet but it may come to that
[21:31:24] <awjr>	 jdlrobson: i dont think they need tests per se, just validated - im actually not 100% what all goes into 'testing' but jcmish can fill you in :)
[21:31:33] <jdlrobson>	 k i will wait to hear from jcmish  :)
[21:31:38] <awjr>	 w00t
[21:31:45] <jdlrobson>	 luckily i have bugs and one last story to work on in the meantime
[21:31:54] <awjr>	 how did you get through everything?!
[21:32:19] <jcmish>	 sorry folks talking ot Chris
[21:32:58] <jcmish>	 jdlrobson:  you just need to walk through testing the stories and making sure they work as expected on betalabs
[21:33:06] <jcmish>	 and well now test2 :D 
[21:33:13] <jdlrobson>	 jcmish: ok i can definitely help with that
[21:33:41] <jcmish>	 yep then we let kenan know they look good
[21:33:47] <jcmish>	 he takes a pass and accepts them
[22:36:59] <jdlrobson>	 brb
[22:59:57] <MaxSem>	 awjr, GeoData on beta should work now
[23:00:19] <awjr>	 cool! that saves me from creating the bug i meant to create hours ago :p
[23:00:26] <awjr>	 thanks MaxSem, what was the issue?
[23:00:38] <MaxSem>	 https://gerrit.wikimedia.org/r/95559
[23:01:13] <awjr>	 bah still getting the api error MaxSem
[23:01:22] <awjr>	 oh it was just merged
[23:01:26] <MaxSem>	 eh? jetty starts now
[23:01:30] <awjr>	 oom!
[23:01:42] <MaxSem>	 face motherfucking palm
[23:01:48] <awjr>	 hahaha
[23:01:56] <awjr>	 at least it was betalabs :p
[23:02:14] <MaxSem>	 who pushed so much data into it?
[23:02:15] <awjr>	 yeah, still erroring; i'll try again in a bit
[23:04:54] <MaxSem>	 and now?
[23:05:09] <MaxSem>	 what URL are you trying?
[23:05:31] <awjr>	 http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Nearby
[23:05:33] <awjr>	 mp wprlu
[23:05:34] <awjr>	 er
[23:05:35] <awjr>	 no worky
[23:07:30] <jdlrobson>	 me back
[23:07:40] <awjr>	 jdlrobson: i dont see anything scary in that refactor
[23:07:44] <awjr>	 im testing now
[23:07:51] <awjr>	 it is much cleaner :)
[23:08:32] <MaxSem>	 hmm Solr HTTP error: Not Found (404)
[23:08:37] <MaxSem>	 that's something new
[23:13:45] <grrrit-wm>	 (03PS1) 10Jdlrobson: Story 1360: Add paging to Special:History and enable link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95561 
[23:13:47] <grrrit-wm>	 (03PS1) 10Jdlrobson: Redirect action=history links to mobile view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95562 
[23:14:07] <awjr>	 actually jdlrobson the changeset introduces a PHP warning
[23:14:08] <awjr>	 [Thu Nov 14 15:11:46 2013] [error] [client 127.0.0.1] PHP Warning:  Invalid argument supplied for foreach() in /mnt/hgfs/wikimedia_git/extensions/MobileFrontend/includes/skins/MinervaTemplate.php on line 68
[23:14:19] <jdlrobson>	 awjr: mmm  how odd
[23:14:21] <jdlrobson>	 how do you replicate?
[23:14:30] <awjr>	 load any page :)
[23:14:41] <jdlrobson>	 you running latest core?
[23:14:59] <awjr>	 yes jdlrobson
[23:15:09] <awjr>	 i havent investigaged the code yet
[23:15:13] <jdlrobson>	 awjr: looking now
[23:15:19] <awjr>	 kk
[23:15:35] <dr0ptp4kt>	 yurik you there?
[23:15:55] <jdlrobson>	 seems related to languages awjr 
[23:16:08] <awjr>	 yeah though it doesn't happen for me on current master
[23:16:32] <jdlrobson>	 can't seem to replicate that on my local instance..
[23:16:56] <jdlrobson>	 ahh got it
[23:18:11] <awjr>	 $this->getLanguages() is returning false, which makes count( $languages ) return 1
[23:18:15] <awjr>	 yay php
[23:18:48] <jdlrobson>	 php count grr
[23:19:03] <awjr>	 should probably do a if ( is_array(  $languages ) )
[23:19:15] <awjr>	 same with variants
[23:19:33] <jdlrobson>	 yeh already on it now
[23:19:58] <awjr>	 groovy
[23:20:14] <awjr>	 i still dont see why this is happening in the refactor but not in master
[23:21:16] <jdlrobson>	 awjr: fixing now
[23:21:24] <jdlrobson>	 awjr: i guess core sets it to false not an empty array
[23:21:58] <grrrit-wm>	 (03PS4) 10Jdlrobson: Hygiene: The big skin cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94247 
[23:22:03] <jdlrobson>	 ^ awjr there you go
[23:23:38] <awjr>	 argh mw core gives me a headache
[23:25:09] <jdlrobson>	 awjr:  :)
[23:25:45] <awjr>	 actuallya s far as i can tell jdlrobson it sets it to an empty array...
[23:25:57] <awjr>	 something else may be broken
[23:26:21] <jdlrobson>	 awjr: languages seem to work fine though..
[23:26:23] <awjr>	 which if that's the case, your fix may hide it at least for me in testing since i dont have languages set up locally
[23:26:25] <awjr>	 ah ok
[23:26:29] <awjr>	 you have langs set up jdlrobson?
[23:26:35] <jdlrobson>	 awjr: just noticed a nasty bug on nearby.. i hope it didn't get on the deployment train
[23:26:41] <jdlrobson>	 (the refresh icon is screwed up)
[23:26:52] <jdlrobson>	 awjr: yes i have languages setup...
[23:26:57] <awjr>	 ok then
[23:27:22] <awjr>	 jdlrobson: refresh icon looks the same as usual to me: http://m.mediawiki.org/wiki/Special:Nearby
[23:27:46] <jdlrobson>	 awjr: did the deployment go out today?
[23:27:50] <jdlrobson>	 i thought it was cancelled?
[23:28:08] <jdlrobson>	 i'm seeing the issue on master anyhow
[23:28:53] <awjr>	 it appears to have happened, jdlrobson - mediawiki.org is running 1.23wmf4
[23:29:05] <awjr>	 jdlrobson: in betalabs the icon looks OK
[23:29:07] <jdlrobson>	 awjr: ok maybe we're ok then.. :)
[23:29:12] <jdlrobson>	 still i'm going to fix it now on master
[23:29:15] <awjr>	 http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Nearby
[23:30:05] <awjr>	 oh, i take it back jdlrobson, it does get set to false in core >_<
[23:30:14] <awjr>	 found it.
[23:30:29] <jdlrobson>	 actually wait awjr think there might be a major issue with that refactor
[23:30:35] <awjr>	 !
[23:30:35] <jdlrobson>	 give me 10 mins to double check
[23:30:41] <awjr>	 kk i'll keep poking
[23:30:41] <jdlrobson>	 (i think it might be loading styles twice)
[23:31:41] <awjr>	 doesnt seem to be in master, jdlrobson
[23:31:45] <awjr>	 er in stable i mean
[23:31:53] <jdlrobson>	 you sure?
[23:32:05] <awjr>	 well i only see one request for CSS files on article pages
[23:32:06] <jdlrobson>	 i'm seeing requests for http://localhost.m/w/load.php?debug=true&lang=en&modules=mobile.nearby.styles&only=styles&skin=mobile&target=mobile&* and http://localhost.m/w/load.php?debug=true&lang=en&modules=mobile.nearby.styles&only=styles&skin=vector&version=20131114T232200Z&*
[23:32:14] <jdlrobson>	 maybe it's just a debug mode thing?
[23:32:44] <jdlrobson>	 actually awjr i'm seeing it on master so probably something else
[23:33:06] <awjr>	 yeah i am not seeing that (but i don't have ?debug=true)
[23:33:16] <awjr>	 that seems to be loading styles for vector
[23:33:20] <awjr>	 as well as mobile skin
[23:34:43] <jdlrobson>	 awjr: the refresh icon issue i'm seeing only whilst logged in
[23:35:02] <awjr>	 ah
[23:35:04] <awjr>	 same thing with the styles?
[23:35:17] <awjr>	 or is the icon thing the same as the style issue?
[23:35:20] <jdlrobson>	 yup it might actually be BetaFeatures...
[23:35:25] <awjr>	 ha
[23:35:33] <awjr>	 that may explain why i am not seeing it
[23:35:57] <jdlrobson>	 haha yeh it's beta features
[23:35:57] <jdlrobson>	 funny
[23:36:06] <awjr>	 the refactor is looking OK to me jdlrobson
[23:36:09] <jdlrobson>	 ok less urgent then :)
[23:36:47] <awjr>	 one tiny quibble jdlrobson
[23:37:03] <jdlrobson>	 awjr: go for it
[23:37:07] <awjr>	 SkinMobile::preparePageContent() doesn't have any scope defined
[23:37:11] <awjr>	 similar methods are marked as protected
[23:37:20] <grrrit-wm>	 (03PS1) 10Jdlrobson: Don't load beta features code on mobile. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95568 
[23:37:21] <jdlrobson>	 awjr: I can fix that right this minute
[23:37:47] <awjr>	 ok, i am happy to merge after that
[23:37:56] <jdlrobson>	 sweet on its way
[23:38:40] <grrrit-wm>	 (03PS5) 10Jdlrobson: Hygiene: The big skin cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94247 
[23:38:44] <jdlrobson>	 ^ awjr done
[23:39:05] <awjr>	 oh wait
[23:39:15] <awjr>	 what happened to setting the robotpolicy?
[23:39:30] <awjr>	 it was removed in SkinMobile but i dont see it replaced anywhere
[23:39:35] <grrrit-wm>	 (03PS2) 10Jdlrobson: Don't load beta features code on mobile. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95568 
[23:39:47] <jdlrobson>	 awjr: it should be provided by core.. is it not? let me check
[23:40:01] <awjr>	 it may be but it wasn't in the dependency
[23:40:54] <jdlrobson>	 err… awjr i'm not seeing it on live enwiki… https://en.m.wikipedia.org/wiki/Main_Page view source
[23:41:20] <jdlrobson>	 with that patch i see <meta name="robots" content="noindex,nofollow" />
[23:41:52] <awjr>	 well you should only see it with wgMFNoindexPages == true
[23:42:01] <awjr>	 not sure how that's set in prod
[23:42:02] <jdlrobson>	 ahhhh
[23:42:07] <awjr>	 i can check
[23:42:38] <jdlrobson>	 yeh little confused now
[23:42:44] <awjr>	 but that functionality doesn't appear to be replicated anywhere in core - it's a MF variable
[23:43:53] <jdlrobson>	 awjr: ok i can reinstore that
[23:44:01] <jdlrobson>	 is it correct that en.m.wikipedia shows in search results? 
[23:44:02] <jdlrobson>	 https://www.google.com/#q=site:en.m.wikipedia.org
[23:44:19] <awjr>	 we set it to false everywhere in produciton
[23:44:52] <awjr>	 so, mobile pages should be getting indexed
[23:45:48] <awjr>	 MaxSem: appears to have added the var about a year and a half ago
[23:46:26] <awjr>	 jdlrobson: should probably leave that alone in this patchset
[23:46:34] <MaxSem>	 every time we try enabling indexing, google screws it up
[23:46:51] <awjr>	 MaxSem: it's enabled now isnt it?
[23:46:56] <awjr>	 wgMFNoindexPages == false in prod
[23:47:02] <MaxSem>	 ah
[23:47:06] <jdlrobson>	 good catch awjr - fixing now
[23:47:24] <MaxSem>	 I must have forgotten the last iterationXD
[23:47:32] <awjr>	 heh
[23:48:19] <awjr>	 ok, i *think* the rest of it is ok
[23:48:47] <grrrit-wm>	 (03PS6) 10Jdlrobson: Hygiene: The big skin cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94247 
[23:49:34] <jdlrobson>	 ^ awjr done
[23:49:53] <awjr>	 kk jdlrobson im going through a little more carefully one more tie
[23:49:54] <awjr>	 *tie
[23:49:56] <awjr>	 damn it
[23:49:56] <awjr>	 time
[23:55:08] <awjr>	 er adding talk topics appears broken in master
[23:55:11] <awjr>	 jdlrobson: ^
[23:56:59] <jdlrobson>	 awjr: huh? what by?
[23:57:10] * awjr  shrugs

[23:57:18] <awjr>	 it appears that i can add talk topics via mobile
[23:57:23] <awjr>	 but they do not appear to be saved
[23:57:32] <jdlrobson>	 awjr: my patch introduced that? or this is another bug?
[23:57:40] <jdlrobson>	 it's happened before so wouldn't be surprised..
[23:57:40] <awjr>	 no, it's in master - it's not in the refactor
[23:58:16] <grrrit-wm>	 (03PS1) 10Jdlrobson: Regression: Fix upload button on Special:Uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95570 
[23:58:53] <grrrit-wm>	 (03CR) 10Awjrichards: [C: 032] "looks ok now; fingers crossed :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94247 (owner: 10Jdlrobson)
[23:59:25] <jdlrobson>	 awjr: i'll investigate that now
[23:59:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: The big skin cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94247 (owner: 10Jdlrobson)
[23:59:35] <grrrit-wm>	 (03CR) 10JGonera: "(2 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94078 (owner: 10JGonera)