[00:01:37] ^ awjr just noticed this minor issue with uploads whilst testing if you don't mind looking at it [00:03:12] the upload button jdlrobson? [00:03:40] awjr: yup [00:03:42] jdlrobson: the big skin cleanup merged ok with no rebase :D [00:03:47] or rather, with no conflicts [00:07:29] eh jdlrobson i dont see the problem you mentioned in the commit message, and applying the patch seems to make no difference in how things look to me on Special:Uploads in stable [00:07:47] this is for the big blue 'contribute an image' button? [00:07:53] yeh i see the icon overlap [00:07:56] it seems to depend on load order [00:08:01] oh weird [00:08:57] well the css rule doesn't seem to hurt anything [00:09:24] (03CR) 10Awjrichards: [C: 032] Regression: Fix upload button on Special:Uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95570 (owner: 10Jdlrobson) [00:10:03] (03Merged) 10jenkins-bot: Regression: Fix upload button on Special:Uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95570 (owner: 10Jdlrobson) [00:29:43] awjr: is there any way to make the popups on mingle show the bugzilla url as a link and save me one click each time? [00:30:12] not that i know of [00:30:28] chrome gadget maybe :p [00:31:42] awjr: haha notice anything weird about this page…? http://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:MobileOptions&returnto=Special%3AUploads [00:31:56] kik [00:31:57] er [00:31:58] lol [00:32:03] man ive been doing that all day.. [00:32:11] was that from the language fix? [00:32:38] it seems special pages sometimes show broken languages buttons now.. fixing as we speak [00:32:54] actually jdlrobson the language overlay doesn't appear to be showing language names either [00:33:10] at least on stable [00:33:27] or in beta [00:33:42] awjr: works for me on stable.. [00:34:15] wtf though - i can't replicate the language issue on my local instance :-S [00:34:31] weird, i see the dividers for the languages, although i cant see the lang names nor does tapping on them do anything [00:34:54] FFS [00:34:55] uls-p-lang-dummy [00:34:58] wtf is that [00:35:30] universal language selector horribleness [00:35:56] looks like i need to install universe language selector here [00:36:32] argh there have been a lot of uls issues [00:37:32] languages working fine here.. http://en.m.wikipedia.beta.wmflabs.org/wiki/San_Francisco [00:38:12] awjr: once downloaded i'll raise a bug against UniversalLanguageSelector about uls-p-lang-dummy [00:38:28] awjr: almost gone through the in testing column [00:38:38] yeah langs look fine on sf [00:38:49] try this tho jdlrobson http://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=0.8893721290643325_Moved&campaign=random [01:02:47] awjr: do you have that blog post draft up ? [01:02:58] tfinc funny that you mention it [01:03:04] i am making some more edits and then will share [01:03:41] k, i've been tempted to pick up some of the others we've talked about so i want to see yours first [01:15:51] tfinc: https://docs.google.com/a/wikimedia.org/document/d/1tiwXn_vsFW0bUEyMITjEFX2CIh6V9L5uEFb7R3yBmkc/edit [01:15:54] email coming [01:16:46] fun. i'll start the email and take a spin through it tomorrow [01:16:59] then i'll know which other chapter i want to work on :) [01:17:06] :D [01:17:53] awjr: https://bugzilla.wikimedia.org/show_bug.cgi?id=57091 not sure what to do about this [01:18:51] well, it's not in production yet jdlrobson [01:19:12] awjr: UniversalLanguageSelector isn't? I thought it was [01:19:14] but it feels urgent to cope with before it does [01:19:14] ? [01:19:22] oh jdlrobson yes, but the issue in the bug is not present in prod [01:19:26] afaict [01:20:01] https://test2.m.wikipedia.org/w/index.php?title=Special:MobileOptions&returnto=Main+Page [01:21:00] jdlrobson: but we should follow up with an emial to the language team because it is kinda urgent [01:21:13] you wanna write it since you found the problem? [01:21:19] awjr: sure [01:21:24] what's the right mailing list for that? [01:21:28] do you have their team email? [01:21:28] wikitech? [01:21:28] ah [01:21:49] well [01:21:52] hmm [01:22:01] probably [01:22:03] awjr: i've put it on our story board [01:22:10] we have till next thursday to fix this [01:22:19] more and more we've been using team-specific lists, but i think this is good for the engineering public [01:23:47] legoktm: jdlrobson: ULS is deployed on all WMF wikis [01:24:17] last i heard jdlrobson the language team has been responding quickly to ULS issues, so hopefully this will be no exception [01:24:33] ok cool. well i'll follow up on it tomorrow [01:24:49] i had a look at the code and i'm not quite sure how to resolve it - seems to be a hack in place to ensure language list always shows [01:27:39] awjr: how do i change a config variable on beta labs? [01:28:25] jgonera: are you in india?! [01:28:35] No, on a plane [01:28:48] jdlrobson: in the same config file as you would for prod, but the file ends in -labs [01:28:50] But not airborne [01:28:57] well, filename [01:28:59] o [01:29:08] jgonera: where are you? [01:29:11] newark? [01:29:21] Jdlrobson can you send me your local settings with ve enabled to me email? [01:29:34] Yeah, still Newark. [01:29:38] zomg sarah is cooking bacon and my office is right next to our kitchen [01:29:41] it's really hard to concentrate [01:30:07] are you flying direct to india from there? [01:30:08] I always close all the doors when cooking bacon ;) [01:30:16] hehehe i have no doors to my office [01:30:19] Awjr, yes [01:30:30] dang how long is that flight? [01:30:39] To Mumbai, staying there 2 days [01:30:43] 15h [01:30:52] oof [01:31:16] i start to go totally batty after 12h on a plane [01:31:31] I'm extremely lucky to have a free seat next to me. [01:31:59] actually last time i flew to india, i flew HOU -> FRA, FRA -> BLR but there was a medical emergency on the HOU -> FRA leg, while we were over the middle of the atlantic ocean [01:32:27] I'll probably sleep a couple of hours in the middle of the flight but not too much so that I arrive tired to Mumbai [01:32:27] so the plane had to turn around and land in montreal [01:32:38] i wound up being on the plane for about 18 hours [01:32:47] Ugh... [01:32:52] yeah that was nuts [01:32:57] but yay to empty seat next to you :) [01:33:13] ;) [01:33:16] the silver lining was that they put me up in a hotel in FRA that night and bumped me to biz class for my flight bangalore the enxt day [01:33:23] jdlrobson are you there? [01:33:24] there was a glass of champagne in my hand before i even sat down... [01:33:32] jgonera: i haven't got VE enabled here - we did it all on rob's machine [01:33:41] jgonera: what exactly is the issue you are running into ? [01:34:08] jdlrobson it just doesn't work, no additional edit tab [01:34:17] jgonera: ok so checklist [01:34:20] does it work on desktop? [01:34:26] But I can see ve experentla mode in beta features [01:34:42] No, I'm talking about desktop [01:35:08] jgonera: ok 1s [01:35:18] Is Rob somewhere out there? Tell him to send me his config then ;) [01:35:55] $wgVisualEditorDisableForAnons = true [01:35:57] jgonera: try that [01:36:23] i'm digging through the code - seems there is a way to make it enable always [01:36:33] Awjr a glass of champagne to celebrate that you're going in the right direction? ;) [01:36:40] hehehe [01:37:00] I'll try when they let me use my laptop. [01:37:08] jgonera: rob's already on a plane [01:37:26] i discovered we were making the emergency landing by looking at the flight tracker and noticing that the plane was going the wrong way... [01:37:34] Oh, I see [01:37:49] Well maybe I'll figure this out [01:38:00] actually jgonera $wgDefaultUserOptions['visualeditor-enable'] = 1; [01:38:02] that should do it! [01:38:11] Awjr they didn't tell you? [01:38:12] Hah [01:38:22] jgonera: not until about 30 mins before we actually landed! [01:38:49] Can you send that line to my email? [01:39:25] jgonera: i'm just triyng it out now but sure i can [01:39:34] dr0ptp4kt, looking for me? [01:39:45] Awjr wow... On my previous flight I couldn't even do it. It had direct TV and I'd have to pay to watch the flight tracker... [01:39:53] jgonera: done [01:40:03] Thanks jdlrobson [01:40:10] it seems to work [01:40:22] Cool [01:40:29] i can see an edit button in anonymous mode and click it and it throws a parsoid error as i have no parsoid [01:40:39] btw jgonera i finished all the other overlay redesigns not sure if you saw that [01:40:44] pay for the flight tracker! [01:40:46] OK, I have it so it should work [01:40:49] dang [01:40:49] i'm expecting rebase issues ;-) [01:40:52] what airline was that?! [01:41:03] dr0ptp4kt, yeah, was wondering if you had a chance to look at that mediawiki-config related email [01:41:17] Jdlrobson, no, I haven't yet. [01:41:20] oh hey guys [01:41:28] You didn't do the editor thoigh right? [01:41:32] Awjr united [01:41:35] hey greg-g what's up [01:41:36] jgonera nope didn't touch editor [01:41:45] sheesh they charge you for everything [01:41:52] quick question: on the deploy calendar I have "November: Mobile - User Profiles in Alpha " from tfinc, but just curious what the status is of that [01:41:56] OK, will work on that on the plane [01:42:05] And review yours when I have internet [01:42:11] @_@ [01:42:15] (03PS5) 10Jdlrobson: Story 1347 1/2: Use new overlay for this page has issues [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95314 [01:42:20] greg-g: we actually already have user profiles in beta [01:42:25] well then [01:42:27] :) [01:42:28] (03PS3) 10Jdlrobson: Hygiene: Cleanup enwp.less prepare to destroy it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95452 [01:42:31] (03PS3) 10Jdlrobson: Story 1347 2/2: Update this page has issues in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95453 [01:42:39] wait, what do you mean by beta/ [01:42:43] and what is meant by alpha? [01:42:46] * greg-g isn't sure [01:42:54] greg-g: mobile has 3 modes - beta, alpha and stable [01:42:55] mobile web has three different states: alpha, beta, stable [01:42:57] jinx [01:42:57] (sorry to interrupt) [01:43:02] :) [01:43:12] greg-g: beta and alpha are optin via a cookie and audiences are much lower [01:43:16] ok, that's what I thought, just we have the stupid overload of beta around here :) [01:43:27] (03PS2) 10Jdlrobson: Story 1345: Redesign notifications overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95482 [01:43:28] heh [01:43:45] so, alright, I'll go ahead and remove that line.... [01:43:47] we're the original beta grrrit-wm [01:43:48] thanks all! [01:43:51] greg-g: [01:43:54] for us, alpha is basically a developer sandbox to try crazy things out in production, beta receives oversight form product [01:43:55] np [01:44:01] heh, don't call me gerrit [01:44:09] lol [01:44:11] zing! [01:44:53] K plane is moving, logging out. [01:45:52] fly safe jgonera [01:50:00] dr0ptp4kt, talking to self, eh? :) [01:50:40] (03PS4) 10Jdlrobson: Alpha: Use the same chrome on special pages as article pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94435 [01:51:32] yurik, ha. how else would devs get through the day? i'm talking about the subject "Deploy after merge on mediawiki-config" [01:51:52] yeah, there is really no rush on that one, lets do it wed [01:52:18] (03CR) 10Jdlrobson: "I'm still puzzled about what the problem is here." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94901 (owner: 10Shirayuki) [01:53:38] yurik, cool man. [01:53:52] jdlrobson: hi [01:53:54] 3:53 am here. waiting for a flight to Mumbai. noticed the bug about ULS. [01:53:55] I cannot reproduce it on my laptop. [01:53:56] where do you see the language button? [01:54:11] aharoni: http://en.m.wikipedia.beta.wmflabs.org/wiki/Foo [01:54:30] if you disable javascript you'll see what's going on [01:54:57] it says this page is available in one language and there is a list with a single list item with class="uls-p-lang-dummy" [01:55:04] even though this page doesn't exist [01:56:05] uls-p-lang-dummy! I remember adding that ugly hack. [01:59:29] meh. [01:59:31] OK, got it. [01:59:39] it's probably not new. [01:59:47] thanks for reporting. [02:05:13] (03PS3) 10Jdlrobson: Alpha: Experiment to collapse sections in JavaScript [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94245 [02:05:22] (03Abandoned) 10Jdlrobson: Minerva: Make it possible to run toggling code on desktop skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94246 (owner: 10Jdlrobson) [02:05:48] (03CR) 10Jdlrobson: [C: 04-1] "Need to fix Max's edge case. Not sure how though." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94245 (owner: 10Jdlrobson) [02:05:50] (03CR) 10jenkins-bot: [V: 04-1] Alpha: Experiment to collapse sections in JavaScript [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94245 (owner: 10Jdlrobson) [02:12:00] im outta here [02:12:03] jdlrobson: you back in the office tmrw? [02:12:14] awjr: nope on monday :) [02:12:20] okidoke [02:12:35] i shoul dhave time tomorrow to play around with various scripts and bingle and stuff if you wanna pair at all [02:13:46] sweet [02:17:47] jdlrobson: I suspect that I'm going to find a related bug there. [02:17:59] another one, but similar. [16:49:38] [[Zero:436-01]]; ABaso(WMF); Preparing production IP addresses for launch next week (config still disabled until then).; https://meta.wikimedia.org/w/index.php?diff=6376130&oldid=6343305&rcid=4666484 [17:02:40] (03PS1) 10Jdlrobson: Strengthen .tutorial selector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95636 [17:10:30] (03PS3) 10Jdlrobson: Beta: Override Special:Contributions and Special:RecentChanges with mobile equivalents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94620 [17:11:02] (03CR) 10jenkins-bot: [V: 04-1] Beta: Override Special:Contributions and Special:RecentChanges with mobile equivalents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94620 (owner: 10Jdlrobson) [17:11:03] (03CR) 10Jdlrobson: "(4 comments)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94620 (owner: 10Jdlrobson) [17:14:59] (03PS4) 10Jdlrobson: Beta: Override Special:Contributions and Special:RecentChanges with mobile equivalents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94620 [17:55:26] (03PS1) 10Jdlrobson: Add make phplint to Makefile and pre commit hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95643 [17:55:40] (03PS2) 10Jdlrobson: Add make phplint to Makefile and pre commit hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95643 [18:00:52] kenanwang standup! [18:01:32] turning stuff on [18:01:38] cool cool [18:20:14] how has sf bat kid not got a wiki page yet? [18:20:55] o_O [18:21:05] awjr: lol at this https://twitter.com/BobNBC/status/401413714911318016/photo/1 [18:21:25] ohhhh is this the make a wish kid? [18:22:22] yeh it's happening right now [18:22:28] ha sweet! [18:26:11] hey guys I'm back [18:27:01] kenanwang jdlrobson so, https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1414 [18:27:14] jdlrobson: this is the ULS bug? [18:27:17] awjr: yeh [18:27:29] so basically what's happening is ALL pages have a language button due to a dummy language added in ULS [18:27:51] see http://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Ssasa&title=Ssasa [18:27:56] including special pages, like mobile options, kenanwang [18:28:00] it's a non existent language! [18:28:05] http://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:MobileOptions&returnto=Ssasa [18:28:27] jdlrobson: it looks like andre__ added it as a blocking bug for the next deployment [18:28:37] is this something for us to fix or for the language team to fix? [18:28:46] afaict this is something the lang team needs to deal with [18:28:49] awjr: yup. The only thing is I'm not sure how to fix it - preferably it should be done in ULS itself [18:28:51] (People are free to correct me. "Better safe than sorry" was my thought) [18:29:04] andre__: i think that was the right move [18:29:20] we could resort to a hack which goes through the array and scrubs out this node but if the node ever changes the bug will be back [18:29:21] it screws up mobile ux [18:29:27] (in the end it's up to greg-g to decide) [18:29:43] jdlrobson: normally i would say we should coordinate with the lang team, but i think they're all travelling and then focusing on the lang summit :| [18:30:01] yeh... [18:30:18] jdlrobson: maybe we should do a temporary hack doing what you say and so this doesn't have to block deployment, and then push the lang team to actually fix the issue. [18:30:47] we can override globals in mobile right? [18:30:55] dr0ptp4kt: are you ablet o acces the google doc now? [18:30:59] php global jdlrobson? [18:31:04] I think if we set $wgULSPosition to 'interlanguage' it will stop it from doing its thing [18:31:12] that would be the nicest hack right now [18:31:25] you can always override globals, which is part of why they are scary :p [18:31:40] * greg-g ignores backscroll for now, in meeting, ping me again if I need to read something [18:31:40] awjr: will it override it just for mobile if we put it in the right hook? [18:32:09] yeah; or we could override it only when we need to (eg on special pages) [18:32:13] awjr, it still says "you do not have permission to add comments". [18:32:17] (or is this an always thing?) [18:32:21] awjr: probably safer just to always override [18:32:35] jdlrobson: yeah i htink we could do that [18:32:55] jdlrobson: the code has changed quite a bit since i last really looked at it, but i htink i know where we could do that relatively safely [18:32:57] ok sounds like we have a good handle on what to do with this [18:33:02] let's go ahead and do it and alert the lang team [18:33:18] ok, next one jdlrobson, kenanwang: https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1415 [18:33:37] (jdlrobson, kenanwang im going to push the language bug to the highest priority [18:33:48] awjr: i'll do a fix now [18:33:50] if that's ok with you kenanwang [18:34:08] jdlrobson: for the lang bug or the notification bug? [18:34:56] hey Eloquence [18:35:07] dr0ptp4kt: ah, try now? [18:35:11] If you're talking about the lang bug I'm ok with changing to high priority and working on it now [18:35:35] awjr, there we go [18:35:37] awjr: lang [18:35:46] notifications bug - this is something I seem to see on desktop too actually [18:35:58] where I will read a notification but it doesn't register that I've read it [18:36:09] mmm might be an issue in Echo then? [18:36:15] is this specifically when refreshing the page or closing the overlay? [18:36:19] perhaps we can poke it and reassign if necessary? [18:36:21] (or both) [18:36:29] it sounds like when closing the overlay (hitting the left arrow to go back) [18:37:07] sounds like it's an issue in stable [18:38:26] (03PS1) 10Jdlrobson: Hack around ULS bug 57091 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95648 [18:38:29] awjr: there is code that's doing it. I can poke at it since i'm familiar with notification code [18:38:32] there is a fix for that bug.. [18:38:46] ok; kenanwang shall we just move it over to ready for dev this iteration? [18:38:51] jdlrobson: i'll look at the patchset in a min [18:39:10] sure [18:39:17] hi [18:39:19] yay [18:39:29] (03PS2) 10Jdlrobson: Hack around ULS bug 57091 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95648 [18:39:32] is it possible to put close tabs on the bottom of sections in mobile view as well as the top ? [18:39:33] ok kenanwang, if you have a chance, can you dbl check the priority order of stuff in 'ready for development' and adjust as necessary? [18:39:39] let's move it to ready for dev and poke at it a little maybe I'll add a note that I see it in desktop sometimes too [18:39:47] yep [18:40:10] thoughts as to what we do with the rest of the iteration? [18:40:24] kenanwang: code review is going to be the major problem [18:40:33] it's not worth taking on too much if it's not getting code reviewed [18:40:39] yeah, a lot of stuff is coded but we need to figure out how to get it merged [18:40:57] If finding stuff to do becomes a problem I /could/ work on the language overlay and other stuff from next iteration [18:40:58] i can help out with it some, but for serious client-side stuff there's not a lot i can do [18:41:29] upstreaming is another good idea [18:41:38] i suggest we take care of hygiene, bugs, and other useful projects (like the git log scripts, bingle, etc) [18:41:48] and yeah i guess i would consider upstreaming as part of 'other useful projects' [18:42:13] there's definitely no shortage of stuff to do ): [18:42:14] er [18:42:15] :) [18:42:45] kenanwang: maybe the three of us can sit down together on monday and review the bug backlog to dbl check priority and see if there's anything we ought to tackle [18:42:47] awjr: i find it ridiculous how much code we have in SkinMobile for footer generation... [18:43:04] hahaha iirc a lot of it is for hijacking/overriding what core does [18:43:46] Swob: jdlrobson or kenanwang can probably answer that question best. we used to provide a link to close sections at the bottom but we removed it a long time ago because hardly anyone used it [18:44:48] (03PS1) 10Jdlrobson: Hygiene: Remove unused code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95649 [18:45:17] yeah let's do hygiene today and then revisit on monday [18:45:26] awjr jdlrobson ^ [18:45:58] Swob: we took it out because it wasn't used much, is it a big annoyance to you? [18:46:10] it would help [18:46:11] Swob: we used to have close links but data we collected a while back showed no-one clicked on them... [18:46:38] by "close tab" I mean a button/link/etc that collapses one section of a page, like there is on the top [18:46:51] i dont remember them ever being there [18:47:03] on mobile [18:47:40] because some pages get huge [18:47:57] it was a looong time ago Swob, like over a year ago probably [18:47:58] Swob: i'm confused. You mean a button at the bottom that when clicked closes the section above it? [18:48:07] some background here - https://bugzilla.wikimedia.org/show_bug.cgi?id=45137 [18:48:15] although i can't find the link to the data [18:50:21] https://www.mediawiki.org/wiki/Event_logging/Mobile#Section_toggles < Swob [18:50:52] yeah [18:50:59] For instance section_1 was toggled open 28,264 times but jump back_1 (the equivalent at the bottom) only 405 [18:51:04] huge order of difference [18:51:05] is that ever going to be reenabled? [18:52:44] and it looks like it didnt work properly to begin with [18:53:02] Since usage is so low i personally wouldn't like to see it. To implement it previously we used some very messy code which fragmented our cache which we are trying to move away from [18:53:23] Swob: why do you say it didn't work properly? This data was taken long before the bug that was raised.. [18:53:44] so it worked properly and then stopped working prperly? [18:53:47] yes [18:53:54] and we decided to kill it since usage was low [18:53:54] ... [18:53:56] well whatever [18:54:06] so bsaically youre not willing to bring it back even as an option [18:54:34] Swob: this seems like something that would work better as a gadget type thing for those who want it [18:54:34] * YuviPanda waves at brion [18:54:40] i don't think it belongs in the core code [18:54:47] jdlrobson: gadgets don't load on Mobile [18:54:48] do they? [18:54:55] I'm still on Bart will be a couple minutes late [18:55:01] brion: ah, okay! [18:55:07] i'll check gerrit in the meantime [18:55:15] :) [18:55:29] im pretty sure nothing loads on mobile, afaik it doesnt even allow logging in [18:55:38] YuviPanda: not in their current form but i suspect one day they will when there is a need for them. For instance it should be relatively easy to run a mobile equivalent of user script like User:Jdlrobson/vector.js [18:55:49] Swob: you can login on mobile.. [18:56:23] jdlrobson: yeah, I was playing with different ways of showing random articles with violetto and could use similar .js files on Desktop. Can't do anything on Mobile yet :( [18:56:28] would be nice to have those enabled tho [18:56:38] it's only for logged in users mostly, so it doens't fragment too many things [18:56:38] YuviPanda: it should be pretty straightforward [18:56:41] yeah [18:56:59] YuviPanda: I've had the desire for that a few times as well [18:57:21] no "log in" that i can see. but ok [18:57:24] Swob out of interest: are you talking about the Wikipedia mobile app? [18:57:33] thanks for answering me even if the answer is just "no" [18:57:34] as that's a completely different kettle of fish if you are [18:57:35] yeah, but we need a better way of enabling it than saying 'go to common.js under your user namespace, enter this line' [18:57:55] no, i mean the mobile site of enwikipedia \ [18:58:03] Swob: what phone do you use? [18:58:35] jdlrobson: want me to file a bug, re: userscripts? [18:58:53] right now im on an Android but it's the same on all cellphones that Ive used [18:58:53] YuviPanda: sure it won't get me to do it any quicker though ;-) [18:59:06] and for that matter, on my Windows PC when i load the mobile site it does the same thing [18:59:08] Swob: when you click the menu icon in the top left login should be available from that menu [18:59:22] no menu thati can see [18:59:26] https://en.m.wikipedia.org/wiki/Special:MobileMenu [18:59:28] ^ looks like that [18:59:42] I'm 3 minutes out be right in guys :) [18:59:56] oh ok [19:00:05] jdlrobson: heh, sure [19:00:06] well i wouldnt expect three horizontal lines to mean "log in" [19:00:26] ohh.. interesting. So you didn't realize the three horizontal lines were a menu button [19:00:27] ? [19:01:31] well the menu button i see is next to the search bar [19:01:38] i figured it was just part of the search bar [19:02:04] ^ violetto kaity|away you will probably be interested in this conversation (they are our designers) [19:03:29] jdlrobson: what's happening [19:03:54] violetto: interestingly swob has revealed that the icon we use for the main menu is not very discoverable [19:04:21] jdlrobson: the one next to search bar? [19:04:22] it makes me wonder if the icon doesn't 'translate' well - i remember thedj (i think) raising this previously [19:04:25] violetto: yes [19:05:24] violetto: swob figured it was part of the search bar and didn't provide things like login etc [19:06:11] Swob: where do you expect the login etc to be when you were searching for it? [19:06:56] dont talk to me like Im stupid [19:08:11] I dont come here to make enemies, I just wanted someone to answer my question [19:08:42] and i got that answer and said "thank you" [19:09:46] Swob: yikes, i apologize if that caused misunderstanding. i asked because i wanted to understand why you wouldn't have found it next to the search bar under the "hamburger" icon, since it's a typical place for actions like that to be found. [19:09:55] if youre not going to provide a help page or anything for a mobile website, then dont be surprised when people cant find somethign that isnt even labeled [19:11:03] Swob: i needed to know where you were expecting to find the "log in" because we might have placed it in a less convenient area, so knowing where you expected to see it would really help. [19:11:40] i didnt expect to find it anywhere [19:11:53] all there is on the screen is a search bar and the main body of the page [19:12:42] so i figured it was still read only [19:13:47] Swob: i see what you mean. so the "hamburger" icon did not seem like a tappable area, correct? [19:14:04] Swob: we can fix that [19:14:31] i think writing a help file would be better but OK [19:14:34] Swob: Apologies that you felt we were talking to you like you are stupid. I assure you that's not the case (one of the problems with text based communication). You've raised a really important issue that we are not aware of and want to understand better. [19:15:16] brion: https://trello.com/c/bf4UJasl/7-3-as-a-commuter-with-intermittent-connectivity-i-want-the-article-i-m-reading-to-still-be-available-when-i-lose-connection-so-i- [19:15:45] Swob: where would you expect a help page to be? [19:16:06] yeah lets just forget it OK [19:16:08] would it be at the bottom / top / linked to from the homepage? [19:17:55] Swob: I would really value your input as this is likely to effect other people and could be losing us editors etc [19:27:51] https://www.mediawiki.org/wiki/Wikipedia_App_Design [19:28:35] eh jdlrobson https://gerrit.wikimedia.org/r/#/c/95648/2/includes/MobileFrontend.hooks.php will cause problems in desktop [19:28:51] there's likely a better place for it - lemme take a look through the hooks [19:30:29] i guess the trick is to override early enough in the call chain [19:31:11] jdlrobson: is your local dev instance configured to replicate the bug? (mine is not) [19:31:41] oh shit .. yeh that's not mobile only [19:31:45] awjr: yep mine is [19:31:46] it's easier [19:31:48] *easy [19:31:48] jdlrobson: ok [19:31:57] try doing it in onRequestContextCreatSkin() [19:32:01] YuviPanda: good luck on your test! [19:32:02] just installed UniversalLanguageSelector and add $wgULSPosition = 'interlanguage'; to LocalSettings [19:32:06] like maybe on line 60 [19:32:08] YuviPanda: make us proud! [19:32:30] awjr: can you -1 it to that effect? i'm going to need to switch locations soon. [19:32:41] yeah jdlrobson, in the mean time ill get uls instaleld [19:32:50] is uls its own extension? [19:33:32] awjr: yup [19:33:39] (03CR) 10Awjrichards: [C: 04-1] "this will override the global var for desktop. we should probably put it in onReqeustContextCreateSkin() when we're sure we're in mobile o" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95648 (owner: 10Jdlrobson) [19:36:15] jdlrobson: kenanwang heh, yeah - thanks! :D [19:40:52] mhurd: hey? [19:41:33] awjr: good first real meeting in R61 [19:41:53] nice tfinc how was the jabra? [19:41:56] sadly the jabber was not as consistent as the chat 150 [19:42:01] it did better or it did a lot worse [19:42:03] YuviPanda: yo [19:42:08] not very consistent according to YuviPanda [19:42:37] i have 20min in there in case you want to hear it [19:42:42] mhurd: where's the iOS app at? [19:42:51] one sec... [19:43:14] YuviPanda: https://gerrit.wikimedia.org/r/apps/ios/wikipedia [19:43:24] i see it [19:43:35] mhurd: ah, nice! bridge code is done [19:45:26] awjr: --^ [19:45:44] tfinc: now's not a good time, trying to fix an issue before i head out for lunch [19:45:53] k [19:45:59] thanks tho :) [19:47:29] (03PS3) 10Awjrichards: Hack: Hack around ULS issue [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95648 (owner: 10Jdlrobson) [19:48:50] (03CR) 10Awjrichards: "I moved the override into MobileFrontendHooks::onReqestContextCreateSkin() after we are sure we're in mobile mode. Tested with ULS install" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95648 (owner: 10Jdlrobson) [19:52:52] (03PS1) 10Dr0ptp4kt: WIP: DO NOT MERGE! Supported flagged revisions of W0 configurations. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/95657 [19:53:14] YuviPanda: ok got stuff in gerrit for me to look at? [19:53:21] brion: nope, not working as such [19:53:26] btw monte's got some AWESOME ideas for a table of contents-ish view [19:53:30] ok [19:53:30] just wanted to check in on iOS fixes [19:53:32] study for that test dude :D [19:53:35] s/fixes/status/ [19:53:39] brion: yeah, doing. 2 units of 5 done [19:53:42] woo [19:53:46] (03CR) 10Dr0ptp4kt: [C: 04-2] "DO NOT MERGE YET! SEE COMMIT MESSAGE ABOUT MEDIAWIKI-CONFIG AND POSSIBLE TUNING!" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/95657 (owner: 10Dr0ptp4kt) [19:53:48] brion: what ideas? pictures! [19:54:21] i shoulda recorded him talking and drawing on his little pad of paper, he was very excited :D [19:54:28] brion: hehe :D [19:55:22] YuviPanda: looks like i didn't have the HD setting for our hangout [19:55:27] i changed it for my account [19:55:27] ah! [19:55:31] i look far sharper [19:55:32] that explains the blurryness [19:55:38] can you rejoin and let me know if it looks different ? [19:55:40] same hangout [19:55:48] tfinc: sure, moment [19:56:39] (03PS1) 10Mhurd: Added tests for dependent MWNetworkOps. Re-org of dir structure. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/95659 [19:56:47] \o/ [20:05:37] brion: this look ok? (for getting thumbnail links for articles for "cat" and "cattle") /w/api.php?action=query&prop=pageimages&format=json&piprop=thumbnail%7Cname&pithumbsize=25&pilimit=10&titles=cat%7Ccattle [20:06:09] mhurd: fwiw, I'm grabbing only like 5 results out of opensearch :P [20:06:21] brion: any progress ont he wikidata patch? [20:06:59] YuviPanda: ya def need to limit # [20:10:21] mhurd: yeah looks about right [20:10:27] brion: yay! [20:10:36] if you use the exact terms returned from OpenSearch it shouldn't need to include the 'normalized' sections [20:10:39] which makes the lookup easier :D [20:11:05] and.... make sure we multiply the target thumbnail size by the display density [20:21:38] NetworkOnMainThreadException whee [20:28:01] dr0ptp4kt: i looked at the patch briefly, will look closer once you tell me its good - in the mean time, hacking away on the python version of SMS prism system :) [20:30:36] (03PS1) 10Yuvipanda: Exit the activity if there is no pages left to pop. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95690 [20:30:40] brion: ^ [20:30:42] just one patch [20:31:12] YuviPanda: did you have a fix for the crash-on-cancel-search-request bug? i don't see any clean way to abort a request using that http library [20:31:16] other than killing the thread [20:31:25] brion: nope, didn't look into it yet. [20:31:37] brion: will probably need a bit of poking around and integration with okhttp [20:31:45] brion: I'll look at it when I'm back [20:31:48] remember to study for your exam, you're not on the clock atm :D [20:31:54] yes, yes [20:31:56] i know [20:32:00] i'll go away now [20:32:02] :D [20:32:06] do merge it but :D [20:32:10] wll do [20:33:44] (03CR) 10Brion VIBBER: [C: 032 V: 032] Exit the activity if there is no pages left to pop. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95690 (owner: 10Yuvipanda) [20:37:54] (03PS1) 10Brion VIBBER: Workaround for crash when typing too fast in search box [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95692 [20:39:53] (03PS3) 10JGonera: Separate stable and beta search JS code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94078 [20:39:54] (03PS2) 10JGonera: Story 1099: Better search UX [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95318 [20:40:25] (03PS1) 10JGonera: Hygiene: Remove unused LESS variables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95693 [20:40:43] (03PS1) 10JGonera: Hygiene: Merge @contentMarginLeft/Right into @contentMargin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95694 [20:41:43] (03CR) 10JGonera: Story 1099: Better search UX [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95318 (owner: 10JGonera) [21:05:09] (03PS1) 10Brion VIBBER: work in progress -- search task tweaks [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95700 [21:06:12] awjr_lunch: back sorry that took longer then expected [21:07:26] no worries jdlrobson, just back myself [21:07:49] too many distractions [21:08:54] btw awjr https://gerrit.wikimedia.org/r/#/c/95648/3/includes/MobileFrontend.hooks.php < i hate this habit we have of returning early - it really makes code hard to follow and we should get out of it [21:09:14] the rest should be wrapped in an else statement (obviously not part of this patch but made me think) [21:10:09] (03CR) 10Jdlrobson: [C: 032] Hack: Hack around ULS issue [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95648 (owner: 10Jdlrobson) [21:10:51] jdlrobson: the prevailing school of thought in the php world, afaik, is that early returns are preferable [21:10:59] really?! [21:11:01] aye [21:11:03] they are so unreadable [21:11:10] i think it's even in the mediawiki conventions documentation [21:11:19] (03Merged) 10jenkins-bot: Hack: Hack around ULS issue [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95648 (owner: 10Jdlrobson) [21:11:28] well, early return is different, i think, than arbitray returns in the middle of methods [21:12:05] i forget how PHP processing works too, iirc there's some performance benefit to the approach rather than lots of if/else blocks, but i cant remember for sure id ahve to look it up [21:12:20] personally, i find the early return much more readable than mega if blocks [21:12:27] in fact, i hate long if/else blocks. [21:12:37] i find them very difficult to read [21:13:12] i think it's one of those things that divide people [21:13:18] :) [21:13:28] i think multiple returns leads to mistakes [21:13:40] for instance say i put something underneath a return to statement thinking it will never get run.. [21:13:54] if that return statement is then removed, suddenly my code is running in an environment it shouldn't [21:14:02] it just offers more protection imo [21:14:24] depending on the instance, i can agree with that [21:14:40] terminating a method early though can be useful [21:14:46] http://stackoverflow.com/questions/36707/should-a-function-have-only-one-return-statement [21:14:52] see divided :) [21:15:07] "Structured programming says you should only ever have one return statement per function. This is to limit the complexity. Many people such as Martin Fowler argue that it is simpler to write functions with multiple return statements." [21:17:53] so in the case of that particular funciton, what would you prefer to see, jdlrobson? [21:26:03] (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove unused LESS variables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95693 (owner: 10JGonera) [21:26:22] (03PS2) 10Jdlrobson: Hygiene: Merge @contentMarginLeft/Right into @contentMargin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95694 (owner: 10JGonera) [21:26:40] (03Merged) 10jenkins-bot: Hygiene: Remove unused LESS variables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95693 (owner: 10JGonera) [21:27:40] (03CR) 10Jdlrobson: [C: 032] Hygiene: Merge @contentMarginLeft/Right into @contentMargin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95694 (owner: 10JGonera) [21:28:11] (03Merged) 10jenkins-bot: Hygiene: Merge @contentMarginLeft/Right into @contentMargin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95694 (owner: 10JGonera) [21:28:45] (03CR) 10Jdlrobson: Make child overlay hide the parent forcefully (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94468 (owner: 10JGonera) [21:30:54] (03PS3) 10Jdlrobson: Make child overlay hide the parent forcefully [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94468 (owner: 10JGonera) [21:31:25] (03CR) 10Jdlrobson: [C: 032] Make child overlay hide the parent forcefully [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94468 (owner: 10JGonera) [21:31:43] awjr: sorry just saw your message - i prefer use of an else statement in these situations [21:31:59] so it's fine to return above but i'd rather the rest of the function was wrapped in an else [21:32:15] it makes it clearer that it shouldn't be run in that circumstance [21:32:39] (03Merged) 10jenkins-bot: Make child overlay hide the parent forcefully [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94468 (owner: 10JGonera) [21:33:54] i can see that, but then you have to read the entire function to know what's ultimately going to happen. the early return makes it readily apparent that in the case where we're not in mobile mode, nothing else will happen, so i don't need to worry about the rest of the function. but as you say, this is one of those things like https://en.wikipedia.org/wiki/Toilet_paper_orientation [21:34:08] (03PS2) 10Brion VIBBER: work in progress -- search task tweaks [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95700 [21:34:46] (03CR) 10Jdlrobson: "This should really be merged before Thursday (beta features launch)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95568 (owner: 10Jdlrobson) [21:34:49] (03PS3) 10Jdlrobson: Don't load beta features code on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95568 [21:35:17] (03PS2) 10Jdlrobson: Story 1360: Add paging to Special:History and enable link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95561 [21:36:04] awjr: i think that's careless though [21:36:17] https://en.wikipedia.org/wiki/Binaural_beats [21:36:18] awjr: if someone is focused on removing that behavior they may not pay attention to the rest of the code [21:36:19] oops [21:36:23] https://en.wikipedia.org/wiki/Toilet_paper_orientation [21:36:59] i can imagine making gross mistakes with a long if/else statement too [21:38:27] (03PS6) 10Jdlrobson: Story 1347 1/2: Use new overlay for this page has issues [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95314 [21:38:58] yeh i guess it does come down to toilet paper [21:39:04] (03CR) 10jenkins-bot: [V: 04-1] Story 1347 1/2: Use new overlay for this page has issues [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95314 (owner: 10Jdlrobson) [21:39:07] :) [21:39:53] (03PS7) 10Jdlrobson: Story 1347 1/2: Use new overlay for this page has issues [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95314 [21:40:06] (03PS4) 10Jdlrobson: Hygiene: Cleanup enwp.less prepare to destroy it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95452 [21:43:47] jdlrobson: do you want to play around with git logs and/or bingle soon [21:43:49] ? [21:43:56] im close to a point where i can focus on that stuff [21:44:03] sure awjr just doing some rebasing based on some ju ju changes [21:44:11] cool holler when you're ready [22:01:10] (03PS4) 10Jdlrobson: Story 1347 2/2: Update this page has issues in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95453 [22:02:43] hi [22:02:44] (03PS2) 10Jdlrobson: Strengthen .tutorial selector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95636 [22:10:15] tfinc: mmm good oj [22:10:19] :) [22:10:36] (03PS3) 10Jdlrobson: Story 1345: Redesign notifications overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95482 [22:11:18] (03PS5) 10Jdlrobson: Alpha: Use the same chrome on special pages as article pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94435 [22:11:30] awjr: ready for pairing [22:11:35] cool [22:11:56] so on the one hand ive been dying to get back to bingle but i think the more pressing thing is to get the git log stuff automated [22:12:23] sorry for being angry earlier [22:14:03] Swob: no worries.. i'm really really sorry that i made you feel that way [22:14:29] awjr: git log it is then [22:14:33] but i really do think adding a help meny would be a good idea [22:14:37] *menu [22:16:59] Swob: yeh i'm very interested in the idea of help - the team has talked about it a few times but doesn't know where to start [22:17:16] one of the issues is where to put it, another is when to show it, and another is what to say [22:17:37] I was also wondering that if the search bar was a button as well whether the header would feel more like a clickable menu [22:17:51] * a search button instead of a search box [22:18:05] i also wonder if styling the icon differently would make it more obvious it is a button [22:18:18] it's actually really topical as we are thinking about redesigning the top bar [22:18:55] Swob: see https://www.dropbox.com/sh/ose6jehykg82j78/Afo_WB_GPK#lh:null-search-overlay-01.png [22:19:04] i could imagine turning it into a bulleted list or making a clearer visual separation between it and the search might help [22:19:21] awjr: yeh in the new design we have a vertical line between the search box and a W icon - whether that would help more i'm not sure [22:19:43] i still think the W needs to look more clickable [22:19:55] is the W supposed to replace the hamburger? [22:20:00] awjr: correct [22:20:09] to me that's even less obvious than the burger :| [22:20:27] awjr: agreed… we used to have a W and no one knew it's purpose [22:20:42] it looks sexy though :) [22:20:51] but, not all projects start with the letter W [22:20:53] people rejoiced that mobile had a random button when we moved to the hamburger despite the fact it had been hidden behind the W icon for a whole year [22:21:08] (i think we have a tendency to be overly-focussed on wikipedia) [22:21:10] Swob awjr: i could also imagine showing a help icon in place of the echo icon for non logged out users that shows people around (cc violetto ) [22:21:32] jdlrobson: like an interactive tutorial? [22:21:42] yeh similar to the uploads tutorial [22:21:53] yeah [22:21:53] it could also guide people into why they should have an account etc [22:22:22] yeah, i've seen a lot of apps do that [22:22:34] i dunno that i've seen a web app do it, but i think it could be effective [22:23:01] I think the help icon is universal and it's worth a go [22:26:45] awjr: anyway.. how do you want to work on the deploy scripts? [22:27:03] eh sorry jdlrobson got distracted telling jcmish a story [22:27:12] shall we hangout and chat? [22:27:40] and first - do you have the git log scripts checked out? [22:27:57] i think we should talk through existing state and figure out what to do next [22:28:02] sure send me the hangout link and i'm there [22:28:08] i don't have the git log scripts [22:28:11] will they take long to check out? [22:28:15] :D [22:28:27] no, it's tiny jdlrobson [22:28:29] (03CR) 10Jdlrobson: [C: 04-1] "This looks fricking awesome! :D" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95318 (owner: 10JGonera) [22:28:34] checkout the mediawiki/release.git repo [22:28:57] (03PS2) 10Jdlrobson: Redirect action=history links to mobile view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95562 [22:30:06] jdlrobson: when you're ready: https://plus.google.com/hangouts/_/76cpiijijqrpb3b4gicibb907s?authuser=1&hl=en [22:32:52] yurik yurik_ you around? [22:33:33] dr0ptp4kt: no, about to leave, whats up? [22:34:47] yurik_, good you get going. was just gonna say that https://gerrit.wikimedia.org/r/#/c/95662/ incorporates the notion of setting the vars before loading the ZeroRatedMobileAccess.php script (again, that change is about zero-risk), but it also would enable us to turn on FlaggedRevs. was hoping you could review and then we put that one in on wednesday. [22:35:19] dr0ptp4kt: will try to get to it on wkend [22:35:22] yurik_ we could also push in the mainline ZRMA extension code to go along with it if i have it complete by then, but i don't know if i will. i'm about to switch contexts to firefox os for a couple of days. [22:35:22] off i go [22:35:29] don't worry about it man. just enjoy the weekend! take care! [22:35:34] ttyl yurik_ [22:35:35] :) [22:35:37] ltr [22:35:47] enjoy :) [22:35:52] peace [22:42:59] (03Abandoned) 10Brion VIBBER: Workaround for crash when typing too fast in search box [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95692 (owner: 10Brion VIBBER) [22:46:57] jdlrobson: for the API stuff, how do you feel about requiring the requests library? [22:47:06] it makes life a helluva lot easier for making http requests [22:47:40] awjr: Httplib you mean? [22:47:53] jdlrobson: no; http://www.python-requests.org/en/latest/ [22:47:55] i tend to use https://code.google.com/p/httplib2/ [22:48:05] feel free awjr [22:48:08] :D [22:52:08] awjr: first commit on its way [22:52:28] i miss writing python [22:52:32] awjr: https://gerrit.wikimedia.org/r/95718 [22:53:01] argh pep8 hey [22:53:38] hhaha [22:53:51] (03PS3) 10Brion VIBBER: Refactor SearchArticlesTask to produce a base ApiTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95700 [23:01:41] "foreach not applicable to java.util.Iterator" [23:01:43] saywaaaaaat [23:02:54] argh friggin api [23:10:48] i am making a post request but getting an error that says i must login with a post request :( [23:15:04] wtf [23:15:40] awjr: is it getting redirected, by any chance? [23:15:52] oh [23:15:57] that could be, that would turn it into a get, right? [23:16:01] yeah [23:16:06] no non-JS way to forward a POST [23:16:10] im trying to https://mediawiki.org/w/api.php [23:16:13] that shouldn't redirect [23:16:24] i'm betting that redirects to https://www.mediawiki.org/w/api.php [23:16:41] AHHH you're right [23:16:47] [23:17:02] /o\ [23:17:31] hahaha wow thanks brion [23:17:40] jdlrobson: hey I wanted to talk to you about something [23:17:43] yay [23:17:46] i had even tried with a efw different libraries [23:17:48] you got availability in a bit? [23:17:50] heh :D [23:19:16] kenanwang: sure [23:19:18] what's up [23:19:28] awjr: wikitext success! [23:19:34] woohoo! [23:19:36] well the user profile write card [23:19:42] jdlrobson: still working on the api bits [23:19:50] we need some way for users to review those [23:20:17] they need to get surfaced in recent changes or something [23:20:31] kenanwang: i think they do... [23:20:38] kenanwang: they should be normal wiki pages [23:20:47] any way to check on that? [23:20:58] I thought that that might be the case but I wanted to make sure [23:22:14] kenanwang: seems broken though... [23:22:25] i'm not sure how this got through testing... [23:22:39] i just edited by profile on mediawiki.org and it saved but didn't update the screen :-S [23:22:40] https://m.mediawiki.org/wiki/Special:UserProfile/Jdlrobson [23:22:47] https://m.mediawiki.org/wiki/User:Jdlrobson/UserProfileIntro < kenanwang [23:23:21] https://m.mediawiki.org/w/index.php?title=Special:History/User:Jdlrobson/UserProfileIntro [23:24:17] awjr: https://gerrit.wikimedia.org/r/95721 [23:25:38] hmmm weird [23:33:45] brion: when u have a sec... [23:35:05] (03PS1) 10Brion VIBBER: Work in progress: PageQueryTask & PageImagesTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95722 [23:42:45] (03PS2) 10Brion VIBBER: Work in progress: PageQueryTask & PageImagesTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95722 [23:49:27] awjr: all finished here [23:49:33] awjr: https://gerrit.wikimedia.org/r/95732 [23:50:23] nice jdlrobson, sitll working through api stuff will look when im done [23:50:46] i forgot that logging in to the api is not totally straightforward :p